[Okular-devel] [okular] [Bug 353400] Okular's annotations (stored directly in the pdf file) won't show in a few other pdf readers

[Fabio D';Urso]

https://bugs.kde.org/show_bug.cgi?id=353400

Fabio D'Urso  changed:

   What|Removed |Added

 CC||fabiodu...@hotmail.it
 Resolution|FIXED   |INVALID

--- Comment #7 from Fabio D'Urso  ---
Yes, unlike other annotators, Okular (Poppler) does not attach any appearance
stream to annotations.
Appearance streams are optional according to PDF specs, and PDF readers should
in theory be able to render annotations without them. As you said, Firefox's
plugin is basic and probably does not have proper annotation support.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 119894: Only update zoomFactor for current page

[Fabio D';Urso]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119894/#review65121
---


So we had a loop that set d->zoomFactor repeatedly, I didn't know that, I guess 
the last iteration was the one that won :P

I've tried your patch on the document from the bug and I'm noticing this issue: 
if you choose, say, "fit width" on the first page, go to the second page and 
zoom out, you actually zoom in. Is it intended behavior? I would expect zoom 
out to always reduce the page size on the screen.

What about moving the "use the current page as reference" thing when the user 
actually changes zoom, so that zoom in/out always take the real current page as 
reference? Something like this:
@@ -3660,6 +3660,10 @@ void PageView::updateZoom( ZoomMode newZoomMode )
 zoomValue[13] = zoomFactorFitWidth;
 zoomValue[14] = zoomFactorFitPage;
 qSort(zoomValue.begin(), zoomValue.end());
+
+if ( d->items.count() > 0 )
+newFactor = d->items[ qMax( 0, (int)d->document->currentPage() 
) ]->zoomFactor();
+
 QVector::iterator i;
     if ( newZoomMode == ZoomOut )
 {

- Fabio D'Urso


On Aug. 21, 2014, 10:08 p.m., Albert Astals Cid wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119894/
> ---
> 
> (Updated Aug. 21, 2014, 10:08 p.m.)
> 
> 
> Review request for Okular, Markus Trippelsdorf and Tingnan Zhang.
> 
> 
> Bugs: 335819
> http://bugs.kde.org/show_bug.cgi?id=335819
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> In the wild world where each page is of different size, only use the current 
> page to update the zoom factor in updateItemSize
> 
> 
> Diffs
> -
> 
>   ui/pageview.cpp 8ceafae 
> 
> Diff: https://git.reviewboard.kde.org/r/119894/diff/
> 
> 
> Testing
> ---
> 
> Works for me with https://bugs.kde.org/attachment.cgi?id=88318
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 310154] inline note is loosing UTF-8 characters

[Fabio D';Urso]

https://bugs.kde.org/show_bug.cgi?id=310154

Fabio D'Urso  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 CC||fabiodu...@hotmail.it
 Resolution|--- |DUPLICATE

--- Comment #6 from Fabio D'Urso  ---


*** This bug has been marked as a duplicate of bug 305534 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 305534] Anotation don't show all non-ASCII letters

[Fabio D';Urso]

https://bugs.kde.org/show_bug.cgi?id=305534

Fabio D'Urso  changed:

   What|Removed |Added

 CC||marcela.maslan...@gmail.com

--- Comment #4 from Fabio D'Urso  ---
*** Bug 310154 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 312398] PDF: Buttons are out of function and have no button image

[Fabio D';Urso]

https://bugs.kde.org/show_bug.cgi?id=312398

Fabio D'Urso  changed:

   What|Removed |Added

 Status|UNCONFIRMED |CONFIRMED
 CC||fabiodu...@hotmail.it
Version|0.15.3  |0.19.0
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 309734] Okular crashes on exit when print preview was shown on attached PDF

[Fabio D';Urso]

https://bugs.kde.org/show_bug.cgi?id=309734

Fabio D'Urso  changed:

   What|Removed |Added

 Status|UNCONFIRMED |CONFIRMED
 CC||fabiodu...@hotmail.it
Version|unspecified |0.19.0
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 305534] Anotation don't show all non-ASCII letters

[Fabio D';Urso]

https://bugs.kde.org/show_bug.cgi?id=305534

Fabio D'Urso  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||fabiodu...@hotmail.it
  Component|general |PDF backend
 Resolution|--- |UPSTREAM

--- Comment #3 from Fabio D'Urso  ---
It's a Poppler issue. I'm sure there is already some Poppler bug about this.
Anyway, thanks for caring about Okular :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 330527] Annotations: Inline Note not shows cyrillic symbols.

[Fabio D';Urso]

https://bugs.kde.org/show_bug.cgi?id=330527

Fabio D'Urso  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
 CC||fabiodu...@hotmail.it
 Resolution|--- |DUPLICATE

--- Comment #3 from Fabio D'Urso  ---
It's a Poppler issue. I'm sure there is already some Poppler bug about this.

*** This bug has been marked as a duplicate of bug 305534 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 305534] Anotation don't show all non-ASCII letters

[Fabio D';Urso]

https://bugs.kde.org/show_bug.cgi?id=305534

Fabio D'Urso  changed:

   What|Removed |Added

 CC||ploo...@gmail.com

--- Comment #2 from Fabio D'Urso  ---
*** Bug 330527 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 304156] mouse icon change when holding annotation tool

[Fabio D';Urso]

https://bugs.kde.org/show_bug.cgi?id=304156

Fabio D'Urso  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||fabiodu...@hotmail.it
 Resolution|--- |FIXED

--- Comment #1 from Fabio D'Urso  ---
It seems to work fine here with Okular 0.19.0 (KDE 4.13.0). We have changed a
few this about mouse icon updates and I think this is one of them.
Thanks for caring about Okular :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 300492] Okular got stuck reloading and crashed on quit

[Fabio D';Urso]

https://bugs.kde.org/show_bug.cgi?id=300492

Fabio D'Urso  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDSINFO
 CC||fabiodu...@hotmail.it
 Resolution|--- |WAITINGFORINFO

--- Comment #2 from Fabio D'Urso  ---
Can you please try if this still happens with Okular >= 0.19.0 ( KDE >= 4.13.0
)?
Thanks for caring about Okular :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 300400] searching for text in rotated content doesn't work

[Fabio D';Urso]

https://bugs.kde.org/show_bug.cgi?id=300400

Fabio D'Urso  changed:

   What|Removed |Added

 Status|UNCONFIRMED |CONFIRMED
 CC||fabiodu...@hotmail.it
Version|unspecified |0.19.0
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 299359] TAB character has no impact in annotations

[Fabio D';Urso]

https://bugs.kde.org/show_bug.cgi?id=299359

Fabio D'Urso  changed:

   What|Removed |Added

Version|0.16.1  |0.19.0

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 299359] TAB character has no impact in annotations

[Fabio D';Urso]

https://bugs.kde.org/show_bug.cgi?id=299359

Fabio D'Urso  changed:

   What|Removed |Added

 Status|UNCONFIRMED |CONFIRMED
 CC||fabiodu...@hotmail.it
 Ever confirmed|0   |1

--- Comment #2 from Fabio D'Urso  ---
I confirm that the bug happens both in PDF documents (which are rendered by
Poppler) and in non-PDF documents.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 298561] okular 0.14.2 on KDE 4.8.2 fails to open chm files: No plugin for mimetype '"application/octet-stream"'

[Fabio D';Urso]

https://bugs.kde.org/show_bug.cgi?id=298561

Fabio D'Urso  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDSINFO
 CC||fabiodu...@hotmail.it
 Resolution|--- |WAITINGFORINFO

--- Comment #32 from Fabio D'Urso  ---
Any news about this bug? Can any of you guys that could reproduce this bug
please test if it still happens with Okular >= 0.19.0 (KDE >= 4.13.0)?
Thanks for caring about Okular :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 298142] Okular crashed while reloading dvi file

[Fabio D';Urso]

https://bugs.kde.org/show_bug.cgi?id=298142

Fabio D'Urso  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDSINFO
 CC||fabiodu...@hotmail.it
 Resolution|--- |WAITINGFORINFO

--- Comment #1 from Fabio D'Urso  ---
Can you please try if this still happens with Okular >= 0.19.0 ( KDE >= 4.13.0
)?
Thanks for caring about Okular :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 297679] Image form not filling

[Fabio D';Urso]

https://bugs.kde.org/show_bug.cgi?id=297679

Fabio D'Urso  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||fabiodu...@hotmail.it
 Resolution|--- |INVALID

--- Comment #2 from Fabio D'Urso  ---
Closing because the requested information hasn't been provided by the OP.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 290763] Okular crashed when a page was turned.

[Fabio D';Urso]

https://bugs.kde.org/show_bug.cgi?id=290763

Fabio D'Urso  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||fabiodu...@hotmail.it
 Resolution|--- |INVALID

--- Comment #3 from Fabio D'Urso  ---
Closing because the requested information hasn't been provided by the OP.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 289468] PDF Form entry not displaying

[Fabio D';Urso]

https://bugs.kde.org/show_bug.cgi?id=289468

Fabio D'Urso  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||fabiodu...@hotmail.it
 Resolution|--- |WORKSFORME

--- Comment #7 from Fabio D'Urso  ---
If I understand corrently: you are typing "books books books" in Okular, but it
disappears when you click on Hide forms.
It seems to work here, please reopen if I misunderstood and/or you can
reproduce the issue with recent Okular and Poppler versions (eg poppler >= 0.24
and Okular >= 0.19.0 [ie KDE >= 4.13.0]).
Thanks for caring about Okular :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 287457] EPUB document gets messy when highlighting text

[Fabio D';Urso]

https://bugs.kde.org/show_bug.cgi?id=287457

Fabio D'Urso  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||fabiodu...@hotmail.it
 Resolution|--- |FIXED

--- Comment #4 from Fabio D'Urso  ---
It seems to work now. Please reopen this bug if you can reproduce it with
Okular >= 0.19.0 (KDE >= 4.13.0).
Thanks for caring about Okular :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 286966] okular crashed after changing page and maximizing

[Fabio D';Urso]

https://bugs.kde.org/show_bug.cgi?id=286966

Fabio D'Urso  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||fabiodu...@hotmail.it
 Resolution|--- |INVALID

--- Comment #2 from Fabio D'Urso  ---
Closing because the requested information hasn't been provided.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 286331] Okular crashed

[Fabio D';Urso]

https://bugs.kde.org/show_bug.cgi?id=286331

Fabio D'Urso  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDSINFO
 CC||fabiodu...@hotmail.it
  Component|general |DVI backend
 Resolution|--- |WAITINGFORINFO

--- Comment #2 from Fabio D'Urso  ---
Can you please try if this still happens with Okular >= 0.19.0 ( KDE >= 4.13.0
)?
Thanks for caring about Okular :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 285308] Sometimes when changing window / page size the page doesn't redraw at the new resolution

[Fabio D';Urso]

https://bugs.kde.org/show_bug.cgi?id=285308

Fabio D'Urso  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||fabiodu...@hotmail.it
 Resolution|--- |WORKSFORME

--- Comment #3 from Fabio D'Urso  ---
It seems to work fine here with Okular 0.19.0 (KDE 4.13.0).
If you can still reproduce this behavior, please reopen this bug.
Thanks for caring about Okular :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 284428] When compiled without libspectre print preview displays the postscript code

[Fabio D';Urso]

https://bugs.kde.org/show_bug.cgi?id=284428

Fabio D'Urso  changed:

   What|Removed |Added

 Status|UNCONFIRMED |CONFIRMED
 CC||fabiodu...@hotmail.it
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 283146] Okular becomes slow when review side panel opened

[Fabio D';Urso]

https://bugs.kde.org/show_bug.cgi?id=283146

Fabio D'Urso  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||fabiodu...@hotmail.it
 Resolution|--- |FIXED

--- Comment #1 from Fabio D'Urso  ---
The way annotations are rendered has changed since then, and I can't notice any
speed difference in Okular >= 0.19.0 ( KDE >= 4.13.0 ).
If you can still reproduce it, please reopen this bug.
Thanks for caring about Okular :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 282970] Okular crashed after 3 open/close in short time.

[Fabio D';Urso]

https://bugs.kde.org/show_bug.cgi?id=282970

Fabio D'Urso  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||fabiodu...@hotmail.it
  Component|general |PDF backend
 Resolution|--- |WORKSFORME

--- Comment #6 from Fabio D'Urso  ---
Closing because it works here and libpoppler has changed a lot since 2011.
Please reopen this bug if you can reproduce it with newer poppler versions.
Thanks for caring about Okular :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 282965] Okular (chm file is open) crahsed when quit

[Fabio D';Urso]

https://bugs.kde.org/show_bug.cgi?id=282965

Fabio D'Urso  changed:

   What|Removed |Added

  Component|general |CHM backend

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 282965] Okular (chm file is open) crahsed when quit

[Fabio D';Urso]

https://bugs.kde.org/show_bug.cgi?id=282965

Fabio D'Urso  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDSINFO
 CC||fabiodu...@hotmail.it
 Resolution|--- |WAITINGFORINFO

--- Comment #11 from Fabio D'Urso  ---
Can you try with Okular >= 0.19.0 (KDE >= 4.13.0), can you still reproduce this
issue?
Thanks for caring about Okular :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 282656] Okular crashed while trying to load an epub file

[Fabio D';Urso]

https://bugs.kde.org/show_bug.cgi?id=282656

Fabio D'Urso  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||fabiodu...@hotmail.it
  Component|general |EPub backend
 Resolution|--- |UPSTREAM

--- Comment #7 from Fabio D'Urso  ---
I can't reproduce it. Seems like it's been fixed in recent versions.
Thank you for caring about Okular :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 280507] The black text underline acts as text deletion

[Fabio D';Urso]

https://bugs.kde.org/show_bug.cgi?id=280507

Fabio D'Urso  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDSINFO
 CC||fabiodu...@hotmail.it
 Resolution|--- |WAITINGFORINFO

--- Comment #6 from Fabio D'Urso  ---
Can still reproduce this issue with Okular >= 0.15 ( KDE >= 4.9 ) and
libpoppler >= 0.20?
The annotation rendering algorithm have changed in that version.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 279775] Okular doesnt jump properly to index for big pdf files

[Fabio D';Urso]

https://bugs.kde.org/show_bug.cgi?id=279775

Fabio D'Urso  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDSINFO
 CC||fabiodu...@hotmail.it
 Resolution|--- |WAITINGFORINFO

--- Comment #8 from Fabio D'Urso  ---
It seems to work fine here, can you still reproduce this bug with Okular >=
0.19.0 ( KDE >= 4.13.0 )?
Thanks for caring about Okular :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 279191] orientation changes not saved

[Fabio D';Urso]

https://bugs.kde.org/show_bug.cgi?id=279191

Fabio D'Urso  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDSINFO
 CC||fabiodu...@hotmail.it
 Resolution|--- |WAITINGFORINFO

--- Comment #1 from Fabio D'Urso  ---
The orientation should be preserved, provided you don't rename the file. Can
you still reproduce this issue with Okular >= 0.19.0 ( KDE >= 4.13.0 )?
Thanks for caring about Okular :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 277572] okular not able to display simple 4.8MB pdf file on a notebook with 4GB of memory

[Fabio D';Urso]

https://bugs.kde.org/show_bug.cgi?id=277572

Fabio D'Urso  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||fabiodu...@hotmail.it
 Resolution|--- |FIXED

--- Comment #7 from Fabio D'Urso  ---
The original document is no longer available. However, with the recent (okular
>= 0.16, ie KDE >= 4.10) tiled rendering features it should work now.
Thanks for caring about okular :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 275704] okular keeps scrolling when entering page number

[Fabio D';Urso]

https://bugs.kde.org/show_bug.cgi?id=275704

Fabio D'Urso  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDSINFO
 CC||fabiodu...@hotmail.it
 Resolution|--- |WAITINGFORINFO

--- Comment #2 from Fabio D'Urso  ---
I can't reproduce it either. Can you still reproduce this bug with Okular >=
0.19.0 ( KDE >= 4.13.0 )?
Thanks for caring about Okular :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 273968] Usability: change highlight color for text search and/or annotation

[Fabio D';Urso]

https://bugs.kde.org/show_bug.cgi?id=273968

Fabio D'Urso  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||fabiodu...@hotmail.it
 Resolution|--- |FIXED

--- Comment #6 from Fabio D'Urso  ---
Since Okular 0.17 (KDE/4.11), you can change the default highlighter color, so
I'm closing this bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 272594] Okular crashed when opening print dialog while another printing is not finished

[Fabio D';Urso]

https://bugs.kde.org/show_bug.cgi?id=272594

Fabio D'Urso  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||fabiodu...@hotmail.it
 Resolution|--- |INVALID

--- Comment #1 from Fabio D'Urso  ---
It looks like the crash is not happening in okular's code, so I'm marking it as
INVALID.
By the way, can you still reproduce it on a newer installation?
Thanks for caring about Okular :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 271869] okular hangs X or whole system

[Fabio D';Urso]

https://bugs.kde.org/show_bug.cgi?id=271869

Fabio D'Urso  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDSINFO
 CC||fabiodu...@hotmail.it
 Resolution|--- |WAITINGFORINFO

--- Comment #4 from Fabio D'Urso  ---
Can you still reproduce this bug with Okular >= 0.19.0 ( KDE >= 4.13.0 )?
We have changed some things about memory management since then.
Thanks for caring about Okular :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 265891] Printing of XPS very bad font sizes

[Fabio D';Urso]

https://bugs.kde.org/show_bug.cgi?id=265891

Fabio D'Urso  changed:

   What|Removed |Added

Version|0.11.2  |0.19.0

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 269667] Most all pages go all black once enough pdfs are open

[Fabio D';Urso]

https://bugs.kde.org/show_bug.cgi?id=269667

Fabio D'Urso  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDSINFO
 CC||fabiodu...@hotmail.it
 Resolution|--- |WAITINGFORINFO

--- Comment #10 from Fabio D'Urso  ---
Can any of you guys that could reproduce this bug please try with Okular >=
0.19.0 ( KDE >= 4.13.0 )?
Thanks for caring about Okular :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 267882] Okular crash while scrolling with many files open

[Fabio D';Urso]

https://bugs.kde.org/show_bug.cgi?id=267882

Fabio D'Urso  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDSINFO
 CC||fabiodu...@hotmail.it
 Resolution|--- |WAITINGFORINFO

--- Comment #4 from Fabio D'Urso  ---
Can you still reproduce this bug with Okular >= 0.19.0 ( KDE >= 4.13.0 )?
We have fixed some things about memory management since then and this might be
one of them.
Thanks for caring about Okular :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 265891] Printing of XPS very bad font sizes

[Fabio D';Urso]

https://bugs.kde.org/show_bug.cgi?id=265891

Fabio D'Urso  changed:

   What|Removed |Added

 Status|UNCONFIRMED |CONFIRMED
 CC||fabiodu...@hotmail.it
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 117267: make width of the rectangle for inline note in annotations configurable

[Fabio D';Urso]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117267/#review57567
---


Hi Alin! Sorry for the very late reply...

We don't need to show this new property for *all* annotation types. Currently, 
you're showing it for eg stamps and line annotations too (duplicating the size 
property we already have).
I'd add this new property in TextAnnotationWidget::createStyleWidget (under the 
InPlace branch) rather than AnnotationWidget::createAppearanceWidget, which is 
shared by all annotation types.

Another issue I've noticed is that this property is not saved if you create a 
custom annotation tool (Configure Okular... -> Annotations).

Also, if we want to be picky :D, ui/pagepainter.cpp needs to be patched too, to 
make this property work on non-PDF documents too. This is probably just a 
matter of setting the pen width around line 709.

Sorry again for the delay :)


- Fabio D'Urso


On May 2, 2014, 3:28 p.m., Alin M Elena wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117267/
> ---
> 
> (Updated May 2, 2014, 3:28 p.m.)
> 
> 
> Review request for Okular and Fabio D'Urso.
> 
> 
> Bugs: 332887
> http://bugs.kde.org/show_bug.cgi?id=332887
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> make width of the rectangle for inline note in annotations configurable
> promised it to fabio few months back... never got the time to it till now
> 
> 
> Diffs
> -
> 
>   ui/annotationwidgets.h 6e7a218 
>   ui/annotationwidgets.cpp 450e50b 
> 
> Diff: https://git.reviewboard.kde.org/r/117267/diff/
> 
> 
> Testing
> ---
> 
> saved a document with various widths for border from 0 to more... opened it 
> in windows acroread and worked.
> 
> 
> Thanks,
> 
> Alin M Elena
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Bug 330518 - Add configure icon to the annotation toolbar

[Fabio D';Urso]

On Saturday, March 29, 2014 06:50:52 PM Abhijeet Nikam wrote:
> Hi,
> 
> I wish to start with this bug and solve some more in future.
> 
> I have build and compiled okular but the changes I make in the code is
> not reflected as the program launches.
> 
> I followed the following steps as recommended:
> 
> git clone git://anongit.kde.org/okular
> cd okular
> mkdir build
> cd build
> cmake -DCMAKE_INSTALL_PREFIX=/usr/local ..
> make
> make install
> 
> after that I ran
> 
> export KDEDIRS=/usr/local:$(kde4-config --prefix); kbuildsycoca4

You should be able to run it as /usr/local/bin/okular. Be sure to run it after 
the export+kbuildsycoca4 commands and *in the same shell instance*.

Btw, in order for "make install" to work, I guess you've run it as root.
You can avoid installing to a system-wide folder by just using a 
/home/yourname/subfolder instead of /usr/local. Installing to a local folder 
is good because you don't risk overwriting files provided by your distro.
The distro-provided system-wide installation and your local one can coexist.

Fabio

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 330740] [Suggestion] Add 'save' option to file menu

[Fabio D';Urso]

https://bugs.kde.org/show_bug.cgi?id=330740

Fabio D'Urso  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||fabiodu...@hotmail.it
 Resolution|--- |DUPLICATE

--- Comment #1 from Fabio D'Urso  ---


*** This bug has been marked as a duplicate of bug 315552 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 315552] Allow save annotations directly to original pdf file

[Fabio D';Urso]

https://bugs.kde.org/show_bug.cgi?id=315552

Fabio D'Urso  changed:

   What|Removed |Added

 CC||haav...@ostermann.no

--- Comment #3 from Fabio D'Urso  ---
*** Bug 330740 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Possible bug with annotations?

[Fabio D';Urso]

On Monday, December 16, 2013 10:19:08 PM Albert Astals Cid wrote:
> El Dilluns, 16 de desembre de 2013, a les 17:16:20, Edward Rosten va 
escriure:
> > Hi All,
> 
> Hi
> 
> > I'm having a problem with annotations and I'm not sure if it's a bug.
> > 
> > I've attached 3 files. The original is hello.pdf, a very plain PDF
> > made with PDFlatex.
> > 
> > The next file hello-okular.pdf has been annotated with okular. The
> > problem with this file is that annotations don't appear in all
> > readers. They don't appear in xpdf and (worse) don't appear in the PDF
> > reader built into gmail, or the one built into Firefox. They do appear
> > in evince, okular and Acrobat Reader.
> > 
> > For the final file, I loaded hello-okular.pdf into Acrobat Reader and
> > saved as hello-okular-adobereader.pdf without making any explicit
> > modifications. Now the annotations appear in all readers.
> > 
> > It appears that the annotations only semi-work in other PDF readers at
> > the moment. I also have a vague memory which I can't verify that
> > okular annotations have previously been readable in xpdf (and
> > presumably the others, though I don't remember).
> > 
> > Is this a bug?
> 
> Looks like it to me. What could be otherwise?

Sounds like xpdf, gmail and Firefox don't know how to handle annotations 
without an appearance stream (Poppler -the library we use to handle PDFs- 
doesn't store the appearance stream within the PDF file, whereas Acrobat 
does). Basically we're saying "you have to draw a circle annotation" but we're 
not telling how (ie "draw a curve using these control points").

If they used to work, then I'm wrong and it is a bug.


According to the specs the appearance stream is optional, therefore I'm 
tempted to say this is not our/Poppler's bug. OTOH, given that so many readers 
show this issue, we may want to change Poppler's behavior.

There is a reason why I haven't done this yet: we would need to embed a font 
in case of text notes, but I don't know enough about fonts to do that and I 
guess there are also licensing issues to keep in mind.

Albert, what do you think?

Fabio

> Cheers,
>   Albert
> 
> > Regards
> > 
> > -Ed
> 
> ___
> Okular-devel mailing list
> Okular-devel@kde.org
> https://mail.kde.org/mailman/listinfo/okular-devel

-- 
Fabio
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 327892] inability to use middle mouse button to scroll -- or, at least, to not have it zoom -- means okular is unusable for a good # of people

[Fabio D';Urso]

https://bugs.kde.org/show_bug.cgi?id=327892

Fabio D'Urso  changed:

   What|Removed |Added

 CC||fabiodu...@hotmail.it

--- Comment #3 from Fabio D'Urso  ---
Gregory, reposting will not increase chances for your patch to be adopted.
Saying "this feature is the MOST important thing in the world because it's
important for ME" won't work either.
As Albert said in the other thread, we won't destroy other users' habits. I've
never used okular with a real MMB (read below), but I think I would agree on a
configuration option. Please let's move the discussion back to the original
post.

By the way, I use a ThinkPad, and I've put this lines in a autostart shell
script (they're taken from some website I no longer remember of). They activate
vertical scrolling at driver level for all applications. IIRC, you can also
enable horizontal scrolling.
I have no idea if/how you can do the same from the System Settings panel.

# Mid-btn vert scroll
xinput set-int-prop "TPPS/2 IBM TrackPoint" "Evdev Wheel Emulation" 8 1
xinput set-int-prop "TPPS/2 IBM TrackPoint" "Evdev Wheel Emulation Button" 8 2
xinput set-int-prop "TPPS/2 IBM TrackPoint" "Evdev Wheel Emulation Timeout" 8
200
xinput set-int-prop "TPPS/2 IBM TrackPoint" "Evdev Wheel Emulation Axes" 8 6 7
4 5
xinput set-int-prop "TPPS/2 IBM TrackPoint" "Evdev Middle Button Emulation" 8 1
xinput set-int-prop "TPPS/2 IBM TrackPoint" "Evdev Middle Button Timeout" 8 50

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 328658] Since okular-4.11 KFileDialog does not use "Recent Dirs"

[Fabio D';Urso]

https://bugs.kde.org/show_bug.cgi?id=328658

Fabio D'Urso  changed:

   What|Removed |Added

 CC||fabiodu...@hotmail.it

--- Comment #3 from Fabio D'Urso  ---
All applications that I know always default to the location the file was opened
from, and this seems to me the right thing to do:
 a) it is what most users expect (it is consistent with other applications) 
 b) it is more practical if you want to save over the current file (keep in
mind that we currently lack a plain "save" button, even though this is more an
excuse than a reason :P)

I've read bug 328703, but I'm not sure I understand why you don't agree with
this new behaviour: you still have "Save Copy As" that behaves the other way.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 328511] Okular auto-shutdown when I'm reading a pdf file

[Fabio D';Urso]

https://bugs.kde.org/show_bug.cgi?id=328511

Fabio D'Urso  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||fabiodu...@hotmail.it
 Resolution|--- |UPSTREAM

--- Comment #1 from Fabio D'Urso  ---
Thank you for the bug report.
It was a libpoppler issue and we've patched it (
http://cgit.freedesktop.org/poppler/poppler/commit/?h=poppler-0.24&id=58e04a08afee39370283c494ee2e4e392fd3b684
). It will be fixed in poppler 0.24.5

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 114153: An Idea: Render PDF annotations internally while they are being moved

[Fabio D';Urso]

> On Nov. 27, 2013, 7:49 p.m., Fabio D'Urso wrote:
> > Rendering differences (that I judged ugly) were the reason why I chose to 
> > go the dashed outline route.
> 
> Jon Mease wrote:
> Yeah, that makes sense. How do you feel about my idea above of only using 
> this approach for the "geometric" annotations?  To my eye the rendering looks 
> almost identical.
> 
> Fabio D'Urso wrote:
> It works for me. IIRC, however, there are some differences with straight 
> lines having non-null "leader lines" (ie those optional perpendicular 
> segments at the endings), maybe you can change Okular's rendering to match 
> Poppler's.
> BTW, the long-term fix I have in mind is to patch Poppler to render 
> annotations separately to different pixmaps than the rest of the page, so we 
> can really paint them on top of the page inexpensively. But this is lots of 
> work and I have no time to do that at the moment :( so yeah, it works for me! 
> :D
>
> 
> Jon Mease wrote:
> Thanks for the feedback. I'll give this a shot and update the patch 
> accordingly.  I'll also see if I can generate some annotations with leader 
> lines in Foxit and take a look at Okular's rendering.
> 
> BTW, the larger project I'm working towards right now is to be able to 
> write on PDFs in Okular with a Wacom tablet and be able to bulk-select words 
> (collections of ink strokes) and move them around like in Xournal.  This 
> update will really improve the appearance of this bulk translation of 
> annotations.
> 
> I like the sound of this Poppler patch, but it certainly does sound like 
> a lot of work.

You don't need FoxIt at all :) Just create a straight line in Okular and set 
its Leader Line and Leader Line Extension Length properties, then compare 
Poppler's and PagePainter's renderings.
If they look the same, then I was not remembering correctly :P


- Fabio


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114153/#review44612
---


On Nov. 27, 2013, 3:22 p.m., Jon Mease wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114153/
> ---
> 
> (Updated Nov. 27, 2013, 3:22 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> Unlike in other document formats, the annotations on PDF documents are 
> rendered by the Poppler back-end along with the document itself.  Because 
> this document rendering step is expensive we don't render annotations on PDF 
> documents while the annotations are being moved (With Ctrl+Left click drag).  
> Instead of rendering the annotation itself during the move, we render a 
> dashed outline of the annotation.  For non-PDF document types the annotations 
> are rendered by Okular on top of the document, and so there is no large 
> performance penalty in rendering the annotation smoothly as it is moved.  I 
> find the aesthetic experience of moving annotations on non-PDF to be much 
> more pleasing.
> 
> In this small patch updates the paintCroppedPageOnPainter() function draw 
> external annotations using the internal annotation drawing logic while the 
> annotation is being moved.  It also removes the dashed annotation outline 
> during the move.  With this small change the experience of moving an 
> annotation on a PDF now matches that of moving an annotation on the other 
> document formats.
> 
> Two small oddities:  The rendering of the popup note icon differs between the 
> Poppler back-end and Okular's internal rendering so the icon changes form 
> while being moved and then changes back after being dropped.  The rendering 
> of fonts on inline notes between the Poppler back-end and Okular's internal 
> rendering seems to differ in some cases so as you move an inline note the 
> font changes.
> 
> Thoughts?
> 
> 
> Diffs
> -
> 
>   ui/pagepainter.cpp d5d9c3e 
> 
> Diff: http://git.reviewboard.kde.org/r/114153/diff/
> 
> 
> Testing
> ---
> 
> Tested drawing and moving each of the annotation types on a PDF document and 
> on a DVI document. The behavior on the DVI document is unchanged. I find the 
> behavior on the PDF document to be more natural.
> 
> 
> Thanks,
> 
> Jon Mease
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 114153: An Idea: Render PDF annotations internally while they are being moved

[Fabio D';Urso]

> On Nov. 27, 2013, 7:49 p.m., Fabio D'Urso wrote:
> > Rendering differences (that I judged ugly) were the reason why I chose to 
> > go the dashed outline route.
> 
> Jon Mease wrote:
> Yeah, that makes sense. How do you feel about my idea above of only using 
> this approach for the "geometric" annotations?  To my eye the rendering looks 
> almost identical.

It works for me. IIRC, however, there are some differences with straight lines 
having non-null "leader lines" (ie those optional perpendicular segments at the 
endings), maybe you can change Okular's rendering to match Poppler's.
BTW, the long-term fix I have in mind is to patch Poppler to render annotations 
separately to different pixmaps than the rest of the page, so we can really 
paint them on top of the page inexpensively. But this is lots of work and I 
have no time to do that at the moment :( so yeah, it works for me! :D


- Fabio


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114153/#review44612
---


On Nov. 27, 2013, 3:22 p.m., Jon Mease wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114153/
> ---
> 
> (Updated Nov. 27, 2013, 3:22 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> Unlike in other document formats, the annotations on PDF documents are 
> rendered by the Poppler back-end along with the document itself.  Because 
> this document rendering step is expensive we don't render annotations on PDF 
> documents while the annotations are being moved (With Ctrl+Left click drag).  
> Instead of rendering the annotation itself during the move, we render a 
> dashed outline of the annotation.  For non-PDF document types the annotations 
> are rendered by Okular on top of the document, and so there is no large 
> performance penalty in rendering the annotation smoothly as it is moved.  I 
> find the aesthetic experience of moving annotations on non-PDF to be much 
> more pleasing.
> 
> In this small patch updates the paintCroppedPageOnPainter() function draw 
> external annotations using the internal annotation drawing logic while the 
> annotation is being moved.  It also removes the dashed annotation outline 
> during the move.  With this small change the experience of moving an 
> annotation on a PDF now matches that of moving an annotation on the other 
> document formats.
> 
> Two small oddities:  The rendering of the popup note icon differs between the 
> Poppler back-end and Okular's internal rendering so the icon changes form 
> while being moved and then changes back after being dropped.  The rendering 
> of fonts on inline notes between the Poppler back-end and Okular's internal 
> rendering seems to differ in some cases so as you move an inline note the 
> font changes.
> 
> Thoughts?
> 
> 
> Diffs
> -
> 
>   ui/pagepainter.cpp d5d9c3e 
> 
> Diff: http://git.reviewboard.kde.org/r/114153/diff/
> 
> 
> Testing
> ---
> 
> Tested drawing and moving each of the annotation types on a PDF document and 
> on a DVI document. The behavior on the DVI document is unchanged. I find the 
> behavior on the PDF document to be more natural.
> 
> 
> Thanks,
> 
> Jon Mease
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 328029] Have highlighted text show in xml file in docdata directory

[Fabio D';Urso]

https://bugs.kde.org/show_bug.cgi?id=328029

Fabio D'Urso  changed:

   What|Removed |Added

 CC||fabiodu...@hotmail.it

--- Comment #5 from Fabio D'Urso  ---
You can read the coordinates of the highlighted rectangles from the xml file,
and use them to extract the corresponding text from the PDF file. I think you
can use okular's own API to do that, have a look at Page::text(RegularAreaRect
*)
(http://api.kde.org/4.x-api/kdegraphics-apidocs/okular/html/classOkular_1_1Page.html#a11ab0f2abe5c1e760c046a33fd5393f3).
You can also directly obtain the list of the annotations using okular's API
instead of parsing the xml data.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 114153: An Idea: Render PDF annotations internally while they are being moved

[Fabio D';Urso]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114153/#review44612
---


Rendering differences (that I judged ugly) were the reason why I chose to go 
the dashed outline route.

- Fabio D'Urso


On Nov. 27, 2013, 3:22 p.m., Jon Mease wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114153/
> ---
> 
> (Updated Nov. 27, 2013, 3:22 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> Unlike in other document formats, the annotations on PDF documents are 
> rendered by the Poppler back-end along with the document itself.  Because 
> this document rendering step is expensive we don't render annotations on PDF 
> documents while the annotations are being moved (With Ctrl+Left click drag).  
> Instead of rendering the annotation itself during the move, we render a 
> dashed outline of the annotation.  For non-PDF document types the annotations 
> are rendered by Okular on top of the document, and so there is no large 
> performance penalty in rendering the annotation smoothly as it is moved.  I 
> find the aesthetic experience of moving annotations on non-PDF to be much 
> more pleasing.
> 
> In this small patch updates the paintCroppedPageOnPainter() function draw 
> external annotations using the internal annotation drawing logic while the 
> annotation is being moved.  It also removes the dashed annotation outline 
> during the move.  With this small change the experience of moving an 
> annotation on a PDF now matches that of moving an annotation on the other 
> document formats.
> 
> Two small oddities:  The rendering of the popup note icon differs between the 
> Poppler back-end and Okular's internal rendering so the icon changes form 
> while being moved and then changes back after being dropped.  The rendering 
> of fonts on inline notes between the Poppler back-end and Okular's internal 
> rendering seems to differ in some cases so as you move an inline note the 
> font changes.
> 
> Thoughts?
> 
> 
> Diffs
> -
> 
>   ui/pagepainter.cpp d5d9c3e 
> 
> Diff: http://git.reviewboard.kde.org/r/114153/diff/
> 
> 
> Testing
> ---
> 
> Tested drawing and moving each of the annotation types on a PDF document and 
> on a DVI document. The behavior on the DVI document is unchanged. I find the 
> behavior on the PDF document to be more natural.
> 
> 
> Thanks,
> 
> Jon Mease
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 177778] make it possible to resize resizable annotations

[Fabio D';Urso]

https://bugs.kde.org/show_bug.cgi?id=18

Fabio D'Urso  changed:

   What|Removed |Added

 CC||frap...@gmail.com

--- Comment #5 from Fabio D'Urso  ---
*** Bug 327679 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 327679] Resize notes

[Fabio D';Urso]

https://bugs.kde.org/show_bug.cgi?id=327679

Fabio D'Urso  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||fabiodu...@hotmail.it
 Resolution|--- |DUPLICATE

--- Comment #2 from Fabio D'Urso  ---
@Yuri: That's the popup window. I guess he's talking about the actual
annotations (e.g. inline text notes, geometrical shapes...)

*** This bug has been marked as a duplicate of bug 18 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 113250: Add tiled rendering support in kimgio generator

[Fabio D';Urso]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113250/
---

(Updated Oct. 20, 2013, 9:24 a.m.)


Status
--

This change has been marked as submitted.


Review request for Okular and Mailson Menezes.


Repository: okular


Description
---

This patch adds support for tiled rendering in the kimgio generator, so that 
higher zoom levels can be reached.
Since the code is very short, this patch can also be useful as reference to 
create tile-aware generators.


Diffs
-

  generators/kimgio/generator_kimgio.cpp 06c2c7a 

Diff: http://git.reviewboard.kde.org/r/113250/diff/


Testing
---

Tested with some images and different orientations.


Thanks,

Fabio D'Urso

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 326292] Failed to open files with ftp:// URL

[Fabio D';Urso]

https://bugs.kde.org/show_bug.cgi?id=326292

Fabio D'Urso  changed:

   What|Removed |Added

 CC||fabiodu...@hotmail.it

--- Comment #1 from Fabio D'Urso  ---
Hi, can you reproduce the issue on some publicly accessible server?
How are you opening the file? ("open file" dialog, dolphin, konqueror, command
line, ...)
I can open remote FTP files here.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 322553] Okular crashes when yellow highlits are removed

[Fabio D';Urso]

https://bugs.kde.org/show_bug.cgi?id=322553

Fabio D'Urso  changed:

   What|Removed |Added

 CC||cinalj...@gmail.com

--- Comment #5 from Fabio D'Urso  ---
*** Bug 326105 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 326105] Review-Highlight/Note feature

[Fabio D';Urso]

https://bugs.kde.org/show_bug.cgi?id=326105

Fabio D'Urso  changed:

   What|Removed |Added

 Status|NEEDSINFO   |RESOLVED
 CC||fabiodu...@hotmail.it
 Resolution|WAITINGFORINFO  |DUPLICATE

--- Comment #3 from Fabio D'Urso  ---


*** This bug has been marked as a duplicate of bug 322553 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] Review Request 113250: Add tiled rendering support in kimgio generator

[Fabio D';Urso]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113250/
---

Review request for Okular and Mailson Menezes.


Repository: okular


Description
---

This patch adds support for tiled rendering in the kimgio generator, so that 
higher zoom levels can be reached.
Since the code is very short, this patch can also be useful as reference to 
create tile-aware generators.


Diffs
-

  generators/kimgio/generator_kimgio.cpp 06c2c7a 

Diff: http://git.reviewboard.kde.org/r/113250/diff/


Testing
---

Tested with some images and different orientations.


Thanks,

Fabio D'Urso

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 111793: kimgio generator: Apply transformations dictated by Exif metadata

[Fabio D';Urso]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111793/
---

(Updated Oct. 11, 2013, 9:11 a.m.)


Status
--

This change has been marked as submitted.


Review request for Okular.


Bugs: 322920
http://bugs.kde.org/show_bug.cgi?id=322920


Repository: okular


Description
---

This patch fixes bug 322920 (JPG images don't open rotated correctly).
It adds a dependency on libKExiv2, which is a wrapper around Exiv2.

I've put the code that applies the transformation in loadDocument(), which 
means that it will block the UI.
Of course, with a little more effort, it can be moved to image(), but I've 
decided to keep it in loadDocument() because:
 - it's a one-time only operation;
 - loadDocument() already blocks while loading the file, so I guess a little 
more time won't hurt much.
Of course, if you don't agree, I can change it.

The dependency on libKExiv2 *not* optional because I want to avoid having 
orientation depend on compilation flags. If I made it optional and you shared a 
.okular archive with annotations, their (normalized) coordinates would no 
longer be consistent among clients.


Diffs
-

  generators/CMakeLists.txt 531cc6e 
  generators/kimgio/CMakeLists.txt b0a61eb 
  generators/kimgio/generator_kimgio.cpp 1badab3 
  generators/kimgio/tests/data/testExifOrientation-0.jpg PRE-CREATION 
  generators/kimgio/tests/data/testExifOrientation-0mirror.jpg PRE-CREATION 
  generators/kimgio/tests/data/testExifOrientation-180.jpg PRE-CREATION 
  generators/kimgio/tests/data/testExifOrientation-180mirror.jpg PRE-CREATION 
  generators/kimgio/tests/data/testExifOrientation-270.jpg PRE-CREATION 
  generators/kimgio/tests/data/testExifOrientation-270mirror.jpg PRE-CREATION 
  generators/kimgio/tests/data/testExifOrientation-90.jpg PRE-CREATION 
  generators/kimgio/tests/data/testExifOrientation-90mirror.jpg PRE-CREATION 
  generators/kimgio/tests/data/testExifOrientation-noexif.jpg PRE-CREATION 
  generators/kimgio/tests/data/testExifOrientation-unspecified.jpg PRE-CREATION 
  generators/kimgio/tests/kimgiotest.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/111793/diff/


Testing
---

- Image from bug 322920
- Images taken with my phone (Galaxy S2)
- Images without Exif metadata at all, to verify that they still work


Thanks,

Fabio D'Urso

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 322920] JPG images don't open rotated correctly

[Fabio D';Urso]

https://bugs.kde.org/show_bug.cgi?id=322920

Fabio D'Urso  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
   Version Fixed In||4.12.0
 Resolution|--- |FIXED
  Latest Commit||http://commits.kde.org/okul
   ||ar/26c257202d5741f040cdc146
   ||26c3fbf24943e93d

--- Comment #4 from Fabio D'Urso  ---
Git commit 26c257202d5741f040cdc14626c3fbf24943e93d by Fabio D'Urso.
Committed on 08/10/2013 at 14:30.
Pushed by fabiod into branch 'master'.

kimgio generator: Apply transformations dictated by Exif metadata
FIXED-IN: 4.12.0
REVIEW: 111793

M  +6-1generators/CMakeLists.txt
M  +7-3generators/kimgio/CMakeLists.txt
M  +14   -0generators/kimgio/generator_kimgio.cpp
A  +---generators/kimgio/tests/data/testExifOrientation-0.jpg
A  +---generators/kimgio/tests/data/testExifOrientation-0mirror.jpg
A  +---generators/kimgio/tests/data/testExifOrientation-180.jpg
A  +---generators/kimgio/tests/data/testExifOrientation-180mirror.jpg
A  +---generators/kimgio/tests/data/testExifOrientation-270.jpg
A  +---generators/kimgio/tests/data/testExifOrientation-270mirror.jpg
A  +---generators/kimgio/tests/data/testExifOrientation-90.jpg
A  +---generators/kimgio/tests/data/testExifOrientation-90mirror.jpg
A  +---generators/kimgio/tests/data/testExifOrientation-noexif.jpg
A  +---generators/kimgio/tests/data/testExifOrientation-unspecified.jpg
A  +101  -0generators/kimgio/tests/kimgiotest.cpp [License: GPL (v2+)]

http://commits.kde.org/okular/26c257202d5741f040cdc14626c3fbf24943e93d

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 325810] Okular crashes on zoom selection

[Fabio D';Urso]

https://bugs.kde.org/show_bug.cgi?id=325810

Fabio D'Urso  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDSINFO
 CC||fabiodu...@hotmail.it
 Resolution|--- |WAITINGFORINFO

--- Comment #1 from Fabio D'Urso  ---
I'm not able to reproduce the situation. The zoom selector is disabled while
reloading, am I missing something?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 111793: kimgio generator: Apply transformations dictated by Exif metadata

[Fabio D';Urso]

> On July 30, 2013, 6:16 p.m., Albert Astals Cid wrote:
> > But you can still share an .okular file with an older version of okular, 
> > no? So not really sure the "let's make exiv dependency strict" makes sense.
> 
> Fabio D'Urso wrote:
> Sure, I obviously meant if shared among the same okular version

Are we agreed on this?


- Fabio


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111793/#review36834
-------


On Oct. 8, 2013, 4:23 p.m., Fabio D'Urso wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111793/
> ---
> 
> (Updated Oct. 8, 2013, 4:23 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Bugs: 322920
> http://bugs.kde.org/show_bug.cgi?id=322920
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> This patch fixes bug 322920 (JPG images don't open rotated correctly).
> It adds a dependency on libKExiv2, which is a wrapper around Exiv2.
> 
> I've put the code that applies the transformation in loadDocument(), which 
> means that it will block the UI.
> Of course, with a little more effort, it can be moved to image(), but I've 
> decided to keep it in loadDocument() because:
>  - it's a one-time only operation;
>  - loadDocument() already blocks while loading the file, so I guess a little 
> more time won't hurt much.
> Of course, if you don't agree, I can change it.
> 
> The dependency on libKExiv2 *not* optional because I want to avoid having 
> orientation depend on compilation flags. If I made it optional and you shared 
> a .okular archive with annotations, their (normalized) coordinates would no 
> longer be consistent among clients.
> 
> 
> Diffs
> -
> 
>   generators/CMakeLists.txt 531cc6e 
>   generators/kimgio/CMakeLists.txt b0a61eb 
>   generators/kimgio/generator_kimgio.cpp 1badab3 
>   generators/kimgio/tests/data/testExifOrientation-0.jpg PRE-CREATION 
>   generators/kimgio/tests/data/testExifOrientation-0mirror.jpg PRE-CREATION 
>   generators/kimgio/tests/data/testExifOrientation-180.jpg PRE-CREATION 
>   generators/kimgio/tests/data/testExifOrientation-180mirror.jpg PRE-CREATION 
>   generators/kimgio/tests/data/testExifOrientation-270.jpg PRE-CREATION 
>   generators/kimgio/tests/data/testExifOrientation-270mirror.jpg PRE-CREATION 
>   generators/kimgio/tests/data/testExifOrientation-90.jpg PRE-CREATION 
>   generators/kimgio/tests/data/testExifOrientation-90mirror.jpg PRE-CREATION 
>   generators/kimgio/tests/data/testExifOrientation-noexif.jpg PRE-CREATION 
>   generators/kimgio/tests/data/testExifOrientation-unspecified.jpg 
> PRE-CREATION 
>   generators/kimgio/tests/kimgiotest.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/111793/diff/
> 
> 
> Testing
> ---
> 
> - Image from bug 322920
> - Images taken with my phone (Galaxy S2)
> - Images without Exif metadata at all, to verify that they still work
> 
> 
> Thanks,
> 
> Fabio D'Urso
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 111793: kimgio generator: Apply transformations dictated by Exif metadata

[Fabio D';Urso]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111793/
---

(Updated Oct. 8, 2013, 4:23 p.m.)


Review request for Okular.


Changes
---

- Fixed libkexiv2 detection (previously it didn't compile at all if missing, 
now it just skips the kimgio generator)

- Added autotest with images for all possible Exif Orientation values.
   All images actually produce the same output (a white 3x2 rectangle, with a 
single black pixel in the top-left corner).
   For each image, the test checks that the image gets rotated/mirrored 
correctly and correct pixmaps are generated.
   In order to obtain pixmaps, I had to compile PagePainter from ui/ along with 
the test, like okular active currently does.
   (If I find some time, I can try to move PagePainter into okularcore [in a 
separate patch, of course]. What do you think?)


Bugs: 322920
http://bugs.kde.org/show_bug.cgi?id=322920


Repository: okular


Description
---

This patch fixes bug 322920 (JPG images don't open rotated correctly).
It adds a dependency on libKExiv2, which is a wrapper around Exiv2.

I've put the code that applies the transformation in loadDocument(), which 
means that it will block the UI.
Of course, with a little more effort, it can be moved to image(), but I've 
decided to keep it in loadDocument() because:
 - it's a one-time only operation;
 - loadDocument() already blocks while loading the file, so I guess a little 
more time won't hurt much.
Of course, if you don't agree, I can change it.

The dependency on libKExiv2 *not* optional because I want to avoid having 
orientation depend on compilation flags. If I made it optional and you shared a 
.okular archive with annotations, their (normalized) coordinates would no 
longer be consistent among clients.


Diffs (updated)
-

  generators/CMakeLists.txt 531cc6e 
  generators/kimgio/CMakeLists.txt b0a61eb 
  generators/kimgio/generator_kimgio.cpp 1badab3 
  generators/kimgio/tests/data/testExifOrientation-0.jpg PRE-CREATION 
  generators/kimgio/tests/data/testExifOrientation-0mirror.jpg PRE-CREATION 
  generators/kimgio/tests/data/testExifOrientation-180.jpg PRE-CREATION 
  generators/kimgio/tests/data/testExifOrientation-180mirror.jpg PRE-CREATION 
  generators/kimgio/tests/data/testExifOrientation-270.jpg PRE-CREATION 
  generators/kimgio/tests/data/testExifOrientation-270mirror.jpg PRE-CREATION 
  generators/kimgio/tests/data/testExifOrientation-90.jpg PRE-CREATION 
  generators/kimgio/tests/data/testExifOrientation-90mirror.jpg PRE-CREATION 
  generators/kimgio/tests/data/testExifOrientation-noexif.jpg PRE-CREATION 
  generators/kimgio/tests/data/testExifOrientation-unspecified.jpg PRE-CREATION 
  generators/kimgio/tests/kimgiotest.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/111793/diff/


Testing
---

- Image from bug 322920
- Images taken with my phone (Galaxy S2)
- Images without Exif metadata at all, to verify that they still work


Thanks,

Fabio D'Urso

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 110914: Tabbed interface

[Fabio D';Urso]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110914/#review41071
---


Hi! :)
I have neither tested nor read the whole patch in depth, I've only had a look 
at your description and made a few tests.

We had a discussion at the okular BOF this summer, and we decided that it's 
better to avoid having multiple open copies of the same document, because this 
creates consistency issues if you are annotating (while saving, the two 
instances will overwrite each other's changes). In the light of this, I'm not 
sure "Duplicate tab" makes sense the way it is now. In my opinion, a better 
approach would be to tie multiple PageViews to the same Document. However, as 
the Document class currently assumes that there is only one PageView, this 
requires significant changes, so we had better leave this feature for a 
different patch.

I see a lighter issue with the way "Detach tab" works: if you create a new 
process you will 1) loose all cached pixmaps, 2) cause the Part::queryClose() 
message to show up if there are unsaved annotations. (If you want to reproduce 
this issue annotate a PDF, click "save as", open the file you saved, detach its 
tab).

Both "Duplicate tab" and "Detach tab" fail at handling input from - (standard 
input)
  cat somePdfFile.pdf | okular -
because, by definition, you can't read it twice.

About the issue with moving menu items, I see that all you need to do is to add 
the confirm_tabs_close checkbox, right? Maybe you can just add it to the 
configuration dialog instead or drop it at all (for example the warnings from 
document.cpp warnLimitedAnnotSupport() cannot be reactivated).


shell/shell.cpp
<http://git.reviewboard.kde.org/r/110914/#comment30154>

Why is the dontAskAgainName in i18n()? It's internal stuff, we don't want 
it to depend on the current language/be translated, no?



shell/shell.cpp
<http://git.reviewboard.kde.org/r/110914/#comment30153>

There's a extra whitespace at the end of the line


- Fabio D'Urso


On Aug. 23, 2013, 8:06 p.m., Jonathan Doman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110914/
> ---
> 
> (Updated Aug. 23, 2013, 8:06 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Bugs: 155515
> http://bugs.kde.org/show_bug.cgi?id=155515
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> This patch adds support for a tabbed interface (multiple documents in one 
> window). The core work just adds a tab bar that switches between multiple 
> embedded okularparts, but there are many other considerations:
>  - Tab context menu allows for duplicating or detaching (detached tabs start 
> in new okular process)
>  - `okular file.pdf` will open file in existing window if possible, unless 
> --new flag is used. It also selects the most recently raised/activated window 
> to use. This mirrors behavior I expect from browsers and other tabbed 
> interfaces.
>  - Warns when closing window with multiple tabs
>  - No warning is given when opening an already open file. This is the 
> behavior I strongly prefer (and observe in other programs), but will change 
> if there is consensus otherwise.
> 
> When selecting different tools in one part, the tool selection propagates to 
> all parts, but the GUI does not reflect that. This bug is present in other 
> programs (e.g. multiple okularparts in Konqueror), so I made no attempt to 
> diagnose or fix.
> 
> One menu item was added for the multiple tab warning option. When testing 
> this, I noticed that items in the Settings menu seem to move around when 
> switching tabs, and I cannot diagnose or fix this. It seems to be related to 
> XMLGUI bug #64754. 
> 
> My development branch is also hosted at 
> https://github.com/jrmrjnck/okular-tabbed
> 
> 
> Diffs
> -
> 
>   part.h 4b3aafdb637080ae81eb0e45742f53a34738984d 
>   part.cpp 71c3d0f5d908969ffcf18aba327297ccd2e1c8e1 
>   shell/main.cpp e0ca587ba167c4020d5af5bd33a2dc1b4923cac4 
>   shell/shell.h c065c560fb4ddfcf181601cf35e9ca14581731f6 
>   shell/shell.cpp 1708501daaef817a1ce35fa5d96701a66ab66983 
>   shell/shell.rc 93fbc417588312792bab39b693c65e5d414c87c6 
> 
> Diff: http://git.reviewboard.kde.org/r/110914/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jonathan Doman
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 322919] Crash on exit while PDF file is updated

[Fabio D';Urso]

https://bugs.kde.org/show_bug.cgi?id=322919

Fabio D'Urso  changed:

   What|Removed |Added

 Status|CONFIRMED   |RESOLVED
   Version Fixed In||4.11.3
 Resolution|--- |FIXED
  Latest Commit||http://commits.kde.org/okul
   ||ar/68439221ea29801133586d82
   ||f19a24f8f3627a31

--- Comment #10 from Fabio D'Urso  ---
Git commit 68439221ea29801133586d82f19a24f8f3627a31 by Fabio D'Urso.
Committed on 01/10/2013 at 14:19.
Pushed by fabiod into branch 'KDE/4.11'.

Unparent the old TOCModel so that it doesn't get deleted twice
FIXED-IN: 4.11.3

M  +3-0ui/toc.cpp

http://commits.kde.org/okular/68439221ea29801133586d82f19a24f8f3627a31

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 321169] FREQ: Add option to show table of contents in sidebar on startup (if present) instead of thumbnails

[Fabio D';Urso]

https://bugs.kde.org/show_bug.cgi?id=321169

Fabio D'Urso  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
   Version Fixed In||4.12.0
 Resolution|--- |FIXED
  Latest Commit||http://commits.kde.org/okul
   ||ar/20716155ecb1e8433476c0e7
   ||ff3610613003c29f

--- Comment #4 from Fabio D'Urso  ---
Git commit 20716155ecb1e8433476c0e7ff3610613003c29f by Fabio D'Urso, on behalf
of Stefan Radermacher.
Committed on 27/09/2013 at 13:31.
Pushed by fabiod into branch 'master'.

Show table of contents in sidebar on startup (if present)
FIXED-IN: 4.12.0
REVIEW: 111036

M  +4-0part.cpp

http://commits.kde.org/okular/20716155ecb1e8433476c0e7ff3610613003c29f

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 111036: Add option to show table of contents in sidebar on startup (if present) instead of thumbnails

[Fabio D';Urso]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111036/#review41053
---

Ship it!


Works for me! (maybe a short comment that says that we always show the TOC if 
present wouldn't hurt :D)

- Fabio D'Urso


On Sept. 27, 2013, 1:33 p.m., Stefan Radermacher wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111036/
> ---
> 
> (Updated Sept. 27, 2013, 1:33 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Bugs: 321169
> http://bugs.kde.org/show_bug.cgi?id=321169
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> This is a proposed implementation of the feature request I made in bug report 
> #321169.
> 
> 
> Diffs
> -
> 
>   part.cpp 71c3d0f 
> 
> Diff: http://git.reviewboard.kde.org/r/111036/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Stefan Radermacher
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 112370: BugFix for bug 323434/323435

[Fabio D';Urso]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112370/#review41052
---


Hi! I haven't actually tried the code yet, but I see some avoidable variables. 
Also, modFactor can be made const too.


ui/pageview.cpp
<http://git.reviewboard.kde.org/r/112370/#comment30132>

Seems we don't need decFactor here, do we?



ui/pageview.cpp
<http://git.reviewboard.kde.org/r/112370/#comment30133>

Same thing: we don't need incFactor here, do we?



ui/pageview.cpp
<http://git.reviewboard.kde.org/r/112370/#comment30131>

Why is modFactor assigned twice? (The second assignment seems to be the 
right one)


- Fabio D'Urso


On Sept. 27, 2013, 1:21 a.m., Tingnan Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112370/
> ---
> 
> (Updated Sept. 27, 2013, 1:21 a.m.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> BugFix 323434/323435. Zoom factor now will be properly rounded to those 
> "interval values" like 140%, 250%, etc, when using zoom in and out feature. 
> 
> 
> Diffs
> -
> 
>   ui/pageview.cpp 0d6c567d836340555b3101b58178a9247959543a 
> 
> Diff: http://git.reviewboard.kde.org/r/112370/diff/
> 
> 
> Testing
> ---
> 
> done on local machine
> 
> 
> Thanks,
> 
> Tingnan Zhang
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 322553] Okular crashes when yellow highlits are removed

[Fabio D';Urso]

https://bugs.kde.org/show_bug.cgi?id=322553

Fabio D'Urso  changed:

   What|Removed |Added

 CC||ms...@freemail.hu

--- Comment #4 from Fabio D'Urso  ---
*** Bug 324953 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 324953] Removing highlight crashes Okular

[Fabio D';Urso]

https://bugs.kde.org/show_bug.cgi?id=324953

Fabio D'Urso  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||fabiodu...@hotmail.it
 Resolution|--- |DUPLICATE

--- Comment #1 from Fabio D'Urso  ---
Where is the document? Anyway, the backtrace looks like a bug that was fixed in
Poppler 0.23.3
I'd be great if you could attach the document or try with a newer Poppler
yourself.

Thank you for reporting

*** This bug has been marked as a duplicate of bug 322553 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 324731] opening an pdf document, it crash

[Fabio D';Urso]

https://bugs.kde.org/show_bug.cgi?id=324731

Fabio D'Urso  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDSINFO
 CC||fabiodu...@hotmail.it
 Resolution|--- |WAITINGFORINFO

--- Comment #1 from Fabio D'Urso  ---
Thank you for the bug report. Can you attach the pdf document please?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 317710] some pdf files crash new version of okular

[Fabio D';Urso]

https://bugs.kde.org/show_bug.cgi?id=317710

Fabio D'Urso  changed:

   What|Removed |Added

 CC||wurstwasserflocke@googlemai
   ||l.com

--- Comment #12 from Fabio D'Urso  ---
*** Bug 324351 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 324351] Okular crashes when opening this PDF.

[Fabio D';Urso]

https://bugs.kde.org/show_bug.cgi?id=324351

Fabio D'Urso  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||fabiodu...@hotmail.it
 Resolution|--- |DUPLICATE

--- Comment #1 from Fabio D'Urso  ---
Good news! It was a Poppler bug that has already been fixed in Poppler 0.22.3.
Thank you for reporting :)

*** This bug has been marked as a duplicate of bug 317710 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Dt. 28th August - status

[Fabio D';Urso]

On Thursday, August 29, 2013 01:23:48 AM Jaydeep Solanki wrote:
> On Wed, Aug 28, 2013 at 2:00 AM, Jaydeep Solanki  wrote:
> > Hi,
> > 
> > I noticed that the (movie) annotation version actually works, it's just
> > that it takes a few seconds to start.
> > 
> > Current status is I can hear the video playing but no visual.
> 
> I have visual now, working on playing video using raw data,  and fixing
> position of video widget, currently it's displayed at (0,0).

Hi,

In case it's relevant for your work, there's an interesting comment about 
playing from QByteArray in core/movie.cpp

Fabio

> 
> > To debug this, I turned off a lot of features like drawingContent (because
> > the video player is not drawn using converter), turned off the textpages,
> > etc.
> > Now what I see are random lines, which I guess was supposed to be the
> > video.
> > 
> > Plus, the audio doesn't play when loading movie from QByteArray, but works
> > when using a file from other location (which I used to test). Seems to be
> > a
> > minor bug, will be easy to fix once I get at least something working.
> > 
> > Note : if you want to try out what I'm seeing, a patch is attached, and if
> > you might have seen something similar it would be helpful.
> > 
> > Epub
> > link > .epub>to test.
> > 
> > Cheers,
> > Jaydeep

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Receiving emails from build.kde.org on build failures

[Fabio D';Urso]

On Saturday, August 24, 2013 01:54:58 PM Albert Astals Cid wrote:
> Hi guys, what do you think about build.kde.org sending this list an email
> when okular[1] fails compiling (or the tests stop passing)?

Agreed,

Fabio

> I think it's an awesome idea but don't want to tell the sysadmins to flip
> the switch if people here think those emails would be spam.
> 
> Also, hopefully we should not get many of those since people compile and run
> the tests before committing, right? ;-)
> 
> Cheers,
>   Albert
> 
> [1] http://build.kde.org/view/kdegraphics/job/okular_master/
> [1] http://build.kde.org/view/kdegraphics/job/okular_stable/
> ___
> Okular-devel mailing list
> Okular-devel@kde.org
> https://mail.kde.org/mailman/listinfo/okular-devel

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [Active] [Bug 308240] active-documentviewer crashes by using zoom gestures

[Fabio D';Urso]

https://bugs.kde.org/show_bug.cgi?id=308240

Fabio D'Urso  changed:

   What|Removed |Added

 CC||fabiodu...@hotmail.it

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Dt. 6th August - status

[Fabio D';Urso]

Hi,

On Wednesday, August 07, 2013 12:31:41 AM Albert Astals Cid wrote:
> El Dimarts, 6 d'agost de 2013, a les 20:52:25, Jaydeep Solanki va escriure:
> > Hi,
> > 
> > I have implemented a simple Qt Visibility support, which hides text, it's
> > doesn't hide the exact area of the text, because the way QTextDocument is
> > developed it is impossible to implement an approach that hides only a part
> > of line. Either we can hide a line or not hide it.
> > And implementing an approach in which incrementing the cursor and not
> > inserting the text was my idea, but it seems they are using the text so
> > much that, I'm not able to get a way to exclude the text and implement
> > visibility.
> 
> Before continuing to work on that, i think you should explore with the Qt
> guys how feasible is this work to be accepted upstream with the known
> limitations you mention, because if it's not going to be accepted, it's not
> really useful for us since we can't expect people to patch their Qt for us.
> 
> > Regarding the threaded QTextDocument, I tried the approach you said, and
> > it
> > seems that it is also blocking UI, even more then single threaded. Suppose
> > I'm on a page and the next page is loading in other thread, the UI thread
> > will have to wait till the other thread finishes it's job (because of
> > locking), which takes a bit more time than usual because it is generated
> > from a cloned QTextDocument.
> 
> Why would the UI thread have to wait?

Disclaimer: I haven't read the whole discussion, so this idea might not be 
applicable. If I understood correctly, there's some object that needs to be 
cloned because its methods are not reentrant, but cloning is expensive.

I was thinking about keeping a pool of clones, initially containing only one 
instance, and adding a new clone to the pool when an instance is requested and 
there are no readily available ones.

Of course this approach, if feasible at all, will waste memory. Depending on 
the size of the object it might pay or not.

> > Regarding the clone method overriding in EpubDocument, I'm using a dynamic
> > property, to store the name of the generator, and using it I decide which
> > method to call EpubDocument::myClone() or QTextDocument::clone() in
> > TextDocumentGenerator.
> 
> You can't call EpubDocument::myClone in TextDocumentGenerator, that
> introduces a circular dependency.
> 
> > One more thing I noticed about Okular is it doesn't free up memory, after
> > the document is closed, it frees after Okular quits, so my question is
> > does
> > it use the memory (cached pixmaps) when I load the same document again ?
> 
> Nope, it should free it, if it doesn't it's a bug that has to be fixed.

I remember reading somewhere that most free() implementations don't actually 
return the memory back to the OS, instead they keep free'd blocks in a 
internal pool for future reuse. Eventually, when the process dies, all of its 
memory is reclaimed back by the OS.

As Albert said, Okular does "free" pixmaps, but maybe you see that behavior 
for this reason.

> Cheers,
>   Albert
> 
> > Cheers,
> > Jaydeep
> 
> ___
> Okular-devel mailing list
> Okular-devel@kde.org
> https://mail.kde.org/mailman/listinfo/okular-devel

--
Fabio

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 111793: kimgio generator: Apply transformations dictated by Exif metadata

[Fabio D';Urso]

> On July 30, 2013, 6:16 p.m., Albert Astals Cid wrote:
> > But you can still share an .okular file with an older version of okular, 
> > no? So not really sure the "let's make exiv dependency strict" makes sense.

Sure, I obviously meant if shared among the same okular version


- Fabio


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111793/#review36834
---


On July 30, 2013, 9:40 a.m., Fabio D'Urso wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111793/
> ---
> 
> (Updated July 30, 2013, 9:40 a.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> ---
> 
> This patch fixes bug 322920 (JPG images don't open rotated correctly).
> It adds a dependency on libKExiv2, which is a wrapper around Exiv2.
> 
> I've put the code that applies the transformation in loadDocument(), which 
> means that it will block the UI.
> Of course, with a little more effort, it can be moved to image(), but I've 
> decided to keep it in loadDocument() because:
>  - it's a one-time only operation;
>  - loadDocument() already blocks while loading the file, so I guess a little 
> more time won't hurt much.
> Of course, if you don't agree, I can change it.
> 
> The dependency on libKExiv2 *not* optional because I want to avoid having 
> orientation depend on compilation flags. If I made it optional and you shared 
> a .okular archive with annotations, their (normalized) coordinates would no 
> longer be consistent among clients.
> 
> 
> This addresses bug 322920.
> http://bugs.kde.org/show_bug.cgi?id=322920
> 
> 
> Diffs
> -
> 
>   generators/kimgio/CMakeLists.txt b0a61eb 
>   generators/kimgio/generator_kimgio.cpp 1badab3 
> 
> Diff: http://git.reviewboard.kde.org/r/111793/diff/
> 
> 
> Testing
> ---
> 
> - Image from bug 322920
> - Images taken with my phone (Galaxy S2)
> - Images without Exif metadata at all, to verify that they still work
> 
> 
> Thanks,
> 
> Fabio D'Urso
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] Review Request 111793: kimgio generator: Apply transformations dictated by Exif metadata

[Fabio D';Urso]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111793/
---

Review request for Okular.


Description
---

This patch fixes bug 322920 (JPG images don't open rotated correctly).
It adds a dependency on libKExiv2, which is a wrapper around Exiv2.

I've put the code that applies the transformation in loadDocument(), which 
means that it will block the UI.
Of course, with a little more effort, it can be moved to image(), but I've 
decided to keep it in loadDocument() because:
 - it's a one-time only operation;
 - loadDocument() already blocks while loading the file, so I guess a little 
more time won't hurt much.
Of course, if you don't agree, I can change it.

The dependency on libKExiv2 *not* optional because I want to avoid having 
orientation depend on compilation flags. If I made it optional and you shared a 
.okular archive with annotations, their (normalized) coordinates would no 
longer be consistent among clients.


This addresses bug 322920.
http://bugs.kde.org/show_bug.cgi?id=322920


Diffs
-

  generators/kimgio/CMakeLists.txt b0a61eb 
  generators/kimgio/generator_kimgio.cpp 1badab3 

Diff: http://git.reviewboard.kde.org/r/111793/diff/


Testing
---

- Image from bug 322920
- Images taken with my phone (Galaxy S2)
- Images without Exif metadata at all, to verify that they still work


Thanks,

Fabio D'Urso

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] Review Request 111782: Okular active: Do not position pages on non-exact pixel boundaries

[Fabio D';Urso]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111782/
---

Review request for Okular.


Description
---

As Marco Martin discovered, at some zoom levels on my laptop okular active 
tries to draw page pixmaps at non-exact pixel boundaries, resulting in almost 
unreadable text (see attached video).

This patch fixes the issue by rounding the page position to the nearest pixel. 
Unfortunately, this patch also seems introduce a binding loop:
  QML PageItem_QML_18: Binding loop detected for property "x"

I'm creating this review request as remainder for further investigation.


Diffs
-

  active/app/package/contents/ui/FullScreenDelegate.qml ac308aa 

Diff: http://git.reviewboard.kde.org/r/111782/diff/


Testing
---


File Attachments


Screen recording of the issue
  
http://git.reviewboard.kde.org/media/uploaded/files/2013/07/29/screen-recording.ogv


Thanks,

Fabio D'Urso

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 322357] PDF Annotations in certain pages crash Okular

[Fabio D';Urso]

https://bugs.kde.org/show_bug.cgi?id=322357

Fabio D'Urso  changed:

   What|Removed |Added

 Status|UNCONFIRMED |NEEDSINFO
 CC||fabiodu...@hotmail.it
 Resolution|--- |WAITINGFORINFO

--- Comment #1 from Fabio D'Urso  ---
Hi, can you please attach the pdf file?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] okular active: rendering issues with document scrolling

[Fabio D';Urso]

Hi,

I'm getting some rendering issue while scrolling a document with okular 
active.
Video: http://fdurso1.xoom.it/okularActive-doc-scroll.ogv
pdf file: 
http://wwwimages.adobe.com/www.adobe.com/content/dam/Adobe/en/devnet/pdf/pdfs/PDF32000_2008.pdf

After scrolling, some portions of the document look low-res until the document 
is scrolled again. It only seems to happen at a certain zoom level.

This doesn't look like a regression: I've tried backtracking over git history, 
but I couldn't find a "good" version/commit.

My current setup:
 - plasma-mobile is from 4.10 (but I have removed a conflicting
   /usr/lib/kde4/imports/org/kde/dirmodel/ directory)
 - everything else is from 4.11 beta 2

As my testing environment is far from ideal, any attempt by others to 
reproduce/deny the issue would be greatly appreciated :)

Thank you,
Fabio

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 321797] okular: no option to delete bookmarks

[Fabio D';Urso]

https://bugs.kde.org/show_bug.cgi?id=321797

Fabio D'Urso  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 CC||fabiodu...@hotmail.it
 Resolution|--- |INVALID

--- Comment #1 from Fabio D'Urso  ---
(In reply to comment #0)
> 1. Create bookmark
> 2. Want to remove bookmark
> 3. ...
Use the Bookmarks panel (the one with the star icon on the left).
You can right-click and delete bookmarks from there.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Branch 'epub-qtextdoc' review

[Fabio D';Urso]

On Tuesday, June 25, 2013 06:32:52 PM Jaydeep Solanki wrote:
> On Tue, Jun 25, 2013 at 4:50 AM, Fabio D'Urso  wrote:
> > On Monday, June 24, 2013 11:57:35 PM Jaydeep Solanki wrote:
> > > Hello,
> > > I have put together some of my work, in a branch named 'epub-qtextdoc'.
> > > 
> > > It would be really nice if you can review it.
> > 
> > Hi Jaydeep,
> > 
> > I've never worked on epubs, therefore I can't really comment on your code.
> > 
> > I noticed that there are some indentation changes in your patch "epub
> > change
> > document loading method" that affect code that would otherwise be
> > unaffected.
> > Such changes make diffs unnecessarily long and harder to read, because
> > it's
> > not clear what code has been changed or not (and they also confuse git's
> > history tracking).
> > 
> > Sorry again for not being able to review the actual code,
> 
> I agree with you, on this.
> The file was previously using indentation of width 2, & I used width 4.
> Would it be a good idea to push another commit with indent width 2
> ? because again it will create diff, that has indentation change.
> Or Albert can just kill the branch, & I'll push it again, with indent width
> 2 + some documentation, for making it easier to read.

Have you tried git push -f?
 1. Do your chages and git add them
 2. git commit --amend
 3. git push -f origin epub-qtextdoc

git push -f lets you "rewrite history" and change already-pushed commits.
As a side effect, it causes other people's git clones to stop tracking your 
changes automatically, therefore it's generally better to avoid it.
But I think this case is worth an exception.

Note: git push -f might be blocked by server policies, in which case you'll 
get an error at step three and nothing will be pushed.

Fabio

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Branch 'epub-qtextdoc' review

[Fabio D';Urso]

On Monday, June 24, 2013 11:57:35 PM Jaydeep Solanki wrote:
> Hello,
> I have put together some of my work, in a branch named 'epub-qtextdoc'.
> 
> It would be really nice if you can review it.

Hi Jaydeep,

I've never worked on epubs, therefore I can't really comment on your code.

I noticed that there are some indentation changes in your patch "epub change 
document loading method" that affect code that would otherwise be unaffected.
Such changes make diffs unnecessarily long and harder to read, because it's 
not clear what code has been changed or not (and they also confuse git's 
history tracking).

Sorry again for not being able to review the actual code,

Fabio

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 110905: Fix tiles issue when zooming out a rotated document

[Fabio D';Urso]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110905/#review34857
---

Ship it!


Ship It!

- Fabio D'Urso


On June 8, 2013, 11:42 p.m., Mailson Menezes wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110905/
> ---
> 
> (Updated June 8, 2013, 11:42 p.m.)
> 
> 
> Review request for Okular, Albert Astals Cid and Fabio D'Urso.
> 
> 
> Description
> ---
> 
> This error was reported by fabio and can be reproduced by zooming a rotated 
> document to 1600% then back to 800%.
> 
> 
> Diffs
> -
> 
>   core/tilesmanager.cpp 8a57f6d1fed56f74b735d55c19823e8e11e9a529 
> 
> Diff: http://git.reviewboard.kde.org/r/110905/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Mailson Menezes
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 267350] filling out a PDF form saves data to some file i ~/.kde/share/apps/okular/docdata/

[Fabio D';Urso]

https://bugs.kde.org/show_bug.cgi?id=267350

--- Comment #27 from Fabio D'Urso  ---
Created attachment 80666
  --> https://bugs.kde.org/attachment.cgi?id=80666&action=edit
XFA-warning

(In reply to comment #23)
> Created attachment 80639 [details]
> File for which forms only appear in Okular, not Adobe Reader
Yes, it's known issue. Basically that file uses a newer format to store form
data, which is currently unsupported by poppler (and probably won't be for a
long time, because it's very complex).
However, Okular from 4.10 with poppler 0.22 should warn you (see attached
screen), doesn't it?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 320753] Dynamic memory usage limit doesn't take into account virtual memory exhaustion

[Fabio D';Urso]

https://bugs.kde.org/show_bug.cgi?id=320753

Fabio D'Urso  changed:

   What|Removed |Added

 Status|NEEDSINFO   |CONFIRMED
 Resolution|WAITINGFORINFO  |---
Summary|Okular crashed when |Dynamic memory usage limit
   |searching large document|doesn't take into account
   ||virtual memory exhaustion
 Ever confirmed|0   |1

--- Comment #19 from Fabio D'Urso  ---
Yes, that's surely what makes the difference between a crash or not. I've done
some calculations.

On your 1920x1080 monitor each page is 1532x2167 pixels (according to the last
log you posted).
Since images are stored as ARGB that makes for 1532x2167x4 = 13,2 MB per page.
13,2 MB x 273 pages = 3,6 GB, which is above the 3 GB virtual memory limit.
Indeed, this last stack trace is Poppler failing to allocate memory.

I don't know how big images are on your 1280x1024 monitor because I have no
logs.
Assuming that page size is proportional to monitor width, the total memory
usage would be:
3,6 GB x ( 1280 / 1920 )^2 = 1.6 GB, which is well below the 3 GB barrier.
Feel free to post a log on your 1280x1024 monitor (no need to use valgrind) to
confirm/deny my calculations.

So it makes sense that we don't go out out of memory on your 1280x1024 monitor,
whereas we do on the 1920x1080 one.

To sum up, we have this bug:
 Our dynamic memory usage limit doesn't take into account virtual memory
exhaustion.

(In reply to comment #17)
> (Thanks a lot for all your help, by the way!)
Thank you for caring about okular!  :D

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 320753] Okular crashed when searching large document

[Fabio D';Urso]

https://bugs.kde.org/show_bug.cgi?id=320753

--- Comment #16 from Fabio D'Urso  ---
(In reply to comment #15)
> However, the reason for the crash this time seems to be
> that valgrind ran out of memory. I have 16 GB RAM, but run 32-bit Kubuntu
> with PAE. I don't see any "Painter not active" messages this time.
Makes sense, the algorithm that decides when to stop allocating only looks at
the amount of physical memory, and it ignores the fact that you can't allocate
more than 3GB under 32-bit linux.

@Albert: In the light of this, the "QPainter::begin: Paint device returned
engine == 0, type: 3" might be a result of a failed allocation too, what do you
think? A failed new is supposed to throw an exception instead of returning
NULL, but it's possible that Qt is using plain malloc or nothrow new somewhere.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 320753] Okular crashed when searching large document

[Fabio D';Urso]

https://bugs.kde.org/show_bug.cgi?id=320753

--- Comment #13 from Fabio D'Urso  ---
So it seems it's not Poppler's fault. Weird
QPainter::begin: Paint device returned engine == 0, type: 3
QPainter::end: Painter not active, aborted

It might be something bad happening in the PagePainter class, but it's a hard
to say what's going on in that stack trace full of ???s, maybe installing
okular-dbg can help.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 320753] Okular crashed when searching large document

[Fabio D';Urso]

https://bugs.kde.org/show_bug.cgi?id=320753

--- Comment #8 from Fabio D'Urso  ---
Created attachment 80346
  --> https://bugs.kde.org/attachment.cgi?id=80346&action=edit
valgrind pdftoppm output

As said, I've run
seq 1 273 | while read X; do echo pdftoppm -f $X -l $X ICRA-2013-Digest.pdf;
valgrind pdftoppm -f $X -l $X ICRA-2013-Digest.pdf > /dev/null; done
I'm attaching the output (I've removed output for pages that produced no
errors).
Note: pdftoppm is poppler 0.20.5
I don't see anything that can cause a crash.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 159601] configurable review tools

[Fabio D';Urso]

https://bugs.kde.org/show_bug.cgi?id=159601

Fabio D'Urso  changed:

   What|Removed |Added

 CC||fabiodu...@hotmail.it

--- Comment #24 from Fabio D'Urso  ---
Russell, Albert is just saying that they have been implemented in 4.11.0, i.e.
the *next* KDE major release, which is not yet out. So, since you are *not*
running the development version, you're describing your wishes against an old
version.
The good news is that this feature has been implemented the way you described
it :)
This is an old screenshot, what you'll find in KDE 4.11 will be slightly
different:
http://mail.kde.org/pipermail/okular-devel/attachments/20120801/47fb19e0/attachment-0010.png
.

Cheers

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 320753] Okular crashed when searching large document

[Fabio D';Urso]

https://bugs.kde.org/show_bug.cgi?id=320753

--- Comment #7 from Fabio D'Urso  ---
Tried with poppler 0.20.5, still no crash here :/

Yes, lines like
  okular(19505)/okular (app) Okular::Document::requestPixmaps: request id=3
651x922@270
list all pending requests, which are then processed sequentially. Lines like
  okular(19505)/okular (app)
Okular::DocumentPrivate::sendGeneratorPixmapRequest: sending request id=3
1532x2167@181 async == true isTile == false
tell what's actually being processed right now (in this case a 1532x2167
rendering of page 182).

I can see that page, and I see you've added annotations on it, so you see it
too. It seems this bug doesn't happen always. Let's wait to see if someone else
manages to reproduce it.
I've also searched for "navigation", and it reaches the end of the document
without any issue.

@Albert: In the meantime I'm running pdftoppm on each page through valgrind
memcheck.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 320753] Okular crashed when searching large document

[Fabio D';Urso]

https://bugs.kde.org/show_bug.cgi?id=320753

Fabio D'Urso  changed:

   What|Removed |Added

 CC||fabiodu...@hotmail.it

--- Comment #5 from Fabio D'Urso  ---
No crash here by just scrolling (Fedora x86 32-bit, poppler 0.20.2 with lots of
backported patches). What is your Poppler version (pdfinfo -v)?
You said it also crashes if you search some text, what text exactly?

Can you please run "kdebugdialog", enable all okular entries and run okular
from the shell?
After opening the document you'll see lots of debug output. Just before the
crash you should see something like:
okular(18020)/okular (app) Okular::DocumentPrivate::sendGeneratorPixmapRequest:
sending request id=3 223x315@64 async == true isTile == false
Can you paste that line? (the number after @ is the zero-based page on which
the crash is happening)

Thank you.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 320224] pdf cache problem using form pdf

[Fabio D';Urso]

https://bugs.kde.org/show_bug.cgi?id=320224

Fabio D'Urso  changed:

   What|Removed |Added

 CC||fabiodu...@hotmail.it

--- Comment #4 from Fabio D'Urso  ---
As Albert said, this is what's happening in detail:
 1) the original file is left untouched *but* okular saves filled data in
docdata/
 2) the new file of course contains the form data you typed
There's no "bug" in this: this "feature" is what lets you to fill a form, close
okular without saving, reopen the document and still see your forms filled. A
possible workaround is to create a copy of the original document *before*
filling forms, and then fill the copy.

A better solution would be to let the user disable automatic saving of metadata
through a metadata setting panel (there are already some bugs/wishes about it),
but unfortunately we have limited manpower :(

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 110566: Configurable review tools

[Fabio D';Urso]

> On May 21, 2013, 12:07 a.m., Albert Astals Cid wrote:
> > conf/preferencesdialog.cpp, line 51
> > <http://git.reviewboard.kde.org/r/110566/diff/1/?file=145418#file145418line51>
> >
> > Instead of draw-freehand maybe use the same icon we use in the side 
> > panel?

It *is* draw-freehand, isn't it? (part.cpp:379)


> On May 21, 2013, 12:07 a.m., Albert Astals Cid wrote:
> > conf/widgetannottools.cpp, line 291
> > <http://git.reviewboard.kde.org/r/110566/diff/1/?file=145421#file145421line291>
> >
> > Would it make sense to try to reuse the defaultToolName function?

Yes it makes sense in theory, but there's an issue with "Text markup" and 
"Geometrical shape": the tool name is more specific, e.g. "Geometrical shape" 
can be either a "Rectangle" or a "Ellipse".

On the other hand, I see the benefit in grouping those strings in some way, 
because it's starting to be difficult to track them.
Let's leave this for a later patch, do you agree?


> On May 21, 2013, 12:07 a.m., Albert Astals Cid wrote:
> > conf/okular.kcfg, line 62
> > <http://git.reviewboard.kde.org/r/110566/diff/1/?file=145416#file145416line62>
> >
> > Maybe add a kWarning here if annotationTools content is empty? The old 
> > code seemed to have them, no?

Kind of, they warned if tools.xml wasn't readable or was invalid XML. I've 
re-added the same kWarnings.


> On May 21, 2013, 12:07 a.m., Albert Astals Cid wrote:
> > conf/widgetannottools.cpp, line 298
> > <http://git.reviewboard.kde.org/r/110566/diff/1/?file=145421#file145421line298>
> >
> > maybe i18nc here so it is clear that this is a noun and not a verb?

I agree with you. I've git grepped and we already had a i18n("Stamp") in 
guiutils.cpp:86.
I don't know if translation tools can link new strings to old identical 
strings. If it's the case, it might make sense to leave it unchanged.
On the other hand, we can use this occasion to fix that occurrence too.

I haven't pushed the patch, but I've got it here ready. Please let me know what 
you think it's best.


> On May 21, 2013, 12:07 a.m., Albert Astals Cid wrote:
> > ui/pageviewannotator.cpp, line 1083
> > <http://git.reviewboard.kde.org/r/110566/diff/1/?file=145453#file145453line1083>
> >
> > Maybe some i18nc here too?

Closing this issue, which I've addressed in the patch mentioned by the previous 
one


- Fabio


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110566/#review32856
---


On May 21, 2013, 11:23 a.m., Fabio D'Urso wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110566/
> ---
> 
> (Updated May 21, 2013, 11:23 a.m.)
> 
> 
> Review request for Okular.
> 
> 
> Description
> ---
> 
> Diff dump from the configurable-review-tools branch, as requested in 
> http://mail.kde.org/pipermail/okular-devel/2013-May/015009.html
> 
> This patch mainly addresses bug 159601, but it also adds GUI control to 
> configure some annotation properties (text alignment in inline notes, stroke 
> width in freehand lines, background color in polygons) and changes some texts.
> 
> Use
>  gitk origin/configurable-review-tools ^origin/master --no-merges
> for a detailed changelog.
> 
> 
> This addresses bug 159601.
> http://bugs.kde.org/show_bug.cgi?id=159601
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 64c4c2a 
>   Messages.sh 6d0d0b0 
>   conf/dlgannotations.h PRE-CREATION 
>   conf/dlgannotations.cpp PRE-CREATION 
>   conf/dlgannotationsbase.ui PRE-CREATION 
>   conf/dlgidentity.h 1bbd937 
>   conf/dlgidentity.cpp 8585716 
>   conf/dlgidentitybase.ui 15752eb 
>   conf/okular.kcfg 4a2aaf3 
>   conf/preferencesdialog.h 3340487 
>   conf/preferencesdialog.cpp 9f6d339 
>   conf/settings.kcfgc 060f260 
>   conf/widgetannottools.h PRE-CREATION 
>   conf/widgetannottools.cpp PRE-CREATION 
>   ui/annotationpropertiesdialog.h d1a1c27 
>   ui/annotationpropertiesdialog.cpp 5d86d79 
>   ui/annotationwidgets.h 1832876 
>   ui/annotationwidgets.cpp ce8a91b 
>   ui/data/CMakeLists.txt 6501be5 
>   ui/data/sources/tool-base-okular.svgz PRE-CREATION 
>   ui/data/sources/tool-highlighter-okular-colorizable.svgz PRE-CREATION 
>   ui/data/sources/tool-ink-okular-colorizable.svgz PRE-CREATION 
>   ui/data/sources/tool-note-inline-okul

Re: [Okular-devel] Review Request 110566: Configurable review tools

[Fabio D';Urso]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110566/
---

(Updated May 21, 2013, 11:23 a.m.)


Review request for Okular.


Changes
---

RR updated to edb5fc32750251f7330b94e2138ffa955322bb7b:
 Re-add some kWarnings about missing/invalid tools.xml file


Description
---

Diff dump from the configurable-review-tools branch, as requested in 
http://mail.kde.org/pipermail/okular-devel/2013-May/015009.html

This patch mainly addresses bug 159601, but it also adds GUI control to 
configure some annotation properties (text alignment in inline notes, stroke 
width in freehand lines, background color in polygons) and changes some texts.

Use
 gitk origin/configurable-review-tools ^origin/master --no-merges
for a detailed changelog.


This addresses bug 159601.
http://bugs.kde.org/show_bug.cgi?id=159601


Diffs (updated)
-

  CMakeLists.txt 64c4c2a 
  Messages.sh 6d0d0b0 
  conf/dlgannotations.h PRE-CREATION 
  conf/dlgannotations.cpp PRE-CREATION 
  conf/dlgannotationsbase.ui PRE-CREATION 
  conf/dlgidentity.h 1bbd937 
  conf/dlgidentity.cpp 8585716 
  conf/dlgidentitybase.ui 15752eb 
  conf/okular.kcfg 4a2aaf3 
  conf/preferencesdialog.h 3340487 
  conf/preferencesdialog.cpp 9f6d339 
  conf/settings.kcfgc 060f260 
  conf/widgetannottools.h PRE-CREATION 
  conf/widgetannottools.cpp PRE-CREATION 
  ui/annotationpropertiesdialog.h d1a1c27 
  ui/annotationpropertiesdialog.cpp 5d86d79 
  ui/annotationwidgets.h 1832876 
  ui/annotationwidgets.cpp ce8a91b 
  ui/data/CMakeLists.txt 6501be5 
  ui/data/sources/tool-base-okular.svgz PRE-CREATION 
  ui/data/sources/tool-highlighter-okular-colorizable.svgz PRE-CREATION 
  ui/data/sources/tool-ink-okular-colorizable.svgz PRE-CREATION 
  ui/data/sources/tool-note-inline-okular-colorizable.svgz PRE-CREATION 
  ui/data/sources/tool-note-okular-colorizable.svgz PRE-CREATION 
  ui/data/tool-base-okular.png PRE-CREATION 
  ui/data/tool-ellipse-okular.png 6a3260e 
  ui/data/tool-highlighter-okular-colorizable.png PRE-CREATION 
  ui/data/tool-highlighter-okular.png 594ba41 
  ui/data/tool-ink-okular-colorizable.png PRE-CREATION 
  ui/data/tool-ink-okular.png 8a2eeb0 
  ui/data/tool-line-okular.png a2dda94 
  ui/data/tool-note-inline-okular-colorizable.png PRE-CREATION 
  ui/data/tool-note-inline-okular.png 4d8187f 
  ui/data/tool-note-okular-colorizable.png PRE-CREATION 
  ui/data/tool-note-okular.png a89c91b 
  ui/data/tool-polygon-okular.png 66ba2cb 
  ui/data/tool-stamp-okular.png e53a04a 
  ui/data/tool-underline-okular.png 924772f 
  ui/data/tools.xml 5e3cb84 
  ui/guiutils.h 73c0838 
  ui/guiutils.cpp af06000 
  ui/pagepainter.h 23ac845 
  ui/pagepainter.cpp 2890b56 
  ui/pageview.cpp 26f5516 
  ui/pageviewannotator.h 850d887 
  ui/pageviewannotator.cpp 035c1f3 
  ui/pageviewutils.h 0aaf057 
  ui/pageviewutils.cpp c2e0388 

Diff: http://git.reviewboard.kde.org/r/110566/diff/


Testing
---


Thanks,

Fabio D'Urso

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] Review Request 110566: Configurable review tools

[Fabio D';Urso]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110566/
---

Review request for Okular.


Description
---

Diff dump from the configurable-review-tools branch, as requested in 
http://mail.kde.org/pipermail/okular-devel/2013-May/015009.html

This patch mainly addresses bug 159601, but it also adds GUI control to 
configure some annotation properties (text alignment in inline notes, stroke 
width in freehand lines, background color in polygons) and changes some texts.

Use
 gitk origin/configurable-review-tools ^origin/master --no-merges
for a detailed changelog.


This addresses bug 159601.
http://bugs.kde.org/show_bug.cgi?id=159601


Diffs
-

  CMakeLists.txt 64c4c2a 
  Messages.sh 6d0d0b0 
  conf/dlgannotations.h PRE-CREATION 
  conf/dlgannotations.cpp PRE-CREATION 
  conf/dlgannotationsbase.ui PRE-CREATION 
  conf/dlgidentity.h 1bbd937 
  conf/dlgidentity.cpp 8585716 
  conf/dlgidentitybase.ui 15752eb 
  conf/okular.kcfg 4a2aaf3 
  conf/preferencesdialog.h 3340487 
  conf/preferencesdialog.cpp 9f6d339 
  conf/settings.kcfgc 060f260 
  conf/widgetannottools.h PRE-CREATION 
  conf/widgetannottools.cpp PRE-CREATION 
  ui/annotationpropertiesdialog.h d1a1c27 
  ui/annotationpropertiesdialog.cpp 5d86d79 
  ui/annotationwidgets.h 1832876 
  ui/annotationwidgets.cpp ce8a91b 
  ui/data/CMakeLists.txt 6501be5 
  ui/data/sources/tool-base-okular.svgz PRE-CREATION 
  ui/data/sources/tool-highlighter-okular-colorizable.svgz PRE-CREATION 
  ui/data/sources/tool-ink-okular-colorizable.svgz PRE-CREATION 
  ui/data/sources/tool-note-inline-okular-colorizable.svgz PRE-CREATION 
  ui/data/sources/tool-note-okular-colorizable.svgz PRE-CREATION 
  ui/data/tool-base-okular.png PRE-CREATION 
  ui/data/tool-ellipse-okular.png 6a3260e 
  ui/data/tool-highlighter-okular-colorizable.png PRE-CREATION 
  ui/data/tool-highlighter-okular.png 594ba41 
  ui/data/tool-ink-okular-colorizable.png PRE-CREATION 
  ui/data/tool-ink-okular.png 8a2eeb0 
  ui/data/tool-line-okular.png a2dda94 
  ui/data/tool-note-inline-okular-colorizable.png PRE-CREATION 
  ui/data/tool-note-inline-okular.png 4d8187f 
  ui/data/tool-note-okular-colorizable.png PRE-CREATION 
  ui/data/tool-note-okular.png a89c91b 
  ui/data/tool-polygon-okular.png 66ba2cb 
  ui/data/tool-stamp-okular.png e53a04a 
  ui/data/tool-underline-okular.png 924772f 
  ui/data/tools.xml 5e3cb84 
  ui/guiutils.h 73c0838 
  ui/guiutils.cpp af06000 
  ui/pagepainter.h 23ac845 
  ui/pagepainter.cpp 2890b56 
  ui/pageview.cpp 26f5516 
  ui/pageviewannotator.h 850d887 
  ui/pageviewannotator.cpp 035c1f3 
  ui/pageviewutils.h 0aaf057 
  ui/pageviewutils.cpp c2e0388 

Diff: http://git.reviewboard.kde.org/r/110566/diff/


Testing
---


Thanks,

Fabio D'Urso

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel