from:"Gilbert Assaf"

D14310: Fixes url whitespaces in epub documents

2018-08-11 Thread Gilbert Assaf

gassaf added a comment.


  Here you go. I created this epub document via a free software tool called 
sigil.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D14310

To: gassaf, #okular
Cc: aacid, okular-devel, ngraham

D14310: Fixes url whitespaces in epub documents

2018-08-11 Thread Gilbert Assaf

gassaf updated this revision to Diff 39469.
gassaf added a comment.


  epub generator unit test added

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14310?vs=38278=39469

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14310

AFFECTED FILES
  generators/epub/CMakeLists.txt
  generators/epub/autotests/data/test.epub
  generators/epub/autotests/epubgeneratortest.cpp
  generators/epub/converter.cpp

To: gassaf, #okular
Cc: aacid, okular-devel, ngraham

D14310: Fixes url whitespaces in epub documents

2018-07-23 Thread Gilbert Assaf

gassaf added a reviewer: Okular.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D14310

To: gassaf, #okular
Cc: okular-devel, ngraham, aacid

D14310: Fixes url whitespaces in epub documents

2018-07-23 Thread Gilbert Assaf

gassaf created this revision.
Restricted Application added a project: Okular.
Restricted Application added a subscriber: okular-devel.
gassaf requested review of this revision.

REVISION SUMMARY
  libepub can't handle whitespace url encodings. This is why epub documents 
containing whitespaces urls aren't
  displayed correctly. Since libepub doesn't seem to be maintained anymore, it 
might be better to fix this issue here.
  
  BUG: 334711

TEST PLAN
  Example epubs are in the ticket.

REPOSITORY
  R223 Okular

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14310

AFFECTED FILES
  generators/epub/converter.cpp

To: gassaf
Cc: okular-devel, ngraham, aacid

D13766: fixed picture scaling issues in epub generator

2018-07-05 Thread Gilbert Assaf

gassaf added a comment.


  Same here: Regular DPI without scaling.
  
  I did a quick search in Okular source and everywhere, where the QImage 
`scaled*()`  function is used, it is called with `Qt::SmoothTransformation` 
parameter. Except in the epub generator.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D13766

To: gassaf, #okular
Cc: ngraham, aacid, okular-devel

D13766: fixed picture scaling issues in epub generator

2018-06-30 Thread Gilbert Assaf

gassaf added a comment.


  I did some more tests and epub_get_data() always returned the correct size.
  
  Original image file from ebook:
  F5980094: A978-1-4302-6653-2_CoverFigure_HTML.jpg 

  Screenshot from Okular, build with
  
/*if(img.height() > maxHeight)
img = img.scaledToHeight(maxHeight);
if(img.width() > maxWidth)
img = img.scaledToWidth(maxWidth);*/
  
  F5980120: Without_scaling.png 
  
  So I would argue Okular does load all images with the correct size. HOWEVER 
if you use Okulars zoom functionality the image gets blurry again:
  F5980159: without_scaling_blurry.png 
  
  I don't know for sure what causes this behavior. Maybe this is a 
QTextDocument issue? I will try to look into this.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D13766

To: gassaf, #okular
Cc: ngraham, aacid, okular-devel

D13766: fixed picture scaling issues in epub generator

2018-06-28 Thread Gilbert Assaf

gassaf added a comment.


  I tried commenting out the two lines (+if clause, so line 88 - 91) and all 
pictures are looking fine. Except that they are sometimes to big and break 
layout. So I would argue Okular does load all pictures with the correct 
solution, but the down-scaling part made them look blurry.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D13766

To: gassaf, #okular
Cc: ngraham, aacid, okular-devel

D13766: fixed picture scaling issues in epub generator

2018-06-27 Thread Gilbert Assaf

gassaf edited the test plan for this revision.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D13766

To: gassaf
Cc: okular-devel, ngraham, aacid

D13766: fixed picture scaling issues in epub generator

2018-06-27 Thread Gilbert Assaf

gassaf created this revision.
Restricted Application added a project: Okular.
Restricted Application added a subscriber: okular-devel.
gassaf requested review of this revision.

REVISION SUMMARY
  Images don't look blurry in epub files
  
  BUG: 391625

REPOSITORY
  R223 Okular

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13766

AFFECTED FILES
  generators/epub/epubdocument.cpp

To: gassaf
Cc: okular-devel, ngraham, aacid

Re: Review Request 130057: Bug 288042 - Option to reset forms

2017-11-04 Thread Gilbert Assaf



> On Sept. 26, 2017, 9:57 p.m., Albert Astals Cid wrote:
> > Do you think you could do an autotest using formSamples.pdf ?

I don't know how to put text into a PageViewItem from an autotest class. I 
can't access the necessary members, because of the way PageViewPrivate is 
declared. Even with friending classes I could not get it to work. 
I think the only way to create an autotest is to reimplement this functionality 
using Okular::FormField.


- Gilbert


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130057/#review103741
---


On Sept. 23, 2017, 7:08 p.m., Gilbert Assaf wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130057/
> ---
> 
> (Updated Sept. 23, 2017, 7:08 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Bugs: 288042
> http://bugs.kde.org/show_bug.cgi?id=288042
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> Clear Contents of FormLineEdit, TextAreaEdit and FileEdit + unchecks 
> CheckBoxEdit and ListEdit form elements. 
> 
> I don't touch RadioBoxes and ComboBoxes, because I am not sure, to which 
> state I should reset/clear them. Especially for ComboBox, I am not sure if 
> clearing them could be harmful.
> 
> 
> Diffs
> -
> 
>   part.rc 34a1160ef5d7b8f65e14a457f1b39bbb06fe3074 
>   ui/formwidgets.h b1bc11a4f7048935614ad384cc49dd1cd2b1336c 
>   ui/formwidgets.cpp a1215ce7d88b428dccdc5cac54ad6c934a81d494 
>   ui/pageview.h 43b03b0f677781cb92402e8291335424da210b65 
>   ui/pageview.cpp 9766422b927d23330ce9fced5af8d406cee6ccd2 
>   ui/pageviewutils.h ca8bd78a4d78cb2e779b5b682c66fa60bcb3af80 
>   ui/pageviewutils.cpp a46384afb3f976842d6693b60fb01fd474481d0d 
> 
> 
> Diff: https://git.reviewboard.kde.org/r/130057/diff/4/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gilbert Assaf
> 
>

Re: Review Request 130057: Bug 288042 - Option to reset forms

2017-09-23 Thread Gilbert Assaf


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130057/
---

(Updated Sept. 23, 2017, 7:08 p.m.)


Review request for Okular.


Changes
---

Form reset doesn't switch focus anymore if ListEdits are involved. And the 
option is only visible in edit mode.


Bugs: 288042
http://bugs.kde.org/show_bug.cgi?id=288042


Repository: okular


Description
---

Clear Contents of FormLineEdit, TextAreaEdit and FileEdit + unchecks 
CheckBoxEdit and ListEdit form elements. 

I don't touch RadioBoxes and ComboBoxes, because I am not sure, to which state 
I should reset/clear them. Especially for ComboBox, I am not sure if clearing 
them could be harmful.


Diffs (updated)
-

  part.rc 34a1160ef5d7b8f65e14a457f1b39bbb06fe3074 
  ui/formwidgets.h b1bc11a4f7048935614ad384cc49dd1cd2b1336c 
  ui/formwidgets.cpp a1215ce7d88b428dccdc5cac54ad6c934a81d494 
  ui/pageview.h 43b03b0f677781cb92402e8291335424da210b65 
  ui/pageview.cpp 9766422b927d23330ce9fced5af8d406cee6ccd2 
  ui/pageviewutils.h ca8bd78a4d78cb2e779b5b682c66fa60bcb3af80 
  ui/pageviewutils.cpp a46384afb3f976842d6693b60fb01fd474481d0d 


Diff: https://git.reviewboard.kde.org/r/130057/diff/4/

Changes: https://git.reviewboard.kde.org/r/130057/diff/3-4/


Testing
---


Thanks,

Gilbert Assaf

Re: Review Request 130226: CHM Generator Lib Update

2017-09-12 Thread Gilbert Assaf


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130226/
---

(Updated Sept. 12, 2017, 9:07 p.m.)


Status
--

This change has been marked as submitted.


Review request for Okular.


Changes
---

Submitted with commit 6b27aa53fa7ba034f7808601ebdc13bbf8b0e020 by Gilbert Assaf 
to branch master.


Repository: okular


Description
---

This patch updates our copy of the chm lib from kchmviewer. The lib files 
itself are an unmodified copy from kchmviewer 7.7, only our generator needed 
some changes. In contrast to kchmviewer we still use khtml and therefor still 
need msits.


Diffs
-

  cmake/modules/FindLibZip.cmake PRE-CREATION 
  generators/CMakeLists.txt 5eedf4ebb61237f92d5bbf64c216123140d27fd3 
  generators/chm/CMakeLists.txt 83abe4e24e03b24622117156badb76a1b9d735da 
  generators/chm/generator_chm.h 1485bc8aae60d662dfc0c01afa2f664dbba6382f 
  generators/chm/generator_chm.cpp b6a770ece0d46cb7874bfdf388bae8074d240149 
  generators/chm/lib/bitfiddle.h eb15b0fa9b0d13b27170be76828631d8328b3109 
  generators/chm/lib/ebook.h PRE-CREATION 
  generators/chm/lib/ebook.cpp PRE-CREATION 
  generators/chm/lib/ebook_chm.h PRE-CREATION 
  generators/chm/lib/ebook_chm.cpp PRE-CREATION 
  generators/chm/lib/ebook_chm_encoding.h PRE-CREATION 
  generators/chm/lib/ebook_chm_encoding.cpp PRE-CREATION 
  generators/chm/lib/ebook_epub.h PRE-CREATION 
  generators/chm/lib/ebook_epub.cpp PRE-CREATION 
  generators/chm/lib/ebook_search.h PRE-CREATION 
  generators/chm/lib/ebook_search.cpp PRE-CREATION 
  generators/chm/lib/ebook_url.h PRE-CREATION 
  generators/chm/lib/helper_entitydecoder.h PRE-CREATION 
  generators/chm/lib/helper_entitydecoder.cpp PRE-CREATION 
  generators/chm/lib/helper_search_index.h PRE-CREATION 
  generators/chm/lib/helper_search_index.cpp PRE-CREATION 
  generators/chm/lib/helperxmlhandler_epubcontainer.h PRE-CREATION 
  generators/chm/lib/helperxmlhandler_epubcontainer.cpp PRE-CREATION 
  generators/chm/lib/helperxmlhandler_epubcontent.h PRE-CREATION 
  generators/chm/lib/helperxmlhandler_epubcontent.cpp PRE-CREATION 
  generators/chm/lib/helperxmlhandler_epubtoc.h PRE-CREATION 
  generators/chm/lib/helperxmlhandler_epubtoc.cpp PRE-CREATION 
  generators/chm/lib/lchmurlhandler.h 35133c41d764de551a350a240d8ee43d07f84716 
  generators/chm/lib/lchmurlhandler.cpp 
9d98d87e147539ef30817b3c66a040aa750575ad 
  generators/chm/lib/libchmfile.h cb739ac7914d4856a5f0e8e6793d78e68b0c9628 
  generators/chm/lib/libchmfile.cpp 60d03bc267eff759495af44b333448a55071b023 
  generators/chm/lib/libchmfile_search.cpp 
76532b18282913ff97c8509d8e384ec0b1f48dfb 
  generators/chm/lib/libchmfileimpl.h f8d7cc11269a2688fd8b58a30d718ff911b051b3 
  generators/chm/lib/libchmfileimpl.cpp 
d10602028e958e7feded362b2ab58e32ca1d1ff0 
  generators/chm/lib/libchmtextencoding.h 
5228b04c10718d407fc49df2e69d220d4efff67c 
  generators/chm/lib/libchmtextencoding.cpp 
0ed3f0710360c7bab113a35c7896e6bbd6664d20 
  generators/chm/lib/libchmtocimage.h c0d98b3ba27596a731fd0ab24386578f6c58fdf8 
  generators/chm/lib/libchmtocimage.cpp 
2952e8604d8c01360eace2826bbf5dc428155ff1 


Diff: https://git.reviewboard.kde.org/r/130226/diff/2/


Testing
---


Thanks,

Gilbert Assaf

[okular] [Bug 288042] Option to reset forms (PDF)

2017-08-30 Thread Gilbert Assaf

https://bugs.kde.org/show_bug.cgi?id=288042

Gilbert Assaf <gas...@gmx.de> changed:

   What|Removed |Added

 CC||gas...@gmx.de

--- Comment #4 from Gilbert Assaf <gas...@gmx.de> ---
https://git.reviewboard.kde.org/r/130057/

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Review Request 130226: CHM Generator Lib Update

2017-08-26 Thread Gilbert Assaf


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130226/
---

(Updated Aug. 26, 2017, 5:49 p.m.)


Review request for Okular.


Changes
---

qFatal changed to qWarning


Repository: okular


Description
---

This patch updates our copy of the chm lib from kchmviewer. The lib files 
itself are an unmodified copy from kchmviewer 7.7, only our generator needed 
some changes. In contrast to kchmviewer we still use khtml and therefor still 
need msits.


Diffs (updated)
-

  cmake/modules/FindLibZip.cmake PRE-CREATION 
  generators/CMakeLists.txt 5eedf4ebb61237f92d5bbf64c216123140d27fd3 
  generators/chm/CMakeLists.txt 83abe4e24e03b24622117156badb76a1b9d735da 
  generators/chm/generator_chm.h 1485bc8aae60d662dfc0c01afa2f664dbba6382f 
  generators/chm/generator_chm.cpp b6a770ece0d46cb7874bfdf388bae8074d240149 
  generators/chm/lib/bitfiddle.h eb15b0fa9b0d13b27170be76828631d8328b3109 
  generators/chm/lib/ebook.h PRE-CREATION 
  generators/chm/lib/ebook.cpp PRE-CREATION 
  generators/chm/lib/ebook_chm.h PRE-CREATION 
  generators/chm/lib/ebook_chm.cpp PRE-CREATION 
  generators/chm/lib/ebook_chm_encoding.h PRE-CREATION 
  generators/chm/lib/ebook_chm_encoding.cpp PRE-CREATION 
  generators/chm/lib/ebook_epub.h PRE-CREATION 
  generators/chm/lib/ebook_epub.cpp PRE-CREATION 
  generators/chm/lib/ebook_search.h PRE-CREATION 
  generators/chm/lib/ebook_search.cpp PRE-CREATION 
  generators/chm/lib/ebook_url.h PRE-CREATION 
  generators/chm/lib/helper_entitydecoder.h PRE-CREATION 
  generators/chm/lib/helper_entitydecoder.cpp PRE-CREATION 
  generators/chm/lib/helper_search_index.h PRE-CREATION 
  generators/chm/lib/helper_search_index.cpp PRE-CREATION 
  generators/chm/lib/helperxmlhandler_epubcontainer.h PRE-CREATION 
  generators/chm/lib/helperxmlhandler_epubcontainer.cpp PRE-CREATION 
  generators/chm/lib/helperxmlhandler_epubcontent.h PRE-CREATION 
  generators/chm/lib/helperxmlhandler_epubcontent.cpp PRE-CREATION 
  generators/chm/lib/helperxmlhandler_epubtoc.h PRE-CREATION 
  generators/chm/lib/helperxmlhandler_epubtoc.cpp PRE-CREATION 
  generators/chm/lib/lchmurlhandler.h 35133c41d764de551a350a240d8ee43d07f84716 
  generators/chm/lib/lchmurlhandler.cpp 
9d98d87e147539ef30817b3c66a040aa750575ad 
  generators/chm/lib/libchmfile.h cb739ac7914d4856a5f0e8e6793d78e68b0c9628 
  generators/chm/lib/libchmfile.cpp 60d03bc267eff759495af44b333448a55071b023 
  generators/chm/lib/libchmfile_search.cpp 
76532b18282913ff97c8509d8e384ec0b1f48dfb 
  generators/chm/lib/libchmfileimpl.h f8d7cc11269a2688fd8b58a30d718ff911b051b3 
  generators/chm/lib/libchmfileimpl.cpp 
d10602028e958e7feded362b2ab58e32ca1d1ff0 
  generators/chm/lib/libchmtextencoding.h 
5228b04c10718d407fc49df2e69d220d4efff67c 
  generators/chm/lib/libchmtextencoding.cpp 
0ed3f0710360c7bab113a35c7896e6bbd6664d20 
  generators/chm/lib/libchmtocimage.h c0d98b3ba27596a731fd0ab24386578f6c58fdf8 
  generators/chm/lib/libchmtocimage.cpp 
2952e8604d8c01360eace2826bbf5dc428155ff1 

Diff: https://git.reviewboard.kde.org/r/130226/diff/


Testing
---


Thanks,

Gilbert Assaf

Re: Review Request 130226: CHM Generator Lib Update

2017-08-19 Thread Gilbert Assaf



> On Aug. 16, 2017, 9:58 p.m., Albert Astals Cid wrote:
> > What do they use instead of khtml? Some other html renderer?
> 
> Gilbert Assaf wrote:
> QtWebKit
> 
> Albert Astals Cid wrote:
> Do we want to use that? Or do maybe as a second step? I.e. this first and 
> then evaluate if we want to move to qtwekbit?
> 
> Also what testing have you done?

There is one big problem with qtwebkit: it is no longer officially supported. 
Qt uses qtwebengine now, but you have to use a recent distro to get, because it 
seems very hard to package (see https://euroquis.nl/bobulate/?p=1681 and this 
https://marc.info/?l=kde-core-devel=142954900813235=2 ). I would suggest we 
stick with khtml for now. I tested this patch with all documents I have, but I 
would welcome everyone who would like to do some additional testing, since it 
is quiet a big change.


- Gilbert


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130226/#review103610
---


On Aug. 16, 2017, 12:54 p.m., Gilbert Assaf wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130226/
> ---
> 
> (Updated Aug. 16, 2017, 12:54 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> This patch updates our copy of the chm lib from kchmviewer. The lib files 
> itself are an unmodified copy from kchmviewer 7.7, only our generator needed 
> some changes. In contrast to kchmviewer we still use khtml and therefor still 
> need msits.
> 
> 
> Diffs
> -
> 
>   cmake/modules/FindLibZip.cmake PRE-CREATION 
>   generators/CMakeLists.txt 5eedf4ebb61237f92d5bbf64c216123140d27fd3 
>   generators/chm/CMakeLists.txt 83abe4e24e03b24622117156badb76a1b9d735da 
>   generators/chm/generator_chm.h 1485bc8aae60d662dfc0c01afa2f664dbba6382f 
>   generators/chm/generator_chm.cpp b6a770ece0d46cb7874bfdf388bae8074d240149 
>   generators/chm/lib/bitfiddle.h eb15b0fa9b0d13b27170be76828631d8328b3109 
>   generators/chm/lib/ebook.h PRE-CREATION 
>   generators/chm/lib/ebook.cpp PRE-CREATION 
>   generators/chm/lib/ebook_chm.h PRE-CREATION 
>   generators/chm/lib/ebook_chm.cpp PRE-CREATION 
>   generators/chm/lib/ebook_chm_encoding.h PRE-CREATION 
>   generators/chm/lib/ebook_chm_encoding.cpp PRE-CREATION 
>   generators/chm/lib/ebook_epub.h PRE-CREATION 
>   generators/chm/lib/ebook_epub.cpp PRE-CREATION 
>   generators/chm/lib/ebook_search.h PRE-CREATION 
>   generators/chm/lib/ebook_search.cpp PRE-CREATION 
>   generators/chm/lib/ebook_url.h PRE-CREATION 
>   generators/chm/lib/helper_entitydecoder.h PRE-CREATION 
>   generators/chm/lib/helper_entitydecoder.cpp PRE-CREATION 
>   generators/chm/lib/helper_search_index.h PRE-CREATION 
>   generators/chm/lib/helper_search_index.cpp PRE-CREATION 
>   generators/chm/lib/helperxmlhandler_epubcontainer.h PRE-CREATION 
>   generators/chm/lib/helperxmlhandler_epubcontainer.cpp PRE-CREATION 
>   generators/chm/lib/helperxmlhandler_epubcontent.h PRE-CREATION 
>   generators/chm/lib/helperxmlhandler_epubcontent.cpp PRE-CREATION 
>   generators/chm/lib/helperxmlhandler_epubtoc.h PRE-CREATION 
>   generators/chm/lib/helperxmlhandler_epubtoc.cpp PRE-CREATION 
>   generators/chm/lib/lchmurlhandler.h 
> 35133c41d764de551a350a240d8ee43d07f84716 
>   generators/chm/lib/lchmurlhandler.cpp 
> 9d98d87e147539ef30817b3c66a040aa750575ad 
>   generators/chm/lib/libchmfile.h cb739ac7914d4856a5f0e8e6793d78e68b0c9628 
>   generators/chm/lib/libchmfile.cpp 60d03bc267eff759495af44b333448a55071b023 
>   generators/chm/lib/libchmfile_search.cpp 
> 76532b18282913ff97c8509d8e384ec0b1f48dfb 
>   generators/chm/lib/libchmfileimpl.h 
> f8d7cc11269a2688fd8b58a30d718ff911b051b3 
>   generators/chm/lib/libchmfileimpl.cpp 
> d10602028e958e7feded362b2ab58e32ca1d1ff0 
>   generators/chm/lib/libchmtextencoding.h 
> 5228b04c10718d407fc49df2e69d220d4efff67c 
>   generators/chm/lib/libchmtextencoding.cpp 
> 0ed3f0710360c7bab113a35c7896e6bbd6664d20 
>   generators/chm/lib/libchmtocimage.h 
> c0d98b3ba27596a731fd0ab24386578f6c58fdf8 
>   generators/chm/lib/libchmtocimage.cpp 
> 2952e8604d8c01360eace2826bbf5dc428155ff1 
> 
> Diff: https://git.reviewboard.kde.org/r/130226/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gilbert Assaf
> 
>

Re: Review Request 130226: CHM Generator Lib Update

2017-08-17 Thread Gilbert Assaf



> On Aug. 16, 2017, 9:58 nachm., Albert Astals Cid wrote:
> > What do they use instead of khtml? Some other html renderer?

QtWebKit


- Gilbert


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130226/#review103610
---


On Aug. 16, 2017, 12:54 nachm., Gilbert Assaf wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130226/
> ---
> 
> (Updated Aug. 16, 2017, 12:54 nachm.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> This patch updates our copy of the chm lib from kchmviewer. The lib files 
> itself are an unmodified copy from kchmviewer 7.7, only our generator needed 
> some changes. In contrast to kchmviewer we still use khtml and therefor still 
> need msits.
> 
> 
> Diffs
> -
> 
>   cmake/modules/FindLibZip.cmake PRE-CREATION 
>   generators/CMakeLists.txt 5eedf4ebb61237f92d5bbf64c216123140d27fd3 
>   generators/chm/CMakeLists.txt 83abe4e24e03b24622117156badb76a1b9d735da 
>   generators/chm/generator_chm.h 1485bc8aae60d662dfc0c01afa2f664dbba6382f 
>   generators/chm/generator_chm.cpp b6a770ece0d46cb7874bfdf388bae8074d240149 
>   generators/chm/lib/bitfiddle.h eb15b0fa9b0d13b27170be76828631d8328b3109 
>   generators/chm/lib/ebook.h PRE-CREATION 
>   generators/chm/lib/ebook.cpp PRE-CREATION 
>   generators/chm/lib/ebook_chm.h PRE-CREATION 
>   generators/chm/lib/ebook_chm.cpp PRE-CREATION 
>   generators/chm/lib/ebook_chm_encoding.h PRE-CREATION 
>   generators/chm/lib/ebook_chm_encoding.cpp PRE-CREATION 
>   generators/chm/lib/ebook_epub.h PRE-CREATION 
>   generators/chm/lib/ebook_epub.cpp PRE-CREATION 
>   generators/chm/lib/ebook_search.h PRE-CREATION 
>   generators/chm/lib/ebook_search.cpp PRE-CREATION 
>   generators/chm/lib/ebook_url.h PRE-CREATION 
>   generators/chm/lib/helper_entitydecoder.h PRE-CREATION 
>   generators/chm/lib/helper_entitydecoder.cpp PRE-CREATION 
>   generators/chm/lib/helper_search_index.h PRE-CREATION 
>   generators/chm/lib/helper_search_index.cpp PRE-CREATION 
>   generators/chm/lib/helperxmlhandler_epubcontainer.h PRE-CREATION 
>   generators/chm/lib/helperxmlhandler_epubcontainer.cpp PRE-CREATION 
>   generators/chm/lib/helperxmlhandler_epubcontent.h PRE-CREATION 
>   generators/chm/lib/helperxmlhandler_epubcontent.cpp PRE-CREATION 
>   generators/chm/lib/helperxmlhandler_epubtoc.h PRE-CREATION 
>   generators/chm/lib/helperxmlhandler_epubtoc.cpp PRE-CREATION 
>   generators/chm/lib/lchmurlhandler.h 
> 35133c41d764de551a350a240d8ee43d07f84716 
>   generators/chm/lib/lchmurlhandler.cpp 
> 9d98d87e147539ef30817b3c66a040aa750575ad 
>   generators/chm/lib/libchmfile.h cb739ac7914d4856a5f0e8e6793d78e68b0c9628 
>   generators/chm/lib/libchmfile.cpp 60d03bc267eff759495af44b333448a55071b023 
>   generators/chm/lib/libchmfile_search.cpp 
> 76532b18282913ff97c8509d8e384ec0b1f48dfb 
>   generators/chm/lib/libchmfileimpl.h 
> f8d7cc11269a2688fd8b58a30d718ff911b051b3 
>   generators/chm/lib/libchmfileimpl.cpp 
> d10602028e958e7feded362b2ab58e32ca1d1ff0 
>   generators/chm/lib/libchmtextencoding.h 
> 5228b04c10718d407fc49df2e69d220d4efff67c 
>   generators/chm/lib/libchmtextencoding.cpp 
> 0ed3f0710360c7bab113a35c7896e6bbd6664d20 
>   generators/chm/lib/libchmtocimage.h 
> c0d98b3ba27596a731fd0ab24386578f6c58fdf8 
>   generators/chm/lib/libchmtocimage.cpp 
> 2952e8604d8c01360eace2826bbf5dc428155ff1 
> 
> Diff: https://git.reviewboard.kde.org/r/130226/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gilbert Assaf
> 
>

Review Request 130226: CHM Generator Lib Update

2017-08-16 Thread Gilbert Assaf


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130226/
---

Review request for Okular.


Repository: okular


Description
---

This patch updates our copy of the chm lib from kchmviewer. The lib files 
itself are an unmodified copy from kchmviewer 7.7, only our generator needed 
some changes. In contrast to kchmviewer we still use khtml and therefor still 
need msits.


Diffs
-

  cmake/modules/FindLibZip.cmake PRE-CREATION 
  generators/CMakeLists.txt 5eedf4ebb61237f92d5bbf64c216123140d27fd3 
  generators/chm/CMakeLists.txt 83abe4e24e03b24622117156badb76a1b9d735da 
  generators/chm/generator_chm.h 1485bc8aae60d662dfc0c01afa2f664dbba6382f 
  generators/chm/generator_chm.cpp b6a770ece0d46cb7874bfdf388bae8074d240149 
  generators/chm/lib/bitfiddle.h eb15b0fa9b0d13b27170be76828631d8328b3109 
  generators/chm/lib/ebook.h PRE-CREATION 
  generators/chm/lib/ebook.cpp PRE-CREATION 
  generators/chm/lib/ebook_chm.h PRE-CREATION 
  generators/chm/lib/ebook_chm.cpp PRE-CREATION 
  generators/chm/lib/ebook_chm_encoding.h PRE-CREATION 
  generators/chm/lib/ebook_chm_encoding.cpp PRE-CREATION 
  generators/chm/lib/ebook_epub.h PRE-CREATION 
  generators/chm/lib/ebook_epub.cpp PRE-CREATION 
  generators/chm/lib/ebook_search.h PRE-CREATION 
  generators/chm/lib/ebook_search.cpp PRE-CREATION 
  generators/chm/lib/ebook_url.h PRE-CREATION 
  generators/chm/lib/helper_entitydecoder.h PRE-CREATION 
  generators/chm/lib/helper_entitydecoder.cpp PRE-CREATION 
  generators/chm/lib/helper_search_index.h PRE-CREATION 
  generators/chm/lib/helper_search_index.cpp PRE-CREATION 
  generators/chm/lib/helperxmlhandler_epubcontainer.h PRE-CREATION 
  generators/chm/lib/helperxmlhandler_epubcontainer.cpp PRE-CREATION 
  generators/chm/lib/helperxmlhandler_epubcontent.h PRE-CREATION 
  generators/chm/lib/helperxmlhandler_epubcontent.cpp PRE-CREATION 
  generators/chm/lib/helperxmlhandler_epubtoc.h PRE-CREATION 
  generators/chm/lib/helperxmlhandler_epubtoc.cpp PRE-CREATION 
  generators/chm/lib/lchmurlhandler.h 35133c41d764de551a350a240d8ee43d07f84716 
  generators/chm/lib/lchmurlhandler.cpp 
9d98d87e147539ef30817b3c66a040aa750575ad 
  generators/chm/lib/libchmfile.h cb739ac7914d4856a5f0e8e6793d78e68b0c9628 
  generators/chm/lib/libchmfile.cpp 60d03bc267eff759495af44b333448a55071b023 
  generators/chm/lib/libchmfile_search.cpp 
76532b18282913ff97c8509d8e384ec0b1f48dfb 
  generators/chm/lib/libchmfileimpl.h f8d7cc11269a2688fd8b58a30d718ff911b051b3 
  generators/chm/lib/libchmfileimpl.cpp 
d10602028e958e7feded362b2ab58e32ca1d1ff0 
  generators/chm/lib/libchmtextencoding.h 
5228b04c10718d407fc49df2e69d220d4efff67c 
  generators/chm/lib/libchmtextencoding.cpp 
0ed3f0710360c7bab113a35c7896e6bbd6664d20 
  generators/chm/lib/libchmtocimage.h c0d98b3ba27596a731fd0ab24386578f6c58fdf8 
  generators/chm/lib/libchmtocimage.cpp 
2952e8604d8c01360eace2826bbf5dc428155ff1 

Diff: https://git.reviewboard.kde.org/r/130226/diff/


Testing
---


Thanks,

Gilbert Assaf

Re: Review Request 130187: CHMGenerator code modernization

2017-08-16 Thread Gilbert Assaf


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130187/
---

(Updated Aug. 16, 2017, 12:53 nachm.)


Status
--

This change has been discarded.


Review request for Okular.


Repository: okular


Description
---

- Removes lib/lchmurlhandler.cpp (contains no code)
- Use keyword override
- Usage of proper Include Guards
- Fixes order of includes
- Introduces usage of nullptr
- Introduces usage of auto
- Removes usage of QString:null


Diffs
-

  generators/chm/CMakeLists.txt 83abe4e24e03b24622117156badb76a1b9d735da 
  generators/chm/autotests/chmgeneratortest.cpp 
6b0b8efc7e9395d137f2cd36876e8197accbfc16 
  generators/chm/generator_chm.h 1485bc8aae60d662dfc0c01afa2f664dbba6382f 
  generators/chm/generator_chm.cpp b6a770ece0d46cb7874bfdf388bae8074d240149 
  generators/chm/kio-msits/msits.cpp 50bac0c100b9dd816d55a817c021ff083e3d5202 
  generators/chm/lib/lchmurlhandler.h 35133c41d764de551a350a240d8ee43d07f84716 
  generators/chm/lib/lchmurlhandler.cpp 
9d98d87e147539ef30817b3c66a040aa750575ad 
  generators/chm/lib/libchmfileimpl.h f8d7cc11269a2688fd8b58a30d718ff911b051b3 
  generators/chm/lib/libchmfileimpl.cpp 
d10602028e958e7feded362b2ab58e32ca1d1ff0 
  generators/chm/lib/libchmtextencoding.cpp 
0ed3f0710360c7bab113a35c7896e6bbd6664d20 
  generators/chm/lib/libchmtocimage.h c0d98b3ba27596a731fd0ab24386578f6c58fdf8 
  generators/chm/lib/libchmtocimage.cpp 
2952e8604d8c01360eace2826bbf5dc428155ff1 

Diff: https://git.reviewboard.kde.org/r/130187/diff/


Testing
---

With clang4.0 
some work was done with clang-tidy: 
https://www.kdab.com/clang-tidy-part-1-modernize-source-code-using-c11c14/


Thanks,

Gilbert Assaf

Re: Review Request 130187: CHMGenerator code modernization

2017-07-31 Thread Gilbert Assaf



> On Juli 24, 2017, 11:08 vorm., Albert Astals Cid wrote:
> > i'd be happier if we don't touch the code in lib/ and kio-msits since it's 
> > "copied" from kchmviewer.
> > 
> > At some point it would make sense if someone has time to go and see how 
> > much kchmviewer code has changed and if it makes sense updating our "copy".
> > 
> > What do you think?
> 
> Gilbert Assaf wrote:
> Sounds reasonable. I will look into this.

kchmviewer did a rewrite of those classes a few years ago. I suggest we use 
their current version and integrate them in okular. Although we might need a 
rewrite of our generator_chm class.


- Gilbert


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130187/#review103466
-----------


On Juli 20, 2017, 2:40 nachm., Gilbert Assaf wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130187/
> ---
> 
> (Updated Juli 20, 2017, 2:40 nachm.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> - Removes lib/lchmurlhandler.cpp (contains no code)
> - Use keyword override
> - Usage of proper Include Guards
> - Fixes order of includes
> - Introduces usage of nullptr
> - Introduces usage of auto
> - Removes usage of QString:null
> 
> 
> Diffs
> -
> 
>   generators/chm/CMakeLists.txt 83abe4e24e03b24622117156badb76a1b9d735da 
>   generators/chm/autotests/chmgeneratortest.cpp 
> 6b0b8efc7e9395d137f2cd36876e8197accbfc16 
>   generators/chm/generator_chm.h 1485bc8aae60d662dfc0c01afa2f664dbba6382f 
>   generators/chm/generator_chm.cpp b6a770ece0d46cb7874bfdf388bae8074d240149 
>   generators/chm/kio-msits/msits.cpp 50bac0c100b9dd816d55a817c021ff083e3d5202 
>   generators/chm/lib/lchmurlhandler.h 
> 35133c41d764de551a350a240d8ee43d07f84716 
>   generators/chm/lib/lchmurlhandler.cpp 
> 9d98d87e147539ef30817b3c66a040aa750575ad 
>   generators/chm/lib/libchmfileimpl.h 
> f8d7cc11269a2688fd8b58a30d718ff911b051b3 
>   generators/chm/lib/libchmfileimpl.cpp 
> d10602028e958e7feded362b2ab58e32ca1d1ff0 
>   generators/chm/lib/libchmtextencoding.cpp 
> 0ed3f0710360c7bab113a35c7896e6bbd6664d20 
>   generators/chm/lib/libchmtocimage.h 
> c0d98b3ba27596a731fd0ab24386578f6c58fdf8 
>   generators/chm/lib/libchmtocimage.cpp 
> 2952e8604d8c01360eace2826bbf5dc428155ff1 
> 
> Diff: https://git.reviewboard.kde.org/r/130187/diff/
> 
> 
> Testing
> ---
> 
> With clang4.0 
> some work was done with clang-tidy: 
> https://www.kdab.com/clang-tidy-part-1-modernize-source-code-using-c11c14/
> 
> 
> Thanks,
> 
> Gilbert Assaf
> 
>

Re: Review Request 130187: CHMGenerator code modernization

2017-07-24 Thread Gilbert Assaf



> On July 24, 2017, 11:08 a.m., Albert Astals Cid wrote:
> > i'd be happier if we don't touch the code in lib/ and kio-msits since it's 
> > "copied" from kchmviewer.
> > 
> > At some point it would make sense if someone has time to go and see how 
> > much kchmviewer code has changed and if it makes sense updating our "copy".
> > 
> > What do you think?

Sounds reasonable. I will look into this.


- Gilbert


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130187/#review103466
-------


On July 20, 2017, 2:40 p.m., Gilbert Assaf wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130187/
> ---
> 
> (Updated July 20, 2017, 2:40 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> - Removes lib/lchmurlhandler.cpp (contains no code)
> - Use keyword override
> - Usage of proper Include Guards
> - Fixes order of includes
> - Introduces usage of nullptr
> - Introduces usage of auto
> - Removes usage of QString:null
> 
> 
> Diffs
> -
> 
>   generators/chm/CMakeLists.txt 83abe4e24e03b24622117156badb76a1b9d735da 
>   generators/chm/autotests/chmgeneratortest.cpp 
> 6b0b8efc7e9395d137f2cd36876e8197accbfc16 
>   generators/chm/generator_chm.h 1485bc8aae60d662dfc0c01afa2f664dbba6382f 
>   generators/chm/generator_chm.cpp b6a770ece0d46cb7874bfdf388bae8074d240149 
>   generators/chm/kio-msits/msits.cpp 50bac0c100b9dd816d55a817c021ff083e3d5202 
>   generators/chm/lib/lchmurlhandler.h 
> 35133c41d764de551a350a240d8ee43d07f84716 
>   generators/chm/lib/lchmurlhandler.cpp 
> 9d98d87e147539ef30817b3c66a040aa750575ad 
>   generators/chm/lib/libchmfileimpl.h 
> f8d7cc11269a2688fd8b58a30d718ff911b051b3 
>   generators/chm/lib/libchmfileimpl.cpp 
> d10602028e958e7feded362b2ab58e32ca1d1ff0 
>   generators/chm/lib/libchmtextencoding.cpp 
> 0ed3f0710360c7bab113a35c7896e6bbd6664d20 
>   generators/chm/lib/libchmtocimage.h 
> c0d98b3ba27596a731fd0ab24386578f6c58fdf8 
>   generators/chm/lib/libchmtocimage.cpp 
> 2952e8604d8c01360eace2826bbf5dc428155ff1 
> 
> Diff: https://git.reviewboard.kde.org/r/130187/diff/
> 
> 
> Testing
> ---
> 
> With clang4.0 
> some work was done with clang-tidy: 
> https://www.kdab.com/clang-tidy-part-1-modernize-source-code-using-c11c14/
> 
> 
> Thanks,
> 
> Gilbert Assaf
> 
>

[okular] [Bug 377024] Add "expand all" to the Review View

2017-07-23 Thread Gilbert Assaf

https://bugs.kde.org/show_bug.cgi?id=377024

Gilbert Assaf <gas...@gmx.de> changed:

   What|Removed |Added

 CC||gas...@gmx.de

--- Comment #1 from Gilbert Assaf <gas...@gmx.de> ---
Well this option kind of already exists. If you press the "Show reviews for
current page only" Button, located at the bottom in the review view, all
annotations from all authors for this particular page are collapsed. But I
agree, this is not very intuitive.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Review Request 130187: CHMGenerator code modernization

2017-07-20 Thread Gilbert Assaf


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130187/
---

Review request for Okular.


Repository: okular


Description
---

- Removes lib/lchmurlhandler.cpp (contains no code)
- Use keyword override
- Usage of proper Include Guards
- Fixes order of includes
- Introduces usage of nullptr
- Introduces usage of auto
- Removes usage of QString:null


Diffs
-

  generators/chm/CMakeLists.txt 83abe4e24e03b24622117156badb76a1b9d735da 
  generators/chm/autotests/chmgeneratortest.cpp 
6b0b8efc7e9395d137f2cd36876e8197accbfc16 
  generators/chm/generator_chm.h 1485bc8aae60d662dfc0c01afa2f664dbba6382f 
  generators/chm/generator_chm.cpp b6a770ece0d46cb7874bfdf388bae8074d240149 
  generators/chm/kio-msits/msits.cpp 50bac0c100b9dd816d55a817c021ff083e3d5202 
  generators/chm/lib/lchmurlhandler.h 35133c41d764de551a350a240d8ee43d07f84716 
  generators/chm/lib/lchmurlhandler.cpp 
9d98d87e147539ef30817b3c66a040aa750575ad 
  generators/chm/lib/libchmfileimpl.h f8d7cc11269a2688fd8b58a30d718ff911b051b3 
  generators/chm/lib/libchmfileimpl.cpp 
d10602028e958e7feded362b2ab58e32ca1d1ff0 
  generators/chm/lib/libchmtextencoding.cpp 
0ed3f0710360c7bab113a35c7896e6bbd6664d20 
  generators/chm/lib/libchmtocimage.h c0d98b3ba27596a731fd0ab24386578f6c58fdf8 
  generators/chm/lib/libchmtocimage.cpp 
2952e8604d8c01360eace2826bbf5dc428155ff1 

Diff: https://git.reviewboard.kde.org/r/130187/diff/


Testing
---

With clang4.0 
some work was done with clang-tidy: 
https://www.kdab.com/clang-tidy-part-1-modernize-source-code-using-c11c14/


Thanks,

Gilbert Assaf

Re: Review Request 130057: Bug 288042 - Option to reset forms

2017-07-05 Thread Gilbert Assaf


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130057/
---

(Updated July 5, 2017, 4:53 p.m.)


Review request for Okular.


Bugs: 288042
http://bugs.kde.org/show_bug.cgi?id=288042


Repository: okular


Description
---

Clear Contents of FormLineEdit, TextAreaEdit and FileEdit + unchecks 
CheckBoxEdit and ListEdit form elements. 

I don't touch RadioBoxes and ComboBoxes, because I am not sure, to which state 
I should reset/clear them. Especially for ComboBox, I am not sure if clearing 
them could be harmful.


Diffs (updated)
-

  part.rc 34a1160ef5d7b8f65e14a457f1b39bbb06fe3074 
  ui/formwidgets.h b1bc11a4f7048935614ad384cc49dd1cd2b1336c 
  ui/formwidgets.cpp 6ab49b0ed9fa3ba71486cf45e89e46c7b0f61d3f 
  ui/pageview.h 43b03b0f677781cb92402e8291335424da210b65 
  ui/pageview.cpp acacfb9047e678b99bb8a1cdcefbfeac0ac9c3d1 
  ui/pageviewutils.h ca8bd78a4d78cb2e779b5b682c66fa60bcb3af80 
  ui/pageviewutils.cpp a57712ca235b2ca629f5739ad73488d513416d0c 

Diff: https://git.reviewboard.kde.org/r/130057/diff/


Testing
---


Thanks,

Gilbert Assaf

Re: Review Request 130057: Bug 288042 - Option to reset forms

2017-07-05 Thread Gilbert Assaf



> On July 2, 2017, 10:46 p.m., Albert Astals Cid wrote:
> > How does this play with undo/redo?
> > 
> > I haven't tried but i think this would feel weird (please try):
> > 
> > * Open a file with two fields
> > * Go to field 1 and write "hola"
> > * Go to field 2 and write "adios"
> > * Go to field 1 and delete everything
> > * Now press "Clear forms"
> > * Now press "undo", what happens? if my guess is right, field 1 will go to 
> > "hola" and field 2 will stay empty, which is exactly the opposite of what 
> > you had when pressing "Clear forms"

I tried this and field 1 stays empty and field 2 show "adios" again.


- Gilbert


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130057/#review103403
---


On March 30, 2017, 7 p.m., Gilbert Assaf wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130057/
> ---
> 
> (Updated March 30, 2017, 7 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Bugs: 288042
> http://bugs.kde.org/show_bug.cgi?id=288042
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> Clear Contents of FormLineEdit, TextAreaEdit and FileEdit + unchecks 
> CheckBoxEdit and ListEdit form elements. 
> 
> I don't touch RadioBoxes and ComboBoxes, because I am not sure, to which 
> state I should reset/clear them. Especially for ComboBox, I am not sure if 
> clearing them could be harmful.
> 
> 
> Diffs
> -
> 
>   part.rc 34a1160ef5d7b8f65e14a457f1b39bbb06fe3074 
>   ui/formwidgets.h b1bc11a4f7048935614ad384cc49dd1cd2b1336c 
>   ui/formwidgets.cpp 6ab49b0ed9fa3ba71486cf45e89e46c7b0f61d3f 
>   ui/pageview.h 43b03b0f677781cb92402e8291335424da210b65 
>   ui/pageview.cpp 88ffe62418f3b68ca8c2314c54f13226d2ed6191 
>   ui/pageviewutils.h ca8bd78a4d78cb2e779b5b682c66fa60bcb3af80 
>   ui/pageviewutils.cpp a57712ca235b2ca629f5739ad73488d513416d0c 
> 
> Diff: https://git.reviewboard.kde.org/r/130057/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gilbert Assaf
> 
>

[okular] [Bug 262265] crashes with chm (text encoding by LCID)

2017-06-02 Thread Gilbert Assaf

https://bugs.kde.org/show_bug.cgi?id=262265

Gilbert Assaf <gas...@gmx.de> changed:

   What|Removed |Added

  Latest Commit||https://commits.kde.org/oku
   ||lar/e876640c215f27b0d0cd632
   ||d553174bf851e0147
 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED

--- Comment #4 from Gilbert Assaf <gas...@gmx.de> ---
Okular sends a 'qFatal()', if no encoding could be guessed. This will also
create a core dump crashing Okular and all open document in this instance. 
Reviewed at https://git.reviewboard.kde.org/r/130106/

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 236688] Make use of table of contents data to improve page ordering in CHM files

2017-06-02 Thread Gilbert Assaf

https://bugs.kde.org/show_bug.cgi?id=236688

Gilbert Assaf <gas...@gmx.de> changed:

   What|Removed |Added

  Latest Commit||https://commits.kde.org/oku
   ||lar/786ec885264fda5b1b2e1ce
   ||e22a7d62f5ad90d3f

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 236688] Make use of table of contents data to improve page ordering in CHM files

2017-06-02 Thread Gilbert Assaf

https://bugs.kde.org/show_bug.cgi?id=236688

Gilbert Assaf <gas...@gmx.de> changed:

   What|Removed |Added

 Resolution|--- |FIXED
 CC||gas...@gmx.de
 Status|CONFIRMED   |RESOLVED

--- Comment #1 from Gilbert Assaf <gas...@gmx.de> ---
All pages in a CHM File are now ordered accordingly to TOC Data. If a page is
not in TOC, it will be added at the end. 
Reviewed at https://git.reviewboard.kde.org/r/130078/

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 164198] CHM: zooming does not change the font size

2017-06-02 Thread Gilbert Assaf

https://bugs.kde.org/show_bug.cgi?id=164198

Gilbert Assaf <gas...@gmx.de> changed:

   What|Removed |Added

 Resolution|--- |FIXED
 CC||gas...@gmx.de
 Status|CONFIRMED   |RESOLVED
  Latest Commit||https://commits.kde.org/oku
   ||lar/ff1647ce68856022e7c3278
   ||ccb72c4039328b584

--- Comment #1 from Gilbert Assaf <gas...@gmx.de> ---
Transfers zoom handling from KHTML to KHTMLView and QImage. This way the font
now actually increases when you zoom in and zoom handling is more in line with
the other generators. Bugs closed: 164198 Reviewed at
https://git.reviewboard.kde.org/r/130127/

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Review Request 130106: Bug 262265 chmlib should not send qFatal if encoding could not be guessed

2017-05-31 Thread Gilbert Assaf



> On Mai 31, 2017, 11:06 vorm., Luigi Toscano wrote:
> > Please check 
> > https://community.kde.org/Policies/Commit_Policy#Special_keywords_in_GIT_and_SVN_log_messages
> >  for next reviews (in this case, BUG: and REVIEW: keyword were missing).
> > 
> > (also, this could have gone to the Applications/17.04 branch instead - 
> > Albert?)

sorry I saw this message to late. I was assuming just using rbt patch would be 
enough. I will definitly do this next time!


- Gilbert


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130106/#review103255
---


On Mai 31, 2017, 11:03 vorm., Gilbert Assaf wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130106/
> ---
> 
> (Updated Mai 31, 2017, 11:03 vorm.)
> 
> 
> Review request for Okular.
> 
> 
> Bugs: 262265
> http://bugs.kde.org/show_bug.cgi?id=262265
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> Okular sends a 'qFatal()', if no encoding could be guessed. This will also 
> create a core dump crashing Okular and all open document in this instance.
> 
> 
> Diffs
> -
> 
>   generators/chm/lib/libchmfileimpl.cpp 
> 3ae4e98ddf8876a996a34ab710ffa0ab71f52cde 
> 
> Diff: https://git.reviewboard.kde.org/r/130106/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gilbert Assaf
> 
>

Re: Review Request 130078: Bug 236688 - Sort pages according to TOC in CHM Files

2017-05-31 Thread Gilbert Assaf


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130078/
---

(Updated Mai 31, 2017, 11:16 vorm.)


Status
--

This change has been marked as submitted.


Review request for Okular.


Bugs: 236688
http://bugs.kde.org/show_bug.cgi?id=236688


Repository: okular


Description
---

All pages in a CHM File are now ordered accordingly to TOC Data. If a page is 
not in TOC, it will be added at the end.


Diffs
-

  generators/chm/CMakeLists.txt 22015955dba2519d485f22951e320694ebe82a7f 
  generators/chm/autotests/chmgeneratortest.cpp PRE-CREATION 
  generators/chm/autotests/data/test.chm PRE-CREATION 
  generators/chm/generator_chm.cpp 871df9abc24b981b684fa3cb9d9568593fab2e48 

Diff: https://git.reviewboard.kde.org/r/130078/diff/


Testing
---

I created a small example chm file to test this. I can provide the file, if 
someone would like to have it.


Thanks,

Gilbert Assaf

Re: Review Request 130106: Bug 262265 chmlib should not send qFatal if encoding could not be guessed

2017-05-31 Thread Gilbert Assaf


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130106/
---

(Updated Mai 31, 2017, 11:03 vorm.)


Status
--

This change has been marked as submitted.


Review request for Okular.


Bugs: 262265
http://bugs.kde.org/show_bug.cgi?id=262265


Repository: okular


Description
---

Okular sends a 'qFatal()', if no encoding could be guessed. This will also 
create a core dump crashing Okular and all open document in this instance.


Diffs
-

  generators/chm/lib/libchmfileimpl.cpp 
3ae4e98ddf8876a996a34ab710ffa0ab71f52cde 

Diff: https://git.reviewboard.kde.org/r/130106/diff/


Testing
---


Thanks,

Gilbert Assaf

Re: Review Request 130113: kio_msits emits mimetype again

2017-05-31 Thread Gilbert Assaf


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130113/
---

(Updated Mai 31, 2017, 11:01 vorm.)


Status
--

This change has been marked as submitted.


Review request for Okular.


Repository: okular


Description
---

kio_msits emitting mimetype function ported to QT5. A kio slave should always 
emit the mimetype (see kio slave api doc).


Diffs
-

  generators/chm/kio-msits/msits.cpp 0a53e0c9d78373155cd0a0efb7fa667e62fb7e32 

Diff: https://git.reviewboard.kde.org/r/130113/diff/


Testing
---


Thanks,

Gilbert Assaf

Re: Review Request 130113: kio_msits emits mimetype again

2017-05-31 Thread Gilbert Assaf


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130113/#review103253
---


Ship it!




Ship It!

- Gilbert Assaf


On May 3, 2017, 1:40 p.m., Gilbert Assaf wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130113/
> ---
> 
> (Updated May 3, 2017, 1:40 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> kio_msits emitting mimetype function ported to QT5. A kio slave should always 
> emit the mimetype (see kio slave api doc).
> 
> 
> Diffs
> -
> 
>   generators/chm/kio-msits/msits.cpp 0a53e0c9d78373155cd0a0efb7fa667e62fb7e32 
> 
> Diff: https://git.reviewboard.kde.org/r/130113/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gilbert Assaf
> 
>

[okular] [Bug 377718] Can you kindly improve support for such CHM file like this ?

2017-05-25 Thread Gilbert Assaf

https://bugs.kde.org/show_bug.cgi?id=377718

--- Comment #5 from Gilbert Assaf <gas...@gmx.de> ---
I have downloaded the file! Thank you very much!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 377718] Can you kindly improve support for such CHM file like this ?

2017-05-24 Thread Gilbert Assaf

https://bugs.kde.org/show_bug.cgi?id=377718

Gilbert Assaf <gas...@gmx.de> changed:

   What|Removed |Added

 CC||gas...@gmx.de

--- Comment #3 from Gilbert Assaf <gas...@gmx.de> ---
@Albert: Could you provide me with this file? I will look into this and see
what I can do.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Review Request 130078: Bug 236688 - Sort pages according to TOC in CHM Files

2017-05-22 Thread Gilbert Assaf



> On Mai 21, 2017, 10:05 nachm., Albert Astals Cid wrote:
> > If you created test.chm rest looks good

Yes test.chm file was created by me


- Gilbert


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130078/#review103234
---


On April 26, 2017, 1:40 nachm., Gilbert Assaf wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130078/
> ---
> 
> (Updated April 26, 2017, 1:40 nachm.)
> 
> 
> Review request for Okular.
> 
> 
> Bugs: 236688
> http://bugs.kde.org/show_bug.cgi?id=236688
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> All pages in a CHM File are now ordered accordingly to TOC Data. If a page is 
> not in TOC, it will be added at the end.
> 
> 
> Diffs
> -
> 
>   generators/chm/CMakeLists.txt 22015955dba2519d485f22951e320694ebe82a7f 
>   generators/chm/autotests/chmgeneratortest.cpp PRE-CREATION 
>   generators/chm/autotests/data/test.chm PRE-CREATION 
>   generators/chm/generator_chm.cpp 871df9abc24b981b684fa3cb9d9568593fab2e48 
> 
> Diff: https://git.reviewboard.kde.org/r/130078/diff/
> 
> 
> Testing
> ---
> 
> I created a small example chm file to test this. I can provide the file, if 
> someone would like to have it.
> 
> 
> Thanks,
> 
> Gilbert Assaf
> 
>

Review Request 130127: CHM: zooming changes the font size

2017-05-12 Thread Gilbert Assaf


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130127/
---

Review request for Okular.


Bugs: 164198
http://bugs.kde.org/show_bug.cgi?id=164198


Repository: okular


Description
---

Transfers zoom handling from KHTML to KHTMLView and QImage.
This way the font now actually increases when you zoom in and zoom handling is 
more in line with the other generators.


Diffs
-

  generators/chm/generator_chm.h 0edaf87743062476aa12c31947a7d7c147b1e014 
  generators/chm/generator_chm.cpp 871df9abc24b981b684fa3cb9d9568593fab2e48 

Diff: https://git.reviewboard.kde.org/r/130127/diff/


Testing
---


Thanks,

Gilbert Assaf

[okular] [Bug 377454] Please add ability to "edit outlines (contents)"

2017-05-08 Thread Gilbert Assaf

https://bugs.kde.org/show_bug.cgi?id=377454

Gilbert Assaf <gas...@gmx.de> changed:

   What|Removed |Added

 CC||gas...@gmx.de

--- Comment #3 from Gilbert Assaf <gas...@gmx.de> ---
Hi, I am sorry, but this fix is for bug #190203 only.
It allows you to create bookmarks for outline elements from the Table of
Contents, which are automatically named after that item.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Review Request 130113: kio_msits emits mimetype again

2017-05-03 Thread Gilbert Assaf


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130113/
---

Review request for Okular.


Repository: okular


Description
---

kio_msits emitting mimetype function ported to QT5. A kio slave should always 
emit the mimetype (see kio slave api doc).


Diffs
-

  generators/chm/kio-msits/msits.cpp 0a53e0c9d78373155cd0a0efb7fa667e62fb7e32 

Diff: https://git.reviewboard.kde.org/r/130113/diff/


Testing
---


Thanks,

Gilbert Assaf

Re: Review Request 130078: Bug 236688 - Sort pages according to TOC in CHM Files

2017-04-26 Thread Gilbert Assaf


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130078/
---

(Updated April 26, 2017, 1:40 nachm.)


Review request for Okular.


Changes
---

I added an unit test, I figured this might be helpful for reviewing this patch.


Bugs: 236688
http://bugs.kde.org/show_bug.cgi?id=236688


Repository: okular


Description
---

All pages in a CHM File are now ordered accordingly to TOC Data. If a page is 
not in TOC, it will be added at the end.


Diffs (updated)
-

  generators/chm/CMakeLists.txt 22015955dba2519d485f22951e320694ebe82a7f 
  generators/chm/autotests/chmgeneratortest.cpp PRE-CREATION 
  generators/chm/autotests/data/test.chm PRE-CREATION 
  generators/chm/generator_chm.cpp 871df9abc24b981b684fa3cb9d9568593fab2e48 

Diff: https://git.reviewboard.kde.org/r/130078/diff/


Testing
---

I created a small example chm file to test this. I can provide the file, if 
someone would like to have it.


Thanks,

Gilbert Assaf

Review Request 130106: Bug 262265 chmlib should not send qFatal if encoding could not be guessed

2017-04-26 Thread Gilbert Assaf


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130106/
---

Review request for Okular.


Bugs: 262265
http://bugs.kde.org/show_bug.cgi?id=262265


Repository: okular


Description
---

Okular sends a 'qFatal()', if no encoding could be guessed. This will also 
create a core dump crashing Okular and all open document in this instance.


Diffs
-

  generators/chm/lib/libchmfileimpl.cpp 
3ae4e98ddf8876a996a34ab710ffa0ab71f52cde 

Diff: https://git.reviewboard.kde.org/r/130106/diff/


Testing
---


Thanks,

Gilbert Assaf

[okular] [Bug 262265] crashes with chm (text encoding by LCID)

2017-04-25 Thread Gilbert Assaf

https://bugs.kde.org/show_bug.cgi?id=262265

Gilbert Assaf <gas...@gmx.de> changed:

   What|Removed |Added

 CC||gas...@gmx.de

--- Comment #3 from Gilbert Assaf <gas...@gmx.de> ---
The attached file has no coding specified. This causes Okular to crash. You can
only open this file, if you force Okular to use utf8 (only possible in code),
but it stills looks broken. And I don't think it is a good idea to assume utf8
if no encoding is provided.

I tried to open this file on Windows, but Microsofts own chm viewer only shows
garbage and doesn't display any content.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: PDFium plugin

2017-04-19 Thread Gilbert Assaf

I just wanted to give you an update on my pdfium_generator implementation.
At this point it is usable for viewing and browsing a pdf:

What works: TOC, mark and copy text, follow internal/external links, printing

BUT the pdfium API still has a lot of things missing:

- No public API to access embedded files:
https://bugs.chromium.org/p/pdfium/issues/detail?id=174

- No public API to access font Informations:
https://bugs.chromium.org/p/pdfium/issues/detail?id=668

- Hard to ship for distributions:
https://bugs.chromium.org/p/pdfium/issues/detail?id=451
pdfium is currently a mixture of static and shared libs.

- Doesn't support Movie Annotations:
https://bugs.chromium.org/p/pdfium/issues/detail?id=577

- No public API to access Annotations:
https://bugs.chromium.org/p/pdfium/issues/detail?id=671
pdfium can render Annotations, but this is not compatible how Okular does things.
You don't have any control over it, pdfium just returns the render buffer filled with Annotation content.

- The same goes for Forms! Although it may be possible to write a wrapper API for Forms, but this will take A LOT of work.

- Doesn't support printing as postscript.

On the upside: It has _javascript_ support and sometimes renders things "better" than poppler. But I don't think switching to pdfium is a good idea for Okular in the near future.

Gesendet: Samstag, 21. Januar 2017 um 15:44 Uhr
Von: "Gilbert Assaf" <gas...@gmx.de>
An: okular-devel@kde.org
Betreff: Re: PDFium plugin

I decided to create an pdfium_generator branch, as Albert suggested. I guess the main focus from the pdfium guys is chromium support. But they have at least some pending issues in their bug tracker, which might change things in the future.  And it will take some time anyway to have a fully working pdfium plugin...

Gesendet: Mittwoch, 18. Januar 2017 um 08:02 Uhr
Von: "Jonathan Schultz" <jonat...@imatix.com>
An: "Okular development" <okular-devel@kde.org>, "Gilbert Assaf" <gas...@gmx.de>
Betreff: Re: PDFium plugin

Please excuse the silly comment about providing an executable - I see
that you said that we'd have to build it ourselves.

So I just tried building, got most of the way without a hitch. I had to
also use ninja build libfx_lpng.a and libfx_freetype.a to satisfy the
dependencies in the okular Makefile. But once that was done it seems to
work. I wasn't too sure that it was actually using pdfium, but when I
moved the poppler generator out of the way I could see that it is
working. Some small differences in appearance... So at least it works as
a proof-of-concept...

On 18/01/17 10:14, Jonathan Schultz wrote:
> Looks interesting. How does it compare (performance, features, etc.)
> with the Poppler plugin?
>
> Any chance you could save us the bother of building ourselves and post a
> link to an executable?
>
> Cheers,
> Jonathan
>
> On 18/01/17 03:30, Gilbert Assaf wrote:
>> Hi all,
>>
>> I worked on an okular pdf plugin using pdfium as a backend. At this
>> point it is little more than a “proof-of-concept”. But you can already
>> view simple pdf files.
>>
>> I would like to get some feedback on this: maybe somebody else is
>> already working on an okular pdfium plugin? I am relatively new to KDE
>> and don’t know all the development processes.
>> How do you normally proceed from here on? Reviewboard? A personal branch?
>>
>> I attached a git patch file, if somebody would like to try it out.
>>
>> A small warning: pdfium only works on x64 and at this point it is
>> basically a mixture of static and shared libraries. So you definitely
>> have to compile it yourself.
>>
>> Thanks,
>> Gilbert
>>
>> === Install depot tools ===
>> Needed for fetching and building pdfium
>> See instructions:
>> https://www.chromium.org/developers/how-tos/install-depot-tools
>>
>> === Install pdfium ===
>> mkdir repo
>> cd repo
>> gclient config --unmanaged https://pdfium.googlesource.com/pdfium.git
>> gclient sync
>> cd pdfium
>> export PDFIUM_DIR=`pwd`
>> gn gen out/Debug --args="pdf_enable_xfa=false pdf_enable_v8=true
>> use_sysroot=false is_debug=true"
>> ninja -C out/Debug pdfium
>>
>> === Compile Okular ===
>> cd 
>> cmake .. -DPDFIUM_ROOT_DIR=$PDFIUM_DIR
>> You probably have to add $PDFIUM_DIR dir to your LD_LIBRARY_PATH variable
>

Re: Review Request 130078: Bug 236688 - Sort pages according to TOC in CHM Files

2017-04-18 Thread Gilbert Assaf



> On April 12, 2017, 12:58 p.m., Albert Astals Cid wrote:
> > Did you forget to attach the diff?

Oops, I knew I forgot something.. :-/


- Gilbert


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130078/#review103032
---


On April 18, 2017, 2:09 p.m., Gilbert Assaf wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130078/
> ---
> 
> (Updated April 18, 2017, 2:09 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Bugs: 236688
> http://bugs.kde.org/show_bug.cgi?id=236688
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> All pages in a CHM File are now ordered accordingly to TOC Data. If a page is 
> not in TOC, it will be added at the end.
> 
> 
> Diffs
> -
> 
>   generators/chm/generator_chm.cpp 871df9abc24b981b684fa3cb9d9568593fab2e48 
> 
> Diff: https://git.reviewboard.kde.org/r/130078/diff/
> 
> 
> Testing
> ---
> 
> I created a small example chm file to test this. I can provide the file, if 
> someone would like to have it.
> 
> 
> Thanks,
> 
> Gilbert Assaf
> 
>

Re: Review Request 130078: Bug 236688 - Sort pages according to TOC in CHM Files

2017-04-18 Thread Gilbert Assaf


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130078/
---

(Updated April 18, 2017, 2:09 p.m.)


Review request for Okular.


Bugs: 236688
http://bugs.kde.org/show_bug.cgi?id=236688


Repository: okular


Description
---

All pages in a CHM File are now ordered accordingly to TOC Data. If a page is 
not in TOC, it will be added at the end.


Diffs (updated)
-

  generators/chm/generator_chm.cpp 871df9abc24b981b684fa3cb9d9568593fab2e48 

Diff: https://git.reviewboard.kde.org/r/130078/diff/


Testing
---

I created a small example chm file to test this. I can provide the file, if 
someone would like to have it.


Thanks,

Gilbert Assaf

Review Request 130078: Bug 236688 - Sort pages according to TOC in CHM Files

2017-04-10 Thread Gilbert Assaf


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130078/
---

Review request for Okular.


Summary (updated)
-

Bug 236688 - Sort pages according to TOC in CHM Files


Bugs: 236688
http://bugs.kde.org/show_bug.cgi?id=236688


Repository: okular


Description (updated)
---

All pages in a CHM File are now ordered accordingly to TOC Data. If a page is 
not in TOC, it will be added at the end.


Diffs
-


Diff: https://git.reviewboard.kde.org/r/130078/diff/


Testing (updated)
---

I created a small example chm file to test this. I can provide the file, if 
someone would like to have it.


Thanks,

Gilbert Assaf

[okular] [Bug 370949] PDF bookmarks off by one

2017-04-07 Thread Gilbert Assaf

https://bugs.kde.org/show_bug.cgi?id=370949

Gilbert Assaf <gas...@gmx.de> changed:

   What|Removed |Added

 CC||gas...@gmx.de

--- Comment #2 from Gilbert Assaf <gas...@gmx.de> ---
I can reproduce this problem, with current Master. But I think it's a Bug in
poppler. I also tested it with various other pdf readers:

Okular: Bookmarks are off by one
Firefox: Same Problem
Evince: Same Problem
Chromium: Works fine
Adobe Reader: Works fine

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Review Request 130057: Bug 288042 - Option to reset forms

2017-03-30 Thread Gilbert Assaf


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130057/
---

(Updated March 30, 2017, 7 p.m.)


Review request for Okular.


Changes
---

I updated my patch accordingly. Thanks for the suggestion.


Bugs: 288042
http://bugs.kde.org/show_bug.cgi?id=288042


Repository: okular


Description
---

Clear Contents of FormLineEdit, TextAreaEdit and FileEdit + unchecks 
CheckBoxEdit and ListEdit form elements. 

I don't touch RadioBoxes and ComboBoxes, because I am not sure, to which state 
I should reset/clear them. Especially for ComboBox, I am not sure if clearing 
them could be harmful.


Diffs (updated)
-

  part.rc 34a1160ef5d7b8f65e14a457f1b39bbb06fe3074 
  ui/formwidgets.h b1bc11a4f7048935614ad384cc49dd1cd2b1336c 
  ui/formwidgets.cpp 6ab49b0ed9fa3ba71486cf45e89e46c7b0f61d3f 
  ui/pageview.h 43b03b0f677781cb92402e8291335424da210b65 
  ui/pageview.cpp 88ffe62418f3b68ca8c2314c54f13226d2ed6191 
  ui/pageviewutils.h ca8bd78a4d78cb2e779b5b682c66fa60bcb3af80 
  ui/pageviewutils.cpp a57712ca235b2ca629f5739ad73488d513416d0c 

Diff: https://git.reviewboard.kde.org/r/130057/diff/


Testing
---


Thanks,

Gilbert Assaf

Review Request 130057: Bug 288042 - Option to reset forms

2017-03-29 Thread Gilbert Assaf


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130057/
---

Review request for Okular.


Bugs: 288042
http://bugs.kde.org/show_bug.cgi?id=288042


Repository: okular


Description
---

Clear Contents of FormLineEdit, TextAreaEdit and FileEdit + unchecks 
CheckBoxEdit and ListEdit form elements. 

I don't touch RadioBoxes and ComboBoxes, because I am not sure, to which state 
I should reset/clear them. Especially for ComboBox, I am not sure if clearing 
them could be harmful.


Diffs
-

  part.rc 34a1160ef5d7b8f65e14a457f1b39bbb06fe3074 
  ui/formwidgets.h b1bc11a4f7048935614ad384cc49dd1cd2b1336c 
  ui/formwidgets.cpp 6ab49b0ed9fa3ba71486cf45e89e46c7b0f61d3f 
  ui/pageview.h 43b03b0f677781cb92402e8291335424da210b65 
  ui/pageview.cpp 88ffe62418f3b68ca8c2314c54f13226d2ed6191 
  ui/pageviewutils.h ca8bd78a4d78cb2e779b5b682c66fa60bcb3af80 
  ui/pageviewutils.cpp a57712ca235b2ca629f5739ad73488d513416d0c 

Diff: https://git.reviewboard.kde.org/r/130057/diff/


Testing
---


Thanks,

Gilbert Assaf

Re: Review Request 129999: Allow to create bookmarks from the TOC

2017-03-22 Thread Gilbert Assaf


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/12/
---

(Updated March 23, 2017, 12:23 a.m.)


Status
--

This change has been marked as submitted.


Review request for Okular.


Changes
---

Submitted with commit a2aceadc13ea4917dff2c58f470dd6eb8bc2cf53 by Albert Astals 
Cid on behalf of Gilbert Assaf to branch Applications/17.04.


Bugs: 190203
http://bugs.kde.org/show_bug.cgi?id=190203


Repository: okular


Description
---

If a bookmark is created from the TOC view, the text of the selected TOC item 
text is automatically used. Otherwise the behavior stays unchanged.


Diffs
-

  part.h f4c50ab 
  part.cpp 198197a 
  ui/toc.h 5e7fe2a 
  ui/toc.cpp a205ad1 

Diff: https://git.reviewboard.kde.org/r/12/diff/


Testing
---


Thanks,

Gilbert Assaf

Re: Review Request 129999: Allow to create bookmarks from the TOC

2017-03-20 Thread Gilbert Assaf


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/12/
---

(Updated March 20, 2017, 3:37 p.m.)


Review request for Okular.


Changes
---

Ok I see your point. I rewrote my patch to use a right click context menu on 
the TOC items.


Bugs: 190203
http://bugs.kde.org/show_bug.cgi?id=190203


Repository: okular


Description
---

If a bookmark is created from the TOC view, the text of the selected TOC item 
text is automatically used. Otherwise the behavior stays unchanged.


Diffs (updated)
-

  part.h f4c50ab 
  part.cpp 198197a 
  ui/toc.h 5e7fe2a 
  ui/toc.cpp a205ad1 

Diff: https://git.reviewboard.kde.org/r/12/diff/


Testing
---


Thanks,

Gilbert Assaf

Review Request 129999: Allow to create bookmarks from the TOC

2017-03-09 Thread Gilbert Assaf


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/12/
---

Review request for Okular.


Bugs: 190203
http://bugs.kde.org/show_bug.cgi?id=190203


Repository: okular


Description
---

If a bookmark is created from the TOC view, the text of the selected TOC item 
text is automatically used. Otherwise the behavior stays unchanged.


Diffs
-

  part.cpp 198197a5f4f5f09b3e30efbc7798ecef5f637ca7 
  ui/toc.h 5e7fe2a39ee5245379844fa0392a628a6e7f5c78 
  ui/toc.cpp a205ad1c577b81e9059620d03ffd86bab033813c 

Diff: https://git.reviewboard.kde.org/r/12/diff/


Testing
---


Thanks,

Gilbert Assaf

[okular] [Bug 353302] Txt Backend does not display Arabic text

2017-02-23 Thread Gilbert Assaf

https://bugs.kde.org/show_bug.cgi?id=353302

Gilbert Assaf <gas...@gmx.de> changed:

   What|Removed |Added

 CC||gas...@gmx.de

--- Comment #2 from Gilbert Assaf <gas...@gmx.de> ---
KEncodingProber doesn't work correctly with this file. This causes Okular to
not be able to read this file. A similar bug can be found here:
https://bugs.kde.org/show_bug.cgi?id=334733

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: PDFium plugin

2017-01-21 Thread Gilbert Assaf

I decided to create an pdfium_generator branch, as Albert suggested. I guess the main focus from the pdfium guys is chromium support. But they have at least some pending issues in their bug tracker, which might change things in the future.  And it will take some time anyway to have a fully working pdfium plugin...

Gesendet: Mittwoch, 18. Januar 2017 um 08:02 Uhr
Von: "Jonathan Schultz" <jonat...@imatix.com>
An: "Okular development" <okular-devel@kde.org>, "Gilbert Assaf" <gas...@gmx.de>
Betreff: Re: PDFium plugin

Please excuse the silly comment about providing an executable - I see
that you said that we'd have to build it ourselves.

So I just tried building, got most of the way without a hitch. I had to
also use ninja build libfx_lpng.a and libfx_freetype.a to satisfy the
dependencies in the okular Makefile. But once that was done it seems to
work. I wasn't too sure that it was actually using pdfium, but when I
moved the poppler generator out of the way I could see that it is
working. Some small differences in appearance... So at least it works as
a proof-of-concept...

On 18/01/17 10:14, Jonathan Schultz wrote:
> Looks interesting. How does it compare (performance, features, etc.)
> with the Poppler plugin?
>
> Any chance you could save us the bother of building ourselves and post a
> link to an executable?
>
> Cheers,
> Jonathan
>
> On 18/01/17 03:30, Gilbert Assaf wrote:
>> Hi all,
>>
>> I worked on an okular pdf plugin using pdfium as a backend. At this
>> point it is little more than a “proof-of-concept”. But you can already
>> view simple pdf files.
>>
>> I would like to get some feedback on this: maybe somebody else is
>> already working on an okular pdfium plugin? I am relatively new to KDE
>> and don’t know all the development processes.
>> How do you normally proceed from here on? Reviewboard? A personal branch?
>>
>> I attached a git patch file, if somebody would like to try it out.
>>
>> A small warning: pdfium only works on x64 and at this point it is
>> basically a mixture of static and shared libraries. So you definitely
>> have to compile it yourself.
>>
>> Thanks,
>> Gilbert
>>
>> === Install depot tools ===
>> Needed for fetching and building pdfium
>> See instructions:
>> https://www.chromium.org/developers/how-tos/install-depot-tools
>>
>> === Install pdfium ===
>> mkdir repo
>> cd repo
>> gclient config --unmanaged https://pdfium.googlesource.com/pdfium.git
>> gclient sync
>> cd pdfium
>> export PDFIUM_DIR=`pwd`
>> gn gen out/Debug --args="pdf_enable_xfa=false pdf_enable_v8=true
>> use_sysroot=false is_debug=true"
>> ninja -C out/Debug pdfium
>>
>> === Compile Okular ===
>> cd 
>> cmake .. -DPDFIUM_ROOT_DIR=$PDFIUM_DIR
>> You probably have to add $PDFIUM_DIR dir to your LD_LIBRARY_PATH variable
>

PDFium plugin

2017-01-17 Thread Gilbert Assaf


Hi all,

 

I worked on an okular pdf plugin using pdfium as a backend. At this point it is little more than a “proof-of-concept”. But you can already view simple pdf files.  


I would like to get some feedback on this: maybe somebody else is already working on an okular pdfium plugin? I am relatively new to KDE and don’t know all the development processes.
How do you normally proceed from here on? Reviewboard? A personal branch?

 

I attached a git patch file, if somebody would like to try it out.


A small warning: pdfium only works on x64 and at this point it is basically a mixture of static and shared libraries. So you definitely have to compile it yourself.

 

Thanks,
Gilbert


=== Install depot tools ===
Needed for fetching and building pdfium
See instructions:
https://www.chromium.org/developers/how-tos/install-depot-tools

 

=== Install pdfium ===
mkdir repo
cd repo
gclient config --unmanaged https://pdfium.googlesource.com/pdfium.git
gclient sync
cd pdfium
export PDFIUM_DIR=`pwd`
gn gen out/Debug --args="pdf_enable_xfa=false pdf_enable_v8=true use_sysroot=false is_debug=true"
ninja -C out/Debug pdfium


=== Compile Okular ===
cd 
cmake .. -DPDFIUM_ROOT_DIR=$PDFIUM_DIR

You probably have to add $PDFIUM_DIR dir to your LD_LIBRARY_PATH variable


pdfium.tar.gz
Description: Binary data

55 matches

Mail list logo