[okular] [Bug 370217] [frameworks] Line width of freehand annotation is resolution dependent

2016-10-16 Thread Oliver Sander via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=370217

--- Comment #3 from Oliver Sander  ---
Thanks for the hint.  I played around with this a little.  It seems that the
initial drawing code is buggier than I though.  Simply multiplying the zoom
factor to the pen width doesn't cut it.  You can witness the problems without
patching okular: go to Options -> set up Okular -> Annotations -> freehand -->
edit and set the line width to something large, like 20.  When I do this, the
drawing becomes very blocky, the pen width is not constant anymore, and
sometimes parts of what I draw are not shown.

Any ideas?  I may look some more into this, but currently I am out of ideas.

-- 
You are receiving this mail because:
You are the assignee for the bug.


[okular] [Bug 370217] [frameworks] Line width of freehand annotation is resolution dependent

2016-10-13 Thread Oliver Sander via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=370217

--- Comment #1 from Oliver Sander  ---
Friendly ping :-)

-- 
You are receiving this mail because:
You are the assignee for the bug.


[okular] [Bug 321992] Feature request: Can the highlighter automatically fill the attached pop-up note with highlighted text.

2016-10-07 Thread Oliver Sander via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=321992

Oliver Sander  changed:

   What|Removed |Added

 CC||oliver.san...@tu-dresden.de

--- Comment #14 from Oliver Sander  ---
It's not me who decides what goes into okular and what doesn't, but I know that
your chances increase if you upload the patch to
https://git.reviewboard.kde.org .

-- 
You are receiving this mail because:
You are the assignee for the bug.


[okular] [Bug 370217] New: [frameworks] Line width of freehand annotation is resolution dependent

2016-10-06 Thread Oliver Sander via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=370217

Bug ID: 370217
   Summary: [frameworks] Line width of freehand annotation is
resolution dependent
   Product: okular
   Version: unspecified
  Platform: Compiled Sources
OS: Linux
Status: UNCONFIRMED
  Severity: minor
  Priority: NOR
 Component: general
  Assignee: okular-devel@kde.org
  Reporter: oliver.san...@tu-dresden.de

Try drawing a freehand annotation on a pdf document (F6 and then the third icon
from the top).  You will see it appear while you draw.  Then as you lift off
the pen / release the mouse button, it will disappear very briefly, and then
reappear.  The bug is that the line also changes its width at the same moment.

Here is what I think is happening: the line is drawn by two different parts of
the code before and after you release the mouse button.  While you draw, the
line is drawn by a QPen object constructed in annotationtools.cpp:158.  The pen
width is

const qreal penWidth = m_annotElement.attribute( QStringLiteral("width"),
QStringLiteral("1.0") ).toDouble();

from three lines above.  Once the mouse button is released, the line is redrawn
by code somewhere else, and I haven't been able to find where.  I don't know
how the pen width is computed there.

I played around with my screen resolution and it seems that the problem is that
the first drawing code does not take screen resolution into account, while the
second one does.  I am interested in debugging this further, but I need some
help: where is the code that draws the freehand annotation after the initial
drawing is completed?  I suppose that comparing the two will explain why the
line widths differ.

Reproducible: Always

-- 
You are receiving this mail because:
You are the assignee for the bug.


[okular] [Bug 366781] [frameworks] Implement zooming with a pinch gesture on a touch screen

2016-09-03 Thread Oliver Sander via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=366781

--- Comment #2 from Oliver Sander  ---
I managed to upload the patch to reviewboard after all:

https://git.reviewboard.kde.org/r/128821/

Unlike the patch that I attached above, the one at reviewboard applies directly
to the frameworks branch, and contains all necessary gesture-grabbing
infrastructure.  Therefore,

https://git.reviewboard.kde.org/r/126809/ 

is not needed.  Instead, the two will conflict.  I'll update one as soon as the
other one is committed.

-- 
You are receiving this mail because:
You are the assignee for the bug.


[okular] [Bug 367959] Okular mangles some characters (non embedded fonts)

2016-08-29 Thread Oliver Sander via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=367959

Oliver Sander  changed:

   What|Removed |Added

 CC||oliver.san...@tu-dresden.de

--- Comment #4 from Oliver Sander  ---
Confirmed on

Qt: 4.8.7
KDE: 4.14.23
Okular: 0.25.0
poppler 0.44.0
Debian Testing

-- 
You are receiving this mail because:
You are the assignee for the bug.


[okular] [Bug 366785] Crash while oprning PDF from Google slides.

2016-08-15 Thread Oliver Sander via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=366785

Oliver Sander  changed:

   What|Removed |Added

 CC||oliver.san...@tu-dresden.de

--- Comment #2 from Oliver Sander  ---
Works for me:  Debian Testing

Qt: 4.8.7
KDE: 4.14.22
Okular: 0.25.0

poppler:  0.44.0-3

-- 
You are receiving this mail because:
You are the assignee for the bug.


[okular] [Bug 366781] [frameworks] Implement zooming with a pinch gesture on a touch screen

2016-08-15 Thread Oliver Sander via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=366781

Oliver Sander  changed:

   What|Removed |Added

Summary|Implement zooming with a|[frameworks] Implement
   |pinch gesture on a touch|zooming with a pinch
   |screen  |gesture on a touch screen

-- 
You are receiving this mail because:
You are the assignee for the bug.


[okular] [Bug 366781] Implement zooming with a pinch gesture on a touch screen

2016-08-15 Thread Oliver Sander via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=366781

--- Comment #1 from Oliver Sander  ---
Created attachment 100602
  --> https://bugs.kde.org/attachment.cgi?id=100602=edit
Implement zooming with a two-finger pinch gesture on a touch screen.

Needs the framework branch and

https://git.reviewboard.kde.org/r/126809/

-- 
You are receiving this mail because:
You are the assignee for the bug.


[okular] [Bug 366781] New: Implement zooming with a pinch gesture on a touch screen

2016-08-15 Thread Oliver Sander via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=366781

Bug ID: 366781
   Summary: Implement zooming with a pinch gesture on a touch
screen
   Product: okular
   Version: 0.25.80
  Platform: Compiled Sources
OS: Linux
Status: UNCONFIRMED
  Severity: wishlist
  Priority: NOR
 Component: general
  Assignee: okular-devel@kde.org
  Reporter: oliver.san...@tu-dresden.de

The attached patch implements document zoom controlled by a two-finger pinch
gesture on a touch screen.  Can somebody please have a look at this?  The
actual zooming was done by copy'n'paste, I don't understand the full details of
how zooming works in okular, yet.

I tested it on my Lenovo Thinkpad Yoga, and it works nicely.

The patch needs some infrastructure from
https://git.reviewboard.kde.org/r/126809/ 
On request, I can easily extract that infrastructure into a separate patch, or
include it with this one here.

Unfortunately, I can't get ReviewBoard to accept the patch file.  The error
message is

"The uploaded diff uses short revisions, but Review Board requires full
revisions. Please generate a new diff using the --full-index parameter."

And when doing as told, I get 

"The specified diff file could not be parsed.
Line undefined: fatal: git cat-file 36b31779250246b13f1096f0af443027058d989e:
bad file "

Any ideas?


Reproducible: Always

-- 
You are receiving this mail because:
You are the assignee for the bug.


[okular] [Bug 366617] okular crash when opening a pdfmod generated file

2016-08-11 Thread Oliver Sander via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=366617

--- Comment #10 from Oliver Sander  ---
According to the original trace, the segfault happens in poppler, so maybe you
should start with that.

-- 
You are receiving this mail because:
You are the assignee for the bug.


[okular] [Bug 366617] okular crash when opening a pdfmod generated file

2016-08-11 Thread Oliver Sander via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=366617

--- Comment #7 from Oliver Sander  ---
I don't know how to do it on ArchLinux.  DuckDuckGo gave me the following link,
which appears to go into the right direction:

https://wiki.archlinux.org/index.php/Debug_-_Getting_Traces

-- 
You are receiving this mail because:
You are the assignee for the bug.


[okular] [Bug 366617] okular crash when opening a pdfmod generated file

2016-08-11 Thread Oliver Sander via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=366617

--- Comment #3 from Oliver Sander  ---
It works for me.  Is your okular/poppler too old?  Mine is

$okular --version
Qt: 4.8.7
KDE: 4.14.22
Okular: 0.25.0

$apt show libpoppler-dev
Package: libpoppler-dev
Version: 0.44.0-3

on an up-to-date Debian Testing.

-- 
You are receiving this mail because:
You are the assignee for the bug.


[Okular-devel] [okular] [Bug 365460] PDF Version 1.7 - Document Password needed

2016-07-12 Thread Oliver Sander via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=365460

Oliver Sander  changed:

   What|Removed |Added

 CC||oliver.san...@tu-dresden.de

--- Comment #1 from Oliver Sander  ---
Do you  mean this one:

https://www.bundesbank.de/Redaktion/DE/Downloads/Aufgaben/Unbarer_Zahlungsverkehr/Vordrucke/7000_c3_einreichungsverzeichnis_auslandsschecks.pdf

I can open it without issues.  (It has only one page, right?)  Maybe your
okular/poppler is too old?
Mine are

Qt: 4.8.7
KDE: 4.14.21
Okular: 0.25.0
Poppler 0.44
(all from Debian testing)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 177778] make it possible to resize resizable annotations

2016-03-04 Thread Oliver Sander via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=18

Oliver Sander  changed:

   What|Removed |Added

 CC||oliver.san...@tu-dresden.de

--- Comment #13 from Oliver Sander  ---
The Berlin office of KDAB got hired several times to implement support for
embedded movies in okular.  That worked out very nicely.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 346979] Touch control and basic gestures

2016-01-18 Thread Oliver Sander via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=346979

Oliver Sander  changed:

   What|Removed |Added

 CC||oliver.san...@tu-dresden.de

--- Comment #5 from Oliver Sander  ---
Some progress:
https://git.reviewboard.kde.org/r/126809/
https://git.reviewboard.kde.org/r/125847/

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 357822] Superscript characters sometimes not displayed

2016-01-11 Thread Oliver Sander via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=357822

Oliver Sander  changed:

   What|Removed |Added

 CC||oliver.san...@tu-dresden.de

--- Comment #4 from Oliver Sander  ---
I can reproduce the problem with pdftotext version 0.38.0 from Debian testing.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 357822] Superscript characters sometimes not displayed

2016-01-11 Thread Oliver Sander via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=357822

--- Comment #9 from Oliver Sander  ---
My freetype version appears to be 2.6.1 (says my Debian package manager).

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 357822] Superscript characters sometimes not displayed

2016-01-11 Thread Oliver Sander via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=357822

--- Comment #8 from Oliver Sander  ---
Created attachment 96596
  --> https://bugs.kde.org/attachment.cgi?id=96596=edit
Screenshot of my file->properties->fonts

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 357579] Okular-15.12.0: page numbers text area not sized correctly when refreshing a document

2016-01-05 Thread Oliver Sander via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=357579

Oliver Sander  changed:

   What|Removed |Added

 CC||oliver.san...@tu-dresden.de

--- Comment #2 from Oliver Sander  ---
I can confirm this.  There are more ways to make the mis-rendering go away
(temporarily), e.g., moving to a different page.

~ okular --version
Qt: 4.8.7
KDE: 4.14.14
Okular: 0.23.2
(from today's Debian testing, using the MATE desktop)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 341318] Save for every document whether it is viewed in continuous mode or not

2015-12-11 Thread Oliver Sander via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=341318

Oliver Sander  changed:

   What|Removed |Added

 CC||oliver.san...@tu-dresden.de

--- Comment #10 from Oliver Sander  ---
Is there anything I can do to make this patch land in master?  Unfortunately,
36h days are currently out of stock, but I would volunteer to work on the patch
if somebody tells me what precisely remains to be done.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 355530] Remember my choice in Navigation panel

2015-11-24 Thread Oliver Sander via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=355530

Oliver Sander  changed:

   What|Removed |Added

 CC||oliver.san...@tu-dresden.de

--- Comment #6 from Oliver Sander  ---
Sorry, but no.  You need to open three separate bug reports, so your three
wishes get three different numbers, and can be commented on separately.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 354012] Wish: change page by swiping on touchscreen during presentation mode

2015-10-28 Thread Oliver Sander via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=354012

--- Comment #5 from Oliver Sander  ---
Fair enough.  I have now posted my patch against the 'frameworks' branch:

https://git.reviewboard.kde.org/r/125847/

Maybe somebody finds it useful, or knows what to do to get it to work on
master.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 354012] Wish: change page by swiping on touchscreen during presentation mode

2015-10-26 Thread Oliver Sander via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=354012

--- Comment #3 from Oliver Sander  ---
I was afraid you were going to say this... :-)

I just spent the last two hours unsuccessfully trying to port the patch from
the frameworks branch to master.  Qt4 replaces the touch events (from the
touchpad) with mouse events, which then of course do not allow gestures.  In
Qt5 there is 

QCoreApplication::setAttribute(Qt::AA_SynthesizeMouseForUnhandledTouchEvents,false);

which disables this behavior, but I have no clue how to do the same in Qt4. 
Does anybody have an idea?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 354012] Wish: change page by swiping on touchscreen during presentation mode

2015-10-25 Thread Oliver Sander via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=354012

--- Comment #1 from Oliver Sander  ---
I wrote a patch for this.  Albert, do you want this for the master branch or
the frameworks branch?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 354016] Spurious straight lines when leaving drawing area in presentation mode

2015-10-18 Thread Oliver Sander via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=354016

--- Comment #4 from Oliver Sander  ---
It does work, apologies for the hassle.  I do understand the problem, but with
Tobias' recent improvements to the presentationwidget I am stuck on that branch
now.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 354016] Spurious straight lines when leaving drawing area in presentation mode

2015-10-18 Thread Oliver Sander via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=354016

--- Comment #2 from Oliver Sander  ---
Hi, many thanks for the quick fix.  Could somebody forward-port this to the
'frameworks' branch?  (I tried but failed.)  I need this fix together with the
mult-color drawing feature in presentation mode.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 354012] New: Wish: change page by swiping on touchscreen during presentation mode

2015-10-17 Thread Oliver Sander via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=354012

Bug ID: 354012
   Summary: Wish: change page by swiping on touchscreen during
presentation mode
   Product: okular
   Version: unspecified
  Platform: Compiled Sources
OS: Linux
Status: UNCONFIRMED
  Severity: wishlist
  Priority: NOR
 Component: general
  Assignee: okular-devel@kde.org
  Reporter: oliver.san...@tu-dresden.de

I have a thinkpad yoga which has a touchpad, a touchscreen, and a pen.  All
three are separate input devices.  The keyboard and touchpad can fold away
completely, which leaves you with a tablet-like device.  I use this to do
presentations.  I cannot leave the keyboard there while presenting because I
draw on my slides with the pen, and the keyboard gets in the way of my drawing
hand.

However, in presentation mode, left mouse click goes to the next page, and
right mouse click goes to the previous one.  However, using the touchpad
buttons is not an option as the keyboard is folded away.  A finger tap on the
touchscreen is interpreted as left click, so I can go forward in the
presentation, but not backward.

My wish: please make okular let me get to the next/previous page of a
presentation when I do a left-to-right/right-to-left swiping gesture on the
touchscreen.

The make things a bit more complicated: [I am not sure whether the following is
a separate wish or not]  When I'm presenting, I have one of the drawing tools
activated basically all of the time.  I can draw okay with the pen.  However,
my finger (remember: that's not the same input device as the pen) is also wired
to 'drawing'.  Consequences:  a) I cannot change the page at all anymore. b) I
cannot rest my palm on the touchscreen for writing, because okular interprets
my palm as an attempt to draw something.

I know of related wishes such as https://bugs.kde.org/show_bug.cgi?id=346979
In contrast to others, I try here to focus on a single issue only, so it is not
a duplicate.

Reproducible: Always

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 354016] New: Spurious straight lines when leaving drawing area in presentation mode

2015-10-17 Thread Oliver Sander via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=354016

Bug ID: 354016
   Summary: Spurious straight lines when leaving drawing area in
presentation mode
   Product: okular
   Version: unspecified
  Platform: Compiled Sources
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: okular-devel@kde.org
  Reporter: oliver.san...@tu-dresden.de

The following steps produce spurious lines when using the drawing tools in
presentation mode.

1) Open a file
2) Go to presentation mode
3) Pick a drawing tool from the toolbar at the top
4) Start drawing.  Draw a line that leaves the page to the left or the right.
   (typically the screen is wider than the page, and there is a black area both
to the left
   and to the right)
5) Continue drawing somewhere else on the page

Result: there is a line from the point where you left the drawing area in 4) to
the point where started again in 5)


Reproducible: Always

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel