[okular] [Bug 419109] Preserve extended attributes when saving a file
https://bugs.kde.org/show_bug.cgi?id=419109 --- Comment #8 from Stefan Brüns --- (In reply to Manu from comment #6) > maybe out of my depth here, but I think that goes against the baloo > philosophy: if you do that, then *every* program handling the file must know > about those attributes (acrobat reader, e.g., would probably crash); > extended attributes are handled by the file system and you don't have that > problem How is this related to baloo? Baloo just takes any metadata there is, and does not care if it is stored inside the file or in extended attributes. -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 419109] Preserve extended attributes when saving a file
https://bugs.kde.org/show_bug.cgi?id=419109 --- Comment #7 from Stefan Brüns --- (In reply to tagwerk19 from comment #5) > What would happen if this information was part of the file (rather than in > the extended attributes)? It would be copied/saved as part of the file and > managed within the app... There is no "if ..." here. Any metadata part of the file is in the scope of the application. Applications may or may not preserve any metadata (and sometimes it is not possible to preserve metadata, i.e. when you convert files to a different format without (structured) metadata). -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 419109] Preserve extended attributes when saving a file
https://bugs.kde.org/show_bug.cgi?id=419109 --- Comment #2 from Stefan Brüns --- For "Save", I would definitely vote for "preserve as much as possible". For "Save as ...", I am not sure. There are pros and cons for both possibilities. Cons: - It may lead to information leakage. Tags, comments, origin-url ... - Attributes may no longer apply Pros: - It still is mostly the same file - Manual transfer of attributes is time consuming Baloo itself does not care either way. As the file is created as a copy (and the old one deleted), it is just a new file which happens to have the same path. -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 390709] Create a reader mode/horizontal continous mode
https://bugs.kde.org/show_bug.cgi?id=390709 --- Comment #6 from Stefan Brüns --- (In reply to David Hurka from comment #5) > Does Bug 343910 request the same what you want? I think in most parts, yes. The "Overview" + "unlimited pages" + "Autofit" + "Fullscreen" setting does cover it for large parts. "unlimited pages" for overview is not implemented, the current limit is 8. This makes it impossible to see e.g. page 8 and 9 at the same time. Navigation is somewhat limited, one can just as single "paper sheet" with the "up"/"down" arrows at the bottom, but there is no corresponding keyboard binding (up/down cursor jumps to the next overview, e.g. by 8 pages). The "previous/next/page number" pane at the bottom eats up some vertical screen space, and also breaks fits law for the horizontal scroll bar. Also, the up/down arrows jump one page left/right, so probably better button icons are needed. -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 407140] Crash, QTextDocument chokes on input and ends up with negative pagecounts
https://bugs.kde.org/show_bug.cgi?id=407140 --- Comment #2 from Stefan Brüns --- (In reply to Albert Astals Cid from comment #1) > That's not a pdf ;) > > This is most probably a duplicate of 406738 > > Do you have time to check? The backtrace is the same. -- You are receiving this mail because: You are the assignee for the bug.
D20947: [EPubGenerator] Fetch the application palette just once
This revision was automatically updated to reflect the committed changes. Closed by commit R223:43cf8c8aef98: [EPubGenerator] Fetch the application palette just once (authored by bruns). REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20947?vs=57348&id=57393 REVISION DETAIL https://phabricator.kde.org/D20947 AFFECTED FILES generators/epub/converter.cpp To: bruns, #okular, ngraham Cc: okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid
D20946: [EPubGenerator] Reduce nesting level in loop
This revision was automatically updated to reflect the committed changes. Closed by commit R223:f7fbbf769be3: [EPubGenerator] Reduce nesting level in loop (authored by bruns). REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20946?vs=57347&id=57392 REVISION DETAIL https://phabricator.kde.org/D20946 AFFECTED FILES generators/epub/converter.cpp To: bruns, #okular, ngraham Cc: okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid
D20949: [EPubGenerator] Avoid crashes due to bogus wrapping of content in table
bruns edited the summary of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D20949 To: bruns, #okular Cc: okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid
D20949: [EPubGenerator] Avoid crashes due to bogus wrapping of content in table
bruns added a reviewer: Okular. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D20949 To: bruns, #okular Cc: okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid
D20949: [EPubGenerator] Avoid crashes due to bogus wrapping of content in table
bruns updated this revision to Diff 57352. bruns added a comment. remove unrelated code from patch REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20949?vs=57350&id=57352 BRANCH fix_epub REVISION DETAIL https://phabricator.kde.org/D20949 AFFECTED FILES generators/epub/converter.cpp To: bruns Cc: okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid
D20950: [EPubGenerator] Use proper UserResource enum value for custom resource
bruns created this revision. bruns added a reviewer: Okular. Herald added a project: Okular. Herald added a subscriber: okular-devel. bruns requested review of this revision. REVISION SUMMARY QTextDocument::ResourceType uses values 0 through 3, and provides UserResource = 100 for custom types. Avoid possible future clashes. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D20950 AFFECTED FILES generators/epub/epubdocument.h To: bruns, #okular Cc: okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid
D20948: [EPubGenerator] Avoid pointless scans of the whole document
bruns created this revision. bruns added a reviewer: Okular. Herald added a project: Okular. Herald added a subscriber: okular-devel. bruns requested review of this revision. REVISION SUMMARY The "" tag is a placeholder, and should only be processed when it has been inserted for this toc item, i.e. when movieAnnots is non-empty. Also place the search cursor at the last inserted block, otherwise the expression will search from the beginning of the document. Do likewise for audio/soundActions. This makes loading large documents much fasters, and even fixes crashing on huge documents, e.g. from project Gutenberg "The Complete Works of William Shakespeare" (3200 pages) or the "King James Bible" (1400 pages). TEST PLAN open a large EPub file (see above) REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D20948 AFFECTED FILES generators/epub/converter.cpp To: bruns, #okular Cc: okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid
D20949: [EPubGenerator] Avoid crashes due to bogus wrapping of content in table
bruns created this revision. Herald added a project: Okular. Herald added a subscriber: okular-devel. bruns requested review of this revision. REVISION SUMMARY QTextDocument chokes badly when a some documents are wrapped inside a table, returning e.g. a pagecount of -41292 afterwards. On the downside, this removes any padding from the page. On the upside, it removes any padding from the page. BUG: 407140 CCBUG: 406116 REPOSITORY R223 Okular BRANCH fix_epub REVISION DETAIL https://phabricator.kde.org/D20949 AFFECTED FILES generators/epub/converter.cpp To: bruns Cc: okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid
D20947: [EPubGenerator] Fetch the application palette just once
bruns created this revision. bruns added a reviewer: Okular. Herald added a project: Okular. Herald added a subscriber: okular-devel. bruns requested review of this revision. REVISION SUMMARY There is no reason to fetch the palette once per loop, just do it once REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D20947 AFFECTED FILES generators/epub/converter.cpp To: bruns, #okular Cc: okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid
D20946: [EPubGenerator] Reduce nesting level in loop
bruns created this revision. bruns added a reviewer: Okular. Herald added a project: Okular. Herald added a subscriber: okular-devel. bruns requested review of this revision. REVISION SUMMARY The loop body is skipped when `epub_it_get_curr(it)` is invalid. Make it more obvious there is no more code executed in this case. TEST PLAN no functional changes REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D20946 AFFECTED FILES generators/epub/converter.cpp To: bruns, #okular Cc: okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid
[okular] [Bug 407140] New: Crash, QTextDocument chokes on input and ends up with negative pagecounts
https://bugs.kde.org/show_bug.cgi?id=407140 Bug ID: 407140 Summary: Crash, QTextDocument chokes on input and ends up with negative pagecounts Product: okular Version: unspecified Platform: Other OS: Linux Status: REPORTED Severity: normal Priority: NOR Component: EPub backend Assignee: okular-devel@kde.org Reporter: stefan.bru...@rwth-aachen.de Target Milestone: --- Created attachment 119786 --> https://bugs.kde.org/attachment.cgi?id=119786&action=edit Problematic PDF SUMMARY The EPub generator wraps the page content with a html table, and after QTextDocument::setHtml(...) the pageCount() is -42192. This later leads to crashes when the page number is used as an array index. Removing the wrapping table from the firstpage code path avoids the bad behavior. The problematic PDF is the one from https://bugs.kde.org/show_bug.cgi?id=406116, but with the bad navPoint entries removed. According to EPubCheck, the fixed file is wellformed. STEPS TO REPRODUCE 1. Try to open the attached EPub with okular. OBSERVED RESULT Crash SOFTWARE/OS VERSIONS Linux/KDE Plasma: openSUSE Tumbleweed 20190428 KDE Plasma Version: 19.04.00 KDE Frameworks Version: 5.57 Qt Version: 5.12 ADDITIONAL INFORMATION -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 407140] Crash, QTextDocument chokes on input and ends up with negative pagecounts
https://bugs.kde.org/show_bug.cgi?id=407140 Stefan Brüns changed: What|Removed |Added See Also||https://bugs.kde.org/show_b ||ug.cgi?id=406116 -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 390706] Two-finger touchscreen zoom gesture needs final refresh
https://bugs.kde.org/show_bug.cgi?id=390706 Stefan Brüns changed: What|Removed |Added Status|NEEDSINFO |UNCONFIRMED Resolution|WAITINGFORINFO |--- --- Comment #9 from Stefan Brüns --- Thats the info as printed in the Okular About/Libraries tab, so this *is* a regular Plasma5/Kwin/X11 session. -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 390706] Two-finger touchscreen zoom gesture needs final refresh
https://bugs.kde.org/show_bug.cgi?id=390706 --- Comment #7 from Stefan Brüns --- It is sometimes hard to see the misrendering, and it does not happen all the time, or it is immediately cleared, because on lifting the finger a small movement happens. -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 390706] Two-finger touchscreen zoom gesture needs final refresh
https://bugs.kde.org/show_bug.cgi?id=390706 Stefan Brüns changed: What|Removed |Added Resolution|WAITINGFORINFO |--- Status|NEEDSINFO |UNCONFIRMED Version|unspecified |1.3.2 --- Comment #6 from Stefan Brüns --- KDE Frameworks 5.43.0 Qt 5.10.0 (built against 5.10.0) The xcb windowing system -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 390709] Create a reader mode/horizontal continous mode
https://bugs.kde.org/show_bug.cgi?id=390709 --- Comment #4 from Stefan Brüns --- This is specially useful for e.g. datasheets, when you want/need to see multiple pages at once. One possible approach would be to allow moving pagewise in the overview mode. Currently, if you press cursor right or cursor down, it jumps N pages at a time. If e.g. cursor right moved just one page, this would be a real improvement for me. Btw, currently one has to click the ">" (next page) button N times to move to the next overview. -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 390706] Two-finger touchscreen zoom gesture needs final refresh
https://bugs.kde.org/show_bug.cgi?id=390706 --- Comment #3 from Stefan Brüns --- Created attachment 110828 --> https://bugs.kde.org/attachment.cgi?id=110828&action=edit Screenshot -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 390706] Two-finger touchscreen zoom gesture needs final refresh
https://bugs.kde.org/show_bug.cgi?id=390706 --- Comment #2 from Stefan Brüns --- When I zoom in using Ctrl + Mouse Wheel Up, the page contents are magnified immediately, but for a very short time the contents are "blocky". This is not persistent, but the contents are immediately rerendered with the higher resolution. This is the expected behaviour. When I use a pinch zoom gesture, the last step - rerendering at current resolution - is omitted. As soon as I move the page around (cursor keys, mouse, touch), the contents are rerendered. I have tried to create two screenshots - the left half shows the jaggy edges immediately after zooming, the right half after pressing cursor down. -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 390709] Create a reader mode/horizontal continous mode
https://bugs.kde.org/show_bug.cgi?id=390709 Stefan Brüns changed: What|Removed |Added Resolution|WAITINGFORINFO |--- Status|NEEDSINFO |UNCONFIRMED --- Comment #2 from Stefan Brüns --- a) this shows only 2 pages b) again, limited to jumping 2 pages each time -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 390708] Allow to move backward in presentations using touch
https://bugs.kde.org/show_bug.cgi?id=390708 --- Comment #4 from Stefan Brüns --- (In reply to Oliver Sander from comment #3) > We are talking about touch screens, right? Not about touch pad gestures? Yes, touch screens. -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 390708] Allow to move backward in presentations using touch
https://bugs.kde.org/show_bug.cgi?id=390708 --- Comment #2 from Stefan Brüns --- (In reply to Oliver Sander from comment #1) > You can go back and forth in presentations using left/right swiping > gestures. Note that Qt swipe gestures need three(!) fingers. Has no effect for me. The event device reports up to ten fingers. -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 390709] New: Create a reader mode/horizontal continous mode
https://bugs.kde.org/show_bug.cgi?id=390709 Bug ID: 390709 Summary: Create a reader mode/horizontal continous mode Product: okular Version: unspecified Platform: Other OS: Linux Status: UNCONFIRMED Severity: normal Priority: NOR Component: general Assignee: okular-devel@kde.org Reporter: stefan.bru...@rwth-aachen.de Target Milestone: --- For reading PDF documents, a reader mode showing multiple pages in full screen would be nice. I.e. a mixture between presentation and overview mode. The vertical resolution of a FullHD screen is often sufficient to read an A4 page in portrait mode. Overview mode with e.g. 3 pages only allows to jump by 3 pages, which is bad if you want to see the "wrong" 3 adjacent pages. -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 390708] New: Allow to move backward in presentations using touch
https://bugs.kde.org/show_bug.cgi?id=390708 Bug ID: 390708 Summary: Allow to move backward in presentations using touch Product: okular Version: unspecified Platform: Other OS: Linux Status: UNCONFIRMED Severity: normal Priority: NOR Component: general Assignee: okular-devel@kde.org Reporter: stefan.bru...@rwth-aachen.de Target Milestone: --- Currently, the only possible movement is forward, as a touch is handled as a click. Possible actions: - touch on left half - backward, touch on right half - forward - swipe left/right -forward/backward -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 390707] New: Two-finger touchscreen zoom gesture should respect finger position
https://bugs.kde.org/show_bug.cgi?id=390707 Bug ID: 390707 Summary: Two-finger touchscreen zoom gesture should respect finger position Product: okular Version: unspecified Platform: Other OS: Linux Status: UNCONFIRMED Severity: normal Priority: NOR Component: general Assignee: okular-devel@kde.org Reporter: stefan.bru...@rwth-aachen.de Target Milestone: --- The two-finger zoom seems to always zoom to the center position. Expected behaviour: If the user marks a rectangle with the fingers, e.g. in the top left corner of the view, and then pulls the rectangle to the size of the screen, the former top left corner should be shown full screen. The same should probably apply to zooming with Ctrl + Mouse Wheel, i.e. zoom to mouse position. This is how zooming is handled in e.g. inkscape and any other document centric application I am aware of. -- You are receiving this mail because: You are the assignee for the bug.
[okular] [Bug 390706] New: Two-finger touchscreen zoom gesture needs final refresh
https://bugs.kde.org/show_bug.cgi?id=390706 Bug ID: 390706 Summary: Two-finger touchscreen zoom gesture needs final refresh Product: okular Version: unspecified Platform: Other OS: Linux Status: UNCONFIRMED Severity: normal Priority: NOR Component: general Assignee: okular-devel@kde.org Reporter: stefan.bru...@rwth-aachen.de Target Milestone: --- In general the gesture works, but after the gesture is finished, the view seems to still use a "nearest" filter instead of doing a rerendering at the final zoom level. When entering the same zoom level in the input box, the rendering has the same size, but is sharp and crisp. When scrolling, the rendering also becomes clean. -- You are receiving this mail because: You are the assignee for the bug.
[Okular-devel] [Bug 175097] New: PDF Backend does not support "Print to file"
http://bugs.kde.org/show_bug.cgi?id=175097 Summary: PDF Backend does not support "Print to file" Product: okular Version: unspecified Platform: SuSE RPMs OS/Version: unspecified Status: UNCONFIRMED Severity: wishlist Priority: NOR Component: PDF backend AssignedTo: okular-devel@kde.org ReportedBy: [EMAIL PROTECTED] Version:(using KDE 4.1.3) Installed from:SuSE RPMs Current state for the PDF backend: * PDF backend supports printing to Postscript (Poppler PSOutputDevice), so it could print to PS file. * PDF backend does not support conversion to PDF - Poppler has no PDFOutputDevice, although it can save its internal state of the PDF document. Dont know if this is enough if there are annotations, only a selection of pages should be printed, printing to different paper size ... * QTs print dialog only has a general flag for disabling printing to file, but does not differentiate between "print to PDF" and "print to PS". There is no possibility for an application to signal "generation of PS is supported, but not for PDF" - so printing to file is disabled completely. For KDE3/Kpdf, this was different - applications had to generate PS, and the PS was converted to PDF (via ghostscript). ** PLEASE ** dont close this _wishlist_ item as invalid - saving to PS _and_ PDF would be really nice, especially when one has made annotations to the document or filled out a form. -- Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
