[Okular-devel] [okular] [Bug 318828] Wrong ObjectRect after modifying annotation properties in a rotated document

2013-05-07 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=318828

Albert Astals Cid aa...@kde.org changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |FIXED
  Latest Commit||http://commits.kde.org/okul
   ||ar/4296ac7e5dd579aa43845df8
   ||0739c6a4f45284db

--- Comment #6 from Albert Astals Cid aa...@kde.org ---
Git commit 4296ac7e5dd579aa43845df80739c6a4f45284db by Albert Astals Cid, on
behalf of Jon Mease.
Committed on 07/05/2013 at 22:05.
Pushed by aacid into branch 'master'.

Rotate annotation to match page when setting annotation's properties
REVIEW:110229

M  +3-0core/annotations.cpp
M  +30   -0tests/modifyannotationpropertiestest.cpp

http://commits.kde.org/okular/4296ac7e5dd579aa43845df80739c6a4f45284db

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 318828] Wrong ObjectRect after modifying annotation properties in a rotated document

2013-04-27 Thread Jon Mease
https://bugs.kde.org/show_bug.cgi?id=318828

--- Comment #5 from Jon Mease jon.me...@gmail.com ---
Proposed fix and unit test submitted for review
https://git.reviewboard.kde.org/r/110229/

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 318828] Wrong ObjectRect after modifying annotation properties in a rotated document

2013-04-26 Thread Jon Mease
https://bugs.kde.org/show_bug.cgi?id=318828

--- Comment #4 from Jon Mease jon.me...@gmail.com ---
Sure thing. May be a few days but I'll take a look soon.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 318828] Wrong ObjectRect after modifying annotation properties in a rotated document

2013-04-24 Thread Fabio D'Urso
https://bugs.kde.org/show_bug.cgi?id=318828

--- Comment #1 from Fabio D'Urso fabiodu...@hotmail.it ---
Created attachment 79428
  -- https://bugs.kde.org/attachment.cgi?id=79428action=edit
Example PDF file

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 318828] Wrong ObjectRect after modifying annotation properties in a rotated document

2013-04-24 Thread Fabio D'Urso
https://bugs.kde.org/show_bug.cgi?id=318828

--- Comment #2 from Fabio D'Urso fabiodu...@hotmail.it ---
Created attachment 79429
  -- https://bugs.kde.org/attachment.cgi?id=79429action=edit
Wrong fix

I've tried to fix it myself, and the attached patch indeed fixes the issue, but
it's obviously a wrong fix.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 318828] Wrong ObjectRect after modifying annotation properties in a rotated document

2013-04-24 Thread Fabio D'Urso
https://bugs.kde.org/show_bug.cgi?id=318828

Fabio D'Urso fabiodu...@hotmail.it changed:

   What|Removed |Added

 CC||fabiodu...@hotmail.it,
   ||jon.me...@gmail.com

--- Comment #3 from Fabio D'Urso fabiodu...@hotmail.it ---
Jon, can you have a look at this issue?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel