[Okular-devel] [okular] [Bug 325044] PostScript file with extension .txt are not rendered as PostScript

2014-05-08 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=325044

Albert Astals Cid  changed:

   What|Removed |Added

 Status|UNCONFIRMED |CONFIRMED
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 325044] PostScript file with extension .txt are not rendered as PostScript

2014-05-11 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=325044

Albert Astals Cid  changed:

   What|Removed |Added

Version|0.17.1  |0.19.1

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 325044] PostScript file with extension .txt are not rendered as PostScript

2014-08-13 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=325044

Albert Astals Cid  changed:

   What|Removed |Added

   Version Fixed In||4.14.0
 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED
  Latest Commit||http://commits.kde.org/okul
   ||ar/fba90677fcc9ccf0e6f5efe7
   ||5e7446703d669d36

--- Comment #8 from Albert Astals Cid  ---
Git commit fba90677fcc9ccf0e6f5efe75e7446703d669d36 by Albert Astals Cid.
Committed on 13/08/2014 at 21:51.
Pushed by aacid into branch 'KDE/4.14'.

Fine tune mime type detection used for opening files

If the argument mimetype and filepath mimetype disagree, first try to use the
filepath mimetype and if that fails use the argument one. On top of that if
text/plain is the first, first try with content mimetype since the text backend
never fails to open a file

I can now open https://bugs.freedesktop.org/attachment.cgi?id=99508 (which is
served as text/plain) and PS files with .txt extension (bug 325044)

REVIEW: 119737
FIXED-IN: 4.14.0

M  +60   -18   part.cpp
M  +2-0part.h

http://commits.kde.org/okular/fba90677fcc9ccf0e6f5efe75e7446703d669d36

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 325044] PostScript file with extension .txt are not rendered as PostScript

2013-09-18 Thread Jekyll Wu
https://bugs.kde.org/show_bug.cgi?id=325044

Jekyll Wu  changed:

   What|Removed |Added

   Keywords||reproducible
 CC||adap...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 325044] PostScript file with extension .txt are not rendered as PostScript

2013-09-21 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=325044

Albert Astals Cid  changed:

   What|Removed |Added

 CC||aa...@kde.org,
   ||fa...@kde.org

--- Comment #1 from Albert Astals Cid  ---
I don't think this is not an okular issue, adding David Faure to see what he
thinks, but the thing is kdelibs is telling okular the foo.txt file is a text
file so we use the text backend to open it

tsdgeos@xps:~/okularfiles/ps$ diff 3dcolor.ps 3dcolor.txt 
tsdgeos@xps:~/okularfiles/ps$ kmimetypefinder 3dcolor.txt
text/plain
(accuracy 100)
tsdgeos@xps:~/okularfiles/ps$ kmimetypefinder 3dcolor.ps
application/postscript
(accuracy 100)

But sincerely, if you have a .ps file named .txt, you're doing something wrong.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 325044] PostScript file with extension .txt are not rendered as PostScript

2013-09-22 Thread Maciej J . Woloszyk
https://bugs.kde.org/show_bug.cgi?id=325044

--- Comment #2 from Maciej J . Woloszyk  ---
On 21 September 2013 17:45, Albert Astals Cid  wrote:
>
> But sincerely, if you have a .ps file named .txt, you're doing something 
> wrong.
>

If it was simply my doing I would agree. Unfortunately this is
something I get as an output from our stupid ERP system and I can't do
anything about it. But as it worked all these years before I would
like it to work again ;)

m.
PS. And yes - it's doing it wrong. As it is doing many other things :(

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 325044] PostScript file with extension .txt are not rendered as PostScript

2013-09-23 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=325044

--- Comment #3 from Albert Astals Cid  ---
It worked because we did not support txt files, we now do, so we now open it as
a txt file which is what you are telling us it is with the .txt extension,
there's nothing we can do. You can remove the txt backend from your system and
it'll work again.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 325044] PostScript file with extension .txt are not rendered as PostScript

2013-09-23 Thread Maciej J . Woloszyk
https://bugs.kde.org/show_bug.cgi?id=325044

--- Comment #4 from Maciej J . Woloszyk  ---
On 23 September 2013 20:15, Albert Astals Cid  wrote:
> It worked because we did not support txt files, we now do, so we now open it 
> as
> a txt file which is what you are telling us it is with the .txt extension,
> there's nothing we can do. You can remove the txt backend from your system and
> it'll work again.
>

Ok. I've removed the backend and yes - it works as it should.

And IMHO decision about file content based on it's name is a huuuge
step backwards. I feel like in the old Windows days.

Thanks for the suggestion anyway.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 325044] PostScript file with extension .txt are not rendered as PostScript

2013-09-24 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=325044

--- Comment #5 from Albert Astals Cid  ---
There is a problem with using magic to open a file, that it can fail, and once
it has failed there's no way to override it from a user point of view. That's
why we give precedence to the extension, it's something the user can fix if
they fucked up. Except you don't seem to be able to control your extensions
because of your unique broken scenario.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 325044] PostScript file with extension .txt are not rendered as PostScript

2013-09-24 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=325044

--- Comment #6 from Albert Astals Cid  ---
Now, what we could do is, in the case that file extension and file contents
magic detection disagree, show a dialog saying "Hi sir, we're confused, what do
you want to do with this?"

Do you think this is an acceptable solution?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 325044] PostScript file with extension .txt are not rendered as PostScript

2013-09-24 Thread Maciej J . Woloszyk
https://bugs.kde.org/show_bug.cgi?id=325044

--- Comment #7 from Maciej J . Woloszyk  ---
On 24 September 2013 13:54, Albert Astals Cid  wrote:
> Now, what we could do is, in the case that file extension and file contents
> magic detection disagree, show a dialog saying "Hi sir, we're confused, what 
> do
> you want to do with this?"
>
> Do you think this is an acceptable solution?
>

It could be especially with a checkbox for "remember this decision for
this type od diagreement" ;)

For me it would be better if I finally learn how to create Gentoo
ebuilds and just make a text backend optional at the compile time and
then simply switch it off ;) But the dialog could be more general
solution.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel