[Okular-devel] [okular] [Bug 325677] okular fails to open .cbr files with newest unrar installed
https://bugs.kde.org/show_bug.cgi?id=325677 Albert Astals Cid aa...@kde.org changed: What|Removed |Added Status|REOPENED|RESOLVED Version Fixed In||4.11.3 Resolution|--- |FIXED Latest Commit||http://commits.kde.org/okul ||ar/cfa37065c26ac2a8ece55868 ||0a31be4e4bad7091 --- Comment #14 from Albert Astals Cid aa...@kde.org --- Git commit cfa37065c26ac2a8ece558680a31be4e4bad7091 by Albert Astals Cid, on behalf of Christoph Feck. Committed on 13/10/2013 at 21:54. Pushed by aacid into branch 'KDE/4.11'. Fix cbr (rar) listing with unrar 5 The new unrar version includes the paths in its bare listing (unrar lb), while it still extracts only the filename without the path. Thus, the Unrar::list() function fails. This patch strips the path away. REVIEW: 113163 FIXED-IN: 4.11.3 M +6-2generators/comicbook/unrar.cpp http://commits.kde.org/okular/cfa37065c26ac2a8ece558680a31be4e4bad7091 -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 325677] okular fails to open .cbr files with newest unrar installed
https://bugs.kde.org/show_bug.cgi?id=325677 Albert Astals Cid aa...@kde.org changed: What|Removed |Added CC||aa...@kde.org --- Comment #3 from Albert Astals Cid aa...@kde.org --- Can you attach on of the cbr you use for opening it? Does not seem like this bug should not be file dependant but better to make sure -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 325677] okular fails to open .cbr files with newest unrar installed
https://bugs.kde.org/show_bug.cgi?id=325677 --- Comment #4 from Jörg Schuck joerg_sch...@web.de --- Created attachment 82709 -- https://bugs.kde.org/attachment.cgi?id=82709action=edit Sample comic file that will open for me. This file will open for me. The base .rar file used DOESN't have the image in a sub-folder. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 325677] okular fails to open .cbr files with newest unrar installed
https://bugs.kde.org/show_bug.cgi?id=325677 --- Comment #5 from Jörg Schuck joerg_sch...@web.de --- Created attachment 82710 -- https://bugs.kde.org/attachment.cgi?id=82710action=edit This is a sample file that won't open for me. This file fails to open. It HAS the image in a subfolder within the file. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 325677] okular fails to open .cbr files with newest unrar installed
https://bugs.kde.org/show_bug.cgi?id=325677 --- Comment #6 from Jörg Schuck joerg_sch...@web.de --- Seems like it has something to do with the files. If the images are contained in a subfolder within the rar file used as base for the .cbr okular fails to open it with the latest unrar version. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 325677] okular fails to open .cbr files with newest unrar installed
https://bugs.kde.org/show_bug.cgi?id=325677 --- Comment #9 from Christoph Feck christ...@maxiom.de --- Seems like line 117 in generators/comicbook/unrar.cpp needs to be int ret = startSyncProcess( QStringList() x mFileName mTempDir-name() ); for unrar version 5+. That would also be possible, but I am not sure, if Okular handles nested directories for the temporary extracted files everywhere (e.g. when later cleaning up etc.). Also, I am not sure how unrar behaves when absolute paths are present in the archive. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 325677] okular fails to open .cbr files with newest unrar installed
https://bugs.kde.org/show_bug.cgi?id=325677 --- Comment #10 from Jörg Schuck joerg_sch...@web.de --- Agreed. Your patch is quite elegant and superior to my suggestion. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 325677] okular fails to open .cbr files with newest unrar installed
https://bugs.kde.org/show_bug.cgi?id=325677 Jörg Schuck joerg_sch...@web.de changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED --- Comment #11 from Jörg Schuck joerg_sch...@web.de --- Just finnished compiling. Works on my end. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 325677] okular fails to open .cbr files with newest unrar installed
https://bugs.kde.org/show_bug.cgi?id=325677 Christoph Feck christ...@maxiom.de changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED |--- Ever confirmed|0 |1 --- Comment #12 from Christoph Feck christ...@maxiom.de --- Thanks for testing, but we resolve the bug, when the commit was made :) -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 325677] okular fails to open .cbr files with newest unrar installed
https://bugs.kde.org/show_bug.cgi?id=325677 --- Comment #13 from Jörg Schuck joerg_sch...@web.de --- Whoops. Sorry for that. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 325677] okular fails to open .cbr files with newest unrar installed
https://bugs.kde.org/show_bug.cgi?id=325677 --- Comment #2 from Jörg Schuck joerg_sch...@web.de --- As for unrar: $ unrar --version UNRAR 5.00 freeware Copyright (c) 1993-2013 Alexander Roshal And the complete debugging information for okular. $ okular comic.cbr okular(28727)/kdeui (KIconLoader) KIconTheme::KIconTheme: Icon theme Faenza not found. okular(28727)/kdeui (KIconLoader) KIconTheme::KIconTheme: Icon theme Faenza not found. okular(28727)/kdeui (KGlobalAccel) KActionCollection::addAction: Registering action go_first under new name first_page okular(28727)/kdeui (KGlobalAccel) KActionCollection::addAction: Registering action go_last under new name last_page okular(28727)/kdecore (KSycoca) KSycocaPrivate::openDatabase: Trying to open ksycoca from /var/tmp/kdecache-schuck/ksycoca4 okular(28727)/kdeui (KGlobalAccel) KActionCollection::addAction: Registering action file_save_as under new name file_save_copy okular(28727)/kdecore (KConfigSkeleton) KCoreConfigSkeleton::writeConfig: okular(28727)/kdecore (KConfigSkeleton) KCoreConfigSkeleton::writeConfig: okular(28727)/kdecore (KConfigSkeleton) KCoreConfigSkeleton::writeConfig: okular(28727)/kdecore (KConfigSkeleton) KCoreConfigSkeleton::writeConfig: okular(28727)/kio (KDirWatch) KDirWatchPrivate::KDirWatchPrivate: INotify available: true okular(28727)/kdecore (KConfigSkeleton) KCoreConfigSkeleton::writeConfig: okular(28727)/kdeui (KMainWindow) KMainWindow::applyMainWindowSettings: KMainWindow::applyMainWindowSettings MainWindow okular(28727)/kdeui (KMainWindow) KMainWindow::applyMainWindowSettings: KMainWindow::applyMainWindowSettings MainWindow okular(28727)/kdeui (KMainWindow) KMainWindow::applyMainWindowSettings: KMainWindow::applyMainWindowSettings MainWindow okular(28727)/kdeui (KMainWindow) KMainWindow::applyMainWindowSettings: KMainWindow::applyMainWindowSettings MainWindow okular(28727)/kparts KParts::ReadWritePart::setModified: setModified( false ) okular(28727)/kparts KParts::ReadWritePart::setModified: setModified( false ) okular(28727)/kdecore (trader) KMimeTypeTrader::query: query for mimeType application/x-cbr , okular/Generator : returning 1 offers okular(28727) UnrarHelper::UnrarHelper: detected: /usr/bin/unrar ( unrar-nonfree ) okular(28727)/kdecore (kdelibs) KTempDir::create: KTempDir: Temporary directory created : /tmp/kde-schuck/okularBrhf3s/ okular(28727)/kdecore (trader) KMimeTypeTrader::query: query for mimeType application/x-rar , okular/Generator : returning 0 offers okular(28727)/kdeui (KNotification) KNotificationManager::notificationClosed: 467 okular(28727)/kparts KParts::ReadWritePart::setModified: setModified( false ) okular(28727)/kparts KParts::Part::~Part: deleting widget Sidebar(0x1944770) okular(28727)/kio (KDirWatch) KDirWatchPrivate::KDirWatchPrivate: INotify available: true The funny thing is it detected unrar correctly it just fails to open and display the file. I have even considered that a wonky build has managed to enter the repositories and rebuild unrar locally. To no avail. It still fails to open with the current version under Arch. -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] [okular] [Bug 325677] okular fails to open .cbr files with newest unrar installed
https://bugs.kde.org/show_bug.cgi?id=325677 Christoph Feck christ...@maxiom.de changed: What|Removed |Added CC||christ...@maxiom.de --- Comment #1 from Christoph Feck christ...@maxiom.de --- Works here with openSUSE unrar package (unrar-5.0.11-2.1.5.i586). unrar --version UNRAR 5.00 freeware Copyright (c) 1993-2013 Alexander Roshal Please add the output of unrar --version. Could you also please enable all messages with kdebugdialog in Konsole, and add the output from Okular when trying to open the .cbr? -- You are receiving this mail because: You are the assignee for the bug. ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
