[Okular-devel] [okular] [Bug 331872] "Open documents in new tab" doesn't work

2014-04-09 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=331872

Albert Astals Cid  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
   Version Fixed In||4.13.0
 Resolution|--- |FIXED
  Latest Commit||http://commits.kde.org/okul
   ||ar/89fd56c23bc19812d3514991
   ||a6eeb9f27c2cb742

--- Comment #6 from Albert Astals Cid  ---
Git commit 89fd56c23bc19812d3514991a6eeb9f27c2cb742 by Albert Astals Cid, on
behalf of Jonathan Doman.
Committed on 09/04/2014 at 21:29.
Pushed by aacid into branch 'KDE/4.13'.

Launch documents from external sources in new tabs

FIXED-IN: 4.13.0
Related: bug 332238
REVIEW: 116700

M  +12   -2part.cpp
M  +2-0part.h
M  +85   -11   shell/main.cpp
M  +62   -9shell/shell.cpp
M  +5-0shell/shell.h
M  +2-23   ui/pageview.cpp
M  +0-7ui/pageview.h
M  +13   -0ui/sidebar.cpp
M  +8-0ui/sidebar.h
M  +0-17   ui/thumbnaillist.cpp
M  +0-6ui/thumbnaillist.h

http://commits.kde.org/okular/89fd56c23bc19812d3514991a6eeb9f27c2cb742

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 331872] "Open documents in new tab" doesn't work

2014-03-10 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=331872

Albert Astals Cid  changed:

   What|Removed |Added

 CC||aa...@kde.org

--- Comment #5 from Albert Astals Cid  ---
The fact that you don't plan any more than one okular ever open doesn't mean
that it can't happen, so it's something that needs to be taken into account ;-)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 331872] "Open documents in new tab" doesn't work

2014-03-10 Thread Antonio Rojas
https://bugs.kde.org/show_bug.cgi?id=331872

--- Comment #4 from Antonio Rojas  ---
If this is implemented I don't plan to have more than one okular window open
ever, so I don't really mind. What do browsers usually do?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 331872] "Open documents in new tab" doesn't work

2014-03-09 Thread Jonathan Doman
https://bugs.kde.org/show_bug.cgi?id=331872

--- Comment #3 from Jonathan Doman  ---
Okay, I'm not an official developer but I'll try to implement this and get it
reviewed. How would you expect this to behave when there are multiple okular
windows already opened? Should it open a new tab in the first window, or any
window, or a window determined by some other metric? (I have my own opinion but
would like more inputs.)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 331872] "Open documents in new tab" doesn't work

2014-03-09 Thread Antonio Rojas
https://bugs.kde.org/show_bug.cgi?id=331872

Antonio Rojas  changed:

   What|Removed |Added

   Severity|normal  |wishlist

--- Comment #2 from Antonio Rojas  ---
OK changed to wishlist then... I expected this to work for files open from the
file browser (after all, that is how okular is usually opened)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 331872] "Open documents in new tab" doesn't work

2014-03-09 Thread Jonathan Doman
https://bugs.kde.org/show_bug.cgi?id=331872

Jonathan Doman  changed:

   What|Removed |Added

 CC||jonathan.do...@gmail.com

--- Comment #1 from Jonathan Doman  ---
Can you clarify the actions you are taking to reproduce and what is the
expected behavior? New tabs will only be created for documents opened through
okular's file open dialog. Documents opened through an external file browser or
command line will open a new window. If this isn't the behavior you
want/expect, you should resubmit this as a feature request and I can make a
patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel