[Okular-devel] [okular] [Bug 334100] --page number being ignored

2014-08-08 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=334100

Albert Astals Cid aa...@kde.org changed:

   What|Removed |Added

 Resolution|--- |FIXED
   Version Fixed In||4.14.0
  Latest Commit||http://commits.kde.org/okul
   ||ar/61c830cb7a049f50ec654dac
   ||bfd128a36ef5740b
 Status|ASSIGNED|RESOLVED

--- Comment #8 from Albert Astals Cid aa...@kde.org ---
Git commit 61c830cb7a049f50ec654dacbfd128a36ef5740b by Albert Astals Cid.
Committed on 08/08/2014 at 20:35.
Pushed by aacid into branch 'KDE/4.14'.

Pass the command line options properly when using tabs or unique instances

Use a QString to serialize the command line options other than urls to open so
it can be easily passed around to every place that opens a new shell or tab or
overrides the content in a unique instance.
FIXED-IN: 4.14.0
REVIEW: 119595

M  +2-1conf/settings.kcfgc
M  +21   -16   core/document.cpp
M  +1-0core/document_p.h
M  +1-0shell/CMakeLists.txt
M  +17   -131  shell/main.cpp
M  +38   -44   shell/shell.cpp
M  +7-9shell/shell.h
M  +67   -0shell/shellutils.cpp
M  +10   -0shell/shellutils.h
M  +5-0tests/CMakeLists.txt

http://commits.kde.org/okular/61c830cb7a049f50ec654dacbfd128a36ef5740b

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 334100] --page number being ignored

2014-08-03 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=334100

Albert Astals Cid aa...@kde.org changed:

   What|Removed |Added

 Status|CONFIRMED   |ASSIGNED

--- Comment #5 from Albert Astals Cid aa...@kde.org ---
I'm working on a fix for this, should be up next week in time for 4.14.0

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 334100] --page number being ignored

2014-08-03 Thread Paul
https://bugs.kde.org/show_bug.cgi?id=334100

--- Comment #6 from Paul pip@gmx.com ---
(In reply to Albert Astals Cid from comment #5)
 I'm working on a fix for this, should be up next week in time for 4.14.0

Fantastic! Many thanks, appreciate the effort you guys put in. :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 334100] --page number being ignored

2014-08-03 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=334100

--- Comment #7 from Albert Astals Cid aa...@kde.org ---
Big-ish patch up at https://git.reviewboard.kde.org/r/119595/

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 334100] --page number being ignored

2014-08-01 Thread Paul
https://bugs.kde.org/show_bug.cgi?id=334100

--- Comment #4 from Paul pip@gmx.com ---
(In reply to Jonathan Doman from comment #1)
 ... I'm happy to fix this, but it may be over a month until I have time
 to do so.

Any further timescale on this? The lack of --page number functionality
rather breaks Recol's snippet feature, it would be good to have that working
again :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 334100] --page number being ignored

2014-06-23 Thread Christoph Feck
https://bugs.kde.org/show_bug.cgi?id=334100

Christoph Feck christ...@maxiom.de changed:

   What|Removed |Added

 CC||kol...@aon.at

--- Comment #3 from Christoph Feck christ...@maxiom.de ---
*** Bug 336609 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 334100] --page number being ignored

2014-05-08 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=334100

Albert Astals Cid aa...@kde.org changed:

   What|Removed |Added

 Status|UNCONFIRMED |CONFIRMED
 CC||aa...@kde.org
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 334100] --page number being ignored

2014-04-30 Thread Paul
https://bugs.kde.org/show_bug.cgi?id=334100

--- Comment #2 from Paul pip@gmx.com ---
(In reply to comment #1)
 Thanks for reporting this - I can confirm that I broke this functionality. ...

:)  Things happen...  Thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 334100] --page number being ignored

2014-04-29 Thread Paul
https://bugs.kde.org/show_bug.cgi?id=334100

Paul pip@gmx.com changed:

   What|Removed |Added

 CC||pip@gmx.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] [okular] [Bug 334100] --page number being ignored

2014-04-29 Thread Jonathan Doman
https://bugs.kde.org/show_bug.cgi?id=334100

Jonathan Doman jonathan.do...@gmail.com changed:

   What|Removed |Added

 CC||jonathan.do...@gmail.com

--- Comment #1 from Jonathan Doman jonathan.do...@gmail.com ---
Thanks for reporting this - I can confirm that I broke this functionality. In
fact, I think many of the command line options won't work properly. I'm happy
to fix this, but it may be over a month until I have time to do so.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel