[Okular-devel] [okular] [Bug 359932] Okular is very slow at opening some EPUB's

[layus]

https://bugs.kde.org/show_bug.cgi?id=359932

--- Comment #19 from Guillaume Maudoux (layus)  ---
Nice ! I hope it will find its way in okular fast enough :-).

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 359932] Okular is very slow at opening some EPUB's

[Martin Sandsmark via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=359932

Martin Sandsmark  changed:

   What|Removed |Added

 CC||martin.sandsm...@kde.org

--- Comment #18 from Martin Sandsmark  ---
(I reverted that change later, it broke layouting).

For Reasons(TM) I implemented a trivial epub "reader" using KArchive and
QDomDocument for parsing the container and QTextDocument for the actual
rendering: https://github.com/sandsmark/epubreader

The performance of this seems to be as good as or even better than FBReader and
Calibre, depending on the book.

I ran my application under callgrind, and it seems like there's some
low-hanging fruit in the internal QCss class to increase performance even more.

I plan on using the code from that to improve the epub generator in Okular.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 359932] Okular is very slow at opening some EPUB's

[Martin Sandsmark via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=359932

--- Comment #17 from Martin Sandsmark  ---
Git commit c110c65401a97877eb8b1cd3c6be04e2bdcbc5ec by Martin T. H. Sandsmark.
Committed on 13/07/2016 at 13:41.
Pushed by sandsmark into branch 'frameworks'.

Improve page breaks and batch up cursor edits in epub generator

Patch by Guillaume Maudoux (layus).

M  +14   -11   generators/epub/converter.cpp

http://commits.kde.org/okular/c110c65401a97877eb8b1cd3c6be04e2bdcbc5ec

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 359932] Okular is very slow at opening some EPUB's

[layus]

https://bugs.kde.org/show_bug.cgi?id=359932

--- Comment #16 from Guillaume Maudoux (layus)  ---
Sorry, that was a bit bold from me.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 359932] Okular is very slow at opening some EPUB's

[Albert Astals Cid via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=359932

Albert Astals Cid  changed:

   What|Removed |Added

 Status|RESOLVED|UNCONFIRMED
 Resolution|WONTFIX |---

--- Comment #15 from Albert Astals Cid  ---
Guillaume since you're not an Okular developer, don't WONTFIX bugs.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 359932] Okular is very slow at opening some EPUB's

[layus]

https://bugs.kde.org/show_bug.cgi?id=359932

Guillaume Maudoux (layus)  changed:

   What|Removed |Added

 Status|UNCONFIRMED |RESOLVED
 Resolution|--- |WONTFIX

--- Comment #14 from Guillaume Maudoux (layus)  ---
After many bissecting builds, my feeling is that there is not a single commit
to blame, but a set of changes that decrease paerformance on the underlying
QTextDocument.
QTextDocument is quite bloated and, most probably, received extra features (or
even bugfixes) at the cost of efficiency.
If you want an efficient epub reader, use calibre's document viewer.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 359932] Okular is very slow at opening some EPUB's

[cpon via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=359932

cpon  changed:

   What|Removed |Added

 CC||cpigat...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 359932] Okular is very slow at opening some EPUB's

[Albert Astals Cid via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=359932

Albert Astals Cid  changed:

   What|Removed |Added

 CC||aa...@kde.org

--- Comment #13 from Albert Astals Cid  ---
Please use reviewboard.kde.org for patches

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 359932] Okular is very slow at opening some EPUB's

[layus]

https://bugs.kde.org/show_bug.cgi?id=359932

--- Comment #12 from Guillaume Maudoux (layus)  ---
Created attachment 97741
  --> https://bugs.kde.org/attachment.cgi?id=97741=edit
Ipmprove line breaks and batch cursor edits

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 359932] Okular is very slow at opening some EPUB's

[layus]

https://bugs.kde.org/show_bug.cgi?id=359932

--- Comment #11 from Guillaume Maudoux (layus)  ---
Investigations show that okular spends a lot of time in the convert() method.
That step produces a QTextDocument from the epub content.
More specifically, it spends a lot of time in _cursor->insertHtml() called once
for each chapter of the epub, and an equal amount of time in
_cursor->insertText() used very stupidly by the algorithm to force a page
break.

Also, the console output shows that okular repaints all the pages on every
redraw, which causes that other 50% of the load time, and causes lag during
scrolling.
I have attached a first patch to remove the dumb insertion of newline
characters to force a new page.
The patch also tries to group cursor operations. That being said, my patch does
not seem to have that much effect on the load time.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 359932] Okular is very slow at opening some EPUB's

[Thomas Tuegel via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=359932

Thomas Tuegel  changed:

   What|Removed |Added

 CC||ttue...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 359932] Okular is very slow at opening some EPUB's

[Shlomi Fish via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=359932

--- Comment #10 from Shlomi Fish  ---
I should note that per the duplicate bug, this EPUB also exhibits the problem
and Okular should be verified to properly work with it -
http://www.shlomifish.org/Files/files/text/Up-and-Coming-Stories-by-the-2016-Campbell-Eligible-Authors-anthology.epub
- here it also crashes eventually with it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 359932] Okular is very slow at opening some EPUB's

[Christoph Feck via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=359932

Christoph Feck  changed:

   What|Removed |Added

 CC||shlo...@shlomifish.org

--- Comment #9 from Christoph Feck  ---
*** Bug 360057 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 359932] Okular is very slow at opening some EPUB's

[layus]

https://bugs.kde.org/show_bug.cgi?id=359932

--- Comment #8 from Guillaume Maudoux (layus)  ---
So we agree on the bug, and it is reproducible. That's a great start.

Do any of you have an idea on how to debug this ?
Is it possible to get traces without recompiling ?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 359932] Okular is very slow at opening some EPUB's

[Albert via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=359932

--- Comment #7 from Albert  ---
>Then your issue could be different: okular-frameworks is unsupported, and it 
>could suffer from porting errors related to paths.
you're right in regard to frameworks.  I can however confirm your original
report:
>Okular freezes while loading the epub, then the rendering is laggy (not fast, 
>but not freezing either).
in regular okular, and the log displays the same information as I posted sans
the "no such file" portion

Name: kdegraphics-okular
Version : 15.12.2-1
Qt: 4.8.7
KDE Development Platform: 4.14.17
Okular: 0.24.2

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 359932] Okular is very slow at opening some EPUB's

[Luigi Toscano via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=359932

Luigi Toscano  changed:

   What|Removed |Added

 CC||luigi.tosc...@tiscali.it

--- Comment #6 from Luigi Toscano  ---
(In reply to Albert from comment #4)
> Created attachment 97705 [details]
> okular-frameworks-git log from konsole
> 
> >Have you tried the attached epub in okular ?
> indeed, running latest git okular-frameworks-git r7262.154c98f-1 (Sat Mar  5
> 22:50:10 CST 2016) from konsole, see attached file
> all the libepub missing files are the same as on the link mentioned

Then your issue could be different: okular-frameworks is unsupported, and it
could suffer from porting errors related to paths.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 359932] Okular is very slow at opening some EPUB's

[Albert via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=359932

--- Comment #5 from Albert  ---
the files are obviously there, but somewhere along the way either okular or
libepub add a kUrl path that causes the files to be lost in the process (ie..
instead of finding the file "cover-image.png" in the root of the epub, it tries
to find it in some path added by kURL in either libepub's implementation or
okular's)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 359932] Okular is very slow at opening some EPUB's

[Albert via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=359932

--- Comment #4 from Albert  ---
Created attachment 97705
  --> https://bugs.kde.org/attachment.cgi?id=97705=edit
okular-frameworks-git log from konsole

>Have you tried the attached epub in okular ?
indeed, running latest git okular-frameworks-git r7262.154c98f-1 (Sat Mar  5
22:50:10 CST 2016) from konsole, see attached file
all the libepub missing files are the same as on the link mentioned

running the patched version from the link provides a few more details:
libepub (II):   cover.xhtmlstylesheet.css - No such file
libepub (II):   cover.xhtmlcover-image.jpg - No such file
libepub (II):   cover.xhtmlcover-image.jpg - No such file
libepub (II):   title_page.xhtmlstylesheet.css - No such file
libepub (II):   title_page.xhtmlcover-image.jpg - No such file
libepub (II):   title_page.xhtmlcover-image.jpg - No such file
libepub (II):   ch1.xhtmlstylesheet.css - No such file
libepub (II):   ch1.xhtmlcover-image.jpg - No such file
libepub (II):   ch1.xhtmlcover-image.jpg - No such file
libepub (II):   ch2.xhtmlstylesheet.css - No such file
libepub (II):   ch2.xhtmlcover-image.jpg - No such file
libepub (II):   ch2.xhtmlcover-image.jpg - No such file
libepub (II):   ch3.xhtmlstylesheet.css - No such file
libepub (II):   ch3.xhtmlcover-image.jpg - No such file
libepub (II):   ch3.xhtmlcover-image.jpg - No such file


and as mentioned in the link, the structure of the epub (if you open in ark for
example) is what throws off either libepub or okular (or both)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 359932] Okular is very slow at opening some EPUB's

[layus]

https://bugs.kde.org/show_bug.cgi?id=359932

--- Comment #3 from Guillaume Maudoux (layus)  ---
It seems to me that it is unrelated. My log shows nothing like "cannot XXX".
What log are you referring to ?
And the attached epub has a very simple structure, and there seem to be no
error in libepub.

Have you tried the attached epub in okular ?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 359932] Okular is very slow at opening some EPUB's

[Albert via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=359932

--- Comment #2 from Albert  ---
the referenced path does allow the ebooks to be opened faster, but the log is
still full of missing path/file errors

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 359932] Okular is very slow at opening some EPUB's

[Albert via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=359932

Albert  changed:

   What|Removed |Added

 CC||kdebug-specta...@yahoo.com

--- Comment #1 from Albert  ---
this happens with epubs with weird directory structures for the most part as
per:
https://git.reviewboard.kde.org/r/125500/
has a patch that fixes the loading problem in maybe half the cases, but some
epubs still manage to freeze.  on the log it will also show several "cannot
find [path to file]/filename" errors (mainly with locating images/css).
it looks like the main issue is with libepub which is not maintained, not
handling the paths correctly.  the patch submitter above mentions "
non-canonical path in libepub. I fixed it in my fork of library" but that fork
is nowhere to be found.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 359932] Okular is very slow at opening some EPUB's

[layus]

https://bugs.kde.org/show_bug.cgi?id=359932

Guillaume Maudoux (layus)  changed:

   What|Removed |Added

   See Also||https://bugs.kde.org/show_b
   ||ug.cgi?id=358562

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel