Re: [Okular-devel] Feature Announcement: Adding zoom to Okular history

2009-06-20 Thread XTra KrazzY
  1. What do you think about this feature? (is it as useful as we think it
  is?)

 How does it work?
 I mean, i am in page 1, change to page 2 and now change zoom, i press back in
 history and that happens? am i sent to page 1? my zoom changes? both?
 Or there is a separate zoom history?

Both. The zoom is now part of the document viewport.

  2. Why aren't the back/forward in the document buttons in the menu bar by
  default, instead of in some submenu?

 That i'd like to know too :D Afair the reason was that it's too similar to
 regular next/previous page

  3. How are we going to commit our changes to the project?
 
  We know you are in amidst of a feature freeze until the next KDE minor
  version comes out. We would suggest you to think of it more of as an
  enhancement rather than a feature. It's not as if we added another document
  format or revamped the entire Document/PageView API.

 an enhacement is synomim of feature, good try though ;-)

Well, we kinda have to submit it by July 2nd. :-)
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


Re: [Okular-devel] Feature Announcement: Adding zoom to Okular history

2009-06-20 Thread Pino Toscano
Hi,

 1. What do you think about this feature? (is it as useful as we think it
 is?)

Not in favour, but not against.

 3. How are we going to commit our changes to the project?

You don't directly, please post them for review.

 We know you are in amidst of a feature freeze until the next KDE minor
 version comes out. We would suggest you to think of it more of as an
 enhancement rather than a feature. It's not as if we added another document
 format or revamped the entire Document/PageView API.

KDE 4.3 is already closed for new features since one month. Although I had to 
introduce changes needed for Kile (which cannot wait 2010 for needed features 
for it) or small very-micro enhancements, the proposed feature does look 
invasive enough (from both API and UI POVs) to not be in 4.3.
At least from Okular's POV, you don't have any deadline on July 2nd, so don't 
rush for it.

-- 
Pino Toscano


signature.asc
Description: This is a digitally signed message part.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


[Okular-devel] Feature Announcement: Adding zoom to Okular history

2009-06-19 Thread XTra KrazzY
Hello,

My partner and I would like to announce that as a project for an Open
Source Development course in a university study in, we almost finished
developing (we're doing some polishing and finishing touches to the code)
adding zoom to the document history, which can be accessed via the
back/forward in the document buttons.

We've talked to Pino Toscano a while ago on #okular and got permission to
implement this feature.

The questions we have now are:
1. What do you think about this feature? (is it as useful as we think it
is?)
2. Why aren't the back/forward in the document buttons in the menu bar by
default, instead of in some submenu?
3. How are we going to commit our changes to the project?

We know you are in amidst of a feature freeze until the next KDE minor
version comes out. We would suggest you to think of it more of as an
enhancement rather than a feature. It's not as if we added another document
format or revamped the entire Document/PageView API.

So, what do you think?
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel


Re: [Okular-devel] Feature Announcement: Adding zoom to Okular history

2009-06-19 Thread Albert Astals Cid
A Dissabte, 20 de juny de 2009, XTra KrazzY va escriure:
 Hello,

 My partner and I would like to announce that as a project for an Open
 Source Development course in a university study in, we almost finished
 developing (we're doing some polishing and finishing touches to the code)
 adding zoom to the document history, which can be accessed via the
 back/forward in the document buttons.

 We've talked to Pino Toscano a while ago on #okular and got permission to
 implement this feature.

 The questions we have now are:
 1. What do you think about this feature? (is it as useful as we think it
 is?)

How does it work?
I mean, i am in page 1, change to page 2 and now change zoom, i press back in 
history and that happens? am i sent to page 1? my zoom changes? both?
Or there is a separate zoom history?

 2. Why aren't the back/forward in the document buttons in the menu bar by
 default, instead of in some submenu?

That i'd like to know too :D Afair the reason was that it's too similar to 
regular next/previous page

 3. How are we going to commit our changes to the project?

 We know you are in amidst of a feature freeze until the next KDE minor
 version comes out. We would suggest you to think of it more of as an
 enhancement rather than a feature. It's not as if we added another document
 format or revamped the entire Document/PageView API.

an enhacement is synomim of feature, good try though ;-)

Albert

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel