Re: [Okular-devel] Review Request 109632: Annotation eraser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/109632/ --- (Updated April 23, 2014, 11:01 p.m.) Status -- This change has been discarded. Review request for Okular. Repository: okular Description --- Prerequisites: Please read till the end! This introduces a new annotation tool: Eraser. The eraser primarily erases other annotations that it comes into contact with (shapes, lines, highlights, etc.). However, ink annotations are treated more like a real eraser: Existing paths are split and unaffected parts are preserved. This is what it looks like: http://bedahr.org/eraser.ogv Example tool configuration for your tools.xml (not included in patch): tool id=15 name=Eraser pixmap=tool-eraser-okular tooltipEraser/tooltip engine type=Eraser / shortcut7/shortcut /tool The eraser builds on the work for the outline selection proposed in review request #109627. Please apply that patch before this one. Diffs - ui/pageviewannotator.cpp 7bd7496 Diff: https://git.reviewboard.kde.org/r/109632/diff/ Testing --- While it worked fine for the few PDFs I threw at it on this relatively powerful machine, it was pointed out to me in #okular, that calls to modifyPageAnnotation are very expensive as poppler has to re-draw the pdf (with the annotations) for every change. I hope we can resume the discussion about possible improvements here. Thanks, Peter Grasch ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 109632: Annotation eraser
On March 24, 2013, 1:06 a.m., Jon Mease wrote: Comments on the functionality (not the implementation): 1) I'm really excited to have this functionality in Okular (My work on the undo functionality was also primarily motivated by the desire to replace Xournal with Okular for tablet PC ink document annotation). 2) How difficult would it be to add something like an erase ink strokes option to the tools.xml. Xournal has this option and it controls whether an ink stroke is fully deleted by the eraser (as you do for the other annotation types) or erased incrementally (your current implementation for ink annotations). I've found both of these settings to be quite helpful under different circumstances. Peter Grasch wrote: To do that, we would just need to *not* treat the ink annotation as a special case. Btw, it would also be easy to add a pen width to the eraser by not using objectRects but nearestObjectRect (iteratively for as long as distance = penWidth). Albert Astals Cid wrote: Peter how's the implementation of this going? Do you need anything from us or just time? Peter, I'm going to discard this with the hope of maintaining a cleaner reviewboard queue. This does not mean we do not appreciate this feature. We do, so if you ever get time to work on this please create a new review request with it. Thanks again for caring about Okular :) - Albert --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/109632/#review29779 --- On March 21, 2013, 1:26 a.m., Peter Grasch wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/109632/ --- (Updated March 21, 2013, 1:26 a.m.) Review request for Okular. Repository: okular Description --- Prerequisites: Please read till the end! This introduces a new annotation tool: Eraser. The eraser primarily erases other annotations that it comes into contact with (shapes, lines, highlights, etc.). However, ink annotations are treated more like a real eraser: Existing paths are split and unaffected parts are preserved. This is what it looks like: http://bedahr.org/eraser.ogv Example tool configuration for your tools.xml (not included in patch): tool id=15 name=Eraser pixmap=tool-eraser-okular tooltipEraser/tooltip engine type=Eraser / shortcut7/shortcut /tool The eraser builds on the work for the outline selection proposed in review request #109627. Please apply that patch before this one. Diffs - ui/pageviewannotator.cpp 7bd7496 Diff: https://git.reviewboard.kde.org/r/109632/diff/ Testing --- While it worked fine for the few PDFs I threw at it on this relatively powerful machine, it was pointed out to me in #okular, that calls to modifyPageAnnotation are very expensive as poppler has to re-draw the pdf (with the annotations) for every change. I hope we can resume the discussion about possible improvements here. Thanks, Peter Grasch ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 109632: Annotation eraser
On March 24, 2013, 1:06 a.m., Jon Mease wrote: Comments on the functionality (not the implementation): 1) I'm really excited to have this functionality in Okular (My work on the undo functionality was also primarily motivated by the desire to replace Xournal with Okular for tablet PC ink document annotation). 2) How difficult would it be to add something like an erase ink strokes option to the tools.xml. Xournal has this option and it controls whether an ink stroke is fully deleted by the eraser (as you do for the other annotation types) or erased incrementally (your current implementation for ink annotations). I've found both of these settings to be quite helpful under different circumstances. Peter Grasch wrote: To do that, we would just need to *not* treat the ink annotation as a special case. Btw, it would also be easy to add a pen width to the eraser by not using objectRects but nearestObjectRect (iteratively for as long as distance = penWidth). Peter how's the implementation of this going? Do you need anything from us or just time? - Albert --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109632/#review29779 --- On March 21, 2013, 1:26 a.m., Peter Grasch wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109632/ --- (Updated March 21, 2013, 1:26 a.m.) Review request for Okular. Description --- Prerequisites: Please read till the end! This introduces a new annotation tool: Eraser. The eraser primarily erases other annotations that it comes into contact with (shapes, lines, highlights, etc.). However, ink annotations are treated more like a real eraser: Existing paths are split and unaffected parts are preserved. This is what it looks like: http://bedahr.org/eraser.ogv Example tool configuration for your tools.xml (not included in patch): tool id=15 name=Eraser pixmap=tool-eraser-okular tooltipEraser/tooltip engine type=Eraser / shortcut7/shortcut /tool The eraser builds on the work for the outline selection proposed in review request #109627. Please apply that patch before this one. Diffs - ui/pageviewannotator.cpp 7bd7496 Diff: http://git.reviewboard.kde.org/r/109632/diff/ Testing --- While it worked fine for the few PDFs I threw at it on this relatively powerful machine, it was pointed out to me in #okular, that calls to modifyPageAnnotation are very expensive as poppler has to re-draw the pdf (with the annotations) for every change. I hope we can resume the discussion about possible improvements here. Thanks, Peter Grasch ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 109632: Annotation eraser
On March 24, 2013, 1:06 a.m., Jon Mease wrote: Comments on the functionality (not the implementation): 1) I'm really excited to have this functionality in Okular (My work on the undo functionality was also primarily motivated by the desire to replace Xournal with Okular for tablet PC ink document annotation). 2) How difficult would it be to add something like an erase ink strokes option to the tools.xml. Xournal has this option and it controls whether an ink stroke is fully deleted by the eraser (as you do for the other annotation types) or erased incrementally (your current implementation for ink annotations). I've found both of these settings to be quite helpful under different circumstances. To do that, we would just need to *not* treat the ink annotation as a special case. Btw, it would also be easy to add a pen width to the eraser by not using objectRects but nearestObjectRect (iteratively for as long as distance = penWidth). - Peter --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109632/#review29779 --- On March 21, 2013, 1:26 a.m., Peter Grasch wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109632/ --- (Updated March 21, 2013, 1:26 a.m.) Review request for Okular. Description --- Prerequisites: Please read till the end! This introduces a new annotation tool: Eraser. The eraser primarily erases other annotations that it comes into contact with (shapes, lines, highlights, etc.). However, ink annotations are treated more like a real eraser: Existing paths are split and unaffected parts are preserved. This is what it looks like: http://bedahr.org/eraser.ogv Example tool configuration for your tools.xml (not included in patch): tool id=15 name=Eraser pixmap=tool-eraser-okular tooltipEraser/tooltip engine type=Eraser / shortcut7/shortcut /tool The eraser builds on the work for the outline selection proposed in review request #109627. Please apply that patch before this one. Diffs - ui/pageviewannotator.cpp 7bd7496 Diff: http://git.reviewboard.kde.org/r/109632/diff/ Testing --- While it worked fine for the few PDFs I threw at it on this relatively powerful machine, it was pointed out to me in #okular, that calls to modifyPageAnnotation are very expensive as poppler has to re-draw the pdf (with the annotations) for every change. I hope we can resume the discussion about possible improvements here. Thanks, Peter Grasch ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 109632: Annotation eraser
On March 22, 2013, 8:19 p.m., Albert Astals Cid wrote: So yeah, besides what Fabio comments on it may well be a bit slow (no way to speed it up unless you change poppler to do two pass rendering that might even be possible) code looks ok *but* it will stop working when the undo/redo annotations code gets merged. I'd suggest you have a look at it and try to find out how you'd apply your changes on top of it. I'll hold off until that is committed then. No reason to start complicating things, this is not that urgent. - Peter --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109632/#review29738 --- On March 21, 2013, 1:26 a.m., Peter Grasch wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109632/ --- (Updated March 21, 2013, 1:26 a.m.) Review request for Okular. Description --- Prerequisites: Please read till the end! This introduces a new annotation tool: Eraser. The eraser primarily erases other annotations that it comes into contact with (shapes, lines, highlights, etc.). However, ink annotations are treated more like a real eraser: Existing paths are split and unaffected parts are preserved. This is what it looks like: http://bedahr.org/eraser.ogv Example tool configuration for your tools.xml (not included in patch): tool id=15 name=Eraser pixmap=tool-eraser-okular tooltipEraser/tooltip engine type=Eraser / shortcut7/shortcut /tool The eraser builds on the work for the outline selection proposed in review request #109627. Please apply that patch before this one. Diffs - ui/pageviewannotator.cpp 7bd7496 Diff: http://git.reviewboard.kde.org/r/109632/diff/ Testing --- While it worked fine for the few PDFs I threw at it on this relatively powerful machine, it was pointed out to me in #okular, that calls to modifyPageAnnotation are very expensive as poppler has to re-draw the pdf (with the annotations) for every change. I hope we can resume the discussion about possible improvements here. Thanks, Peter Grasch ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 109632: Annotation eraser
On March 22, 2013, 8:19 p.m., Albert Astals Cid wrote: So yeah, besides what Fabio comments on it may well be a bit slow (no way to speed it up unless you change poppler to do two pass rendering that might even be possible) code looks ok *but* it will stop working when the undo/redo annotations code gets merged. I'd suggest you have a look at it and try to find out how you'd apply your changes on top of it. Peter Grasch wrote: I'll hold off until that is committed then. No reason to start complicating things, this is not that urgent. I don't think it will be difficult to rebase your changes onto the new undo functionality (once it's merged) but let me know if you have any questions. - Jon --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109632/#review29738 --- On March 21, 2013, 1:26 a.m., Peter Grasch wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109632/ --- (Updated March 21, 2013, 1:26 a.m.) Review request for Okular. Description --- Prerequisites: Please read till the end! This introduces a new annotation tool: Eraser. The eraser primarily erases other annotations that it comes into contact with (shapes, lines, highlights, etc.). However, ink annotations are treated more like a real eraser: Existing paths are split and unaffected parts are preserved. This is what it looks like: http://bedahr.org/eraser.ogv Example tool configuration for your tools.xml (not included in patch): tool id=15 name=Eraser pixmap=tool-eraser-okular tooltipEraser/tooltip engine type=Eraser / shortcut7/shortcut /tool The eraser builds on the work for the outline selection proposed in review request #109627. Please apply that patch before this one. Diffs - ui/pageviewannotator.cpp 7bd7496 Diff: http://git.reviewboard.kde.org/r/109632/diff/ Testing --- While it worked fine for the few PDFs I threw at it on this relatively powerful machine, it was pointed out to me in #okular, that calls to modifyPageAnnotation are very expensive as poppler has to re-draw the pdf (with the annotations) for every change. I hope we can resume the discussion about possible improvements here. Thanks, Peter Grasch ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 109632: Annotation eraser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109632/#review29779 --- Comments on the functionality (not the implementation): 1) I'm really excited to have this functionality in Okular (My work on the undo functionality was also primarily motivated by the desire to replace Xournal with Okular for tablet PC ink document annotation). 2) How difficult would it be to add something like an erase ink strokes option to the tools.xml. Xournal has this option and it controls whether an ink stroke is fully deleted by the eraser (as you do for the other annotation types) or erased incrementally (your current implementation for ink annotations). I've found both of these settings to be quite helpful under different circumstances. - Jon Mease On March 21, 2013, 1:26 a.m., Peter Grasch wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109632/ --- (Updated March 21, 2013, 1:26 a.m.) Review request for Okular. Description --- Prerequisites: Please read till the end! This introduces a new annotation tool: Eraser. The eraser primarily erases other annotations that it comes into contact with (shapes, lines, highlights, etc.). However, ink annotations are treated more like a real eraser: Existing paths are split and unaffected parts are preserved. This is what it looks like: http://bedahr.org/eraser.ogv Example tool configuration for your tools.xml (not included in patch): tool id=15 name=Eraser pixmap=tool-eraser-okular tooltipEraser/tooltip engine type=Eraser / shortcut7/shortcut /tool The eraser builds on the work for the outline selection proposed in review request #109627. Please apply that patch before this one. Diffs - ui/pageviewannotator.cpp 7bd7496 Diff: http://git.reviewboard.kde.org/r/109632/diff/ Testing --- While it worked fine for the few PDFs I threw at it on this relatively powerful machine, it was pointed out to me in #okular, that calls to modifyPageAnnotation are very expensive as poppler has to re-draw the pdf (with the annotations) for every change. I hope we can resume the discussion about possible improvements here. Thanks, Peter Grasch ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 109632: Annotation eraser
On March 21, 2013, 11:29 p.m., Albert Astals Cid wrote: It does indeed look cool, but is there a use case? I mean do you usually have so much complex Ink annotations that you need to cut them only partially? For example: 1. Correct a shoddily drawn shape 2. Remove an accidentally drawn line over something else without having to re-do what's below 3. Change an I to an i :) 4. ... Also, it much more directly mirrors what a user will probably expect from an eraser tool. FWIW, these review requests are a direct result of me trying to switch from Xournal to Okular for taking notes in class. I implemented this because I thought it would be a nice feature to use - not a nice one to implement. - Peter --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109632/#review29667 --- On March 21, 2013, 1:26 a.m., Peter Grasch wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109632/ --- (Updated March 21, 2013, 1:26 a.m.) Review request for Okular. Description --- Prerequisites: Please read till the end! This introduces a new annotation tool: Eraser. The eraser primarily erases other annotations that it comes into contact with (shapes, lines, highlights, etc.). However, ink annotations are treated more like a real eraser: Existing paths are split and unaffected parts are preserved. This is what it looks like: http://bedahr.org/eraser.ogv Example tool configuration for your tools.xml (not included in patch): tool id=15 name=Eraser pixmap=tool-eraser-okular tooltipEraser/tooltip engine type=Eraser / shortcut7/shortcut /tool The eraser builds on the work for the outline selection proposed in review request #109627. Please apply that patch before this one. Diffs - ui/pageviewannotator.cpp 7bd7496 Diff: http://git.reviewboard.kde.org/r/109632/diff/ Testing --- While it worked fine for the few PDFs I threw at it on this relatively powerful machine, it was pointed out to me in #okular, that calls to modifyPageAnnotation are very expensive as poppler has to re-draw the pdf (with the annotations) for every change. I hope we can resume the discussion about possible improvements here. Thanks, Peter Grasch ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 109632: Annotation eraser
On March 21, 2013, 11:29 p.m., Albert Astals Cid wrote: It does indeed look cool, but is there a use case? I mean do you usually have so much complex Ink annotations that you need to cut them only partially? Peter Grasch wrote: For example: 1. Correct a shoddily drawn shape 2. Remove an accidentally drawn line over something else without having to re-do what's below 3. Change an I to an i :) 4. ... Also, it much more directly mirrors what a user will probably expect from an eraser tool. FWIW, these review requests are a direct result of me trying to switch from Xournal to Okular for taking notes in class. I implemented this because I thought it would be a nice feature to use - not a nice one to implement. So *you* are the use case, that works for me. - Albert --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109632/#review29667 --- On March 21, 2013, 1:26 a.m., Peter Grasch wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109632/ --- (Updated March 21, 2013, 1:26 a.m.) Review request for Okular. Description --- Prerequisites: Please read till the end! This introduces a new annotation tool: Eraser. The eraser primarily erases other annotations that it comes into contact with (shapes, lines, highlights, etc.). However, ink annotations are treated more like a real eraser: Existing paths are split and unaffected parts are preserved. This is what it looks like: http://bedahr.org/eraser.ogv Example tool configuration for your tools.xml (not included in patch): tool id=15 name=Eraser pixmap=tool-eraser-okular tooltipEraser/tooltip engine type=Eraser / shortcut7/shortcut /tool The eraser builds on the work for the outline selection proposed in review request #109627. Please apply that patch before this one. Diffs - ui/pageviewannotator.cpp 7bd7496 Diff: http://git.reviewboard.kde.org/r/109632/diff/ Testing --- While it worked fine for the few PDFs I threw at it on this relatively powerful machine, it was pointed out to me in #okular, that calls to modifyPageAnnotation are very expensive as poppler has to re-draw the pdf (with the annotations) for every change. I hope we can resume the discussion about possible improvements here. Thanks, Peter Grasch ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 109632: Annotation eraser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109632/#review29738 --- So yeah, besides what Fabio comments on it may well be a bit slow (no way to speed it up unless you change poppler to do two pass rendering that might even be possible) code looks ok *but* it will stop working when the undo/redo annotations code gets merged. I'd suggest you have a look at it and try to find out how you'd apply your changes on top of it. ui/pageviewannotator.cpp http://git.reviewboard.kde.org/r/109632/#comment22135 const - Albert Astals Cid On March 21, 2013, 1:26 a.m., Peter Grasch wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109632/ --- (Updated March 21, 2013, 1:26 a.m.) Review request for Okular. Description --- Prerequisites: Please read till the end! This introduces a new annotation tool: Eraser. The eraser primarily erases other annotations that it comes into contact with (shapes, lines, highlights, etc.). However, ink annotations are treated more like a real eraser: Existing paths are split and unaffected parts are preserved. This is what it looks like: http://bedahr.org/eraser.ogv Example tool configuration for your tools.xml (not included in patch): tool id=15 name=Eraser pixmap=tool-eraser-okular tooltipEraser/tooltip engine type=Eraser / shortcut7/shortcut /tool The eraser builds on the work for the outline selection proposed in review request #109627. Please apply that patch before this one. Diffs - ui/pageviewannotator.cpp 7bd7496 Diff: http://git.reviewboard.kde.org/r/109632/diff/ Testing --- While it worked fine for the few PDFs I threw at it on this relatively powerful machine, it was pointed out to me in #okular, that calls to modifyPageAnnotation are very expensive as poppler has to re-draw the pdf (with the annotations) for every change. I hope we can resume the discussion about possible improvements here. Thanks, Peter Grasch ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] Review Request 109632: Annotation eraser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109632/ --- Review request for Okular. Description --- This introduces a new annotation tool: Eraser. The eraser primarily erases other annotations that it comes into contact with (shapes, lines, highlights, etc.). However, ink annotations are treated more like a real eraser: Existing paths are split and unaffected parts are preserved. This is what it looks like: http://bedahr.org/eraser.ogv Example tool configuration for your tools.xml (not included in patch): tool id=15 name=Eraser pixmap=tool-eraser-okular tooltipEraser/tooltip engine type=Eraser / shortcut7/shortcut /tool Diffs - ui/pageviewannotator.cpp 7bd7496 Diff: http://git.reviewboard.kde.org/r/109632/diff/ Testing --- While it worked fine for the few PDFs I threw at it on this relatively powerful machine, it was pointed out to me in #okular, that calls to modifyPageAnnotation are very expensive as poppler has to re-draw the pdf (with the annotations) for every change. I hope we can resume the discussion about possible improvements here. Thanks, Peter Grasch ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 109632: Annotation eraser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109632/#review29667 --- It does indeed look cool, but is there a use case? I mean do you usually have so much complex Ink annotations that you need to cut them only partially? - Albert Astals Cid On March 21, 2013, 1:26 a.m., Peter Grasch wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109632/ --- (Updated March 21, 2013, 1:26 a.m.) Review request for Okular. Description --- Prerequisites: Please read till the end! This introduces a new annotation tool: Eraser. The eraser primarily erases other annotations that it comes into contact with (shapes, lines, highlights, etc.). However, ink annotations are treated more like a real eraser: Existing paths are split and unaffected parts are preserved. This is what it looks like: http://bedahr.org/eraser.ogv Example tool configuration for your tools.xml (not included in patch): tool id=15 name=Eraser pixmap=tool-eraser-okular tooltipEraser/tooltip engine type=Eraser / shortcut7/shortcut /tool The eraser builds on the work for the outline selection proposed in review request #109627. Please apply that patch before this one. Diffs - ui/pageviewannotator.cpp 7bd7496 Diff: http://git.reviewboard.kde.org/r/109632/diff/ Testing --- While it worked fine for the few PDFs I threw at it on this relatively powerful machine, it was pointed out to me in #okular, that calls to modifyPageAnnotation are very expensive as poppler has to re-draw the pdf (with the annotations) for every change. I hope we can resume the discussion about possible improvements here. Thanks, Peter Grasch ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 109632: Annotation eraser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109632/ --- (Updated March 21, 2013, 1:26 a.m.) Review request for Okular. Description (updated) --- Prerequisites: Please read till the end! This introduces a new annotation tool: Eraser. The eraser primarily erases other annotations that it comes into contact with (shapes, lines, highlights, etc.). However, ink annotations are treated more like a real eraser: Existing paths are split and unaffected parts are preserved. This is what it looks like: http://bedahr.org/eraser.ogv Example tool configuration for your tools.xml (not included in patch): tool id=15 name=Eraser pixmap=tool-eraser-okular tooltipEraser/tooltip engine type=Eraser / shortcut7/shortcut /tool The eraser builds on the work for the outline selection proposed in review request #109627. Please apply that patch before this one. Diffs - ui/pageviewannotator.cpp 7bd7496 Diff: http://git.reviewboard.kde.org/r/109632/diff/ Testing --- While it worked fine for the few PDFs I threw at it on this relatively powerful machine, it was pointed out to me in #okular, that calls to modifyPageAnnotation are very expensive as poppler has to re-draw the pdf (with the annotations) for every change. I hope we can resume the discussion about possible improvements here. Thanks, Peter Grasch ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
