Re: [Okular-devel] Review Request 109633: Use crosshair cursor while annotating
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109633/#review34925 --- This review has been submitted with commit 09dad5e6d2124731166b75050a1bc8b4f038eee9 by Albert Astals Cid on behalf of Peter Grasch to branch master. - Commit Hook On June 17, 2013, 11:11 a.m., Peter Grasch wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109633/ --- (Updated June 17, 2013, 11:11 a.m.) Review request for Okular. Description --- The open hand cursor is imho very inconvenient for inconvenient for most types of annotations. Especially ink annotations are much more useful with that added bit of control (the open hand cursor covers the virtual pen tip). The patch itself feels a bit contrived. Please let me know if there is a better way to do this given Okulars architecture. Diffs - ui/pageview.h a9a291c ui/pageview.cpp 6567d5b ui/pageviewannotator.h 33e42a7 ui/pageviewannotator.cpp d1d259e Diff: http://git.reviewboard.kde.org/r/109633/diff/ Testing --- Tested successfully: Tool selection, deselection, continuous mode. Thanks, Peter Grasch ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 109633: Use crosshair cursor while annotating
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109633/ --- (Updated June 23, 2013, 6:45 p.m.) Status -- This change has been marked as submitted. Review request for Okular. Description --- The open hand cursor is imho very inconvenient for inconvenient for most types of annotations. Especially ink annotations are much more useful with that added bit of control (the open hand cursor covers the virtual pen tip). The patch itself feels a bit contrived. Please let me know if there is a better way to do this given Okulars architecture. Diffs - ui/pageview.h a9a291c ui/pageview.cpp 6567d5b ui/pageviewannotator.h 33e42a7 ui/pageviewannotator.cpp d1d259e Diff: http://git.reviewboard.kde.org/r/109633/diff/ Testing --- Tested successfully: Tool selection, deselection, continuous mode. Thanks, Peter Grasch ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 109633: Use crosshair cursor while annotating
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109633/ --- (Updated June 17, 2013, 11:11 a.m.) Review request for Okular. Changes --- Only show forbidden cursor when not currently annotating. Description --- The open hand cursor is imho very inconvenient for inconvenient for most types of annotations. Especially ink annotations are much more useful with that added bit of control (the open hand cursor covers the virtual pen tip). The patch itself feels a bit contrived. Please let me know if there is a better way to do this given Okulars architecture. Diffs (updated) - ui/pageview.h a9a291c ui/pageview.cpp 6567d5b ui/pageviewannotator.h 33e42a7 ui/pageviewannotator.cpp d1d259e Diff: http://git.reviewboard.kde.org/r/109633/diff/ Testing --- Tested successfully: Tool selection, deselection, continuous mode. Thanks, Peter Grasch ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 109633: Use crosshair cursor while annotating
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109633/ --- (Updated March 23, 2013, 9:14 a.m.) Review request for Okular. Changes --- Until further mouse movement, I keep seeing the crosshair cursor when I'm done making an annotation in non-continuous mode or after closing the annotation toolbar (F6). Done. PageViewAnnotator::active() seems very similar to PageViewAnnotator::routeEvents(). Maybe we can just rename s/routeEvents/active/ ? Done. I think we should not show the crosshair cursor when the mouse is *not* on a page (because you can't draw annotations there) Disagreed. I think switching the cursor while the user is still on the toolbar instantly shows that the tool has now been selected and is ready to use. Maybe it's just me but I like that. Also, as Albert pointed out, some annotations can be ended in the space between pages. Description --- The open hand cursor is imho very inconvenient for inconvenient for most types of annotations. Especially ink annotations are much more useful with that added bit of control (the open hand cursor covers the virtual pen tip). The patch itself feels a bit contrived. Please let me know if there is a better way to do this given Okulars architecture. Diffs (updated) - ui/pageview.cpp e8d481d ui/pageviewannotator.h 850d887 ui/pageviewannotator.cpp 4615d1c Diff: http://git.reviewboard.kde.org/r/109633/diff/ Testing --- Tested successfully: Tool selection, deselection, continuous mode. Thanks, Peter Grasch ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 109633: Use crosshair cursor while annotating
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109633/ --- (Updated March 23, 2013, 9:01 p.m.) Review request for Okular. Changes --- Okular now shows a forbidden cursor when outside the page. In order to select the correct cursor when annotation tool is selected with a keyboard shortcut (where we can make no assumptions about the mouse position), I had to make pickItemOnPoint public. Description --- The open hand cursor is imho very inconvenient for inconvenient for most types of annotations. Especially ink annotations are much more useful with that added bit of control (the open hand cursor covers the virtual pen tip). The patch itself feels a bit contrived. Please let me know if there is a better way to do this given Okulars architecture. Diffs (updated) - ui/pageview.h 5e839f2 ui/pageview.cpp e8d481d ui/pageviewannotator.h 850d887 ui/pageviewannotator.cpp 4615d1c Diff: http://git.reviewboard.kde.org/r/109633/diff/ Testing --- Tested successfully: Tool selection, deselection, continuous mode. Thanks, Peter Grasch ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] Review Request 109633: Use crosshair cursor while annotating
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109633/ --- Review request for Okular. Description --- The open hand cursor is imho very inconvenient for inconvenient for most types of annotations. Especially ink annotations are much more useful with that added bit of control (the open hand cursor covers the virtual pen tip). The patch itself feels a bit contrived. Please let me know if there is a better way to do this given Okulars architecture. Diffs - ui/pageviewannotator.cpp 7bd7496 ui/pageviewannotator.h 850d887 ui/pageview.cpp e8d481d Diff: http://git.reviewboard.kde.org/r/109633/diff/ Testing --- Tested successfully: Tool selection, deselection, continuous mode. Thanks, Peter Grasch ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 109633: Use crosshair cursor while annotating
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109633/#review29658 --- A few notes: - Until further mouse movement, I keep seeing the crosshair cursor when I'm done making an annotation in non-continuous mode or after closing the annotation toolbar (F6). - PageViewAnnotator::active() seems very similar to PageViewAnnotator::routeEvents(). Maybe we can just rename s/routeEvents/active/ ? - I think we should not show the crosshair cursor when the mouse is *not* on a page (because you can't draw annotations there) - Fabio D'Urso On March 21, 2013, 1:22 a.m., Peter Grasch wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109633/ --- (Updated March 21, 2013, 1:22 a.m.) Review request for Okular. Description --- The open hand cursor is imho very inconvenient for inconvenient for most types of annotations. Especially ink annotations are much more useful with that added bit of control (the open hand cursor covers the virtual pen tip). The patch itself feels a bit contrived. Please let me know if there is a better way to do this given Okulars architecture. Diffs - ui/pageviewannotator.cpp 7bd7496 ui/pageviewannotator.h 850d887 ui/pageview.cpp e8d481d Diff: http://git.reviewboard.kde.org/r/109633/diff/ Testing --- Tested successfully: Tool selection, deselection, continuous mode. Thanks, Peter Grasch ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 109633: Use crosshair cursor while annotating
On March 21, 2013, 8:11 p.m., Fabio D'Urso wrote: A few notes: - Until further mouse movement, I keep seeing the crosshair cursor when I'm done making an annotation in non-continuous mode or after closing the annotation toolbar (F6). - PageViewAnnotator::active() seems very similar to PageViewAnnotator::routeEvents(). Maybe we can just rename s/routeEvents/active/ ? - I think we should not show the crosshair cursor when the mouse is *not* on a page (because you can't draw annotations there) I think we should not show the crosshair cursor when the mouse is *not* on a page (because you can't draw annotations there) But you can end one (e.g. a line) - Albert --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109633/#review29658 --- On March 21, 2013, 1:22 a.m., Peter Grasch wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109633/ --- (Updated March 21, 2013, 1:22 a.m.) Review request for Okular. Description --- The open hand cursor is imho very inconvenient for inconvenient for most types of annotations. Especially ink annotations are much more useful with that added bit of control (the open hand cursor covers the virtual pen tip). The patch itself feels a bit contrived. Please let me know if there is a better way to do this given Okulars architecture. Diffs - ui/pageviewannotator.cpp 7bd7496 ui/pageviewannotator.h 850d887 ui/pageview.cpp e8d481d Diff: http://git.reviewboard.kde.org/r/109633/diff/ Testing --- Tested successfully: Tool selection, deselection, continuous mode. Thanks, Peter Grasch ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
