[Okular-devel] Review Request 109989: Fixes bug 318091 and adds undo unit tests
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109989/ --- Review request for Okular. Description --- Fixes bug 318091 (Undo / Redo of annotation creation doesn't properly handle page rotation) and adds associated unit test. Also adds a plethora of unit tests covering all of the new annotation undo commands (https://git.reviewboard.kde.org/r/107442/) This addresses bug 318091. http://bugs.kde.org/show_bug.cgi?id=318091 Diffs - tests/modifyannotationpropertiestest.cpp PRE-CREATION tests/editannotationcontentstest.cpp PRE-CREATION tests/addremoveannotationtest.cpp PRE-CREATION core/page.cpp bb9ae83 tests/CMakeLists.txt 5d1ce2d core/document.cpp 3302b76 tests/testingutils.h PRE-CREATION tests/testingutils.cpp PRE-CREATION tests/translateannotationtest.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/109989/diff/ Testing --- This is testing :-) Thanks, Jon Mease ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 109989: Fixes bug 318091 and adds undo unit tests
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109989/#review31005 --- This review has been submitted with commit 3c6140b616fe1e4979b229869c378396200bf4de by Albert Astals Cid on behalf of Jon Mease to branch master. - Commit Hook On April 13, 2013, 10:55 a.m., Jon Mease wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109989/ --- (Updated April 13, 2013, 10:55 a.m.) Review request for Okular. Description --- Fixes bug 318091 (Undo / Redo of annotation creation doesn't properly handle page rotation) and adds associated unit test. Also adds a plethora of unit tests covering all of the new annotation undo commands (https://git.reviewboard.kde.org/r/107442/) This addresses bug 318091. http://bugs.kde.org/show_bug.cgi?id=318091 Diffs - tests/modifyannotationpropertiestest.cpp PRE-CREATION tests/editannotationcontentstest.cpp PRE-CREATION tests/addremoveannotationtest.cpp PRE-CREATION core/page.cpp bb9ae83 tests/CMakeLists.txt 5d1ce2d core/document.cpp 3302b76 tests/testingutils.h PRE-CREATION tests/testingutils.cpp PRE-CREATION tests/translateannotationtest.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/109989/diff/ Testing --- This is testing :-) Thanks, Jon Mease ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 109989: Fixes bug 318091 and adds undo unit tests
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109989/ --- (Updated April 13, 2013, 8:55 p.m.) Status -- This change has been marked as submitted. Review request for Okular. Description --- Fixes bug 318091 (Undo / Redo of annotation creation doesn't properly handle page rotation) and adds associated unit test. Also adds a plethora of unit tests covering all of the new annotation undo commands (https://git.reviewboard.kde.org/r/107442/) This addresses bug 318091. http://bugs.kde.org/show_bug.cgi?id=318091 Diffs - tests/modifyannotationpropertiestest.cpp PRE-CREATION tests/editannotationcontentstest.cpp PRE-CREATION tests/addremoveannotationtest.cpp PRE-CREATION core/page.cpp bb9ae83 tests/CMakeLists.txt 5d1ce2d core/document.cpp 3302b76 tests/testingutils.h PRE-CREATION tests/testingutils.cpp PRE-CREATION tests/translateannotationtest.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/109989/diff/ Testing --- This is testing :-) Thanks, Jon Mease ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
