Re: [Okular-devel] Review Request 114049: Add unit tests for editing PDF forms
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114049/#review44318 --- This review has been submitted with commit 126b9fdf8c581610f3af54b6906f00b3d814e9c9 by Albert Astals Cid on behalf of Jon Mease to branch KDE/4.12. - Commit Hook On Nov. 22, 2013, 11:29 p.m., Jon Mease wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114049/ --- (Updated Nov. 22, 2013, 11:29 p.m.) Review request for Okular. Repository: okular Description --- Add a set of unit tests on the editing of PDF form data. These tests also test the undo/redo actions on forms. These tests require the attached formSamples.pdf file be included in the tests/data directory. These tests should apply to KDE/4.11 and onward, but I developed them against 4.12. Diffs - tests/CMakeLists.txt 800a2a7 tests/data/formSamples.pdf PRE-CREATION tests/editformstest.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/114049/diff/ Testing --- This is testing :-) File Attachments Form Samples PDF http://git.reviewboard.kde.org/media/uploaded/files/2013/11/22/0358848d-d534-4bea-b7cd-4f77dfdbfa11__formSamples.pdf Thanks, Jon Mease ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 114049: Add unit tests for editing PDF forms
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114049/ --- (Updated Nov. 24, 2013, 3:37 p.m.) Status -- This change has been marked as submitted. Review request for Okular. Repository: okular Description --- Add a set of unit tests on the editing of PDF form data. These tests also test the undo/redo actions on forms. These tests require the attached formSamples.pdf file be included in the tests/data directory. These tests should apply to KDE/4.11 and onward, but I developed them against 4.12. Diffs - tests/CMakeLists.txt 800a2a7 tests/data/formSamples.pdf PRE-CREATION tests/editformstest.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/114049/diff/ Testing --- This is testing :-) File Attachments Form Samples PDF http://git.reviewboard.kde.org/media/uploaded/files/2013/11/22/0358848d-d534-4bea-b7cd-4f77dfdbfa11__formSamples.pdf Thanks, Jon Mease ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 114049: Add unit tests for editing PDF forms
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114049/#review44319 --- Ship it! Good stuff :-) - Albert Astals Cid On Nov. 24, 2013, 3:37 p.m., Jon Mease wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114049/ --- (Updated Nov. 24, 2013, 3:37 p.m.) Review request for Okular. Repository: okular Description --- Add a set of unit tests on the editing of PDF form data. These tests also test the undo/redo actions on forms. These tests require the attached formSamples.pdf file be included in the tests/data directory. These tests should apply to KDE/4.11 and onward, but I developed them against 4.12. Diffs - tests/CMakeLists.txt 800a2a7 tests/data/formSamples.pdf PRE-CREATION tests/editformstest.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/114049/diff/ Testing --- This is testing :-) File Attachments Form Samples PDF http://git.reviewboard.kde.org/media/uploaded/files/2013/11/22/0358848d-d534-4bea-b7cd-4f77dfdbfa11__formSamples.pdf Thanks, Jon Mease ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 114049: Add unit tests for editing PDF forms
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114049/ --- (Updated Nov. 22, 2013, 11:29 p.m.) Review request for Okular. Repository: okular Description --- Add a set of unit tests on the editing of PDF form data. These tests also test the undo/redo actions on forms. These tests require the attached formSamples.pdf file be included in the tests/data directory. These tests should apply to KDE/4.11 and onward, but I developed them against 4.12. Diffs - tests/CMakeLists.txt 800a2a7 tests/data/formSamples.pdf PRE-CREATION tests/editformstest.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/114049/diff/ Testing --- This is testing :-) File Attachments Form Samples PDF http://git.reviewboard.kde.org/media/uploaded/files/2013/11/22/0358848d-d534-4bea-b7cd-4f77dfdbfa11__formSamples.pdf Thanks, Jon Mease ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
