Re: [Okular-devel] Review Request 118171: Fix for bug 118171 - crash when clicking in a text form that is not editable
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118171/ --- (Updated May 20, 2014, 9:25 p.m.) Status -- This change has been marked as submitted. Review request for Okular. Bugs: 334611 http://bugs.kde.org/show_bug.cgi?id=334611 Repository: okular Description --- Fix for bug 334611 - Crash when clicking in a text form that is not editable. Solution is to not connect the undo/redo support signals for read-only form fields. Diffs - ui/formwidgets.cpp 023a25f Diff: https://git.reviewboard.kde.org/r/118171/diff/ Testing --- Okular no longer crashes when selecting text from the read only text field in the PDF supplied with the bug report Thanks, Jon Mease ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 118171: Fix for bug 118171 - crash when clicking in a text form that is not editable
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118171/#review58207 --- Awesome work as always! - Albert Astals Cid On May 20, 2014, 9:25 p.m., Jon Mease wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118171/ --- (Updated May 20, 2014, 9:25 p.m.) Review request for Okular. Bugs: 334611 http://bugs.kde.org/show_bug.cgi?id=334611 Repository: okular Description --- Fix for bug 334611 - Crash when clicking in a text form that is not editable. Solution is to not connect the undo/redo support signals for read-only form fields. Diffs - ui/formwidgets.cpp 023a25f Diff: https://git.reviewboard.kde.org/r/118171/diff/ Testing --- Okular no longer crashes when selecting text from the read only text field in the PDF supplied with the bug report Thanks, Jon Mease ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] Review Request 118171: Fix for bug 118171 - crash when clicking in a text form that is not editable
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118171/ --- Review request for Okular. Bugs: 334611 http://bugs.kde.org/show_bug.cgi?id=334611 Repository: okular Description --- Fix for bug 334611 - Crash when clicking in a text form that is not editable. Solution is to not connect the undo/redo support signals for read-only form fields. Diffs - ui/formwidgets.cpp 023a25f Diff: https://git.reviewboard.kde.org/r/118171/diff/ Testing --- Okular no longer crashes when selecting text from the read only text field in the PDF supplied with the bug report Thanks, Jon Mease ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
