Re: [Okular-devel] Review Request 124069: Implement a 'Save' menu action (Fixes bug #348642)
On June 11, 2015, 11:16 a.m., Luigi Toscano wrote: Please note that the long term solution is to completely change the logic. https://forum.kde.org/viewtopic.php?f=251t=122750 Jonathan Verner wrote: aaah... :-) Now I see that there is even a branch for implementing these changes. But it seems that the last change to that branch was commited almost a year ago. What is the status of that branch? Is there something I can do to help? Albert Astals Cid wrote: Last email from Fabio said The okular side is mostly ok iirc, but what's still missing is proper poppler support for hot-switching the underlying file descriptor. It would work, but would result in annoying file reloads when you save. I'll try to find some time to keep working on it soon-ish, but definitely not on time for the freeze. I suggest you email him about what needs work or just try the branch yourself and see if it works, what needs fixing, etc. Unfortunately, I won't have time in the near future. I'll see what I can do afterwards... - Jonathan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124069/#review81377 --- On June 11, 2015, 11:03 a.m., Jonathan Verner wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124069/ --- (Updated June 11, 2015, 11:03 a.m.) Review request for Okular. Bugs: 348642 http://bugs.kde.org/show_bug.cgi?id=348642 Repository: okular Description --- Implement a 'Save' menu action to complement the 'Save As...' action. The action saves the current document. Note that it uses the Save As implementation but does not query the user for a filename instead using the document filename. Diffs - part.h 9eebdb2cd033eaec00ea88b57545721173e745f0 part.cpp 5b03e56e194bf84a9f02ceaf94cad13526715157 part.rc 60f86e5bae0ef235093711ba10be5eb3f30e7b36 Diff: https://git.reviewboard.kde.org/r/124069/diff/ Testing --- I ran okular and tested that Ctrl-S as well as the menu action that they work. Thanks, Jonathan Verner ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 124069: Implement a 'Save' menu action (Fixes bug #348642)
On jun. 11, 2015, 11:16 a.m., Luigi Toscano wrote: Please note that the long term solution is to completely change the logic. https://forum.kde.org/viewtopic.php?f=251t=122750 Jonathan Verner wrote: aaah... :-) Now I see that there is even a branch for implementing these changes. But it seems that the last change to that branch was commited almost a year ago. What is the status of that branch? Is there something I can do to help? Last email from Fabio said The okular side is mostly ok iirc, but what's still missing is proper poppler support for hot-switching the underlying file descriptor. It would work, but would result in annoying file reloads when you save. I'll try to find some time to keep working on it soon-ish, but definitely not on time for the freeze. I suggest you email him about what needs work or just try the branch yourself and see if it works, what needs fixing, etc. - Albert --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124069/#review81377 --- On jun. 11, 2015, 11:03 a.m., Jonathan Verner wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124069/ --- (Updated jun. 11, 2015, 11:03 a.m.) Review request for Okular. Bugs: 348642 http://bugs.kde.org/show_bug.cgi?id=348642 Repository: okular Description --- Implement a 'Save' menu action to complement the 'Save As...' action. The action saves the current document. Note that it uses the Save As implementation but does not query the user for a filename instead using the document filename. Diffs - part.h 9eebdb2cd033eaec00ea88b57545721173e745f0 part.cpp 5b03e56e194bf84a9f02ceaf94cad13526715157 part.rc 60f86e5bae0ef235093711ba10be5eb3f30e7b36 Diff: https://git.reviewboard.kde.org/r/124069/diff/ Testing --- I ran okular and tested that Ctrl-S as well as the menu action that they work. Thanks, Jonathan Verner ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
[Okular-devel] Review Request 124069: Implement a 'Save' menu action (Fixes bug #348642)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124069/ --- Review request for Okular. Bugs: 348642 http://bugs.kde.org/show_bug.cgi?id=348642 Repository: okular Description --- Implement a 'Save' menu action to complement the 'Save As...' action. The action saves the current document. Note that it uses the Save As implementation but does not query the user for a filename instead using the document filename. Diffs - part.h 9eebdb2cd033eaec00ea88b57545721173e745f0 part.cpp 5b03e56e194bf84a9f02ceaf94cad13526715157 part.rc 60f86e5bae0ef235093711ba10be5eb3f30e7b36 Diff: https://git.reviewboard.kde.org/r/124069/diff/ Testing --- I ran okular and tested that Ctrl-S as well as the menu action that they work. Thanks, Jonathan Verner ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 124069: Implement a 'Save' menu action (Fixes bug #348642)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124069/#review81377 --- Please note that the long term solution is to completely change the logic. https://forum.kde.org/viewtopic.php?f=251t=122750 - Luigi Toscano On June 11, 2015, 1:03 p.m., Jonathan Verner wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124069/ --- (Updated June 11, 2015, 1:03 p.m.) Review request for Okular. Bugs: 348642 http://bugs.kde.org/show_bug.cgi?id=348642 Repository: okular Description --- Implement a 'Save' menu action to complement the 'Save As...' action. The action saves the current document. Note that it uses the Save As implementation but does not query the user for a filename instead using the document filename. Diffs - part.h 9eebdb2cd033eaec00ea88b57545721173e745f0 part.cpp 5b03e56e194bf84a9f02ceaf94cad13526715157 part.rc 60f86e5bae0ef235093711ba10be5eb3f30e7b36 Diff: https://git.reviewboard.kde.org/r/124069/diff/ Testing --- I ran okular and tested that Ctrl-S as well as the menu action that they work. Thanks, Jonathan Verner ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 124069: Implement a 'Save' menu action (Fixes bug #348642)
On June 11, 2015, 11:16 a.m., Luigi Toscano wrote: Please note that the long term solution is to completely change the logic. https://forum.kde.org/viewtopic.php?f=251t=122750 aaah... :-) Now I see that there is even a branch for implementing these changes. But it seems that the last change to that branch was commited almost a year ago. What is the status of that branch? Is there something I can do to help? - Jonathan --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124069/#review81377 --- On June 11, 2015, 11:03 a.m., Jonathan Verner wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124069/ --- (Updated June 11, 2015, 11:03 a.m.) Review request for Okular. Bugs: 348642 http://bugs.kde.org/show_bug.cgi?id=348642 Repository: okular Description --- Implement a 'Save' menu action to complement the 'Save As...' action. The action saves the current document. Note that it uses the Save As implementation but does not query the user for a filename instead using the document filename. Diffs - part.h 9eebdb2cd033eaec00ea88b57545721173e745f0 part.cpp 5b03e56e194bf84a9f02ceaf94cad13526715157 part.rc 60f86e5bae0ef235093711ba10be5eb3f30e7b36 Diff: https://git.reviewboard.kde.org/r/124069/diff/ Testing --- I ran okular and tested that Ctrl-S as well as the menu action that they work. Thanks, Jonathan Verner ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
