[Okular-devel] Review Request 125397: adding RTL reading mode feature to okular

[Fahad Al-Saidi]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125397/
---

Review request for Okular.


Bugs: 325650
http://bugs.kde.org/show_bug.cgi?id=325650


Repository: okular


Description
---

This is my first patch to okular, so I am newbie here. This patch adds RTL 
reading mode to okular in following view modes:
- facing pages.
- facing ( center first page).
- Overview.

As well as adds “Right to left reading direction “ option to okular's settings.


Diffs
-

  conf/dlggeneral.cpp ad389f3 
  conf/dlggeneralbase.ui 03d5d5d 
  conf/okular.kcfg 76d7c37 
  conf/preferencesdialog.h dcea37e 
  interfaces/viewerinterface.h 4f27921 
  ui/pageview.cpp 6bff6ac 

Diff: https://git.reviewboard.kde.org/r/125397/diff/


Testing
---

I have tested in pdf & ODF files and it works fine.


Thanks,

Fahad Al-Saidi

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 125397: adding RTL reading mode feature to okular

[Fahad Al-Saidi]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125397/#review92307
---



any feedback?

- Fahad Al-Saidi


On Sept. 25, 2015, 4:05 p.m., Fahad Al-Saidi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125397/
> ---
> 
> (Updated Sept. 25, 2015, 4:05 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Bugs: 325650
> http://bugs.kde.org/show_bug.cgi?id=325650
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> This is my first patch to okular, so I am newbie here. This patch adds RTL 
> reading mode to okular in following view modes:
> - facing pages.
> - facing ( center first page).
> - Overview.
> 
> As well as adds “Right to left reading direction “ option to okular's 
> settings.
> 
> 
> Diffs
> -
> 
>   conf/dlggeneral.cpp ad389f3 
>   conf/dlggeneralbase.ui 03d5d5d 
>   conf/okular.kcfg 76d7c37 
>   conf/preferencesdialog.h dcea37e 
>   interfaces/viewerinterface.h 4f27921 
>   ui/pageview.cpp 6bff6ac 
> 
> Diff: https://git.reviewboard.kde.org/r/125397/diff/
> 
> 
> Testing
> ---
> 
> I have tested in pdf & ODF files and it works fine.
> 
> 
> Thanks,
> 
> Fahad Al-Saidi
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 125397: adding RTL reading mode feature to okular

[Albert Astals Cid]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125397/#review92546
---



Is this something that one would expect to set manually? Shouldn't it be 
detected from the file contents? Or that's just too hard/not optimal?


conf/dlggeneralbase.ui (line 388)


Why did you change the acceletaror?



ui/pageview.cpp (line 828)


Isn't that basically if (true) ?


- Albert Astals Cid


On Sept. 25, 2015, 4:05 p.m., Fahad Al-Saidi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125397/
> ---
> 
> (Updated Sept. 25, 2015, 4:05 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Bugs: 325650
> http://bugs.kde.org/show_bug.cgi?id=325650
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> This is my first patch to okular, so I am newbie here. This patch adds RTL 
> reading mode to okular in following view modes:
> - facing pages.
> - facing ( center first page).
> - Overview.
> 
> As well as adds “Right to left reading direction “ option to okular's 
> settings.
> 
> 
> Diffs
> -
> 
>   conf/dlggeneral.cpp ad389f3 
>   conf/dlggeneralbase.ui 03d5d5d 
>   conf/okular.kcfg 76d7c37 
>   conf/preferencesdialog.h dcea37e 
>   interfaces/viewerinterface.h 4f27921 
>   ui/pageview.cpp 6bff6ac 
> 
> Diff: https://git.reviewboard.kde.org/r/125397/diff/
> 
> 
> Testing
> ---
> 
> I have tested in pdf & ODF files and it works fine.
> 
> 
> Thanks,
> 
> Fahad Al-Saidi
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 125397: adding RTL reading mode feature to okular

[Fahad Al-Saidi]

> On Feb. 19, 2016, 12:27 a.m., Albert Astals Cid wrote:
> > Is this something that one would expect to set manually? Shouldn't it be 
> > detected from the file contents? Or that's just too hard/not optimal?

Sorry for late reply. I didn't get notified when you wrote your comment. It is 
weired from reviewboard. However, setting this option manually is better 
because most of times you want to read pdfs in RTL & LTR lanagues so you don't 
want to be forced in RTL mode when you read LTR pdf.


- Fahad


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125397/#review92546
---


On Sept. 25, 2015, 4:05 p.m., Fahad Al-Saidi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125397/
> ---
> 
> (Updated Sept. 25, 2015, 4:05 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Bugs: 325650
> http://bugs.kde.org/show_bug.cgi?id=325650
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> This is my first patch to okular, so I am newbie here. This patch adds RTL 
> reading mode to okular in following view modes:
> - facing pages.
> - facing ( center first page).
> - Overview.
> 
> As well as adds “Right to left reading direction “ option to okular's 
> settings.
> 
> 
> Diffs
> -
> 
>   conf/dlggeneral.cpp ad389f3 
>   conf/dlggeneralbase.ui 03d5d5d 
>   conf/okular.kcfg 76d7c37 
>   conf/preferencesdialog.h dcea37e 
>   interfaces/viewerinterface.h 4f27921 
>   ui/pageview.cpp 6bff6ac 
> 
> Diff: https://git.reviewboard.kde.org/r/125397/diff/
> 
> 
> Testing
> ---
> 
> I have tested in pdf & ODF files and it works fine.
> 
> 
> Thanks,
> 
> Fahad Al-Saidi
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 125397: adding RTL reading mode feature to okular

[Fahad Al-Saidi]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125397/
---

(Updated June 27, 2016, 12:54 p.m.)


Review request for Okular.


Changes
---

update patch per Albert feedback. Thanks Albert.


Bugs: 325650
http://bugs.kde.org/show_bug.cgi?id=325650


Repository: okular


Description
---

This is my first patch to okular, so I am newbie here. This patch adds RTL 
reading mode to okular in following view modes:
- facing pages.
- facing ( center first page).
- Overview.

As well as adds “Right to left reading direction “ option to okular's settings.


Diffs (updated)
-

  conf/dlggeneral.cpp 9945522 
  conf/dlggeneralbase.ui 03d5d5d 
  conf/okular.kcfg d90fe23 
  ui/pageview.cpp 26373bb 

Diff: https://git.reviewboard.kde.org/r/125397/diff/


Testing
---

I have tested in pdf & ODF files and it works fine.


Thanks,

Fahad Al-Saidi

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 125397: adding RTL reading mode feature to okular

[Fahad Al-Saidi]

> On Feb. 19, 2016, 12:27 a.m., Albert Astals Cid wrote:
> > conf/dlggeneralbase.ui, line 391
> > 
> >
> > Why did you change the acceletaror?

Oops, by mistake.


> On Feb. 19, 2016, 12:27 a.m., Albert Astals Cid wrote:
> > ui/pageview.cpp, line 828
> > 
> >
> > Isn't that basically if (true) ?

I want to notify slotRelayoutPages when RTL mode is enabled and disabled. 
However, I fix it with different approach.


- Fahad


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125397/#review92546
---


On June 27, 2016, 12:54 p.m., Fahad Al-Saidi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125397/
> ---
> 
> (Updated June 27, 2016, 12:54 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Bugs: 325650
> http://bugs.kde.org/show_bug.cgi?id=325650
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> This is my first patch to okular, so I am newbie here. This patch adds RTL 
> reading mode to okular in following view modes:
> - facing pages.
> - facing ( center first page).
> - Overview.
> 
> As well as adds “Right to left reading direction “ option to okular's 
> settings.
> 
> 
> Diffs
> -
> 
>   conf/dlggeneral.cpp 9945522 
>   conf/dlggeneralbase.ui 03d5d5d 
>   conf/okular.kcfg d90fe23 
>   ui/pageview.cpp 26373bb 
> 
> Diff: https://git.reviewboard.kde.org/r/125397/diff/
> 
> 
> Testing
> ---
> 
> I have tested in pdf & ODF files and it works fine.
> 
> 
> Thanks,
> 
> Fahad Al-Saidi
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 125397: adding RTL reading mode feature to okular

[Olivier Churlaud]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125397/#review97673
---



Mostly style correction. Then I think it will be fine. (I'll check again)


ui/pageview.cpp (line 829)


Trailing space here to remove



ui/pageview.cpp (line 4400)


Please be sure to respect the indentation



ui/pageview.cpp (line 4416)


Still indentation and 

]else { => } else {


- Olivier Churlaud


On June 27, 2016, 2:54 p.m., Fahad Al-Saidi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125397/
> ---
> 
> (Updated June 27, 2016, 2:54 p.m.)
> 
> 
> Review request for Okular.
> 
> 
> Bugs: 325650
> http://bugs.kde.org/show_bug.cgi?id=325650
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> This is my first patch to okular, so I am newbie here. This patch adds RTL 
> reading mode to okular in following view modes:
> - facing pages.
> - facing ( center first page).
> - Overview.
> 
> As well as adds “Right to left reading direction “ option to okular's 
> settings.
> 
> 
> Diffs
> -
> 
>   conf/dlggeneral.cpp 9945522 
>   conf/dlggeneralbase.ui 03d5d5d 
>   conf/okular.kcfg d90fe23 
>   ui/pageview.cpp 26373bb 
> 
> Diff: https://git.reviewboard.kde.org/r/125397/diff/
> 
> 
> Testing
> ---
> 
> I have tested in pdf & ODF files and it works fine.
> 
> 
> Thanks,
> 
> Fahad Al-Saidi
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 125397: adding RTL reading mode feature to okular

[Fahad Al-Saidi]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125397/
---

(Updated July 21, 2016, 5:07 a.m.)


Review request for Okular and Albert Astals Cid.


Bugs: 325650
http://bugs.kde.org/show_bug.cgi?id=325650


Repository: okular


Description
---

This is my first patch to okular, so I am newbie here. This patch adds RTL 
reading mode to okular in following view modes:
- facing pages.
- facing ( center first page).
- Overview.

As well as adds “Right to left reading direction “ option to okular's settings.


Diffs (updated)
-

  conf/dlggeneral.cpp 9945522 
  conf/dlggeneralbase.ui 03d5d5d 
  conf/okular.kcfg d90fe23 
  ui/pageview.cpp 26373bb 

Diff: https://git.reviewboard.kde.org/r/125397/diff/


Testing
---

I have tested in pdf & ODF files and it works fine.


Thanks,

Fahad Al-Saidi

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 125397: adding RTL reading mode feature to okular

[Fahad Al-Saidi]

> On July 20, 2016, 6:29 p.m., Olivier Churlaud wrote:
> > Mostly style correction. Then I think it will be fine. (I'll check again)

Great. All requested changes done. Thanks


- Fahad


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125397/#review97673
---


On July 21, 2016, 5:07 a.m., Fahad Al-Saidi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125397/
> ---
> 
> (Updated July 21, 2016, 5:07 a.m.)
> 
> 
> Review request for Okular and Albert Astals Cid.
> 
> 
> Bugs: 325650
> http://bugs.kde.org/show_bug.cgi?id=325650
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> This is my first patch to okular, so I am newbie here. This patch adds RTL 
> reading mode to okular in following view modes:
> - facing pages.
> - facing ( center first page).
> - Overview.
> 
> As well as adds “Right to left reading direction “ option to okular's 
> settings.
> 
> 
> Diffs
> -
> 
>   conf/dlggeneral.cpp 9945522 
>   conf/dlggeneralbase.ui 03d5d5d 
>   conf/okular.kcfg d90fe23 
>   ui/pageview.cpp 26373bb 
> 
> Diff: https://git.reviewboard.kde.org/r/125397/diff/
> 
> 
> Testing
> ---
> 
> I have tested in pdf & ODF files and it works fine.
> 
> 
> Thanks,
> 
> Fahad Al-Saidi
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 125397: adding RTL reading mode feature to okular

[Olivier Churlaud]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125397/#review97690
---



@Albert: If you could check. IMO, it can be shipped.

- Olivier Churlaud


On July 21, 2016, 7:07 a.m., Fahad Al-Saidi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125397/
> ---
> 
> (Updated July 21, 2016, 7:07 a.m.)
> 
> 
> Review request for Okular and Albert Astals Cid.
> 
> 
> Bugs: 325650
> http://bugs.kde.org/show_bug.cgi?id=325650
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> This is my first patch to okular, so I am newbie here. This patch adds RTL 
> reading mode to okular in following view modes:
> - facing pages.
> - facing ( center first page).
> - Overview.
> 
> As well as adds “Right to left reading direction “ option to okular's 
> settings.
> 
> 
> Diffs
> -
> 
>   conf/dlggeneral.cpp 9945522 
>   conf/dlggeneralbase.ui 03d5d5d 
>   conf/okular.kcfg d90fe23 
>   ui/pageview.cpp 26373bb 
> 
> Diff: https://git.reviewboard.kde.org/r/125397/diff/
> 
> 
> Testing
> ---
> 
> I have tested in pdf & ODF files and it works fine.
> 
> 
> Thanks,
> 
> Fahad Al-Saidi
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 125397: adding RTL reading mode feature to okular

[Albert Astals Cid]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125397/#review97739
---


Ship it!




Ship It!

- Albert Astals Cid


On July 21, 2016, 5:07 a.m., Fahad Al-Saidi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125397/
> ---
> 
> (Updated July 21, 2016, 5:07 a.m.)
> 
> 
> Review request for Okular and Albert Astals Cid.
> 
> 
> Bugs: 325650
> http://bugs.kde.org/show_bug.cgi?id=325650
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> This is my first patch to okular, so I am newbie here. This patch adds RTL 
> reading mode to okular in following view modes:
> - facing pages.
> - facing ( center first page).
> - Overview.
> 
> As well as adds “Right to left reading direction “ option to okular's 
> settings.
> 
> 
> Diffs
> -
> 
>   conf/dlggeneral.cpp 9945522 
>   conf/dlggeneralbase.ui 03d5d5d 
>   conf/okular.kcfg d90fe23 
>   ui/pageview.cpp 26373bb 
> 
> Diff: https://git.reviewboard.kde.org/r/125397/diff/
> 
> 
> Testing
> ---
> 
> I have tested in pdf & ODF files and it works fine.
> 
> 
> Thanks,
> 
> Fahad Al-Saidi
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 125397: adding RTL reading mode feature to okular

[Fahad Al-Saidi]

> On July 21, 2016, 11:03 p.m., Albert Astals Cid wrote:
> > Ship It!

Great.


- Fahad


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125397/#review97739
---


On July 21, 2016, 5:07 a.m., Fahad Al-Saidi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125397/
> ---
> 
> (Updated July 21, 2016, 5:07 a.m.)
> 
> 
> Review request for Okular and Albert Astals Cid.
> 
> 
> Bugs: 325650
> http://bugs.kde.org/show_bug.cgi?id=325650
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> This is my first patch to okular, so I am newbie here. This patch adds RTL 
> reading mode to okular in following view modes:
> - facing pages.
> - facing ( center first page).
> - Overview.
> 
> As well as adds “Right to left reading direction “ option to okular's 
> settings.
> 
> 
> Diffs
> -
> 
>   conf/dlggeneral.cpp 9945522 
>   conf/dlggeneralbase.ui 03d5d5d 
>   conf/okular.kcfg d90fe23 
>   ui/pageview.cpp 26373bb 
> 
> Diff: https://git.reviewboard.kde.org/r/125397/diff/
> 
> 
> Testing
> ---
> 
> I have tested in pdf & ODF files and it works fine.
> 
> 
> Thanks,
> 
> Fahad Al-Saidi
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 125397: adding RTL reading mode feature to okular

[Olivier Churlaud]

> On July 22, 2016, 1:03 a.m., Albert Astals Cid wrote:
> > Ship It!
> 
> Fahad Al-Saidi wrote:
> Great.

Can you ship it Fahad? Or should I in your behalf?


- Olivier


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125397/#review97739
---


On July 21, 2016, 7:07 a.m., Fahad Al-Saidi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125397/
> ---
> 
> (Updated July 21, 2016, 7:07 a.m.)
> 
> 
> Review request for Okular and Albert Astals Cid.
> 
> 
> Bugs: 325650
> http://bugs.kde.org/show_bug.cgi?id=325650
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> This is my first patch to okular, so I am newbie here. This patch adds RTL 
> reading mode to okular in following view modes:
> - facing pages.
> - facing ( center first page).
> - Overview.
> 
> As well as adds “Right to left reading direction “ option to okular's 
> settings.
> 
> 
> Diffs
> -
> 
>   conf/dlggeneral.cpp 9945522 
>   conf/dlggeneralbase.ui 03d5d5d 
>   conf/okular.kcfg d90fe23 
>   ui/pageview.cpp 26373bb 
> 
> Diff: https://git.reviewboard.kde.org/r/125397/diff/
> 
> 
> Testing
> ---
> 
> I have tested in pdf & ODF files and it works fine.
> 
> 
> Thanks,
> 
> Fahad Al-Saidi
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 125397: adding RTL reading mode feature to okular

[Fahad Al-Saidi]

> On July 21, 2016, 11:03 p.m., Albert Astals Cid wrote:
> > Ship It!
> 
> Fahad Al-Saidi wrote:
> Great.
> 
> Olivier Churlaud wrote:
> Can you ship it Fahad? Or should I in your behalf?

I can if I know :-) I am new here so any informoation will be great.


- Fahad


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125397/#review97739
---


On July 21, 2016, 5:07 a.m., Fahad Al-Saidi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125397/
> ---
> 
> (Updated July 21, 2016, 5:07 a.m.)
> 
> 
> Review request for Okular and Albert Astals Cid.
> 
> 
> Bugs: 325650
> http://bugs.kde.org/show_bug.cgi?id=325650
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> This is my first patch to okular, so I am newbie here. This patch adds RTL 
> reading mode to okular in following view modes:
> - facing pages.
> - facing ( center first page).
> - Overview.
> 
> As well as adds “Right to left reading direction “ option to okular's 
> settings.
> 
> 
> Diffs
> -
> 
>   conf/dlggeneral.cpp 9945522 
>   conf/dlggeneralbase.ui 03d5d5d 
>   conf/okular.kcfg d90fe23 
>   ui/pageview.cpp 26373bb 
> 
> Diff: https://git.reviewboard.kde.org/r/125397/diff/
> 
> 
> Testing
> ---
> 
> I have tested in pdf & ODF files and it works fine.
> 
> 
> Thanks,
> 
> Fahad Al-Saidi
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 125397: adding RTL reading mode feature to okular

[Albert Astals Cid]

> On July 21, 2016, 11:03 p.m., Albert Astals Cid wrote:
> > Ship It!
> 
> Fahad Al-Saidi wrote:
> Great.
> 
> Olivier Churlaud wrote:
> Can you ship it Fahad? Or should I in your behalf?
> 
> Fahad Al-Saidi wrote:
> I can if I know :-) I am new here so any informoation will be great.

Olivier, please commit this as I asked you. He doesn't have commit access 
https://websvn.kde.org/trunk/kde-common/accounts?view=markup


- Albert


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125397/#review97739
---


On July 21, 2016, 5:07 a.m., Fahad Al-Saidi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125397/
> ---
> 
> (Updated July 21, 2016, 5:07 a.m.)
> 
> 
> Review request for Okular and Albert Astals Cid.
> 
> 
> Bugs: 325650
> http://bugs.kde.org/show_bug.cgi?id=325650
> 
> 
> Repository: okular
> 
> 
> Description
> ---
> 
> This is my first patch to okular, so I am newbie here. This patch adds RTL 
> reading mode to okular in following view modes:
> - facing pages.
> - facing ( center first page).
> - Overview.
> 
> As well as adds “Right to left reading direction “ option to okular's 
> settings.
> 
> 
> Diffs
> -
> 
>   conf/dlggeneral.cpp 9945522 
>   conf/dlggeneralbase.ui 03d5d5d 
>   conf/okular.kcfg d90fe23 
>   ui/pageview.cpp 26373bb 
> 
> Diff: https://git.reviewboard.kde.org/r/125397/diff/
> 
> 
> Testing
> ---
> 
> I have tested in pdf & ODF files and it works fine.
> 
> 
> Thanks,
> 
> Fahad Al-Saidi
> 
>

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

Re: [Okular-devel] Review Request 125397: adding RTL reading mode feature to okular

[Fahad Al-Saidi]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125397/
---

(Updated July 26, 2016, 1:39 a.m.)


Status
--

This change has been marked as submitted.


Review request for Okular and Albert Astals Cid.


Changes
---

Submitted with commit 04908dba2f93842a0008ef1ba8c966621c615f9e by Olivier 
CHURLAUD to branch master.


Bugs: 325650
http://bugs.kde.org/show_bug.cgi?id=325650


Repository: okular


Description
---

This is my first patch to okular, so I am newbie here. This patch adds RTL 
reading mode to okular in following view modes:
- facing pages.
- facing ( center first page).
- Overview.

As well as adds “Right to left reading direction “ option to okular's settings.


Diffs
-

  conf/dlggeneral.cpp 9945522 
  conf/dlggeneralbase.ui 03d5d5d 
  conf/okular.kcfg d90fe23 
  ui/pageview.cpp 26373bb 

Diff: https://git.reviewboard.kde.org/r/125397/diff/


Testing
---

I have tested in pdf & ODF files and it works fine.


Thanks,

Fahad Al-Saidi

___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel