[okular] [Bug 318998] Add option to exit after printing

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=318998

Albert Astals Cid  changed:

   What|Removed |Added

  Latest Commit||https://commits.kde.org/oku
   ||lar/09b7b079ac92bd1da7bac6b
   ||04e2bed139506f2f8
 Status|CONFIRMED   |RESOLVED
 Resolution|--- |FIXED

--- Comment #27 from Albert Astals Cid  ---
Git commit 09b7b079ac92bd1da7bac6b04e2bed139506f2f8 by Albert Astals Cid, on
behalf of Dileep Sankhla.
Committed on 03/03/2018 at 16:36.
Pushed by aacid into branch 'master'.

Option to exit after printing

Summary:
When running okular with the parameter --print to directly open the print mode,
it doesn't exit after acknowledging the print dialog. Hence adding
--print_and_exit option exits Okular after acknowledging the print dialog and
thus is useful for the command line batch processing or a Dolphin service as
the issue suggests.

Test Plan:
1. open a file in Okular using the parameter --print. It will open Okular in
print mode with the print dialog
2. Either print the file or cancel the print dialog
3. You will find that Okular stays open
4. Now using this patch, see for available options with the --help parameter.
You will find --print_and_exit option
5. Now open a file in Okular using the parameter --print_and_exit. It will open
Okular in print mode with the print dialog
6. Either print the file or cancel the print dialog
7. You will find that Okular closes after acknowledging the dialog

Reviewers: aacid, #okular, ngraham

Subscribers: ltoscano, ngraham, aacid, #okular

Tags: #okular

Differential Revision: https://phabricator.kde.org/D10249

M  +11   -11   autotests/mainshelltest.cpp
M  +19   -4part.cpp
M  +3-1part.h
M  +1-0shell/main.cpp
M  +2-0shell/shell.cpp
M  +22   -13   shell/shellutils.cpp
M  +3-2shell/shellutils.h

https://commits.kde.org/okular/09b7b079ac92bd1da7bac6b04e2bed139506f2f8

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 318998] Add option to exit after printing

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=318998

Nate Graham  changed:

   What|Removed |Added

 CC||pointedst...@zoho.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 318998] Add option to exit after printing

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=318998

--- Comment #26 from Albert Astals Cid  ---
You need to show the gui, how will you select the printer, if you want black
and white or not, etc if you don't?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 318998] Add option to exit after printing

[Dileep Sankhla]

https://bugs.kde.org/show_bug.cgi?id=318998

--- Comment #25 from Dileep Sankhla  ---
Thank you. One more thing, should it opens the print dialog and then exit on
printing or should it be non-GUI that simply prints and exits? 
If the latter case, should it print the exit code?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 318998] Add option to exit after printing

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=318998

--- Comment #24 from Albert Astals Cid  ---
What comment #1 says, so add --print_and_exit

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 318998] Add option to exit after printing

[Dileep Sankhla]

https://bugs.kde.org/show_bug.cgi?id=318998

Dileep Sankhla  changed:

   What|Removed |Added

 CC||sankhla.dilee...@gmail.com

--- Comment #23 from Dileep Sankhla  ---
What does the issue actually mean - adding an option to automatically exit with
the exit code and message after acknowledging the print dialog when launched
with --print parameter or adding a separate parameter option as
--print_and_exit that do the same? Or is it something different? Confuse
between improving an existing parameter or adding a new parameter for the same.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Okular-devel] [okular] [Bug 318998] Add option to exit after printing

[Simon Andric]

https://bugs.kde.org/show_bug.cgi?id=318998

Simon Andric simonandr...@gmail.com changed:

   What|Removed |Added

 CC||simonandr...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 318998] Add option to exit after printing

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=318998

--- Comment #21 from Albert Astals Cid aa...@kde.org ---
read http://okular.kde.org/download.php

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 318998] Add option to exit after printing

[Ronnie . P . Thomas]

https://bugs.kde.org/show_bug.cgi?id=318998

Ronnie.P.Thomas ronnie...@gmail.com changed:

   What|Removed |Added

 CC||ronnie...@gmail.com

--- Comment #20 from Ronnie.P.Thomas ronnie...@gmail.com ---
I'd like to have a go at this bug...

I've compiled the program, but I think that the shell/okular file is using the
okularpart from my distribution's okular package. So, how can I make okular
load the 'okularpart' which was compiled with it? Do I need to install it in
/usr/local? I would prefer installing it some directory in my $HOME though..

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 318998] Add option to exit after printing

[Ronnie . P . Thomas]

https://bugs.kde.org/show_bug.cgi?id=318998

--- Comment #22 from Ronnie.P.Thomas ronnie...@gmail.com ---
Ah.. right, I should have read the manual. Thank you!

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 318998] Add option to exit after printing

[Abhyudaya]

https://bugs.kde.org/show_bug.cgi?id=318998

--- Comment #16 from Abhyudaya abhyu...@gmail.com ---
Thank you for patiently helping, I apologize for the newbie questions. I've
compiled and installed the copy of okular. How should I proceed further?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 318998] Add option to exit after printing

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=318998

--- Comment #17 from Albert Astals Cid aa...@kde.org ---
Have you tried doing anything at all before asking for what to do?

Anyway the bug even has a patch attached and you are not even asking about it,
are you not curious about it? 

Maybe someone should actually read all the comments of the bug and attach it to
reviewboard as I asked?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 318998] Add option to exit after printing

[Abhyudaya]

https://bugs.kde.org/show_bug.cgi?id=318998

--- Comment #18 from Abhyudaya abhyu...@gmail.com ---
Sorry this is the first time I'm trying to fix bugs so I don't have an idea
about anything. I did look into the path but didn't really understand anything
and after reading the comments i thought the bug hasn't been resolved yet so
asked about how to go about resolving it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 318998] Add option to exit after printing

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=318998

--- Comment #19 from Albert Astals Cid aa...@kde.org ---
So, i'm going what you need to do, you need to read okular code and produce a
patch that does what the bug says. From here it's your work, you need to put
99.999% of the time, and then if you have a very specific question, you drop by
our IRC client or our mailing list and ask it. If you want to reuse the
existing patch or not is your choice. And I hope you don't do the same mistake
Clayton did.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 318998] Add option to exit after printing

[Abhyudaya]

https://bugs.kde.org/show_bug.cgi?id=318998

--- Comment #14 from Abhyudaya abhyu...@gmail.com ---
I installed kde4 and got a copy of okular. I'm following the steps given here
https://okular.kde.org/download.php and i'm stuck at this command 
cmake -DCMAKE_INSTALL_PREFIX=/path/to/your/kde4/install/dir
I can't seem to figure out the path to the kde4 installation, I've tried
searching a lot
(http://askubuntu.com/questions/527492/kde4-config-shows-no-output/527512?iemail=1noredirect=1#527512)
but couldn't find anything

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 318998] Add option to exit after printing

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=318998

--- Comment #15 from Albert Astals Cid aa...@kde.org ---
/path/to/your/kde4/install/dir is whatever path you want.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 318998] Add option to exit after printing

[Abhyudaya]

https://bugs.kde.org/show_bug.cgi?id=318998

Abhyudaya abhyu...@gmail.com changed:

   What|Removed |Added

 CC||abhyu...@gmail.com

--- Comment #8 from Abhyudaya abhyu...@gmail.com ---
I would like to solve this bug. Where do I start?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 318998] Add option to exit after printing

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=318998

--- Comment #9 from Albert Astals Cid aa...@kde.org ---
Have you compiled okular already?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 318998] Add option to exit after printing

[Abhyudaya]

https://bugs.kde.org/show_bug.cgi?id=318998

--- Comment #10 from Abhyudaya abhyu...@gmail.com ---
No. where do I get the project to get started with?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 318998] Add option to exit after printing

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=318998

--- Comment #11 from Albert Astals Cid aa...@kde.org ---
http://lmgtfy.com/?q=okular+source+code

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 318998] Add option to exit after printing

[Abhyudaya]

https://bugs.kde.org/show_bug.cgi?id=318998

--- Comment #12 from Abhyudaya abhyu...@gmail.com ---
I installed it, how do i compile it?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 318998] Add option to exit after printing

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=318998

--- Comment #13 from Albert Astals Cid aa...@kde.org ---
Spend a few hours trying to answer the question for yourself and if you really
can't find the answer come back and ask again.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 318998] Add option to exit after printing

[Swarn Avinash Kumar]

https://bugs.kde.org/show_bug.cgi?id=318998

Swarn Avinash Kumar avinashzebi...@gmail.com changed:

   What|Removed |Added

 CC||avinashzebi...@gmail.com

--- Comment #6 from Swarn Avinash Kumar avinashzebi...@gmail.com ---
is this bug open? can I solve this bug?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 318998] Add option to exit after printing

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=318998

--- Comment #4 from Albert Astals Cid aa...@kde.org ---
Clayton?

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 318998] Add option to exit after printing

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=318998

Albert Astals Cid aa...@kde.org changed:

   What|Removed |Added

 CC||cgrs...@gmail.com

--- Comment #5 from Albert Astals Cid aa...@kde.org ---
And that's why one has to use reviewboard, because you leave a comment here and
you don't add yourself to the cc's so you ignore my answers...

Please Clayton, read up.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 318998] Add option to exit after printing

[Clayton Gerstner]

https://bugs.kde.org/show_bug.cgi?id=318998

--- Comment #2 from Clayton Gerstner cgrs...@gmail.com ---
Created attachment 79914
  -- https://bugs.kde.org/attachment.cgi?id=79914action=edit
Patch to add --print_and_exit

Here's a patch to add --print_and_exit to okular. It is perhaps overly simple.
Because batch processing was specifically mentioned it doesn't open the window
with print dialog, it simply prints and exits (with exit status guessed via
Part::doPrint(), again for batch processing/scriptability) though that would
obviously be trivial to change.

Anyway, it worked the one time I tested it connected to a printer. :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 318998] Add option to exit after printing

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=318998

--- Comment #3 from Albert Astals Cid aa...@kde.org ---
Hi Clayton, could you please use reviewboard.kde.org for the patches? It's much
easier to keep track of them and comment there than here in bugzilla.

Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel

[Okular-devel] [okular] [Bug 318998] Add option to exit after printing

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=318998

Albert Astals Cid aa...@kde.org changed:

   What|Removed |Added

   Keywords||junior-jobs
 Status|UNCONFIRMED |CONFIRMED
 CC||aa...@kde.org
 Ever confirmed|0   |1

--- Comment #1 from Albert Astals Cid aa...@kde.org ---
I'd probably go with a --print_and_exit since adding a --exit param makes no
sense :D

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Okular-devel mailing list
Okular-devel@kde.org
https://mail.kde.org/mailman/listinfo/okular-devel