[okular] [Bug 370726] Text selection tool highlight unintelligible with some color schemes

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=370726

Nate Graham  changed:

   What|Removed |Added

   Keywords||usability
Summary|Text selection tool |Text selection tool
   |highlight unintelligible|highlight unintelligible
   ||with some color schemes

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 370726] Text selection tool highlight unintelligible

[Mehrad Mahmoudian]

https://bugs.kde.org/show_bug.cgi?id=370726

--- Comment #7 from Mehrad Mahmoudian  ---
I think this is the right thread. I am using Breath Dark theme on my Plasma and
the selection theme works pretty fine everywhere that has a dark background
(Dolphine, Plasma Settings, Kate, ...) , and also due to color inversion, it
works fine in kdiff3 which has white background.

I checked the https://invent.kde.org/graphics/okular/-/merge_requests/440 but
saw that it was closed without explanation/conclusion.

I tried to experiment with the color schemes and finally managed to find the
right balance, but I think the most ideal situation is to either have a
configurable selection color (perhaps the easiest), or similar to kdiff, the
text color gets inverted if there is not enough contrast between the highlight
color and the text color.


In case it matters, here is my system info:
- Okular Version: 23.04.0
- Operating System: Manjaro Linux 
- KDE Plasma Version: 5.27.4
- KDE Frameworks Version: 5.105.0
- Qt Version: 5.15.9
- Kernel Version: 6.1.26-1-MANJARO (64-bit)
- Graphics Platform: X11
- Processors: 20 × Intel® Core™ i9-10900K CPU @ 3.70GHz
- Memory: 31.1 GiB of RAM
- Graphics Processor: AMD Radeon Pro WX 3200 Series

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 370726] Text selection tool highlight unintelligible

[Mehrad Mahmoudian]

https://bugs.kde.org/show_bug.cgi?id=370726

Mehrad Mahmoudian  changed:

   What|Removed |Added

 CC||m.mahmoud...@gmail.com

--- Comment #6 from Mehrad Mahmoudian  ---
Created attachment 159260
  --> https://bugs.kde.org/attachment.cgi?id=159260=edit
The Breath Dark theme's color on a PDF with white background and black text

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 370726] Text selection tool highlight unintelligible

[Xu Zhao]

https://bugs.kde.org/show_bug.cgi?id=370726

--- Comment #5 from Xu Zhao  ---
I submitted a tentative merge request to address this issue:
https://invent.kde.org/graphics/okular/-/merge_requests/440

Maybe someone here could help review it?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 370726] Text selection tool highlight unintelligible

[Xaver]

https://bugs.kde.org/show_bug.cgi?id=370726

Xaver  changed:

   What|Removed |Added

 CC||emailic...@gmail.com

--- Comment #4 from Xaver  ---
>Using the selection text color from the theme would definitely work, but might 
>look ugly, like we're mangling the presentation of the document. Maybe instead 
>when the text is dark, we could impose a certain amount of lightness on the 
>selection background, to ensure that it's always readable.

Well, with a dark selection color it's not just ugly but partly to completely
unreadable.
Perhaps making the selection color transparent with the background could ensure
a certain contrast while still retaining the original text color though?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 370726] Text selection tool highlight unintelligible

[Xu Zhao]

https://bugs.kde.org/show_bug.cgi?id=370726

--- Comment #3 from Xu Zhao  ---
The problem persists on Okular 1.9.3. Any progress on this issue?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 370726] Text selection tool highlight unintelligible

[Xu Zhao]

https://bugs.kde.org/show_bug.cgi?id=370726

Xu Zhao  changed:

   What|Removed |Added

 CC||i...@xuzhao.net

--- Comment #2 from Xu Zhao  ---
Can confirm this on Okular 1.9.0. Any progress on this bug?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 370726] Text selection tool highlight unintelligible

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=370726

Nate Graham  changed:

   What|Removed |Added

 CC||pointedst...@zoho.com
 Status|UNCONFIRMED |CONFIRMED
 Ever confirmed|0   |1

--- Comment #1 from Nate Graham  ---
Using the selection text color from the theme would definitely work, but might
look ugly, like we're mangling the presentation of the document. Maybe instead
when the text is dark, we could impose a certain amount of lightness on the
selection background, to ensure that it's always readable.

-- 
You are receiving this mail because:
You are the assignee for the bug.