[okular] [Bug 384267] Found text (ctrl-f) highlight color should use System Settings "selection background" color, not be hard-coded yellow

[Luca Manganelli]

https://bugs.kde.org/show_bug.cgi?id=384267

Luca Manganelli  changed:

   What|Removed |Added

 CC||luc...@gmail.com

--- Comment #19 from Luca Manganelli  ---
Please fix this bug. This is an accessibility issue to me (I cannot see much
difference from white and yellow for my eye problem)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 384267] Found text (ctrl-f) highlight color should use System Settings "selection background" color, not be hard-coded yellow

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=384267

acryl...@gmail.com changed:

   What|Removed |Added

 CC||acryl...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 384267] Found text (ctrl-f) highlight color should use System Settings "selection background" color, not be hard-coded yellow

[Paul Preney]

https://bugs.kde.org/show_bug.cgi?id=384267

--- Comment #18 from Paul Preney  ---
I missed mentioning I am using Okular v21.08.1 --but all past versions also
have these issues.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 384267] Found text (ctrl-f) highlight color should use System Settings "selection background" color, not be hard-coded yellow

[Paul Preney]

https://bugs.kde.org/show_bug.cgi?id=384267

Paul Preney  changed:

   What|Removed |Added

 CC||p...@preney.ca

--- Comment #17 from Paul Preney  ---
I also have issues with this. 

I run with KDE Night Mode enabled (i.e., the screen is significantly shifted
towards yellow/orange). This causes yellow highlights to become essentially
invisible (or very hard to to see) on the page. Also I regularly search PDFs
with lots of small text and it can be hard (even without Night Mode on) to
easily find bright-yellow on the page. More contrast to improve visibility is
needed with Ctrl-F highlighting.

ASIDE: Yellow is a great highlight colour when NOT using Night Mode, colour
inversion, large text, and/or reviewing using yellow --otherwise it is the
worst (as implemented in okular since Night Mode renders it essentially
invisible, inversion makes it unseen-black and viewing using yellow essentially
makes it unseen if the two overlap).

Choosing any of the Accessibility settings does not work since none of these
changes the highlight to something noticeable/contrasting. In most situations
those settings the Ctrl-F hard-coded yellow background becomes invisible (i.e.,
essentially black if inverting colours) and although the letters highlighted
are a slightly brighter/bolder yellow but such is not easy to see with Night
Mode off (and essentially impossible to see with it on).

I would like to ask that the Ctrl-F highlight be configurable as follows:
  * Status quo: Default to what currently happens.
  * Allow the user under Accessibility to choose a some sort of "High contrast
invert" for Ctrl-F matches.

The high contrast invert would completely invert what is underneath the Ctrl-F
highlight box. Sure if the area underneath is 50% gray the inversion would be
~50% gray, i.e., useless, but Ctrl-F matches text and virtually all PDF pages
have significant contrast between text and what is underneath the text so that
a colour inversion should be very visible. Most documents though, the inversion
would make Ctrl-F finds white letter with a black background.

It would also be ideal to make user-customizable the colour of the border of
the box that surrounds the Ctrl-F yellow highlight. The current colour "black"
is useless: it blends in to the page's text (i.e., it doesn't draw the user's
attention to the found text) and if Accessibility's invert colour (etc.) is
chosen it becomes invisible, etc.

Currently there are times when the only way I can see where a match is on a
page is to turn off Night Mode completely --and even then I have to look
carefully because most PDFs I look at have a lot of small text in them --the
yellow is too subtle a colour for such to stand out easily.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 384267] Found text (ctrl-f) highlight color should use System Settings "selection background" color, not be hard-coded yellow

[David Hurka]

https://bugs.kde.org/show_bug.cgi?id=384267

David Hurka  changed:

   What|Removed |Added

   See Also||https://bugs.kde.org/show_b
   ||ug.cgi?id=429796

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 384267] Found text (ctrl-f) highlight color should use System Settings "selection background" color, not be hard-coded yellow

[SarenT]

https://bugs.kde.org/show_bug.cgi?id=384267

SarenT  changed:

   What|Removed |Added

 CC||sarentasci...@hotmail.com

--- Comment #16 from SarenT  ---
I am also affected by this problem. Yellow is a very effective highlight color,
which makes search results unnoticeable. I would like to suggest that
application contains 2 settings:
1: whether to use system default
2: if not then which color (color chooser). This should be relatively simple to
implement.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 384267] Found text (ctrl-f) highlight color should use System Settings "selection background" color, not be hard-coded yellow

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=384267

Nate Graham  changed:

   What|Removed |Added

   See Also||https://bugs.kde.org/show_b
   ||ug.cgi?id=416703

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 384267] Found text (ctrl-f) highlight color should use System Settings "selection background" color, not be hard-coded yellow

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=384267

--- Comment #15 from Albert Astals Cid  ---
(In reply to David Hurka from comment #14)
> No my problem with Okular is different to yours. Text selection (using Text
> Selection mode) makes text invisible, because PDFs use black text. I need to
> change the Selection Background color locally in Okular, while I am
> relatively ok with yellow for Ctrl+F searching. Does this need another bug
> report?

Since this is about "search color" and your issues not with "search color", yes
i would suggest you open a new bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 384267] Found text (ctrl-f) highlight color should use System Settings "selection background" color, not be hard-coded yellow

[David Hurka]

https://bugs.kde.org/show_bug.cgi?id=384267

--- Comment #14 from David Hurka  ---
(In reply to Albert Astals Cid from comment #1)
> No, that solution doesn't work, because people that use dark themes (where
> selection is usually a white-ish color) would not see the selection when
> reading PDFs (that usually have a white background).

(In reply to Frank Myhr from comment #2)
> Perhaps someone who uses dark themes can chime in...

I use dark themes. All themes available in System Settings use blue or light
blue for Selection Background, but I always change it to brown or purple, so it
does not glare and the white text is still easily readable. (In many places,
the Selection Background is used permanently, so it has potential to glare.)

No my problem with Okular is different to yours. Text selection (using Text
Selection mode) makes text invisible, because PDFs use black text. I need to
change the Selection Background color locally in Okular, while I am relatively
ok with yellow for Ctrl+F searching. Does this need another bug report?

Although there is no color sheme entry for Search Highlight Background, I
suggest adding these options:
Configure -> General -> Appearance:
[_] Use custom background color [KColorButton] (already there)
[x] Use custom text selection color [KColorButton]
[_] Use custom search highlight color [KColorButton]

I already suggested to add another KColorButton to the Ctrl+F search bar,
right?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 384267] Found text (ctrl-f) highlight color should use System Settings "selection background" color, not be hard-coded yellow

[Tn]

https://bugs.kde.org/show_bug.cgi?id=384267

Tn  changed:

   What|Removed |Added

 OS|Linux   |All
Version|1.0.0   |1.3.2
   Platform|Ubuntu Packages |unspecified

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 384267] Found text (ctrl-f) highlight color should use System Settings "selection background" color, not be hard-coded yellow

[Tn]

https://bugs.kde.org/show_bug.cgi?id=384267

Tn  changed:

   What|Removed |Added

 CC||whyeven3...@outlook.com

--- Comment #13 from Tn  ---
I just want to echo this report as it affects my usage too. In order to improve
my ability to sleep, I use redshift to reduce the colour temperature of my
screen and tinted glasses to filter out blue light. The yellow highlight colour
will easily get lost once I've gone below a certain temperature threshold and
so, the ability to change the highlight colour for the search and find function
would be greatly beneficial to users like myself.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 384267] Found text (ctrl-f) highlight color should use System Settings "selection background" color, not be hard-coded yellow

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=384267

--- Comment #12 from Nate Graham  ---
Ah, thanks Albert. Changed.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 384267] Found text (ctrl-f) highlight color should use System Settings "selection background" color, not be hard-coded yellow

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=384267

--- Comment #11 from Albert Astals Cid  ---
I don't think that's going to work, i'm 92.46% sure that BUG: needs to be at
the beginning of the line at alone, not in a sentence like you wrote it.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 384267] Found text (ctrl-f) highlight color should use System Settings "selection background" color, not be hard-coded yellow

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=384267

Nate Graham  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|UNCONFIRMED |CONFIRMED

--- Comment #10 from Nate Graham  ---
Thanks! I've slightly edited the summary to include "BUG: 384267" which will
automatically close this bug report once the patch is committed.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 384267] Found text (ctrl-f) highlight color should use System Settings "selection background" color, not be hard-coded yellow

[Oliver Sander]

https://bugs.kde.org/show_bug.cgi?id=384267

--- Comment #9 from Oliver Sander  ---
https://phabricator.kde.org/D7662

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 384267] Found text (ctrl-f) highlight color should use System Settings "selection background" color, not be hard-coded yellow

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=384267

--- Comment #8 from Nate Graham  ---
Reviewboard is going away soon. Can you upload your to our Phabricator
instance?

https://phabricator.kde.org

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 384267] Found text (ctrl-f) highlight color should use System Settings "selection background" color, not be hard-coded yellow

[Oliver Sander]

https://bugs.kde.org/show_bug.cgi?id=384267

--- Comment #7 from Oliver Sander  ---
No need for KColorUtils, QColor has 'darken' natively.  Feel free to play with
the parameter.

Patch is at

  https://git.reviewboard.kde.org/r/130238/

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 384267] Found text (ctrl-f) highlight color should use System Settings "selection background" color, not be hard-coded yellow

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=384267

Nate Graham  changed:

   What|Removed |Added

 CC||pointedst...@zoho.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 384267] Found text (ctrl-f) highlight color should use System Settings "selection background" color, not be hard-coded yellow

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=384267

--- Comment #6 from Albert Astals Cid  ---
(In reply to Oliver Sander from comment #4)
> True, I was going to send a patch for that.  Adding the border is now simply
> 
> diff --git a/ui/pagepainter.cpp b/ui/pagepainter.cpp
> index 047220f95..94429af93 100644
> --- a/ui/pagepainter.cpp
> +++ b/ui/pagepainter.cpp
> @@ -385,6 +385,8 @@ void PagePainter::paintCroppedPageOnPainter( QPainter *
> destPainter, const Okula
>  QPainter painter();
> 
> painter.setCompositionMode(QPainter::CompositionMode_Multiply);
>  painter.fillRect(highlightRect, highlightColor);
> +painter.setPen(Qt::black);
> +painter.drawRect(highlightRect);
>  }
>  }
>  // 4B.4. paint annotations [COMPOSITED ONES]
> 
> I am not convinced that hard-wiring Qt::black is a good idea.  What is a
> good color?

Maybe try KColorUtils::darken ?
https://api.kde.org/frameworks/kguiaddons/html/namespaceKColorUtils.html#a11e97bbb394b7e619163c2cc6b9a513a

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 384267] Found text (ctrl-f) highlight color should use System Settings "selection background" color, not be hard-coded yellow

[Frank Myhr]

https://bugs.kde.org/show_bug.cgi?id=384267

--- Comment #5 from Frank Myhr  ---
@Oliver Sander:
Cool patch!
I agree, color selection is now seeming more complicated than it first
appeared. I began wondering about a dotted- or dashed-line border with, say,
alternating dark and light pixels. But that seems unnecessarily complex to
implement. What about using *2* rectangles, one just slightly bigger than the
other, one in a dark and the other in a light color? Or even *4* rectangles in
alternating dark and light colors? It seems THAT would be pretty easy to see as
(at minimum) a double-box no matter what the theme and document colors in
use...

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 384267] Found text (ctrl-f) highlight color should use System Settings "selection background" color, not be hard-coded yellow

[Oliver Sander]

https://bugs.kde.org/show_bug.cgi?id=384267

Oliver Sander  changed:

   What|Removed |Added

 CC||oliver.san...@tu-dresden.de

--- Comment #4 from Oliver Sander  ---
True, I was going to send a patch for that.  Adding the border is now simply

diff --git a/ui/pagepainter.cpp b/ui/pagepainter.cpp
index 047220f95..94429af93 100644
--- a/ui/pagepainter.cpp
+++ b/ui/pagepainter.cpp
@@ -385,6 +385,8 @@ void PagePainter::paintCroppedPageOnPainter( QPainter *
destPainter, const Okula
 QPainter painter();

painter.setCompositionMode(QPainter::CompositionMode_Multiply);
 painter.fillRect(highlightRect, highlightColor);
+painter.setPen(Qt::black);
+painter.drawRect(highlightRect);
 }
 }
 // 4B.4. paint annotations [COMPOSITED ONES]

I am not convinced that hard-wiring Qt::black is a good idea.  What is a good
color?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 384267] Found text (ctrl-f) highlight color should use System Settings "selection background" color, not be hard-coded yellow

[Frank Myhr]

https://bugs.kde.org/show_bug.cgi?id=384267

--- Comment #2 from Frank Myhr  ---
@Albert Astals Cid:
You're right, I didn't think of that as I don't personally use dark themes.

Hmm... how about using system Selection Background color for the found text
highlight, and its inverse color to draw a box around this highlight. And an
option to invert these colors in case that works better with the theme in use?

Perhaps someone who uses dark themes can chime in...

Thanks,
Frank

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 384267] Found text (ctrl-f) highlight color should use System Settings "selection background" color, not be hard-coded yellow

[Albert Astals Cid]

https://bugs.kde.org/show_bug.cgi?id=384267

Albert Astals Cid  changed:

   What|Removed |Added

 CC||aa...@kde.org
   Severity|normal  |wishlist

--- Comment #1 from Albert Astals Cid  ---
No, that solution doesn't work, because people that use dark themes (where
selection is usually a white-ish color) would not see the selection when
reading PDFs (that usually have a white background).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 384267] Found text (ctrl-f) highlight color should use System Settings "selection background" color, not be hard-coded yellow

[Frank Myhr]

https://bugs.kde.org/show_bug.cgi?id=384267

Frank Myhr  changed:

   What|Removed |Added

 CC||fm...@fhmtech.com

-- 
You are receiving this mail because:
You are the assignee for the bug.