[okular] [Bug 402756] Highlight annotation should inherit visual style (e.g. rounded vs square) from widget theme

2019-01-15 Thread avlas
https://bugs.kde.org/show_bug.cgi?id=402756

avlas  changed:

   What|Removed |Added

 Resolution|--- |UPSTREAM
 Status|REPORTED|RESOLVED

--- Comment #8 from avlas  ---
> Only that this is not a selection, this is an highlight annotation, widget
> styles don't have the concept of "highlight annotation", so no this has
> nothing to do with "The visual style".
> 
> On top of that what you're seeing is not rendered by Okular but by Poppler,
> the ones rendered by Okular (i.e. non pdf file highlights) have square
> corners.

I see. Good to know. Thanks!

> I'd sincerely close this bug as NOT A BUG

I'd disagree. I think closing as UPSTREAM would be more appropriate then... (I
may consider reporting it to Poppler, will see).

I'm doing it myself. Change it if you feel it is not proper.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 402756] Highlight annotation should inherit visual style (e.g. rounded vs square) from widget theme

2019-01-15 Thread Albert Astals Cid
https://bugs.kde.org/show_bug.cgi?id=402756

Albert Astals Cid  changed:

   What|Removed |Added

 CC||aa...@kde.org

--- Comment #7 from Albert Astals Cid  ---
(In reply to Nate Graham from comment #5)
> Yeah, I think this is fine personally. But I do think it would be a sensible
> change to inherit the selection style from the widget theme. That way themes
> with square selection highlights (like Breeze) would give you what you want.

Only that this is not a selection, this is an highlight annotation, widget
styles don't have the concept of "highlight annotation", so no this has nothing
to do with "The visual style".

On top of that what you're seeing is not rendered by Okular but by Poppler, the
ones rendered by Okular (i.e. non pdf file highlights) have square corners.

I'd sincerely close this bug as NOT A BUG

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 402756] Highlight annotation should inherit visual style (e.g. rounded vs square) from widget theme

2019-01-15 Thread avlas
https://bugs.kde.org/show_bug.cgi?id=402756

--- Comment #6 from avlas  ---
(In reply to Nate Graham from comment #5)
> Yeah, I think this is fine personally. But I do think it would be a sensible
> change to inherit the selection style from the widget theme. That way themes
> with square selection highlights (like Breeze) would give you what you want.

That would be great!

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 402756] Highlight annotation should inherit visual style (e.g. rounded vs square) from widget theme

2019-01-15 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=402756

Nate Graham  changed:

   What|Removed |Added

 Status|NEEDSINFO   |REPORTED
 Resolution|WAITINGFORINFO  |---
Summary|Highlight rounded style |Highlight annotation should
   |looks archaic   |inherit visual style (e.g.
   ||rounded vs square) from
   ||widget theme

--- Comment #5 from Nate Graham  ---
Yeah, I think this is fine personally. But I do think it would be a sensible
change to inherit the selection style from the widget theme. That way themes
with square selection highlights (like Breeze) would give you what you want.

-- 
You are receiving this mail because:
You are the assignee for the bug.