[okular] [Bug 420755] Animated scroll transitions should respect global animation speed

2020-09-14 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=420755

Nate Graham  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

--- Comment #18 from Nate Graham  ---
Re-opening since after discussion, this will require a setting in Okular's own
UI for people not using it in Plasma.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 420755] Animated scroll transitions should respect global animation speed

2020-09-14 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=420755

Nate Graham  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/grap
   ||hics/okular/commit/2d6fafe2
   ||5505b0f7a521cd867f41063f0ea
   ||73c5d
   Version Fixed In||1.12.0
 Status|CONFIRMED   |RESOLVED

--- Comment #17 from Nate Graham  ---
Git commit 2d6fafe25505b0f7a521cd867f41063f0ea73c5d by Nate Graham.
Committed on 14/09/2020 at 17:02.
Pushed by ngraham into branch 'master'.

Scale smooth scroll durations according to the global animation speed

Now people who don't like animations can set thenm to "Instant" globally
and smooth scrolling will be effectively disabled off in Okular.

There is no change in speed for people using the default global
animation duration.
FIXED-IN: 1.12.0

M  +7-0ui/pageview.cpp

https://invent.kde.org/graphics/okular/commit/2d6fafe25505b0f7a521cd867f41063f0ea73c5d

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 420755] Animated scroll transitions should respect global animation speed

2020-07-31 Thread Densetsu no Ero-sennin
https://bugs.kde.org/show_bug.cgi?id=420755

Densetsu no Ero-sennin  changed:

   What|Removed |Added

 CC||ag+servi...@sologoc.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 420755] Animated scroll transitions should respect global animation speed

2020-07-02 Thread Till Schäfer
https://bugs.kde.org/show_bug.cgi?id=420755

--- Comment #16 from Till Schäfer  ---
(In reply to Florent Rougon from comment #15)
> I fully agree with comment #14. I love Okular, but having Page Up and Page
> Down take so much time is absolutely terrible. One can't reasonably browse
> through a largish PDF file anymore. Please restore quick Page Up and Page
> Down behavior. The animation I see in Okular 1.10.2 is a big usability
> regression for useless eye candy; that is a pretty bad tradeoff, IMHO. Thank
> you very much for all the great work (yes, all the rest! :-).

+1 
I would further stress, that the global animation speed is not good choice for
the current implementation. Page Up/Down repeat rate should is not limited by
the animation speed. This overrides the keyboard repeat rate, which is quite
counter intuitive. Furthermore, it ignores some user input during the animation
(e.g., a second key press) because the animation is not finished. This is
rather disruptive. It makes you wait for the animation, you cant trust your
intuition of fast input anymore. To make this more clear: imagine blocking a
second alt+tab window switching because the animation is not finished...

Thus, I think the implementation should respect the following things:
- Animation should never block user input
- Animation should not limit scroll speed. 
- If animation is applied it should always animate to the scroll position where
you would have been without any animation and without resource limitations
(e.g. processor power to render the page). Thus, it is much more sensible to
speak of animation time, rather than speed. The animated scroll speed should be
faster if your press Page Up/Down multiple times to catch up to the desired
scroll position. Currently this is vise versa.  
- Make it optional: Making an animation optional is not an unusual thing in
KDE/Plasma. For example, the desktop effects can be enabled/disabled
separately. While I usually like some animations, because they can actually
increase the visual perception of what is happening, they should never stand in
the way and hinder productivity. I would further not like to adjust the
otherwise useful global animation speed to get rid of an annoyance in a
specific application.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 420755] Animated scroll transitions should respect global animation speed

2020-07-02 Thread Florent Rougon
https://bugs.kde.org/show_bug.cgi?id=420755

Florent Rougon  changed:

   What|Removed |Added

 CC||f.rou...@free.fr

--- Comment #15 from Florent Rougon  ---
I fully agree with comment #14. I love Okular, but having Page Up and Page Down
take so much time is absolutely terrible. One can't reasonably browse through a
largish PDF file anymore. Please restore quick Page Up and Page Down behavior.
The animation I see in Okular 1.10.2 is a big usability regression for useless
eye candy; that is a pretty bad tradeoff, IMHO. Thank you very much for all the
great work (yes, all the rest! :-).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 420755] Animated scroll transitions should respect global animation speed

2020-06-16 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=420755

--- Comment #14 from nfx...@gmail.com ---
In addition, this new behavior seems to make the page up/page down keys scroll
VERY slowly and VERy annoyingly (animated scroll down for half a second, full
stop for half a second, repeat).

This is absolutely unusable.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 420755] Animated scroll transitions should respect global animation speed

2020-06-08 Thread David Hurka
https://bugs.kde.org/show_bug.cgi?id=420755

David Hurka  changed:

   What|Removed |Added

   See Also||https://bugs.kde.org/show_b
   ||ug.cgi?id=422629

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 420755] Animated scroll transitions should respect global animation speed

2020-05-29 Thread Denis Lisov
https://bugs.kde.org/show_bug.cgi?id=420755

Denis Lisov  changed:

   What|Removed |Added

 CC||dennis.lis...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 420755] Animated scroll transitions should respect global animation speed

2020-05-25 Thread Tristan Miller
https://bugs.kde.org/show_bug.cgi?id=420755

Tristan Miller  changed:

   What|Removed |Added

 CC||psychon...@nothingisreal.co
   ||m

--- Comment #13 from Tristan Miller  ---
Another important reason to provide a mechanism for disabling this new feature:
the scrolling animation makes Okular all but unusable when running remotely
over a slow Internet connection.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 420755] Animated scroll transitions should respect global animation speed

2020-05-05 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=420755

--- Comment #12 from nfx...@gmail.com ---
Christoph Loy: I don't know. My bug was closed as duplicate of this, and it
wasn't about any links at all.

gwarser: Judging from the closing of my bug report, what you suggest is part of
this bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 420755] Animated scroll transitions should respect global animation speed

2020-05-05 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=420755

--- Comment #11 from gwar...@gmail.com ---
Should I create new bug if I want to disable inertial scrolling after scroll by
mouse dragging? I should note that it seems to "explode" sometimes - happened
to me once, after dragging, 50-page document was very fast scrolled to the end.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 420755] Animated scroll transitions should respect global animation speed

2020-05-05 Thread Christoph Loy
https://bugs.kde.org/show_bug.cgi?id=420755

--- Comment #10 from Christoph Loy  ---
(In reply to nfxjfg from comment #9)
> If this was introduced for touchpad use, you should really reconsider the
> impact on normal desktop users. I'm not sure if you can detect touchpad use,
> but if you can, disabling this by default for mouse/keyboard would be a
> sensible thing to do.

I am not really sure what clicking on links has to do with using a touchpad or
a mouse...

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 420755] Animated scroll transitions should respect global animation speed

2020-05-05 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=420755

--- Comment #9 from nfx...@gmail.com ---
If this was introduced for touchpad use, you should really reconsider the
impact on normal desktop users. I'm not sure if you can detect touchpad use,
but if you can, disabling this by default for mouse/keyboard would be a
sensible thing to do.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 420755] Animated scroll transitions should respect global animation speed

2020-05-05 Thread David Hurka
https://bugs.kde.org/show_bug.cgi?id=420755

David Hurka  changed:

   What|Removed |Added

 CC||nfx...@gmail.com

--- Comment #8 from David Hurka  ---
*** Bug 421039 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 420755] Animated scroll transitions should respect global animation speed

2020-05-03 Thread bugzilla_noreply
https://bugs.kde.org/show_bug.cgi?id=420755

gwar...@gmail.com changed:

   What|Removed |Added

 CC||gwar...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 420755] Animated scroll transitions should respect global animation speed

2020-05-02 Thread David Hurka
https://bugs.kde.org/show_bug.cgi?id=420755

--- Comment #7 from David Hurka  ---
(In reply to Christoph Loy from comment #6)
> For KDE users, I agree, a global setting would be perfect. But what would
> that mean for a windows user like me?

I don’t know, but you will probably not be able to configure it. It will
probably depend on the style you use (Aero or Classic).

(In reply to Nate Graham from comment #5)
> Nitpick: you're not objecting to smooth scrolling (which refers to
> pixel-by-pixel touchpad scrolling) but rather animated scroll transitions
> when using a mouse wheel or keyboard navigation. Re-titling appropriately.

Sounds like you expect that smooth scroll transitions (mouse wheel step / arrow
key) and smooth scroll transitions (clicking a navigation link) will use the
same code soon.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 420755] Animated scroll transitions should respect global animation speed

2020-05-02 Thread Christoph Loy
https://bugs.kde.org/show_bug.cgi?id=420755

--- Comment #6 from Christoph Loy  ---
First, thanks for fixing up my bug report.

For KDE users, I agree, a global setting would be perfect. But what would that
mean for a windows user like me? I totally do understand that windows is
probably not your number one priority, but I'd still be interested how a
solution for windows would look like.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[okular] [Bug 420755] Animated scroll transitions should respect global animation speed

2020-05-01 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=420755

Nate Graham  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 CC||n...@kde.org
 Status|REPORTED|CONFIRMED
Summary|Smooth scrolling cannot be  |Animated scroll transitions
   |disabled by the user|should respect global
   ||animation speed

--- Comment #5 from Nate Graham  ---
Nitpick: you're not objecting to smooth scrolling (which refers to
pixel-by-pixel touchpad scrolling) but rather animated scroll transitions when
using a mouse wheel or keyboard navigation. Re-titling appropriately.

Also note that animated scroll transitions for wheel scrolling were reverted in
Okular 1.10.1 to fix some regressions encountered by people with free-wheeling
scroll wheels.

Finally, I agree with David H that Okular could respect the global setting for
animation duration here, turning off animated scroll transitions entirely when
the user has disabled all animations. I don't think it makes sense to add an
option only in Okular though. That seems like over-configuration.

-- 
You are receiving this mail because:
You are the assignee for the bug.