D12352: Make it possible to disable the build of okularkirigami
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R223:1fb77446a737: Make it possible to disable the build of okularkirigami (authored by apol). REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12352?vs=32616&id=32842 REVISION DETAIL https://phabricator.kde.org/D12352 AFFECTED FILES CMakeLists.txt mobile/app/package/contents/ui/Documents.qml To: apol, #okular, mart, aacid, lbeltrame Cc: ngraham, aacid
D12352: Make it possible to disable the build of okularkirigami
lbeltrame added inline comments.
INLINE COMMENTS
> Documents.qml:56
> }
> -text: i18n("No Documents found. To start to read, put some files in
> the Documents folder of your device.")
> -wrapMode: Text.WordWrap
> -horizontalAlignment: Text.AlignHCenter
> -verticalAlignment: Text.AlignVCenter
> +Kirigami.Label {
> +text: i18n("No Documents found. To start to read, put some files
> in the Documents folder of your device.")
This, and all the changes in Document.qml are unrelated.
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D12352
To: apol, #okular, mart, aacid, lbeltrame
Cc: ngraham, aacid
D12352: Make it possible to disable the build of okularkirigami
apol updated this revision to Diff 32616. apol added a comment. Improve description REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12352?vs=32569&id=32616 BRANCH master REVISION DETAIL https://phabricator.kde.org/D12352 AFFECTED FILES CMakeLists.txt mobile/app/package/contents/ui/Documents.qml To: apol, #okular, mart, aacid, lbeltrame Cc: ngraham, aacid
D12352: Make it possible to disable the build of okularkirigami
lbeltrame added inline comments. INLINE COMMENTS > CMakeLists.txt:127 > > -add_subdirectory( mobile ) > +option(BUILD_OKULARKIRIGAMI "Builds the convergent application" ON) > +if (BUILD_OKULARKIRIGAMI) Doesn't specify much about what a "convergent" application is (unless it's specified elsewhere). Perhaps "Builds a Kirigami-based, convergent version of Okular"? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D12352 To: apol, #okular, mart, aacid, lbeltrame Cc: ngraham, aacid
D12352: Make it possible to disable the build of okularkirigami
apol created this revision. apol added reviewers: Okular, mart, aacid, lbeltrame. Restricted Application added a project: Okular. apol requested review of this revision. REVISION SUMMARY Some distros seem to have the option. BUG: 393119 TEST PLAN Still builds, can disable build REPOSITORY R223 Okular BRANCH master REVISION DETAIL https://phabricator.kde.org/D12352 AFFECTED FILES CMakeLists.txt To: apol, #okular, mart, aacid, lbeltrame Cc: ngraham, aacid
