D14102: Add share action to selection context menu

[Nicolas Fella]

nicolasfella abandoned this revision.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D14102

To: nicolasfella, #okular, aacid, apol
Cc: ngraham, okular-devel, johnzh, andisa, siddharthmanthan, maguirre, 
fbampaloukas, joaonetto, kezik, darcyshen, aacid

D14102: Add share action to selection context menu

[Nathaniel Graham]

ngraham added a comment.


  Why so we do!

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D14102

To: nicolasfella, #okular, aacid, apol
Cc: ngraham, okular-devel, fbampaloukas, joaonetto, tfella, darcyshen, aacid

D14102: Add share action to selection context menu

[Albert Astals Cid]

aacid added a comment.


  In D14102#484368 , @ngraham wrote:
  
  > Yeah I'm not sure how much sense it makes to have this in the selection 
context menu. I could see it making sense in the File menu though, where it 
would operate on the active file.
  
  
  The awesome thing about that is that Limux paid for that, so we already have 
it :)

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D14102

To: nicolasfella, #okular, aacid, apol
Cc: ngraham, okular-devel, fbampaloukas, joaonetto, tfella, darcyshen, aacid

D14102: Add share action to selection context menu

[Nathaniel Graham]

ngraham added a comment.


  Yeah I'm not sure how much sense it makes to have this in the selection 
context menu. I could see it making sense in the File menu though, where it 
would operate on the active file.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D14102

To: nicolasfella, #okular, aacid, apol
Cc: ngraham, okular-devel, fbampaloukas, joaonetto, tfella, darcyshen, aacid

D14102: Add share action to selection context menu

[Albert Astals Cid]

aacid requested changes to this revision.
This revision now requires changes to proceed.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D14102

To: nicolasfella, #okular, aacid, apol
Cc: ngraham, okular-devel, fbampaloukas, joaonetto, tfella, darcyshen, aacid

D14102: Add share action to selection context menu

[Albert Astals Cid]

aacid added a comment.


  I personally don't think this makes much sense, but I'm not a heavy Okular 
user either.
  
  In D14102#293160 , @apol wrote:
  
  > I'd say it would make sense to just make it possible to drag and drop this 
to the quick share plasmoid. Or just put it on the clipboard and paste it there.
  
  
  You can't drag the selection goes away once the menu goes away.

INLINE COMMENTS

> pageview.cpp:2851
> +connect(d->m_shareMenu, ::triggered, this, [this, 
> selectionRect, sharedFileName] {
> +// renders page into a pixmap and saves it
> +QPixmap copyPix( selectionRect.width(), 
> selectionRect.height() );

Don't duplicate code that is just 3 lines below, reuse!

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D14102

To: nicolasfella, #okular, aacid, apol
Cc: ngraham, okular-devel, aacid

D14102: Add share action to selection context menu

[Aleix Pol Gonzalez]

apol added a comment.


  I'd say it would make sense to just make it possible to drag and drop this to 
the quick share plasmoid. Or just put it on the clipboard and paste it there.

INLINE COMMENTS

> pageview.cpp:60
>  #include 
> +#include 
> +#include 

Purpose is already used in other parts of Okular and it's ifdef'd there.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D14102

To: nicolasfella, #okular, aacid, apol
Cc: ngraham, okular-devel, aacid

D14102: Add share action to selection context menu

[Nicolas Fella]

nicolasfella edited the test plan for this revision.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D14102

To: nicolasfella, #okular, aacid, apol
Cc: okular-devel, ngraham, aacid

D14102: Add share action to selection context menu

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added reviewers: Okular, aacid, apol.
Restricted Application added a project: Okular.
Restricted Application added a subscriber: okular-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  Enable sharing a selection via Purpose.

REPOSITORY
  R223 Okular

BRANCH
  share

REVISION DETAIL
  https://phabricator.kde.org/D14102

AFFECTED FILES
  ui/pageview.cpp

To: nicolasfella, #okular, aacid, apol
Cc: okular-devel, ngraham, aacid