D18397: Fix crash on canceling the file open dialog

2019-02-04 Thread Volker Krause 
This revision was automatically updated to reflect the committed changes.
Closed by commit R223:dfe6f26c6af8: Fix crash on canceling the file open dialog 
(authored by vkrause).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D18397?vs=50371&id=50866#toc

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18397?vs=50371&id=50866

REVISION DETAIL
  https://phabricator.kde.org/D18397

AFFECTED FILES
  mobile/android/src/OpenFileActivity.java

To: vkrause, apol, nicolasfella, aacid
Cc: apol, nicolasfella, okular-devel, tfella, ngraham, darcyshen, aacid

D18397: Fix crash on canceling the file open dialog

2019-02-02 Thread Albert Astals Cid 
aacid accepted this revision.

REPOSITORY
  R223 Okular

BRANCH
  arcpatch-D18397

REVISION DETAIL
  https://phabricator.kde.org/D18397

To: vkrause, apol, nicolasfella, aacid
Cc: apol, nicolasfella, okular-devel, tfella, ngraham, darcyshen, aacid

D18397: Fix crash on canceling the file open dialog

2019-01-27 Thread Nicolas Fella 
nicolasfella accepted this revision.

REPOSITORY
  R223 Okular

BRANCH
  arcpatch-D18397

REVISION DETAIL
  https://phabricator.kde.org/D18397

To: vkrause, apol, nicolasfella
Cc: apol, nicolasfella, okular-devel, tfella, ngraham, darcyshen, aacid

D18397: Fix crash on canceling the file open dialog

2019-01-27 Thread Volker Krause 
vkrause updated this revision to Diff 50371.
vkrause added a comment.


  Check result code as suggested by Nico.

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18397?vs=49903&id=50371

BRANCH
  arcpatch-D18397

REVISION DETAIL
  https://phabricator.kde.org/D18397

AFFECTED FILES
  mobile/android/src/OpenFileActivity.java

To: vkrause, apol
Cc: apol, nicolasfella, okular-devel, tfella, ngraham, darcyshen, aacid

D18397: Fix crash on canceling the file open dialog

2019-01-26 Thread Aleix Pol Gonzalez 
apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R223 Okular

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18397

To: vkrause, apol
Cc: apol, nicolasfella, okular-devel, tfella, ngraham, darcyshen, aacid

D18397: Fix crash on canceling the file open dialog

2019-01-19 Thread Albert Astals Cid 
aacid added a subscriber: apol.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D18397

To: vkrause
Cc: apol, nicolasfella, okular-devel, tfella, ngraham, darcyshen, aacid

D18397: Fix crash on canceling the file open dialog

2019-01-19 Thread Nicolas Fella 
nicolasfella added a comment.


  I think the "proper" thing to do would be to check whether the resultCode is 
Activity.RESULT_OK or Activity.RESULT_CANCELED

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D18397

To: vkrause
Cc: nicolasfella, okular-devel, tfella, ngraham, darcyshen, aacid

D18397: Fix crash on canceling the file open dialog

2019-01-19 Thread Volker Krause 
vkrause created this revision.
Herald added a project: Okular.
Herald added a subscriber: okular-devel.
vkrause requested review of this revision.

REPOSITORY
  R223 Okular

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18397

AFFECTED FILES
  mobile/android/src/OpenFileActivity.java

To: vkrause
Cc: okular-devel, tfella, ngraham, darcyshen, aacid