D9043: Use a distinct and more appropriate icon for Layers

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: aacid, Okular.
Restricted Application added a project: Okular.

REVISION SUMMARY
  BUG: 387424

TEST PLAN
  Tested in KDE Neon. Before:
  
  After:

REPOSITORY
  R223 Okular

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9043

AFFECTED FILES
  part.cpp

To: ngraham, aacid, #okular
Cc: gassaf, ngraham, aacid

D9043: Use a distinct and more appropriate icon for Layers

[Nathaniel Graham]

ngraham edited the test plan for this revision.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D9043

To: ngraham, aacid, #okular
Cc: gassaf, ngraham, aacid

D9043: Use a distinct and more appropriate icon for Layers

[Albert Astals Cid]

aacid added a comment.


  dialog-layers seems to be breeze only, which is not very good for people not 
using breeze :/

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D9043

To: ngraham, aacid, #okular
Cc: gassaf, ngraham, aacid

D9043: Use a distinct and more appropriate icon for Layers

[Nathaniel Graham]

ngraham added a comment.


  Darn. Can you think of a more universal icon that has an Oxygen equivalent?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D9043

To: ngraham, aacid, #okular
Cc: gassaf, ngraham, aacid

D9043: Use a distinct and more appropriate icon for Layers

[Albert Astals Cid]

aacid added a comment.


  I didn't find anything back when we added this feature, worst case scenario 
one could copy the breeze icon into a okular- name and install it with okular 
but i guess it'd still look somewhat alien in other themes :/
  
  Sadly I don't really have a better solution than the solution we did

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D9043

To: ngraham, aacid, #okular
Cc: gassaf, ngraham, aacid

D9043: Use a distinct and more appropriate icon for Layers

[Henrik Fehlauer]

rkflx added a comment.


  How about `format-list-ordered` or `format-list-unordered`? Those retain at 
least some of the layering semantics.
  
  F5523082: format-list.png 

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D9043

To: ngraham, aacid, #okular
Cc: rkflx, gassaf, ngraham, aacid

D9043: Use a distinct and more appropriate icon for Layers

[Nathaniel Graham]

ngraham edited the test plan for this revision.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D9043

To: ngraham, aacid, #okular
Cc: rkflx, gassaf, ngraham, aacid

D9043: Use a distinct and more appropriate icon for Layers

[Nathaniel Graham]

ngraham added a comment.


  Excellent idea, @rkflx. `format-list-unordered` is much better than what I 
had chosen anyway.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D9043

To: ngraham, aacid, #okular
Cc: rkflx, gassaf, ngraham, aacid

D9043: Use a distinct and more appropriate icon for Layers

[Nathaniel Graham]

ngraham updated this revision to Diff 23284.
ngraham added a comment.


  Instead, use the format-list-unordered icon, which has an Oxygen version and 
is much better anyway

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9043?vs=23112&id=23284

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9043

AFFECTED FILES
  part.cpp

To: ngraham, aacid, #okular
Cc: rkflx, gassaf, ngraham, aacid

D9043: Use a distinct and more appropriate icon for Layers

[Albert Astals Cid]

aacid accepted this revision.
aacid added a comment.
This revision is now accepted and ready to land.


  I guess it's not worse than what we had :D

REPOSITORY
  R223 Okular

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9043

To: ngraham, aacid, #okular
Cc: rkflx, gassaf, ngraham, aacid

D9043: Use a distinct and more appropriate icon for Layers

[Nathaniel Graham]

ngraham closed this revision.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D9043

To: ngraham, aacid, #okular
Cc: rkflx, gassaf, ngraham, aacid

D9043: Use a distinct and more appropriate icon for Layers

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R223:da89a035c1e2: Use a distinct and more appropriate icon 
for Layers (authored by ngraham).

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9043?vs=23284&id=23368

REVISION DETAIL
  https://phabricator.kde.org/D9043

AFFECTED FILES
  part.cpp

To: ngraham, aacid, #okular
Cc: rkflx, gassaf, ngraham, aacid