Re: [Okular-devel] Review Request 109096: Open print dialog from command line
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109096/#review29033 --- This review has been submitted with commit 5ab30aae15ac69e030695b22a008001426e8cdca by Albert Astals Cid on behalf of Tomáš Poledný to branch master. - Commit Hook On March 8, 2013, 8:17 p.m., Tomáš Poledný wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109096/ --- (Updated March 8, 2013, 8:17 p.m.) Review request for Okular. Description --- Added command line options print. Bug 252462 This addresses bug 252462. http://bugs.kde.org/show_bug.cgi?id=252462 Diffs - part.h 2fcdf0a part.cpp 912716a shell/main.cpp 226dab8 shell/shell.cpp 81d63c2 Diff: http://git.reviewboard.kde.org/r/109096/diff/ Testing --- Thanks, Tomáš Poledný ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 109096: Open print dialog from command line
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109096/ --- (Updated March 11, 2013, 9:53 p.m.) Status -- This change has been marked as submitted. Review request for Okular. Description --- Added command line options print. Bug 252462 This addresses bug 252462. http://bugs.kde.org/show_bug.cgi?id=252462 Diffs - part.h 2fcdf0a part.cpp 912716a shell/main.cpp 226dab8 shell/shell.cpp 81d63c2 Diff: http://git.reviewboard.kde.org/r/109096/diff/ Testing --- Thanks, Tomáš Poledný ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 109096: Open print dialog from command line
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109096/ --- (Updated March 8, 2013, 8:17 p.m.) Review request for Okular. Changes --- Fixed problem filethatdoesnotexist.pdf -unique -print and filethatdoesexist.pdf -unique Description --- Added command line options print. Bug 252462 This addresses bug 252462. http://bugs.kde.org/show_bug.cgi?id=252462 Diffs (updated) - part.h 2fcdf0a part.cpp 912716a shell/main.cpp 226dab8 shell/shell.cpp 81d63c2 Diff: http://git.reviewboard.kde.org/r/109096/diff/ Testing --- Thanks, Tomáš Poledný ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 109096: Open print dialog from command line
On March 3, 2013, 4:38 p.m., Albert Astals Cid wrote: I have found a bug, if you do: okular filethatdoesnotexist.pdf -unique -print okular filethatdoesexist.pdf -unique You get the printing dialog when opening the second one, i think that's a bit unexpected, no? Yes you are right. I fixed it. I added new method resetStartArguments(). I will use this method for fixing problem with presentation argument and unique instance. I'm so sorry for that. - Tomáš --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109096/#review28457 --- On March 8, 2013, 8:17 p.m., Tomáš Poledný wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109096/ --- (Updated March 8, 2013, 8:17 p.m.) Review request for Okular. Description --- Added command line options print. Bug 252462 This addresses bug 252462. http://bugs.kde.org/show_bug.cgi?id=252462 Diffs - part.h 2fcdf0a part.cpp 912716a shell/main.cpp 226dab8 shell/shell.cpp 81d63c2 Diff: http://git.reviewboard.kde.org/r/109096/diff/ Testing --- Thanks, Tomáš Poledný ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 109096: Open print dialog from command line
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109096/#review28457 --- I have found a bug, if you do: okular filethatdoesnotexist.pdf -unique -print okular filethatdoesexist.pdf -unique You get the printing dialog when opening the second one, i think that's a bit unexpected, no? - Albert Astals Cid On March 1, 2013, 11:36 a.m., Tomáš Poledný wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109096/ --- (Updated March 1, 2013, 11:36 a.m.) Review request for Okular. Description --- Added command line options print. Bug 252462 This addresses bug 252462. http://bugs.kde.org/show_bug.cgi?id=252462 Diffs - part.h 2fcdf0a part.cpp 912716a shell/main.cpp 226dab8 shell/shell.cpp 81d63c2 Diff: http://git.reviewboard.kde.org/r/109096/diff/ Testing --- Thanks, Tomáš Poledný ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 109096: Open print dialog from command line
On Feb. 28, 2013, 11:45 p.m., Albert Astals Cid wrote: kdocumentviewer.h, line 50 http://git.reviewboard.kde.org/r/109096/diff/4/?file=116181#file116181line50 Do we need this? If not i'd prefer not to change this public header. Yes, it is like startPresentation. I was thinking start presentation is similar action to printing. That is reason why I changed this interface. Or we can cast m_part to Part (Okular). What is better for you? On Feb. 28, 2013, 11:45 p.m., Albert Astals Cid wrote: part.h, line 152 http://git.reviewboard.kde.org/r/109096/diff/4/?file=116182#file116182line152 Why do we need enableStartPrint and startPrint if they do the same? You are right but enableStartPrint is method for D-Bus calling. startPrint is inherited from interface. It's the same question. Is printing action similar to a presentation or not? If not we can cast m_part and use only enableStartPrint and remove startPrint from interface. What is better choice for you? - Tomáš --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109096/#review28312 --- On Feb. 27, 2013, 11:58 p.m., Tomáš Poledný wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109096/ --- (Updated Feb. 27, 2013, 11:58 p.m.) Review request for Okular. Description --- Added command line options print. Bug 252462 This addresses bug 252462. http://bugs.kde.org/show_bug.cgi?id=252462 Diffs - kdocumentviewer.h 2f77610 part.h 2fcdf0a part.cpp 912716a shell/main.cpp 226dab8 shell/shell.cpp 81d63c2 Diff: http://git.reviewboard.kde.org/r/109096/diff/ Testing --- Thanks, Tomáš Poledný ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 109096: Open print dialog from command line
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109096/ --- (Updated March 1, 2013, 11:34 a.m.) Review request for Okular. Changes --- I found solution more simple and without casting. Description --- Added command line options print. Bug 252462 This addresses bug 252462. http://bugs.kde.org/show_bug.cgi?id=252462 Diffs (updated) - part.h 2fcdf0a part.cpp 912716a shell/main.cpp 226dab8 shell/shell.cpp 81d63c2 Diff: http://git.reviewboard.kde.org/r/109096/diff/ Testing --- Thanks, Tomáš Poledný ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 109096: Open print dialog from command line
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109096/ --- (Updated March 1, 2013, 11:36 a.m.) Review request for Okular. Description --- Added command line options print. Bug 252462 This addresses bug 252462. http://bugs.kde.org/show_bug.cgi?id=252462 Diffs - part.h 2fcdf0a part.cpp 912716a shell/main.cpp 226dab8 shell/shell.cpp 81d63c2 Diff: http://git.reviewboard.kde.org/r/109096/diff/ Testing --- Thanks, Tomáš Poledný ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 109096: Open print dialog from command line
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109096/#review28230 --- part.cpp http://git.reviewboard.kde.org/r/109096/#comment21097 Why are you using invokeMethod here? shell/main.cpp http://git.reviewboard.kde.org/r/109096/#comment21098 Why are those here? Seems to me you are trying to fix multiple things in a same review, this is a bad idea, actually you shouldn't even implement print and noraise in the same review, one review per feature is better, allows smaller and self-contained commits to be done. - Albert Astals Cid On Feb. 24, 2013, 3:01 p.m., Tomáš Poledný wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109096/ --- (Updated Feb. 24, 2013, 3:01 p.m.) Review request for Okular. Description --- Added command line options print. Bug 252462 This addresses bugs 252462 and 315538. http://bugs.kde.org/show_bug.cgi?id=252462 http://bugs.kde.org/show_bug.cgi?id=315538 Diffs - kdocumentviewer.h 2f77610 part.h e3a9418 part.cpp f1cdc11 shell/main.cpp 226dab8 shell/shell.cpp 81d63c2 Diff: http://git.reviewboard.kde.org/r/109096/diff/ Testing --- Thanks, Tomáš Poledný ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 109096: Open print dialog from command line
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109096/#review28234 --- part.cpp http://git.reviewboard.kde.org/r/109096/#comment21100 I'm sorry my fault. I was not thinking about it. Calling method is better. I hope that now everything will be okay. shell/main.cpp http://git.reviewboard.kde.org/r/109096/#comment21099 Ok I will make 3 different review request. Sorry for that. Lessons learned for next time. - Tomáš Poledný On Feb. 24, 2013, 3:01 p.m., Tomáš Poledný wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109096/ --- (Updated Feb. 24, 2013, 3:01 p.m.) Review request for Okular. Description --- Added command line options print. Bug 252462 This addresses bugs 252462 and 315538. http://bugs.kde.org/show_bug.cgi?id=252462 http://bugs.kde.org/show_bug.cgi?id=315538 Diffs - kdocumentviewer.h 2f77610 part.h e3a9418 part.cpp f1cdc11 shell/main.cpp 226dab8 shell/shell.cpp 81d63c2 Diff: http://git.reviewboard.kde.org/r/109096/diff/ Testing --- Thanks, Tomáš Poledný ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 109096: Open print dialog from command line
On Feb. 27, 2013, 10:35 p.m., Albert Astals Cid wrote: part.cpp, line 1322 http://git.reviewboard.kde.org/r/109096/diff/3/?file=115231#file115231line1322 Why are you using invokeMethod here? I'm sorry my fault. I was not thinking about it. Calling method is better. I hope that now everything will be okay. On Feb. 27, 2013, 10:35 p.m., Albert Astals Cid wrote: shell/main.cpp, line 34 http://git.reviewboard.kde.org/r/109096/diff/3/?file=115232#file115232line34 Why are those here? Seems to me you are trying to fix multiple things in a same review, this is a bad idea, actually you shouldn't even implement print and noraise in the same review, one review per feature is better, allows smaller and self-contained commits to be done. Ok I will make 3 different review request. Sorry for that. Lessons learned for next time. - Tomáš --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109096/#review28230 --- On Feb. 27, 2013, 11:58 p.m., Tomáš Poledný wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109096/ --- (Updated Feb. 27, 2013, 11:58 p.m.) Review request for Okular. Description --- Added command line options print. Bug 252462 This addresses bug 252462. http://bugs.kde.org/show_bug.cgi?id=252462 Diffs - kdocumentviewer.h 2f77610 part.h 2fcdf0a part.cpp 912716a shell/main.cpp 226dab8 shell/shell.cpp 81d63c2 Diff: http://git.reviewboard.kde.org/r/109096/diff/ Testing --- Thanks, Tomáš Poledný ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 109096: Open print dialog from command line
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109096/ --- (Updated Feb. 24, 2013, 3:01 p.m.) Review request for Okular. Changes --- Added --noraise option (Bug 315538). Fixed cmd line options --presentation and --print if okular is unique instance. Command okular https://bugs.freedesktop.org/attachment.cgi?id=46889 --print now works. Description --- Added command line options print. Bug 252462 This addresses bug 252462. http://bugs.kde.org/show_bug.cgi?id=252462 Diffs (updated) - kdocumentviewer.h 2f77610 part.h e3a9418 part.cpp f1cdc11 shell/main.cpp 226dab8 shell/shell.cpp 81d63c2 Diff: http://git.reviewboard.kde.org/r/109096/diff/ Testing --- Thanks, Tomáš Poledný ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 109096: Open print dialog from command line
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109096/ --- (Updated Feb. 24, 2013, 3:01 p.m.) Review request for Okular. Description --- Added command line options print. Bug 252462 This addresses bugs 252462 and 315538. http://bugs.kde.org/show_bug.cgi?id=252462 http://bugs.kde.org/show_bug.cgi?id=315538 Diffs - kdocumentviewer.h 2f77610 part.h e3a9418 part.cpp f1cdc11 shell/main.cpp 226dab8 shell/shell.cpp 81d63c2 Diff: http://git.reviewboard.kde.org/r/109096/diff/ Testing --- Thanks, Tomáš Poledný ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 109096: Open print dialog from command line
On Feb. 23, 2013, 11:50 p.m., Albert Astals Cid wrote: Should move it to a bool like we do in start presentation, otherwise okular https://bugs.freedesktop.org/attachment.cgi?id=46889 --print won't work I have rewritten it. I do not know if we need to change the version of interface KDocumentViewer. - Tomáš --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109096/#review27946 --- On Feb. 24, 2013, 3:01 p.m., Tomáš Poledný wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109096/ --- (Updated Feb. 24, 2013, 3:01 p.m.) Review request for Okular. Description --- Added command line options print. Bug 252462 This addresses bugs 252462 and 315538. http://bugs.kde.org/show_bug.cgi?id=252462 http://bugs.kde.org/show_bug.cgi?id=315538 Diffs - kdocumentviewer.h 2f77610 part.h e3a9418 part.cpp f1cdc11 shell/main.cpp 226dab8 shell/shell.cpp 81d63c2 Diff: http://git.reviewboard.kde.org/r/109096/diff/ Testing --- Thanks, Tomáš Poledný ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 109096: Open print dialog from command line
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109096/#review27925 --- shell/shell.cpp http://git.reviewboard.kde.org/r/109096/#comment20933 Using QueuedConnections is by default evil and you shouldn't use them unless strictly necessary. I guess you're using it to open the dialog after the document has been loaded. Can't you just achieve that calling slotPrint after openUrl? - Albert Astals Cid On Feb. 22, 2013, 9:12 p.m., Tomáš Poledný wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109096/ --- (Updated Feb. 22, 2013, 9:12 p.m.) Review request for Okular. Description --- Added command line options print. Bug 252462 This addresses bug 252462. http://bugs.kde.org/show_bug.cgi?id=252462 Diffs - shell/main.cpp 226dab8 shell/shell.cpp 81d63c2 Diff: http://git.reviewboard.kde.org/r/109096/diff/ Testing --- Thanks, Tomáš Poledný ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 109096: Open print dialog from command line
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109096/ --- (Updated Feb. 23, 2013, 1:35 p.m.) Review request for Okular. Changes --- Removed QueuedConnections Description --- Added command line options print. Bug 252462 This addresses bug 252462. http://bugs.kde.org/show_bug.cgi?id=252462 Diffs (updated) - shell/main.cpp 226dab8 shell/shell.cpp 81d63c2 Diff: http://git.reviewboard.kde.org/r/109096/diff/ Testing --- Thanks, Tomáš Poledný ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 109096: Open print dialog from command line
On Feb. 23, 2013, 12:16 p.m., Albert Astals Cid wrote: shell/shell.cpp, line 182 http://git.reviewboard.kde.org/r/109096/diff/1/?file=114956#file114956line182 Using QueuedConnections is by default evil and you shouldn't use them unless strictly necessary. I guess you're using it to open the dialog after the document has been loaded. Can't you just achieve that calling slotPrint after openUrl? You are right. I have fixed it in new diff. - Tomáš --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109096/#review27925 --- On Feb. 23, 2013, 1:35 p.m., Tomáš Poledný wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109096/ --- (Updated Feb. 23, 2013, 1:35 p.m.) Review request for Okular. Description --- Added command line options print. Bug 252462 This addresses bug 252462. http://bugs.kde.org/show_bug.cgi?id=252462 Diffs - shell/main.cpp 226dab8 shell/shell.cpp 81d63c2 Diff: http://git.reviewboard.kde.org/r/109096/diff/ Testing --- Thanks, Tomáš Poledný ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 109096: Open print dialog from command line
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109096/#review27946 --- Should move it to a bool like we do in start presentation, otherwise okular https://bugs.freedesktop.org/attachment.cgi?id=46889 --print won't work - Albert Astals Cid On Feb. 23, 2013, 1:35 p.m., Tomáš Poledný wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109096/ --- (Updated Feb. 23, 2013, 1:35 p.m.) Review request for Okular. Description --- Added command line options print. Bug 252462 This addresses bug 252462. http://bugs.kde.org/show_bug.cgi?id=252462 Diffs - shell/main.cpp 226dab8 shell/shell.cpp 81d63c2 Diff: http://git.reviewboard.kde.org/r/109096/diff/ Testing --- Thanks, Tomáš Poledný ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 109096: Open print dialog from command line
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109096/ --- (Updated Feb. 22, 2013, 9:09 p.m.) Review request for Okular. Description --- Added command line options print Diffs - shell/main.cpp 226dab8 shell/shell.cpp 81d63c2 Diff: http://git.reviewboard.kde.org/r/109096/diff/ Testing --- Thanks, Tomáš Poledný ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 109096: Open print dialog from command line
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109096/ --- (Updated Feb. 22, 2013, 9:11 p.m.) Review request for Okular. Description (updated) --- Added command line options print. Bug 252462 Diffs - shell/main.cpp 226dab8 shell/shell.cpp 81d63c2 Diff: http://git.reviewboard.kde.org/r/109096/diff/ Testing --- Thanks, Tomáš Poledný ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
Re: [Okular-devel] Review Request 109096: Open print dialog from command line
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109096/ --- (Updated Feb. 22, 2013, 9:12 p.m.) Review request for Okular. Description --- Added command line options print. Bug 252462 This addresses bug 252462. http://bugs.kde.org/show_bug.cgi?id=252462 Diffs - shell/main.cpp 226dab8 shell/shell.cpp 81d63c2 Diff: http://git.reviewboard.kde.org/r/109096/diff/ Testing --- Thanks, Tomáš Poledný ___ Okular-devel mailing list Okular-devel@kde.org https://mail.kde.org/mailman/listinfo/okular-devel
