Re: Review Request 129286: Fix warnings about unhandled enumeration value in switch
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129286/ --- (Updated March 12, 2017, 10:17 p.m.) Status -- This change has been discarded. Review request for Okular. Repository: okular Description --- The one in the DVI generator is a maybe-unused warning, but it's a false positive, because there were no unhandled enum values. Diffs - generators/dvi/generator_dvi.cpp d1536cc ui/pageview.cpp bb540cb ui/presentationwidget.cpp e6ecdc5 Diff: https://git.reviewboard.kde.org/r/129286/diff/ Testing --- Thanks, Miklós Máté
Re: Review Request 129286: Fix warnings about unhandled enumeration value in switch
> On March 11, 2017, 5:03 p.m., Albert Astals Cid wrote: > > Which compiler are you using that gives you those warnings? > > Miklós Máté wrote: > 3 months ago I think I used gcc 5.something. Currently I have gcc 6.3, > and it doesn't issue a warning for the dvi generator. Yay for fewer false > positives. Ok, i'll discard this then. - Albert --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129286/#review102792 --- On Oct. 30, 2016, 2:29 p.m., Miklós Máté wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129286/ > --- > > (Updated Oct. 30, 2016, 2:29 p.m.) > > > Review request for Okular. > > > Repository: okular > > > Description > --- > > The one in the DVI generator is a maybe-unused warning, but it's a false > positive, because there were no unhandled enum values. > > > Diffs > - > > generators/dvi/generator_dvi.cpp d1536cc > ui/pageview.cpp bb540cb > ui/presentationwidget.cpp e6ecdc5 > > Diff: https://git.reviewboard.kde.org/r/129286/diff/ > > > Testing > --- > > > Thanks, > > Miklós Máté > >
Re: Review Request 129286: Fix warnings about unhandled enumeration value in switch
> On March 11, 2017, 6:03 p.m., Albert Astals Cid wrote: > > Which compiler are you using that gives you those warnings? 3 months ago I think I used gcc 5.something. Currently I have gcc 6.3, and it doesn't issue a warning for the dvi generator. Yay for fewer false positives. - Miklós --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129286/#review102792 --- On Oct. 30, 2016, 3:29 p.m., Miklós Máté wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129286/ > --- > > (Updated Oct. 30, 2016, 3:29 p.m.) > > > Review request for Okular. > > > Repository: okular > > > Description > --- > > The one in the DVI generator is a maybe-unused warning, but it's a false > positive, because there were no unhandled enum values. > > > Diffs > - > > generators/dvi/generator_dvi.cpp d1536cc > ui/pageview.cpp bb540cb > ui/presentationwidget.cpp e6ecdc5 > > Diff: https://git.reviewboard.kde.org/r/129286/diff/ > > > Testing > --- > > > Thanks, > > Miklós Máté > >
Re: Review Request 129286: Fix warnings about unhandled enumeration value in switch
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129286/#review102792 --- Which compiler are you using that gives you those warnings? - Albert Astals Cid On Oct. 30, 2016, 2:29 p.m., Miklós Máté wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129286/ > --- > > (Updated Oct. 30, 2016, 2:29 p.m.) > > > Review request for Okular. > > > Repository: okular > > > Description > --- > > The one in the DVI generator is a maybe-unused warning, but it's a false > positive, because there were no unhandled enum values. > > > Diffs > - > > generators/dvi/generator_dvi.cpp d1536cc > ui/pageview.cpp bb540cb > ui/presentationwidget.cpp e6ecdc5 > > Diff: https://git.reviewboard.kde.org/r/129286/diff/ > > > Testing > --- > > > Thanks, > > Miklós Máté > >
Re: Review Request 129286: Fix warnings about unhandled enumeration value in switch
> On Nov. 17, 2016, 10:29 p.m., Albert Astals Cid wrote: > > adding default: is not a good idea, it will silence warnings in teh future > > when new enums are added. > > > > You don't want to silence the warnings, you want to fix them. Your concern is valid in general, but in this case I would be very surprised if RenditionAction gained a new operation. Anyway, in the meantime the last two hunks have been taken care of by Martin T. H. Sandsmark. The first hunk (the dvi generator) is still a useful fix for a maybe-uninitialized warning. - Miklós --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129286/#review100919 --- On Oct. 30, 2016, 3:29 p.m., Miklós Máté wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129286/ > --- > > (Updated Oct. 30, 2016, 3:29 p.m.) > > > Review request for Okular. > > > Repository: okular > > > Description > --- > > The one in the DVI generator is a maybe-unused warning, but it's a false > positive, because there were no unhandled enum values. > > > Diffs > - > > generators/dvi/generator_dvi.cpp d1536cc > ui/pageview.cpp bb540cb > ui/presentationwidget.cpp e6ecdc5 > > Diff: https://git.reviewboard.kde.org/r/129286/diff/ > > > Testing > --- > > > Thanks, > > Miklós Máté > >
Re: Review Request 129286: Fix warnings about unhandled enumeration value in switch
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129286/#review100919 --- adding default: is not a good idea, it will silence warnings in teh future when new enums are added. You don't want to silence the warnings, you want to fix them. - Albert Astals Cid On Oct. 30, 2016, 2:29 p.m., Miklós Máté wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129286/ > --- > > (Updated Oct. 30, 2016, 2:29 p.m.) > > > Review request for Okular. > > > Repository: okular > > > Description > --- > > The one in the DVI generator is a maybe-unused warning, but it's a false > positive, because there were no unhandled enum values. > > > Diffs > - > > generators/dvi/generator_dvi.cpp d1536cc > ui/pageview.cpp bb540cb > ui/presentationwidget.cpp e6ecdc5 > > Diff: https://git.reviewboard.kde.org/r/129286/diff/ > > > Testing > --- > > > Thanks, > > Miklós Máté > >
Review Request 129286: Fix warnings about unhandled enumeration value in switch
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129286/ --- Review request for Okular. Repository: okular Description --- The one in the DVI generator is a maybe-unused warning, but it's a false positive, because there were no unhandled enum values. Diffs - generators/dvi/generator_dvi.cpp d1536cc ui/pageview.cpp bb540cb ui/presentationwidget.cpp e6ecdc5 Diff: https://git.reviewboard.kde.org/r/129286/diff/ Testing --- Thanks, Miklós Máté
