Re: [HELP] commit permission request for my Apache id

2012-09-16 Thread Chen Peng
Thank you, Ariel.

2012/9/15 ZuoJun Chen zjchen...@gmail.com

 Hi, Ariel

  Thank you for your kind help.

 Regards -- Zuo Jun

 2012/9/15 Ariel Constenla-Haile arie...@apache.org

  On Fri, Sep 14, 2012 at 04:48:13PM +0800, Chen Peng wrote:
   me too, my svn id is pengch, just in incubator project, not include ooo
   project.
 
  [...]
 
See  zjchen  in list
http://people.apache.org/committer-index.html#Z
http://people.apache.org/committer-index.html#liuzhe
 
  Done, thanks to Ross:
  http://people.apache.org/committer-index.html#zjchen
  http://people.apache.org/committer-index.html#pengch
 
 
  Regards
  --
  Ariel Constenla-Haile
  La Plata, Argentina
 



Re: [HELP] commit permission request for my Apache id

2012-09-14 Thread Chen Peng
me too, my svn id is pengch, just in incubator project, not include ooo
project.

2012/9/14 ZuoJun Chen zjchen...@gmail.com

 Hi,

  I have accepted the commiter invitation some days ago and

 my Apache id has been created. However, I'm not in ooo svn project

 thus could not commit code to AOO trunk.

 See  zjchen  in list
 http://people.apache.org/committer-index.html#Z
 http://people.apache.org/committer-index.html#liuzhe

  Is there anyone who can help me to make commits permission?

 Thanks in advance.

 Regards -- Zuo Jun



[Call-for-Review]Bug 119487 - [From Symphony]Images lose macro association when open Excel file in AOO

2012-09-06 Thread Chen Peng
Hi All,
 I have fixed a bug about macro doesn't work on images, as shown in
below:
   *Bug 119487*
https://issues.apache.org/ooo/show_bug.cgi?id=119487 - [From
Symphony]Images lose macro association when open Excel file in AOO
   https://issues.apache.org/ooo/show_bug.cgi?id=119487

   Root Cause:
Macro on picture is supported by VBA, should set the related
flag to true.
   Resolution:
Set the SimpleMacro flag to true to enable the macro on picture.

Anyone help to review the fix will be appreciated, thanks!


[Call-for-​Review]Bug 120133 - [From Symphony]Doc file saved by AOO, section size changed

2012-08-22 Thread Chen Peng
Hi All,
 I have fixed a bug about copy text wrong, as shown in below:
   *Bug 120133*
https://issues.apache.org/ooo/show_bug.cgi?id=120133 - [From
Symphony]Doc file saved by AOO, section size changed
   https://issues.apache.org/ooo/show_bug.cgi?id=120133
   Root Cause:
   The section width should consider page and section indent value
to calculate the right width size.
   Resolution:
   Get the indent value, then calculate the right section width.

Anyone help to review the fix will be appreciated, thanks!


Re: Older IBM patches for VBA (from Symphony?)

2012-08-09 Thread Chen Peng
Hi Pedro,
   I think we can tagged them [From Symphony], and  I will look at
these patches. Thanks.

2012/8/10 Pedro Giffuni p...@apache.org

 Hello;

 I just wanted to point out that there are 4 open issues by lihuibj @ ibm :

 https://issues.apache.org/ooo/show_bug.cgi?id=106278

 https://issues.apache.org/ooo/show_bug.cgi?id=108863

 https://issues.apache.org/ooo/show_bug.cgi?id=108874

 https://issues.apache.org/ooo/show_bug.cgi?id=110746


 And there also cws/lihuivba01

 Perhaps this should be tagged [From Symphony] too?

 cheers,

 Pedro.



Re: [Call-for-Review]Bug 120442 - Copy text to Firefox or Chrome cause data damaged

2012-08-08 Thread Chen Peng
Hi Herbert, thank you very much.

2012/8/8 Herbert Duerr h...@apache.org

 On 07.08.2012 10:20, Chen Peng wrote:

 Hi All,
   I have fixed a bug about copy text wrong, as shown in below:
 *Bug 120442*
 https://issues.apache.org/**ooo/show_bug.cgi?id=120442https://issues.apache.org/ooo/show_bug.cgi?id=120442
 - Copy

 text to Firefox or Chrome cause data damaged
 [...]
 *Resolution:
 *   Need to convert such two 16-bit unicode to a 32-bit unicode
 to

 show the content.

  Anyone help to review the fix will be appreciated, thanks!


 Good stuff, I applied your patch (with some minor modifications).
 Unicode codepoints outside of the baseplane are better supported now.

 Herbert



[Call-for-​Review]Two issues about font size change in document.

2012-08-07 Thread Chen Peng
Hi All,
 I have fixed two problems about font size change in document, as shown
in below:

 1. *Bug 119649*
https://issues.apache.org/ooo/show_bug.cgi?id=119649- [From
Symphony]Hyperlink font size increased if saved to .doc file
 https://issues.apache.org/ooo/show_bug.cgi?id=119649
 *Root Cause:
* In the id definition, RES_TXTATR_INETFMT must precede
RES_TXTATR_CHARFMT, so that link
 style can overwrite char style. And in #i24291# it describes
All we want to do is ensure for now is
 that if a charfmt exist  in the character properties that it
rises to the top and is exported first.,
 so hyperlink text property will override the original text
property in this situation.
 *Resolution:
* Ignore the link style in such situation when doing ms word
filter exports.

 2. *Bug 119650*
https://issues.apache.org/ooo/show_bug.cgi?id=119650- [From
Symphony]Font size increased if saved by AOO
 https://issues.apache.org/ooo/show_bug.cgi?id=119650
 *Root Cause:
*The properties of CHP PLC was not broken after a paragraph
ending.
 *Resolution:
*   Add such broken after paragraph ending.

Thank you very much if you can help me to review them!


[Call-for-Review]Bug 120442 - Copy text to Firefox or Chrome cause data damaged

2012-08-07 Thread Chen Peng
Hi All,
 I have fixed a bug about copy text wrong, as shown in below:
   *Bug 120442*
https://issues.apache.org/ooo/show_bug.cgi?id=120442 - Copy
text to Firefox or Chrome cause data damaged
   https://issues.apache.org/ooo/show_bug.cgi?id=120442
  * Root Cause:
*   In Firefox or Chrome, if the unicode is equal or larger than
0xd800 and smaller equal or than 0xdbff,
   and the next unicode  is equal or larger then 0xdc00 and equal
or smaller than 0xdfff, using such two 16-bit unicode
   can't  display the data such as the last 5 charaters of line 8
in the sample.
   *Resolution:
*   Need to convert such two 16-bit unicode to a 32-bit unicode to
show the content.

Anyone help to review the fix will be appreciated, thanks!


Re: [DISCUSS]Macros are lost after saving the xls file to ods, then save as to xls again

2012-07-03 Thread Chen Peng
Yes, Jim. Your description is very exact about this topic. Thank you.

2012/7/3 chengjh chen...@apache.org

 Hi Peng,

 Let me use a scenario to confirm your problem,solution and
 question..Anything misunderstood,please correct me.thanks.

 Problem:
 When AOO launches an excel document with VBA,saves to ods and then saves to
 excel again,the VBA info will be lost.

 Solution:
 a)The VBA streams of an excel document will be saved into the ods document
 with binary format when converting an excel document to an ods document in
 AOO Spreadsheet with certain controller.
 b)Once the ods document containing the binary VBA streams is launched into
 AOO or previous releases,with certain controller,the binary VBA steams will
 be loaded[still binary stream in memory] or rejected..There is no any
 impact on the application,the application can still work well.
 c)Based on b),if the ods document is saved to an excel document,the binary
 VBA streams will be exported, thus, the VBA info will not be lost.

 Question:
 You are not sure whether this solution is reasonable. So, you want to know
 the comments about your solution. If no comments, you will do so to
 implement it.

 On Mon, Jul 2, 2012 at 4:33 PM, Chen Peng chenpeng2...@gmail.com wrote:

  Hi All,
My name is Chen Peng, I am a developer from Symphony. My special
  areas are VBA and sw.
Now I found an issue about macros lost:
   I saved an excel file with VBA to spreadsheet, the VBA can work
  well in spreadsheet, then I wanted to save this spreadsheet back to
 excel,
  but all the macros are lost.
I propose to save the binary data of excel VBA to spreadsheet, when
  saving excel to spreadsheet, then we can get the binary data from
  spreadsheet if need to save the spreadsheet to excel again.
The binary data will not impact the open/save... of the ODF format
  application, it will not be touched when we operate the ODF formant
  applications. The binary data will be just used when we want to save the
  spreadsheet to excel, it is just a data prestore about saving spreadsheet
  macros to excel.
 Can you give some advice about the solution?
 Any feedback will be preciated, thanks.
 



 --

 Best Regards,Jianhong Cheng



Re: VBA

2012-07-03 Thread Chen Peng
Hi Stefan,
  Do you mean you want to open a report then change the filter in the
report using StarBasic macro?
  if it is, this is not a VBA issue.
  You can use the Record Macro function in AOO to store the macro
action, maybe you can get the answer.



2012/7/4 Stefan Lindel ste...@famlindel.de

 I want open a Report and change the filter dynamicly

 I found the Code to Open
 subdlg = getController().loadComponent(**com.sun.star.sdb.application.**
 DatabaseObject.REPORT,**Ergebnisse,FALSE)

 but i dont know how i change the filter in the report

 mfg

 Stefan



[Call-for-​​​Review] bug 119953 ([From Symphony]Undo redo insert file cause application crashed)

2012-06-26 Thread Chen Peng
Hi all,
I have a fix for bug 119953.
https://issues.apache.org/ooo/show_bug.cgi?id=119953
It is about application crash when undo  redo a inserted file, because of
in the procedure of inserting file, a text node split and a text node join
action did not have corresponding undo recorded.

Anybody who could help to review it?
Thanks.