[Call-for-Review]Bug 120442 - Copy text to Firefox or Chrome cause data damaged

2012-08-07 Thread Chen Peng 
Hi All,
 I have fixed a bug about copy text wrong, as shown in below:
   *Bug 120442*
 - Copy
text to Firefox or Chrome cause data damaged
   https://issues.apache.org/ooo/show_bug.cgi?id=120442
  * Root Cause:
*   In Firefox or Chrome, if the unicode is equal or larger than
0xd800 and smaller equal or than 0xdbff,
   and the next unicode  is equal or larger then 0xdc00 and equal
or smaller than 0xdfff, using such two 16-bit unicode
   can't  display the data such as the last 5 charaters of line 8
in the sample.
   *Resolution:
*   Need to convert such two 16-bit unicode to a 32-bit unicode to
show the content.

Anyone help to review the fix will be appreciated, thanks!

Re: [Call-for-Review]Bug 120442 - Copy text to Firefox or Chrome cause data damaged

2012-08-08 Thread Herbert Duerr 

On 07.08.2012 10:20, Chen Peng wrote:

Hi All,
  I have fixed a bug about copy text wrong, as shown in below:
*Bug 120442*
 - Copy
text to Firefox or Chrome cause data damaged
[...]
*Resolution:
*   Need to convert such two 16-bit unicode to a 32-bit unicode to
show the content.

 Anyone help to review the fix will be appreciated, thanks!


Good stuff, I applied your patch (with some minor modifications).
Unicode codepoints outside of the baseplane are better supported now.

Herbert

Re: [Call-for-Review]Bug 120442 - Copy text to Firefox or Chrome cause data damaged

2012-08-08 Thread Chen Peng 
Hi Herbert, thank you very much.

2012/8/8 Herbert Duerr 

> On 07.08.2012 10:20, Chen Peng wrote:
>
>> Hi All,
>>   I have fixed a bug about copy text wrong, as shown in below:
>> *Bug 120442*
>> >
>> - Copy
>>
>> text to Firefox or Chrome cause data damaged
>> [...]
>> *Resolution:
>> *   Need to convert such two 16-bit unicode to a 32-bit unicode
>> to
>>
>> show the content.
>>
>>  Anyone help to review the fix will be appreciated, thanks!
>>
>
> Good stuff, I applied your patch (with some minor modifications).
> Unicode codepoints outside of the baseplane are better supported now.
>
> Herbert
>