Re: Is MaxOutstandingR2T hardcoded?

2009-01-08 Thread Erez Zilber

On Wed, Jan 7, 2009 at 8:34 PM, Mike Christie micha...@cs.wisc.edu wrote:

 Erez Zilber wrote:
 I noticed that if I change the value of
 node.session.iscsi.MaxOutstandingR2T to some value  1 (and the target
 also supports a value higher than 1), it is still negotiated to '1'. I
 saw that the login PDU itself contains 'MaxOutstandingR2T = 1'.

 I took a look at the code and found this in 
 login.c::add_params_normal_session:

 http://git.kernel.org/?p=linux/kernel/git/mnc/open-iscsi.git;a=blob;f=usr/login.c;h=02358703a423a1b09f578fd919e9245797a3c0b1;hb=HEAD#l802

 Is it hardcoded on purpose? If yes, why?


 Because the code only supports one.

So, maybe it's a good idea to disable commands like iscsiadm -m node
--op update -n node.session.iscsi.MaxOutstandingR2T -v some_val.

Erez

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
open-iscsi group.
To post to this group, send email to open-iscsi@googlegroups.com
To unsubscribe from this group, send email to 
open-iscsi+unsubscr...@googlegroups.com
For more options, visit this group at http://groups.google.com/group/open-iscsi
-~--~~~~--~~--~--~---



connection, host resets, I/O errors eventually (DRBD, but not only)

2009-01-08 Thread Tomasz Chmielewski

Anyone using iSCSI over DRBD? And a slow internet link perhaps?

If yes, you are likely to see connection errors, host resets, and eventually,
I/O errors reported, for example:

Jan  7 21:47:09 vmware1 kernel:  connection23:0: iscsi: detected conn error 
(1011)
Jan  7 21:47:10 vmware1 kernel: iscsi: host reset succeeded
Jan  7 21:47:50 vmware1 kernel:  connection23:0: iscsi: detected conn error 
(1011)
Jan  7 21:47:50 vmware1 kernel: iscsi: host reset succeeded
Jan  7 21:48:00 vmware1 kernel: sd 22:0:0:1: SCSI error: return code = 
0x0002
Jan  7 21:48:00 vmware1 kernel: end_request: I/O error, dev sdw, sector 1494720
Jan  7 21:48:00 vmware1 kernel: Buffer I/O error on device sdw, logical block 
186840
Jan  7 21:48:00 vmware1 kernel: lost page write due to I/O error on sdw


This is due to the fact that open-iscsi doesn't seem to like low-speed (but 
stable)
connections to the target.

To reproduce:

1) set up a connection with limited speed between the target and the initiator,
for example, with openvpn, one would use --shaper 5 option to limit the 
speed
to 50 kB/s.

2) login the target to the initiator over this connection (can be also in LAN)

3) start reading and writing... after some time you will be seeing connection 
errors and 
host resets followed by I/O errors, possibly data corruption


A harder way to reproduce (but somehow more realistic) would be to set up DRBD,
start background synchronization at high speed (thus leaving not much bandwidth 
for
normal writes), start reading and writing...


I can reproduce it with tgtd and IET, so I guess open-iscsi is to be blamed.

Ideas what's wrong and why it fails?


-- 
Tomasz Chmielewski
http://wpkg.org

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
open-iscsi group.
To post to this group, send email to open-iscsi@googlegroups.com
To unsubscribe from this group, send email to 
open-iscsi+unsubscr...@googlegroups.com
For more options, visit this group at http://groups.google.com/group/open-iscsi
-~--~~~~--~~--~--~---



Open-iscsi doesn't run into openvz VE

2009-01-08 Thread Marc Aymerich

Hi!

Some of you make works open-iscsi into openvz virtual Enviroment¿ I
can't find the way to work open-iscsi into openvz container with the
default installation of Debian Lenny. ¿I need to apply some kernel
patch?

# iscsid -f
iscsid: Missing or Invalid version from
/sys/module/scsi_transport_iscsi/version. Make sure a up to date
scsi_transport_iscsi module is loaded and a up todate version of
iscsid is running. Exiting...

When iscsid starts it checks the scsi_transport_iscsi module version
but on the default installation of openvz the VE doesn't have anything
in /sys/module:

# ls /sys
class  devices


I can reproduce this problem with:

*
 on Host Machine 
*

# uname -r
2.6.26-1-openvz-amd64

# lsmod |grep scsi
iscsi_tcp  21636  0
libiscsi   32384  2 ib_iser,iscsi_tcp
scsi_transport_iscsi36256  4 ib_iser,iscsi_tcp,libiscsi
scsi_mod  160888  8
ib_iser,iscsi_tcp,libiscsi,scsi_transport_iscsi,sg,sr_mod,sd_mod,libata

# cat /sys/module/scsi_transport_iscsi/version
2.0-869

# iscsid --version
iscsid version 2.0-870

***
*** on Virtual Machine 
***

# uname -r
2.6.26-1-openvz-amd64

# iscsid --version
iscsid version 2.0-870


Yes, the version of the scsi_transport_iscsi module and the open-iscsi
doesn't match exactly, but in the host machine it works fine.


Thanks very much!!
Marc

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
open-iscsi group.
To post to this group, send email to open-iscsi@googlegroups.com
To unsubscribe from this group, send email to 
open-iscsi+unsubscr...@googlegroups.com
For more options, visit this group at http://groups.google.com/group/open-iscsi
-~--~~~~--~~--~--~---



How can I list logged in nodes?

2009-01-08 Thread chris1.nore...@googlemail.com

Hi, is there a way using iscsiadm to list only nodes which are
currently logged in? I find that running iscsiadm -m node always
lists discovered nodes, but can't find a way to list only those which
are logged in and therefore available.

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
open-iscsi group.
To post to this group, send email to open-iscsi@googlegroups.com
To unsubscribe from this group, send email to 
open-iscsi+unsubscr...@googlegroups.com
For more options, visit this group at http://groups.google.com/group/open-iscsi
-~--~~~~--~~--~--~---



Re: How can I list logged in nodes?

2009-01-08 Thread Konrad Rzeszutek

On Thu, Jan 08, 2009 at 10:00:31AM -0800, chris1.nore...@googlemail.com wrote:
 
 Hi, is there a way using iscsiadm to list only nodes which are
 currently logged in? I find that running iscsiadm -m node always
 lists discovered nodes, but can't find a way to list only those which
 are logged in and therefore available.

iscsiadm -m session

Will do it.

 
 

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
open-iscsi group.
To post to this group, send email to open-iscsi@googlegroups.com
To unsubscribe from this group, send email to 
open-iscsi+unsubscr...@googlegroups.com
For more options, visit this group at http://groups.google.com/group/open-iscsi
-~--~~~~--~~--~--~---



Re: connection, host resets, I/O errors eventually (DRBD, but not only)

2009-01-08 Thread Mike Christie

Tomasz Chmielewski wrote:
 Anyone using iSCSI over DRBD? And a slow internet link perhaps?
 
 If yes, you are likely to see connection errors, host resets, and eventually,
 I/O errors reported, for example:
 
 Jan  7 21:47:09 vmware1 kernel:  connection23:0: iscsi: detected conn error 
 (1011)
 Jan  7 21:47:10 vmware1 kernel: iscsi: host reset succeeded
 Jan  7 21:47:50 vmware1 kernel:  connection23:0: iscsi: detected conn error 
 (1011)
 Jan  7 21:47:50 vmware1 kernel: iscsi: host reset succeeded
 Jan  7 21:48:00 vmware1 kernel: sd 22:0:0:1: SCSI error: return code = 
 0x0002
 Jan  7 21:48:00 vmware1 kernel: end_request: I/O error, dev sdw, sector 
 1494720
 Jan  7 21:48:00 vmware1 kernel: Buffer I/O error on device sdw, logical block 
 186840
 Jan  7 21:48:00 vmware1 kernel: lost page write due to I/O error on sdw
 
 
 This is due to the fact that open-iscsi doesn't seem to like low-speed (but 
 stable)
 connections to the target.
 
 To reproduce:
 
 1) set up a connection with limited speed between the target and the 
 initiator,
 for example, with openvpn, one would use --shaper 5 option to limit the 
 speed
 to 50 kB/s.
 
 2) login the target to the initiator over this connection (can be also in LAN)
 
 3) start reading and writing... after some time you will be seeing connection 
 errors and 
 host resets followed by I/O errors, possibly data corruption
 
 
 A harder way to reproduce (but somehow more realistic) would be to set up 
 DRBD,
 start background synchronization at high speed (thus leaving not much 
 bandwidth for
 normal writes), start reading and writing...
 
 
 I can reproduce it with tgtd and IET, so I guess open-iscsi is to be blamed.
 
 Ideas what's wrong and why it fails?
 

The scsi layer sets a timeout on each command. If it does not execute in 
X seconds, it will run the iscsi eh.

So you can increase the scsi command time:

To modify the udev rule open /etc/udev/rules.d/50-udev.rules, and find the
following lines:

ACTION==add, SUBSYSTEM==scsi , SYSFS{type}==0|7|14, \
 RUN+=/bin/sh -c 'echo 60  /sys$$DEVPATH/timeout'


and you probably want to decrease the number of oustanding commands by 
setting the node.session.cmds_max for that session. With 50 kB/s you 
might as well set this to 1 command.

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
open-iscsi group.
To post to this group, send email to open-iscsi@googlegroups.com
To unsubscribe from this group, send email to 
open-iscsi+unsubscr...@googlegroups.com
For more options, visit this group at http://groups.google.com/group/open-iscsi
-~--~~~~--~~--~--~---



multipathd: sdc: readsector0 checker reports path is down

2009-01-08 Thread Ray Van Dolson

I'm still getting the hang of iSCSI and multipath, so bear with me if
this is a FAQ that I've missed...

I have a host attaching to an MD3000i via iSCSI/dm-multipath that is
working but showing a lot of the following errors in syslog:

  multipathd: sdc: readsector0 checker reports path is down

My initial impression is that sdc is likely the passive path (for
failover) whereas sdd is my active path:

  # multipath -ll
  sdc: checker msg is readsector0 checker reports path is down
  mpath2 (36001ec9000f33837) dm-2 DELL,Universal Xport
  [size=20M][features=0][hwhandler=0]
  \_ round-robin 0 [prio=0][enabled]
   \_ 4:0:0:31 sdf 8:80  [active][ready] 
  mpath1 (36001ec9000f337dd) dm-1 DELL,Universal Xport
  [size=20M][features=0][hwhandler=0]
  \_ round-robin 0 [prio=0][enabled]
   \_ 3:0:0:31 sde 8:64  [active][ready] 
  mpath0 (36001ec9000f337dd065b491854a4) dm-0 DELL,MD3000i
  [size=150G][features=0][hwhandler=1 rdac]
  \_ round-robin 0 [prio=3][active]
   \_ 3:0:0:0  sdd 8:48  [active][ready] 
  \_ round-robin 0 [prio=0][enabled]
   \_ 4:0:0:0  sdc 8:32  [failed][faulty]

  # iscsiadm -m discovery -t sendtargets -p 192.168.132.101:3260
  0.0.0.0:3260,1 
iqn.1984-05.com.dell:powervault.6001ec9000f337dd48bdc862
  0.0.0.0:3260,2 
iqn.1984-05.com.dell:powervault.6001ec9000f337dd48bdc862
  192.168.132.101:3260,1 
iqn.1984-05.com.dell:powervault.6001ec9000f337dd48bdc862
  192.168.132.102:3260,2 
iqn.1984-05.com.dell:powervault.6001ec9000f337dd48bdc862

  # iscsiadm -m session -P 1
  Target: iqn.1984-05.com.dell:powervault.6001ec9000f337dd48bdc862
Current Portal: 192.168.132.101:3260,1
Persistent Portal: 192.168.132.101:3260,1
  **
  Interface:
  **
  Iface Name: default
  Iface Transport: tcp
  Iface Initiatorname: iqn.1994-05.com.redhat:2738e0d3bd21
  Iface IPaddress: 192.168.132.202
  Iface HWaddress: default
  Iface Netdev: default
  SID: 1
  iSCSI Connection State: LOGGED IN
  iSCSI Session State: Unknown
  Internal iscsid Session State: NO CHANGE
Current Portal: 192.168.132.102:3260,2
Persistent Portal: 192.168.132.102:3260,2
  **
  Interface:
  **
  Iface Name: default
  Iface Transport: tcp
  Iface Initiatorname: iqn.1994-05.com.redhat:2738e0d3bd21
  Iface IPaddress: 192.168.132.202
  Iface HWaddress: default
  Iface Netdev: default
  SID: 2
  iSCSI Connection State: LOGGED IN
  iSCSI Session State: Unknown
  Internal iscsid Session State: NO CHANGE

sde and sdf are the silly 20MB partition that the MD3000 creates and
I'm not using either.

My ultimate goal is to not have so many of the path is down errors
showing up in my syslog file (hundreds and hundreds of them).  I'm not
sure if their presence is normal (indicative of a passive path) or
indicative of a problem.

Also, I'm not clear as to how I should identify which target
corresponds with which drive (sdc or sdd).

Any thoughts?  I don't have direct access to the MD3000i
unfortunately... this is from a CentOS 5.2 system btw.

Ray

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
open-iscsi group.
To post to this group, send email to open-iscsi@googlegroups.com
To unsubscribe from this group, send email to 
open-iscsi+unsubscr...@googlegroups.com
For more options, visit this group at http://groups.google.com/group/open-iscsi
-~--~~~~--~~--~--~---



Re: multipathd: sdc: readsector0 checker reports path is down

2009-01-08 Thread Chandra Seetharaman


On Thu, 2009-01-08 at 11:31 -0800, Ray Van Dolson wrote:
 I'm still getting the hang of iSCSI and multipath, so bear with me if
 this is a FAQ that I've missed...
 
 I have a host attaching to an MD3000i via iSCSI/dm-multipath that is
 working but showing a lot of the following errors in syslog:
 
   multipathd: sdc: readsector0 checker reports path is down
you should be using the rdac path checker. In addition to that you
should be using rdac hardware handler and tpc priority checker.

If you have and entry for your MD3000i in /etc/multipath.conf, replace
it with this. If not add this
---
devices {
device {
vendor  DELL
product MD3000i
hardware_handler1 rdac
path_checkerrdac
failbackimmediate
path_grouping_policygroup_by_prio
no_path_retry   queue
prio_callout/sbin/mpath_prio_tpc /dev/%n
}
}
-

After this change you have to do:
- multipath -F
- service multipathd restart

Let me know how it goes.
 
 My initial impression is that sdc is likely the passive path (for
 failover) whereas sdd is my active path:

yes.

 
   # multipath -ll
   sdc: checker msg is readsector0 checker reports path is down
   mpath2 (36001ec9000f33837) dm-2 DELL,Universal Xport
   [size=20M][features=0][hwhandler=0]
   \_ round-robin 0 [prio=0][enabled]
\_ 4:0:0:31 sdf 8:80  [active][ready] 
   mpath1 (36001ec9000f337dd) dm-1 DELL,Universal Xport
   [size=20M][features=0][hwhandler=0]
   \_ round-robin 0 [prio=0][enabled]
\_ 3:0:0:31 sde 8:64  [active][ready] 
   mpath0 (36001ec9000f337dd065b491854a4) dm-0 DELL,MD3000i
   [size=150G][features=0][hwhandler=1 rdac]
   \_ round-robin 0 [prio=3][active]
\_ 3:0:0:0  sdd 8:48  [active][ready] 
   \_ round-robin 0 [prio=0][enabled]
\_ 4:0:0:0  sdc 8:32  [failed][faulty]
 
   # iscsiadm -m discovery -t sendtargets -p 192.168.132.101:3260
   0.0.0.0:3260,1 
 iqn.1984-05.com.dell:powervault.6001ec9000f337dd48bdc862
   0.0.0.0:3260,2 
 iqn.1984-05.com.dell:powervault.6001ec9000f337dd48bdc862
   192.168.132.101:3260,1 
 iqn.1984-05.com.dell:powervault.6001ec9000f337dd48bdc862
   192.168.132.102:3260,2 
 iqn.1984-05.com.dell:powervault.6001ec9000f337dd48bdc862
 
   # iscsiadm -m session -P 1
   Target: iqn.1984-05.com.dell:powervault.6001ec9000f337dd48bdc862
 Current Portal: 192.168.132.101:3260,1
 Persistent Portal: 192.168.132.101:3260,1
   **
   Interface:
   **
   Iface Name: default
   Iface Transport: tcp
   Iface Initiatorname: iqn.1994-05.com.redhat:2738e0d3bd21
   Iface IPaddress: 192.168.132.202
   Iface HWaddress: default
   Iface Netdev: default
   SID: 1
   iSCSI Connection State: LOGGED IN
   iSCSI Session State: Unknown
   Internal iscsid Session State: NO CHANGE
 Current Portal: 192.168.132.102:3260,2
 Persistent Portal: 192.168.132.102:3260,2
   **
   Interface:
   **
   Iface Name: default
   Iface Transport: tcp
   Iface Initiatorname: iqn.1994-05.com.redhat:2738e0d3bd21
   Iface IPaddress: 192.168.132.202
   Iface HWaddress: default
   Iface Netdev: default
   SID: 2
   iSCSI Connection State: LOGGED IN
   iSCSI Session State: Unknown
   Internal iscsid Session State: NO CHANGE
 
 sde and sdf are the silly 20MB partition that the MD3000 creates and
 I'm not using either.
 
 My ultimate goal is to not have so many of the path is down errors
 showing up in my syslog file (hundreds and hundreds of them).  I'm not
 sure if their presence is normal (indicative of a passive path) or
 indicative of a problem.
 
 Also, I'm not clear as to how I should identify which target
 corresponds with which drive (sdc or sdd).
 
 Any thoughts?  I don't have direct access to the MD3000i
 unfortunately... this is from a CentOS 5.2 system btw.
 
 Ray
 
  


--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
open-iscsi group.
To post to this group, send email to open-iscsi@googlegroups.com
To unsubscribe from this group, send email to 
open-iscsi+unsubscr...@googlegroups.com
For more options, visit this group at http://groups.google.com/group/open-iscsi
-~--~~~~--~~--~--~---



Re: [dm-devel] multipathd: sdc: readsector0 checker reports path is down

2009-01-08 Thread Konrad Rzeszutek

On Thu, Jan 08, 2009 at 11:31:38AM -0800, Ray Van Dolson wrote:
 I'm still getting the hang of iSCSI and multipath, so bear with me if
 this is a FAQ that I've missed...
 
 I have a host attaching to an MD3000i via iSCSI/dm-multipath that is
 working but showing a lot of the following errors in syslog:
 
   multipathd: sdc: readsector0 checker reports path is down

You are using the wrong path checker, wrong path priority program,
and no hardware path checker :-(

Here is what you need in your multipath.conf file:

 #   
# DELL :D3000i :: Active-Passive RDAC
# Note: The same as the IBM DS3300
#   
device {
vendor  DELL
product MD3000i
product_blacklist   Universal Xport
features1 queue_if_no_path
path_grouping_policygroup_by_prio
hardware_handler1 rdac
path_checkerrdac
priordac
failbackimmediate
}   


Thought you might need to replace the 'prio rdac' with
'prio_callout   /sbin/mpath_prio_rdac as I think RHEL5/CentOS5 uses
the old calling convention.

This should get rid of your down errors and show your passive/active path
properly.

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
open-iscsi group.
To post to this group, send email to open-iscsi@googlegroups.com
To unsubscribe from this group, send email to 
open-iscsi+unsubscr...@googlegroups.com
For more options, visit this group at http://groups.google.com/group/open-iscsi
-~--~~~~--~~--~--~---



Re: multipathd: sdc: readsector0 checker reports path is down

2009-01-08 Thread Ray Van Dolson

On Thu, Jan 08, 2009 at 11:58:52AM -0800, Chandra Seetharaman wrote:
 
 
 On Thu, 2009-01-08 at 11:31 -0800, Ray Van Dolson wrote:
  I'm still getting the hang of iSCSI and multipath, so bear with me if
  this is a FAQ that I've missed...
  
  I have a host attaching to an MD3000i via iSCSI/dm-multipath that is
  working but showing a lot of the following errors in syslog:
  
multipathd: sdc: readsector0 checker reports path is down
 you should be using the rdac path checker. In addition to that you
 should be using rdac hardware handler and tpc priority checker.
 
 If you have and entry for your MD3000i in /etc/multipath.conf, replace
 it with this. If not add this
 ---
 devices {
 device {
 vendor  DELL
 product MD3000i
 hardware_handler1 rdac
 path_checkerrdac
 failbackimmediate
 path_grouping_policygroup_by_prio
 no_path_retry   queue
 prio_callout/sbin/mpath_prio_tpc /dev/%n
 }
 }
 -
 
 After this change you have to do:
 - multipath -F
 - service multipathd restart
 
 Let me know how it goes.

This appears to have done the trick.  So, I guess the default path
checker is readsector0 and rdac is another method -- I imagine it
directly talks to my MD3000i to determine path status?

  
  My initial impression is that sdc is likely the passive path (for
  failover) whereas sdd is my active path:
 
 yes.

Thanks much!

Ray

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
open-iscsi group.
To post to this group, send email to open-iscsi@googlegroups.com
To unsubscribe from this group, send email to 
open-iscsi+unsubscr...@googlegroups.com
For more options, visit this group at http://groups.google.com/group/open-iscsi
-~--~~~~--~~--~--~---



Re: [dm-devel] Re: multipathd: sdc: readsector0 checker reports path is down

2009-01-08 Thread Chandra Seetharaman


On Thu, 2009-01-08 at 12:10 -0800, Ray Van Dolson wrote:
 On Thu, Jan 08, 2009 at 11:58:52AM -0800, Chandra Seetharaman wrote:
  
  
  On Thu, 2009-01-08 at 11:31 -0800, Ray Van Dolson wrote:
   I'm still getting the hang of iSCSI and multipath, so bear with me if
   this is a FAQ that I've missed...
   
   I have a host attaching to an MD3000i via iSCSI/dm-multipath that is
   working but showing a lot of the following errors in syslog:
   
 multipathd: sdc: readsector0 checker reports path is down
  you should be using the rdac path checker. In addition to that you
  should be using rdac hardware handler and tpc priority checker.
  
  If you have and entry for your MD3000i in /etc/multipath.conf, replace
  it with this. If not add this
  ---
  devices {
  device {
  vendor  DELL
  product MD3000i
  hardware_handler1 rdac
  path_checkerrdac
  failbackimmediate
  path_grouping_policygroup_by_prio
  no_path_retry   queue
  prio_callout/sbin/mpath_prio_tpc /dev/%n
  }
  }
  -
  
  After this change you have to do:
  - multipath -F
  - service multipathd restart
  
  Let me know how it goes.
 
 This appears to have done the trick.  So, I guess the default path
 checker is readsector0 and rdac is another method -- I imagine it
 directly talks to my MD3000i to determine path status?

Yes, it sends a C9 inquiry to the storage controller and determines the
state.
 
   
   My initial impression is that sdc is likely the passive path (for
   failover) whereas sdd is my active path:
  
  yes.
 
 Thanks much!
 
 Ray
 
 --
 dm-devel mailing list
 dm-de...@redhat.com
 https://www.redhat.com/mailman/listinfo/dm-devel


--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
open-iscsi group.
To post to this group, send email to open-iscsi@googlegroups.com
To unsubscribe from this group, send email to 
open-iscsi+unsubscr...@googlegroups.com
For more options, visit this group at http://groups.google.com/group/open-iscsi
-~--~~~~--~~--~--~---



[PATCH] iscsi_tcp - make padbuf non-static

2009-01-08 Thread Karen Xie

[PATCH] iscsi_tcp - make padbuf non-static

From: Karen Xie k...@chelsio.com

virt_to_page() call should not be used on kernel text and data addresses.
virt_to_page() is used by sg_init_one(). So change padbuf to be allocated 
within iscsi_segment.

Signed-off-by: Karen Xie k...@chelsio.com
---

 drivers/scsi/iscsi_tcp.c |3 +--
 drivers/scsi/iscsi_tcp.h |1 +
 2 files changed, 2 insertions(+), 2 deletions(-)


diff --git a/drivers/scsi/iscsi_tcp.c b/drivers/scsi/iscsi_tcp.c
index ed6c54c..3b07868 100644
--- a/drivers/scsi/iscsi_tcp.c
+++ b/drivers/scsi/iscsi_tcp.c
@@ -190,7 +190,6 @@ iscsi_tcp_segment_splice_digest(struct iscsi_segment 
*segment, void *digest)
 static inline int
 iscsi_tcp_segment_done(struct iscsi_segment *segment, int recv, unsigned 
copied)
 {
-   static unsigned char padbuf[ISCSI_PAD_LEN];
struct scatterlist sg;
unsigned int pad;
 
@@ -245,7 +244,7 @@ iscsi_tcp_segment_done(struct iscsi_segment *segment, int 
recv, unsigned copied)
debug_tcp(consume %d pad bytes\n, pad);
segment-total_size += pad;
segment-size = pad;
-   segment-data = padbuf;
+   segment-data = segment-padbuf;
return 0;
}
 
diff --git a/drivers/scsi/iscsi_tcp.h b/drivers/scsi/iscsi_tcp.h
index 498d8ca..a906db2 100644
--- a/drivers/scsi/iscsi_tcp.h
+++ b/drivers/scsi/iscsi_tcp.h
@@ -40,6 +40,7 @@ struct iscsi_segment {
unsigned inttotal_copied;
 
struct hash_desc*hash;
+   unsigned char   padbuf[ISCSI_PAD_LEN];
unsigned char   recv_digest[ISCSI_DIGEST_SIZE];
unsigned char   digest[ISCSI_DIGEST_SIZE];
unsigned intdigest_len;

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
open-iscsi group.
To post to this group, send email to open-iscsi@googlegroups.com
To unsubscribe from this group, send email to 
open-iscsi+unsubscr...@googlegroups.com
For more options, visit this group at http://groups.google.com/group/open-iscsi
-~--~~~~--~~--~--~---



Re: [PATCH] iscsi_tcp - make padbuf non-static

2009-01-08 Thread Mike Christie

Karen Xie wrote:
 [PATCH] iscsi_tcp - make padbuf non-static
 
 From: Karen Xie k...@chelsio.com
 
 virt_to_page() call should not be used on kernel text and data addresses.
 virt_to_page() is used by sg_init_one(). So change padbuf to be allocated 
 within iscsi_segment.
 
 Signed-off-by: Karen Xie k...@chelsio.com


Thanks for finding this.

Acked-by: Mike Christie micha...@cs.wisc.edu

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
open-iscsi group.
To post to this group, send email to open-iscsi@googlegroups.com
To unsubscribe from this group, send email to 
open-iscsi+unsubscr...@googlegroups.com
For more options, visit this group at http://groups.google.com/group/open-iscsi
-~--~~~~--~~--~--~---