RE: [PATCH] fix conn context data pointer
-Original Message- From: open-iscsi@googlegroups.com [mailto:open-is...@googlegroups.com] On Behalf Of Mike Christie Sent: Thursday, June 25, 2009 8:57 PM To: open-iscsi@googlegroups.com Cc: Chenault, Thomas; thomas.weyerg...@net-m.de Subject: Re: [PATCH] fix conn context data pointer On 06/25/2009 12:47 AM, shyam_i...@dell.com wrote: Establish a connection to an MD3000i (use CHAP and Rev. CHAP) - Disconnect the iSCSI session iscsiadm -m node -pip_addr -Tiqn -u - Reconnect the iSCSI session iscsiadm -m node -pip_addr -Tiqn -l -Fails because iscsid gets killed Signed-off-by: Thomas Chenaultthomas_chena...@dell.com Tested-by: Shyam Iyershyam_i...@dell.com diff --git a/usr/initiator.c b/usr/initiator.c index 8e4ea6b..c29f5fb 100644 --- a/usr/initiator.c +++ b/usr/initiator.c @@ -127,7 +127,7 @@ struct iscsi_conn_context *iscsi_conn_co sizeof(struct actor)); conn_context-allocated = 1; /* some callers abuse this pointer */ - conn_context-data = conn_context + + conn_context-data = (void *)conn_context + sizeof(struct iscsi_conn_context); log_debug(7, get conn context %p, conn_context-actor); Does this fix your segfault with iscsistart too? Yes it fixes the segfault with iscsistart too. Thanks for reminding that. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups open-iscsi group. To post to this group, send email to open-iscsi@googlegroups.com To unsubscribe from this group, send email to open-iscsi+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/open-iscsi -~--~~~~--~~--~--~---
RE: [PATCH] fix conn context data pointer
Mike Christie wrote: diff --git a/usr/initiator.c b/usr/initiator.c index 8e4ea6b..c29f5fb 100644 --- a/usr/initiator.c +++ b/usr/initiator.c @@ -127,7 +127,7 @@ struct iscsi_conn_context *iscsi_conn_co sizeof(struct actor)); conn_context-allocated = 1; /* some callers abuse this pointer */ -conn_context-data = conn_context + +conn_context-data = (void *)conn_context + sizeof(struct iscsi_conn_context); log_debug(7, get conn context %p, conn_context-actor); Does this fix your segfault with iscsistart too? Thomas, could you try this patch? Mike, I am not certain which Thomas you were addressing. I was aware of an iscsistart segfault at the time this patch was created and I was convinced that this patch resolved it. Thomas --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups open-iscsi group. To post to this group, send email to open-iscsi@googlegroups.com To unsubscribe from this group, send email to open-iscsi+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/open-iscsi -~--~~~~--~~--~--~---
Re: [PATCH] fix conn context data pointer
On 06/25/2009 12:47 AM, shyam_i...@dell.com wrote: Establish a connection to an MD3000i (use CHAP and Rev. CHAP) - Disconnect the iSCSI session iscsiadm -m node -pip_addr -Tiqn -u - Reconnect the iSCSI session iscsiadm -m node -pip_addr -Tiqn -l -Fails because iscsid gets killed Signed-off-by: Thomas Chenaultthomas_chena...@dell.com Tested-by: Shyam Iyershyam_i...@dell.com diff --git a/usr/initiator.c b/usr/initiator.c index 8e4ea6b..c29f5fb 100644 --- a/usr/initiator.c +++ b/usr/initiator.c @@ -127,7 +127,7 @@ struct iscsi_conn_context *iscsi_conn_co sizeof(struct actor)); conn_context-allocated = 1; /* some callers abuse this pointer */ - conn_context-data = conn_context + + conn_context-data = (void *)conn_context + sizeof(struct iscsi_conn_context); log_debug(7, get conn context %p, conn_context-actor); Merged in b176b84381ed92152f7d471d19642f1a3ac3f7f3 Thanks for the work on this issue. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups open-iscsi group. To post to this group, send email to open-iscsi@googlegroups.com To unsubscribe from this group, send email to open-iscsi+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/open-iscsi -~--~~~~--~~--~--~---
Re: [PATCH] fix conn context data pointer
On 06/25/2009 12:47 AM, shyam_i...@dell.com wrote: Establish a connection to an MD3000i (use CHAP and Rev. CHAP) - Disconnect the iSCSI session iscsiadm -m node -pip_addr -Tiqn -u - Reconnect the iSCSI session iscsiadm -m node -pip_addr -Tiqn -l -Fails because iscsid gets killed Signed-off-by: Thomas Chenaultthomas_chena...@dell.com Tested-by: Shyam Iyershyam_i...@dell.com diff --git a/usr/initiator.c b/usr/initiator.c index 8e4ea6b..c29f5fb 100644 --- a/usr/initiator.c +++ b/usr/initiator.c @@ -127,7 +127,7 @@ struct iscsi_conn_context *iscsi_conn_co sizeof(struct actor)); conn_context-allocated = 1; /* some callers abuse this pointer */ - conn_context-data = conn_context + + conn_context-data = (void *)conn_context + sizeof(struct iscsi_conn_context); log_debug(7, get conn context %p, conn_context-actor); Does this fix your segfault with iscsistart too? Thomas, could you try this patch? --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups open-iscsi group. To post to this group, send email to open-iscsi@googlegroups.com To unsubscribe from this group, send email to open-iscsi+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/open-iscsi -~--~~~~--~~--~--~---
[PATCH] fix conn context data pointer
Establish a connection to an MD3000i (use CHAP and Rev. CHAP) - Disconnect the iSCSI session iscsiadm -m node -p ip_addr -T iqn -u - Reconnect the iSCSI session iscsiadm -m node -p ip_addr -T iqn -l -Fails because iscsid gets killed Signed-off-by: Thomas Chenault thomas_chena...@dell.com Tested-by: Shyam Iyer shyam_i...@dell.com diff --git a/usr/initiator.c b/usr/initiator.c index 8e4ea6b..c29f5fb 100644 --- a/usr/initiator.c +++ b/usr/initiator.c @@ -127,7 +127,7 @@ struct iscsi_conn_context *iscsi_conn_co sizeof(struct actor)); conn_context-allocated = 1; /* some callers abuse this pointer */ - conn_context-data = conn_context + + conn_context-data = (void *)conn_context + sizeof(struct iscsi_conn_context); log_debug(7, get conn context %p, conn_context-actor); --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups open-iscsi group. To post to this group, send email to open-iscsi@googlegroups.com To unsubscribe from this group, send email to open-iscsi+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/open-iscsi -~--~~~~--~~--~--~--- fix_conn_context_data_pointer Description: fix_conn_context_data_pointer
