Re: [PATCH 0/3 ver2] iscsi bidi & varlen support
On Mon, Feb 18 2008 at 19:22 +0200, James Bottomley <[EMAIL PROTECTED]> wrote: > On Mon, 2008-02-18 at 17:08 +0200, Boaz Harrosh wrote: >> But ... James? is >> there any chance these can go into scsi-rc-fixes for the 2.6.25 >> kernel? The reason they are so late was mainly because of a fallout >> in the merge process and a bug that was introduced because of that, >> but they were intended to go together with bidi into 2.6.25. Also >> as an important client code to the bidi-api that is introduced in >> 2.6.25 kernel. > > Well, I think you know the answer to that one under Linus' rules for non > merge window submission. It's not a bug fix; we haven't even put it > into -mm for testing and it's a pretty invasive change. > > James > > It was extensively tested by all iscsi people. It has the Sign-off-by of the iscsi maintainer. They are not new patches. But, yes you are right. I now remember the trouble we had with Linus last time. So it's 2.6.26 then. :-( . People that need it for 2.6.25 will just get it off the git tree. Boaz --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "open-iscsi" group. To post to this group, send email to open-iscsi@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/open-iscsi -~--~~~~--~~--~--~---
Re: [PATCH 0/3 ver2] iscsi bidi & varlen support
On Mon, 2008-02-18 at 17:08 +0200, Boaz Harrosh wrote: > But ... James? is > there any chance these can go into scsi-rc-fixes for the 2.6.25 > kernel? The reason they are so late was mainly because of a fallout > in the merge process and a bug that was introduced because of that, > but they were intended to go together with bidi into 2.6.25. Also > as an important client code to the bidi-api that is introduced in > 2.6.25 kernel. Well, I think you know the answer to that one under Linus' rules for non merge window submission. It's not a bug fix; we haven't even put it into -mm for testing and it's a pretty invasive change. James --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "open-iscsi" group. To post to this group, send email to open-iscsi@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/open-iscsi -~--~~~~--~~--~--~---
[PATCH 0/3 ver2] iscsi bidi & varlen support
On Thu, Jan 31 2008 at 20:08 +0200, Boaz Harrosh <[EMAIL PROTECTED]> wrote: > Cheers after 1.3 years these can go in. > > [PATCH 1/3] iscsi: extended cdb support >The varlen support is not yet in mainline for > block and scsi-ml. But the API for drivers will > not change. All LLD need to do is max_command to > the it's maximum and be ready for bigger commands. > This is what's done here. Once these commands start > coming iscsi will be ready for them. > > [PATCH 2/3] iscsi: bidi support - libiscsi > [PATCH 3/3] iscsi: bidi support - iscsi_tcp > bidirectional commands support in iscsi. > iSER is not yet ready, but it will not break. > There is already a mechanism in libiscsi that will > return error if bidi commands are sent iSER way. > > Pete please send me the iSER bits so we can port them > to this latest version. > > Mike these patches are ontop of iscs branch of the iscsi > git tree, they will apply but for compilation you will need > to sync with Linus mainline. The patches are for the in-tree > iscsi code. I own you the compat patch for the out-off-tree > code, but this I will only be Sunday. > > If we do it fast it might get accepted to 2.6.25 merge window > > Everybody is invited to a party at Shila ben-yhuda 52 Tel-Aviv > 9:45 pm. Drinks and wonderful see-food on us :) > > Boaz > > - Everything the same as before. But working this time. Also Pete's comment about second patch, was correct and code is now fixed. I have got Mike's Signed-off-by, on these they were tested and approved by him. So they are for scsi-misc. But ... James? is there any chance these can go into scsi-rc-fixes for the 2.6.25 kernel? The reason they are so late was mainly because of a fallout in the merge process and a bug that was introduced because of that, but they were intended to go together with bidi into 2.6.25. Also as an important client code to the bidi-api that is introduced in 2.6.25 kernel. Thanks Boaz --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "open-iscsi" group. To post to this group, send email to open-iscsi@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/open-iscsi -~--~~~~--~~--~--~---
