Antw: [PATCH 4/5] iscsiuio CFLAGS fixes

2015-01-14 Thread Ulrich Windl
 Ulrich Windl ulrich.wi...@rz.uni-regensburg.de schrieb am 14.01.2015 um
08:45 in Nachricht 54b62c9d02a100018...@gwsmtp1.uni-regensburg.de:
 Chris Leech cle...@redhat.com schrieb am 12.01.2015 um 20:24 in Nachricht
 1421090651-8333-5-git-send-email-cle...@redhat.com:
 try and keep existing CFLAGS from environment for packagers
 ---
  iscsiuio/configure.ac | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
 
 diff --git a/iscsiuio/configure.ac b/iscsiuio/configure.ac
 index d619598..7ee1e73 100644
 --- a/iscsiuio/configure.ac
 +++ b/iscsiuio/configure.ac
 @@ -53,7 +53,7 @@ AC_LIBTOOL_DLOPEN
  # libtool stuff
  AC_PROG_LIBTOOL
  
 -CFLAGS=-O2 -Wall
 +CFLAGS=${CFLAGS} -O2 -Wall
 
 Don't you have to use either += or := for that? See 6.6 Appending More 
 Text to Variables in the GNU make info...

Sorry, I didn't look close: It's autoconfigure, not Make...


-- 
You received this message because you are subscribed to the Google Groups 
open-iscsi group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to open-iscsi+unsubscr...@googlegroups.com.
To post to this group, send email to open-iscsi@googlegroups.com.
Visit this group at http://groups.google.com/group/open-iscsi.
For more options, visit https://groups.google.com/d/optout.


Antw: [PATCH 4/5] iscsiuio CFLAGS fixes

2015-01-13 Thread Ulrich Windl
 Chris Leech cle...@redhat.com schrieb am 12.01.2015 um 20:24 in Nachricht
1421090651-8333-5-git-send-email-cle...@redhat.com:
 try and keep existing CFLAGS from environment for packagers
 ---
  iscsiuio/configure.ac | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
 
 diff --git a/iscsiuio/configure.ac b/iscsiuio/configure.ac
 index d619598..7ee1e73 100644
 --- a/iscsiuio/configure.ac
 +++ b/iscsiuio/configure.ac
 @@ -53,7 +53,7 @@ AC_LIBTOOL_DLOPEN
  # libtool stuff
  AC_PROG_LIBTOOL
  
 -CFLAGS=-O2 -Wall
 +CFLAGS=${CFLAGS} -O2 -Wall

Don't you have to use either += or := for that? See 6.6 Appending More 
Text to Variables in the GNU make info...


  ## check for --enable-debug first before checking CFLAGS before
  ## so that we don't mix -O and -g
  AC_ARG_ENABLE(debug,
 -- 
 2.1.0
 
 -- 
 You received this message because you are subscribed to the Google Groups 
 open-iscsi group.
 To unsubscribe from this group and stop receiving emails from it, send an 
 email to open-iscsi+unsubscr...@googlegroups.com.
 To post to this group, send email to open-iscsi@googlegroups.com.
 Visit this group at http://groups.google.com/group/open-iscsi.
 For more options, visit https://groups.google.com/d/optout.




-- 
You received this message because you are subscribed to the Google Groups 
open-iscsi group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to open-iscsi+unsubscr...@googlegroups.com.
To post to this group, send email to open-iscsi@googlegroups.com.
Visit this group at http://groups.google.com/group/open-iscsi.
For more options, visit https://groups.google.com/d/optout.