Re: [PATCH v4] iscsi: Perform connection failure entirely in kernel space
On Wednesday, January 15, 2020 at 7:52:39 PM UTC-8, Martin K. Petersen wrote: > > > > Please consider the v4 below with the lock added. > > Lee: Please re-review this given the code change. > Martin: The recent change makes sense, so please still include my: Reviewed-by: Lee Duncan > > > From: Bharath Ravi > > > > Connection failure processing depends on a daemon being present to (at > > least) stop the connection and start recovery. This is a problem on a > > multipath scenario, where if the daemon failed for whatever reason, the > > SCSI path is never marked as down, multipath won't perform the > > failover and IO to the device will be forever waiting for that > > connection to come back. > > > > This patch performs the connection failure entirely inside the kernel. > > This way, the failover can happen and pending IO can continue even if > > the daemon is dead. Once the daemon comes alive again, it can execute > > recovery procedures if applicable. > > -- > Martin K. PetersenOracle Linux Engineering > -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/open-iscsi/1ece4cbc-29df-4b10-952d-a8d829e24e6f%40googlegroups.com.
Re: [PATCH v4] iscsi: Perform connection failure entirely in kernel space
> Please consider the v4 below with the lock added. Lee: Please re-review this given the code change. > From: Bharath Ravi > > Connection failure processing depends on a daemon being present to (at > least) stop the connection and start recovery. This is a problem on a > multipath scenario, where if the daemon failed for whatever reason, the > SCSI path is never marked as down, multipath won't perform the > failover and IO to the device will be forever waiting for that > connection to come back. > > This patch performs the connection failure entirely inside the kernel. > This way, the failover can happen and pending IO can continue even if > the daemon is dead. Once the daemon comes alive again, it can execute > recovery procedures if applicable. -- Martin K. Petersen Oracle Linux Engineering -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/open-iscsi/yq1tv4wnjm2.fsf%40oracle.com.
Re: [PATCH v4] iscsi: Perform connection failure entirely in kernel space
On Fri, Jan 3, 2020 at 2:26 PM Gabriel Krisman Bertazi wrote: > Please consider the v4 below with the lock added. > Reviewed-by: Khazhismel Kumykov -- You received this message because you are subscribed to the Google Groups "open-iscsi" group. To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/open-iscsi/CACGdZYKsGk-kD7aO%3DbCSUzsFkX12xPkB3D2XDYGgDE4gD%2B1cmA%40mail.gmail.com. smime.p7s Description: S/MIME Cryptographic Signature
