Re: [Openais] [PATCH] Add options to cfg service
Committed revision 1683. with the fixes note below. Chrissie Steven Dake wrote: > Call api->fatal_error instead of exit. > > make sure comments that are one liners use the format > /* > * comment > */ > > then good for commit > > regards > -steve > > On Wed, 2008-10-29 at 11:57 +, Christine Caulfield wrote: >> This patch adds two extra features to the CFG service in corosync, these >> are taken (conceptually at least) from cman. >> >> 1. corosync_cfg_killnode()this will tell a remote node to exit. >> 2. corosync_cfg_tryshutdown() this will do a semi-controlled shutdown in >> that it will consult any interested attached daemons if they are willing >> to let corosync be shut down. If they all agree then the rest of the >> cluster will be informed before the node dies. >> >> I have simply called exit(100) in this patch, there might (I hope) be a >> better way of shutting down corosync! >> >> Oh, and I apologise for the whitespace changes on some of the existing lines ___ Openais mailing list Openais@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/openais
Re: [Openais] [whitetank openais / corosync trunk] patch to fixup commit token
This patch causes the range calculated in messages_deliver_to_app() to be negative in some circumstances (which triggers an assert). The cases I've seen involve end_point being zero and instance->my_high_delivered being positive. The following patch appears to resolve the issue (ie. it allows range to be negative instead of "really really positive") but may not be 100% correct. --- a/exec/totemsrp.c Thu Oct 30 08:55:51 2008 +0100 +++ b/exec/totemsrp.c Fri Oct 31 10:25:13 2008 +0100 @@ -3427,7 +3460,7 @@ static void messages_deliver_to_app ( int res; struct mcast *mcast_in; struct mcast mcast_header; - unsigned int range = 0; + int range = 0; int endian_conversion_required; unsigned int my_high_delivered_stored = 0; On Wed, Oct 29, 2008 at 10:51, Steven Dake <[EMAIL PROTECTED]> wrote: > In some circumstances the received_flg of the commit token is not > properly configured. This patch addresses that issue by scanning the > commit token on the first rotation for nodes in the previous ring id > that are improperly set and setting them appropriately. > > Regards > -steve > > ___ > Openais mailing list > Openais@lists.linux-foundation.org > https://lists.linux-foundation.org/mailman/listinfo/openais > ___ Openais mailing list Openais@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/openais
