[Openais] [PATCH] Fix uninitialised memory errors found by valgrind
Signed-off-by: Zane Bitter --- exec/totempg.c |1 + exec/totemsrp.c |1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/exec/totempg.c b/exec/totempg.c index c514453..9188958 100644 --- a/exec/totempg.c +++ b/exec/totempg.c @@ -673,6 +673,7 @@ int callback_token_received_fn (enum totem_callback_token_type type, return (0); } mcast.header.version = 0; + mcast.header.type = 0; mcast.fragmented = 0; /* diff --git a/exec/totemsrp.c b/exec/totemsrp.c index 2d8755c..0c6e82e 100644 --- a/exec/totemsrp.c +++ b/exec/totemsrp.c @@ -2191,6 +2191,7 @@ int totemsrp_mcast ( /* * Set mcast header */ + memset(message_item.mcast, 0, sizeof (struct mcast)); message_item.mcast->header.type = MESSAGE_TYPE_MCAST; message_item.mcast->header.endian_detector = ENDIAN_LOCAL; message_item.mcast->header.encapsulated = MESSAGE_NOT_ENCAPSULATED; ___ Openais mailing list Openais@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/openais
Re: [Openais] Corosync/openais segfault
On 04/07/2011 12:45 PM, Vladislav Bogdanov wrote: > 05.04.2011 19:34, Steven Dake wrote: >> On 04/05/2011 09:53 AM, Vladislav Bogdanov wrote: >>> 05.04.2011 19:41, Steven Dake wrote: This could be one of two things. Either a bug in the lock service around reference counting, or a known issue we have resolved with recursion that causes stack corrution. We will release a new version of 1.3 in the next week or so. >>> >>> Does this mean that current trunk is stable? >> >> The flatiron-1.3 branch has these problems fixed. The flatiron branch >> also has these problems fixed. I am waiting for some third party QE to >> release a z stream in the 1.3 stream. > > Do you mean commit e6597c7a1cd0230428815edf13e175315a2dbd31 (totemsrp: > Remove recv_flush code) in flatiron-1.3? > If not, can you point me to a correct commit in that branch? > > Best, > Vladislav thats the commit regards -steve ___ Openais mailing list Openais@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/openais
Re: [Openais] Corosync/openais segfault
05.04.2011 19:34, Steven Dake wrote: > On 04/05/2011 09:53 AM, Vladislav Bogdanov wrote: >> 05.04.2011 19:41, Steven Dake wrote: >>> This could be one of two things. Either a bug in the lock service >>> around reference counting, or a known issue we have resolved with >>> recursion that causes stack corrution. >>> >>> We will release a new version of 1.3 in the next week or so. >> >> Does this mean that current trunk is stable? > > The flatiron-1.3 branch has these problems fixed. The flatiron branch > also has these problems fixed. I am waiting for some third party QE to > release a z stream in the 1.3 stream. Do you mean commit e6597c7a1cd0230428815edf13e175315a2dbd31 (totemsrp: Remove recv_flush code) in flatiron-1.3? If not, can you point me to a correct commit in that branch? Best, Vladislav ___ Openais mailing list Openais@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/openais
Re: [Openais] Resource start/stop linear dependency
On Thu, Apr 7, 2011 at 9:12 AM, wrote: > Hi, > > I have configured three resource(X,Y,Z) in a one resource-group. > > Order of resource in cib.xml file X then Y then Z. > > No rsc-order constraint is added in the cib.xml file Yes there is - ordering is implied by the use of a group. > > If I stop reource Z then only resource Z is stopped. > > If I start reource Z then only resource Z is startted. > > If I stop reource Y then resource Y and Z are stopped. > > If I start reource Y then resource Y and Z is startted. > > > I want to Start/Stop only resource Y . Then How can I do It. > > Is it supported in any version of pacemaker. > > Cluster Stack > Pacemaker > Heartbeat > > ___ > Openais mailing list > Openais@lists.linux-foundation.org > https://lists.linux-foundation.org/mailman/listinfo/openais > ___ Openais mailing list Openais@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/openais
[Openais] Resource start/stop linear dependency
Hi, I have configured three resource(X,Y,Z) in a one resource-group. Order of resource in cib.xml file X then Y then Z. No rsc-order constraint is added in the cib.xml file If I stop reource Z then only resource Z is stopped. If I start reource Z then only resource Z is startted. If I stop reource Y then resource Y and Z are stopped. If I start reource Y then resource Y and Z is startted. I want to Start/Stop only resource Y . Then How can I do It. Is it supported in any version of pacemaker. Cluster Stack Pacemaker Heartbeat ___ Openais mailing list Openais@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/listinfo/openais
