Re: [Openais] [PATCH] totemsrp: fix buffer overflows for large clusters (> 100 nodes)

[Steven Dake]

Thanks for the submission.

Reviewed-by; Steven Dake 

On 07/24/2011 02:58 AM, MORITA Kazutaka wrote:
> Signed-off-by: MORITA Kazutaka 
> ---
>  exec/totemsrp.c |6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/exec/totemsrp.c b/exec/totemsrp.c
> index 16de74d..e34da1a 100644
> --- a/exec/totemsrp.c
> +++ b/exec/totemsrp.c
> @@ -508,7 +508,7 @@ struct totemsrp_instance {
>   
>   void * token_recv_event_handle;
>   void * token_sent_event_handle;
> - char commit_token_storage[9000];
> + char commit_token_storage[4];
>  };
>  
>  struct message_handlers {
> @@ -2976,7 +2976,7 @@ static void memb_state_commit_token_create (
>  
>  static void memb_join_message_send (struct totemsrp_instance *instance)
>  {
> - char memb_join_data[1];
> + char memb_join_data[4];
>   struct memb_join *memb_join = (struct memb_join *)memb_join_data;
>   char *addr;
>   unsigned int addr_idx;
> @@ -3028,7 +3028,7 @@ static void memb_join_message_send (struct 
> totemsrp_instance *instance)
>  
>  static void memb_leave_message_send (struct totemsrp_instance *instance)
>  {
> - char memb_join_data[1];
> + char memb_join_data[4];
>   struct memb_join *memb_join = (struct memb_join *)memb_join_data;
>   char *addr;
>   unsigned int addr_idx;

___
Openais mailing list
Openais@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/openais

[Openais] [PATCH] totemsrp: fix buffer overflows for large clusters (> 100 nodes)

[MORITA Kazutaka]

Signed-off-by: MORITA Kazutaka 
---
 exec/totemsrp.c |6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/exec/totemsrp.c b/exec/totemsrp.c
index 16de74d..e34da1a 100644
--- a/exec/totemsrp.c
+++ b/exec/totemsrp.c
@@ -508,7 +508,7 @@ struct totemsrp_instance {

void * token_recv_event_handle;
void * token_sent_event_handle;
-   char commit_token_storage[9000];
+   char commit_token_storage[4];
 };
 
 struct message_handlers {
@@ -2976,7 +2976,7 @@ static void memb_state_commit_token_create (
 
 static void memb_join_message_send (struct totemsrp_instance *instance)
 {
-   char memb_join_data[1];
+   char memb_join_data[4];
struct memb_join *memb_join = (struct memb_join *)memb_join_data;
char *addr;
unsigned int addr_idx;
@@ -3028,7 +3028,7 @@ static void memb_join_message_send (struct 
totemsrp_instance *instance)
 
 static void memb_leave_message_send (struct totemsrp_instance *instance)
 {
-   char memb_join_data[1];
+   char memb_join_data[4];
struct memb_join *memb_join = (struct memb_join *)memb_join_data;
char *addr;
unsigned int addr_idx;
-- 
1.7.2.5

___
Openais mailing list
Openais@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/openais