Re: [OpenBabel-Devel] [PATCH] Fix build with gcc-5.x

[Dominik 'Rathann' Mierzejewski]

Hi, Maciek.

On Wednesday, 11 February 2015 at 16:42, Maciek Wójcikowski wrote:
 Hi Dominik,
 
 You could create Pull requests on Github for both patches - this will be
 better way to contribute to OB.
 https://github.com/openbabel/openbabel

I'd have to create my own fork on github and add these patches to it and
then create pull requests. This seems like a lot of work for two small
patches.

Regards,
Dominik
-- 
Fedora http://fedoraproject.org/wiki/User:Rathann
RPMFusion http://rpmfusion.org
Faith manages.
-- Delenn to Lennier in Babylon 5:Confessions and Lamentations

--
Dive into the World of Parallel Programming. The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net/
___
OpenBabel-Devel mailing list
OpenBabel-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openbabel-devel

[OpenBabel-Devel] [PATCH] Fix build with gcc-5.x

[Dominik 'Rathann' Mierzejewski]

Dear OpenBabel developers,
the attached patch fixes building current git master (commit
75414ad4e043f16ba72ae51c7ca60f448576688d) with gcc-5.0:

Building CXX object src/CMakeFiles/openbabel.dir/alias.o
cd /builddir/build/BUILD/openbabel-75414ad4e043f16ba72ae51c7ca60f448576688d/src
 /usr/lib64/ccache/c++   -DHAVE_EIGEN -DHAVE_EIGEN3 -DHAVE_LIBZ
-DHAVE_SHARED_POINTER -DHAVE_WXWIDGETS -DMAKE_OBDLL -DUSING_DYNAMIC_LIBS
-D_FILE_OFFSET_BITS=64 -D_LARGE_FILES -D__WXGTK__ -O2 -g -pipe -Wall
-Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions
-fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches
-m64 -mtune=generic  -pthread -O2 -g -DNDEBUG -O2 -g -fPIC -isystem
/usr/lib64/wx/include/gtk2-unicode-release-2.8 -isystem
/usr/include/wx-2.8
-I/builddir/build/BUILD/openbabel-75414ad4e043f16ba72ae51c7ca60f448576688d/include
-I/builddir/build/BUILD/openbabel-75414ad4e043f16ba72ae51c7ca60f448576688d/data
-I/usr/include/eigen3-DOB_MODULE_PATH=\/usr/lib64/openbabel\ -o
CMakeFiles/openbabel.dir/alias.o -c
/builddir/build/BUILD/openbabel-75414ad4e043f16ba72ae51c7ca60f448576688d/src/alias.cpp
In file included from
/builddir/build/BUILD/openbabel-75414ad4e043f16ba72ae51c7ca60f448576688d/src/alias.cpp:17:0:
/builddir/build/BUILD/openbabel-75414ad4e043f16ba72ae51c7ca60f448576688d/include/openbabel/alias.h:118:47:
error: 'tr1' is not a member of 'std'
   typedef std::vector std::pairstd::string,
obsharedptrOBSmartsPattern   SmartsTable;
   ^
/builddir/build/BUILD/openbabel-75414ad4e043f16ba72ae51c7ca60f448576688d/include/openbabel/alias.h:118:47:
error: 'tr1' is not a member of 'std'
[...]
and so on.

Regards,
Dominik
-- 
Fedora http://fedoraproject.org/wiki/User:Rathann
RPMFusion http://rpmfusion.org
Faith manages.
-- Delenn to Lennier in Babylon 5:Confessions and Lamentations
diff -up 
openbabel-75414ad4e043f16ba72ae51c7ca60f448576688d/include/openbabel/shared_ptr.h.gcc5
 
openbabel-75414ad4e043f16ba72ae51c7ca60f448576688d/include/openbabel/shared_ptr.h
--- 
openbabel-75414ad4e043f16ba72ae51c7ca60f448576688d/include/openbabel/shared_ptr.h.gcc5
  2015-02-04 20:04:57.0 +0100
+++ 
openbabel-75414ad4e043f16ba72ae51c7ca60f448576688d/include/openbabel/shared_ptr.h
   2015-02-07 22:10:37.433163644 +0100
@@ -21,7 +21,7 @@ GNU General Public License for more deta
   #define obsharedptr boost::shared_ptr
 #else
   #include memory
-  #if __GNUC__ == 4  // __GNUC_MINOR__  3  removed at the suggestion of 
Konstantin Tokarev
+  #if __GNUC__ = 4  // __GNUC_MINOR__  3  removed at the suggestion of 
Konstantin Tokarev
 #ifdef _LIBCPP_VERSION
   #include memory
 #else
--
Dive into the World of Parallel Programming. The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net/___
OpenBabel-Devel mailing list
OpenBabel-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openbabel-devel