Re: [OpenBabel-Devel] cmake formats

2015-12-04 Thread Geoffrey Hutchison
> Is there any reason why formats/CMakeLists.txt couldn't include 
> formats.cmake? Or, alternatively, src/CMakeLists.txt could include 
> src/formats/CMakeLists.txt directly?

The latter seems like a bad idea (i.e., breaking compartmentalization) but I 
don't know the reasoning behind creating formats.cmake. If you send a patch 
that pulls that into formats/CMakeLists.txt I'll gladly merge it.

-Geoff
--
Go from Idea to Many App Stores Faster with Intel(R) XDK
Give your users amazing mobile app experiences with Intel(R) XDK.
Use one codebase in this all-in-one HTML5 development environment.
Design, debug & build mobile apps & 2D/3D high-impact games for multiple OSs.
http://pubads.g.doubleclick.net/gampad/clk?id=254741911=/4140
___
OpenBabel-Devel mailing list
OpenBabel-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openbabel-devel


[OpenBabel-Devel] cmake formats

2015-10-16 Thread David Koes
Hi all,

Is there anyway that

src/formats/formats.cmake
src/formats/CMakeLists.txt

could be refactored so that they don't contain essentially duplicated 
information?  Not being a cmake expert, it's not immediately clear to me 
why two different files are necessary, but if formats.cmake is not 
updated with new formats (as happened with exyzformat and orcaformat), 
then static builds start to fail.

Is there any reason why formats/CMakeLists.txt couldn't include 
formats.cmake? Or, alternatively, src/CMakeLists.txt could include 
src/formats/CMakeLists.txt directly?


Thanks,

David Koes
Assistant Professor
Computational and Systems Biology
University of Pittsburgh

--
___
OpenBabel-Devel mailing list
OpenBabel-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openbabel-devel