Re: [OE-core] [PATCH] initrdscripts: fix udevd path
On Mon, Nov 5, 2012 at 8:15 AM, Damian, Alexandru < alexandru.dam...@intel.com> wrote: > Hello guys, > > Sorry about the previously confusing message. > > To clear things up, I've submitted two patches about the udev 182 not > starting properly in the live image. First submission was in fact > incorrect, having sent an intermediary patch file. > > The second submission is the correct patch, that fixes the udev problems, > and adds a couple of features to the initrd file - allows you to use as > root a partition instead of the rootfs.img for recovering an old install, > and fails safe when no rootfs is found, dropping the user to a shell if > something goes wrong. > > Please review the second patch and disregard the first one. Please split the patch in two: one fixing udevd and another with new features; please tag it properly as v3 so it is easy to spoit it. -- Otavio Salvador O.S. Systems E-mail: ota...@ossystems.com.br http://www.ossystems.com.br Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] [PING v3] [PATCH 0/2] Support additional user-defined package metadata
On Sat, Nov 3, 2012 at 9:01 PM, Sebastian Krzyszkowiak wrote: > Has it got rejected, applied, forgotten or what? > > I think it would make sense to support it. There was just one answer > asking if RDEPENDS won't be enough and Ive had good point in my > opinion. It's a shame that patch, even after few pings, goes without > proper reply... I think this is the right time to resend this patch rebased against current master so a new review can be done. -- Otavio Salvador O.S. Systems E-mail: ota...@ossystems.com.br http://www.ossystems.com.br Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH] insane: detect and warn about relocations in .text
Ping? On Wed, 2012-10-03 at 11:24 +0100, Phil Blundell wrote: > Signed-off-by: Phil Blundell > --- > This requires qa.elf.run_objdump() so needs to be applied after the > patch which adds that function. > > meta/classes/insane.bbclass | 26 +- > 1 file changed, 25 insertions(+), 1 deletion(-) > > diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass > index 5848ab4..ff35ed8 100644 > --- a/meta/classes/insane.bbclass > +++ b/meta/classes/insane.bbclass > @@ -108,7 +108,7 @@ def package_qa_get_machine_dict(): > > > # Currently not being used by default "desktop" > -WARN_QA ?= "ldflags useless-rpaths rpaths unsafe-references-in-binaries > unsafe-references-in-scripts staticdev libdir" > +WARN_QA ?= "ldflags useless-rpaths rpaths unsafe-references-in-binaries > unsafe-references-in-scripts staticdev libdir textrel" > ERROR_QA ?= "dev-so debug-deps dev-deps debug-files arch la2 pkgconfig la > perms dep-cmp" > > ALL_QA = "${WARN_QA} ${ERROR_QA}" > @@ -421,6 +421,30 @@ def package_qa_check_desktop(path, name, d, elf, > messages): > for l in output: > messages.append("Desktop file issue: " + l.strip()) > > +QAPATHTEST[textrel] = "package_qa_textrel" > +def package_qa_textrel(path, name, d, elf, messages): > +""" > +Check if the binary contains relocations in .text > +""" > + > +if not elf: > +return > + > +if os.path.islink(path): > +return > + > +phdrs = elf.run_objdump("-p", d) > +sane = True > + > +import re > +textrel_re = re.compile("\s+TEXTREL\s+") > +for line in phdrs.split("\n"): > +if textrel_re.match(line): > +sane = False > + > +if not sane: > +messages.append("ELF binary '%s' has relocations in .text" % path) > + > QAPATHTEST[ldflags] = "package_qa_hash_style" > def package_qa_hash_style(path, name, d, elf, messages): > """ ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
[OE-core] [for-denzil] bitbake: compile tar-replacement firstly
From: "Roy.Li" Compiling tar-replacement or not is decided by version of host tar, if the host tar version is lower than 1.23, Compiling tar-replacement is needed. When doing popoluate tar-replacement sysroot to write the tar to sysroot, but writing is not finished. other packages probably use the being written tar to unzip file, which will lead to failure and report the below error: "bitbake_build/tmp/sysroots/x86_64-linux/usr/bin/tar: Text file busy" Now we compile tar-replacement firstly to ensure that a being written tar command will not be used. (From OE-Core rev: 3c1c4719fc96f6f1fbb257413d6baf3d91fdf4e8) Signed-off-by: Roy.Li Signed-off-by: Saul Wold Signed-off-by: Richard Purdie --- scripts/bitbake |7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/scripts/bitbake b/scripts/bitbake index 3772d82..c52d5d2 100755 --- a/scripts/bitbake +++ b/scripts/bitbake @@ -134,7 +134,12 @@ if [ $buildpseudo -gt 0 ]; then fi done done -bitbake pseudo-native $TARTARGET $additionalopts -c populate_sysroot + +if [ $needtar = "1" ]; then + bitbake $TARTARGET -c populate_sysroot +fi + +bitbake pseudo-native $additionalopts -c populate_sysroot ret=$? if [ "$ret" != "0" ]; then exit 1 -- 1.7.9.7 ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
[OE-core] [PATCH] xorg-driver-common: remove AC_CHECK_FILE workaround
The drivers don't generally use AC_CHECK_FILE anymore, so remove this brute-force kludge. Any subsequent breakage can be worked-around in the recipe and fixes submitted upstream. Signed-off-by: Ross Burton --- meta/recipes-graphics/xorg-driver/xorg-driver-common.inc | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/meta/recipes-graphics/xorg-driver/xorg-driver-common.inc b/meta/recipes-graphics/xorg-driver/xorg-driver-common.inc index f9f25ff..d2c9a5f 100644 --- a/meta/recipes-graphics/xorg-driver/xorg-driver-common.inc +++ b/meta/recipes-graphics/xorg-driver/xorg-driver-common.inc @@ -5,7 +5,7 @@ SECTION = "x11/drivers" LICENSE = "MIT-X" PE = "2" -INC_PR = "r18" +INC_PR = "r19" DEPENDS = "virtual/xserver xproto randrproto util-macros" @@ -18,14 +18,6 @@ FILES_${PN}-dbg += " ${libdir}/xorg/modules/drivers/.debug" inherit autotools pkgconfig -# AC_CHECK_FILE doesn't work when cross compiling, so we create a replacement -# macro that simply assumes the test succeeds. -do_configure_prepend () { -echo 'AC_DEFUN(CC_AC_CHECK_FILE, $2)' > configure.ac.new -sed 's/AC_CHECK_FILE/CC_AC_CHECK_FILE/g' configure.ac >> configure.ac.new -mv configure.ac.new configure.ac -} - # FIXME: We don't want to include the libtool archives (*.la) from modules # directory, as they serve no useful purpose. Upstream should fix Makefile.am do_install_append() { -- 1.7.10 ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [OE-core] Pseudo patch/change, sanity check requested
On 11/5/12 9:05 PM, Peter Seebach wrote: Okay, this is a little odd. We had a build failure of pseudo for a 64-bit target. I looked. I found an easy fix. I'm sending this out to the list before I check it in, for one simple reason: It is absolutely obvious to me that, without this fix, the --enable-static-sqlite feature should never have worked on 64-bit systems. Obviously, it's been in use for months. Which means there's SOMETHING going on which I don't understand. And I am soliciting feedback because I am not comfortable checking in a fix I don't understand, and I recognize that changes to pseudo are relatively high risk. What I'm looking for: 1. Reports from anyone who's been bitten by this. 2. Feedback on how it could be that the build system has worked despite the obvious bug. The bug is simply that --enable-static-sqlite has been hard-coding the path to $(SQLITE)/lib/libsqlite3.a. This obviously can't work on systems where the library directory is lib64. So why haven't we seen it before last week? Within OpenEmbedded-core, we build a local version of sqlite. This local version (native sysroot) always lives in the 'lib' directory path at this time. If the local sqlite is not built, then pseudo should not have been built. --Mark -s --- commit b6c2409d786e53f62accc1c7a6538f39dd0ab601 Author: Peter Seebach Date: Fri Nov 2 19:55:57 2012 -0500 Makefile.in/configure: Use $(LIB), not hardcoded lib, for sqlite It turns out that the -L usage mostly doesn't matter (usually something else has requested the right directory, or it's the default), but the explicit path to libsqlite3.a hardcoded "lib", and on some systems it should be something else, such as "lib64". Solution: Use $(LIB) for that directory. Note that this may not resolve things if, say, you're doing MIPS n32 on a target where that lives in /usr/lib32, but I think in that case you'd be specifying $libdir, so it should still work out. Also added --with-static-sqlite=/path as an option in case people need to further outsmart this. Signed-off-by: Peter Seebach diff --git a/Makefile.in b/Makefile.in index 83fc89f..56ea5e2 100644 --- a/Makefile.in +++ b/Makefile.in @@ -38,7 +38,7 @@ CFLAGS_BASE=-pipe -std=gnu99 -Wall -W -Wextra CFLAGS_CODE=-fPIC -D_LARGEFILE64_SOURCE -D_ATFILE_SOURCE $(ARCH_FLAGS) CFLAGS_DEFS=-DPSEUDO_PREFIX='"$(PREFIX)"' -DPSEUDO_SUFFIX='"$(SUFFIX)"' -DPSEUDO_BINDIR='"$(BIN)"' -DPSEUDO_LIBDIR='"$(LIB)"' -DPSEUDO_LOCALSTATEDIR='"$(LOCALSTATE)"' -DPSEUDO_VERSION='"$(VERSION)"' CFLAGS_DEBUG=-O2 -g -CFLAGS_SQL=-L$(SQLITE)/lib -I$(SQLITE)/include $(RPATH) +CFLAGS_SQL=-L$(SQLITE)/$(LIB) -I$(SQLITE)/include $(RPATH) CFLAGS_PSEUDO=$(CFLAGS_BASE) $(CFLAGS_CODE) $(CFLAGS_DEFS) \ $(CFLAGS_DEBUG) $(CFLAGS_SQL) diff --git a/configure b/configure index 4a41943..c536f58 100755 --- a/configure +++ b/configure @@ -37,6 +37,7 @@ usage() echo >&2 " [--suffix=...]" echo >&2 " [--with-sqlite=...]" echo >&2 " [--enable-static-sqlite]" +echo >&2 " [--with-static-sqlite=...]" echo >&2 " [--with-rpath=...|--without-rpath]" echo >&2 " [--cflags='']" echo >&2 " [--bits=32|64]" @@ -58,14 +59,19 @@ do --libdir=*) opt_libdir=${arg#--libdir=} ;; +--with-static-sqlite=*) +opt_sqlite_ldarg=${arg#--with-static-sqlite=} +sqlite_ldarg=$opt_sqlite_ldarg +use_maybe_rpath=false +;; --enable-static-sqlite) -sqlite_ldarg='$(SQLITE)/lib/libsqlite3.a' +sqlite_ldarg='$(SQLITE)/$(LIB)/libsqlite3.a' use_maybe_rpath=false ;; --with-sqlite=*) opt_sqlite=${arg#--with-sqlite=} # assign new value if unset -maybe_rpath='-Wl,-R$(SQLITE)/lib' +maybe_rpath='-Wl,-R$(SQLITE)/$(LIB)' ;; --without-rpath) opt_rpath='' ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core