Re: [OE-core] [PATCH] linux-libc-headers: fix duplicate IFF_LOWER_UP DORMANT ECHO on musl
On Fri, Jun 23, 2017 at 04:20:41PM -0700, Khem Raj wrote: > On Fri, Jun 23, 2017 at 7:17 AM, wrote: > > Hi, > > > > I'm chipping in since I've been messing with these things a bit in upstream > > Linux kernel. > > > > On Fri, Jun 23, 2017 at 06:37:52AM -0700, Khem Raj wrote: > >> On Fri, Jun 23, 2017 at 3:46 AM, André Draszik wrote: > >> > connman is not doing anything wrong here. > >> > > >> > >> yes I am aware of this > >> > >> > The kernel is redefining IFF_LOWER_UP, because it thinks the libc doesn't > >> > define it yet (and glibc doesn't). > >> > > >> > libc-compat.h is the way to solve these kind of issues. There also is > >> > https: > >> > //lkml.org/lkml/2017/3/12/238 which is very similar. I'll pick that > >> > instead. > >> > > >> see the comment https://lkml.org/lkml/2017/3/16/121 > >> that worries me for this patch > > > > I'm aware of those review comments but I have not seen any patches posted > > which > > fix the problem in some other way. Thus I would propose to apply these > > patches > > as a workaround until upstream fixes the issues. > > > > These header files do not change that often either. > > problem is you become incompatible ABI forever that worries me. > However if bruce is fine to carry this patch as part of linux-yocto > I might relent. It still will be hassle where folks will have to apply > this patch to there kernels if they are building musl based systems. API or ABI? But agreed this is a problem. > > > >> I am not questioning the correctness of patch too. But > >> it would be better to get this patch accepted into kernel > >> before applying to OE since these are kind of patches which > >> you can get stuck with for life if upstream is not accepting it. > > > > Upstream-Status: Denied > > > > would be a correct marker for now I guess. > > I would rather see some progress made to get it resolved :) > we need to actually remove glibc'ness completely from kernel. > and this will fix itself. Yes. With the glibc'ness in the kernel headers I was just following existing examples and adding some more. Some of those changes got accepted and only later came the resistance to remove glibc'ness completely. No-one else has proposed patches. Maybe I should invent some hobby project time again for this... -Mikko -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
[OE-core] [PATCH v2 1/3] selftest/archiver: add tests for recipe type filtering
From: André Draszik
The archiver used to be able to filter based on COPYLEFT_RECIPE_TYPES.
Unfortunately, this got broken with the fix for
https://bugzilla.yoctoproject.org/show_bug.cgi?id=6929
in commit ae9102bda398 ("copyleft_filter.bbclass: Allow to filter on name")
Add two tests to prevent that from happening again.
Signed-off-by: André Draszik
---
meta/lib/oeqa/selftest/cases/archiver.py | 76
1 file changed, 76 insertions(+)
diff --git a/meta/lib/oeqa/selftest/cases/archiver.py
b/meta/lib/oeqa/selftest/cases/archiver.py
index 70c7282f22..7ef92cddac 100644
--- a/meta/lib/oeqa/selftest/cases/archiver.py
+++ b/meta/lib/oeqa/selftest/cases/archiver.py
@@ -39,3 +39,79 @@ class Archiver(OESelftestTestCase):
# Check that exclude_recipe was excluded
excluded_present = len(glob.glob(src_path + '/%s-*' % exclude_recipe))
self.assertFalse(excluded_present, 'Recipe %s was not excluded.' %
exclude_recipe)
+
+
+def test_archiver_filters_by_type(self):
+"""
+Summary: The archiver is documented to filter on the recipe type.
+Expected:1. included recipe type (target) should be included
+ 2. other types should be excluded
+Product: oe-core
+Author: André Draszik
+"""
+
+target_recipe = 'initscripts'
+native_recipe = 'zlib-native'
+
+features = 'INHERIT += "archiver"\n'
+features += 'ARCHIVER_MODE[src] = "original"\n'
+features += 'COPYLEFT_RECIPE_TYPES = "target"\n'
+self.write_config(features)
+
+bitbake('-c clean %s %s' % (target_recipe, native_recipe))
+bitbake("%s -c deploy_archives %s" % (target_recipe, native_recipe))
+
+bb_vars = get_bb_vars(['DEPLOY_DIR_SRC', 'TARGET_SYS', 'BUILD_SYS'])
+src_path_target = os.path.join(bb_vars['DEPLOY_DIR_SRC'],
bb_vars['TARGET_SYS'])
+src_path_native = os.path.join(bb_vars['DEPLOY_DIR_SRC'],
bb_vars['BUILD_SYS'])
+
+# Check that target_recipe was included
+included_present = len(glob.glob(src_path_target + '/%s-*' %
target_recipe))
+self.assertTrue(included_present, 'Recipe %s was not included.' %
target_recipe)
+
+# Check that native_recipe was excluded
+excluded_present = len(glob.glob(src_path_native + '/%s-*' %
native_recipe))
+self.assertFalse(excluded_present, 'Recipe %s was not excluded.' %
native_recipe)
+
+def test_archiver_filters_by_type_and_name(self):
+"""
+Summary: Test that the archiver archives by recipe type, taking the
+ recipe name into account.
+Expected:1. included recipe type (target) should be included
+ 2. other types should be excluded
+ 3. recipe by name should be included / excluded,
+overriding previous decision by type
+Product: oe-core
+Author: André Draszik
+"""
+
+target_recipes = [ 'initscripts', 'zlib' ]
+native_recipes = [ 'update-rc.d-native', 'zlib-native' ]
+
+features = 'INHERIT += "archiver"\n'
+features += 'ARCHIVER_MODE[src] = "original"\n'
+features += 'COPYLEFT_RECIPE_TYPES = "target"\n'
+features += 'COPYLEFT_PN_INCLUDE = "%s"\n' % native_recipes[1]
+features += 'COPYLEFT_PN_EXCLUDE = "%s"\n' % target_recipes[1]
+self.write_config(features)
+
+bitbake('-c clean %s %s' % (' '.join(target_recipes), '
'.join(native_recipes)))
+bitbake('-c deploy_archives %s %s' % (' '.join(target_recipes), '
'.join(native_recipes)))
+
+bb_vars = get_bb_vars(['DEPLOY_DIR_SRC', 'TARGET_SYS', 'BUILD_SYS'])
+src_path_target = os.path.join(bb_vars['DEPLOY_DIR_SRC'],
bb_vars['TARGET_SYS'])
+src_path_native = os.path.join(bb_vars['DEPLOY_DIR_SRC'],
bb_vars['BUILD_SYS'])
+
+# Check that target_recipe[0] and native_recipes[1] were included
+included_present = len(glob.glob(src_path_target + '/%s-*' %
target_recipes[0]))
+self.assertTrue(included_present, 'Recipe %s was not included.' %
target_recipes[0])
+
+included_present = len(glob.glob(src_path_native + '/%s-*' %
native_recipes[1]))
+self.assertTrue(included_present, 'Recipe %s was not included.' %
native_recipes[1])
+
+# Check that native_recipes[0] and target_recipes[1] were excluded
+excluded_present = len(glob.glob(src_path_native + '/%s-*' %
native_recipes[0]))
+self.assertFalse(excluded_present, 'Recipe %s was not excluded.' %
native_recipes[0])
+
+excluded_present = len(glob.glob(src_path_target + '/%s-*' %
target_recipes[1]))
+self.assertFalse(excluded_present, 'Recipe %s was not excluded.' %
target_recipes[1])
--
2.11.0
--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.
[OE-core] [PATCH v2 3/3] copyleft_filter.bbclass: restore possiblity to filter on type
From: André Draszik
Since the changes introduced in ae9102bda398
("copyleft_filter.bbclass: Allow to filter on name"), it is
impossible to filter on the recipe type, all recipes are
treated as though they should be included if the license
matches, irrespective of the COPYLEFT_RECIPE_TYPES
variable.
Fix this.
Signed-off-by: André Draszik
---
meta/classes/copyleft_filter.bbclass | 32
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/meta/classes/copyleft_filter.bbclass
b/meta/classes/copyleft_filter.bbclass
index 5867bb9f7e..c36bce431a 100644
--- a/meta/classes/copyleft_filter.bbclass
+++ b/meta/classes/copyleft_filter.bbclass
@@ -47,27 +47,27 @@ def copyleft_should_include(d):
import oe.license
from fnmatch import fnmatchcase as fnmatch
-included, motive = False, 'recipe did not match anything'
-
recipe_type = d.getVar('COPYLEFT_RECIPE_TYPE')
if recipe_type not in oe.data.typed_value('COPYLEFT_RECIPE_TYPES', d):
-include, motive = False, 'recipe type "%s" is excluded' % recipe_type
+included, motive = False, 'recipe type "%s" is excluded' % recipe_type
+else:
+included, motive = False, 'recipe did not match anything'
-include = oe.data.typed_value('COPYLEFT_LICENSE_INCLUDE', d)
-exclude = oe.data.typed_value('COPYLEFT_LICENSE_EXCLUDE', d)
+include = oe.data.typed_value('COPYLEFT_LICENSE_INCLUDE', d)
+exclude = oe.data.typed_value('COPYLEFT_LICENSE_EXCLUDE', d)
-try:
-is_included, reason = oe.license.is_included(d.getVar('LICENSE'),
include, exclude)
-except oe.license.LicenseError as exc:
-bb.fatal('%s: %s' % (d.getVar('PF'), exc))
-else:
-if is_included:
-if reason:
-included, motive = True, 'recipe has included licenses: %s' %
', '.join(reason)
-else:
-included, motive = False, 'recipe does not include a copyleft
license'
+try:
+is_included, reason = oe.license.is_included(d.getVar('LICENSE'),
include, exclude)
+except oe.license.LicenseError as exc:
+bb.fatal('%s: %s' % (d.getVar('PF'), exc))
else:
-included, motive = False, 'recipe has excluded licenses: %s' % ',
'.join(reason)
+if is_included:
+if reason:
+included, motive = True, 'recipe has included licenses:
%s' % ', '.join(reason)
+else:
+included, motive = False, 'recipe does not include a
copyleft license'
+else:
+included, motive = False, 'recipe has excluded licenses: %s' %
', '.join(reason)
if any(fnmatch(d.getVar('PN'), name) \
for name in oe.data.typed_value('COPYLEFT_PN_INCLUDE', d)):
--
2.11.0
--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
[OE-core] [PATCH v2 2/3] selftest/archiver: only execute deploy_archives task
From: André Draszik
There should be no reason to execute a full build, as we're
just interested in the deployment of the archives.
The newly added tests already do the same.
Signed-off-by: André Draszik
---
meta/lib/oeqa/selftest/cases/archiver.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/lib/oeqa/selftest/cases/archiver.py
b/meta/lib/oeqa/selftest/cases/archiver.py
index 7ef92cddac..72026d573c 100644
--- a/meta/lib/oeqa/selftest/cases/archiver.py
+++ b/meta/lib/oeqa/selftest/cases/archiver.py
@@ -27,7 +27,7 @@ class Archiver(OESelftestTestCase):
self.write_config(features)
bitbake('-c clean %s %s' % (include_recipe, exclude_recipe))
-bitbake("%s %s" % (include_recipe, exclude_recipe))
+bitbake("-c deploy_archives %s %s" % (include_recipe, exclude_recipe))
bb_vars = get_bb_vars(['DEPLOY_DIR_SRC', 'TARGET_SYS'])
src_path = os.path.join(bb_vars['DEPLOY_DIR_SRC'],
bb_vars['TARGET_SYS'])
--
2.11.0
--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
[OE-core] ✗ patchtest: failure for "selftest/archiver: add tests f..." and 2 more (rev3)
== Series Details == Series: "selftest/archiver: add tests f..." and 2 more (rev3) Revision: 3 URL : https://patchwork.openembedded.org/series/7443/ State : failure == Summary == Thank you for submitting this patch series to OpenEmbedded Core. This is an automated response. Several tests have been executed on the proposed series by patchtest resulting in the following failures: * Issue Series does not apply on top of target branch [test_series_merge_on_head] Suggested fixRebase your series on top of targeted branch Targeted branch master (currently at 20b3574749) If you believe any of these test results are incorrect, please reply to the mailing list (openembedded-core@lists.openembedded.org) raising your concerns. Otherwise we would appreciate you correcting the issues and submitting a new version of the patchset if applicable. Please ensure you add/increment the version number when sending the new version (i.e. [PATCH] -> [PATCH v2] -> [PATCH v3] -> ...). --- Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest Test suite: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
[OE-core] ✗ patchtest: failure for "selftest/archiver: add tests f..." and 2 more (rev4)
== Series Details == Series: "selftest/archiver: add tests f..." and 2 more (rev4) Revision: 4 URL : https://patchwork.openembedded.org/series/7443/ State : failure == Summary == Thank you for submitting this patch series to OpenEmbedded Core. This is an automated response. Several tests have been executed on the proposed series by patchtest resulting in the following failures: * Issue Series does not apply on top of target branch [test_series_merge_on_head] Suggested fixRebase your series on top of targeted branch Targeted branch master (currently at 20b3574749) If you believe any of these test results are incorrect, please reply to the mailing list (openembedded-core@lists.openembedded.org) raising your concerns. Otherwise we would appreciate you correcting the issues and submitting a new version of the patchset if applicable. Please ensure you add/increment the version number when sending the new version (i.e. [PATCH] -> [PATCH v2] -> [PATCH v3] -> ...). --- Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest Test suite: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
[OE-core] [PATCH v3 2/3] selftest/archiver: only execute deploy_archives task
From: André Draszik
There should be no reason to execute a full build, as we're
just interested in the deployment of the archives.
The newly added tests already do the same.
Signed-off-by: André Draszik
---
meta/lib/oeqa/selftest/cases/archiver.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/lib/oeqa/selftest/cases/archiver.py
b/meta/lib/oeqa/selftest/cases/archiver.py
index 7ef92cddac..72026d573c 100644
--- a/meta/lib/oeqa/selftest/cases/archiver.py
+++ b/meta/lib/oeqa/selftest/cases/archiver.py
@@ -27,7 +27,7 @@ class Archiver(OESelftestTestCase):
self.write_config(features)
bitbake('-c clean %s %s' % (include_recipe, exclude_recipe))
-bitbake("%s %s" % (include_recipe, exclude_recipe))
+bitbake("-c deploy_archives %s %s" % (include_recipe, exclude_recipe))
bb_vars = get_bb_vars(['DEPLOY_DIR_SRC', 'TARGET_SYS'])
src_path = os.path.join(bb_vars['DEPLOY_DIR_SRC'],
bb_vars['TARGET_SYS'])
--
2.11.0
--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
[OE-core] [PATCH v3 1/3] selftest/archiver: add tests for recipe type filtering
From: André Draszik
The archiver used to be able to filter based on COPYLEFT_RECIPE_TYPES.
Unfortunately, this got broken with the fix for
https://bugzilla.yoctoproject.org/show_bug.cgi?id=6929
in commit ae9102bda398 ("copyleft_filter.bbclass: Allow to filter on name")
Add two tests to prevent that from happening again.
Signed-off-by: André Draszik
---
meta/lib/oeqa/selftest/cases/archiver.py | 76
1 file changed, 76 insertions(+)
diff --git a/meta/lib/oeqa/selftest/cases/archiver.py
b/meta/lib/oeqa/selftest/cases/archiver.py
index 70c7282f22..7ef92cddac 100644
--- a/meta/lib/oeqa/selftest/cases/archiver.py
+++ b/meta/lib/oeqa/selftest/cases/archiver.py
@@ -39,3 +39,79 @@ class Archiver(OESelftestTestCase):
# Check that exclude_recipe was excluded
excluded_present = len(glob.glob(src_path + '/%s-*' % exclude_recipe))
self.assertFalse(excluded_present, 'Recipe %s was not excluded.' %
exclude_recipe)
+
+
+def test_archiver_filters_by_type(self):
+"""
+Summary: The archiver is documented to filter on the recipe type.
+Expected:1. included recipe type (target) should be included
+ 2. other types should be excluded
+Product: oe-core
+Author: André Draszik
+"""
+
+target_recipe = 'initscripts'
+native_recipe = 'zlib-native'
+
+features = 'INHERIT += "archiver"\n'
+features += 'ARCHIVER_MODE[src] = "original"\n'
+features += 'COPYLEFT_RECIPE_TYPES = "target"\n'
+self.write_config(features)
+
+bitbake('-c clean %s %s' % (target_recipe, native_recipe))
+bitbake("%s -c deploy_archives %s" % (target_recipe, native_recipe))
+
+bb_vars = get_bb_vars(['DEPLOY_DIR_SRC', 'TARGET_SYS', 'BUILD_SYS'])
+src_path_target = os.path.join(bb_vars['DEPLOY_DIR_SRC'],
bb_vars['TARGET_SYS'])
+src_path_native = os.path.join(bb_vars['DEPLOY_DIR_SRC'],
bb_vars['BUILD_SYS'])
+
+# Check that target_recipe was included
+included_present = len(glob.glob(src_path_target + '/%s-*' %
target_recipe))
+self.assertTrue(included_present, 'Recipe %s was not included.' %
target_recipe)
+
+# Check that native_recipe was excluded
+excluded_present = len(glob.glob(src_path_native + '/%s-*' %
native_recipe))
+self.assertFalse(excluded_present, 'Recipe %s was not excluded.' %
native_recipe)
+
+def test_archiver_filters_by_type_and_name(self):
+"""
+Summary: Test that the archiver archives by recipe type, taking the
+ recipe name into account.
+Expected:1. included recipe type (target) should be included
+ 2. other types should be excluded
+ 3. recipe by name should be included / excluded,
+overriding previous decision by type
+Product: oe-core
+Author: André Draszik
+"""
+
+target_recipes = [ 'initscripts', 'zlib' ]
+native_recipes = [ 'update-rc.d-native', 'zlib-native' ]
+
+features = 'INHERIT += "archiver"\n'
+features += 'ARCHIVER_MODE[src] = "original"\n'
+features += 'COPYLEFT_RECIPE_TYPES = "target"\n'
+features += 'COPYLEFT_PN_INCLUDE = "%s"\n' % native_recipes[1]
+features += 'COPYLEFT_PN_EXCLUDE = "%s"\n' % target_recipes[1]
+self.write_config(features)
+
+bitbake('-c clean %s %s' % (' '.join(target_recipes), '
'.join(native_recipes)))
+bitbake('-c deploy_archives %s %s' % (' '.join(target_recipes), '
'.join(native_recipes)))
+
+bb_vars = get_bb_vars(['DEPLOY_DIR_SRC', 'TARGET_SYS', 'BUILD_SYS'])
+src_path_target = os.path.join(bb_vars['DEPLOY_DIR_SRC'],
bb_vars['TARGET_SYS'])
+src_path_native = os.path.join(bb_vars['DEPLOY_DIR_SRC'],
bb_vars['BUILD_SYS'])
+
+# Check that target_recipe[0] and native_recipes[1] were included
+included_present = len(glob.glob(src_path_target + '/%s-*' %
target_recipes[0]))
+self.assertTrue(included_present, 'Recipe %s was not included.' %
target_recipes[0])
+
+included_present = len(glob.glob(src_path_native + '/%s-*' %
native_recipes[1]))
+self.assertTrue(included_present, 'Recipe %s was not included.' %
native_recipes[1])
+
+# Check that native_recipes[0] and target_recipes[1] were excluded
+excluded_present = len(glob.glob(src_path_native + '/%s-*' %
native_recipes[0]))
+self.assertFalse(excluded_present, 'Recipe %s was not excluded.' %
native_recipes[0])
+
+excluded_present = len(glob.glob(src_path_target + '/%s-*' %
target_recipes[1]))
+self.assertFalse(excluded_present, 'Recipe %s was not excluded.' %
target_recipes[1])
--
2.11.0
--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.
[OE-core] [PATCH v3 3/3] copyleft_filter.bbclass: restore possiblity to filter on type
From: André Draszik
Since the changes introduced in ae9102bda398
("copyleft_filter.bbclass: Allow to filter on name"), it is
impossible to filter on the recipe type, all recipes are
treated as though they should be included if the license
matches, irrespective of the COPYLEFT_RECIPE_TYPES
variable.
Fix this.
Signed-off-by: André Draszik
---
meta/classes/copyleft_filter.bbclass | 32
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/meta/classes/copyleft_filter.bbclass
b/meta/classes/copyleft_filter.bbclass
index 5867bb9f7e..c36bce431a 100644
--- a/meta/classes/copyleft_filter.bbclass
+++ b/meta/classes/copyleft_filter.bbclass
@@ -47,27 +47,27 @@ def copyleft_should_include(d):
import oe.license
from fnmatch import fnmatchcase as fnmatch
-included, motive = False, 'recipe did not match anything'
-
recipe_type = d.getVar('COPYLEFT_RECIPE_TYPE')
if recipe_type not in oe.data.typed_value('COPYLEFT_RECIPE_TYPES', d):
-include, motive = False, 'recipe type "%s" is excluded' % recipe_type
+included, motive = False, 'recipe type "%s" is excluded' % recipe_type
+else:
+included, motive = False, 'recipe did not match anything'
-include = oe.data.typed_value('COPYLEFT_LICENSE_INCLUDE', d)
-exclude = oe.data.typed_value('COPYLEFT_LICENSE_EXCLUDE', d)
+include = oe.data.typed_value('COPYLEFT_LICENSE_INCLUDE', d)
+exclude = oe.data.typed_value('COPYLEFT_LICENSE_EXCLUDE', d)
-try:
-is_included, reason = oe.license.is_included(d.getVar('LICENSE'),
include, exclude)
-except oe.license.LicenseError as exc:
-bb.fatal('%s: %s' % (d.getVar('PF'), exc))
-else:
-if is_included:
-if reason:
-included, motive = True, 'recipe has included licenses: %s' %
', '.join(reason)
-else:
-included, motive = False, 'recipe does not include a copyleft
license'
+try:
+is_included, reason = oe.license.is_included(d.getVar('LICENSE'),
include, exclude)
+except oe.license.LicenseError as exc:
+bb.fatal('%s: %s' % (d.getVar('PF'), exc))
else:
-included, motive = False, 'recipe has excluded licenses: %s' % ',
'.join(reason)
+if is_included:
+if reason:
+included, motive = True, 'recipe has included licenses:
%s' % ', '.join(reason)
+else:
+included, motive = False, 'recipe does not include a
copyleft license'
+else:
+included, motive = False, 'recipe has excluded licenses: %s' %
', '.join(reason)
if any(fnmatch(d.getVar('PN'), name) \
for name in oe.data.typed_value('COPYLEFT_PN_INCLUDE', d)):
--
2.11.0
--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
[OE-core] ✗ patchtest: failure for "selftest/archiver: add tests f..." and 2 more (rev6)
== Series Details == Series: "selftest/archiver: add tests f..." and 2 more (rev6) Revision: 6 URL : https://patchwork.openembedded.org/series/7443/ State : failure == Summary == Thank you for submitting this patch series to OpenEmbedded Core. This is an automated response. Several tests have been executed on the proposed series by patchtest resulting in the following failures: * Issue Series does not apply on top of target branch [test_series_merge_on_head] Suggested fixRebase your series on top of targeted branch Targeted branch master (currently at 20b3574749) If you believe any of these test results are incorrect, please reply to the mailing list (openembedded-core@lists.openembedded.org) raising your concerns. Otherwise we would appreciate you correcting the issues and submitting a new version of the patchset if applicable. Please ensure you add/increment the version number when sending the new version (i.e. [PATCH] -> [PATCH v2] -> [PATCH v3] -> ...). --- Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest Test suite: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
[OE-core] ✗ patchtest: failure for "selftest/archiver: add tests f..." and 2 more (rev7)
== Series Details == Series: "selftest/archiver: add tests f..." and 2 more (rev7) Revision: 7 URL : https://patchwork.openembedded.org/series/7443/ State : failure == Summary == Thank you for submitting this patch series to OpenEmbedded Core. This is an automated response. Several tests have been executed on the proposed series by patchtest resulting in the following failures: * Issue Series does not apply on top of target branch [test_series_merge_on_head] Suggested fixRebase your series on top of targeted branch Targeted branch master (currently at 20b3574749) If you believe any of these test results are incorrect, please reply to the mailing list (openembedded-core@lists.openembedded.org) raising your concerns. Otherwise we would appreciate you correcting the issues and submitting a new version of the patchset if applicable. Please ensure you add/increment the version number when sending the new version (i.e. [PATCH] -> [PATCH v2] -> [PATCH v3] -> ...). --- Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest Test suite: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH] toolchain-scripts: add check for LD_LIBRARY_PATH in the SDK env setup script
On 23 June 2017 at 18:33, Denys Dmytriyenko wrote: > Ping > This has been in mut for a while, should be in soon. Ross -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
[OE-core] [PATCH v2 1/2] [RFC] base.bbclass: extend PACKAGECONFIG to also allow RRECOMMENDS
From: André Draszik
It can be useful to add RRECOMMENDS to packages created, based
on certain PACKAGECONFIGs.
In particular where a package depends on certain linux kernel
infrastructure (kernel modules) which might or might not be
built as a module, being able to RRECOMMENDS instead of
RDEPENDS on the relevant packages avoids build failures in
case those modules are built statically into the kernel, i.e.
in case no package is being created for them.
Add another field to the PACKAGECONFIG syntax to achieve just
that.
Signed-off-by: André Draszik
---
meta/classes/base.bbclass | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass
index 78926656d7..3762c8addc 100644
--- a/meta/classes/base.bbclass
+++ b/meta/classes/base.bbclass
@@ -384,7 +384,7 @@ python () {
# These take the form:
#
# PACKAGECONFIG ??= ""
-# PACKAGECONFIG[foo] =
"--enable-foo,--disable-foo,foo_depends,foo_runtime_depends"
+# PACKAGECONFIG[foo] =
"--enable-foo,--disable-foo,foo_depends,foo_runtime_depends,foo_runtime_recommends"
pkgconfigflags = d.getVarFlags("PACKAGECONFIG") or {}
if pkgconfigflags:
pkgconfig = (d.getVar('PACKAGECONFIG') or "").split()
@@ -426,12 +426,13 @@ python () {
extradeps = []
extrardeps = []
+extrarrecs = []
extraconf = []
for flag, flagval in sorted(pkgconfigflags.items()):
items = flagval.split(",")
num = len(items)
-if num > 4:
-bb.error("%s: PACKAGECONFIG[%s] Only
enable,disable,depend,rdepend can be specified!"
+if num > 5:
+bb.error("%s: PACKAGECONFIG[%s] Only
enable,disable,depend,rdepend,rrecommend can be specified!"
% (d.getVar('PN'), flag))
if flag in pkgconfig:
@@ -439,12 +440,15 @@ python () {
extradeps.append(items[2])
if num >= 4 and items[3]:
extrardeps.append(items[3])
+if num >= 5 and items[4]:
+extrarrecs.append(items[4])
if num >= 1 and items[0]:
extraconf.append(items[0])
elif num >= 2 and items[1]:
extraconf.append(items[1])
appendVar('DEPENDS', extradeps)
appendVar('RDEPENDS_${PN}', extrardeps)
+appendVar('RRECOMMENDS_${PN}', extrarrecs)
appendVar('PACKAGECONFIG_CONFARGS', extraconf)
pn = d.getVar('PN')
--
2.11.0
--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
[OE-core] [PATCH v2 2/2] connman: fix nftables dependency
From: André Draszik
When building with nftables support, connman doesn't ever
depend on the nftables command line tool.
connman will depend on libmnl and libnftnl at build and
run time. In addition, the nftables rules it creates
depend on various kernel modules being present.
Update the PACKAGECONFIG to reflect this. We use the
just introduced RRECOMMENDS field so as to make the
build still succeed if those kernel modules have been
linked statically into the kernel, i.e. when the
packages haven't actually been created.
Signed-off-by: André Draszik
Acked-by: Sylvain Lemieux
---
meta/recipes-connectivity/connman/connman.inc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/recipes-connectivity/connman/connman.inc
b/meta/recipes-connectivity/connman/connman.inc
index ab18f2fe01..141a464121 100644
--- a/meta/recipes-connectivity/connman/connman.inc
+++ b/meta/recipes-connectivity/connman/connman.inc
@@ -51,7 +51,7 @@ PACKAGECONFIG[l2tp] = "--enable-l2tp
--with-l2tp=${sbindir}/xl2tpd,--disable-l2t
PACKAGECONFIG[pptp] = "--enable-pptp
--with-pptp=${sbindir}/pptp,--disable-pptp,,pptp-linux"
# WISPr support for logging into hotspots, requires TLS
PACKAGECONFIG[wispr] = "--enable-wispr,--disable-wispr,gnutls,"
-PACKAGECONFIG[nftables] = "--with-firewall=nftables ,,nftables,nftables"
+PACKAGECONFIG[nftables] = "--with-firewall=nftables ,,libmnl
libnftnl,,kernel-module-nf-tables-ipv4 kernel-module-nft-chain-nat-ipv4
kernel-module-nft-chain-route-ipv4 kernel-module-nft-meta
kernel-module-nft-masq-ipv4 kernel-module-nft-nat"
PACKAGECONFIG[iptables] = "--with-firewall=iptables ,,iptables,iptables"
INITSCRIPT_NAME = "connman"
--
2.11.0
--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
[OE-core] [PATCH] cups: don't change permissions of /var/run/cups/certs in do_package
This directory is deleted by do_install, so luckily the lack of error checking
meant this didn't break.
Signed-off-by: Ross Burton
---
meta/recipes-extended/cups/cups.inc | 7 ---
1 file changed, 7 deletions(-)
diff --git a/meta/recipes-extended/cups/cups.inc
b/meta/recipes-extended/cups/cups.inc
index c3fa45941c2..38d90b5ea9d 100644
--- a/meta/recipes-extended/cups/cups.inc
+++ b/meta/recipes-extended/cups/cups.inc
@@ -79,13 +79,6 @@ do_install () {
fi
}
-python do_package_append() {
-import subprocess
-# Change permissions back the way they were, they probably had a reason...
-workdir = d.getVar('WORKDIR')
-subprocess.call('chmod 0511 %s/install/cups/var/run/cups/certs' % workdir,
shell=True)
-}
-
PACKAGES =+ "${PN}-lib ${PN}-libimage"
RDEPENDS_${PN} += "${@bb.utils.contains('DISTRO_FEATURES', 'sysvinit',
'procps', '', d)}"
--
2.11.0
--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] ✗ patchtest: failure for "selftest/archiver: add tests f..." and 2 more (rev7)
On Mon, 2017-06-26 at 09:01 +, Patchwork wrote: > == Series Details == > > Series: "selftest/archiver: add tests f..." and 2 more (rev7) > Revision: 7 > URL : https://patchwork.openembedded.org/series/7443/ > State : failure > > == Summary == > > > Thank you for submitting this patch series to OpenEmbedded Core. This is > an automated response. Several tests have been executed on the proposed > series by patchtest resulting in the following failures: > > > > * Issue Series does not apply on top of target branch > [test_series_merge_on_head] > Suggested fixRebase your series on top of targeted branch > Targeted branch master (currently at 20b3574749) I'm not sure why this is failing, I made sure to rebase onto 20b3574749 before submitting. Cheers, Andre' -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH 1/1] buildhistory.bbclass: buildhistory_list_files: remove folder size
On 22 June 2017 at 21:04, Juro Bystricky wrote: > Considering that the listed folder size is meaningless anyway (it has no > relation to > the size of the package/image), this patch addresses the problem by > removing > the directory entry sizes entirely from the generated text files. > The alternative would be to show the size of the children of the directory. For example we manually calculate the size of a package (for the PKGSIZE field in pkgdata) by adding up the size of files instead of using du for the same reason. Ross -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCHv2] (master) automake: fix Perl regex
The subject needs to be of the form: automake: fix perl regex for Perl 5.22 onwards Also the Upstream-Status can be set to Backport as this is sha 13f00eb4 upstream. Cheers, Ross On 21 June 2017 at 09:55, Anton Novikov wrote: > Thanks, > > Anton > > > -- > ___ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-core > > -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCHv2] (master) automake: fix Perl regex
Actually looked at the patch: this has been fixed in master since oe-core 7fa044e799db651d45e4732e2527acfc2bc7cd47, which was committed in May. Ross On 26 June 2017 at 13:39, Anton Novikov wrote: > Please reword it at will. > > Thanks, > > Anton > > On 06/26/2017 03:37 PM, Burton, Ross wrote: > > The subject needs to be of the form: > > automake: fix perl regex for Perl 5.22 onwards > > Also the Upstream-Status can be set to Backport as this is sha 13f00eb4 > upstream. > > Cheers, > Ross > > On 21 June 2017 at 09:55, Anton Novikov wrote: > >> Thanks, >> >> Anton >> >> >> -- >> ___ >> Openembedded-core mailing list >> Openembedded-core@lists.openembedded.org >> http://lists.openembedded.org/mailman/listinfo/openembedded-core >> >> > > -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCHv2] (master) automake: fix Perl regex
Whoops, hit sent too early. If you want this also fixed in a stable branch, please cherry-pick and submit the commit from master. Ross On 26 June 2017 at 13:46, Burton, Ross wrote: > Actually looked at the patch: this has been fixed in master since oe-core > 7fa044e799db651d45e4732e2527acfc2bc7cd47, which was committed in May. > > Ross > > On 26 June 2017 at 13:39, Anton Novikov wrote: > >> Please reword it at will. >> >> Thanks, >> >> Anton >> >> On 06/26/2017 03:37 PM, Burton, Ross wrote: >> >> The subject needs to be of the form: >> >> automake: fix perl regex for Perl 5.22 onwards >> >> Also the Upstream-Status can be set to Backport as this is sha 13f00eb4 >> upstream. >> >> Cheers, >> Ross >> >> On 21 June 2017 at 09:55, Anton Novikov wrote: >> >>> Thanks, >>> >>> Anton >>> >>> >>> -- >>> ___ >>> Openembedded-core mailing list >>> Openembedded-core@lists.openembedded.org >>> http://lists.openembedded.org/mailman/listinfo/openembedded-core >>> >>> >> >> > -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
[OE-core] [PATCH] lz4: Add patch to fix re-builds
Configure fails when rebuilding lz4 as LIBDIR is used in two different places for two different things and we override it with a environment variable. Signed-off-by: Jussi Kukkonen --- ...sts-Makefile-don-t-use-LIBDIR-as-variable.patch | 82 ++ meta/recipes-support/lz4/lz4_1.7.4.bb | 1 + 2 files changed, 83 insertions(+) create mode 100644 meta/recipes-support/lz4/files/0001-tests-Makefile-don-t-use-LIBDIR-as-variable.patch diff --git a/meta/recipes-support/lz4/files/0001-tests-Makefile-don-t-use-LIBDIR-as-variable.patch b/meta/recipes-support/lz4/files/0001-tests-Makefile-don-t-use-LIBDIR-as-variable.patch new file mode 100644 index 000..00494e8 --- /dev/null +++ b/meta/recipes-support/lz4/files/0001-tests-Makefile-don-t-use-LIBDIR-as-variable.patch @@ -0,0 +1,82 @@ +From d4768d9e29b805096a86aa13c0d30ee8215af4df Mon Sep 17 00:00:00 2001 +From: Jussi Kukkonen +Date: Mon, 26 Jun 2017 12:07:09 +0300 +Subject: [PATCH] tests/Makefile: don't use LIBDIR as variable + +LIBDIR may be overriden with a environment variable: In this case make +clean breaks. Use another variable name. + +Signed-off-by: Jussi Kukkonen +Upstream-Status: Backport +--- + tests/Makefile | 26 +- + 1 file changed, 13 insertions(+), 13 deletions(-) + +diff --git a/tests/Makefile b/tests/Makefile +index 97fa782..51dd038 100644 +--- a/tests/Makefile b/tests/Makefile +@@ -32,7 +32,7 @@ DESTDIR ?= + PREFIX ?= /usr/local + BINDIR := $(PREFIX)/bin + MANDIR := $(PREFIX)/share/man/man1 +-LIBDIR := ../lib ++LZ4DIR := ../lib + PRGDIR := ../programs + VOID:= /dev/null + TESTDIR := versionsTest +@@ -43,7 +43,7 @@ CFLAGS += -g -Wall -Wextra -Wundef -Wcast-qual -Wcast-align -Wshadow -Wswitch-e +-Wdeclaration-after-statement -Wstrict-prototypes \ +-Wpointer-arith -Wstrict-aliasing=1 + CFLAGS += $(MOREFLAGS) +-CPPFLAGS:= -I$(LIBDIR) -I$(PRGDIR) -DXXH_NAMESPACE=LZ4_ ++CPPFLAGS:= -I$(LZ4DIR) -I$(PRGDIR) -DXXH_NAMESPACE=LZ4_ + FLAGS= $(CFLAGS) $(CPPFLAGS) $(LDFLAGS) + + +@@ -79,31 +79,31 @@ lz4c32: # create a 32-bits version for 32/64 interop tests + $(MAKE) -C $(PRGDIR) clean $@ CFLAGS="-m32 $(CFLAGS)" + cp $(LZ4) $(LZ4)c32 + +-fullbench : $(LIBDIR)/lz4.o $(LIBDIR)/lz4hc.o $(LIBDIR)/lz4frame.o $(LIBDIR)/xxhash.o fullbench.c ++fullbench : $(LZ4DIR)/lz4.o $(LZ4DIR)/lz4hc.o $(LZ4DIR)/lz4frame.o $(LZ4DIR)/xxhash.o fullbench.c + $(CC) $(FLAGS) $^ -o $@$(EXT) + +-fullbench-lib: fullbench.c $(LIBDIR)/xxhash.c +- $(MAKE) -C $(LIBDIR) liblz4.a +- $(CC) $(FLAGS) $^ -o $@$(EXT) $(LIBDIR)/liblz4.a ++fullbench-lib: fullbench.c $(LZ4DIR)/xxhash.c ++ $(MAKE) -C $(LZ4DIR) liblz4.a ++ $(CC) $(FLAGS) $^ -o $@$(EXT) $(LZ4DIR)/liblz4.a + +-fullbench-dll: fullbench.c $(LIBDIR)/xxhash.c +- $(MAKE) -C $(LIBDIR) liblz4 +- $(CC) $(FLAGS) $^ -o $@$(EXT) -DLZ4_DLL_IMPORT=1 $(LIBDIR)/dll/liblz4.dll ++fullbench-dll: fullbench.c $(LZ4DIR)/xxhash.c ++ $(MAKE) -C $(LZ4DIR) liblz4 ++ $(CC) $(FLAGS) $^ -o $@$(EXT) -DLZ4_DLL_IMPORT=1 $(LZ4DIR)/dll/liblz4.dll + +-fuzzer : $(LIBDIR)/lz4.o $(LIBDIR)/lz4hc.o $(LIBDIR)/xxhash.o fuzzer.c ++fuzzer : $(LZ4DIR)/lz4.o $(LZ4DIR)/lz4hc.o $(LZ4DIR)/xxhash.o fuzzer.c + $(CC) $(FLAGS) $^ -o $@$(EXT) + +-frametest: $(LIBDIR)/lz4frame.o $(LIBDIR)/lz4.o $(LIBDIR)/lz4hc.o $(LIBDIR)/xxhash.o frametest.c ++frametest: $(LZ4DIR)/lz4frame.o $(LZ4DIR)/lz4.o $(LZ4DIR)/lz4hc.o $(LZ4DIR)/xxhash.o frametest.c + $(CC) $(FLAGS) $^ -o $@$(EXT) + +-fasttest: $(LIBDIR)/lz4.o fasttest.c ++fasttest: $(LZ4DIR)/lz4.o fasttest.c + $(CC) $(FLAGS) $^ -o $@$(EXT) + + datagen : $(PRGDIR)/datagen.c datagencli.c + $(CC) $(FLAGS) -I$(PRGDIR) $^ -o $@$(EXT) + + clean: +- @$(MAKE) -C $(LIBDIR) $@ > $(VOID) ++ @$(MAKE) -C $(LZ4DIR) $@ > $(VOID) + @$(MAKE) -C $(PRGDIR) $@ > $(VOID) + @$(RM) core *.o *.test tmp* \ + fullbench-dll$(EXT) fullbench-lib$(EXT) \ +-- +2.1.4 + diff --git a/meta/recipes-support/lz4/lz4_1.7.4.bb b/meta/recipes-support/lz4/lz4_1.7.4.bb index 5ddffd5..1e98c1b 100644 --- a/meta/recipes-support/lz4/lz4_1.7.4.bb +++ b/meta/recipes-support/lz4/lz4_1.7.4.bb @@ -11,6 +11,7 @@ PE = "1" SRCREV = "7bb64ff2b69a9f8367de9ab483cdadf42b4c1b65" SRC_URI = "git://github.com/lz4/lz4.git \ + file://0001-tests-Makefile-don-t-use-LIBDIR-as-variable.patch \ file://run-ptest \ " -- 2.1.4 -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
[OE-core] State of bitbake world, Failed tasks 2017-06-23
http://www.openembedded.org/wiki/Bitbake_World_Status
== Number of issues - stats ==
{| class='wikitable'
!|Date !!colspan='3'|Failed tasks
!!|Signatures !!colspan='14'|QA !!Comment
|-
|| ||qemuarm ||qemux86 ||qemux86_64||all
||already-stripped ||libdir||textrel ||build-deps
||file-rdeps||version-going-backwards ||host-user-contaminated
||installed-vs-shipped ||unknown-configure-option ||symlink-to-sysroot
||invalid-pkgconfig ||pkgname ||ldflags ||compile-host-path
||
|-
||2017-06-23||1 ||4 ||2 ||0 ||0 ||1
||5 ||0 ||0 ||0 ||5
||0 ||0 ||0 ||0 ||0
||0 ||0 ||
|}
== Failed tasks 2017-06-23 ==
INFO: jenkins-job.sh-1.8.23 Complete log available at
http://logs.nslu2-linux.org/buildlogs/oe/world/rocko/log.report.20170626_030939.log
=== common (0) ===
=== common-x86 (2) ===
* meta-qt5/recipes-qt/qt5/qtwebengine_git.bb:do_compile
*
openembedded-core/meta/recipes-devtools/valgrind/valgrind_3.12.0.bb:do_compile_ptest_base
=== qemuarm (1) ===
*
meta-openembedded/meta-multimedia/recipes-mediacenter/kodi/kodi_17.bb:do_compile
=== qemux86 (2) ===
*
meta-openembedded/meta-multimedia/recipes-mediacenter/kodi/kodi_17.bb:do_configure
*
meta-openembedded/meta-oe/recipes-extended/hwloc/hwloc_1.11.5.bb:do_configure
=== qemux86_64 (0) ===
=== Number of failed tasks (7) ===
{| class=wikitable
|-
|| qemuarm || 1 ||
http://logs.nslu2-linux.org/buildlogs/oe/world/rocko/log.world.qemuarm.20170622_041724.log/
|| http://errors.yoctoproject.org/Errors/Build/39973/
|-
|| qemux86 || 4 ||
http://logs.nslu2-linux.org/buildlogs/oe/world/rocko/log.world.qemux86.20170622_041725.log/
|| http://errors.yoctoproject.org/Errors/Build/39975/
|-
|| qemux86_64 || 2 ||
http://logs.nslu2-linux.org/buildlogs/oe/world/rocko/log.world.qemux86-64.20170623_075238.log/
|| http://errors.yoctoproject.org/Errors/Build/40160/
|}
=== PNBLACKLISTs (15) ===
=== QA issues (11) ===
{| class=wikitable
!| Count||Issue
|-
||0 ||already-stripped
|-
||0 ||build-deps
|-
||0 ||compile-host-path
|-
||0 ||file-rdeps
|-
||0 ||installed-vs-shipped
|-
||0 ||invalid-pkgconfig
|-
||0 ||ldflags
|-
||0 ||pkgname
|-
||0 ||symlink-to-sysroot
|-
||0 ||unknown-configure-option
|-
||0 ||version-going-backwards
|-
||1 ||libdir
|-
||5 ||host-user-contaminated
|-
||5 ||textrel
|}
=== Incorrect PACKAGE_ARCH or sstate signatures (0) ===
Complete log:
http://logs.nslu2-linux.org/buildlogs/oe/world/rocko/log.signatures.20170623_034040.log/
* ERROR: Nothing PROVIDES 'numactl' (but
/home/jenkins/oe/world/shr-core/meta-openembedded/meta-oe/recipes-extended/hwloc/hwloc_1.11.5.bb
DEPENDS on or otherwise requires it)
* ERROR: numactl was skipped: incompatible with host arm-oe-linux-gnueabi
(not in COMPATIBLE_HOST)
* ERROR: Required build target 'meta-world-pkgdata' has no buildable
providers.
PNBLACKLISTs:
openembedded-core/:
meta-browser:
meta-openembedded:
meta-networking/recipes-support/lksctp-tools/lksctp-tools_1.0.17.bb:PNBLACKLIST[lksctp-tools]
?= "${@bb.utils.contains('DISTRO_FEATURES', 'ld-is-gold', "BROKEN: fails to
link against sctp_connectx symbol", '', d)}"
meta-oe/recipes-connectivity/bluez/bluez-hcidump_2.5.bb:PNBLACKLIST[bluez-hcidump]
?= "${@bb.utils.contains('DISTRO_FEATURES', 'bluez5', 'bluez5 conflicts with
bluez4 and bluez5 is selected in DISTRO_FEATURES', '', d)}"
meta-oe/recipes-connectivity/bluez/bluez4_4.101.bb:PNBLACKLIST[bluez4] ?=
"${@bb.utils.contains('DISTRO_FEATURES', 'bluez5', 'bluez5 conflicts with
bluez4 and bluez5 is selected in DISTRO_FEATURES', '', d)}"
meta-oe/recipes-connectivity/bluez/gst-plugin-bluetooth_4.101.bb:PNBLACKLIST[gst-plugin-bluetooth]
?= "${@bb.utils.contains('DISTRO_FEATURES', 'bluez5', 'bluez5 conflicts with
bluez4 and bluez5 is selected in DISTRO_FEATURES', '', d)}"
meta-oe/recipes-core/dbus/libdbus-c++_0.9.0.bb:PNBLACKLIST[libdbus-c++] ?=
"Fails to build with RSS http://errors.yoctoproject.org/Errors/Details/130644/
- the recipe will be removed on 2017-09-01 unless the issue is fixed"
meta-oe/recipes-graphics/libsexy/libsexy_0.1.11.bb:PNBLACKLIST[libsexy] ?=
"Fails to build with RSS http://errors.yoctoproject.org/Errors/Details/130607/
- the recipe will be removed on 2017-09-01 unless the issue is fixed"
meta-oe/recipes-graphics/xorg-driver/xf86-video-geode_2.11.16.bb:PNBLACKLIST[xf86-video-geode]
?= "BROKEN, fails to build - the recipe will be removed on 2017-09-01 unless
the issue is fixed"
meta-oe/recipes-navigation/foxtrotgps/foxtrotgps_1.1.1.bb:PNBLACKLIST[foxtrotgps]
?= "${@bb.utils.contains('DISTRO_FEATURES', 'blue
Re: [OE-core] ✗ patchtest: failure for "selftest/archiver: add tests f..." and 2 more (rev7)
On Mon, 2017-06-26 at 11:32 +0100, André Draszik wrote:
> On Mon, 2017-06-26 at 09:01 +, Patchwork wrote:
> > == Series Details ==
> >
> > Series: "selftest/archiver: add tests f..." and 2 more (rev7)
> > Revision: 7
> > URL : https://patchwork.openembedded.org/series/7443/
> > State : failure
> >
> > == Summary ==
> >
> >
> > Thank you for submitting this patch series to OpenEmbedded Core. This is
> > an automated response. Several tests have been executed on the proposed
> > series by patchtest resulting in the following failures:
> >
> >
> >
> > * Issue Series does not apply on top of target branch
> > [test_series_merge_on_head]
> > Suggested fixRebase your series on top of targeted branch
> > Targeted branch master (currently at 20b3574749)
>
> I'm not sure why this is failing, I made sure to rebase onto 20b3574749
> before submitting.
>
I tried merging it with verbose flags and this is what I get:
git apply --check 7443.mbox --verbose
Checking patch meta/classes/copyleft_filter.bbclass...
Checking patch meta/lib/oeqa/selftest/cases/archiver.py...
Checking patch meta/classes/copyleft_filter.bbclass...
error: while searching for:
import oe.license
from fnmatch import fnmatchcase as fnmatch
included, motive = False, 'recipe did not match anything'
recipe_type = d.getVar('COPYLEFT_RECIPE_TYPE')
if recipe_type not in oe.data.typed_value('COPYLEFT_RECIPE_TYPES',
d):
include, motive = False, 'recipe type "%s" is excluded' %
recipe_type
include = oe.data.typed_value('COPYLEFT_LICENSE_INCLUDE', d)
exclude = oe.data.typed_value('COPYLEFT_LICENSE_EXCLUDE', d)
try:
is_included, reason =
oe.license.is_included(d.getVar('LICENSE'), include, exclude)
except oe.license.LicenseError as exc:
bb.fatal('%s: %s' % (d.getVar('PF'), exc))
else:
if is_included:
if reason:
included, motive = True, 'recipe has included licenses:
%s' % ', '.join(reason)
else:
included, motive = False, 'recipe does not include a
copyleft license'
else:
included, motive = False, 'recipe has excluded licenses: %s'
% ', '.join(reason)
if any(fnmatch(d.getVar('PN'), name) \
for name in oe.data.typed_value('COPYLEFT_PN_INCLUDE', d)):
error: patch failed: meta/classes/copyleft_filter.bbclass:47
error: meta/classes/copyleft_filter.bbclass: patch does not apply
so there is something that git does not like on the bbclass.
Leo
>
> Cheers,
> Andre'
>
--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
[OE-core] Yocto Project Status WW26’17
Current Dev Position: Preparing for YP 2.4 M2 Next Deadline: YP 2.4 M2 Cut off is July 17, 2017 SWAT team rotation: Jussi -> Stephano on June 23, 2017. SWAT team rotation: Stephano -> Maxin on June 30, 2017. https://wiki.yoctoproject.org/wiki/Yocto_Build_Failure_Swat_Team Key Status/Updates: ·YP 2.4 M1 rc1 is likely to be released as M1. Some issues were found but these were comparatively minor and will be addressed in master during M2. The QA Report: https://wiki.yoctoproject.org/wiki/WW25_-_2017-06-22_-_Full_Test_Cycle_2.4_M1_rc1 Release Criteria: https://wiki.yoctoproject.org/wiki/Yocto_Project_v2.4_Status#Milestone_1_-_Target_June_23.2C_2017 ·Various changes merged into master including cleanup of obsoleted uclibc related changes, removal of gcc 5.x and ipk/deb package parallelisation and various recipe upgrades. ·We have been doing some cleanup of older bugs in the bugzilla, closing things which are unlikely to happen, are obsolete or have already been completed. This is having a positive effect on many of the bug tracking metrics but more work remains to clean things up. Planned upcoming dot releases: YP 2.1.3 Cut off May 22, 2017 - Will respin an rc2 and run through QA after YP 2.4 M1 is done. YP 2.1.3 Release by June 3, 2017 YP 2.3.1 Cut off May 30, 2017 - Running late, but rc1 should go into QA after YP 2.4 M1, YP 2.1.3, and YP 2.2.2 are done. YP 2.3.1 Release by June 9, 2017 YP 2.2.2 Cut off June 5, 2017 - Will respin an rc2 and run through QA after YP 2.4 M1 and YP 2.1.3 are done. YP 2.2.2 Release by June, 16 2017 YP 2.3.2 Cut off Aug 7, 2017 YP 2.3.2 Release by Aug. 18, 2017 Key YP 2.4 Dates are: YP 2.4 M2 Cut off is July 17, 2017 YP 2.4 M2 Release by July 28, 2017 YP 2.4 M3 Cut off is Aug. 21, 2017 YP 2.4 M3 Release by Sept. 1, 2017 YP 2.4 M4 (Final) Cut off is Sept. 18, 2017 YP 2.4 M4 (Final) Release by Oct. 20, 2017 Tracking Metrics: WDD 2508 (last week 2602) (https://wiki.yoctoproject.org/charts/combo.html) Key Status Links for YP: https://wiki.yoctoproject.org/wiki/Yocto_Project_v2.4_Status https://wiki.yoctoproject.org/wiki/Yocto_2.4_Schedule https://wiki.yoctoproject.org/wiki/Yocto_2.4_Features [If anyone has suggestions for other information you’d like to see on this weekly status update, let us know!] Thanks, Stephen K. Jolley Yocto Project Program Manager INTEL, MS JF1-255, 2111 N.E. 25th Avenue, Hillsboro, OR 97124 • Work Telephone:(503) 712-0534 •Cell: (208) 244-4460 • Email:stephen.k.jol...@intel.com -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
[OE-core] [PATCH] meta: Add/fix missing Upstream-Status to patches
This adds or fixes the Upstream-Status for all remaining patches missing it in OE-Core. Signed-off-by: Richard Purdie --- .../openssl/openssl/debian/version-script.patch | 3 +++ .../recipes-connectivity/openssl/openssl/debian1.0.2/soname.patch | 2 ++ .../openssl/openssl/debian1.0.2/version-script.patch | 2 ++ .../glibc/0004-nativesdk-glibc-Allow-64-bit-atomics-for-x86.patch | 1 + .../glibc/0017-Remove-bash-dependency-for-nscd-init-script.patch | 1 + .../defn2-c-man-don-t-rely-on-dpkg-architecture-to-set-a.patch| 1 + .../ovmf/ovmf/0002-ovmf-update-path-to-native-BaseTools.patch | 1 + ...0003-BaseTools-makefile-adjust-to-build-in-under-bitbake.patch | 1 + meta/recipes-core/ovmf/ovmf/no-stack-protector-all-archs.patch| 1 + .../systemd/systemd/0017-remove-duplicate-include-uchar.h.patch | 1 + .../systemd/systemd/0018-check-for-uchar.h-in-configure.patch | 1 + ...port-233-don-t-use-the-unified-hierarchy-for-the-systemd.patch | 2 ++ meta/recipes-devtools/e2fsprogs/e2fsprogs/ptest.patch | 2 ++ .../gcc/gcc-7.1/0044-libgcc-Add-knob-to-use-ldbl-128-on-ppc.patch | 1 + meta/recipes-devtools/libtool/libtool/nohardcodepaths.patch | 2 ++ .../recipes-devtools/perl/perl/debian/cpan-missing-site-dirs.diff | 1 + meta/recipes-devtools/perl/perl/debian/cpan_definstalldirs.diff | 1 + meta/recipes-devtools/perl/perl/debian/db_file_ver.diff | 1 + meta/recipes-devtools/perl/perl/debian/deprecate-with-apt.diff| 1 + meta/recipes-devtools/perl/perl/debian/doc_info.diff | 1 + meta/recipes-devtools/perl/perl/debian/enc2xs_inc.diff| 1 + meta/recipes-devtools/perl/perl/debian/errno_ver.diff | 2 +- .../perl/perl/debian/extutils_set_libperl_path.diff | 1 + meta/recipes-devtools/perl/perl/debian/fakeroot.diff | 1 + meta/recipes-devtools/perl/perl/debian/find_html2text.diff| 1 + .../perl/perl/debian/fixes/document_makemaker_ccflags.diff| 1 + .../perl/perl/debian/fixes/memoize_storable_nstore.diff | 1 + meta/recipes-devtools/perl/perl/debian/fixes/net_smtp_docs.diff | 1 + meta/recipes-devtools/perl/perl/debian/fixes/perl-Cnn.diff| 1 + .../perl/perl/debian/fixes/pod_man_reproducible_date.diff | 1 + .../perl/perl/debian/fixes/podman-empty-date.diff | 1 + meta/recipes-devtools/perl/perl/debian/fixes/podman-pipe.diff | 1 + meta/recipes-devtools/perl/perl/debian/fixes/podman-utc-docs.diff | 1 + meta/recipes-devtools/perl/perl/debian/fixes/podman-utc.diff | 1 + meta/recipes-devtools/perl/perl/debian/fixes/respect_umask.diff | 1 + meta/recipes-devtools/perl/perl/debian/instmodsh_doc.diff | 1 + meta/recipes-devtools/perl/perl/debian/ld_run_path.diff | 1 + meta/recipes-devtools/perl/perl/debian/libnet_config_path.diff| 1 + meta/recipes-devtools/perl/perl/debian/libperl_embed_doc.diff | 1 + meta/recipes-devtools/perl/perl/debian/locale-robustness.diff | 1 + meta/recipes-devtools/perl/perl/debian/makemaker-pasthru.diff | 1 + meta/recipes-devtools/perl/perl/debian/makemaker_customized.diff | 1 + meta/recipes-devtools/perl/perl/debian/mod_paths.diff | 1 + meta/recipes-devtools/perl/perl/debian/no_packlist_perllocal.diff | 1 + meta/recipes-devtools/perl/perl/debian/patchlevel.diff| 1 + .../perl/perl/debian/perl5db-x-terminal-emulator.patch| 1 + meta/recipes-devtools/perl/perl/debian/perlivp.diff | 1 + meta/recipes-devtools/perl/perl/debian/pod2man-customized.diff| 1 + meta/recipes-devtools/perl/perl/debian/prefix_changes.diff| 1 + meta/recipes-devtools/perl/perl/debian/prune_libs.diff| 2 +- meta/recipes-devtools/perl/perl/debian/regen-skip.diff| 1 + meta/recipes-devtools/perl/perl/debian/skip-kfreebsd-crash.diff | 1 + .../perl/perl/debian/skip-upstream-git-tests.diff | 1 + .../perl/perl/debian/squelch-locale-warnings.diff | 1 + meta/recipes-devtools/perl/perl/debian/writable_site_dirs.diff| 1 + .../ext-ODBM_File-t-odbm.t-fix-the-path-of-dbmt_common.p.patch| 2 ++ meta/recipes-devtools/python/python/multilib.patch| 2 +- .../python/python/use_sysroot_ncurses_instead_of_host.patch | 1 + meta/recipes-devtools/qemu/qemu/qemu-2.5.0-cflags.patch | 2 ++ meta/recipes-devtools/ruby/ruby/extmk.patch | 1 + meta/recipes-extended/acpica/files/no-werror.patch| 2 +- .../ghostscript/ghostscript/ghostscript-9.15-parallel-make.patch | 1 + .../libnsl/libnsl2/0001-include-sys-cdefs.h-explicitly.patch | 2 +- .../libnsl/libnsl2/0002-Define-glibc-specific-macros.patch| 2 +- meta/recipes-extended/lsb/lsbinitscripts/functions.patch | 1 + ...002-Add-knob-to-control-whether-numa-support-should-be-c.patch | 1 + .../ltp/ltp/0003-Add-knob-to-control-tirp
[OE-core] [PATCH] python3-pygobject: upgrade to 3.24.1
From: Upgrade Helper
Signed-off-by: Jose Lamego
---
.../{python3-pygobject_3.22.0.bb => python3-pygobject_3.24.1.bb} | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
rename meta/recipes-devtools/python/{python3-pygobject_3.22.0.bb =>
python3-pygobject_3.24.1.bb} (87%)
diff --git a/meta/recipes-devtools/python/python3-pygobject_3.22.0.bb
b/meta/recipes-devtools/python/python3-pygobject_3.24.1.bb
similarity index 87%
rename from meta/recipes-devtools/python/python3-pygobject_3.22.0.bb
rename to meta/recipes-devtools/python/python3-pygobject_3.24.1.bb
index 143048d..5795ae3 100644
--- a/meta/recipes-devtools/python/python3-pygobject_3.22.0.bb
+++ b/meta/recipes-devtools/python/python3-pygobject_3.24.1.bb
@@ -13,8 +13,8 @@ SRC_URI = " \
file://0001-configure.ac-add-sysroot-path-to-GI_DATADIR-don-t-se.patch \
"
-SRC_URI[md5sum] = "ed4117ed5d554d25fd7718807fbf819f"
-SRC_URI[sha256sum] =
"08b29cfb08efc80f7a8630a2734dec65a99c1b59f1e5771c671d2e4ed8a5cbe7"
+SRC_URI[md5sum] = "69a843311d0f0385dff376e11a2d83d2"
+SRC_URI[sha256sum] =
"a628a95aa0909e13fb08230b1b98fc48adef10b220932f76d62f6821b3fdbffd"
S = "${WORKDIR}/${SRCNAME}-${PV}"
--
2.7.4
--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
[OE-core] ✗ patchtest: failure for python3-pygobject: upgrade to 3.24.1
== Series Details == Series: python3-pygobject: upgrade to 3.24.1 Revision: 1 URL : https://patchwork.openembedded.org/series/7465/ State : failure == Summary == Thank you for submitting this patch series to OpenEmbedded Core. This is an automated response. Several tests have been executed on the proposed series by patchtest resulting in the following failures: * Patchpython3-pygobject: upgrade to 3.24.1 Issue Invalid author in commit message [test_non_auh_upgrade] Suggested fixResend the series with a valid patch's author If you believe any of these test results are incorrect, please reply to the mailing list (openembedded-core@lists.openembedded.org) raising your concerns. Otherwise we would appreciate you correcting the issues and submitting a new version of the patchset if applicable. Please ensure you add/increment the version number when sending the new version (i.e. [PATCH] -> [PATCH v2] -> [PATCH v3] -> ...). --- Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest Test suite: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
[OE-core] [PATCH v2] python3-pygobject: upgrade to 3.24.1
Upgrade to latest upstream version
tested on qemux86 with core-image-sato
Signed-off-by: Jose Lamego
---
Notes:
Changes in V2:
Removed AUH reference and added test information
.../{python3-pygobject_3.22.0.bb => python3-pygobject_3.24.1.bb} | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
rename meta/recipes-devtools/python/{python3-pygobject_3.22.0.bb =>
python3-pygobject_3.24.1.bb} (87%)
diff --git a/meta/recipes-devtools/python/python3-pygobject_3.22.0.bb
b/meta/recipes-devtools/python/python3-pygobject_3.24.1.bb
similarity index 87%
rename from meta/recipes-devtools/python/python3-pygobject_3.22.0.bb
rename to meta/recipes-devtools/python/python3-pygobject_3.24.1.bb
index 143048d..5795ae3 100644
--- a/meta/recipes-devtools/python/python3-pygobject_3.22.0.bb
+++ b/meta/recipes-devtools/python/python3-pygobject_3.24.1.bb
@@ -13,8 +13,8 @@ SRC_URI = " \
file://0001-configure.ac-add-sysroot-path-to-GI_DATADIR-don-t-se.patch \
"
-SRC_URI[md5sum] = "ed4117ed5d554d25fd7718807fbf819f"
-SRC_URI[sha256sum] =
"08b29cfb08efc80f7a8630a2734dec65a99c1b59f1e5771c671d2e4ed8a5cbe7"
+SRC_URI[md5sum] = "69a843311d0f0385dff376e11a2d83d2"
+SRC_URI[sha256sum] =
"a628a95aa0909e13fb08230b1b98fc48adef10b220932f76d62f6821b3fdbffd"
S = "${WORKDIR}/${SRCNAME}-${PV}"
--
2.7.4
--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH 1/2] kernel: add package version in dependencies for kernel packages
On Wed, Jun 21, 2017 at 8:00 AM, Heghedus Razvan
wrote:
> Make all dependencies from kernel family packages which depend
> on another kernel related package to depend on the same version.
> This creates a consistent state where kernel, kernel images and
> kernel modules have the same version, making a kernel upgrade
> leading to upgrades of the image and modules.
>
> The upgrade works only if the KERNEL_VERSION_PKG_NAME remains
> the same for the newer versions.
>
> Signed-off-by: Heghedus Razvan
> ---
> meta/classes/kernel-module-split.bbclass | 7 ---
> meta/classes/kernel.bbclass | 15 +--
> meta/recipes-kernel/linux/linux-yocto.inc | 4
> 3 files changed, 17 insertions(+), 9 deletions(-)
>
> diff --git a/meta/classes/kernel-module-split.bbclass
> b/meta/classes/kernel-module-split.bbclass
> index 5e10dcf735..e247e66901 100644
> --- a/meta/classes/kernel-module-split.bbclass
> +++ b/meta/classes/kernel-module-split.bbclass
> @@ -33,7 +33,7 @@ PACKAGESPLITFUNCS_prepend =
> "split_kernel_module_packages "
> KERNEL_MODULES_META_PACKAGE ?= "kernel-modules"
>
> KERNEL_MODULE_PACKAGE_PREFIX ?= ""
> -KERNEL_MODULE_PACKAGE_SUFFIX ?= "-${KERNEL_VERSION}"
> +KERNEL_MODULE_PACKAGE_SUFFIX ?= "-${KERNEL_VERSION_PKG_NAME}"
> KERNEL_MODULE_PROVIDE_VIRTUAL ?= "1"
>
> python split_kernel_module_packages () {
> @@ -114,6 +114,7 @@ python split_kernel_module_packages () {
> for dep in vals["depends"].split(","):
> on = legitimize_package_name(dep)
> dependency_pkg = format % on
> +dependency_pkg += ' ${@get_full_package_version(d)}'
> modinfo_deps.append(dependency_pkg)
> for dep in modinfo_deps:
> if not dep in rdepends:
> @@ -138,10 +139,10 @@ python split_kernel_module_packages () {
> postinst = d.getVar('pkg_postinst_modules')
> postrm = d.getVar('pkg_postrm_modules')
>
> -modules = do_split_packages(d, root='${nonarch_base_libdir}/modules',
> file_regex=module_regex, output_pattern=module_pattern, description='%s
> kernel module', postinst=postinst, postrm=postrm, recursive=True,
> hook=frob_metadata, extra_depends='kernel-%s' %
> (d.getVar("KERNEL_VERSION")))
> +modules = do_split_packages(d, root='${nonarch_base_libdir}/modules',
> file_regex=module_regex, output_pattern=module_pattern, description='%s
> kernel module', postinst=postinst, postrm=postrm, recursive=True,
> hook=frob_metadata, extra_depends='kernel-%s %s' %
> (d.getVar("KERNEL_VERSION_PKG_NAME"), get_full_package_version(d)))
> if modules:
> metapkg = d.getVar('KERNEL_MODULES_META_PACKAGE')
> -d.appendVar('RDEPENDS_' + metapkg, ' '+' '.join(modules))
> +d.appendVar('RDEPENDS_' + metapkg, ' '+' '.join(['{0}
> {1}'.format(module, get_full_package_version(d)) for module in modules]))
>
> # If modules-load.d and modprobe.d are empty at this point, remove
> them to
> # avoid warnings. removedirs only raises an OSError if an empty
> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
> index 7a134d5c29..605c101e62 100644
> --- a/meta/classes/kernel.bbclass
> +++ b/meta/classes/kernel.bbclass
> @@ -55,7 +55,7 @@ python __anonymous () {
>
> d.setVar('FILES_kernel-image-' + typelower, '/' + imagedest + '/'
> + type + '-${KERNEL_VERSION_NAME}')
>
> -d.appendVar('RDEPENDS_kernel-image', ' ' + 'kernel-image-' +
> typelower)
> +d.appendVar('RDEPENDS_kernel-image', ' ' + 'kernel-image-' +
> typelower + ' ${@get_full_package_version(d)}')
>
> d.setVar('PKG_kernel-image-' + typelower, 'kernel-image-' +
> typelower + '-${KERNEL_VERSION_PKG_NAME}')
>
> @@ -493,14 +493,17 @@ FILES_kernel-image = ""
> FILES_kernel-dev = "/boot/System.map* /boot/Module.symvers* /boot/config*
> ${KERNEL_SRC_PATH} ${nonarch_base_libdir}/modules/${KERNEL_VERSION}/build"
> FILES_kernel-vmlinux = "/boot/vmlinux-${KERNEL_VERSION_NAME}"
> FILES_kernel-modules = ""
> -RDEPENDS_kernel = "kernel-base"
> +RDEPENDS_kernel = "kernel-base ${@get_full_package_version(d)}"
>
Is that really supposed to be a space, between kernel-base and the package
version
call ? I guess so, since I see the same thing below in the
RDEPENDS_kernel-base
line below .. but it just reads strange to me. i.e. if that's a RDEPENDS,
where is the
package get_full_package_version(d) created ?
Are you trying to set a generic versionless RDEPENDS and a versioned one
that doesn't
contain 'kernel-' in the name ?
> # Allow machines to override this dependency if kernel image files are
> # not wanted in images as standard
> -RDEPENDS_kernel-base ?= "kernel-image"
> -PKG_kernel-image = "kernel-image-${@legitimize_package_name('${KERNEL_
> VERSION}')}"
> +RDEPENDS_kernel-base ?= "kernel-image ${@get_full_package_version(d)}"
> +PKG_kernel-image = "kernel-image-${KERNEL_VERSION_PKG_NAME}"
> RDEPENDS_kernel-image += "${@base_conditional('KERNEL_IMAGETYPE',
> 'vmlinux', 'kernel
Re: [OE-core] [PATCH 2/2] kernel: user defined KERNEL_VERSION_PKG_NAME
On Wed, Jun 21, 2017 at 8:00 AM, Heghedus Razvan
wrote:
> Add possibility to set KERNEL_VERSION_PKG_NAME to a user
> defined value.
>
> Signed-off-by: Heghedus Razvan
> ---
> meta/classes/kernel.bbclass | 8 ++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
> index 605c101e62..02728d5a86 100644
> --- a/meta/classes/kernel.bbclass
> +++ b/meta/classes/kernel.bbclass
> @@ -28,12 +28,16 @@ INITRAMFS_IMAGE_BUNDLE ?= ""
> # LINUX_VERSION which is a constant.
> KERNEL_VERSION_NAME = "${@d.getVar('KERNEL_VERSION') or ""}"
> KERNEL_VERSION_NAME[vardepvalue] = "${LINUX_VERSION}"
> -KERNEL_VERSION_PKG_NAME = "${@legitimize_package_name(d.
> getVar('KERNEL_VERSION'))}"
> -KERNEL_VERSION_PKG_NAME[vardepvalue] = "${LINUX_VERSION}"
>
> python __anonymous () {
> import re
>
> +if d.getVar('USER_KERNEL_VERSION_PKG') is None :
> +d.setVar('KERNEL_VERSION_PKG_NAME',
> "${@legitimize_package_name(d.getVar('KERNEL_VERSION'))}")
> +d.setVar('KERNEL_VERSION_PKG_NAME[vardepvalue]',
> "${LINUX_VERSION}")
> +else:
> +d.setVar('KERNEL_VERSION_PKG_NAME',
> "${@legitimize_package_name(d.getVar('USER_KERNEL_VERSION_PKG'))}")
>
This is introducing yet another variable that tweaks the already complex
setting of
the kernel version. Not to mention this code is already touchy with respect
to
parse time and rebuilding of the kernel.
My concern is that if this is set, we are completely disassociated with the
source
code of the kernel.
Where did you think this would be set ? local.conf ? distro config ?
somewhere else ?
If we had a way to simply override KERNEL_VERSION, we wouldn't need any
extra
variables.
Bruce
> +
> # Merge KERNEL_IMAGETYPE and KERNEL_ALT_IMAGETYPE into
> KERNEL_IMAGETYPES
> type = d.getVar('KERNEL_IMAGETYPE') or ""
> alttype = d.getVar('KERNEL_ALT_IMAGETYPE') or ""
> --
> 2.13.1
>
> --
> ___
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
--
"Thou shalt not follow the NULL pointer, for chaos and madness await thee
at its end"
--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
[OE-core] [PATCH] cmake: Use find_program if find_host_program is not available
CMake does not define the `find_host_program` command we've
been using in the cross-compiling code path. It was
provided by a widely used Android toolchain file. For
compatibility, continue to use `find_host_program` if
available, but otherwise use just `find_program`.
Signed-off-by: Maxime Roussin-Bélanger
---
meta/recipes-devtools/cmake/cmake.inc | 1 +
...e-find_program-if-find_host_program-is-no.patch | 36 ++
2 files changed, 37 insertions(+)
create mode 100644
meta/recipes-devtools/cmake/cmake/0001-FindCUDA-Use-find_program-if-find_host_program-is-no.patch
diff --git a/meta/recipes-devtools/cmake/cmake.inc
b/meta/recipes-devtools/cmake/cmake.inc
index dbd34f5..6aeb25f 100644
--- a/meta/recipes-devtools/cmake/cmake.inc
+++ b/meta/recipes-devtools/cmake/cmake.inc
@@ -14,6 +14,7 @@ CMAKE_MAJOR_VERSION =
"${@'.'.join(d.getVar('PV').split('.')[0:2])}"
SRC_URI = "https://cmake.org/files/v${CMAKE_MAJOR_VERSION}/cmake-${PV}.tar.gz \
file://support-oe-qt4-tools-names.patch \
file://qt4-fail-silent.patch \
+
file://0001-FindCUDA-Use-find_program-if-find_host_program-is-no.patch \
"
SRC_URI[md5sum] = "b5dff61f6a7f1305271ab3f6ae261419"
diff --git
a/meta/recipes-devtools/cmake/cmake/0001-FindCUDA-Use-find_program-if-find_host_program-is-no.patch
b/meta/recipes-devtools/cmake/cmake/0001-FindCUDA-Use-find_program-if-find_host_program-is-no.patch
new file mode 100644
index 000..8a61f1f
--- /dev/null
+++
b/meta/recipes-devtools/cmake/cmake/0001-FindCUDA-Use-find_program-if-find_host_program-is-no.patch
@@ -0,0 +1,36 @@
+From 46d25e782ebd9b6c50771b6f30433c58fae03a51 Mon Sep 17 00:00:00 2001
+From: Maxime Roussin-Bélanger
+Date: Mon, 26 Jun 2017 11:30:07 -0400
+Subject: [PATCH] cmake: Use find_program if find_host_program is not
+ available
+
+CMake does not define the `find_host_program` command we've been using
+in the cross-compiling code path. It was provided by a widely used
+Android toolchain file. For compatibility, continue to use
+`find_host_program` if available, but otherwise use just `find_program`.
+
+Signed-off-by: Maxime Roussin-Bélanger
+---
+ Modules/FindCUDA.cmake | 6 +-
+ 1 file changed, 5 insertions(+), 1 deletion(-)
+
+diff --git a/Modules/FindCUDA.cmake b/Modules/FindCUDA.cmake
+index a4dca54..77ca351 100644
+--- a/Modules/FindCUDA.cmake
b/Modules/FindCUDA.cmake
+@@ -679,7 +679,11 @@ if(CMAKE_CROSSCOMPILING)
+ # add known CUDA targetr root path to the set of directories we search for
programs, libraries and headers
+ set( CMAKE_FIND_ROOT_PATH
"${CUDA_TOOLKIT_TARGET_DIR};${CMAKE_FIND_ROOT_PATH}")
+ macro( cuda_find_host_program )
+-find_host_program( ${ARGN} )
++if (COMMAND find_host_program)
++ find_host_program( ${ARGN} )
++else()
++ find_program( ${ARGN} )
++endif()
+ endmacro()
+ else()
+ # for non-cross-compile, find_host_program == find_program and
CUDA_TOOLKIT_TARGET_DIR == CUDA_TOOLKIT_ROOT_DIR
+--
+2.1.4
+
--
2.1.4
--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
[OE-core] ✗ patchtest: failure for cmake: Use find_program if find_host_program is not available
== Series Details == Series: cmake: Use find_program if find_host_program is not available Revision: 1 URL : https://patchwork.openembedded.org/series/7466/ State : failure == Summary == Thank you for submitting this patch series to OpenEmbedded Core. This is an automated response. Several tests have been executed on the proposed series by patchtest resulting in the following failures: * Issue Added patch file is missing Upstream-Status in the header [test_upstream_status_presence] Suggested fixAdd Upstream-Status: to the header of meta/recipes-devtools/cmake/cmake/0001-FindCUDA-Use-find_program-if-find_host_program-is-no.patch (possible values: Pending, Submitted, Accepted, Backport, Denied, Inappropriate) If you believe any of these test results are incorrect, please reply to the mailing list (openembedded-core@lists.openembedded.org) raising your concerns. Otherwise we would appreciate you correcting the issues and submitting a new version of the patchset if applicable. Please ensure you add/increment the version number when sending the new version (i.e. [PATCH] -> [PATCH v2] -> [PATCH v3] -> ...). --- Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest Test suite: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH] cmake: Use find_program if find_host_program is not available
On Mon, Jun 26, 2017 at 3:33 PM, Maxime Roussin-Bélanger wrote: > CMake does not define the `find_host_program` command we've > been using in the cross-compiling code path. It was > provided by a widely used Android toolchain file. For > compatibility, continue to use `find_host_program` if > available, but otherwise use just `find_program`. > > Signed-off-by: Maxime Roussin-Bélanger It sounds fine to me; the backward compatibility is maintained and it fixes a real use-case so I see no reason to not apply EXCEPT: - lack of Upstream-Status field - lack of upstream bug about the issue, ideally the proposed patch should be send to upstream so we can drop it in next releases -- Otavio Salvador O.S. Systems http://www.ossystems.com.brhttp://code.ossystems.com.br Mobile: +55 (53) 9981-7854Mobile: +1 (347) 903-9750 -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
[OE-core] [PATCH 1/2] oeqa/selftest/{context, case}: Add signal handlers SIG{INT, TERM}
In order to avoid corrupt local.conf and bblayers.conf adds
signal handlers for SIGINT and SIGTERM to restore previously
backuped configuration.
[YOCTO #11650]
Signed-off-by: Aníbal Limón
---
meta/lib/oeqa/selftest/case.py| 36 ++---
meta/lib/oeqa/selftest/context.py | 56 +++
2 files changed, 72 insertions(+), 20 deletions(-)
diff --git a/meta/lib/oeqa/selftest/case.py b/meta/lib/oeqa/selftest/case.py
index 31a11fddda9..871009c568b 100644
--- a/meta/lib/oeqa/selftest/case.py
+++ b/meta/lib/oeqa/selftest/case.py
@@ -13,28 +13,34 @@ from oeqa.utils.commands import runCmd, bitbake, get_bb_var
from oeqa.core.case import OETestCase
class OESelftestTestCase(OETestCase):
-builddir = os.environ.get("BUILDDIR") or ""
-localconf_path = os.path.join(builddir, "conf/local.conf")
-localconf_backup = os.path.join(builddir, "conf/local.bk")
-testinc_path = os.path.join(builddir, "conf/selftest.inc")
-local_bblayers_path = os.path.join(builddir, "conf/bblayers.conf")
-local_bblayers_backup = os.path.join(builddir, "conf/bblayers.bk")
-testinc_bblayers_path = os.path.join(builddir, "conf/bblayers.inc")
-machineinc_path = os.path.join(builddir, "conf/machine.inc")
-
def __init__(self, methodName="runTest"):
self._extra_tear_down_commands = []
-self._track_for_cleanup = [
-self.testinc_path, self.testinc_bblayers_path,
-self.machineinc_path, self.localconf_backup,
-self.local_bblayers_backup]
-
super(OESelftestTestCase, self).__init__(methodName)
@classmethod
def setUpClass(cls):
super(OESelftestTestCase, cls).setUpClass()
-cls.testlayer_path = cls.tc.testlayer_path
+
+cls.testlayer_path = cls.tc.config_paths['testlayer_path']
+cls.builddir = cls.tc.config_paths['builddir']
+
+cls.localconf_path = cls.tc.config_paths['localconf']
+cls.localconf_backup = cls.tc.config_paths['localconf_class_backup']
+cls.local_bblayers_path = cls.tc.config_paths['bblayers']
+cls.local_bblayers_backup =
cls.tc.config_paths['bblayers_class_backup']
+
+cls.testinc_path = os.path.join(cls.tc.config_paths['builddir'],
+"conf/selftest.inc")
+cls.testinc_bblayers_path =
os.path.join(cls.tc.config_paths['builddir'],
+"conf/bblayers.inc")
+cls.machineinc_path = os.path.join(cls.tc.config_paths['builddir'],
+"conf/machine.inc")
+
+cls._track_for_cleanup = [
+cls.testinc_path, cls.testinc_bblayers_path,
+cls.machineinc_path, cls.localconf_backup,
+cls.local_bblayers_backup]
+
cls.add_include()
@classmethod
diff --git a/meta/lib/oeqa/selftest/context.py
b/meta/lib/oeqa/selftest/context.py
index ca87398224c..e2e6283ffdc 100644
--- a/meta/lib/oeqa/selftest/context.py
+++ b/meta/lib/oeqa/selftest/context.py
@@ -6,6 +6,8 @@ import time
import glob
import sys
import imp
+import signal
+from shutil import copyfile
from random import choice
import oeqa
@@ -16,13 +18,12 @@ from oeqa.core.exception import OEQAPreRun
from oeqa.utils.commands import runCmd, get_bb_vars, get_test_layer
class OESelftestTestContext(OETestContext):
-def __init__(self, td=None, logger=None, machines=None,
testlayer_path=None):
+def __init__(self, td=None, logger=None, machines=None, config_paths=None):
super(OESelftestTestContext, self).__init__(td, logger)
self.machines = machines
self.custommachine = None
-
-self.testlayer_path = testlayer_path
+self.config_paths = config_paths
def runTests(self, machine=None):
if machine:
@@ -108,7 +109,29 @@ class OESelftestTestContextExecutor(OETestContextExecutor):
self.tc_kwargs['init']['td'] = get_bb_vars()
self.tc_kwargs['init']['machines'] = self._get_available_machines()
-self.tc_kwargs['init']['testlayer_path'] = get_test_layer()
+
+builddir = os.environ.get("BUILDDIR")
+self.tc_kwargs['init']['config_paths'] = {}
+self.tc_kwargs['init']['config_paths']['testlayer_path'] = \
+get_test_layer()
+self.tc_kwargs['init']['config_paths']['builddir'] = builddir
+self.tc_kwargs['init']['config_paths']['localconf'] = \
+os.path.join(builddir, "conf/local.conf")
+self.tc_kwargs['init']['config_paths']['localconf_backup'] = \
+os.path.join(builddir, "conf/local.conf.orig")
+self.tc_kwargs['init']['config_paths']['localconf_class_backup'] = \
+os.path.join(builddir, "conf/local.conf.bk")
+self.tc_kwargs['init']['config_paths']['bblayers'] = \
+os.path.join(builddir, "conf/bblayers.conf")
+self.tc_kwargs['init']['config_paths']['bblayers_backup'] = \
+os.path.join(builddir, "conf/bblayers.conf.orig")
+
[OE-core] [PATCH 2/2] selftest/cases/package: Call parent setUpClass method
Since config paths are now passed in Test context the setUpClass
method is expected to be call.
Signed-off-by: Aníbal Limón
---
meta/lib/oeqa/selftest/cases/package.py | 2 ++
1 file changed, 2 insertions(+)
diff --git a/meta/lib/oeqa/selftest/cases/package.py
b/meta/lib/oeqa/selftest/cases/package.py
index 5b9a6d15851..b07d6ed0abe 100644
--- a/meta/lib/oeqa/selftest/cases/package.py
+++ b/meta/lib/oeqa/selftest/cases/package.py
@@ -17,6 +17,8 @@ class VersionOrdering(OESelftestTestCase):
@classmethod
def setUpClass(cls):
+super(VersionOrdering, cls).setUpClass()
+
# Build the tools we need and populate a sysroot
bitbake("dpkg-native opkg-native rpm-native python3-native")
bitbake("build-sysroots -c build_native_sysroot")
--
2.11.0
--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH v2] systemd: work-around ppc gold linker error
On 2017-06-22 08:30 PM, Randy MacLeod wrote: On 2017-06-22 06:22 PM, Khem Raj wrote: What's the link to upstream bug in linker Do you mean: Have I created an upstream bug? No, not yet but I'm just reading their email lists and trying to understand where and how to report the bug. Done: https://sourceware.org/bugzilla/show_bug.cgi?id=21678 I haven't made any progress on testing master. I should have time this week. Oh, webkitgtk_2.16.1 also fails for qemuppc with a similar error. -- # Randy MacLeod. SMTS, Linux, Wind River Direct: 613.963.1350 | 350 Terry Fox Drive, Suite 200, Ottawa, ON, Canada, K2K 2W5 -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH] cmake: Use find_program if find_host_program is not available
On Mon, Jun 26, 2017 at 04:41:34PM -0300, Otavio Salvador wrote: > On Mon, Jun 26, 2017 at 3:33 PM, Maxime Roussin-Bélanger > wrote: > > CMake does not define the `find_host_program` command we've > > been using in the cross-compiling code path. It was > > provided by a widely used Android toolchain file. For > > compatibility, continue to use `find_host_program` if > > available, but otherwise use just `find_program`. > > > > Signed-off-by: Maxime Roussin-Bélanger > > It sounds fine to me; the backward compatibility is maintained and it > fixes a real use-case so I see no reason to not apply EXCEPT: > > - lack of Upstream-Status field > - lack of upstream bug about the issue, ideally the proposed patch > should be send to upstream so we can drop it in next releases > I just got r/w access to the poky-contrib repository. Do I have to create a pull-request/send-pull-request to get an upstream-status field? Can we ignore this email and just use the pull-request script instead? If so, do I have to resend the same patch (V2 ?) to the same recipients? If not, how do I get an upstream-status? I just pushed my branch to contrib repository (mroussin/fix_cmake_find_cuda_not_android), does that mean pending? > -- > Otavio Salvador O.S. Systems > http://www.ossystems.com.brhttp://code.ossystems.com.br > Mobile: +55 (53) 9981-7854Mobile: +1 (347) 903-9750 -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
[OE-core] Package Manager Conflicts
I'm attempting to setup a package feed for a board which I don't have the ability to flash nor do I have access to the original image that is on it. The image on the board comes with Smart installed. I build an image using the information in this guide: https://www.openembedded.org/wiki/OE-Core_Standalone_Setup and add my dependencies before doing: bitbake core-image-minimal and bitbake package-feed However when I attempt to install a package via smart I get this error Committing transaction... error: update-alternatives-opkg-0.3.4+git0+1a708fd73d-r0 conflicts with update-alternatives-cworth I can't find any information referencing this issue, is there a way I can completely strip opkg from the oe-core layer or a solution to this problem? -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
[OE-core] [PATCH][pyro] systemd-boot.bbclass: Add configuration data to secondary EFI partition
The secondary EFI partition is used when booting in EFI mode, and
without the configuration data we don't get any boot targets.
Partial fix to [YOCTO #11503].
(From OE-Core master rev: 84aa7a00810e135fdad3f77bdb1da7d1f5fb8627)
Signed-off-by: California Sullivan
Signed-off-by: Ross Burton
---
meta/classes/systemd-boot.bbclass | 1 +
1 file changed, 1 insertion(+)
diff --git a/meta/classes/systemd-boot.bbclass
b/meta/classes/systemd-boot.bbclass
index 4e69a2c..9597759 100644
--- a/meta/classes/systemd-boot.bbclass
+++ b/meta/classes/systemd-boot.bbclass
@@ -50,6 +50,7 @@ efi_iso_populate() {
efi_populate $iso_dir
mkdir -p ${EFIIMGDIR}/${EFIDIR}
cp $iso_dir/${EFIDIR}/* ${EFIIMGDIR}${EFIDIR}
+cp -r $iso_dir/loader ${EFIIMGDIR}
cp $iso_dir/vmlinuz ${EFIIMGDIR}
EFIPATH=$(echo "${EFIDIR}" | sed 's/\//\\/g')
echo "fs0:${EFIPATH}\\${DEST_EFI_IMAGE}" > ${EFIIMGDIR}/startup.nsh
--
2.9.4
--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
[OE-core] [poky][Patch] bluez: Correct the timer count for bcm43xx firmware download
bcm43xx failed as time out for firmware downloading.
The root cause is that it need wait 50ms to download firmware,
but the value of 50us is set to the timer.
Signed-off-by: Jun Zhu
---
meta/recipes-connectivity/bluez5/bluez5.inc| 1 +
...cm43xx-fix-the-delay-timer-for-firmware-d.patch | 34 ++
2 files changed, 35 insertions(+)
create mode 100644
meta/recipes-connectivity/bluez5/bluez5/0001-hciattach-bcm43xx-fix-the-delay-timer-for-firmware-d.patch
diff --git a/meta/recipes-connectivity/bluez5/bluez5.inc
b/meta/recipes-connectivity/bluez5/bluez5.inc
index 01ade7d..2c10479 100644
--- a/meta/recipes-connectivity/bluez5/bluez5.inc
+++ b/meta/recipes-connectivity/bluez5/bluez5.inc
@@ -27,6 +27,7 @@ SRC_URI = "\
file://run-ptest \
${@bb.utils.contains('DISTRO_FEATURES', 'systemd', '',
'file://0001-Allow-using-obexd-without-systemd-in-the-user-sessio.patch', d)} \
file://0001-tests-add-a-target-for-building-tests-without-runnin.patch \
+file://0001-hciattach-bcm43xx-fix-the-delay-timer-for-firmware-d.patch \
"
S = "${WORKDIR}/bluez-${PV}"
diff --git
a/meta/recipes-connectivity/bluez5/bluez5/0001-hciattach-bcm43xx-fix-the-delay-timer-for-firmware-d.patch
b/meta/recipes-connectivity/bluez5/bluez5/0001-hciattach-bcm43xx-fix-the-delay-timer-for-firmware-d.patch
new file mode 100644
index 000..bd55477
--- /dev/null
+++
b/meta/recipes-connectivity/bluez5/bluez5/0001-hciattach-bcm43xx-fix-the-delay-timer-for-firmware-d.patch
@@ -0,0 +1,34 @@
+From 3b341fb421ef61db7782bf1314ec693828467de9 Mon Sep 17 00:00:00 2001
+From: Andy Duan
+Date: Wed, 23 Nov 2016 17:12:12 +0800
+Subject: [PATCH] hciattach: bcm43xx: fix the delay timer for firmware download
+
+From the log in .bcm43xx_load_firmware():
+/* Wait 50ms to let the firmware placed in download mode */
+nanosleep(&tm_mode, NULL);
+
+But timespec tm_mode is real is 50us. Correct the delayed timer count.
+
+Signed-off-by: Fugang Duan
+---
+ tools/hciattach_bcm43xx.c | 4 ++--
+ 1 file changed, 2 insertions(+), 2 deletions(-)
+
+diff --git a/tools/hciattach_bcm43xx.c b/tools/hciattach_bcm43xx.c
+index 81f38cb..ac1b3c1 100644
+--- a/tools/hciattach_bcm43xx.c
b/tools/hciattach_bcm43xx.c
+@@ -228,8 +228,8 @@ static int bcm43xx_set_speed(int fd, struct termios *ti,
uint32_t speed)
+ static int bcm43xx_load_firmware(int fd, const char *fw)
+ {
+ unsigned char cmd[] = { HCI_COMMAND_PKT, 0x2e, 0xfc, 0x00 };
+- struct timespec tm_mode = { 0, 5 };
+- struct timespec tm_ready = { 0, 200 };
++ struct timespec tm_mode = { 0, 5000 };
++ struct timespec tm_ready = { 0, 2 };
+ unsigned char resp[CC_MIN_SIZE];
+ unsigned char tx_buf[1024];
+ int len, fd_fw, n;
+--
+1.9.1
+
--
2.7.4
--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH 1/2] oeqa/selftest/{context, case}: Add signal handlers SIG{INT, TERM}
On Mon, 2017-06-26 at 15:42 -0500, Aníbal Limón wrote: > def run(self, logger, args): > self._process_args(logger, args) > + > +signal.signal(signal.SIGTERM, self._signal_clean_handler) > +signal.signal(signal.SIGINT, self._signal_clean_handler) > + > rc = None > > if args.machine: > @@ -220,6 +264,8 @@ class > OESelftestTestContextExecutor(OETestContextExecutor): > os.remove(output_link) > os.symlink(args.output_log, output_link) > > +self._signal_clean_handler(None, None) > + Can't you achieve the same thing with less code by using a try: ... modify configuration ... ... run tests ... finally: ... clean up ... block in run()? Then you are also guaranteed to clean up if an unexpected exception triggers the aborting of run(). -- Best Regards, Patrick Ohly The content of this message is my personal opinion only and although I am an employee of Intel, the statements I make here in no way represent Intel's position on the issue, nor am I authorized to speak on behalf of Intel on this matter. -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
