Re: [OE-core] [PATCH] Revert "wic: Set a miniumum FAT16 volume size."
ping? On Thu, 21 Mar 2019 at 16:49, Angus Lees wrote: > This reverts commit f7dfb4d43247d3c13a4e0a3853007d63b9512b83. > > FAT16 volumes do not have a minimum size of 8250 blocks > (== slightly over 4MB). Exhibit A: floppy disks. > > The original commit message suggests this was a workaround for a bug in > parted - in which case we should fix it there, or use the wic > `--fixed-size` option to pass down an enforced minimum from a more > context-aware point in the callstack. > --- > (This should also be backported to sumo) > > scripts/lib/wic/partition.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/lib/wic/partition.py b/scripts/lib/wic/partition.py > index 3fe5c4e26c..2178321404 100644 > --- a/scripts/lib/wic/partition.py > +++ b/scripts/lib/wic/partition.py > @@ -322,7 +322,7 @@ class Partition(): > > dosfs_cmd = "mkdosfs %s -i %s %s %s -C %s %d" % \ > (label_str, self.fsuuid, size_str, extraopts, rootfs, > - max(8250, rootfs_size)) > + rootfs_size) > exec_native_cmd(dosfs_cmd, native_sysroot) > > mcopy_cmd = "mcopy -i %s -s %s/* ::/" % (rootfs, rootfs_dir) > -- > 2.11.0 > > -- - Gus -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
[OE-core] [PATCH] webkitgtk: Fix build with clang
Newer version of webkitgtk has some compile failures with clang/libc++ combination. Signed-off-by: Khem Raj --- .../webkit/webkitgtk/include_array.patch | 15 + .../webkit/webkitgtk/narrowing.patch | 31 +++ .../webkit/webkitgtk/snprintf.patch | 15 + meta/recipes-sato/webkit/webkitgtk_2.24.0.bb | 3 ++ 4 files changed, 64 insertions(+) create mode 100644 meta/recipes-sato/webkit/webkitgtk/include_array.patch create mode 100644 meta/recipes-sato/webkit/webkitgtk/narrowing.patch create mode 100644 meta/recipes-sato/webkit/webkitgtk/snprintf.patch diff --git a/meta/recipes-sato/webkit/webkitgtk/include_array.patch b/meta/recipes-sato/webkit/webkitgtk/include_array.patch new file mode 100644 index 00..7268b04bf4 --- /dev/null +++ b/meta/recipes-sato/webkit/webkitgtk/include_array.patch @@ -0,0 +1,15 @@ +Added missing include for std::array + +Upstream-Status: Submitted [https://bugs.webkit.org/show_bug.cgi?id=197085] +Signed-off-by: Khem Raj + +--- webkitgtk-2.24.0/Source/JavaScriptCore/assembler/PerfLog.cpp.org 2019-04-18 18:03:50.226231691 -0700 webkitgtk-2.24.0/Source/JavaScriptCore/assembler/PerfLog.cpp 2019-04-18 18:07:28.569153989 -0700 +@@ -31,6 +31,7 @@ + #include + #include + #include ++#include + #include + #include + #include diff --git a/meta/recipes-sato/webkit/webkitgtk/narrowing.patch b/meta/recipes-sato/webkit/webkitgtk/narrowing.patch new file mode 100644 index 00..598b6b5df5 --- /dev/null +++ b/meta/recipes-sato/webkit/webkitgtk/narrowing.patch @@ -0,0 +1,31 @@ +Fix build with clang on arm where char is unsigned + +Upstream-Status: Submitted [https://bugs.webkit.org/show_bug.cgi?id=197087] +Signed-off-by: Khem Raj + +--- a/Source/WebCore/contentextensions/DFACombiner.cpp b/Source/WebCore/contentextensions/DFACombiner.cpp +@@ -37,7 +37,7 @@ namespace WebCore { + namespace ContentExtensions { + + class DFAMerger { +-typedef MutableRangeList CombinedTransitionsMutableRangeList; ++typedef MutableRangeList CombinedTransitionsMutableRangeList; + + enum class WhichDFA { + A, +--- a/Source/WebCore/contentextensions/NFAToDFA.cpp b/Source/WebCore/contentextensions/NFAToDFA.cpp +@@ -41,9 +41,9 @@ namespace WebCore { + + namespace ContentExtensions { + +-typedef MutableRange NFANodeRange; +-typedef MutableRangeList NFANodeRangeList; +-typedef MutableRangeList PreallocatedNFANodeRangeList; ++typedef MutableRange NFANodeRange; ++typedef MutableRangeList NFANodeRangeList; ++typedef MutableRangeList PreallocatedNFANodeRangeList; + typedef Vector UniqueNodeList; + typedef Vector NFANodeClosures; + diff --git a/meta/recipes-sato/webkit/webkitgtk/snprintf.patch b/meta/recipes-sato/webkit/webkitgtk/snprintf.patch new file mode 100644 index 00..b1481d78e8 --- /dev/null +++ b/meta/recipes-sato/webkit/webkitgtk/snprintf.patch @@ -0,0 +1,15 @@ +include missing header for snprintf definition + +Upstream-Status: Submitted [https://bugs.webkit.org/show_bug.cgi?id=197088] +Signed-off-by: Khem Raj + +--- a/Source/WebCore/platform/text/TextCodec.cpp b/Source/WebCore/platform/text/TextCodec.cpp +@@ -28,6 +28,7 @@ + #include "TextCodec.h" + + #include ++#include + + namespace WebCore { + diff --git a/meta/recipes-sato/webkit/webkitgtk_2.24.0.bb b/meta/recipes-sato/webkit/webkitgtk_2.24.0.bb index 4a82dae9ef..a023a369f7 100644 --- a/meta/recipes-sato/webkit/webkitgtk_2.24.0.bb +++ b/meta/recipes-sato/webkit/webkitgtk_2.24.0.bb @@ -20,6 +20,9 @@ SRC_URI = "http://www.webkitgtk.org/releases/${BPN}-${PV}.tar.xz \ file://0001-WebKitMacros-Append-to-I-and-not-to-isystem.patch \ file://0001-Fix-build-with-musl.patch \ file://detect-gstreamer-gl.patch \ + file://include_array.patch \ + file://narrowing.patch \ + file://snprintf.patch \ " SRC_URI[md5sum] = "576d69c598b3e36c73441052d02466de" -- 2.21.0 -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH] valgrind: update from 3.14.0 to 3.15.0
On Fri, Apr 19, 2019 at 2:27 PM Randy MacLeod wrote: > > On 4/19/19 3:01 PM, Randy MacLeod wrote: > > The SRC_URI moved. > > Two local patches are now fixed upstream so remove them. > > > > The glibc ptest results are essentially the same. > s/glibc/qemux86-64 glibc/ > > > > 3.14 3.15 > > TOTAL:579 589 > > PASSED: 297 301 > > FAILED: 251 254 > > SKIPPED: 3134 > > DURATION:1312 1171 > > I hope to have time to fix some of these valgrind ptest failures > but I didn't want to hold back the update. > > Build tested for all qemu machines, for both glibc and musl. > > I'm building core-image-sato-sdk-ptest for qemuarm64 now but > it will be a while so merge if you like or wait for an update > and a v2 with minor improvements. Randy, Might this be related to or fix https://bugzilla.yoctoproject.org/show_bug.cgi?id=13302 ? > > ../Randy > > > > > Signed-off-by: Randy MacLeod > > --- > > ...-between-libcoregrind-.a-and-m_main..patch | 45 --- > > ...ts-amd64-Do-not-clobber-rsp-register.patch | 37 --- > > ...{valgrind_3.14.0.bb => valgrind_3.15.0.bb} | 8 ++-- > > 3 files changed, 3 insertions(+), 87 deletions(-) > > delete mode 100644 > > meta/recipes-devtools/valgrind/valgrind/0001-Fix-dependencies-between-libcoregrind-.a-and-m_main..patch > > delete mode 100644 > > meta/recipes-devtools/valgrind/valgrind/0001-tests-amd64-Do-not-clobber-rsp-register.patch > > rename meta/recipes-devtools/valgrind/{valgrind_3.14.0.bb => > > valgrind_3.15.0.bb} (94%) > > > > diff --git > > a/meta/recipes-devtools/valgrind/valgrind/0001-Fix-dependencies-between-libcoregrind-.a-and-m_main..patch > > > > b/meta/recipes-devtools/valgrind/valgrind/0001-Fix-dependencies-between-libcoregrind-.a-and-m_main..patch > > deleted file mode 100644 > > index bedf1c1274..00 > > --- > > a/meta/recipes-devtools/valgrind/valgrind/0001-Fix-dependencies-between-libcoregrind-.a-and-m_main..patch > > +++ /dev/null > > @@ -1,45 +0,0 @@ > > -From 7820fc268fae4353118b6355f1d4b9e1b7eeebec Mon Sep 17 00:00:00 2001 > > -From: Philippe Waroquiers > > -Date: Sun, 28 Oct 2018 18:35:11 +0100 > > -Subject: [PATCH] Fix dependencies between libcoregrind*.a and > > - *m_main.o/*m_libcsetjmp.o > > - > > -The primary and secondary coregrind libraries must be updated > > -when m_main.c or m_libcsetjmp.c are changed. > > - > > -A dependency was missing between libcoregrind*.a and libnolto_coregrind*.a, > > -and so tools were not relinked when m_main.c or m_libcsetjmp.c were > > -changed. > > - > > -Upstream-Status: Backport[git://sourceware.org/git/valgrind.git > > 7820fc268fae4353118b6355f1d4b9e1b7eeebec] > > - > > -Signed-off-by: Robert Yang > > > > - coregrind/Makefile.am | 4 > > - 1 file changed, 4 insertions(+) > > - > > -diff --git a/coregrind/Makefile.am b/coregrind/Makefile.am > > -index 914a270..8de1996 100644 > > a/coregrind/Makefile.am > > -+++ b/coregrind/Makefile.am > > -@@ -511,6 +511,8 @@ libcoregrind_@VGCONF_ARCH_PRI@_@VGCONF_OS@_a_CFLAGS += > > \ > > - endif > > - libcoregrind_@VGCONF_ARCH_PRI@_@VGCONF_OS@_a_LIBADD = \ > > - $(libnolto_coregrind_@VGCONF_ARCH_PRI@_@VGCONF_OS@_a_OBJECTS) > > -+libcoregrind_@VGCONF_ARCH_PRI@_@VGCONF_OS@_a_DEPENDENCIES = \ > > -+libnolto_coregrind-@VGCONF_ARCH_PRI@-@VGCONF_OS@.a > > - > > - if VGCONF_HAVE_PLATFORM_SEC > > - libcoregrind_@VGCONF_ARCH_SEC@_@VGCONF_OS@_a_SOURCES = \ > > -@@ -531,6 +533,8 @@ libcoregrind_@VGCONF_ARCH_SEC@_@VGCONF_OS@_a_CFLAGS += > > \ > > - endif > > - libcoregrind_@VGCONF_ARCH_SEC@_@VGCONF_OS@_a_LIBADD = \ > > - $(libnolto_coregrind_@VGCONF_ARCH_SEC@_@VGCONF_OS@_a_OBJECTS) > > -+libcoregrind_@VGCONF_ARCH_SEC@_@VGCONF_OS@_a_DEPENDENCIES = \ > > -+libnolto_coregrind-@VGCONF_ARCH_SEC@-@VGCONF_OS@.a > > - endif > > - > > - > > # > > --- > > -2.10.2 > > - > > diff --git > > a/meta/recipes-devtools/valgrind/valgrind/0001-tests-amd64-Do-not-clobber-rsp-register.patch > > > > b/meta/recipes-devtools/valgrind/valgrind/0001-tests-amd64-Do-not-clobber-rsp-register.patch > > deleted file mode 100644 > > index 657f80335d..00 > > --- > > a/meta/recipes-devtools/valgrind/valgrind/0001-tests-amd64-Do-not-clobber-rsp-register.patch > > +++ /dev/null > > @@ -1,37 +0,0 @@ > > -From 8c1ebb564f5eca2baeedc27a703200786d1abb0b Mon Sep 17 00:00:00 2001 > > -From: Khem Raj > > -Date: Sat, 22 Dec 2018 15:28:40 -0800 > > -Subject: [PATCH] tests/amd64: Do not clobber %rsp register > > - > > -This is seen with gcc-9.0 compiler now which is fix that gcc community > > -did recently > > -https://gcc.gnu.org/bugzilla/show_bug.cgi?id=52813 > > - > > -Upstream-Status: Submitted [https://bugs.kde.org/show_bug.cgi?id=402480] > > - > > -Signed-off-by: Khem Raj > > > > - none/tests/amd64-linux/bug345887.c | 5 +++-- > > - 1 file changed, 3 insertions(+), 2 deletions(-) > > - > > -diff --git
[OE-core] [oe-core][PATCH 1/1] gdk-pixbuf: add timeout to run-ptest
The default timeout of 300 seconds is far too low for qemu bsp's. Signed-off-by: Joe Slater --- meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf/run-ptest | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf/run-ptest b/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf/run-ptest index 8f90723..b4f982b 100644 --- a/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf/run-ptest +++ b/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf/run-ptest @@ -1,3 +1,5 @@ #! /bin/sh -gnome-desktop-testing-runner gdk-pixbuf +# The default timeout of 300 seconds is far too low for qemu bsp's. +# +gnome-desktop-testing-runner -t 2400 gdk-pixbuf -- 2.7.4 -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH] valgrind: update from 3.14.0 to 3.15.0
On 4/19/19 3:01 PM, Randy MacLeod wrote: The SRC_URI moved. Two local patches are now fixed upstream so remove them. The glibc ptest results are essentially the same. s/glibc/qemux86-64 glibc/ 3.14 3.15 TOTAL:579 589 PASSED: 297 301 FAILED: 251 254 SKIPPED: 3134 DURATION:1312 1171 I hope to have time to fix some of these valgrind ptest failures but I didn't want to hold back the update. Build tested for all qemu machines, for both glibc and musl. I'm building core-image-sato-sdk-ptest for qemuarm64 now but it will be a while so merge if you like or wait for an update and a v2 with minor improvements. ../Randy Signed-off-by: Randy MacLeod --- ...-between-libcoregrind-.a-and-m_main..patch | 45 --- ...ts-amd64-Do-not-clobber-rsp-register.patch | 37 --- ...{valgrind_3.14.0.bb => valgrind_3.15.0.bb} | 8 ++-- 3 files changed, 3 insertions(+), 87 deletions(-) delete mode 100644 meta/recipes-devtools/valgrind/valgrind/0001-Fix-dependencies-between-libcoregrind-.a-and-m_main..patch delete mode 100644 meta/recipes-devtools/valgrind/valgrind/0001-tests-amd64-Do-not-clobber-rsp-register.patch rename meta/recipes-devtools/valgrind/{valgrind_3.14.0.bb => valgrind_3.15.0.bb} (94%) diff --git a/meta/recipes-devtools/valgrind/valgrind/0001-Fix-dependencies-between-libcoregrind-.a-and-m_main..patch b/meta/recipes-devtools/valgrind/valgrind/0001-Fix-dependencies-between-libcoregrind-.a-and-m_main..patch deleted file mode 100644 index bedf1c1274..00 --- a/meta/recipes-devtools/valgrind/valgrind/0001-Fix-dependencies-between-libcoregrind-.a-and-m_main..patch +++ /dev/null @@ -1,45 +0,0 @@ -From 7820fc268fae4353118b6355f1d4b9e1b7eeebec Mon Sep 17 00:00:00 2001 -From: Philippe Waroquiers -Date: Sun, 28 Oct 2018 18:35:11 +0100 -Subject: [PATCH] Fix dependencies between libcoregrind*.a and - *m_main.o/*m_libcsetjmp.o - -The primary and secondary coregrind libraries must be updated -when m_main.c or m_libcsetjmp.c are changed. - -A dependency was missing between libcoregrind*.a and libnolto_coregrind*.a, -and so tools were not relinked when m_main.c or m_libcsetjmp.c were -changed. - -Upstream-Status: Backport[git://sourceware.org/git/valgrind.git 7820fc268fae4353118b6355f1d4b9e1b7eeebec] - -Signed-off-by: Robert Yang - coregrind/Makefile.am | 4 - 1 file changed, 4 insertions(+) - -diff --git a/coregrind/Makefile.am b/coregrind/Makefile.am -index 914a270..8de1996 100644 a/coregrind/Makefile.am -+++ b/coregrind/Makefile.am -@@ -511,6 +511,8 @@ libcoregrind_@VGCONF_ARCH_PRI@_@VGCONF_OS@_a_CFLAGS += \ - endif - libcoregrind_@VGCONF_ARCH_PRI@_@VGCONF_OS@_a_LIBADD = \ - $(libnolto_coregrind_@VGCONF_ARCH_PRI@_@VGCONF_OS@_a_OBJECTS) -+libcoregrind_@VGCONF_ARCH_PRI@_@VGCONF_OS@_a_DEPENDENCIES = \ -+libnolto_coregrind-@VGCONF_ARCH_PRI@-@VGCONF_OS@.a - - if VGCONF_HAVE_PLATFORM_SEC - libcoregrind_@VGCONF_ARCH_SEC@_@VGCONF_OS@_a_SOURCES = \ -@@ -531,6 +533,8 @@ libcoregrind_@VGCONF_ARCH_SEC@_@VGCONF_OS@_a_CFLAGS += \ - endif - libcoregrind_@VGCONF_ARCH_SEC@_@VGCONF_OS@_a_LIBADD = \ - $(libnolto_coregrind_@VGCONF_ARCH_SEC@_@VGCONF_OS@_a_OBJECTS) -+libcoregrind_@VGCONF_ARCH_SEC@_@VGCONF_OS@_a_DEPENDENCIES = \ -+libnolto_coregrind-@VGCONF_ARCH_SEC@-@VGCONF_OS@.a - endif - - # --- -2.10.2 - diff --git a/meta/recipes-devtools/valgrind/valgrind/0001-tests-amd64-Do-not-clobber-rsp-register.patch b/meta/recipes-devtools/valgrind/valgrind/0001-tests-amd64-Do-not-clobber-rsp-register.patch deleted file mode 100644 index 657f80335d..00 --- a/meta/recipes-devtools/valgrind/valgrind/0001-tests-amd64-Do-not-clobber-rsp-register.patch +++ /dev/null @@ -1,37 +0,0 @@ -From 8c1ebb564f5eca2baeedc27a703200786d1abb0b Mon Sep 17 00:00:00 2001 -From: Khem Raj -Date: Sat, 22 Dec 2018 15:28:40 -0800 -Subject: [PATCH] tests/amd64: Do not clobber %rsp register - -This is seen with gcc-9.0 compiler now which is fix that gcc community -did recently -https://gcc.gnu.org/bugzilla/show_bug.cgi?id=52813 - -Upstream-Status: Submitted [https://bugs.kde.org/show_bug.cgi?id=402480] - -Signed-off-by: Khem Raj - none/tests/amd64-linux/bug345887.c | 5 +++-- - 1 file changed, 3 insertions(+), 2 deletions(-) - -diff --git a/none/tests/amd64-linux/bug345887.c b/none/tests/amd64-linux/bug345887.c -index 0f9237d..4b07fe1 100644 a/none/tests/amd64-linux/bug345887.c -+++ b/none/tests/amd64-linux/bug345887.c -@@ -20,13 +20,14 @@ static void inner(void) - "movq $0x10d, %%r14\n" - "movq $0x10e, %%r15\n" - // not %rbp as mdb is then not able to reconstruct stack trace -- "movq $0x10f, %%rsp\n" -+ // not %rsp since gcc ignores it and since gcc >= 9.0 errors about it -+ // see https://gcc.gnu.org/bugzilla/show_bug.cgi?id=52813 - "movq $0x1234, (%%rax)\n" // should cause SEGV here - "ud2"
[OE-core] [PATCH] valgrind: update from 3.14.0 to 3.15.0
The SRC_URI moved. Two local patches are now fixed upstream so remove them. The glibc ptest results are essentially the same. 3.14 3.15 TOTAL:579 589 PASSED: 297 301 FAILED: 251 254 SKIPPED: 3134 DURATION:1312 1171 Signed-off-by: Randy MacLeod --- ...-between-libcoregrind-.a-and-m_main..patch | 45 --- ...ts-amd64-Do-not-clobber-rsp-register.patch | 37 --- ...{valgrind_3.14.0.bb => valgrind_3.15.0.bb} | 8 ++-- 3 files changed, 3 insertions(+), 87 deletions(-) delete mode 100644 meta/recipes-devtools/valgrind/valgrind/0001-Fix-dependencies-between-libcoregrind-.a-and-m_main..patch delete mode 100644 meta/recipes-devtools/valgrind/valgrind/0001-tests-amd64-Do-not-clobber-rsp-register.patch rename meta/recipes-devtools/valgrind/{valgrind_3.14.0.bb => valgrind_3.15.0.bb} (94%) diff --git a/meta/recipes-devtools/valgrind/valgrind/0001-Fix-dependencies-between-libcoregrind-.a-and-m_main..patch b/meta/recipes-devtools/valgrind/valgrind/0001-Fix-dependencies-between-libcoregrind-.a-and-m_main..patch deleted file mode 100644 index bedf1c1274..00 --- a/meta/recipes-devtools/valgrind/valgrind/0001-Fix-dependencies-between-libcoregrind-.a-and-m_main..patch +++ /dev/null @@ -1,45 +0,0 @@ -From 7820fc268fae4353118b6355f1d4b9e1b7eeebec Mon Sep 17 00:00:00 2001 -From: Philippe Waroquiers -Date: Sun, 28 Oct 2018 18:35:11 +0100 -Subject: [PATCH] Fix dependencies between libcoregrind*.a and - *m_main.o/*m_libcsetjmp.o - -The primary and secondary coregrind libraries must be updated -when m_main.c or m_libcsetjmp.c are changed. - -A dependency was missing between libcoregrind*.a and libnolto_coregrind*.a, -and so tools were not relinked when m_main.c or m_libcsetjmp.c were -changed. - -Upstream-Status: Backport[git://sourceware.org/git/valgrind.git 7820fc268fae4353118b6355f1d4b9e1b7eeebec] - -Signed-off-by: Robert Yang - coregrind/Makefile.am | 4 - 1 file changed, 4 insertions(+) - -diff --git a/coregrind/Makefile.am b/coregrind/Makefile.am -index 914a270..8de1996 100644 a/coregrind/Makefile.am -+++ b/coregrind/Makefile.am -@@ -511,6 +511,8 @@ libcoregrind_@VGCONF_ARCH_PRI@_@VGCONF_OS@_a_CFLAGS += \ - endif - libcoregrind_@VGCONF_ARCH_PRI@_@VGCONF_OS@_a_LIBADD = \ - $(libnolto_coregrind_@VGCONF_ARCH_PRI@_@VGCONF_OS@_a_OBJECTS) -+libcoregrind_@VGCONF_ARCH_PRI@_@VGCONF_OS@_a_DEPENDENCIES = \ -+libnolto_coregrind-@VGCONF_ARCH_PRI@-@VGCONF_OS@.a - - if VGCONF_HAVE_PLATFORM_SEC - libcoregrind_@VGCONF_ARCH_SEC@_@VGCONF_OS@_a_SOURCES = \ -@@ -531,6 +533,8 @@ libcoregrind_@VGCONF_ARCH_SEC@_@VGCONF_OS@_a_CFLAGS += \ - endif - libcoregrind_@VGCONF_ARCH_SEC@_@VGCONF_OS@_a_LIBADD = \ - $(libnolto_coregrind_@VGCONF_ARCH_SEC@_@VGCONF_OS@_a_OBJECTS) -+libcoregrind_@VGCONF_ARCH_SEC@_@VGCONF_OS@_a_DEPENDENCIES = \ -+libnolto_coregrind-@VGCONF_ARCH_SEC@-@VGCONF_OS@.a - endif - - # --- -2.10.2 - diff --git a/meta/recipes-devtools/valgrind/valgrind/0001-tests-amd64-Do-not-clobber-rsp-register.patch b/meta/recipes-devtools/valgrind/valgrind/0001-tests-amd64-Do-not-clobber-rsp-register.patch deleted file mode 100644 index 657f80335d..00 --- a/meta/recipes-devtools/valgrind/valgrind/0001-tests-amd64-Do-not-clobber-rsp-register.patch +++ /dev/null @@ -1,37 +0,0 @@ -From 8c1ebb564f5eca2baeedc27a703200786d1abb0b Mon Sep 17 00:00:00 2001 -From: Khem Raj -Date: Sat, 22 Dec 2018 15:28:40 -0800 -Subject: [PATCH] tests/amd64: Do not clobber %rsp register - -This is seen with gcc-9.0 compiler now which is fix that gcc community -did recently -https://gcc.gnu.org/bugzilla/show_bug.cgi?id=52813 - -Upstream-Status: Submitted [https://bugs.kde.org/show_bug.cgi?id=402480] - -Signed-off-by: Khem Raj - none/tests/amd64-linux/bug345887.c | 5 +++-- - 1 file changed, 3 insertions(+), 2 deletions(-) - -diff --git a/none/tests/amd64-linux/bug345887.c b/none/tests/amd64-linux/bug345887.c -index 0f9237d..4b07fe1 100644 a/none/tests/amd64-linux/bug345887.c -+++ b/none/tests/amd64-linux/bug345887.c -@@ -20,13 +20,14 @@ static void inner(void) - "movq $0x10d, %%r14\n" - "movq $0x10e, %%r15\n" - // not %rbp as mdb is then not able to reconstruct stack trace -- "movq $0x10f, %%rsp\n" -+ // not %rsp since gcc ignores it and since gcc >= 9.0 errors about it -+ // see https://gcc.gnu.org/bugzilla/show_bug.cgi?id=52813 - "movq $0x1234, (%%rax)\n" // should cause SEGV here - "ud2" // should never get here - : // no output registers - : // no input registers - : "memory", "%rax", "%rbx", "%rcx", "%rdx", "%rsi", "%rdi", --"%r8", "%r9", "%r10", "%r11", "%r12", "%r13", "%r14", "%r15", "%rsp"); -+"%r8", "%r9", "%r10", "%r11", "%r12", "%r13", "%r14", "%r15"); - } - - __attribute__((noinline)) diff --git
Re: [OE-core] [PATCH 1/3] core-image-sato-ptest-fast: Add 'fast' ptest execution image
gdk-pixbuf is fast? Not for me. Some of its tests take about 2000 seconds on qemux86-64 on a 32 core machine with 64GB ram. Joe From: openembedded-core-boun...@lists.openembedded.org [openembedded-core-boun...@lists.openembedded.org] on behalf of akuster808 [akuster...@gmail.com] Sent: Wednesday, April 17, 2019 9:57 AM To: Richard Purdie; openembedded-core@lists.openembedded.org Subject: Re: [OE-core] [PATCH 1/3] core-image-sato-ptest-fast: Add 'fast' ptest execution image On 4/17/19 8:59 AM, Richard Purdie wrote: > Create a common include file which lists recipes that have ptests divided > into 'fast' and 'slow' groups. This allows us to include ptests which > otherwise > may not get included in images and allows us to test the faster running things > more regularly. > > The new image allows access to these faster executing tests. 'fast' is defined > as tests which execute in under 30s roughly speaking. Maybe at some point allow recipes to define their own groupings. It would lend itself to scaling better. Can we define the system at ~30 seconds? All these may be fast on a 196 core system where as on my laptop all would be slow ; ) - armin > > Signed-off-by: Richard Purdie > --- > .../distro/include/ptest-packagelists.inc | 75 +++ > .../images/core-image-sato-ptest-fast.bb | 16 > 2 files changed, 91 insertions(+) > create mode 100644 meta/conf/distro/include/ptest-packagelists.inc > create mode 100644 meta/recipes-sato/images/core-image-sato-ptest-fast.bb > > diff --git a/meta/conf/distro/include/ptest-packagelists.inc > b/meta/conf/distro/include/ptest-packagelists.inc > new file mode 100644 > index 000..768ba743ed0 > --- /dev/null > +++ b/meta/conf/distro/include/ptest-packagelists.inc > @@ -0,0 +1,75 @@ > +# > +# Lists of the ptests in OE-Core, sorted into two sets by the time they take > +# > +# ptests which take less than ~30s each > +# > +PTESTS_FAST = "\ > +acl-ptest \ > +apr-ptest \ > +apr-util-ptest \ > +attr-ptest \ > +bluez5-ptest \ > +bzip2-ptest \ > +dbus-test-ptest \ > +diffstat-ptest \ > +diffutils-ptest \ > +elfutils-ptest \ > +ethtool-ptest \ > +flex-ptest \ > +gawk-ptest \ > +gdbm-ptest \ > +gdk-pixbuf-ptest \ > +gzip-ptest \ > +json-glib-ptest \ > +kbd-ptest \ > +libconvert-asn1-perl-ptest \ > +liberror-perl-ptest \ > +libpcre-ptest \ > +libtimedate-perl-ptest \ > +libtest-needs-perl-ptest \ > +liburi-perl-ptest \ > +libusb1-ptest \ > +libxml-namespacesupport-perl-ptest \ > +libxml-perl-ptest \ > +libxml-parser-perl-ptest \ > +libxml-sax-perl-ptest \ > +libxml-sax-base-perl-ptest \ > +libxml-simple-perl-ptest \ > +libxml2-ptest \ > +lzo-ptest \ > +nettle-ptest \ > +openssl-ptest \ > +opkg-ptest \ > +pango-ptest \ > +parted-ptest \ > +quilt-ptest \ > +sed-ptest \ > +slang-ptest \ > +zlib-ptest \ > +" > + > +#PTESTS_PROBLEMS = "\ > +#qemu-ptest \ # Doesn't run any tests? > +#ruby-ptest \ # Timeout > +#mdadm-ptest \ # Timeout > +#clutter-1.0-ptest \ # Doesn't build due to depends on cogl-1.0 > +#" > + > +PTESTS_SLOW = "\ > +bash-ptest \ > +busybox-ptest \ > +e2fsprogs-ptest \ > +glib-2.0-ptest \ > +gstreamer1.0-ptest \ > +libevent-ptest \ > +lttng-tools-ptest \ > +openssh-ptest \ > +openssl-ptest \ > +perl-ptest \ > +python-ptest \ > +python3-ptest \ > +strace-ptest \ > +tcl-ptest \ > +util-linux-ptest \ > +valgrind-ptest \ > +" > diff --git a/meta/recipes-sato/images/core-image-sato-ptest-fast.bb > b/meta/recipes-sato/images/core-image-sato-ptest-fast.bb > new file mode 100644 > index 000..b794a7dc9e9 > --- /dev/null > +++ b/meta/recipes-sato/images/core-image-sato-ptest-fast.bb > @@ -0,0 +1,16 @@ > +require core-image-sato-sdk.bb > +require conf/distro/include/ptest-packagelists.inc > + > +IMAGE_INSTALL += "${PTESTS_FAST}" > + > +DESCRIPTION += "Also includes ptest packages with fast execution times to > allow for more automated QA." > + > +# This image is sufficiently large (~1.8GB) that it can't actually fit in a > live > +# image (which has a 4GB limit), so nullify the overhead factor (1.3x out of > the > +# box) and explicitly add just 1500MB. > +# strace-ptest in particular needs more than 500MB > +IMAGE_OVERHEAD_FACTOR = "1.0" > +IMAGE_ROOTFS_EXTRA_SPACE = "1524288" > + > +# ptests need more memory than standard to avoid the OOM killer > +QB_MEM = "-m 1024" -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH v2] kernel-fitimage: support RISC-V
On 4/12/19 9:56 PM, Michael Scott wrote: Support RISC-V kernel image, using the "Image" target. This change allows RISC-V support for fitImage via the following flow: OpenSBI -> u-boot (as payload) -> Linux kernel (as fitImage with ramdisk and dtb). This was tested using QEMU RISC-V 64-bit. Signed-off-by: Michael Scott --- meta/classes/kernel-fitimage.bbclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/classes/kernel-fitimage.bbclass b/meta/classes/kernel-fitimage.bbclass index 2517d75746..09abedff8e 100644 --- a/meta/classes/kernel-fitimage.bbclass +++ b/meta/classes/kernel-fitimage.bbclass @@ -8,7 +8,7 @@ python __anonymous () { d.setVar("DEPENDS", depends) uarch = d.getVar("UBOOT_ARCH") -if uarch == "arm64": +if uarch == "arm64" or uarch == "riscv": I didn't see any response to this v2 patch. Is this approach acceptible? RISC-V should not attempt to use zImage for fitImage as it now stands. replacementtype = "Image" elif uarch == "mips": replacementtype = "vmlinuz.bin" -- Michael Scott Embedded Software Engineer at Foundries.io "microPlatforms™ for Connected Products" E: m...@foundries.io W: https://www.foundries.io -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH 2/2] resulttool: Add log subcommand
On Fri, Apr 19, 2019, 12:05 AM akuster808 wrote: > > > On 4/18/19 7:57 PM, Joshua Watt wrote: > > Adds a subcommand for dumping various logs from test results > > > > Signed-off-by: Joshua Watt > > --- > > scripts/lib/resulttool/log.py| 56 > > scripts/lib/resulttool/regression.py | 2 +- > > scripts/resulttool | 2 + > > 3 files changed, 59 insertions(+), 1 deletion(-) > > create mode 100644 scripts/lib/resulttool/log.py > > > > diff --git a/scripts/lib/resulttool/log.py > b/scripts/lib/resulttool/log.py > > new file mode 100644 > > index 000..5584f2d0a99 > > --- /dev/null > > +++ b/scripts/lib/resulttool/log.py > > @@ -0,0 +1,56 @@ > > +# resulttool - Show logs > > +# > > +# Copyright (c) 2019 Garmin International > > +# > > +# This program is free software; you can redistribute it and/or modify > it > > +# under the terms and conditions of the GNU General Public License, > > +# version 2, as published by the Free Software Foundation. > > +# > > +# This program is distributed in the hope it will be useful, but WITHOUT > > +# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or > > +# FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License > for > > +# more details. > > +# > > +import resulttool.resultutils as resultutils > > + > > +def show_ptest(result, ptest, logger): > > +if 'ptestresult.sections' in result: > > +if ptest in result['ptestresult.sections'] and 'log' in > result['ptestresult.sections'][ptest]: > > +print(result['ptestresult.sections'][ptest]['log']) > > +return 0 > > + > > +print("ptest '%s' not found" % ptest) > > +return 1 > > + > > +def log(args, logger): > > +results = resultutils.load_resultsdata(args.source) > > +for path in results: > > +for res in results[path]: > > +if 'result' not in results[path][res]: > > +continue > > +r = results[path][res]['result'] > > + > > +if args.raw: > > +if 'ptestresult.rawlogs' in r: > > +print(r['ptestresult.rawlogs']['log']) > > +else: > > +print('Raw logs not found') > > +return 1 > > + > > +for ptest in args.ptest: > > +if not show_ptest(r, ptest, logger): > > +return 1 > > + > > +def register_commands(subparsers): > > +"""Register subcommands from this plugin""" > > +parser = subparsers.add_parser('log', help='show logs', > > + description='show the logs > from test results', > > + group='analysis') > > +parser.set_defaults(func=log) > > +parser.add_argument('source', > > +help='the results file/directory/URL to import') > > +parser.add_argument('--ptest', action='append', default=[], > > +help='show logs for a ptest') > > +parser.add_argument('--raw', action='store_true', > > +help='show raw logs') > > + > > diff --git a/scripts/lib/resulttool/regression.py > b/scripts/lib/resulttool/regression.py > > index aecb9da9ce5..fa90ab1e522 100644 > > --- a/scripts/lib/resulttool/regression.py > > +++ b/scripts/lib/resulttool/regression.py > > @@ -64,7 +64,7 @@ def regression_common(args, logger, base_results, > target_results): > > if a in target_results: > > base = list(base_results[a].keys()) > > target = list(target_results[a].keys()) > > -# We may have multiple base/targets which are for different > configurations. Start by > > +# We may have multiple base/targets which are for different > configurations. Start by > This change looks the same to me so what am I missing? > It stripped off trailing whitespace and I missed removing it when staging. - Armin > > # removing any pairs which match > > for c in base.copy(): > > for b in target.copy(): > > diff --git a/scripts/resulttool b/scripts/resulttool > > index 18ac1019236..9477667a870 100755 > > --- a/scripts/resulttool > > +++ b/scripts/resulttool > > @@ -49,6 +49,7 @@ import resulttool.store > > import resulttool.regression > > import resulttool.report > > import resulttool.manualexecution > > +import resulttool.log > > logger = scriptutils.logger_create('resulttool') > > > > def main(): > > @@ -66,6 +67,7 @@ def main(): > > subparsers.add_subparser_group('analysis', 'analysis', 100) > > resulttool.regression.register_commands(subparsers) > > resulttool.report.register_commands(subparsers) > > +resulttool.log.register_commands(subparsers) > > > > args = parser.parse_args() > > if args.debug: > > > -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org
[OE-core] [V2][PATCH] sysstat:Add PACKAGECONFIG for '--enable-install-cron' configure
Add PACKAGECONFIG[cron] for configure option: '--enable-install-cron' and remove the code of enable/disable sysstat.service in Makefile.in which is not available for embedded cross compiling. Signed-off-by: Haiqing Bai --- meta/recipes-extended/sysstat/sysstat.inc | 4 +- ...code-of-handling-enable-disable-self-star.patch | 55 ++ meta/recipes-extended/sysstat/sysstat_11.7.1.bb| 3 +- 3 files changed, 59 insertions(+), 3 deletions(-) create mode 100644 meta/recipes-extended/sysstat/sysstat/0001-Remove-the-code-of-handling-enable-disable-self-star.patch diff --git a/meta/recipes-extended/sysstat/sysstat.inc b/meta/recipes-extended/sysstat/sysstat.inc index 0bc7e14..83a9202 100644 --- a/meta/recipes-extended/sysstat/sysstat.inc +++ b/meta/recipes-extended/sysstat/sysstat.inc @@ -17,8 +17,8 @@ DEPENDS += "base-passwd" # autotools-brokensep as this package doesn't use automake inherit autotools-brokensep gettext systemd -PACKAGECONFIG ??= "" PACKAGECONFIG[lm-sensors] = "--enable-sensors,--disable-sensors,lmsensors,lmsensors-libsensors" +PACKAGECONFIG[cron] = "--enable-install-cron,--disable-install-cron" EXTRA_OECONF += "--disable-stripping" @@ -60,6 +60,6 @@ pkg_postinst_${PN} () { } -FILES_${PN} += "${libdir}/sa" +FILES_${PN} += "${libdir}/sa ${systemd_unitdir}/system/*" TARGET_CC_ARCH += "${LDFLAGS}" diff --git a/meta/recipes-extended/sysstat/sysstat/0001-Remove-the-code-of-handling-enable-disable-self-star.patch b/meta/recipes-extended/sysstat/sysstat/0001-Remove-the-code-of-handling-enable-disable-self-star.patch new file mode 100644 index 000..1d099c9 --- /dev/null +++ b/meta/recipes-extended/sysstat/sysstat/0001-Remove-the-code-of-handling-enable-disable-self-star.patch @@ -0,0 +1,55 @@ +From 85813d1648b03ba0497635c45e90d7edf4dc204c Mon Sep 17 00:00:00 2001 +From: Haiqing Bai +Date: Fri, 29 Mar 2019 11:00:09 +0800 +Subject: [PATCH] Remove the code of handling enable/disable self-start service + in Makefile.in + +Remove the handling of enable/disable sysstat.service self-start in Makefile.in. +The code will trigger below error when cross compiling with +'--enable-install-cron': +| if [ -x "/path/to/sysstat/11.7.1-r0/recipe-sysroot-native/usr/bin/systemctl" ]; then \ +| /path/to/sysstat/11.7.1-r0/recipe-sysroot-native/usr/bin/systemctl enable sysstat.service; \ +| fi +| Started /path/to/sysstat/11.7.1-r0/recipe-sysroot-native/usr/bin/systemctl enable sysstat.service +| Try to find location of sysstat.service... +| 'sysstat.service' couldn't be found; exiting with error + +It's better for user to enable/disable the service with +'systemctl enable/disable sysstat.service' + +Upstream-Status: Inappropriate [ embedded specific ] + +Signed-off-by: Haiqing Bai +--- + Makefile.in | 8 + 1 file changed, 8 deletions(-) + +diff --git a/Makefile.in b/Makefile.in +index edaea3f..2186155 100644 +--- a/Makefile.in b/Makefile.in +@@ -454,11 +454,6 @@ endif + fi \ + fi \ + fi +-ifeq ($(COPY_ONLY),n) +- if [ -x "$(SYSTEMCTL)" ]; then \ +- $(SYSTEMCTL) enable sysstat.service; \ +- fi +-endif + + uninstall_man: + ifeq ($(INSTALL_DOC),y) +@@ -541,9 +536,6 @@ ifeq ($(COPY_ONLY),n) + @echo "USER'S CRONTAB SAVED IN CURRENT DIRECTORY (USING .old SUFFIX)." ; \ + -su $(CRON_OWNER) -c "crontab -r" ; \ + fi +- if [ -x $(SYSTEMCTL) ]; then \ +- $(SYSTEMCTL) disable sysstat.service; \ +- fi + endif + if [ -n "$(SYSTEMD_UNIT_DIR)" -a -d $(DESTDIR)$(SYSTEMD_UNIT_DIR) ]; then \ + rm -f $(DESTDIR)$(SYSTEMD_UNIT_DIR)/sysstat.service; \ +-- +1.9.1 + diff --git a/meta/recipes-extended/sysstat/sysstat_11.7.1.bb b/meta/recipes-extended/sysstat/sysstat_11.7.1.bb index 86738e7..26be619 100644 --- a/meta/recipes-extended/sysstat/sysstat_11.7.1.bb +++ b/meta/recipes-extended/sysstat/sysstat_11.7.1.bb @@ -2,7 +2,8 @@ require sysstat.inc LIC_FILES_CHKSUM = "file://COPYING;md5=a23a74b3f4caf9616230789d94217acb" -SRC_URI += "file://0001-Include-needed-headers-explicitly.patch" +SRC_URI += "file://0001-Include-needed-headers-explicitly.patch \ + file://0001-Remove-the-code-of-handling-enable-disable-self-star.patch" SRC_URI[md5sum] = "bdcda7c9048c7c22fb1f30f75285d13d" SRC_URI[sha256sum] = "303a595b1af0330b183a0f1febfccf89f183b9575ae0562b91fdb876f3ef1feb" -- 1.9.1 -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
[OE-core] [PATCH v3] ltp: Fix setrlimit03 call succeeded unexpectedly
From: He Zhe Backport a patch from upstream to fix the following error. "setrlimit03.c:54: FAIL: call succeeded unexpectedly" Signed-off-by: He Zhe --- v1 to v3: Add Upstream-Status and Signed-off-by ...trlimit03.c-read-proc-sys-fs-nr_open-for-.patch | 70 ++ meta/recipes-extended/ltp/ltp_20190115.bb | 1 + 2 files changed, 71 insertions(+) create mode 100644 meta/recipes-extended/ltp/ltp/0001-syscalls-setrlimit03.c-read-proc-sys-fs-nr_open-for-.patch diff --git a/meta/recipes-extended/ltp/ltp/0001-syscalls-setrlimit03.c-read-proc-sys-fs-nr_open-for-.patch b/meta/recipes-extended/ltp/ltp/0001-syscalls-setrlimit03.c-read-proc-sys-fs-nr_open-for-.patch new file mode 100644 index 000..39623c3 --- /dev/null +++ b/meta/recipes-extended/ltp/ltp/0001-syscalls-setrlimit03.c-read-proc-sys-fs-nr_open-for-.patch @@ -0,0 +1,70 @@ +From db57ddc1497e72947da2b14f471ab521478ef99d Mon Sep 17 00:00:00 2001 +From: Tommi Rantala +Date: Thu, 31 Jan 2019 19:49:00 +0200 +Subject: [PATCH] syscalls/setrlimit03.c: read /proc/sys/fs/nr_open for + RLIMIT_NOFILE limit + +Since kernel v2.6.25 RLIMIT_NOFILE limit is no longer hardcoded to +NR_OPEN, but can be set via /proc/sys/fs/nr_open, see kernel commit +9cfe015aa424b3c003baba3841a60dd9b5ad319b ("get rid of NR_OPEN and +introduce a sysctl_nr_open"). + +nr_open default value is 1024*1024, so setrlimit03 has been passing fine +on new kernels, only "unexpectedly succeeding" if nr_open is set to some +larger value. + +Signed-off-by: Tommi Rantala +Reviewed-by: Cyril Hrubis + +Upstream-Status: Backport [db57ddc1497e ("syscalls/setrlimit03.c: read /proc/sys/fs/nr_open for RLIMIT_NOFILE limit")] + +Signed-off-by: He Zhe +--- + testcases/kernel/syscalls/setrlimit/setrlimit03.c | 13 +++-- + 1 file changed, 11 insertions(+), 2 deletions(-) + +diff --git a/testcases/kernel/syscalls/setrlimit/setrlimit03.c b/testcases/kernel/syscalls/setrlimit/setrlimit03.c +index 29b52aa..12455fe 100644 +--- a/testcases/kernel/syscalls/setrlimit/setrlimit03.c b/testcases/kernel/syscalls/setrlimit/setrlimit03.c +@@ -35,7 +35,10 @@ + # define NR_OPEN (1024*1024) + #endif + ++#define NR_OPEN_PATH "/proc/sys/fs/nr_open" ++ + static struct rlimit rlim1, rlim2; ++static unsigned int nr_open = NR_OPEN; + + static struct tcase { + struct rlimit *rlimt; +@@ -51,7 +54,10 @@ static void verify_setrlimit(unsigned int n) + + TEST(setrlimit(RLIMIT_NOFILE, tc->rlimt)); + if (TST_RET != -1) { +- tst_res(TFAIL, "call succeeded unexpectedly"); ++ tst_res(TFAIL, "call succeeded unexpectedly " ++ "(nr_open=%u rlim_cur=%lu rlim_max=%lu)", nr_open, ++ (unsigned long)(tc->rlimt->rlim_cur), ++ (unsigned long)(tc->rlimt->rlim_max)); + return; + } + +@@ -65,10 +71,13 @@ static void verify_setrlimit(unsigned int n) + + static void setup(void) + { ++ if (!access(NR_OPEN_PATH, F_OK)) ++ SAFE_FILE_SCANF(NR_OPEN_PATH, "%u", _open); ++ + SAFE_GETRLIMIT(RLIMIT_NOFILE, ); + rlim2.rlim_max = rlim1.rlim_cur; + rlim2.rlim_cur = rlim1.rlim_max + 1; +- rlim1.rlim_max = NR_OPEN + 1; ++ rlim1.rlim_max = nr_open + 1; + } + + static struct tst_test test = { +-- +2.7.4 + diff --git a/meta/recipes-extended/ltp/ltp_20190115.bb b/meta/recipes-extended/ltp/ltp_20190115.bb index ddf97e2..1d0c00b 100644 --- a/meta/recipes-extended/ltp/ltp_20190115.bb +++ b/meta/recipes-extended/ltp/ltp_20190115.bb @@ -49,6 +49,7 @@ SRC_URI = "git://github.com/linux-test-project/ltp.git \ file://0001-open_posix_testsuite-mmap24-2-Relax-condition-a-bit.patch \ file://define-sigrtmin-and-sigrtmax-for-musl.patch \ file://setregid01-security-string-formatting.patch \ + file://0001-syscalls-setrlimit03.c-read-proc-sys-fs-nr_open-for-.patch \ " S = "${WORKDIR}/git" -- 2.7.4 -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
[OE-core] [PATCH] glib-2.0: fix ptest failures
From: Mingli Yu * Set G_TEST_BUILDDIR to mark we run the tests out of builddir to make it can skip the test_non_utf8_printf to fix below test error as test_non_utf8_printf needed to run under builddir per https://gitlab.gnome.org/GNOME/glib/blob/master/glib/tests/gdatetime.c#L1440. | GLib:ERROR:../glib-2.58.3/glib/tests/gdatetime.c:1477:test_non_utf8_printf: assertion failed (__p == ("10\346\234\210")): ("Oct" == "10\346\234\210") | Bail out! GLib:ERROR:../glib-2.58.3/glib/tests/gdatetime.c:1477:test_non_utf8_printf: assertion failed (__p == ("10\346\234\210")): ("Oct" == "10\346\234\210") | FAIL: glib/gdatetime.test (Child process killed by signal 6) * Increase the timeout to 15 minute to fix below error as the default timeout which is 5 minutes is not enough. | Executing: glib/actions.test | Test timed out after 300 seconds | cleaning up pid 13050 | FAIL: glib/actions.test (Child process killed by signal 9) Signed-off-by: Mingli Yu --- meta/recipes-core/glib-2.0/glib-2.0/run-ptest | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/meta/recipes-core/glib-2.0/glib-2.0/run-ptest b/meta/recipes-core/glib-2.0/glib-2.0/run-ptest index 8f082d3..e4777da 100644 --- a/meta/recipes-core/glib-2.0/glib-2.0/run-ptest +++ b/meta/recipes-core/glib-2.0/glib-2.0/run-ptest @@ -1,6 +1,8 @@ #! /bin/sh +# set G_TEST_BUILDDIR to mark the tests running out of the builddir +export G_TEST_BUILDDIR=$(pwd) set -eux useradd glib2-test -su glib2-test -c gnome-desktop-testing-runner glib +su glib2-test -c "gnome-desktop-testing-runner glib -t 900" userdel glib2-test -- 2.7.4 -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
[OE-core] [PATCH] resulttool/manualexecution: Enable test case configuration option
From: sangeeta jain Current manualexecution required user to exceute all test cases defined inside a "modulename.json" file in oeqa/manual There are cases when all test cases all not required to run for a module on specific DUT. Enable manualexecution to have the optional feature where it will use pre-defined json format test case configuration file where user will be able to select test cases from the "modulename.json" instead of running all of them. This will help in reducing testing time and reporting unneccesary skip or failures. Example pre-defined json format test case configuration file (for build-applince): { "testcases" : [ "build-appliance.build-appliance.Create_core-image-sato-sdk_using_build_appliance", "build-appliance.build-appliance.Build_a_image_without_error_(added_recipe)" ] } Signed-off-by: sangeeta jain --- scripts/lib/resulttool/manualexecution.py | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/scripts/lib/resulttool/manualexecution.py b/scripts/lib/resulttool/manualexecution.py index ea44219..dc368f3 100755 --- a/scripts/lib/resulttool/manualexecution.py +++ b/scripts/lib/resulttool/manualexecution.py @@ -17,6 +17,7 @@ import os import sys import datetime import re +import copy from oeqa.core.runner import OETestResultJSONHelper @@ -123,7 +124,7 @@ class ManualTestRunner(object): def _get_write_dir(self): return os.environ['BUILDDIR'] + '/tmp/log/manual/' -def run_test(self, case_file, config_options_file): +def run_test(self, case_file, config_options_file, testcase_config_file): test_module = self._get_test_module(case_file) cases = load_json_file(case_file) config_options = {} @@ -132,6 +133,13 @@ class ManualTestRunner(object): configurations = self._get_config(config_options, test_module) result_id = 'manual_%s_%s' % (test_module, configurations['STARTTIME']) test_results = {} +if testcase_config_file: +test_case_config = load_json_file(testcase_config_file) +test_case_to_execute = test_case_config['testcases'] +for case in copy.deepcopy(cases) : +if case['test']['@alias'] not in test_case_to_execute: +cases.remove(case) + print('\nTotal number of test cases in this test suite: %s\n' % len(cases)) for c in cases: test_result = self._execute_test_steps(c) @@ -184,7 +192,7 @@ def manualexecution(args, logger): if args.make_config_options_file: testrunner.make_config_option_file(logger, args.file, args.config_options_file) return 0 -configurations, result_id, write_dir, test_results = testrunner.run_test(args.file, args.config_options_file) +configurations, result_id, write_dir, test_results = testrunner.run_test(args.file, args.config_options_file, args.testcase_config_file) resultjsonhelper = OETestResultJSONHelper() resultjsonhelper.dump_testresult_file(write_dir, configurations, result_id, test_results) return 0 @@ -200,3 +208,5 @@ def register_commands(subparsers): help='the config options file to import and used as available configuration option selection or make config option file') parser_build.add_argument('-m', '--make-config-options-file', action='store_true', help='make the configuration options file based on provided inputs') +parser_build.add_argument('-t', '--testcase-config-file', default='', + help='the testcase configuration file to enable user to run a selected set of test case') \ No newline at end of file -- 2.7.4 -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
[OE-core] [PATCH v2] ltp: Fix setrlimit03 call succeeded unexpectedly
From: He Zhe Backport a patch from upstream to fix the following error. "setrlimit03.c:54: FAIL: call succeeded unexpectedly" Signed-off-by: He Zhe --- ...trlimit03.c-read-proc-sys-fs-nr_open-for-.patch | 67 ++ meta/recipes-extended/ltp/ltp_20190115.bb | 1 + 2 files changed, 68 insertions(+) create mode 100644 meta/recipes-extended/ltp/ltp/0001-syscalls-setrlimit03.c-read-proc-sys-fs-nr_open-for-.patch diff --git a/meta/recipes-extended/ltp/ltp/0001-syscalls-setrlimit03.c-read-proc-sys-fs-nr_open-for-.patch b/meta/recipes-extended/ltp/ltp/0001-syscalls-setrlimit03.c-read-proc-sys-fs-nr_open-for-.patch new file mode 100644 index 000..3a689ca --- /dev/null +++ b/meta/recipes-extended/ltp/ltp/0001-syscalls-setrlimit03.c-read-proc-sys-fs-nr_open-for-.patch @@ -0,0 +1,67 @@ +From db57ddc1497e72947da2b14f471ab521478ef99d Mon Sep 17 00:00:00 2001 +From: Tommi Rantala +Date: Thu, 31 Jan 2019 19:49:00 +0200 +Subject: [PATCH] syscalls/setrlimit03.c: read /proc/sys/fs/nr_open for + RLIMIT_NOFILE limit + +Since kernel v2.6.25 RLIMIT_NOFILE limit is no longer hardcoded to +NR_OPEN, but can be set via /proc/sys/fs/nr_open, see kernel commit +9cfe015aa424b3c003baba3841a60dd9b5ad319b ("get rid of NR_OPEN and +introduce a sysctl_nr_open"). + +nr_open default value is 1024*1024, so setrlimit03 has been passing fine +on new kernels, only "unexpectedly succeeding" if nr_open is set to some +larger value. + +Signed-off-by: Tommi Rantala +Reviewed-by: Cyril Hrubis +Signed-off-by: He Zhe +--- + testcases/kernel/syscalls/setrlimit/setrlimit03.c | 13 +++-- + 1 file changed, 11 insertions(+), 2 deletions(-) + +diff --git a/testcases/kernel/syscalls/setrlimit/setrlimit03.c b/testcases/kernel/syscalls/setrlimit/setrlimit03.c +index 29b52aa..12455fe 100644 +--- a/testcases/kernel/syscalls/setrlimit/setrlimit03.c b/testcases/kernel/syscalls/setrlimit/setrlimit03.c +@@ -35,7 +35,10 @@ + # define NR_OPEN (1024*1024) + #endif + ++#define NR_OPEN_PATH "/proc/sys/fs/nr_open" ++ + static struct rlimit rlim1, rlim2; ++static unsigned int nr_open = NR_OPEN; + + static struct tcase { + struct rlimit *rlimt; +@@ -51,7 +54,10 @@ static void verify_setrlimit(unsigned int n) + + TEST(setrlimit(RLIMIT_NOFILE, tc->rlimt)); + if (TST_RET != -1) { +- tst_res(TFAIL, "call succeeded unexpectedly"); ++ tst_res(TFAIL, "call succeeded unexpectedly " ++ "(nr_open=%u rlim_cur=%lu rlim_max=%lu)", nr_open, ++ (unsigned long)(tc->rlimt->rlim_cur), ++ (unsigned long)(tc->rlimt->rlim_max)); + return; + } + +@@ -65,10 +71,13 @@ static void verify_setrlimit(unsigned int n) + + static void setup(void) + { ++ if (!access(NR_OPEN_PATH, F_OK)) ++ SAFE_FILE_SCANF(NR_OPEN_PATH, "%u", _open); ++ + SAFE_GETRLIMIT(RLIMIT_NOFILE, ); + rlim2.rlim_max = rlim1.rlim_cur; + rlim2.rlim_cur = rlim1.rlim_max + 1; +- rlim1.rlim_max = NR_OPEN + 1; ++ rlim1.rlim_max = nr_open + 1; + } + + static struct tst_test test = { +-- +2.7.4 + diff --git a/meta/recipes-extended/ltp/ltp_20190115.bb b/meta/recipes-extended/ltp/ltp_20190115.bb index ddf97e2..1d0c00b 100644 --- a/meta/recipes-extended/ltp/ltp_20190115.bb +++ b/meta/recipes-extended/ltp/ltp_20190115.bb @@ -49,6 +49,7 @@ SRC_URI = "git://github.com/linux-test-project/ltp.git \ file://0001-open_posix_testsuite-mmap24-2-Relax-condition-a-bit.patch \ file://define-sigrtmin-and-sigrtmax-for-musl.patch \ file://setregid01-security-string-formatting.patch \ + file://0001-syscalls-setrlimit03.c-read-proc-sys-fs-nr_open-for-.patch \ " S = "${WORKDIR}/git" -- 2.7.4 -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
[OE-core] [PATCH] ltp: Fix setrlimit03 call succeeded unexpectedly
From: He Zhe Backport a patch from upstream to fix the following error. "setrlimit03.c:54: FAIL: call succeeded unexpectedly" Signed-off-by: He Zhe --- ...trlimit03.c-read-proc-sys-fs-nr_open-for-.patch | 66 ++ meta/recipes-extended/ltp/ltp_20190115.bb | 1 + 2 files changed, 67 insertions(+) create mode 100644 meta/recipes-extended/ltp/ltp/0001-syscalls-setrlimit03.c-read-proc-sys-fs-nr_open-for-.patch diff --git a/meta/recipes-extended/ltp/ltp/0001-syscalls-setrlimit03.c-read-proc-sys-fs-nr_open-for-.patch b/meta/recipes-extended/ltp/ltp/0001-syscalls-setrlimit03.c-read-proc-sys-fs-nr_open-for-.patch new file mode 100644 index 000..1191e88 --- /dev/null +++ b/meta/recipes-extended/ltp/ltp/0001-syscalls-setrlimit03.c-read-proc-sys-fs-nr_open-for-.patch @@ -0,0 +1,66 @@ +From db57ddc1497e72947da2b14f471ab521478ef99d Mon Sep 17 00:00:00 2001 +From: Tommi Rantala +Date: Thu, 31 Jan 2019 19:49:00 +0200 +Subject: [PATCH] syscalls/setrlimit03.c: read /proc/sys/fs/nr_open for + RLIMIT_NOFILE limit + +Since kernel v2.6.25 RLIMIT_NOFILE limit is no longer hardcoded to +NR_OPEN, but can be set via /proc/sys/fs/nr_open, see kernel commit +9cfe015aa424b3c003baba3841a60dd9b5ad319b ("get rid of NR_OPEN and +introduce a sysctl_nr_open"). + +nr_open default value is 1024*1024, so setrlimit03 has been passing fine +on new kernels, only "unexpectedly succeeding" if nr_open is set to some +larger value. + +Signed-off-by: Tommi Rantala +Reviewed-by: Cyril Hrubis +--- + testcases/kernel/syscalls/setrlimit/setrlimit03.c | 13 +++-- + 1 file changed, 11 insertions(+), 2 deletions(-) + +diff --git a/testcases/kernel/syscalls/setrlimit/setrlimit03.c b/testcases/kernel/syscalls/setrlimit/setrlimit03.c +index 29b52aa..12455fe 100644 +--- a/testcases/kernel/syscalls/setrlimit/setrlimit03.c b/testcases/kernel/syscalls/setrlimit/setrlimit03.c +@@ -35,7 +35,10 @@ + # define NR_OPEN (1024*1024) + #endif + ++#define NR_OPEN_PATH "/proc/sys/fs/nr_open" ++ + static struct rlimit rlim1, rlim2; ++static unsigned int nr_open = NR_OPEN; + + static struct tcase { + struct rlimit *rlimt; +@@ -51,7 +54,10 @@ static void verify_setrlimit(unsigned int n) + + TEST(setrlimit(RLIMIT_NOFILE, tc->rlimt)); + if (TST_RET != -1) { +- tst_res(TFAIL, "call succeeded unexpectedly"); ++ tst_res(TFAIL, "call succeeded unexpectedly " ++ "(nr_open=%u rlim_cur=%lu rlim_max=%lu)", nr_open, ++ (unsigned long)(tc->rlimt->rlim_cur), ++ (unsigned long)(tc->rlimt->rlim_max)); + return; + } + +@@ -65,10 +71,13 @@ static void verify_setrlimit(unsigned int n) + + static void setup(void) + { ++ if (!access(NR_OPEN_PATH, F_OK)) ++ SAFE_FILE_SCANF(NR_OPEN_PATH, "%u", _open); ++ + SAFE_GETRLIMIT(RLIMIT_NOFILE, ); + rlim2.rlim_max = rlim1.rlim_cur; + rlim2.rlim_cur = rlim1.rlim_max + 1; +- rlim1.rlim_max = NR_OPEN + 1; ++ rlim1.rlim_max = nr_open + 1; + } + + static struct tst_test test = { +-- +2.7.4 + diff --git a/meta/recipes-extended/ltp/ltp_20190115.bb b/meta/recipes-extended/ltp/ltp_20190115.bb index ddf97e2..1d0c00b 100644 --- a/meta/recipes-extended/ltp/ltp_20190115.bb +++ b/meta/recipes-extended/ltp/ltp_20190115.bb @@ -49,6 +49,7 @@ SRC_URI = "git://github.com/linux-test-project/ltp.git \ file://0001-open_posix_testsuite-mmap24-2-Relax-condition-a-bit.patch \ file://define-sigrtmin-and-sigrtmax-for-musl.patch \ file://setregid01-security-string-formatting.patch \ + file://0001-syscalls-setrlimit03.c-read-proc-sys-fs-nr_open-for-.patch \ " S = "${WORKDIR}/git" -- 2.7.4 -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
[OE-core] [PATCH] kernel.bbclass: convert base_do_unpack_append() to a task
-- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
[OE-core] Outstanding patches/pings etc
I just wanted to let people know I'm taking a short break over the weekend so not to expect answers to some of the questions regarding patches immediately. I know there are a few pings and other questions. Others like Ross are also away so it will be a quiet time for patches. Cheers, Richard -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core