Re: [OE-core] [RFT][PATCH] glibc: Upgrade to 2.39

2024-01-16 Thread Khem Raj
On Tue, Jan 16, 2024 at 11:10 PM Andrej Valek  wrote:
>
> Hello Raj,
>
> Don't forget to change the glibc-version.inc too and try to make a
> optimization/cleaning like I proposed here:
> https://lists.openembedded.org/g/openembedded-core/message/193572 ;).

yeah CVEs list will need cleaning anyway as it will be verson bump. But if
you turn your suggestion into a patch I can include it in patchset.

>
> Regards,
> Andy
>
> On 16.01.2024 20:53, Khem Raj wrote:
> > Upgrade localdef to get glibc 2.39 build fixes
> > Details of release [1]
> >
> > [1] https://sourceware.org/glibc/wiki/Release/2.39
> >
> > Signed-off-by: Khem Raj 
> > ---
> >   meta/conf/distro/include/tcmode-default.inc   |  2 +-
> >   ...2.38.bb => cross-localedef-native_2.39.bb} |  0
> >   meta/recipes-core/glibc/glibc-common.inc  |  2 +-
> >   ...bc-locale_2.38.bb => glibc-locale_2.39.bb} |  0
> >   ...bc-mtrace_2.38.bb => glibc-mtrace_2.39.bb} |  0
> >   ...-scripts_2.38.bb => glibc-scripts_2.39.bb} |  0
> >   ...tsuite_2.38.bb => glibc-testsuite_2.39.bb} |  0
> >   meta/recipes-core/glibc/glibc-version.inc |  8 ++--
> >   ...ests_2.38.bb => glibc-y2038-tests_2.39.bb} |  0
> >   ...dd-hardlink-resolver-from-util-linux.patch |  2 +-
> >   ...-fix-ups-hardlink-to-make-it-compile.patch |  2 +-
> >   ...Look-for-host-system-ld.so.cache-as-.patch |  8 ++--
> >   ...Fix-buffer-overrun-with-a-relocated-.patch |  4 +-
> >   ...Raise-the-size-of-arrays-containing-.patch | 22 -
> >   ...k-glibc-Allow-64-bit-atomics-for-x86.patch |  4 +-
> >   ...Make-relocatable-install-for-locales.patch | 10 ++--
> >   ...Fall-back-to-faccessat-on-faccess2-r.patch |  4 +-
> >   ...the-path-sets-wrong-config-variables.patch |  2 +-
> >   ...ss-building-and-testing-instructions.patch |  2 +-
> >   ...glibc-Help-bootstrap-cross-toolchain.patch |  4 +-
> >   ...eglibc-Resolve-__fpscr_values-on-SH4.patch |  4 +-
> >   ...port-cross-locale-generation-support.patch | 46 +--
> >   ...-archive-uses-a-hard-coded-locale-pa.patch |  4 +-
> >   ...Do-not-ask-compiler-for-finding-arch.patch |  2 +-
> >   ...y-the-header-between-arm-and-aarch64.patch |  4 +-
> >   ...h-printf-builtin-in-nscd-init-script.patch |  2 +-
> >   ...igure.ac-Set-libc_cv_rootsbindir-onl.patch |  2 +-
> >   ...ell-interpreter-overridable-in-tzsel.patch |  6 +--
> >   ...Use-bin-sh-default-shell-interpreter.patch |  2 +-
> >   ...d-failed-in-unprivileged-process-BZ-.patch |  6 +--
> >   ...build-time-paths-in-the-output-binar.patch |  6 +--
> >   ...e-Pass-mcpu-along-with-march-to-dete.patch |  5 +-
> >   ...Bump-__GLIBC_MINOR__-to-39-on-master.patch | 25 ++
> >   .../glibc/{glibc_2.38.bb => glibc_2.39.bb}|  1 +
> >   34 files changed, 106 insertions(+), 85 deletions(-)
> >   rename meta/recipes-core/glibc/{cross-localedef-native_2.38.bb => 
> > cross-localedef-native_2.39.bb} (100%)
> >   rename meta/recipes-core/glibc/{glibc-locale_2.38.bb => 
> > glibc-locale_2.39.bb} (100%)
> >   rename meta/recipes-core/glibc/{glibc-mtrace_2.38.bb => 
> > glibc-mtrace_2.39.bb} (100%)
> >   rename meta/recipes-core/glibc/{glibc-scripts_2.38.bb => 
> > glibc-scripts_2.39.bb} (100%)
> >   rename meta/recipes-core/glibc/{glibc-testsuite_2.38.bb => 
> > glibc-testsuite_2.39.bb} (100%)
> >   rename meta/recipes-core/glibc/{glibc-y2038-tests_2.38.bb => 
> > glibc-y2038-tests_2.39.bb} (100%)
> >   create mode 100644 
> > meta/recipes-core/glibc/glibc/0024-features.h-Bump-__GLIBC_MINOR__-to-39-on-master.patch
> >   rename meta/recipes-core/glibc/{glibc_2.38.bb => glibc_2.39.bb} (98%)
> >
> > diff --git a/meta/conf/distro/include/tcmode-default.inc 
> > b/meta/conf/distro/include/tcmode-default.inc
> > index 3720a4c5b86..977fb316107 100644
> > --- a/meta/conf/distro/include/tcmode-default.inc
> > +++ b/meta/conf/distro/include/tcmode-default.inc
> > @@ -20,7 +20,7 @@ GCCVERSION ?= "13.%"
> >   SDKGCCVERSION ?= "${GCCVERSION}"
> >   BINUVERSION ?= "2.41%"
> >   GDBVERSION ?= "14.%"
> > -GLIBCVERSION ?= "2.38%"
> > +GLIBCVERSION ?= "2.39%"
> >   LINUXLIBCVERSION ?= "6.6%"
> >   QEMUVERSION ?= "8.1%"
> >   GOVERSION ?= "1.20%"
> > diff --git a/meta/recipes-core/glibc/cross-localedef-native_2.38.bb 
> > b/meta/recipes-core/glibc/cross-localedef-native_2.39.bb
> > similarity index 100%
> > rename from meta/recipes-core/glibc/cross-localedef-native_2.38.bb
> > rename to meta/recipes-core/glibc/cross-localedef-native_2.39.bb
> > diff --git a/meta/recipes-core/glibc/glibc-common.inc 
> > b/meta/recipes-core/glibc/glibc-common.inc
> > index be33c29857c..5b62884a017 100644
> > --- a/meta/recipes-core/glibc/glibc-common.inc
> > +++ b/meta/recipes-core/glibc/glibc-common.inc
> > @@ -22,4 +22,4 @@ ARM_INSTRUCTION_SET:armv6 = "arm"
> >   #
> >   COMPATIBLE_HOST:libc-musl:class-target = "null"
> >
> > -PV = "2.38"
> > +PV = "2.39+git"
> > diff --git a/meta/recipes-core/glibc/glibc-locale_2.38.bb 
> > b/meta/recipes-core/glibc/glibc-locale_2.39.bb
> > similarity index 100%
> > rename from meta/recipe

Patchtest results for [oe-core][kirkstone][PATCH 1/1] openssh: fix CVE-2023-48795

2024-01-16 Thread Patchtest
Thank you for your submission. Patchtest identified one
or more issues with the patch. Please see the log below for
more information:

---
Testing patch 
/home/patchtest/share/mboxes/kirkstone-1-1-openssh-fix-CVE-2023-48795.patch

FAIL: test CVE check ignore: CVE_CHECK_IGNORE is deprecated and should be 
replaced by CVE_STATUS (test_metadata.TestMetadata.test_cve_check_ignore)

PASS: test CVE tag format (test_patch.TestPatch.test_cve_tag_format)
PASS: test Signed-off-by presence 
(test_mbox.TestMbox.test_signed_off_by_presence)
PASS: test Signed-off-by presence 
(test_patch.TestPatch.test_signed_off_by_presence)
PASS: test Upstream-Status presence 
(test_patch.TestPatch.test_upstream_status_presence_format)
PASS: test author valid (test_mbox.TestMbox.test_author_valid)
PASS: test commit message presence 
(test_mbox.TestMbox.test_commit_message_presence)
PASS: test lic files chksum modified not mentioned 
(test_metadata.TestMetadata.test_lic_files_chksum_modified_not_mentioned)
PASS: test max line length (test_metadata.TestMetadata.test_max_line_length)
PASS: test mbox format (test_mbox.TestMbox.test_mbox_format)
PASS: test non-AUH upgrade (test_mbox.TestMbox.test_non_auh_upgrade)
PASS: test shortlog format (test_mbox.TestMbox.test_shortlog_format)
PASS: test shortlog length (test_mbox.TestMbox.test_shortlog_length)
PASS: test target mailing list (test_mbox.TestMbox.test_target_mailing_list)

SKIP: pretest pylint: No python related patches, skipping test 
(test_python_pylint.PyLint.pretest_pylint)
SKIP: pretest src uri left files: Patch cannot be merged 
(test_metadata.TestMetadata.pretest_src_uri_left_files)
SKIP: test bugzilla entry format: No bug ID found 
(test_mbox.TestMbox.test_bugzilla_entry_format)
SKIP: test lic files chksum presence: No added recipes, skipping test 
(test_metadata.TestMetadata.test_lic_files_chksum_presence)
SKIP: test license presence: No added recipes, skipping test 
(test_metadata.TestMetadata.test_license_presence)
SKIP: test pylint: No python related patches, skipping test 
(test_python_pylint.PyLint.test_pylint)
SKIP: test series merge on head: Merge test is disabled for now 
(test_mbox.TestMbox.test_series_merge_on_head)
SKIP: test src uri left files: Patch cannot be merged 
(test_metadata.TestMetadata.test_src_uri_left_files)
SKIP: test summary presence: No added recipes, skipping test 
(test_metadata.TestMetadata.test_summary_presence)

---

Please address the issues identified and
submit a new revision of the patch, or alternatively, reply to this
email with an explanation of why the patch should be accepted. If you
believe these results are due to an error in patchtest, please submit a
bug at https://bugzilla.yoctoproject.org/ (use the 'Patchtest' category
under 'Yocto Project Subprojects'). For more information on specific
failures, see: https://wiki.yoctoproject.org/wiki/Patchtest. Thank
you!

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#193895): 
https://lists.openembedded.org/g/openembedded-core/message/193895
Mute This Topic: https://lists.openembedded.org/mt/103781521/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [RFT][PATCH] glibc: Upgrade to 2.39

2024-01-16 Thread Andrej Valek

Hello Raj,

Don't forget to change the glibc-version.inc too and try to make a 
optimization/cleaning like I proposed here: 
https://lists.openembedded.org/g/openembedded-core/message/193572 ;).


Regards,
Andy

On 16.01.2024 20:53, Khem Raj wrote:

Upgrade localdef to get glibc 2.39 build fixes
Details of release [1]

[1] https://sourceware.org/glibc/wiki/Release/2.39

Signed-off-by: Khem Raj 
---
  meta/conf/distro/include/tcmode-default.inc   |  2 +-
  ...2.38.bb => cross-localedef-native_2.39.bb} |  0
  meta/recipes-core/glibc/glibc-common.inc  |  2 +-
  ...bc-locale_2.38.bb => glibc-locale_2.39.bb} |  0
  ...bc-mtrace_2.38.bb => glibc-mtrace_2.39.bb} |  0
  ...-scripts_2.38.bb => glibc-scripts_2.39.bb} |  0
  ...tsuite_2.38.bb => glibc-testsuite_2.39.bb} |  0
  meta/recipes-core/glibc/glibc-version.inc |  8 ++--
  ...ests_2.38.bb => glibc-y2038-tests_2.39.bb} |  0
  ...dd-hardlink-resolver-from-util-linux.patch |  2 +-
  ...-fix-ups-hardlink-to-make-it-compile.patch |  2 +-
  ...Look-for-host-system-ld.so.cache-as-.patch |  8 ++--
  ...Fix-buffer-overrun-with-a-relocated-.patch |  4 +-
  ...Raise-the-size-of-arrays-containing-.patch | 22 -
  ...k-glibc-Allow-64-bit-atomics-for-x86.patch |  4 +-
  ...Make-relocatable-install-for-locales.patch | 10 ++--
  ...Fall-back-to-faccessat-on-faccess2-r.patch |  4 +-
  ...the-path-sets-wrong-config-variables.patch |  2 +-
  ...ss-building-and-testing-instructions.patch |  2 +-
  ...glibc-Help-bootstrap-cross-toolchain.patch |  4 +-
  ...eglibc-Resolve-__fpscr_values-on-SH4.patch |  4 +-
  ...port-cross-locale-generation-support.patch | 46 +--
  ...-archive-uses-a-hard-coded-locale-pa.patch |  4 +-
  ...Do-not-ask-compiler-for-finding-arch.patch |  2 +-
  ...y-the-header-between-arm-and-aarch64.patch |  4 +-
  ...h-printf-builtin-in-nscd-init-script.patch |  2 +-
  ...igure.ac-Set-libc_cv_rootsbindir-onl.patch |  2 +-
  ...ell-interpreter-overridable-in-tzsel.patch |  6 +--
  ...Use-bin-sh-default-shell-interpreter.patch |  2 +-
  ...d-failed-in-unprivileged-process-BZ-.patch |  6 +--
  ...build-time-paths-in-the-output-binar.patch |  6 +--
  ...e-Pass-mcpu-along-with-march-to-dete.patch |  5 +-
  ...Bump-__GLIBC_MINOR__-to-39-on-master.patch | 25 ++
  .../glibc/{glibc_2.38.bb => glibc_2.39.bb}|  1 +
  34 files changed, 106 insertions(+), 85 deletions(-)
  rename meta/recipes-core/glibc/{cross-localedef-native_2.38.bb => 
cross-localedef-native_2.39.bb} (100%)
  rename meta/recipes-core/glibc/{glibc-locale_2.38.bb => glibc-locale_2.39.bb} 
(100%)
  rename meta/recipes-core/glibc/{glibc-mtrace_2.38.bb => glibc-mtrace_2.39.bb} 
(100%)
  rename meta/recipes-core/glibc/{glibc-scripts_2.38.bb => 
glibc-scripts_2.39.bb} (100%)
  rename meta/recipes-core/glibc/{glibc-testsuite_2.38.bb => 
glibc-testsuite_2.39.bb} (100%)
  rename meta/recipes-core/glibc/{glibc-y2038-tests_2.38.bb => 
glibc-y2038-tests_2.39.bb} (100%)
  create mode 100644 
meta/recipes-core/glibc/glibc/0024-features.h-Bump-__GLIBC_MINOR__-to-39-on-master.patch
  rename meta/recipes-core/glibc/{glibc_2.38.bb => glibc_2.39.bb} (98%)

diff --git a/meta/conf/distro/include/tcmode-default.inc 
b/meta/conf/distro/include/tcmode-default.inc
index 3720a4c5b86..977fb316107 100644
--- a/meta/conf/distro/include/tcmode-default.inc
+++ b/meta/conf/distro/include/tcmode-default.inc
@@ -20,7 +20,7 @@ GCCVERSION ?= "13.%"
  SDKGCCVERSION ?= "${GCCVERSION}"
  BINUVERSION ?= "2.41%"
  GDBVERSION ?= "14.%"
-GLIBCVERSION ?= "2.38%"
+GLIBCVERSION ?= "2.39%"
  LINUXLIBCVERSION ?= "6.6%"
  QEMUVERSION ?= "8.1%"
  GOVERSION ?= "1.20%"
diff --git a/meta/recipes-core/glibc/cross-localedef-native_2.38.bb 
b/meta/recipes-core/glibc/cross-localedef-native_2.39.bb
similarity index 100%
rename from meta/recipes-core/glibc/cross-localedef-native_2.38.bb
rename to meta/recipes-core/glibc/cross-localedef-native_2.39.bb
diff --git a/meta/recipes-core/glibc/glibc-common.inc 
b/meta/recipes-core/glibc/glibc-common.inc
index be33c29857c..5b62884a017 100644
--- a/meta/recipes-core/glibc/glibc-common.inc
+++ b/meta/recipes-core/glibc/glibc-common.inc
@@ -22,4 +22,4 @@ ARM_INSTRUCTION_SET:armv6 = "arm"
  #
  COMPATIBLE_HOST:libc-musl:class-target = "null"
  
-PV = "2.38"

+PV = "2.39+git"
diff --git a/meta/recipes-core/glibc/glibc-locale_2.38.bb 
b/meta/recipes-core/glibc/glibc-locale_2.39.bb
similarity index 100%
rename from meta/recipes-core/glibc/glibc-locale_2.38.bb
rename to meta/recipes-core/glibc/glibc-locale_2.39.bb
diff --git a/meta/recipes-core/glibc/glibc-mtrace_2.38.bb 
b/meta/recipes-core/glibc/glibc-mtrace_2.39.bb
similarity index 100%
rename from meta/recipes-core/glibc/glibc-mtrace_2.38.bb
rename to meta/recipes-core/glibc/glibc-mtrace_2.39.bb
diff --git a/meta/recipes-core/glibc/glibc-scripts_2.38.bb 
b/meta/recipes-core/glibc/glibc-scripts_2.39.bb
similarity index 100%
rename from meta/recipes-core/glibc/glibc-scripts_2.38.bb
rename to meta/recipes-core/glibc/glibc-scripts_2.39.bb
d

[OE-core] [PATCH] coreutils: Fix build with clang

2024-01-16 Thread Khem Raj
Add a gnulib patch to fix build with clang-18

Signed-off-by: Khem Raj 
---
 .../0001-posixtm-pacify-clang-18.patch| 38 +++
 meta/recipes-core/coreutils/coreutils_9.4.bb  |  1 +
 2 files changed, 39 insertions(+)
 create mode 100644 
meta/recipes-core/coreutils/coreutils/0001-posixtm-pacify-clang-18.patch

diff --git 
a/meta/recipes-core/coreutils/coreutils/0001-posixtm-pacify-clang-18.patch 
b/meta/recipes-core/coreutils/coreutils/0001-posixtm-pacify-clang-18.patch
new file mode 100644
index 000..e6c84be3c41
--- /dev/null
+++ b/meta/recipes-core/coreutils/coreutils/0001-posixtm-pacify-clang-18.patch
@@ -0,0 +1,38 @@
+From 67c298c36f69b6906840b7584be06b7b5f33f829 Mon Sep 17 00:00:00 2001
+From: Paul Eggert 
+Date: Tue, 16 Jan 2024 17:21:08 -0800
+Subject: [PATCH] posixtm: pacify clang 18
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+Problem reported by Khem Raj in:
+https://lists.gnu.org/r/bug-gnulib/2024-01/msg00045.html
+* lib/posixtm.c (posixtime): Pacify clang 18 by converting bool to int.
+Arguably this is a bug in draft C2x, since the non-pointer args to
+ckd_add should promote just like any other expressions do;
+but that’s not clang’s fault.
+
+Upstream-Status: Submitted 
[https://lists.gnu.org/archive/html/bug-gnulib/2024-01/msg00046.html]
+Signed-off-by: Khem Raj 
+---
+ ChangeLog | 10 ++
+ lib/posixtm.c |  2 +-
+ 2 files changed, 11 insertions(+), 1 deletion(-)
+
+diff --git a/lib/posixtm.c b/lib/posixtm.c
+index ef9f55f873..a072c7cad0 100644
+--- a/lib/posixtm.c
 b/lib/posixtm.c
+@@ -191,7 +191,7 @@ posixtime (time_t *p, const char *s, unsigned int 
syntax_bits)
+  | (tm0.tm_min ^ tm1.tm_min)
+  | (tm0.tm_sec ^ tm1.tm_sec)))
+ {
+-  if (ckd_add (&t, t, leapsec))
++  if (ckd_add (&t, t, +leapsec))
+ return false;
+   *p = t;
+   return true;
+-- 
+2.43.0
+
diff --git a/meta/recipes-core/coreutils/coreutils_9.4.bb 
b/meta/recipes-core/coreutils/coreutils_9.4.bb
index c0ca150253b..f233ce07eb8 100644
--- a/meta/recipes-core/coreutils/coreutils_9.4.bb
+++ b/meta/recipes-core/coreutils/coreutils_9.4.bb
@@ -16,6 +16,7 @@ inherit autotools gettext texinfo
 SRC_URI = "${GNU_MIRROR}/coreutils/${BP}.tar.xz \
file://remove-usr-local-lib-from-m4.patch \
file://0001-local.mk-fix-cross-compiling-problem.patch \
+   file://0001-posixtm-pacify-clang-18.patch \
file://run-ptest \
"
 SRC_URI[sha256sum] = 
"ea613a4cf44612326e917201bbbcdfbd301de21ffc3b59b6e5c07e040b275e52"
-- 
2.43.0


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#193893): 
https://lists.openembedded.org/g/openembedded-core/message/193893
Mute This Topic: https://lists.openembedded.org/mt/103781435/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[oe-core][kirkstone][PATCH 1/1] openssh: fix CVE-2023-48795

2024-01-16 Thread Meenali Gupta via lists.openembedded.org
From: Meenali Gupta 

A flaw was found in the SSH channel integrity.By manipulating sequence
numbers during the handshake,an attacker can remove the initial messages
on the secure channel without causing a MAC failure. For example,an attacker
could disable the ping extension and thus disable the new countermeasure in
OpenSSH 9.5 against keystroke timing attacks.

This CVE fix included function kex_proposal_populate_entries in kex.c file which
is not present in 8.9p, so ignored this change.

Signed-off-by: Meenali Gupta 
---
 .../openssh/openssh/CVE-2023-48795.patch  | 503 ++
 .../openssh/openssh_8.9p1.bb  |   1 +
 2 files changed, 504 insertions(+)
 create mode 100644 
meta/recipes-connectivity/openssh/openssh/CVE-2023-48795.patch

diff --git a/meta/recipes-connectivity/openssh/openssh/CVE-2023-48795.patch 
b/meta/recipes-connectivity/openssh/openssh/CVE-2023-48795.patch
new file mode 100644
index 00..b1b16d5641
--- /dev/null
+++ b/meta/recipes-connectivity/openssh/openssh/CVE-2023-48795.patch
@@ -0,0 +1,503 @@
+From 1edb00c58f8a6875fad6a497aa2bacf37f9e6cd5 Mon Sep 17 00:00:00 2001
+From: "d...@openbsd.org" 
+Date: Mon, 18 Dec 2023 14:45:17 +
+Subject: [PATCH] upstream: implement "strict key exchange" in ssh and sshd
+ This adds a protocol extension to improve the integrity of the SSH transport
+ protocol, particular in and around the initial key exchange (KEX) phase.
+
+Full details of the extension are in the PROTOCOL file.
+
+with markus@
+
+OpenBSD-Commit-ID: 2a66ac962f0a630d7945fee54004ed9e9c439f14
+
+CVE: CVE-2023-48795
+Upstream-Status: Backport 
[https://github.com/openssh/openssh-portable/commit/1edb00c58f8a6875fad6a497aa2bacf37f9e6cd5]
+
+Signed-off-by: Meenali Gupta 
+---
+ PROTOCOL  |  28 +-
+ kex.c |  71 +-
+ kex.h |   3 +-
+ packet.c  | 103 +-
+ packet.h  |   3 +-
+ sshconnect2.c |  12 ++
+ 6 files changed, 137 insertions(+), 83 deletions(-)
+
+diff --git a/PROTOCOL b/PROTOCOL
+index e6a7d60..68912ce 100644
+--- a/PROTOCOL
 b/PROTOCOL
+@@ -102,6 +102,32 @@ OpenSSH supports the use of ECDH in Curve25519 for key 
exchange as
+ described at:
+ 
http://git.libssh.org/users/aris/libssh.git/plain/doc/curve25519-sha...@libssh.org.txt?h=curve25519
+
++1.9 transport: strict key exchange extension
++
++OpenSSH supports a number of transport-layer hardening measures under
++a "strict KEX" feature. This feature is signalled similarly to the
++RFC8308 ext-info feature: by including a additional algorithm in the
++initiial SSH2_MSG_KEXINIT kex_algorithms field. The client may append
++"kex-strict-c-...@openssh.com" to its kex_algorithms and the server
++may append "kex-strict-s-...@openssh.com". These pseudo-algorithms
++are only valid in the initial SSH2_MSG_KEXINIT and MUST be ignored
++if they are present in subsequent SSH2_MSG_KEXINIT packets.
++
++When an endpoint that supports this extension observes this algorithm
++name in a peer's KEXINIT packet, it MUST make the following changes to
++the the protocol:
++
++a) During initial KEX, terminate the connection if any unexpected or
++   out-of-sequence packet is received. This includes terminating the
++   connection if the first packet received is not SSH2_MSG_KEXINIT.
++   Unexpected packets for the purpose of strict KEX include messages
++   that are otherwise valid at any time during the connection such as
++   SSH2_MSG_DEBUG and SSH2_MSG_IGNORE.
++b) After sending or receiving a SSH2_MSG_NEWKEYS message, reset the
++   packet sequence number to zero. This behaviour persists for the
++   duration of the connection (i.e. not just the first
++   SSH2_MSG_NEWKEYS).
++
+ 2. Connection protocol changes
+
+ 2.1. connection: Channel write close extension "e...@openssh.com"
+@@ -612,4 +638,4 @@ master instance and later clients.
+ OpenSSH extends the usual agent protocol. These changes are documented
+ in the PROTOCOL.agent file.
+
+-$OpenBSD: PROTOCOL,v 1.43 2021/12/19 22:15:42 djm Exp $
++$OpenBSD: PROTOCOL,v 1.50 2023/12/18 14:45:17 djm Exp $
+diff --git a/kex.c b/kex.c
+index 0bcd27d..da16568 100644
+--- a/kex.c
 b/kex.c
+@@ -1,4 +1,4 @@
+-/* $OpenBSD: kex.c,v 1.172 2022/02/01 23:32:51 djm Exp $ */
++/* $OpenBSD: kex.c,v 1.183 2023/12/18 14:45:17 djm Exp $ */
+ /*
+  * Copyright (c) 2000, 2001 Markus Friedl.  All rights reserved.
+  *
+@@ -63,7 +63,7 @@
+ #include "digest.h"
+
+ /* prototype */
+-static int kex_choose_conf(struct ssh *);
++static int kex_choose_conf(struct ssh *, uint32_t seq);
+ static int kex_input_newkeys(int, u_int32_t, struct ssh *);
+
+ static const char * const proposal_names[PROPOSAL_MAX] = {
+@@ -175,6 +175,18 @@ kex_names_valid(const char *names)
+   return 1;
+ }
+
++/* returns non-zero if proposal contains any algorithm from algs */
++static int
++has_any_alg(const char *proposal, const char *algs)
++{
++  char *cp;
++
++  if ((cp = mat

[OE-core] Patchtest results for [kirkstone][PATCH] openssl: fix CVE-2023-6237 Excessive time spent checking invalid RSA public keys

2024-01-16 Thread Patchtest
Thank you for your submission. Patchtest identified one
or more issues with the patch. Please see the log below for
more information:

---
Testing patch 
/home/patchtest/share/mboxes/kirkstone-openssl-fix-CVE-2023-6237-Excessive-time-spent-checking-invalid-RSA-public-keys.patch

FAIL: test CVE check ignore: CVE_CHECK_IGNORE is deprecated and should be 
replaced by CVE_STATUS (test_metadata.TestMetadata.test_cve_check_ignore)

PASS: test CVE tag format (test_patch.TestPatch.test_cve_tag_format)
PASS: test Signed-off-by presence 
(test_mbox.TestMbox.test_signed_off_by_presence)
PASS: test Signed-off-by presence 
(test_patch.TestPatch.test_signed_off_by_presence)
PASS: test Upstream-Status presence 
(test_patch.TestPatch.test_upstream_status_presence_format)
PASS: test author valid (test_mbox.TestMbox.test_author_valid)
PASS: test commit message presence 
(test_mbox.TestMbox.test_commit_message_presence)
PASS: test lic files chksum modified not mentioned 
(test_metadata.TestMetadata.test_lic_files_chksum_modified_not_mentioned)
PASS: test max line length (test_metadata.TestMetadata.test_max_line_length)
PASS: test mbox format (test_mbox.TestMbox.test_mbox_format)
PASS: test non-AUH upgrade (test_mbox.TestMbox.test_non_auh_upgrade)
PASS: test shortlog format (test_mbox.TestMbox.test_shortlog_format)
PASS: test shortlog length (test_mbox.TestMbox.test_shortlog_length)
PASS: test target mailing list (test_mbox.TestMbox.test_target_mailing_list)

SKIP: pretest pylint: No python related patches, skipping test 
(test_python_pylint.PyLint.pretest_pylint)
SKIP: pretest src uri left files: Patch cannot be merged 
(test_metadata.TestMetadata.pretest_src_uri_left_files)
SKIP: test bugzilla entry format: No bug ID found 
(test_mbox.TestMbox.test_bugzilla_entry_format)
SKIP: test lic files chksum presence: No added recipes, skipping test 
(test_metadata.TestMetadata.test_lic_files_chksum_presence)
SKIP: test license presence: No added recipes, skipping test 
(test_metadata.TestMetadata.test_license_presence)
SKIP: test pylint: No python related patches, skipping test 
(test_python_pylint.PyLint.test_pylint)
SKIP: test series merge on head: Merge test is disabled for now 
(test_mbox.TestMbox.test_series_merge_on_head)
SKIP: test src uri left files: Patch cannot be merged 
(test_metadata.TestMetadata.test_src_uri_left_files)
SKIP: test summary presence: No added recipes, skipping test 
(test_metadata.TestMetadata.test_summary_presence)

---

Please address the issues identified and
submit a new revision of the patch, or alternatively, reply to this
email with an explanation of why the patch should be accepted. If you
believe these results are due to an error in patchtest, please submit a
bug at https://bugzilla.yoctoproject.org/ (use the 'Patchtest' category
under 'Yocto Project Subprojects'). For more information on specific
failures, see: https://wiki.yoctoproject.org/wiki/Patchtest. Thank
you!

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#193891): 
https://lists.openembedded.org/g/openembedded-core/message/193891
Mute This Topic: https://lists.openembedded.org/mt/103781219/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [kirkstone][PATCH] openssl: fix CVE-2023-6237 Excessive time spent checking invalid RSA public keys

2024-01-16 Thread Hitendra Prajapati via lists.openembedded.org
Upstream-Status: Backport from 
https://github.com/openssl/openssl/commit/e09fc1d746a4fd15bb5c3d7bbbab950aadd005db

Signed-off-by: Hitendra Prajapati 
---
 .../openssl/openssl/CVE-2023-6237.patch   | 127 ++
 .../openssl/openssl_3.0.12.bb |   1 +
 2 files changed, 128 insertions(+)
 create mode 100644 
meta/recipes-connectivity/openssl/openssl/CVE-2023-6237.patch

diff --git a/meta/recipes-connectivity/openssl/openssl/CVE-2023-6237.patch 
b/meta/recipes-connectivity/openssl/openssl/CVE-2023-6237.patch
new file mode 100644
index 00..621dc6b0ab
--- /dev/null
+++ b/meta/recipes-connectivity/openssl/openssl/CVE-2023-6237.patch
@@ -0,0 +1,127 @@
+rom e09fc1d746a4fd15bb5c3d7bbbab950aadd005db Mon Sep 17 00:00:00 2001
+From: Tomas Mraz 
+Date: Fri, 22 Dec 2023 16:25:56 +0100
+Subject: [PATCH] Limit the execution time of RSA public key check
+
+Fixes CVE-2023-6237
+
+If a large and incorrect RSA public key is checked with
+EVP_PKEY_public_check() the computation could take very long time
+due to no limit being applied to the RSA public key size and
+unnecessarily high number of Miller-Rabin algorithm rounds
+used for non-primality check of the modulus.
+
+Now the keys larger than 16384 bits (OPENSSL_RSA_MAX_MODULUS_BITS)
+will fail the check with RSA_R_MODULUS_TOO_LARGE error reason.
+Also the number of Miller-Rabin rounds was set to 5.
+
+Reviewed-by: Neil Horman 
+Reviewed-by: Matt Caswell 
+(Merged from https://github.com/openssl/openssl/pull/23243)
+
+Upstream-Status: Backport 
[https://github.com/openssl/openssl/commit/e09fc1d746a4fd15bb5c3d7bbbab950aadd005db]
+CVE: CVE-2023-6237
+Signed-off-by: Hitendra Prajapati 
+---
+ crypto/rsa/rsa_sp800_56b_check.c  |  8 +++-
+ test/recipes/91-test_pkey_check.t |  2 +-
+ .../91-test_pkey_check_data/rsapub_17k.pem| 48 +++
+ 3 files changed, 56 insertions(+), 2 deletions(-)
+ create mode 100644 test/recipes/91-test_pkey_check_data/rsapub_17k.pem
+
+diff --git a/crypto/rsa/rsa_sp800_56b_check.c 
b/crypto/rsa/rsa_sp800_56b_check.c
+index fc8f19b..bcbdd24 100644
+--- a/crypto/rsa/rsa_sp800_56b_check.c
 b/crypto/rsa/rsa_sp800_56b_check.c
+@@ -289,6 +289,11 @@ int ossl_rsa_sp800_56b_check_public(const RSA *rsa)
+ return 0;
+ 
+ nbits = BN_num_bits(rsa->n);
++if (nbits > OPENSSL_RSA_MAX_MODULUS_BITS) {
++ERR_raise(ERR_LIB_RSA, RSA_R_MODULUS_TOO_LARGE);
++return 0;
++}
++
+ #ifdef FIPS_MODULE
+ /*
+  * (Step a): modulus must be 2048 or 3072 (caveat from SP800-56Br1)
+@@ -324,7 +329,8 @@ int ossl_rsa_sp800_56b_check_public(const RSA *rsa)
+ goto err;
+ }
+ 
+-ret = ossl_bn_miller_rabin_is_prime(rsa->n, 0, ctx, NULL, 1, &status);
++/* Highest number of MR rounds from FIPS 186-5 Section B.3 Table B.1 */
++ret = ossl_bn_miller_rabin_is_prime(rsa->n, 5, ctx, NULL, 1, &status);
+ #ifdef FIPS_MODULE
+ if (ret != 1 || status != BN_PRIMETEST_COMPOSITE_NOT_POWER_OF_PRIME) {
+ #else
+diff --git a/test/recipes/91-test_pkey_check.t 
b/test/recipes/91-test_pkey_check.t
+index dc7cc64..f8088df 100644
+--- a/test/recipes/91-test_pkey_check.t
 b/test/recipes/91-test_pkey_check.t
+@@ -70,7 +70,7 @@ push(@positive_tests, (
+ "dhpkey.pem"
+ )) unless disabled("dh");
+ 
+-my @negative_pubtests = ();
++my @negative_pubtests = ("rsapub_17k.pem");  # Too big RSA public key
+ 
+ push(@negative_pubtests, (
+ "dsapub_noparam.der"
+diff --git a/test/recipes/91-test_pkey_check_data/rsapub_17k.pem 
b/test/recipes/91-test_pkey_check_data/rsapub_17k.pem
+new file mode 100644
+index 000..9a2eaed
+--- /dev/null
 b/test/recipes/91-test_pkey_check_data/rsapub_17k.pem
+@@ -0,0 +1,48 @@
++-BEGIN PUBLIC KEY-
++MIIIbzANBgkqhkiG9w0BAQEFAAOCCFwAMIIIVwKCCE4Ang+cE5H+hg3RbapDAHqR
++B9lUnp2MlAwsZxQ/FhYepaR60bFQeumbu7817Eo5YLMObVI99hF1C4u/qcpD4Jph
++gZt87/JAYDbP+DIh/5gUXCL9m5Fp4u7mvZaZdnlcftBvR1uKUTCAwc9pZ/Cfr8W2
++GzrRODzsNYnk2DcZMfe2vRDuDZRopE+Y+I72rom2SZLxoN547N1daM/M/CL9KVQ/
++XMI/YOpJrBI0jI3brMRhLkvLckwies9joufydlGbJkeil9H7/grj3fQZtFkZ2Pkj
++b87XDzRVX7wsEpAgPJxskL3jApokCp1kQYKG+Uc3dKM9Ade6IAPK7VKcmbAQTYw2
++gZxsc28dtstazmfGz0ACCTSMrmbgWAM3oPL7RRzhrXDWgmYQ0jHefGh8SNTIgtPq
++TuHxPYkDMQNaf0LmDGCxqlnf4b5ld3YaU8zZ/RqIRx5v/+w0rJUvU53qY1bYSnL1
++vbqKSnN2mip0GYyQ4AUgkS1NBV4rGYU/VTvzEjLfkg02KOtHKandvEoUjmZPzCT0
++V2ZhGc8K1UJNGYlIiHqCdwCBoghvly/pYajTkDXyd6BsukzA5H3IkZB1xDgl035j
++/0Cr7QeZLEOdi9fPdSSaBT6OmD0WFuZfJF0wMr7ucRhWzPXvSensD9v7MBE7tNfH
++SLeTSx8tLt8UeWriiM+0CnkPR1IOqMOxubOyf1eV8NQqEWm5wEQG/0IskbOKnaHa
++PqLFJZn/bvyL3XK5OxVIJG3z6bnRDOMS9SzkjqgPdIO8tkySEHVSi/6iuGUltx3Y
++Fmq6ye/r34ekyHPbfn6UuTON7joM6SIXb5bHM64x4iMVWx4hMvDjfy0UqfywAUyu
++C1o7BExSMxxFG8GJcqR0K8akpPp7EM588PC+YuItoxzXgfUJnP3BQ1Beev2Ve7/J
++xeGZH0N4ntfr+cuaLAakAER9zDglwChWflw3NNFgIdAgSxXv3XXx5xDXpdP4lxUo
++F5zAN4Mero3yV90FaJl7Vhq/UFVidbwFc15jUDwaE0mKRcsBeVd3GOhoECAgE0id
++aIPT20z8oVY0FyTJlRk7QSjo8WjJSrHY/Fn14gctX07ZdfkufyL6w+NijBdYluvB
++nIrgHEvpkDEWoIa8qcx0EppoIcmqgMV2mT

[OE-core] Ability to set a Disk GUID for wic image

2024-01-16 Thread adithya . balakumar
I am trying to generate reproducible wic images. I see that the Disk GUID is 
changing between builds. On seeing the wic imager source file (direct.py), i 
noticed that the disk identifier is set based on the "SOURCE_DATE_EPOCH" 
environment variable 
(https://github.com/openembedded/openembedded-core/blob/f46a211108854b4dabac0336cdcb2cf7b003d7cd/scripts/lib/wic/plugins/imager/direct.py#L316).
 However i don't see a disk GUID being set for the disk.

I don't see a way to set a disk GUID using a .wks file either. Would like to 
know if i am missing something.

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#193889): 
https://lists.openembedded.org/g/openembedded-core/message/193889
Mute This Topic: https://lists.openembedded.org/mt/103780721/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH 2/2] openssl: Fix ptest dependencies on perl-module-* being ignored by COMPLEMENTARY_GLOB

2024-01-16 Thread Chen Qi via lists.openembedded.org

Can we change the perl recipe to simply use 'RDEPENDS' for perl-modules?
I don't see what benefit the 'RRECOMMENDS' could give us.

Regards,
Qi


On 1/17/24 02:56, Tim Orling wrote:



On Tue, Jan 16, 2024 at 9:21 AM Alexander Kanavin 
 wrote:


How about simple depending on specific module packages? I don’t
think OpenSSL truly needs all modules.


Agreed. I don’t see a compelling reason to add the 
perl-modules-force-all complication. This will add confusion in my 
opinion.


Iterate the tests and add the required perl-module-* sub-packages one 
by one (or by inspection if the test cases)


In almost all cases, RDEPENDS on perl-modules is a short cut and 
should be avoided in favor of being explicit.



Alex

On Tue 16. Jan 2024 at 17.56, Lyu, William via
lists.openembedded.org


 wrote:

From: William Lyu 

Change the openssl-ptest RDEPENDS from perl-modules to
perl-modules-force-all which RDEPENDS on the same set of packages
perl-module-* recommended by perl-modules. So, when
openssl-ptest is
added via COMPLEMENTARY_GLOB "ptest-pkgs", its dependencies on
these
perl-module-* packages still get added.

Signed-off-by: William Lyu 
---
 meta/recipes-connectivity/openssl/openssl_3.2.0.bb


| 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git
a/meta/recipes-connectivity/openssl/openssl_3.2.0.bb


b/meta/recipes-connectivity/openssl/openssl_3.2.0.bb


index d041d2d214..7076bd3a7b 100644
--- a/meta/recipes-connectivity/openssl/openssl_3.2.0.bb


+++ b/meta/recipes-connectivity/openssl/openssl_3.2.0.bb


@@ -247,7 +247,7 @@ CONFFILES:openssl-conf =
"${sysconfdir}/ssl/openssl.cnf"

 RRECOMMENDS:libcrypto += "openssl-conf ${PN}-ossl-module-legacy"
 RDEPENDS:${PN}-misc = "perl"
-RDEPENDS:${PN}-ptest += "openssl-bin perl perl-modules bash sed"
+RDEPENDS:${PN}-ptest += "openssl-bin perl
perl-modules-force-all bash sed"

 RDEPENDS:${PN}-bin += "openssl-conf"

-- 
2.43.0












-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#193888): 
https://lists.openembedded.org/g/openembedded-core/message/193888
Mute This Topic: https://lists.openembedded.org/mt/103766390/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH] tune-core2: Update qemu cpu to supported model

2024-01-16 Thread Khem Raj
On Tue, Jan 16, 2024 at 7:37 PM Alexander Kanavin
 wrote:
>
> Please provide a link to the documentation in the commit message, and not 
> just the claim.
>

Perhaps add this link to commit msg
https://qemu-project.gitlab.io/qemu/system/qemu-cpu-models.html#other-non-recommended-x86-cpus

> Alex
>
> On Tue 16. Jan 2024 at 21.46, Simone Weiß  wrote:
>>
>> From: Simone Weiß 
>>
>> Fixes [YOCTO #12388]
>>
>> QEMUs documentation does recommend to not use n270 and core2duo as
>> an argument to -cpu anymore. Update therefore the QEMU cpu option for
>> the core2duo tune to Nehalam. Tested it locally with QEMU and KVM.
>>
>> Signed-off-by: Simone Weiß 
>> ---
>>  meta/conf/machine/include/x86/tune-core2.inc | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/meta/conf/machine/include/x86/tune-core2.inc 
>> b/meta/conf/machine/include/x86/tune-core2.inc
>> index 97b7c1b188..082fd4efc3 100644
>> --- a/meta/conf/machine/include/x86/tune-core2.inc
>> +++ b/meta/conf/machine/include/x86/tune-core2.inc
>> @@ -21,18 +21,18 @@ TUNE_FEATURES:tune-core2-32 = "${TUNE_FEATURES:tune-x86} 
>> core2"
>>  BASE_LIB:tune-core2-32 = "lib"
>>  TUNE_PKGARCH:tune-core2-32 = "core2-32"
>>  PACKAGE_EXTRA_ARCHS:tune-core2-32 = "${PACKAGE_EXTRA_ARCHS:tune-i686} 
>> core2-32"
>> -QEMU_EXTRAOPTIONS_core2-32 = " -cpu n270"
>> +QEMU_EXTRAOPTIONS_core2-32 = " -cpu Nehalem,check=false"
>>
>>  AVAILTUNES += "core2-64"
>>  TUNE_FEATURES:tune-core2-64 = "${TUNE_FEATURES:tune-x86-64} core2"
>>  BASE_LIB:tune-core2-64 = "lib64"
>>  TUNE_PKGARCH:tune-core2-64 = "core2-64"
>>  PACKAGE_EXTRA_ARCHS:tune-core2-64 = "${PACKAGE_EXTRA_ARCHS:tune-x86-64} 
>> core2-64"
>> -QEMU_EXTRAOPTIONS_core2-64 = " -cpu core2duo"
>> +QEMU_EXTRAOPTIONS_core2-64 = " -cpu Nehalem,check=false"
>>
>>  AVAILTUNES += "core2-64-x32"
>>  TUNE_FEATURES:tune-core2-64-x32 = "${TUNE_FEATURES:tune-x86-64-x32} core2"
>>  BASE_LIB:tune-core2-64-x32 = "libx32"
>>  TUNE_PKGARCH:tune-core2-64-x32 = "core2-64-x32"
>>  PACKAGE_EXTRA_ARCHS:tune-core2-64-x32 = 
>> "${PACKAGE_EXTRA_ARCHS:tune-x86-64-x32} core2-64-x32"
>> -QEMU_EXTRAOPTIONS_core2-64-x32 = " -cpu core2duo"
>> +QEMU_EXTRAOPTIONS_core2-64-x32 = " -cpu Nehalem,check=false"
>> --
>> 2.39.2
>>
>>
>>
>>
>
> 
>

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#193887): 
https://lists.openembedded.org/g/openembedded-core/message/193887
Mute This Topic: https://lists.openembedded.org/mt/103771791/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH] tune-core2: Update qemu cpu to supported model

2024-01-16 Thread Alexander Kanavin
Please provide a link to the documentation in the commit message, and not
just the claim.

Alex

On Tue 16. Jan 2024 at 21.46, Simone Weiß  wrote:

> From: Simone Weiß 
>
> Fixes [YOCTO #12388]
>
> QEMUs documentation does recommend to not use n270 and core2duo as
> an argument to -cpu anymore. Update therefore the QEMU cpu option for
> the core2duo tune to Nehalam. Tested it locally with QEMU and KVM.
>
> Signed-off-by: Simone Weiß 
> ---
>  meta/conf/machine/include/x86/tune-core2.inc | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/meta/conf/machine/include/x86/tune-core2.inc
> b/meta/conf/machine/include/x86/tune-core2.inc
> index 97b7c1b188..082fd4efc3 100644
> --- a/meta/conf/machine/include/x86/tune-core2.inc
> +++ b/meta/conf/machine/include/x86/tune-core2.inc
> @@ -21,18 +21,18 @@ TUNE_FEATURES:tune-core2-32 =
> "${TUNE_FEATURES:tune-x86} core2"
>  BASE_LIB:tune-core2-32 = "lib"
>  TUNE_PKGARCH:tune-core2-32 = "core2-32"
>  PACKAGE_EXTRA_ARCHS:tune-core2-32 = "${PACKAGE_EXTRA_ARCHS:tune-i686}
> core2-32"
> -QEMU_EXTRAOPTIONS_core2-32 = " -cpu n270"
> +QEMU_EXTRAOPTIONS_core2-32 = " -cpu Nehalem,check=false"
>
>  AVAILTUNES += "core2-64"
>  TUNE_FEATURES:tune-core2-64 = "${TUNE_FEATURES:tune-x86-64} core2"
>  BASE_LIB:tune-core2-64 = "lib64"
>  TUNE_PKGARCH:tune-core2-64 = "core2-64"
>  PACKAGE_EXTRA_ARCHS:tune-core2-64 = "${PACKAGE_EXTRA_ARCHS:tune-x86-64}
> core2-64"
> -QEMU_EXTRAOPTIONS_core2-64 = " -cpu core2duo"
> +QEMU_EXTRAOPTIONS_core2-64 = " -cpu Nehalem,check=false"
>
>  AVAILTUNES += "core2-64-x32"
>  TUNE_FEATURES:tune-core2-64-x32 = "${TUNE_FEATURES:tune-x86-64-x32} core2"
>  BASE_LIB:tune-core2-64-x32 = "libx32"
>  TUNE_PKGARCH:tune-core2-64-x32 = "core2-64-x32"
>  PACKAGE_EXTRA_ARCHS:tune-core2-64-x32 =
> "${PACKAGE_EXTRA_ARCHS:tune-x86-64-x32} core2-64-x32"
> -QEMU_EXTRAOPTIONS_core2-64-x32 = " -cpu core2duo"
> +QEMU_EXTRAOPTIONS_core2-64-x32 = " -cpu Nehalem,check=false"
> --
> 2.39.2
>
>
> 
>
>

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#193886): 
https://lists.openembedded.org/g/openembedded-core/message/193886
Mute This Topic: https://lists.openembedded.org/mt/103771791/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH] uboot-sign: support to load optee-os and TFA images

2024-01-16 Thread Jamin Lin via lists.openembedded.org
Hi Alexander,

One more thing, So far, bitman only support hash 256.

Thanks

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#193885): 
https://lists.openembedded.org/g/openembedded-core/message/193885
Mute This Topic: https://lists.openembedded.org/mt/103734859/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core][dunfell][PATCH] libtiff: Fix for CVE-2023-6228

2024-01-16 Thread Vijay Anusuri via lists.openembedded.org
From: Vijay Anusuri 

Upstream-Status: Backport 
[https://gitlab.com/libtiff/libtiff/-/commit/1e7d217a323eac701b134afc4ae39b6bdfdbc96a]

Signed-off-by: Vijay Anusuri 
---
 .../libtiff/files/CVE-2023-6228.patch | 30 +++
 meta/recipes-multimedia/libtiff/tiff_4.1.0.bb |  1 +
 2 files changed, 31 insertions(+)
 create mode 100644 meta/recipes-multimedia/libtiff/files/CVE-2023-6228.patch

diff --git a/meta/recipes-multimedia/libtiff/files/CVE-2023-6228.patch 
b/meta/recipes-multimedia/libtiff/files/CVE-2023-6228.patch
new file mode 100644
index 00..a777dea9b0
--- /dev/null
+++ b/meta/recipes-multimedia/libtiff/files/CVE-2023-6228.patch
@@ -0,0 +1,30 @@
+From 1e7d217a323eac701b134afc4ae39b6bdfdbc96a Mon Sep 17 00:00:00 2001
+From: Su_Laus 
+Date: Sat, 9 Sep 2023 15:45:47 +0200
+Subject: [PATCH] Check also if codec of input image is available,
+ independently from codec check of output image and return with error if not.
+ Fixes #606.
+
+Upstream-Status: Backport 
[https://gitlab.com/libtiff/libtiff/-/commit/1e7d217a323eac701b134afc4ae39b6bdfdbc96a]
+CVE: CVE-2023-6228
+Signed-off-by: Vijay Anusuri 
+---
+ tools/tiffcp.c | 2 ++
+ 1 file changed, 2 insertions(+)
+
+diff --git a/tools/tiffcp.c b/tools/tiffcp.c
+index 007bd05..d2f7b66 100644
+--- a/tools/tiffcp.c
 b/tools/tiffcp.c
+@@ -628,6 +628,8 @@ tiffcp(TIFF* in, TIFF* out)
+   else
+   CopyField(TIFFTAG_COMPRESSION, compression);
+   TIFFGetFieldDefaulted(in, TIFFTAG_COMPRESSION, &input_compression);
++  if (!TIFFIsCODECConfigured(input_compression))
++  return FALSE;
+   TIFFGetFieldDefaulted(in, TIFFTAG_PHOTOMETRIC, &input_photometric);
+   if (input_compression == COMPRESSION_JPEG) {
+   /* Force conversion to RGB */
+-- 
+2.25.1
+
diff --git a/meta/recipes-multimedia/libtiff/tiff_4.1.0.bb 
b/meta/recipes-multimedia/libtiff/tiff_4.1.0.bb
index 8b130826e3..c739f3a7fa 100644
--- a/meta/recipes-multimedia/libtiff/tiff_4.1.0.bb
+++ b/meta/recipes-multimedia/libtiff/tiff_4.1.0.bb
@@ -48,6 +48,7 @@ SRC_URI = 
"http://download.osgeo.org/libtiff/tiff-${PV}.tar.gz \
file://CVE-2023-40745.patch \
file://CVE-2023-41175.patch \
file://CVE-2022-40090.patch \
+   file://CVE-2023-6228.patch \
   "
 SRC_URI[md5sum] = "2165e7aba557463acc0664e71a3ed424"
 SRC_URI[sha256sum] = 
"5d29f32517dadb6dbcd1255ea5bbc93a2b54b94fbf83653b4d65c7d6775b8634"
-- 
2.25.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#193884): 
https://lists.openembedded.org/g/openembedded-core/message/193884
Mute This Topic: https://lists.openembedded.org/mt/103778770/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH v1] uboot-sign: support to load optee-os and TFA images

2024-01-16 Thread Jamin Lin via lists.openembedded.org
Currently, u-boot FIT image only support to load u-boot image.
To support optee-os and trusted-firmware-a, update ITS file generation
scripts, so users are able to use u-boot FIT image to load
u-boot, optee-os and treustred-firmware-a images

Add a variable "UBOOT_FIT_ARM_TRUSTED_FIRMWARE_A" to
enable trusted-firmware-a image and it is disable by default.

Add a variable "UBOOT_FIT_OPTEE_OS" to enable optee-os image
and it is disable by default.

The ITS file creation looks like as following.
1. Both optee-os and trusted-firmware-a are disabled.
'''
/dts-v1/;

/ {
images {
uboot {

};
fdt {
};
};

configurations {
default = "conf";
conf {
loadables = "uboot";
fdt = "fdt";
};
};
};
'''

2. Only enable optee-os
'''
/dts-v1/;

/ {
images {
uboot {
};
fdt {
};
optee {
};
};

configurations {
default = "conf";
conf {
firmware = "optee";
loadables = "uboot";
fdt = "fdt";
};
};
};
'''

3: Both optee-os and trusted-firmware-a are enabled
'''
/dts-v1/;

/ {
images {
uboot {
};
fdt {
};
atf {
};
optee {
};
};

configurations {
default = "conf";
conf {
firmware = "atf";
loadables = "uboot", "optee";
fdt = "fdt";
};
};
};
'''

Signed-off-by: Jamin Lin 
---
 meta/classes-recipe/uboot-sign.bbclass | 91 +-
 1 file changed, 90 insertions(+), 1 deletion(-)

diff --git a/meta/classes-recipe/uboot-sign.bbclass 
b/meta/classes-recipe/uboot-sign.bbclass
index ad04c82378..b874eb84db 100644
--- a/meta/classes-recipe/uboot-sign.bbclass
+++ b/meta/classes-recipe/uboot-sign.bbclass
@@ -88,6 +88,18 @@ UBOOT_FIT_ADDRESS_CELLS ?= "1"
 # This is only necessary for determining the signing configuration
 KERNEL_PN = "${PREFERRED_PROVIDER_virtual/kernel}"
 
+# Trusted Firmware-A (TF-A) provides a reference implementation of
+# secure world software for Armv7-A and Armv8-A,
+# including a Secure Monitor executing at Exception Level 3 (EL3)
+# ATF is used as the initial start code on ARMv8-A cores for all K3 platforms
+UBOOT_FIT_ARM_TRUSTED_FIRMWARE_A ?= "0"
+UBOOT_FIT_ARM_TRUSTED_FIRMWARE_A_IMAGE ?= "bl31.bin"
+
+# OP-TEE is a Trusted Execution Environment (TEE) designed as
+# companion to a non-secure Linux kernel running on Arm
+UBOOT_FIT_OPTEE_OS ?= "0"
+UBOOT_FIT_OPTEE_OS_IMAGE ?= "tee-raw.bin"
+
 python() {
 # We need u-boot-tools-native if we're creating a U-Boot fitImage
 sign = d.getVar('UBOOT_SIGN_ENABLE') == '1'
@@ -230,6 +242,20 @@ addtask uboot_generate_rsa_keys before 
do_uboot_assemble_fitimage after do_compi
 # Create a ITS file for the U-boot FIT, for use when
 # we want to sign it so that the SPL can verify it
 uboot_fitimage_assemble() {
+   conf_loadables="\"uboot\""
+   conf_firmware=""
+
+   if [ "${UBOOT_FIT_ARM_TRUSTED_FIRMWARE_A}" = "1" ]; then
+   conf_firmware="\"atf\""
+   if [ "${UBOOT_FIT_OPTEE_OS}" = "1" ]; then
+   conf_loadables="\"uboot\", \"optee\""
+   fi
+   else
+   if [ "${UBOOT_FIT_OPTEE_OS}" = "1" ]; then
+   conf_firmware="\"optee\""
+   fi
+   fi
+
rm -f ${UBOOT_ITS} ${UBOOT_FITIMAGE_BINARY}
 
# First we create the ITS script
@@ -282,13 +308,76 @@ EOF
 
cat << EOF >> ${UBOOT_ITS}
 };
+EOF
+   if [ "${UBOOT_FIT_ARM_TRUSTED_FIRMWARE_A}" = "1" ] ; then
+   cat << EOF >> ${UBOOT_ITS}
+atf {
+description = "ARM Trusted Firmware-A";
+data = /incbin/("${UBOOT_FIT_ARM_TRUSTED_FIRMWARE_A_IMAGE}");
+type = "firmware";
+arch = "${UBOOT_ARCH}";
+os = "arm-trusted-firmware";
+load = <${UBOOT_FIT_ARM_TRUSTED_FIRMWARE_A_LOADADDRESS}>;
+entry = <${UBOOT_FIT_ARM_TRUSTED_FIRMWARE_A_ENTRYPOINT}>;
+compression = "none";
+EOF
+
+   if [ "${SPL_SIGN_ENABLE}" = "1" ] ; then
+   cat << EOF >> ${UBOOT_ITS}
+signature {
+algo = "${UBOOT_FIT_HASH_ALG},${UBOOT_FIT_SIGN_ALG}";
+key-name-hint = "${SPL_SIGN_KEYNAME}";
+};
+EOF
+   fi
+
+   cat << EOF >> ${UBOOT_ITS}
+};
+EOF
+   fi
+
+   if [ "${UBOOT_FIT_OPTEE_OS}" = "1" ] ; then
+   cat << EOF >> ${UBOOT_ITS}
+optee {
+description = "OPTEE OS Image";
+data = /incbin/("${UBOOT_FIT_OPTEE_OS_IMAGE}");
+type = "tee";
+arch = "${UBOOT_ARCH}";
+os = "tee";
+load = <${UBOOT_FIT_OPTEE_OS_LOADADDRESS}>;
+entry = <${UBOOT_FIT_OPTEE_OS_ENTRYPOINT}>;
+compression = "none";
+EOF
+
+   if [ "${SP

Re: [OE-core] [PATCH] uboot-sign: support to load optee-os and TFA images

2024-01-16 Thread Jamin Lin via lists.openembedded.org
Yes, it is a typo and will fix it.
Thanks-Jamin

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#193882): 
https://lists.openembedded.org/g/openembedded-core/message/193882
Mute This Topic: https://lists.openembedded.org/mt/103734859/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH] uboot-sign: support to load optee-os and TFA images

2024-01-16 Thread Jamin Lin via lists.openembedded.org
Hi Alexander,

Thanks for review.

I tested it in ASPEED AST2600 and AST2700 SOCs. Yoc can see our Github 
repository here.

https://github.com/AspeedTech-BMC

You are right the latest version of u-boot(2024.01) support binman python tool 
to create FIT image and support optee-os and trusted-firmware-a.

However, “the old version of u-boot binman python tool” did not support to add 
optee-os and trusted-firmware-a in the FIT image.

For example, our AST2600 is production and its u-boot version was 2019.04 and 
binman python tools did not support optee-os image format.

That was why I changed ITS file creation scripts to support all u-boot version.

Finally, users are able to use the “makeimage” tool to crate FIT image with 
optee-os and trusted-firmware-a.

Thanks-Jamin

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#193881): 
https://lists.openembedded.org/g/openembedded-core/message/193881
Mute This Topic: https://lists.openembedded.org/mt/103734859/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core][kirkstone][PATCH] dropbear: backport patch for CVE-2023-48795

2024-01-16 Thread Peter Marko via lists.openembedded.org
From: Peter Marko 

Documentation for this patch is under
https://github.com/mkj/dropbear/commit/66bc1fcdee594c6cb1139df0ef8a6c9c5fc3fde3

Signed-off-by: Peter Marko 
---
 meta/recipes-core/dropbear/dropbear.inc   |   1 +
 .../dropbear/dropbear/CVE-2023-48795.patch| 234 ++
 2 files changed, 235 insertions(+)
 create mode 100644 meta/recipes-core/dropbear/dropbear/CVE-2023-48795.patch

diff --git a/meta/recipes-core/dropbear/dropbear.inc 
b/meta/recipes-core/dropbear/dropbear.inc
index e61930f7db..a32242949b 100644
--- a/meta/recipes-core/dropbear/dropbear.inc
+++ b/meta/recipes-core/dropbear/dropbear.inc
@@ -30,6 +30,7 @@ SRC_URI = 
"http://matt.ucc.asn.au/dropbear/releases/dropbear-${PV}.tar.bz2 \
${@bb.utils.contains('PACKAGECONFIG', 'disable-weak-ciphers', 
'file://dropbear-disable-weak-ciphers.patch', '', d)} \
   file://CVE-2021-36369.patch \
   file://CVE-2023-36328.patch \
+  file://CVE-2023-48795.patch \
   "
 
 PAM_SRC_URI = "file://0005-dropbear-enable-pam.patch \
diff --git a/meta/recipes-core/dropbear/dropbear/CVE-2023-48795.patch 
b/meta/recipes-core/dropbear/dropbear/CVE-2023-48795.patch
new file mode 100644
index 00..6800672ab0
--- /dev/null
+++ b/meta/recipes-core/dropbear/dropbear/CVE-2023-48795.patch
@@ -0,0 +1,234 @@
+From 6e43be5c7b99dbee49dc72b6f989f29fdd7e9356 Mon Sep 17 00:00:00 2001
+From: Matt Johnston 
+Date: Mon, 20 Nov 2023 14:02:47 +0800
+Subject: [PATCH] Implement Strict KEX mode
+
+As specified by OpenSSH with kex-strict-c-...@openssh.com and
+kex-strict-s-...@openssh.com.
+
+CVE: CVE-2023-48795
+Upstream-Status: Backport 
[https://github.com/mkj/dropbear/commit/6e43be5c7b99dbee49dc72b6f989f29fdd7e9356]
+
+Signed-off-by: Peter Marko 
+---
+ cli-session.c| 11 +++
+ common-algo.c|  6 ++
+ common-kex.c | 26 +-
+ kex.h|  3 +++
+ process-packet.c | 34 +++---
+ ssh.h|  4 
+ svr-session.c|  3 +++
+ 7 files changed, 71 insertions(+), 16 deletions(-)
+
+diff --git a/cli-session.c b/src/cli-session.c
+index 5981b2470..d261c8f82 100644
+--- a/cli-session.c
 b/cli-session.c
+@@ -46,6 +46,7 @@ static void cli_finished(void) ATTRIB_NORETURN;
+ static void recv_msg_service_accept(void);
+ static void cli_session_cleanup(void);
+ static void recv_msg_global_request_cli(void);
++static void cli_algos_initialise(void);
+ 
+ struct clientsession cli_ses; /* GLOBAL */
+ 
+@@ -114,6 +115,7 @@ void cli_session(int sock_in, int sock_out, struct 
dropbear_progress_connection
+   }
+ 
+   chaninitialise(cli_chantypes);
++  cli_algos_initialise();
+ 
+   /* Set up cli_ses vars */
+   cli_session_init(proxy_cmd_pid);
+@@ -473,3 +475,12 @@ void cli_dropbear_log(int priority, const char* format, 
va_list param) {
+   fflush(stderr);
+ }
+ 
++static void cli_algos_initialise(void) {
++  algo_type *algo;
++  for (algo = sshkex; algo->name; algo++) {
++  if (strcmp(algo->name, SSH_STRICT_KEX_S) == 0) {
++  algo->usable = 0;
++  }
++  }
++}
++
+diff --git a/common-algo.c b/src/common-algo.c
+index 378f0ca8e..f9d46ebb6 100644
+--- a/common-algo.c
 b/common-algo.c
+@@ -332,6 +332,12 @@ algo_type sshkex[] = {
+   /* Set unusable by svr_algos_initialise() */
+   {SSH_EXT_INFO_C, 0, NULL, 1, NULL},
+ #endif
++#endif
++#if DROPBEAR_CLIENT
++  {SSH_STRICT_KEX_C, 0, NULL, 1, NULL},
++#endif
++#if DROPBEAR_SERVER
++  {SSH_STRICT_KEX_S, 0, NULL, 1, NULL},
+ #endif
+   {NULL, 0, NULL, 0, NULL}
+ };
+diff --git a/common-kex.c b/src/common-kex.c
+index ac8844246..8e33b12a6 100644
+--- a/common-kex.c
 b/common-kex.c
+@@ -183,6 +183,10 @@ void send_msg_newkeys() {
+   gen_new_keys();
+   switch_keys();
+ 
++  if (ses.kexstate.strict_kex) {
++  ses.transseq = 0;
++  }
++
+   TRACE(("leave send_msg_newkeys"))
+ }
+ 
+@@ -193,7 +197,11 @@ void recv_msg_newkeys() {
+ 
+   ses.kexstate.recvnewkeys = 1;
+   switch_keys();
+-  
++
++  if (ses.kexstate.strict_kex) {
++  ses.recvseq = 0;
++  }
++
+   TRACE(("leave recv_msg_newkeys"))
+ }
+ 
+@@ -551,6 +559,10 @@ void recv_msg_kexinit() {
+ 
+   ses.kexstate.recvkexinit = 1;
+ 
++  if (ses.kexstate.strict_kex && !ses.kexstate.donefirstkex && 
ses.recvseq != 1) {
++  dropbear_exit("First packet wasn't kexinit");
++  }
++
+   TRACE(("leave recv_msg_kexinit"))
+ }
+ 
+@@ -861,6 +873,18 @@ static void read_kex_algos() {
+   }
+ #endif
+ 
++  if (!ses.kexstate.donefirstkex) {
++  const char* strict_name;
++  if (IS_DROPBEAR_CLIENT) {
++  strict_name = SSH_STRICT_KEX_S;
++  } else {
++  strict_name = SSH_STRICT_KEX_C;
++  }
++  if (buf_has_algo(ses.payload, strict_name) == DROPBEAR_SUCCESS) 
{
++  

Re: [OE-core] [PATCH] classes-global/insane: Add check for "virtual/" in RPROVIDES and RDEPENDS

2024-01-16 Thread Alexandre Belloni via lists.openembedded.org
Hello,

This causes warnings for meta-aws:

https://autobuilder.yoctoproject.org/typhoon/#/builders/122/builds/3840/steps/12/logs/warnings

On 14/01/2024 17:19:03+, Simone Weiß wrote:
> From: Simone Weiß 
> 
> Fixes [YOCTO #14538]
> 
> Recipes shouldn't use "virtual/" in RPROVIDES and RDEPENDS. This was
> addressed already in recipes in meta-oe and oe-core. Add a test for
> this in insane.bbclass to ensure no regressions occur.
> 
> Signed-off-by: Simone Weiß 
> ---
>  meta/classes-global/insane.bbclass | 6 ++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/meta/classes-global/insane.bbclass 
> b/meta/classes-global/insane.bbclass
> index d625fd82f7..9e8e35e0f7 100644
> --- a/meta/classes-global/insane.bbclass
> +++ b/meta/classes-global/insane.bbclass
> @@ -1606,6 +1606,12 @@ python () {
>  if (d.getVar(d.expand('DEPENDS:${PN}'))):
>  oe.qa.handle_error("pkgvarcheck", "recipe uses DEPENDS:${PN}, should 
> use DEPENDS", d)
>  
> +# virtual/ is meaningless for those variables
> +for k in ['RDEPENDS', 'RPROVIDES']:
> +for var in bb.utils.explode_deps(d.getVar(k + ':' + pn) or ""):
> +if var.startswith("virtual/"):
> +bb.warn("%s is set to %s, the substring 'virtual/' holds no 
> meaning in this context. It is suggested to use the 'virtual-' instead." % 
> (k, var))
> +
>  issues = []
>  if (d.getVar('PACKAGES') or "").split():
>  for dep in (d.getVar('QADEPENDS') or "").split():
> -- 
> 2.39.2
> 

> 
> 
> 


-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#193879): 
https://lists.openembedded.org/g/openembedded-core/message/193879
Mute This Topic: https://lists.openembedded.org/mt/103722088/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH v9 4/9] oe-selftest devtool: ide-sdk tests

2024-01-16 Thread Alexandre Belloni via lists.openembedded.org
I got these failures on the autobuilders:

https://autobuilder.yoctoproject.org/typhoon/#/builders/80/builds/6257/steps/14/logs/stdio
https://autobuilder.yoctoproject.org/typhoon/#/builders/127/builds/2751/steps/14/logs/stdio
https://autobuilder.yoctoproject.org/typhoon/#/builders/87/builds/6317/steps/14/logs/stdio


and this one:

https://autobuilder.yoctoproject.org/typhoon/#/builders/86/builds/6318/steps/14/logs/stdio


On 14/01/2024 23:14:16+0100, Adrian Freihofer wrote:
> Add some oe-selftests for the new devtool ide-sdk plugin. Most of the
> workflows are covered.
> 
> Many thanks to Enguerrand de Ribaucourt for testing and bug fixing.
> 
> Signed-off-by: Adrian Freihofer 
> ---
>  meta/lib/oeqa/selftest/cases/devtool.py | 492 
>  1 file changed, 492 insertions(+)
> 
> diff --git a/meta/lib/oeqa/selftest/cases/devtool.py 
> b/meta/lib/oeqa/selftest/cases/devtool.py
> index a8777207694..006c846438d 100644
> --- a/meta/lib/oeqa/selftest/cases/devtool.py
> +++ b/meta/lib/oeqa/selftest/cases/devtool.py
> @@ -12,6 +12,7 @@ import tempfile
>  import glob
>  import fnmatch
>  import unittest
> +import json
>  
>  from oeqa.selftest.case import OESelftestTestCase
>  from oeqa.utils.commands import runCmd, bitbake, get_bb_var, 
> create_temp_layer
> @@ -2314,3 +2315,494 @@ class DevtoolUpgradeTests(DevtoolBase):
>  
>  #Step 4.5
>  runCmd("grep %s %s" % (modconfopt, codeconfigfile))
> +
> +
> +class DevtoolIdeSdkTests(DevtoolBase):
> +def _write_bb_config(self, recipe_names):
> +"""Helper to write the bitbake local.conf file"""
> +conf_lines = [
> +'IMAGE_CLASSES += "image-combined-dbg"',
> +'IMAGE_GEN_DEBUGFS = "1"',
> +'IMAGE_INSTALL:append = " gdbserver %s"' % ' '.join(
> +[r + '-ptest' for r in recipe_names])
> +]
> +self.write_config("\n".join(conf_lines))
> +
> +def _check_workspace(self):
> +"""Check if a workspace directory is available and setup the 
> cleanup"""
> +self.assertTrue(not os.path.exists(self.workspacedir),
> +'This test cannot be run with a workspace directory 
> under the build directory')
> +self.track_for_cleanup(self.workspacedir)
> +self.add_command_to_tearDown('bitbake-layers remove-layer 
> */workspace')
> +
> +def _workspace_scripts_dir(self, recipe_name):
> +return os.path.realpath(os.path.join(self.builddir, 'workspace', 
> 'ide-sdk', recipe_name, 'scripts'))
> +
> +def _sources_scripts_dir(self, src_dir):
> +return os.path.realpath(os.path.join(src_dir, 'oe-scripts'))
> +
> +def _workspace_gdbinit_dir(self, recipe_name):
> +return os.path.realpath(os.path.join(self.builddir, 'workspace', 
> 'ide-sdk', recipe_name, 'scripts', 'gdbinit'))
> +
> +def _sources_gdbinit_dir(self, src_dir):
> +return os.path.realpath(os.path.join(src_dir, 'oe-gdbinit'))
> +
> +def _devtool_ide_sdk_recipe(self, recipe_name, build_file, testimage):
> +"""Setup a recipe for working with devtool ide-sdk
> +
> +Basically devtool modify -x followed by some tests
> +"""
> +tempdir = tempfile.mkdtemp(prefix='devtoolqa')
> +self.track_for_cleanup(tempdir)
> +self.add_command_to_tearDown('bitbake -c clean %s' % recipe_name)
> +
> +result = runCmd('devtool modify %s -x %s' % (recipe_name, tempdir))
> +self.assertExists(os.path.join(tempdir, build_file),
> +  'Extracted source could not be found')
> +self.assertExists(os.path.join(self.workspacedir, 'conf',
> +   'layer.conf'), 'Workspace directory 
> not created')
> +matches = glob.glob(os.path.join(self.workspacedir,
> +'appends', recipe_name + '.bbappend'))
> +self.assertTrue(matches, 'bbappend not created %s' % result.output)
> +
> +# Test devtool status
> +result = runCmd('devtool status')
> +self.assertIn(recipe_name, result.output)
> +self.assertIn(tempdir, result.output)
> +self._check_src_repo(tempdir)
> +
> +# Usually devtool ide-sdk would initiate the build of the SDK.
> +# But there is a circular dependency with starting Qemu and passing 
> the IP of runqemu to devtool ide-sdk.
> +if testimage:
> +bitbake("%s qemu-native qemu-helper-native" % testimage)
> +deploy_dir_image = get_bb_var('DEPLOY_DIR_IMAGE')
> +self.add_command_to_tearDown('bitbake -c clean %s' % testimage)
> +self.add_command_to_tearDown(
> +'rm -f %s/%s*' % (deploy_dir_image, testimage))
> +
> +return tempdir
> +
> +def _get_recipe_ids(self, recipe_name):
> +"""IDs needed to write recipe specific config entries into IDE 
> config files"""
> +package_arch = get_bb_var('PACKAGE_ARCH', recipe_name)
> +recipe_id = reci

Re: [OE-core] [PATCH 2/2] openssl: Fix ptest dependencies on perl-module-* being ignored by COMPLEMENTARY_GLOB

2024-01-16 Thread Tim Orling
On Tue, Jan 16, 2024 at 10:57 AM Tim Orling via lists.openembedded.org
 wrote:

>
>
> On Tue, Jan 16, 2024 at 9:21 AM Alexander Kanavin 
> wrote:
>
>> How about simple depending on specific module packages? I don’t think
>> OpenSSL truly needs all modules.
>>
>
> Agreed. I don’t see a compelling reason to add the perl-modules-force-all
> complication. This will add confusion in my opinion.
>
> Iterate the tests and add the required perl-module-* sub-packages one by
> one (or by inspection if the test cases)
>
> In almost all cases, RDEPENDS on perl-modules is a short cut and should be
> avoided in favor of being explicit.
>
> This inspired me to sweep the dust off of
https://git.yoctoproject.org/poky-contrib/log/?h=timo/perl-deps_13376

This detects (but doesn't yet know how to properly handle) the RDEPENDS for
openssl-ptest. See attached snippet of the log.

It is too greedy so some dependencies are not going to be needed.



>> Alex
>>
>> On Tue 16. Jan 2024 at 17.56, Lyu, William via lists.openembedded.org
>>  wrote:
>>
>>> From: William Lyu 
>>>
>>> Change the openssl-ptest RDEPENDS from perl-modules to
>>> perl-modules-force-all which RDEPENDS on the same set of packages
>>> perl-module-* recommended by perl-modules. So, when openssl-ptest is
>>> added via COMPLEMENTARY_GLOB "ptest-pkgs", its dependencies on these
>>> perl-module-* packages still get added.
>>>
>>> Signed-off-by: William Lyu 
>>> ---
>>>  meta/recipes-connectivity/openssl/openssl_3.2.0.bb | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/meta/recipes-connectivity/openssl/openssl_3.2.0.bb
>>> b/meta/recipes-connectivity/openssl/openssl_3.2.0.bb
>>> index d041d2d214..7076bd3a7b 100644
>>> --- a/meta/recipes-connectivity/openssl/openssl_3.2.0.bb
>>> +++ b/meta/recipes-connectivity/openssl/openssl_3.2.0.bb
>>> @@ -247,7 +247,7 @@ CONFFILES:openssl-conf =
>>> "${sysconfdir}/ssl/openssl.cnf"
>>>
>>>  RRECOMMENDS:libcrypto += "openssl-conf ${PN}-ossl-module-legacy"
>>>  RDEPENDS:${PN}-misc = "perl"
>>> -RDEPENDS:${PN}-ptest += "openssl-bin perl perl-modules bash sed"
>>> +RDEPENDS:${PN}-ptest += "openssl-bin perl perl-modules-force-all bash
>>> sed"
>>>
>>>  RDEPENDS:${PN}-bin += "openssl-conf"
>>>
>>> --
>>> 2.43.0
>>>
>>>
>>>
>>>
>>>
>>
>>
>>
> 
>
>
DEBUG: openssl-3.2.0-r0 do_perldeps: len(unresolved_rdeps[openssl-ptest]) = 82
DEBUG: openssl-3.2.0-r0 do_perldeps: unresolved_rdeps[openssl-ptest]:
DEBUG: openssl-3.2.0-r0 do_perldeps: 	perl(TLSProxy::ServerHello)
DEBUG: openssl-3.2.0-r0 do_perldeps: 	perl(OpenSSL::Util)
DEBUG: openssl-3.2.0-r0 do_perldeps: 	perl(Errno)
DEBUG: openssl-3.2.0-r0 do_perldeps: 	perl(Getopt::Std)
DEBUG: openssl-3.2.0-r0 do_perldeps: 	perl >= 0:5.008
DEBUG: openssl-3.2.0-r0 do_perldeps: 	perl(parent)
DEBUG: openssl-3.2.0-r0 do_perldeps: 	perl(FindBin)
DEBUG: openssl-3.2.0-r0 do_perldeps: 	perl(platform::mingw)
DEBUG: openssl-3.2.0-r0 do_perldeps: 	perl(List::Util)
DEBUG: openssl-3.2.0-r0 do_perldeps: 	perl(warnings)
DEBUG: openssl-3.2.0-r0 do_perldeps: 	perl(File::Basename)
DEBUG: openssl-3.2.0-r0 do_perldeps: 	perl(IO::Socket)
DEBUG: openssl-3.2.0-r0 do_perldeps: 	perl(OpenSSL::Glob)
DEBUG: openssl-3.2.0-r0 do_perldeps: 	perl(Time::Local)
DEBUG: openssl-3.2.0-r0 do_perldeps: 	perl >= 1:5.10.0
DEBUG: openssl-3.2.0-r0 do_perldeps: 	perl(OpenSSL::Template)
DEBUG: openssl-3.2.0-r0 do_perldeps: 	perl(Test::Pod) >= 1.41
DEBUG: openssl-3.2.0-r0 do_perldeps: 	perl(TLSProxy::NewSessionTicket)
DEBUG: openssl-3.2.0-r0 do_perldeps: 	perl(File::Glob)
DEBUG: openssl-3.2.0-r0 do_perldeps: 	perl(Carp)
DEBUG: openssl-3.2.0-r0 do_perldeps: 	perl(Text::Diff)
DEBUG: openssl-3.2.0-r0 do_perldeps: 	perl(Text::Template) >= 1.46
DEBUG: openssl-3.2.0-r0 do_perldeps: 	perl(OpenSSL::Test::Simple)
DEBUG: openssl-3.2.0-r0 do_perldeps: 	perl(Pod::Html)
DEBUG: openssl-3.2.0-r0 do_perldeps: 	perl(Getopt::Long)
DEBUG: openssl-3.2.0-r0 do_perldeps: 	perl(File::Path) >= 2.00
DEBUG: openssl-3.2.0-r0 do_perldeps: 	perl(ssltests_base)
DEBUG: openssl-3.2.0-r0 do_perldeps: 	perl(TLSProxy::CertificateRequest)
DEBUG: openssl-3.2.0-r0 do_perldeps: 	perl(platform::BASE)
DEBUG: openssl-3.2.0-r0 do_perldeps: 	perl(TLSProxy::Alert)
DEBUG: openssl-3.2.0-r0 do_perldeps: 	perl(OpenSSL::Test)
DEBUG: openssl-3.2.0-r0 do_perldeps: 	perl(Test::More) >= 0.96
DEBUG: openssl-3.2.0-r0 do_perldeps: 	perl(TLSProxy::ServerKeyExchange)
DEBUG: openssl-3.2.0-r0 do_perldeps: 	perl(platform)
DEBUG: openssl-3.2.0-r0 do_perldeps: 	perl(Config)
DEBUG: openssl-3.2.0-r0 do_perldeps: 	perl(File::Temp)
DEBUG: openssl-3.2.0-r0 do_perldeps: 	perl(platform::Windows)
DEBUG: openssl-3.2.0-r0 do_perldeps: 	perl(Data::Dumper)
DEBUG: openssl-3.2.0-r0 do_perldeps: 	perl(OpenSSL::fallback)
DEBUG: openssl-3.2.0-r0 do_perldeps: 	perl(OpenSSL::Ordinals)
DEBUG: openssl-3.2.0-r0 do_perldeps: 	perl(Math::BigInt)
DEBUG: openssl-3.2.0-r0 do_perldeps: 	perl(Pod::Usage)
DEBUG: openssl-3.2.0-r0 do_perldeps: 	perl(Encode)
DEBUG: openssl-3.2.0-r0 do_perldeps: 	perl(Cwd)
DEBUG: ope

[OE-core] [PATCH] libgudev: Pass export-dynamic to linker directly.

2024-01-16 Thread Khem Raj
New clang 18+ errors out on this while older clang does not

Signed-off-by: Khem Raj 
---
 ...Pass-export-dynamic-option-to-linker.patch | 38 +++
 meta/recipes-gnome/libgudev/libgudev_238.bb   |  2 +
 2 files changed, 40 insertions(+)
 create mode 100644 
meta/recipes-gnome/libgudev/libgudev/0001-meson-Pass-export-dynamic-option-to-linker.patch

diff --git 
a/meta/recipes-gnome/libgudev/libgudev/0001-meson-Pass-export-dynamic-option-to-linker.patch
 
b/meta/recipes-gnome/libgudev/libgudev/0001-meson-Pass-export-dynamic-option-to-linker.patch
new file mode 100644
index 000..8a06d244e4c
--- /dev/null
+++ 
b/meta/recipes-gnome/libgudev/libgudev/0001-meson-Pass-export-dynamic-option-to-linker.patch
@@ -0,0 +1,38 @@
+From dc4fcfb1e1e2326a412b252314af3e9424a31457 Mon Sep 17 00:00:00 2001
+From: Khem Raj 
+Date: Tue, 16 Jan 2024 12:02:46 -0800
+Subject: [PATCH] meson: Pass --export-dynamic option to linker
+
+Bypass the compiler driver trying to comprehend and translate it for
+linker, since its not clear what the right behavior should be, gcc seems
+to translate it into --export-dynamic but clang 18+ rejects it
+
+| x86_64-yoe-linux-clang: error: unknown argument: '-export-dynamic'
+
+also see [1]
+
+This makes it work as intended across gcc and clang
+
+Upstream-Status: Submitted 
[https://gitlab.gnome.org/GNOME/libgudev/-/merge_requests/30]
+[1] 
https://discourse.llvm.org/t/clang-option-export-dynamic-parse-to-e-xport-dynamic-error/72454
+Signed-off-by: Khem Raj 
+---
+ gudev/meson.build | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/gudev/meson.build b/gudev/meson.build
+index e904203..3ed580b 100644
+--- a/gudev/meson.build
 b/gudev/meson.build
+@@ -33,7 +33,7 @@ libgudev_c_args = [
+ ]
+ 
+ libgudev_link_args = [
+-  '-export-dynamic',
++  '-Wl,--export-dynamic',
+   '-Wl,--version-script,@0@/libgudev-1.0.sym'.format(top_srcdir),
+ ]
+ 
+-- 
+2.43.0
+
diff --git a/meta/recipes-gnome/libgudev/libgudev_238.bb 
b/meta/recipes-gnome/libgudev/libgudev_238.bb
index 5923544ecad..f197f6421db 100644
--- a/meta/recipes-gnome/libgudev/libgudev_238.bb
+++ b/meta/recipes-gnome/libgudev/libgudev_238.bb
@@ -16,6 +16,8 @@ LIC_FILES_CHKSUM = 
"file://COPYING;md5=4fbd65380cdd255951079008b364516c"
 
 inherit gnomebase gobject-introspection gtk-doc
 
+SRC_URI += "file://0001-meson-Pass-export-dynamic-option-to-linker.patch"
+
 GIR_MESON_ENABLE_FLAG = 'enabled'
 GIR_MESON_DISABLE_FLAG = 'disabled'
 
-- 
2.43.0


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#193876): 
https://lists.openembedded.org/g/openembedded-core/message/193876
Mute This Topic: https://lists.openembedded.org/mt/103773001/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] how badly do symlinks from within ${S} to outside ${S} mess up sstate?

2024-01-16 Thread Richard Purdie
On Tue, 2024-01-16 at 09:23 -0500, Robert P. J. Day wrote:
>   a very weird question, to be sure, but i literally just ran across a
> recipe that does the following (i will paraphrase some stuff to
> protect the innocent).
> 
>   the recipe processes a bunch of XML source files, and generates from
> them JSON files, so any change in any of the XML source files should
> (obviously) trigger a rebuild of the recipe. and here's the problem.
> 
>   the XML files are not copied into the recipe source directory, and
> are not even referenced by SRC_URI. rather, the files live in a
> well-known location on the build host (placed there by a monstrous
> "repo sync"), and to save time and space, the recipe just *symlinks*
> from inside ${S} to the XML source files outside of ${S}, then
> proceeds to process them to generate the subsequent JSON files.
> 
>   the complaint is that, when the build pipeline started taking
> advantage of sstate-cache, even after some of the XML files were
> changed, the recipe would not rebuild.
> 
>   once i understood what was happening, my immediate reaction was
> along the lines, "well, since what is under ${S} is simply symlinks to
> files *outside* of ${S} and (worse) those symlink names will never
> change (all that will change is the XML files at the other end), how
> is bitbake supposed to have any idea that those XML files have
> changed to kick off a rebuild?"
> 
>   so my initial response was, "this does not surprise me at all," but
> does my reasoning hold up? obviously, this should probably use a
> combination of bin_package and externalsrc, but as it is now, is it
> moderately accurate to suggest that it is those symlinks that are
> preventing bitbake from understanding that anything has changed, so
> that it continues to use the old sstate-cache?

Inputs to a recipe need to come through SRC_URI. That way bitbake can
know when they change. If you point at some random place via a symlink
how is bitbake supposed to know if/when they change?

Yes, pointing at a large tree of files will take time to hash and yes,
that can make parsing slow. Either you care when it changes or you
don't.

The inputs are used to generate a hash which makes up the hash
representing the task. When the hash changes, we know that sstate is
invalid and we need to rebuild.

Cheers,

Richard




-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#193875): 
https://lists.openembedded.org/g/openembedded-core/message/193875
Mute This Topic: https://lists.openembedded.org/mt/103762271/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH] tune-core2: Update qemu cpu to supported model

2024-01-16 Thread Simone Weiß
From: Simone Weiß 

Fixes [YOCTO #12388]

QEMUs documentation does recommend to not use n270 and core2duo as
an argument to -cpu anymore. Update therefore the QEMU cpu option for
the core2duo tune to Nehalam. Tested it locally with QEMU and KVM.

Signed-off-by: Simone Weiß 
---
 meta/conf/machine/include/x86/tune-core2.inc | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/meta/conf/machine/include/x86/tune-core2.inc 
b/meta/conf/machine/include/x86/tune-core2.inc
index 97b7c1b188..082fd4efc3 100644
--- a/meta/conf/machine/include/x86/tune-core2.inc
+++ b/meta/conf/machine/include/x86/tune-core2.inc
@@ -21,18 +21,18 @@ TUNE_FEATURES:tune-core2-32 = "${TUNE_FEATURES:tune-x86} 
core2"
 BASE_LIB:tune-core2-32 = "lib"
 TUNE_PKGARCH:tune-core2-32 = "core2-32"
 PACKAGE_EXTRA_ARCHS:tune-core2-32 = "${PACKAGE_EXTRA_ARCHS:tune-i686} core2-32"
-QEMU_EXTRAOPTIONS_core2-32 = " -cpu n270"
+QEMU_EXTRAOPTIONS_core2-32 = " -cpu Nehalem,check=false"
 
 AVAILTUNES += "core2-64"
 TUNE_FEATURES:tune-core2-64 = "${TUNE_FEATURES:tune-x86-64} core2"
 BASE_LIB:tune-core2-64 = "lib64"
 TUNE_PKGARCH:tune-core2-64 = "core2-64"
 PACKAGE_EXTRA_ARCHS:tune-core2-64 = "${PACKAGE_EXTRA_ARCHS:tune-x86-64} 
core2-64"
-QEMU_EXTRAOPTIONS_core2-64 = " -cpu core2duo"
+QEMU_EXTRAOPTIONS_core2-64 = " -cpu Nehalem,check=false"
 
 AVAILTUNES += "core2-64-x32"
 TUNE_FEATURES:tune-core2-64-x32 = "${TUNE_FEATURES:tune-x86-64-x32} core2"
 BASE_LIB:tune-core2-64-x32 = "libx32"
 TUNE_PKGARCH:tune-core2-64-x32 = "core2-64-x32"
 PACKAGE_EXTRA_ARCHS:tune-core2-64-x32 = 
"${PACKAGE_EXTRA_ARCHS:tune-x86-64-x32} core2-64-x32"
-QEMU_EXTRAOPTIONS_core2-64-x32 = " -cpu core2duo"
+QEMU_EXTRAOPTIONS_core2-64-x32 = " -cpu Nehalem,check=false"
-- 
2.39.2


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#193874): 
https://lists.openembedded.org/g/openembedded-core/message/193874
Mute This Topic: https://lists.openembedded.org/mt/103771791/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [RFT][PATCH] glibc: Upgrade to 2.39

2024-01-16 Thread Khem Raj
Upgrade localdef to get glibc 2.39 build fixes
Details of release [1]

[1] https://sourceware.org/glibc/wiki/Release/2.39

Signed-off-by: Khem Raj 
---
 meta/conf/distro/include/tcmode-default.inc   |  2 +-
 ...2.38.bb => cross-localedef-native_2.39.bb} |  0
 meta/recipes-core/glibc/glibc-common.inc  |  2 +-
 ...bc-locale_2.38.bb => glibc-locale_2.39.bb} |  0
 ...bc-mtrace_2.38.bb => glibc-mtrace_2.39.bb} |  0
 ...-scripts_2.38.bb => glibc-scripts_2.39.bb} |  0
 ...tsuite_2.38.bb => glibc-testsuite_2.39.bb} |  0
 meta/recipes-core/glibc/glibc-version.inc |  8 ++--
 ...ests_2.38.bb => glibc-y2038-tests_2.39.bb} |  0
 ...dd-hardlink-resolver-from-util-linux.patch |  2 +-
 ...-fix-ups-hardlink-to-make-it-compile.patch |  2 +-
 ...Look-for-host-system-ld.so.cache-as-.patch |  8 ++--
 ...Fix-buffer-overrun-with-a-relocated-.patch |  4 +-
 ...Raise-the-size-of-arrays-containing-.patch | 22 -
 ...k-glibc-Allow-64-bit-atomics-for-x86.patch |  4 +-
 ...Make-relocatable-install-for-locales.patch | 10 ++--
 ...Fall-back-to-faccessat-on-faccess2-r.patch |  4 +-
 ...the-path-sets-wrong-config-variables.patch |  2 +-
 ...ss-building-and-testing-instructions.patch |  2 +-
 ...glibc-Help-bootstrap-cross-toolchain.patch |  4 +-
 ...eglibc-Resolve-__fpscr_values-on-SH4.patch |  4 +-
 ...port-cross-locale-generation-support.patch | 46 +--
 ...-archive-uses-a-hard-coded-locale-pa.patch |  4 +-
 ...Do-not-ask-compiler-for-finding-arch.patch |  2 +-
 ...y-the-header-between-arm-and-aarch64.patch |  4 +-
 ...h-printf-builtin-in-nscd-init-script.patch |  2 +-
 ...igure.ac-Set-libc_cv_rootsbindir-onl.patch |  2 +-
 ...ell-interpreter-overridable-in-tzsel.patch |  6 +--
 ...Use-bin-sh-default-shell-interpreter.patch |  2 +-
 ...d-failed-in-unprivileged-process-BZ-.patch |  6 +--
 ...build-time-paths-in-the-output-binar.patch |  6 +--
 ...e-Pass-mcpu-along-with-march-to-dete.patch |  5 +-
 ...Bump-__GLIBC_MINOR__-to-39-on-master.patch | 25 ++
 .../glibc/{glibc_2.38.bb => glibc_2.39.bb}|  1 +
 34 files changed, 106 insertions(+), 85 deletions(-)
 rename meta/recipes-core/glibc/{cross-localedef-native_2.38.bb => 
cross-localedef-native_2.39.bb} (100%)
 rename meta/recipes-core/glibc/{glibc-locale_2.38.bb => glibc-locale_2.39.bb} 
(100%)
 rename meta/recipes-core/glibc/{glibc-mtrace_2.38.bb => glibc-mtrace_2.39.bb} 
(100%)
 rename meta/recipes-core/glibc/{glibc-scripts_2.38.bb => 
glibc-scripts_2.39.bb} (100%)
 rename meta/recipes-core/glibc/{glibc-testsuite_2.38.bb => 
glibc-testsuite_2.39.bb} (100%)
 rename meta/recipes-core/glibc/{glibc-y2038-tests_2.38.bb => 
glibc-y2038-tests_2.39.bb} (100%)
 create mode 100644 
meta/recipes-core/glibc/glibc/0024-features.h-Bump-__GLIBC_MINOR__-to-39-on-master.patch
 rename meta/recipes-core/glibc/{glibc_2.38.bb => glibc_2.39.bb} (98%)

diff --git a/meta/conf/distro/include/tcmode-default.inc 
b/meta/conf/distro/include/tcmode-default.inc
index 3720a4c5b86..977fb316107 100644
--- a/meta/conf/distro/include/tcmode-default.inc
+++ b/meta/conf/distro/include/tcmode-default.inc
@@ -20,7 +20,7 @@ GCCVERSION ?= "13.%"
 SDKGCCVERSION ?= "${GCCVERSION}"
 BINUVERSION ?= "2.41%"
 GDBVERSION ?= "14.%"
-GLIBCVERSION ?= "2.38%"
+GLIBCVERSION ?= "2.39%"
 LINUXLIBCVERSION ?= "6.6%"
 QEMUVERSION ?= "8.1%"
 GOVERSION ?= "1.20%"
diff --git a/meta/recipes-core/glibc/cross-localedef-native_2.38.bb 
b/meta/recipes-core/glibc/cross-localedef-native_2.39.bb
similarity index 100%
rename from meta/recipes-core/glibc/cross-localedef-native_2.38.bb
rename to meta/recipes-core/glibc/cross-localedef-native_2.39.bb
diff --git a/meta/recipes-core/glibc/glibc-common.inc 
b/meta/recipes-core/glibc/glibc-common.inc
index be33c29857c..5b62884a017 100644
--- a/meta/recipes-core/glibc/glibc-common.inc
+++ b/meta/recipes-core/glibc/glibc-common.inc
@@ -22,4 +22,4 @@ ARM_INSTRUCTION_SET:armv6 = "arm"
 #
 COMPATIBLE_HOST:libc-musl:class-target = "null"
 
-PV = "2.38"
+PV = "2.39+git"
diff --git a/meta/recipes-core/glibc/glibc-locale_2.38.bb 
b/meta/recipes-core/glibc/glibc-locale_2.39.bb
similarity index 100%
rename from meta/recipes-core/glibc/glibc-locale_2.38.bb
rename to meta/recipes-core/glibc/glibc-locale_2.39.bb
diff --git a/meta/recipes-core/glibc/glibc-mtrace_2.38.bb 
b/meta/recipes-core/glibc/glibc-mtrace_2.39.bb
similarity index 100%
rename from meta/recipes-core/glibc/glibc-mtrace_2.38.bb
rename to meta/recipes-core/glibc/glibc-mtrace_2.39.bb
diff --git a/meta/recipes-core/glibc/glibc-scripts_2.38.bb 
b/meta/recipes-core/glibc/glibc-scripts_2.39.bb
similarity index 100%
rename from meta/recipes-core/glibc/glibc-scripts_2.38.bb
rename to meta/recipes-core/glibc/glibc-scripts_2.39.bb
diff --git a/meta/recipes-core/glibc/glibc-testsuite_2.38.bb 
b/meta/recipes-core/glibc/glibc-testsuite_2.39.bb
similarity index 100%
rename from meta/recipes-core/glibc/glibc-testsuite_2.38.bb
rename to meta/recipes-core/glibc/glibc-testsuite_2.39.bb
diff --git a/meta/recipes-core/glibc/glibc-version.in

Re: [OE-core] [PATCH 2/2] openssl: Fix ptest dependencies on perl-module-* being ignored by COMPLEMENTARY_GLOB

2024-01-16 Thread Tim Orling
On Tue, Jan 16, 2024 at 9:21 AM Alexander Kanavin 
wrote:

> How about simple depending on specific module packages? I don’t think
> OpenSSL truly needs all modules.
>

Agreed. I don’t see a compelling reason to add the perl-modules-force-all
complication. This will add confusion in my opinion.

Iterate the tests and add the required perl-module-* sub-packages one by
one (or by inspection if the test cases)

In almost all cases, RDEPENDS on perl-modules is a short cut and should be
avoided in favor of being explicit.


> Alex
>
> On Tue 16. Jan 2024 at 17.56, Lyu, William via lists.openembedded.org
>  wrote:
>
>> From: William Lyu 
>>
>> Change the openssl-ptest RDEPENDS from perl-modules to
>> perl-modules-force-all which RDEPENDS on the same set of packages
>> perl-module-* recommended by perl-modules. So, when openssl-ptest is
>> added via COMPLEMENTARY_GLOB "ptest-pkgs", its dependencies on these
>> perl-module-* packages still get added.
>>
>> Signed-off-by: William Lyu 
>> ---
>>  meta/recipes-connectivity/openssl/openssl_3.2.0.bb | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-connectivity/openssl/openssl_3.2.0.bb
>> b/meta/recipes-connectivity/openssl/openssl_3.2.0.bb
>> index d041d2d214..7076bd3a7b 100644
>> --- a/meta/recipes-connectivity/openssl/openssl_3.2.0.bb
>> +++ b/meta/recipes-connectivity/openssl/openssl_3.2.0.bb
>> @@ -247,7 +247,7 @@ CONFFILES:openssl-conf =
>> "${sysconfdir}/ssl/openssl.cnf"
>>
>>  RRECOMMENDS:libcrypto += "openssl-conf ${PN}-ossl-module-legacy"
>>  RDEPENDS:${PN}-misc = "perl"
>> -RDEPENDS:${PN}-ptest += "openssl-bin perl perl-modules bash sed"
>> +RDEPENDS:${PN}-ptest += "openssl-bin perl perl-modules-force-all bash
>> sed"
>>
>>  RDEPENDS:${PN}-bin += "openssl-conf"
>>
>> --
>> 2.43.0
>>
>>
>>
>>
>>
> 
>
>

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#193872): 
https://lists.openembedded.org/g/openembedded-core/message/193872
Mute This Topic: https://lists.openembedded.org/mt/103766390/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH] python3-alabaster: upgrade 0.7.13 -> 0.7.16

2024-01-16 Thread Tim Orling
* Since 0.7.14 setup.py was dropped and now the project is using the
  flit core backend (inherit python_flit_core)
* Add BUGTRACKER url

License-Update: LICENSE renamed to LICENSE.rst

https://alabaster.readthedocs.io/en/latest/changelog.html#changelog

0.7.14 – 2024-01-08
* Dropped support for Python 3.8 and earlier.
* Dropped support for Sphinx 3.3 and earlier.
* #198 Fix horizontal scrolling on mobile.
* #206 Properly support the html_support_sphinx config value.
* #211 Fix the GitHub ‘forkme’ banner.
* Added alabaster_version_info to the HTML template context.
* Declare support for Python 3.13.
* Adopt the Ruff linter and formatter.
* Migrate from CircleCI to GitHub Actions.

0.7.15 – 2024-01-08
* #213 Allow an arbitrary string in the logo_name option.
* #114 Improved sidebar CSS styles.
* #178 Deprecated canonical_url in favor of html_baseurl.
* #200 Removed duplicate  tag.
* #188 Removed underline from whitespace.
* #164 Removed type="text/javascript" from 

Re: [OE-core] Patchtest results for [PATCH v2 7/9] oeqa/selftest/recipetool: Move create_go test to a proper class

2024-01-16 Thread Trevor Gamblin


On 2024-01-16 05:05, Vyacheslav Yurkov wrote:
I also have the same opinion. What else am I supposed to write in the 
body if it were merely a refactoring (function moved, renamed, etc), 
and it's already described in the hearer?


It shouldn't be considered a strict requirement, as it's going to be 
difficult for Patchtest to correctly identify which pages do and don't 
need more explanation.


If you want to completely avoid that feedback, then the solution for now 
is to re-state the shortlog as a one-line commit description.



Slava

On 16.01.2024 10:32, Alexander Kanavin wrote:

Because making it strict would only result in useless noise in the
commit logs. It's entirely valid to have changes that can fully be
described with a commit header. I see it as a notice to consider if
the commit message should be added, at the discretion of both
submitter and committer.

Alex

On Tue, 16 Jan 2024 at 10:28, Alexandre Belloni
 wrote:

On 16/01/2024 10:08:50+0100, Alexander Kanavin wrote:

No.

Why not?







-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#193870): 
https://lists.openembedded.org/g/openembedded-core/message/193870
Mute This Topic: https://lists.openembedded.org/mt/103758512/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH 1/2] perl: Add option to prevent COMPLEMENTARY_GLOB from ignoring perl-modules

2024-01-16 Thread Alexander Kanavin
If this is only for fixing OpenSSL ptest, then it’s not needed perhaps,
once OpenSSL recipe is fixed?

Alex

On Tue 16. Jan 2024 at 17.56, Lyu, William via lists.openembedded.org
 wrote:

> From: William Lyu 
>
> When perl-modules is added via COMPLEMENTARY_GLOB, all perl-module-*
> packages recommended by perl-modules are ignored due to the defined
> behavior of COMPLEMENTARY_GLOB.
>
> This patch creates a new package perl-modules-force-all that RDEPENDS on
> the same set of packages perl-modules recommends. If another recipe
> always needs the packages recommended by perl-modules, it can add
> perl-modules-force-all to RDEPENDS to make sure that the recommended
> packages by perl-modules are not ignored by COMPLEMENTARY_GLOB.
>
> Signed-off-by: William Lyu 
> ---
>  meta/recipes-devtools/perl/perl_5.38.2.bb | 22 ++
>  1 file changed, 22 insertions(+)
>
> diff --git a/meta/recipes-devtools/perl/perl_5.38.2.bb
> b/meta/recipes-devtools/perl/perl_5.38.2.bb
> index a9d684cfc5..f75c5aa971 100644
> --- a/meta/recipes-devtools/perl/perl_5.38.2.bb
> +++ b/meta/recipes-devtools/perl/perl_5.38.2.bb
> @@ -311,6 +311,14 @@ ALTERNATIVE_LINK_NAME[Thread.3] =
> "${mandir}/man3/Thread.3"
>  ALLOW_EMPTY:${PN}-modules = "1"
>  PACKAGES += "${PN}-modules "
>
> +# When perl-modules is added through COMPLEMENTARY_GLOB, as it is
> recommending
> +# packages, all its recommendations will be ignored. So, we create a
> +# perl-modules-force-all package depending on the same set of packages as
> listed
> +# in perl-modules to provide a way to guarantee COMPLEMENTARY_GLOB not
> removing
> +# these packages.
> +ALLOW_EMPTY:${PN}-modules-force-all = "1"
> +PACKAGES += "${PN}-modules-force-all "
> +
>  PACKAGESPLITFUNCS =+ "split_perl_packages"
>
>  python split_perl_packages () {
> @@ -328,6 +336,20 @@ python split_perl_packages () {
>  packages = filter(lambda p: 'perl-module-' in p,
> d.getVar('PACKAGES').split())
>  d.setVar(d.expand("RRECOMMENDS:${PN}-modules"), ' '.join(packages))
>
> +# perl-modules-force-all provides a way to prevent COMPLEMENTARY_GLOB
> +# from removing the packages specified in perl-modules.
> +# perl-modules-force-all contains the same set of packages as
> perl-modules.
> +d.setVar(
> +d.expand("RDEPENDS:${PN}-modules-force-all"),
> +d.getVar(d.expand("RRECOMMENDS:${PN}-modules"))
> +)
> +
> +# As perl-modules-force-all depends on all other, potentially
> non-existent,
> +# perl packages, we allow these packages to be empty to prevent build
> +# errors.
> +for pkg in
> d.getVar(d.expand("RDEPENDS:${PN}-modules-force-all")).split():
> +d.setVar(d.expand("ALLOW_EMPTY:" + pkg), "1")
> +
>  # Read the pre-generated dependency file, and use it to set module
> dependecies
>  for line in open(d.expand("${WORKDIR}") +
> '/perl-rdepends.txt').readlines():
>  splitline = line.split()
> --
> 2.43.0
>
>
> 
>
>

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#193869): 
https://lists.openembedded.org/g/openembedded-core/message/193869
Mute This Topic: https://lists.openembedded.org/mt/103766391/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH 2/2] openssl: Fix ptest dependencies on perl-module-* being ignored by COMPLEMENTARY_GLOB

2024-01-16 Thread Alexander Kanavin
How about simple depending on specific module packages? I don’t think
OpenSSL truly needs all modules.

Alex

On Tue 16. Jan 2024 at 17.56, Lyu, William via lists.openembedded.org
 wrote:

> From: William Lyu 
>
> Change the openssl-ptest RDEPENDS from perl-modules to
> perl-modules-force-all which RDEPENDS on the same set of packages
> perl-module-* recommended by perl-modules. So, when openssl-ptest is
> added via COMPLEMENTARY_GLOB "ptest-pkgs", its dependencies on these
> perl-module-* packages still get added.
>
> Signed-off-by: William Lyu 
> ---
>  meta/recipes-connectivity/openssl/openssl_3.2.0.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-connectivity/openssl/openssl_3.2.0.bb
> b/meta/recipes-connectivity/openssl/openssl_3.2.0.bb
> index d041d2d214..7076bd3a7b 100644
> --- a/meta/recipes-connectivity/openssl/openssl_3.2.0.bb
> +++ b/meta/recipes-connectivity/openssl/openssl_3.2.0.bb
> @@ -247,7 +247,7 @@ CONFFILES:openssl-conf =
> "${sysconfdir}/ssl/openssl.cnf"
>
>  RRECOMMENDS:libcrypto += "openssl-conf ${PN}-ossl-module-legacy"
>  RDEPENDS:${PN}-misc = "perl"
> -RDEPENDS:${PN}-ptest += "openssl-bin perl perl-modules bash sed"
> +RDEPENDS:${PN}-ptest += "openssl-bin perl perl-modules-force-all bash sed"
>
>  RDEPENDS:${PN}-bin += "openssl-conf"
>
> --
> 2.43.0
>
>
> 
>
>

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#193868): 
https://lists.openembedded.org/g/openembedded-core/message/193868
Mute This Topic: https://lists.openembedded.org/mt/103766390/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH 2/2] openssl: Fix ptest dependencies on perl-module-* being ignored by COMPLEMENTARY_GLOB

2024-01-16 Thread Lyu, William via lists.openembedded.org
From: William Lyu 

Change the openssl-ptest RDEPENDS from perl-modules to
perl-modules-force-all which RDEPENDS on the same set of packages
perl-module-* recommended by perl-modules. So, when openssl-ptest is
added via COMPLEMENTARY_GLOB "ptest-pkgs", its dependencies on these
perl-module-* packages still get added.

Signed-off-by: William Lyu 
---
 meta/recipes-connectivity/openssl/openssl_3.2.0.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-connectivity/openssl/openssl_3.2.0.bb 
b/meta/recipes-connectivity/openssl/openssl_3.2.0.bb
index d041d2d214..7076bd3a7b 100644
--- a/meta/recipes-connectivity/openssl/openssl_3.2.0.bb
+++ b/meta/recipes-connectivity/openssl/openssl_3.2.0.bb
@@ -247,7 +247,7 @@ CONFFILES:openssl-conf = "${sysconfdir}/ssl/openssl.cnf"
 
 RRECOMMENDS:libcrypto += "openssl-conf ${PN}-ossl-module-legacy"
 RDEPENDS:${PN}-misc = "perl"
-RDEPENDS:${PN}-ptest += "openssl-bin perl perl-modules bash sed"
+RDEPENDS:${PN}-ptest += "openssl-bin perl perl-modules-force-all bash sed"
 
 RDEPENDS:${PN}-bin += "openssl-conf"
 
-- 
2.43.0


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#193866): 
https://lists.openembedded.org/g/openembedded-core/message/193866
Mute This Topic: https://lists.openembedded.org/mt/103766390/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH 1/2] perl: Add option to prevent COMPLEMENTARY_GLOB from ignoring perl-modules

2024-01-16 Thread Lyu, William via lists.openembedded.org
From: William Lyu 

When perl-modules is added via COMPLEMENTARY_GLOB, all perl-module-*
packages recommended by perl-modules are ignored due to the defined
behavior of COMPLEMENTARY_GLOB.

This patch creates a new package perl-modules-force-all that RDEPENDS on
the same set of packages perl-modules recommends. If another recipe
always needs the packages recommended by perl-modules, it can add
perl-modules-force-all to RDEPENDS to make sure that the recommended
packages by perl-modules are not ignored by COMPLEMENTARY_GLOB.

Signed-off-by: William Lyu 
---
 meta/recipes-devtools/perl/perl_5.38.2.bb | 22 ++
 1 file changed, 22 insertions(+)

diff --git a/meta/recipes-devtools/perl/perl_5.38.2.bb 
b/meta/recipes-devtools/perl/perl_5.38.2.bb
index a9d684cfc5..f75c5aa971 100644
--- a/meta/recipes-devtools/perl/perl_5.38.2.bb
+++ b/meta/recipes-devtools/perl/perl_5.38.2.bb
@@ -311,6 +311,14 @@ ALTERNATIVE_LINK_NAME[Thread.3] = "${mandir}/man3/Thread.3"
 ALLOW_EMPTY:${PN}-modules = "1"
 PACKAGES += "${PN}-modules "
 
+# When perl-modules is added through COMPLEMENTARY_GLOB, as it is recommending
+# packages, all its recommendations will be ignored. So, we create a
+# perl-modules-force-all package depending on the same set of packages as 
listed
+# in perl-modules to provide a way to guarantee COMPLEMENTARY_GLOB not removing
+# these packages.
+ALLOW_EMPTY:${PN}-modules-force-all = "1"
+PACKAGES += "${PN}-modules-force-all "
+
 PACKAGESPLITFUNCS =+ "split_perl_packages"
 
 python split_perl_packages () {
@@ -328,6 +336,20 @@ python split_perl_packages () {
 packages = filter(lambda p: 'perl-module-' in p, 
d.getVar('PACKAGES').split())
 d.setVar(d.expand("RRECOMMENDS:${PN}-modules"), ' '.join(packages))
 
+# perl-modules-force-all provides a way to prevent COMPLEMENTARY_GLOB
+# from removing the packages specified in perl-modules.
+# perl-modules-force-all contains the same set of packages as perl-modules.
+d.setVar(
+d.expand("RDEPENDS:${PN}-modules-force-all"),
+d.getVar(d.expand("RRECOMMENDS:${PN}-modules"))
+)
+
+# As perl-modules-force-all depends on all other, potentially non-existent,
+# perl packages, we allow these packages to be empty to prevent build
+# errors.
+for pkg in d.getVar(d.expand("RDEPENDS:${PN}-modules-force-all")).split():
+d.setVar(d.expand("ALLOW_EMPTY:" + pkg), "1")
+
 # Read the pre-generated dependency file, and use it to set module 
dependecies
 for line in open(d.expand("${WORKDIR}") + 
'/perl-rdepends.txt').readlines():
 splitline = line.split()
-- 
2.43.0


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#193867): 
https://lists.openembedded.org/g/openembedded-core/message/193867
Mute This Topic: https://lists.openembedded.org/mt/103766391/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] Yocto Project Status 16 January 2024 (WW03)

2024-01-16 Thread Stephen Jolley
Current Dev Position: YP 5.0 M2

Next Deadline: 15th January 2024 YP 5.0 M2 build

Next Team Meetings:

   -

   Bug Triage meeting Thursday January 18th at 7:30 am PST (
   https://zoom.us/j/454367603?pwd=ZGxoa2ZXL3FkM3Y0bFd5aVpHVVZ6dz09)
   -

   Weekly Project Engineering Sync Tuesday January 16th at 8 am PST (
   https://zoom.us/j/990892712?pwd=cHU1MjhoM2x6ck81bkcrYjRrcmJsUT09)
   
   -

   Twitch -  See https://www.twitch.tv/theyoctojester


Key Status/Updates:

   -

   YP 4.3.2 passed QA and is in review.
   -

   YP 5.0 M2 is due to build this week
   -

   The inherit_defer work highlighted a bug in EXPORT_FUNCTIONS handling.
   This was fixed but does change behavior in some real world usages of the
   function where the incorrect behavior was being relied upon.
   -

   EXPORT_FUNCTIONS is defined as mapping to those ‘namespaced’ functions
   only if there isn’t a real definition of that function.
   -

   The inherit_defer changes will likely merge into M2.
   -

   There has been at least one serial issue that reappeared with the 6.6
   kernel on the autobuilder unfortunately.
   -

   A bug was fixed in the bitbake –runall option where it wasn’t building
   as much as it should have.
   -

   The recipe reporting system on the layer index is now functional again,
   thanks Tim!


Ways to contribute:

   -

   As people are likely aware, the project has a number of components which
   are either unmaintained, or have people with little to no time trying to
   keep them alive. These components include: devtool, toaster, wic, oeqa,
   autobuilder, CROPs containers, pseudo and more. Many have open bugs. Help
   is welcome in trying to better look after these components!
   -

   There are bugs identified as possible for newcomers to the project:
   https://wiki.yoctoproject.org/wiki/Newcomers
   -

   There are bugs that are currently unassigned for YP 5.0. See:
   
https://wiki.yoctoproject.org/wiki/Bug_Triage#Medium+_5.0_Unassigned_Enhancements/Bugs
   -

   We’d welcome new maintainers for recipes in OE-Core. Please see the list
   at:
   
http://git.yoctoproject.org/cgit.cgi/poky/tree/meta/conf/distro/include/maintainers.inc
   and discuss with the existing maintainer, or ask on the OE-Core mailing
   list. We will likely move a chunk of these to “Unassigned” soon to help
   facilitate this.
   -

   Help is very much welcome in trying to resolve our autobuilder
   intermittent issues. You can see the list of failures we’re continuing to
   see by searching for the “AB-INT” tag in bugzilla:
   https://bugzilla.yoctoproject.org/buglist.cgi?quicksearch=AB-INT.
   -

   Help us resolve CVE issues: CVE metrics
   
   -

   We have a growing number of bugs in bugzilla, any help with them is
   appreciated.
   -

   Regarding bugs, even if you can’t fix a bug, submitting a failing test
   case that can reproduce the issue significantly improves the chances it
   might get fixed.


YP 5.0 Milestone Dates:

   -

   YP 5.0 M2 build date  2024/01/15
   -

   YP 5.0 M2 Release date 2024/01/24
   -

   YP 5.0 M3 build date  2024/02/19
   -

   YP 5.0 M3 Release date 2024/03/01
   -

   YP 5.0 M4 build date  2024/04/01
   -

   YP 5.0 M4 Release date 2024/04/30


Upcoming dot releases:

   -

   YP 4.3.2 is ready for release.
   -

   YP 3.1.31 build date 2024/01/22
   -

   YP 3.1.31 Release date 2024/02/02
   -

   YP 4.0.16 build date 2024/01/29
   -

   YP 4.0.16 Release date 2024/02/09
   -

   YP 4.3.3 build date 2024/02/12
   -

   YP 4.3.3 Release date 2024/02/23
   -

   YP 3.1.32 build date 2024/03/04
   -

   YP 3.1.32 Release date 2024/03/15
   -

   YP 4.0.17 build date 2024/03/11
   -

   YP 4.0.17 Release date 2024/03/22
   -

   YP 4.3.4 build date 2024/03/25
   -

   YP 4.3.4 Release date 2024/04/05
   -

   YP 3.1.33 build date 2024/04/15
   -

   YP 3.1.33 Release date 2024/04/26
   -

   YP 4.0.18 build date 2024/04/22
   -

   YP 4.0.18 Release date 2024/05/03
   -

   YP 4.0.19 build date 2024/06/03
   -

   YP 4.0.19 Release date 2024/06/14


Tracking Metrics:

   -

   WDD 2555 (last week 2562) (
   https://wiki.yoctoproject.org/charts/combo.html)
   -

   OE-Core/Poky Patch Metrics
   -

  Total patches found: 1168 (last week 1171)
  -

  Patches in the Pending State: 251 (21%) [last week 252 (22%)]
  -

   https://autobuilder.yocto.io/pub/non-release/patchmetrics/


The Yocto Project’s technical governance is through its Technical Steering
Committee, more information is available at:

https://wiki.yoctoproject.org/wiki/TSC

The Status reports are now stored on the wiki at:
https://wiki.yoctoproject.org/wiki/Weekly_Status

[If anyone has suggestions for other information you’d like to see on this
weekly status update, let us know!]

Thanks,



*Stephen K. Jolley*

*Yocto Project Program Manager*

(*Cell*:(208) 244-4460

* *Email*: *s
jolley.

[OE-core] how badly do symlinks from within ${S} to outside ${S} mess up sstate?

2024-01-16 Thread Robert P. J. Day

  a very weird question, to be sure, but i literally just ran across a
recipe that does the following (i will paraphrase some stuff to
protect the innocent).

  the recipe processes a bunch of XML source files, and generates from
them JSON files, so any change in any of the XML source files should
(obviously) trigger a rebuild of the recipe. and here's the problem.

  the XML files are not copied into the recipe source directory, and
are not even referenced by SRC_URI. rather, the files live in a
well-known location on the build host (placed there by a monstrous
"repo sync"), and to save time and space, the recipe just *symlinks*
from inside ${S} to the XML source files outside of ${S}, then
proceeds to process them to generate the subsequent JSON files.

  the complaint is that, when the build pipeline started taking
advantage of sstate-cache, even after some of the XML files were
changed, the recipe would not rebuild.

  once i understood what was happening, my immediate reaction was
along the lines, "well, since what is under ${S} is simply symlinks to
files *outside* of ${S} and (worse) those symlink names will never
change (all that will change is the XML files at the other end), how
is bitbake supposed to have any idea that those XML files have
changed to kick off a rebuild?"

  so my initial response was, "this does not surprise me at all," but
does my reasoning hold up? obviously, this should probably use a
combination of bin_package and externalsrc, but as it is now, is it
moderately accurate to suggest that it is those symlinks that are
preventing bitbake from understanding that anything has changed, so
that it continues to use the old sstate-cache?

rday

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#193864): 
https://lists.openembedded.org/g/openembedded-core/message/193864
Mute This Topic: https://lists.openembedded.org/mt/103762271/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core][dunfell][PATCH] dbus: Add patches to clear cache on policy reload

2024-01-16 Thread Steve Sakoman
On Tue, Jan 16, 2024 at 4:07 AM Alexander Kanavin
 wrote:
>
> FWIW to me this looks like an outcome of specific product
> requirements, and not something that would be generally useful in
> dunfell. If these are backported, then why not every other bugfix that
> accumulated in dbus repo over the past 4-ish years?

Thanks for reviewing this, Alex.

I had the same thought, but since I'm not a dbus expert I pinged Chen
Qi just in case I was missing something and this is important.

Steve

> On Tue, 16 Jan 2024 at 14:58, Steve Sakoman  wrote:
> >
> > Adding Chen Qi (dbus maintainer).  Does this look OK to you?
> >
> > Steve
> >
> > On Mon, Jan 15, 2024 at 1:23 AM Poonam Jadhav  wrote:
> > >
> > > See discussion at https://marc.info/?l=selinux&m=152173501930182&w=2
> > > Link: https://gitlab.freedesktop.org/dbus/dbus/-/merge_requests/31
> > >
> > > Support patches added:
> > > 1. "Add-_dbus_clear_loop-and-_dbus_clear_watch.patch"
> > >Where '_dbus_clear_loop' and '_dbus_clear_watch'
> > >functions are available.
> > > 2. "Add-utility-functions-to-emit-TAP-diagnostics-and-fa.patch"
> > >Where 'dbus/dbus-test-tap.h' header file is available
> > >
> > > Patches to resolve issue as provided in above link:
> > > 3. "Stop-using-avc_init-which-is-deprecated.patch"
> > >To stop using avc_init() which is deprecated and use avc_open()
> > >instead.With this commit dbus-daemon will stop using a thread
> > >to monitor the avc netlink and will poll it instead.
> > > 4. "Use-SELINUX_CB_POLICYLOAD-instead-of-AVC_CALLBACK_RE"
> > > Use SELINUX_CB_POLICYLOAD instead of AVC_CALLBACK_RESET callback
> > > as this only seems necessary on policy reload and not if the
> > > enforcing mode is changing.
> > >
> > > Signed-off-by: Ranjitsinh Rathod 
> > > Signed-off-by: Bhabu Bindu 
> > > ---
> > >  meta/recipes-core/dbus/dbus.inc   |   4 +
> > >  ...bus_clear_loop-and-_dbus_clear_watch.patch |  56 +++
> > >  ...tions-to-emit-TAP-diagnostics-and-fa.patch | 192 
> > >  ...p-using-avc_init-which-is-deprecated.patch | 439 ++
> > >  ...OLICYLOAD-instead-of-AVC_CALLBACK_RE.patch |  63 +++
> > >  5 files changed, 754 insertions(+)
> > >  create mode 100644 
> > > meta/recipes-core/dbus/dbus/0001-Add-_dbus_clear_loop-and-_dbus_clear_watch.patch
> > >  create mode 100644 
> > > meta/recipes-core/dbus/dbus/0001-Add-utility-functions-to-emit-TAP-diagnostics-and-fa.patch
> > >  create mode 100644 
> > > meta/recipes-core/dbus/dbus/0001-Stop-using-avc_init-which-is-deprecated.patch
> > >  create mode 100644 
> > > meta/recipes-core/dbus/dbus/0002-Use-SELINUX_CB_POLICYLOAD-instead-of-AVC_CALLBACK_RE.patch
> > >
> > > diff --git a/meta/recipes-core/dbus/dbus.inc 
> > > b/meta/recipes-core/dbus/dbus.inc
> > > index 9b5cc53d92..12be2c0ea6 100644
> > > --- a/meta/recipes-core/dbus/dbus.inc
> > > +++ b/meta/recipes-core/dbus/dbus.inc
> > > @@ -9,6 +9,10 @@ SRC_URI = 
> > > "https://dbus.freedesktop.org/releases/dbus/dbus-${PV}.tar.gz \
> > > file://dbus-1.init \
> > > file://clear-guid_from_server-if-send_negotiate_unix_f.patch \
> > > file://CVE-2023-34969.patch \
> > > +   
> > > file://0001-Add-utility-functions-to-emit-TAP-diagnostics-and-fa.patch \
> > > +   file://0001-Add-_dbus_clear_loop-and-_dbus_clear_watch.patch \
> > > +   file://0001-Stop-using-avc_init-which-is-deprecated.patch \
> > > +   
> > > file://0002-Use-SELINUX_CB_POLICYLOAD-instead-of-AVC_CALLBACK_RE.patch \
> > >  "
> > >
> > >  SRC_URI[sha256sum] = 
> > > "bc42d196c1756ac520d61bf3ccd6f42013617def45dd1e591a6091abf51dca38"
> > > diff --git 
> > > a/meta/recipes-core/dbus/dbus/0001-Add-_dbus_clear_loop-and-_dbus_clear_watch.patch
> > >  
> > > b/meta/recipes-core/dbus/dbus/0001-Add-_dbus_clear_loop-and-_dbus_clear_watch.patch
> > > new file mode 100644
> > > index 00..f684f2a1f9
> > > --- /dev/null
> > > +++ 
> > > b/meta/recipes-core/dbus/dbus/0001-Add-_dbus_clear_loop-and-_dbus_clear_watch.patch
> > > @@ -0,0 +1,56 @@
> > > +From 8a4e07925c54eac83878c39313f44fe87d6c3538 Mon Sep 17 00:00:00 2001
> > > +From: Laurent Bigonville 
> > > +Date: Mon, 5 Mar 2018 22:30:44 +0100
> > > +Subject: [PATCH] Add _dbus_clear_loop and _dbus_clear_watch
> > > +
> > > +Bug: https://bugs.freedesktop.org/show_bug.cgi?id=92831
> > > +[smcv: Fix variable names]
> > > +Reviewed-by: Simon McVittie 
> > > +
> > > +Upstream-Status: Backport 
> > > [https://gitlab.freedesktop.org/dbus/dbus/-/commit/8a4e07925c54eac83878c39313f44fe87d6c3538]
> > > +Signed-off-by: Ranjitsinh Rathod 
> > > +
> > > +---
> > > + dbus/dbus-mainloop.h | 7 +++
> > > + dbus/dbus-watch.h| 7 +++
> > > + 2 files changed, 14 insertions(+)
> > > +
> > > +diff --git a/dbus/dbus-mainloop.h b/dbus/dbus-mainloop.h
> > > +index a76cb6f0..19a7c0d5 100644
> > > +--- a/dbus/dbus-mainloop.h
> > >  b/dbus/dbus-mainloop.h
> > > +@@ -60,6 +60,13 @@ dbus_bool_t _dbus_loop_dispatch   (DB

Re: [OE-core][dunfell][PATCH] dbus: Add patches to clear cache on policy reload

2024-01-16 Thread Alexander Kanavin
FWIW to me this looks like an outcome of specific product
requirements, and not something that would be generally useful in
dunfell. If these are backported, then why not every other bugfix that
accumulated in dbus repo over the past 4-ish years?

Alex

On Tue, 16 Jan 2024 at 14:58, Steve Sakoman  wrote:
>
> Adding Chen Qi (dbus maintainer).  Does this look OK to you?
>
> Steve
>
> On Mon, Jan 15, 2024 at 1:23 AM Poonam Jadhav  wrote:
> >
> > See discussion at https://marc.info/?l=selinux&m=152173501930182&w=2
> > Link: https://gitlab.freedesktop.org/dbus/dbus/-/merge_requests/31
> >
> > Support patches added:
> > 1. "Add-_dbus_clear_loop-and-_dbus_clear_watch.patch"
> >Where '_dbus_clear_loop' and '_dbus_clear_watch'
> >functions are available.
> > 2. "Add-utility-functions-to-emit-TAP-diagnostics-and-fa.patch"
> >Where 'dbus/dbus-test-tap.h' header file is available
> >
> > Patches to resolve issue as provided in above link:
> > 3. "Stop-using-avc_init-which-is-deprecated.patch"
> >To stop using avc_init() which is deprecated and use avc_open()
> >instead.With this commit dbus-daemon will stop using a thread
> >to monitor the avc netlink and will poll it instead.
> > 4. "Use-SELINUX_CB_POLICYLOAD-instead-of-AVC_CALLBACK_RE"
> > Use SELINUX_CB_POLICYLOAD instead of AVC_CALLBACK_RESET callback
> > as this only seems necessary on policy reload and not if the
> > enforcing mode is changing.
> >
> > Signed-off-by: Ranjitsinh Rathod 
> > Signed-off-by: Bhabu Bindu 
> > ---
> >  meta/recipes-core/dbus/dbus.inc   |   4 +
> >  ...bus_clear_loop-and-_dbus_clear_watch.patch |  56 +++
> >  ...tions-to-emit-TAP-diagnostics-and-fa.patch | 192 
> >  ...p-using-avc_init-which-is-deprecated.patch | 439 ++
> >  ...OLICYLOAD-instead-of-AVC_CALLBACK_RE.patch |  63 +++
> >  5 files changed, 754 insertions(+)
> >  create mode 100644 
> > meta/recipes-core/dbus/dbus/0001-Add-_dbus_clear_loop-and-_dbus_clear_watch.patch
> >  create mode 100644 
> > meta/recipes-core/dbus/dbus/0001-Add-utility-functions-to-emit-TAP-diagnostics-and-fa.patch
> >  create mode 100644 
> > meta/recipes-core/dbus/dbus/0001-Stop-using-avc_init-which-is-deprecated.patch
> >  create mode 100644 
> > meta/recipes-core/dbus/dbus/0002-Use-SELINUX_CB_POLICYLOAD-instead-of-AVC_CALLBACK_RE.patch
> >
> > diff --git a/meta/recipes-core/dbus/dbus.inc 
> > b/meta/recipes-core/dbus/dbus.inc
> > index 9b5cc53d92..12be2c0ea6 100644
> > --- a/meta/recipes-core/dbus/dbus.inc
> > +++ b/meta/recipes-core/dbus/dbus.inc
> > @@ -9,6 +9,10 @@ SRC_URI = 
> > "https://dbus.freedesktop.org/releases/dbus/dbus-${PV}.tar.gz \
> > file://dbus-1.init \
> > file://clear-guid_from_server-if-send_negotiate_unix_f.patch \
> > file://CVE-2023-34969.patch \
> > +   
> > file://0001-Add-utility-functions-to-emit-TAP-diagnostics-and-fa.patch \
> > +   file://0001-Add-_dbus_clear_loop-and-_dbus_clear_watch.patch \
> > +   file://0001-Stop-using-avc_init-which-is-deprecated.patch \
> > +   
> > file://0002-Use-SELINUX_CB_POLICYLOAD-instead-of-AVC_CALLBACK_RE.patch \
> >  "
> >
> >  SRC_URI[sha256sum] = 
> > "bc42d196c1756ac520d61bf3ccd6f42013617def45dd1e591a6091abf51dca38"
> > diff --git 
> > a/meta/recipes-core/dbus/dbus/0001-Add-_dbus_clear_loop-and-_dbus_clear_watch.patch
> >  
> > b/meta/recipes-core/dbus/dbus/0001-Add-_dbus_clear_loop-and-_dbus_clear_watch.patch
> > new file mode 100644
> > index 00..f684f2a1f9
> > --- /dev/null
> > +++ 
> > b/meta/recipes-core/dbus/dbus/0001-Add-_dbus_clear_loop-and-_dbus_clear_watch.patch
> > @@ -0,0 +1,56 @@
> > +From 8a4e07925c54eac83878c39313f44fe87d6c3538 Mon Sep 17 00:00:00 2001
> > +From: Laurent Bigonville 
> > +Date: Mon, 5 Mar 2018 22:30:44 +0100
> > +Subject: [PATCH] Add _dbus_clear_loop and _dbus_clear_watch
> > +
> > +Bug: https://bugs.freedesktop.org/show_bug.cgi?id=92831
> > +[smcv: Fix variable names]
> > +Reviewed-by: Simon McVittie 
> > +
> > +Upstream-Status: Backport 
> > [https://gitlab.freedesktop.org/dbus/dbus/-/commit/8a4e07925c54eac83878c39313f44fe87d6c3538]
> > +Signed-off-by: Ranjitsinh Rathod 
> > +
> > +---
> > + dbus/dbus-mainloop.h | 7 +++
> > + dbus/dbus-watch.h| 7 +++
> > + 2 files changed, 14 insertions(+)
> > +
> > +diff --git a/dbus/dbus-mainloop.h b/dbus/dbus-mainloop.h
> > +index a76cb6f0..19a7c0d5 100644
> > +--- a/dbus/dbus-mainloop.h
> >  b/dbus/dbus-mainloop.h
> > +@@ -60,6 +60,13 @@ dbus_bool_t _dbus_loop_dispatch   (DBusLoop 
> >*loop);
> > + int  _dbus_get_oom_wait(void);
> > + void _dbus_wait_for_memory (void);
> > +
> > ++static inline void
> > ++_dbus_clear_loop (DBusLoop **pointer_to_loop)
> > ++{
> > ++  _dbus_clear_pointer_impl (DBusLoop, pointer_to_loop,
> > ++_dbus_loop_unref);
> > ++}
> > ++
> > + #endif /* !DOXYGEN_SHOULD_SKIP_THIS */
> > +
> > + #endif /* DBUS_MAINLOOP_H */
> > +diff --git 

Re: [OE-core][dunfell][PATCH] dbus: Add patches to clear cache on policy reload

2024-01-16 Thread Steve Sakoman
Adding Chen Qi (dbus maintainer).  Does this look OK to you?

Steve

On Mon, Jan 15, 2024 at 1:23 AM Poonam Jadhav  wrote:
>
> See discussion at https://marc.info/?l=selinux&m=152173501930182&w=2
> Link: https://gitlab.freedesktop.org/dbus/dbus/-/merge_requests/31
>
> Support patches added:
> 1. "Add-_dbus_clear_loop-and-_dbus_clear_watch.patch"
>Where '_dbus_clear_loop' and '_dbus_clear_watch'
>functions are available.
> 2. "Add-utility-functions-to-emit-TAP-diagnostics-and-fa.patch"
>Where 'dbus/dbus-test-tap.h' header file is available
>
> Patches to resolve issue as provided in above link:
> 3. "Stop-using-avc_init-which-is-deprecated.patch"
>To stop using avc_init() which is deprecated and use avc_open()
>instead.With this commit dbus-daemon will stop using a thread
>to monitor the avc netlink and will poll it instead.
> 4. "Use-SELINUX_CB_POLICYLOAD-instead-of-AVC_CALLBACK_RE"
> Use SELINUX_CB_POLICYLOAD instead of AVC_CALLBACK_RESET callback
> as this only seems necessary on policy reload and not if the
> enforcing mode is changing.
>
> Signed-off-by: Ranjitsinh Rathod 
> Signed-off-by: Bhabu Bindu 
> ---
>  meta/recipes-core/dbus/dbus.inc   |   4 +
>  ...bus_clear_loop-and-_dbus_clear_watch.patch |  56 +++
>  ...tions-to-emit-TAP-diagnostics-and-fa.patch | 192 
>  ...p-using-avc_init-which-is-deprecated.patch | 439 ++
>  ...OLICYLOAD-instead-of-AVC_CALLBACK_RE.patch |  63 +++
>  5 files changed, 754 insertions(+)
>  create mode 100644 
> meta/recipes-core/dbus/dbus/0001-Add-_dbus_clear_loop-and-_dbus_clear_watch.patch
>  create mode 100644 
> meta/recipes-core/dbus/dbus/0001-Add-utility-functions-to-emit-TAP-diagnostics-and-fa.patch
>  create mode 100644 
> meta/recipes-core/dbus/dbus/0001-Stop-using-avc_init-which-is-deprecated.patch
>  create mode 100644 
> meta/recipes-core/dbus/dbus/0002-Use-SELINUX_CB_POLICYLOAD-instead-of-AVC_CALLBACK_RE.patch
>
> diff --git a/meta/recipes-core/dbus/dbus.inc b/meta/recipes-core/dbus/dbus.inc
> index 9b5cc53d92..12be2c0ea6 100644
> --- a/meta/recipes-core/dbus/dbus.inc
> +++ b/meta/recipes-core/dbus/dbus.inc
> @@ -9,6 +9,10 @@ SRC_URI = 
> "https://dbus.freedesktop.org/releases/dbus/dbus-${PV}.tar.gz \
> file://dbus-1.init \
> file://clear-guid_from_server-if-send_negotiate_unix_f.patch \
> file://CVE-2023-34969.patch \
> +   
> file://0001-Add-utility-functions-to-emit-TAP-diagnostics-and-fa.patch \
> +   file://0001-Add-_dbus_clear_loop-and-_dbus_clear_watch.patch \
> +   file://0001-Stop-using-avc_init-which-is-deprecated.patch \
> +   
> file://0002-Use-SELINUX_CB_POLICYLOAD-instead-of-AVC_CALLBACK_RE.patch \
>  "
>
>  SRC_URI[sha256sum] = 
> "bc42d196c1756ac520d61bf3ccd6f42013617def45dd1e591a6091abf51dca38"
> diff --git 
> a/meta/recipes-core/dbus/dbus/0001-Add-_dbus_clear_loop-and-_dbus_clear_watch.patch
>  
> b/meta/recipes-core/dbus/dbus/0001-Add-_dbus_clear_loop-and-_dbus_clear_watch.patch
> new file mode 100644
> index 00..f684f2a1f9
> --- /dev/null
> +++ 
> b/meta/recipes-core/dbus/dbus/0001-Add-_dbus_clear_loop-and-_dbus_clear_watch.patch
> @@ -0,0 +1,56 @@
> +From 8a4e07925c54eac83878c39313f44fe87d6c3538 Mon Sep 17 00:00:00 2001
> +From: Laurent Bigonville 
> +Date: Mon, 5 Mar 2018 22:30:44 +0100
> +Subject: [PATCH] Add _dbus_clear_loop and _dbus_clear_watch
> +
> +Bug: https://bugs.freedesktop.org/show_bug.cgi?id=92831
> +[smcv: Fix variable names]
> +Reviewed-by: Simon McVittie 
> +
> +Upstream-Status: Backport 
> [https://gitlab.freedesktop.org/dbus/dbus/-/commit/8a4e07925c54eac83878c39313f44fe87d6c3538]
> +Signed-off-by: Ranjitsinh Rathod 
> +
> +---
> + dbus/dbus-mainloop.h | 7 +++
> + dbus/dbus-watch.h| 7 +++
> + 2 files changed, 14 insertions(+)
> +
> +diff --git a/dbus/dbus-mainloop.h b/dbus/dbus-mainloop.h
> +index a76cb6f0..19a7c0d5 100644
> +--- a/dbus/dbus-mainloop.h
>  b/dbus/dbus-mainloop.h
> +@@ -60,6 +60,13 @@ dbus_bool_t _dbus_loop_dispatch   (DBusLoop   
>  *loop);
> + int  _dbus_get_oom_wait(void);
> + void _dbus_wait_for_memory (void);
> +
> ++static inline void
> ++_dbus_clear_loop (DBusLoop **pointer_to_loop)
> ++{
> ++  _dbus_clear_pointer_impl (DBusLoop, pointer_to_loop,
> ++_dbus_loop_unref);
> ++}
> ++
> + #endif /* !DOXYGEN_SHOULD_SKIP_THIS */
> +
> + #endif /* DBUS_MAINLOOP_H */
> +diff --git a/dbus/dbus-watch.h b/dbus/dbus-watch.h
> +index 8d8bbf2b..05d9b20e 100644
> +--- a/dbus/dbus-watch.h
>  b/dbus/dbus-watch.h
> +@@ -99,6 +99,13 @@ DBusSocket _dbus_watch_get_socket (DBusWatch  
>  *watch);
> + DBUS_PRIVATE_EXPORT
> + DBusPollable   _dbus_watch_get_pollable   (DBusWatch   
> *watch);
> +
> ++static inline void
> ++_dbus_clear_watch (DBusWatch **pointer_to_watch)
> ++{
> ++  _dbus_clear_pointer_impl (DBusWatch, pointer_to_watch,
> ++_dbus_wat

Re: [OE-core] [PATCH 1/3] recipetool: Don't fail on local go modules

2024-01-16 Thread Richard Purdie
On Tue, 2024-01-16 at 09:33 +0100, Vyacheslav Yurkov wrote:
> On 10.01.2024 16:45, Lukas Funke wrote:
> > On 10.01.2024 14:59, Richard Purdie wrote:
> > > On Wed, 2024-01-10 at 12:53 +0100, Vyacheslav Yurkov wrote:
> > > > Local modules are usually referenced with a 'replace' directive in
> > > > go.mod file. If that's the case, remove them from populating SRC_URI.
> > > > 
> > > > Signed-off-by: Vyacheslav Yurkov 
> > > > ---
> > > >   scripts/lib/recipetool/create_go.py | 32 
> > > > +
> > > >   1 file changed, 19 insertions(+), 13 deletions(-)
> > > 
> > > Do these changes mean we need to improve the test coverage in oe-
> > > selftest for recipetool?
> > 
> > Test converage needs improvement, yes. I haven't considered the case 
> > for local modules since this seems to be rare(?). Are there public 
> > projects which use this mechanism?
> > 
> > Best regards
> > Lukas
> > 
> 
> I added coverage for local modules in my v2.
> 
> I'm not a golang expert, but it seems that local modules in golang is a 
> means to "place a patched version into the project space until upstream 
> fixes it" more or less like Yocto does with Upstream patches. It's used 
> a lot by in-house projects, but you could also get a glimpse on github 
> with this query 
> https://github.com/search?q=path%3A%2Fgo.mod+NOT+is%3Afork+content%3A%2F%5Ereplace+.*%2F&type=code&query=content%3Ago.mod+replace&p=3
>  
> . Note, Github is able to display only first 100 search results (Github 
> API restriction).
> 
> One thing I don't like in my v2 is that I need to look up a public 
> project to add required coverage. I would rather improve tests further 
> by having everything in one repository and just one test, i.e. it has to 
> be a small test project that could be used to test all go-related 
> functionality. The question is though where it should be placed? I could 
> create it on my Github account, but would that be a good option?
> 
> Richard, any suggestions on where these projects for selftest coverage 
> should be hosted?

Thanks for the tests, they are massively helpful in maintaining this
code.

We could always add something to git.yoctoproject.org, we do have a few
test repositories there already for various purposes like this.

If you want to do that, please send an email to
helpd...@yoctoproject.org with an ssh key (or I think a pointer to your
github account), requesting setup for the repo and a brief description
of what it is for.

Cheers,

Richard


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#193860): 
https://lists.openembedded.org/g/openembedded-core/message/193860
Mute This Topic: https://lists.openembedded.org/mt/103639058/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH] uboot-sign: support to load optee-os and TFA images

2024-01-16 Thread Jörg Sommer via lists . openembedded . org
On 15.01.24 08:54, Jamin Lin via lists.openembedded.org wrote:
> Currently, u-boot FIT image only support to load u-boot image.
> To support optee-os and trusted-firmware-a, update ITS file generation
> scripts, so users are able to use u-boot FIT image to load
> u-boot, optee-os and treustred-firmware-a images
> 
> Add a variable "UBOOT_FIT_ARM_TRUSTED_FIRMWARE_A" to
> enable trusted-firmware-a image and it is disable by default.
> 
> Add a variable "UBOOT_FIT_OPTEE_OS" to enable optee-os image
> and it is disable by default.
> 
> The ITS file creation loos like as following.


Is here a K missing?


Kind regards

Jörg Sommer
-- 
Navimatix GmbH
Tatzendpromenade 2
D-07745 Jena
Geschäftsführer: Steffen Späthe, Jan Rommeley
Registergericht: Amtsgericht Jena, HRB 501480


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#193859): 
https://lists.openembedded.org/g/openembedded-core/message/193859
Mute This Topic: https://lists.openembedded.org/mt/103734859/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH v2 2/3] insane.bbclass: Make check_32bit_symbols check for file functions too

2024-01-16 Thread Ola x Nilsson

Seems I have my work cut out for me.  Thanks for the feedback.

/Ola

On Mon, Jan 15 2024, Alexander Kanavin wrote:

> I guess the patch needs to be adjusted to suppress the warnings from here?
> https://git.yoctoproject.org/poky/tree/meta/conf/distro/include/time64.inc
> Any suppressions should come with upstream ticket links.
>
> Better yet, make patches to address the issues. Seems like there's not
> a lot of them.
>
> Alex
>
> On Mon, 15 Jan 2024 at 17:55, Alexandre Belloni via
> lists.openembedded.org
>  wrote:
>>
>> This causes a bunch of warnings on the autobuilders:
>>
>> https://autobuilder.yoctoproject.org/typhoon/#/builders/52/builds/8306/steps/12/logs/warnings
>> https://autobuilder.yoctoproject.org/typhoon/#/builders/108/builds/5587/steps/11/logs/warnings
>>
>> stdio: WARNING: lib32-openssh-9.5p1-r0 do_package_qa: QA Issue: 
>> /usr/bin/ssh-keyscan uses 32-bit api 'mkstemp'
>> stdio: WARNING: lib32-python3-numpy-1.26.2-r0 do_package_qa: QA Issue: 
>> /usr/lib/python3.11/site-packages/numpy/core/_multiarray_umath.cpython-311-i386-linux-gnu.so
>>  uses 32-bit api 'fallocate'
>>
>> https://autobuilder.yoctoproject.org/typhoon/#/builders/65/builds/8499/steps/12/logs/warnings
>> https://autobuilder.yoctoproject.org/typhoon/#/builders/102/builds/5675/steps/12/logs/warnings
>> https://autobuilder.yoctoproject.org/typhoon/#/builders/63/builds/8382/steps/12/logs/warnings
>> https://autobuilder.yoctoproject.org/typhoon/#/builders/59/builds/8363/steps/13/logs/warnings
>> https://autobuilder.yoctoproject.org/typhoon/#/builders/110/builds/7305/steps/12/logs/warnings
>> https://autobuilder.yoctoproject.org/typhoon/#/builders/160/builds/295/steps/12/logs/warnings
>>
>> stdio: WARNING: openssh-9.5p1-r0 do_package_qa: QA Issue: /usr/sbin/sshd 
>> uses 32-bit api 'mkstemp'
>>
>> https://autobuilder.yoctoproject.org/typhoon/#/builders/106/builds/7404/steps/12/logs/warnings
>> https://autobuilder.yoctoproject.org/typhoon/#/builders/103/builds/7327/steps/12/logs/warnings
>> https://autobuilder.yoctoproject.org/typhoon/#/builders/107/builds/5743/steps/13/logs/warnings
>> https://autobuilder.yoctoproject.org/typhoon/#/builders/101/builds/7174/steps/13/logs/warnings
>> https://autobuilder.yoctoproject.org/typhoon/#/builders/128/builds/2749/steps/21/logs/warnings
>> https://autobuilder.yoctoproject.org/typhoon/#/builders/60/builds/8386/steps/13/logs/warnings
>>
>> stdio: WARNING: openssh-9.5p1-r0 do_package_qa: QA Issue: 
>> /usr/bin/ssh-keyscan uses 32-bit api 'mkstemp'
>>
>> https://autobuilder.yoctoproject.org/typhoon/#/builders/53/builds/8436/steps/12/logs/warnings
>>
>> stdio: WARNING: openssh-9.5p1-r0 do_package_qa: QA Issue: 
>> /usr/lib/openssh/ptest/regress/unittests/hostkeys/test_hostkeys uses 32-bit 
>> api 'mkstemp'
>>
>>
>> On 12/01/2024 16:14:02+0100, Ola x Nilsson wrote:
>> > Since _TIME_BITS=64 forces the use of _FILE_OFFSET_BITS=64, also check
>> > for functions redirected only based on _FILE_OFFSET_BITS and
>> > __USE_FILE_OFFSET64.
>> >
>> > Signed-off-by: Ola x Nilsson 
>> > ---
>> >  meta/classes-global/insane.bbclass | 31 ++
>> >  1 file changed, 31 insertions(+)
>> >
>> > diff --git a/meta/classes-global/insane.bbclass 
>> > b/meta/classes-global/insane.bbclass
>> > index 69741a6a79..1ff6a319c4 100644
>> > --- a/meta/classes-global/insane.bbclass
>> > +++ b/meta/classes-global/insane.bbclass
>> > @@ -598,6 +598,37 @@ def check_32bit_symbols(path, packagename, d, elf, 
>> > messages):
>> >  "fts_set",
>> >  # /usr/include/netdb.h
>> >  "gai_suspend",
>> > +
>> > +# Since _TIME_BITS=64 forces the use of _FILE_OFFSET_BITS=64,
>> > +# also check for functions redirected only based on 
>> > _FILE_OFFSET_BITS
>> > +# and __USE_FILE_OFFSET64
>> > +# /usr/include/bits/fcntl-linux.h
>> > +"fallocate",
>> > +# /usr/include/bits/resource.h
>> > +"prlimit",
>> > +# /usr/include/sys/statfs.h
>> > +"statfs", "fstatfs", "statvfs", "fstatvfs",
>> > +# /usr/include/sys/sendfile.h
>> > +"sendfile",
>> > +# /usr/include/sys/resource.h
>> > +"getrlimit", "setrlimit",
>> > +# /usr/include/sys/uio.h
>> > +"preadv", "pwritev", "preadv2", "pwritev2",
>> > +# /usr/include/sys/mman.h
>> > +"mmap",
>> > +# /usr/include/stdlib.h
>> > +"mkstemp", "mkstemps", "mkostemp", "mkostemps",
>> > +# /usr/include/stdio.h
>> > +"fopen", "tmpfile", "freopen", "fseeko", "ftello", "fgetpos",
>> > +"fsetpos",
>> > +# /usr/include/dirent.h
>> > +"readdir",
>> > +"readdir_r", "scandir", "scandirat", "alphasort", "getdirentries",
>> > +"versionsort",
>> > +# /usr/include/unistd.h
>> > +"lseek", "pread", "pwrite", "truncate", "ftruncate", "lockf",
>> > +# /usr/include/fcntl.h
>> > +"open", "openat", "creat", "posix_fadvise", "posix_fallocate",
>> >  }

Re: [OE-core] [RFC v3 1/2] bitbake-layers: Add ability to update the reference of repositories

2024-01-16 Thread Alexander Kanavin
On Tue, 16 Jan 2024 at 12:02, Jermain Horsman  wrote:
> I did implement a new version, it is available on the mailing list,
> it should include all other feedback as well.

Thanks for persevering; the last version is good, so please re-submit
it without the RFC.

Once it lands we can think of further tweaks, but I think this would
cover the majority of situations where people want custom or floating
references for some of the repos.

Alex

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#193857): 
https://lists.openembedded.org/g/openembedded-core/message/193857
Mute This Topic: https://lists.openembedded.org/mt/103598114/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH v2 3/3] python: update 3.11.5 -> 3.12.1

2024-01-16 Thread Alexander Kanavin
Drop distutils and smtpd modules from packaging, as both are gone in 3.12.

Rebase:
0020-configure.ac-setup.py-do-not-add-a-curses-include-pa.patch
(drop setup.py chunk as the file is gone)

Drop patches:
0001-Do-not-add-usr-lib-termcap-to-linker-flags-to-avoid-.patch
(setup.py gone, lib/termcap not mentioned anywhere else)

0001-Don-t-search-system-for-headers-libraries.patch
(setup.py gone, usr/lib64 not mentioned anywhere else)

0001-Makefile-do-not-compile-.pyc-in-parallel.patch
(replaced with COMPILEALL_OPTS= in EXTRA_OEMAKE)

0001-setup.py-Do-not-detect-multiarch-paths-when-cross-co.patch
(setup.py gone, add_multiarch_paths not mentioned anywhere else)

0017-setup.py-do-not-report-missing-dependencies-for-disa.patch
(has been superseded by Setup.local tweak in do_configure:prepend)

12-distutils-prefix-is-inside-staging-area.patch
(distutils has been removed upstream, so this old, unplesant hack can be 
finally dropped)

avoid_warning_about_tkinter.patch
(setup.py gone, tkinter detection logic performed in configure.ac)

Signed-off-by: Alexander Kanavin 
---
 meta/classes-recipe/python3-dir.bbclass   |   2 +-
 ...shebang-overflow-on-python-config.py.patch |   8 +-
 ...ib-termcap-to-linker-flags-to-avoid-.patch |  25 -
 ...-search-system-for-headers-libraries.patch |  27 -
 ...e-stdin-I-O-errors-same-way-as-maste.patch |   6 +-
 ...-use-prefix-value-from-build-configu.patch |  30 +++---
 ...file-do-not-compile-.pyc-in-parallel.patch |  65 
 ...-qemu-wrapper-when-gathering-profile.patch |  16 +--
 ...sts-due-to-load-variability-on-YP-AB.patch |  24 ++---
 ...est_sysconfig-for-posix_user-purelib.patch |  10 +-
 ...asename-to-replace-CC-for-checking-c.patch |  44 
 ...detect-multiarch-paths-when-cross-co.patch |  42 
 ..._fileno-test-due-to-load-variability.patch |  10 +-
 ...g.py-use-platlibdir-also-for-purelib.patch |   6 +-
 ...pes.test_find-skip-without-tools-sdk.patch |  10 +-
 ...le.py-correct-the-test-output-format.patch |   6 +-
 ...orlines-skip-due-to-load-variability.patch |  10 +-
 ...report-missing-dependencies-for-disa.patch |  38 ---
 ...up.py-do-not-add-a-curses-include-pa.patch |  37 ++-
 ...tutils-prefix-is-inside-staging-area.patch |  58 --
 .../python3/avoid_warning_about_tkinter.patch |  30 --
 .../python/python3/cgi_py.patch   |   4 +-
 .../python/python3/crosspythonpath.patch  |   6 +-
 .../python3/deterministic_imports.patch   |  18 +++-
 .../python/python3/makerace.patch |  10 +-
 .../python/python3/python3-manifest.json  | 100 +++---
 .../{python3_3.11.5.bb => python3_3.12.1.bb}  |  27 +++--
 27 files changed, 154 insertions(+), 515 deletions(-)
 delete mode 100644 
meta/recipes-devtools/python/python3/0001-Do-not-add-usr-lib-termcap-to-linker-flags-to-avoid-.patch
 delete mode 100644 
meta/recipes-devtools/python/python3/0001-Don-t-search-system-for-headers-libraries.patch
 delete mode 100644 
meta/recipes-devtools/python/python3/0001-Makefile-do-not-compile-.pyc-in-parallel.patch
 delete mode 100644 
meta/recipes-devtools/python/python3/0001-setup.py-Do-not-detect-multiarch-paths-when-cross-co.patch
 delete mode 100644 
meta/recipes-devtools/python/python3/0017-setup.py-do-not-report-missing-dependencies-for-disa.patch
 delete mode 100644 
meta/recipes-devtools/python/python3/12-distutils-prefix-is-inside-staging-area.patch
 delete mode 100644 
meta/recipes-devtools/python/python3/avoid_warning_about_tkinter.patch
 rename meta/recipes-devtools/python/{python3_3.11.5.bb => python3_3.12.1.bb} 
(96%)

diff --git a/meta/classes-recipe/python3-dir.bbclass 
b/meta/classes-recipe/python3-dir.bbclass
index d93d337f76c..3d07de99b88 100644
--- a/meta/classes-recipe/python3-dir.bbclass
+++ b/meta/classes-recipe/python3-dir.bbclass
@@ -4,7 +4,7 @@
 # SPDX-License-Identifier: MIT
 #
 
-PYTHON_BASEVERSION = "3.11"
+PYTHON_BASEVERSION = "3.12"
 PYTHON_ABI = ""
 PYTHON_DIR = "python${PYTHON_BASEVERSION}"
 PYTHON_PN = "python3"
diff --git 
a/meta/recipes-devtools/python/python3/0001-Avoid-shebang-overflow-on-python-config.py.patch
 
b/meta/recipes-devtools/python/python3/0001-Avoid-shebang-overflow-on-python-config.py.patch
index db084350045..03ecda98c2c 100644
--- 
a/meta/recipes-devtools/python/python3/0001-Avoid-shebang-overflow-on-python-config.py.patch
+++ 
b/meta/recipes-devtools/python/python3/0001-Avoid-shebang-overflow-on-python-config.py.patch
@@ -1,4 +1,4 @@
-From 78f482b91d94b44a02e02c4580166757119061ea Mon Sep 17 00:00:00 2001
+From 33bf96f31c4873032ace2cc9afacc3785997527a Mon Sep 17 00:00:00 2001
 From: Paulo Neves 
 Date: Tue, 7 Jun 2022 16:16:41 +0200
 Subject: [PATCH] Avoid shebang overflow on python-config.py
@@ -17,13 +17,13 @@ Upstream-Status: Denied [distribution]
  1 file changed, 2 insertions(+)
 
 diff --git a/Makefile.pre.in b/Makefile.pre.in
-index 55c7c46..1f6500a 100644
+index fb0b525..75d2e73 100644
 --- a/Makefile.pre.in
 +++ b/Makefile.pre.in
-@@ -2115,6 +21

[OE-core] [PATCH v2 1/3] glib-2.0: ensure GI_DATA_ENABLED is set

2024-01-16 Thread Alexander Kanavin
With python 3.12 some of the glib ptests started failing. Inspection
revealed that they fail because all tests in some glib's test suites are 
skipped;
python 3.12's unittest module deems "no tests in a test suite were executed"
a failure (and I tend to agree).

Why are all the tests skipped? Because python dbus module is missing from
the image, and it's missing because it's pulled in by dbusmock, which
in turn is missing because it is pulled in by glib recipe subject to
GI_DATA_ENABLED, and that variable is not global but defined in a g-i-data
class that glib recipe did not include.

So needed dependencies were simply always excluded regardless of g-i settings,
until now.

Signed-off-by: Alexander Kanavin 
---
v2: include g-i-data class instead of depending on python3-dbusmock
unconditionally; that didn't actually work
---
 meta/recipes-core/glib-2.0/glib.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-core/glib-2.0/glib.inc 
b/meta/recipes-core/glib-2.0/glib.inc
index ae6fc519922..5a57549d855 100644
--- a/meta/recipes-core/glib-2.0/glib.inc
+++ b/meta/recipes-core/glib-2.0/glib.inc
@@ -28,7 +28,7 @@ PACKAGES += "${PN}-codegen ${PN}-utils"
 
 LEAD_SONAME = "libglib-2.0.*"
 
-inherit meson gettext gtk-doc pkgconfig ptest-gnome upstream-version-is-even 
bash-completion gio-module-cache manpages
+inherit meson gettext gtk-doc pkgconfig ptest-gnome upstream-version-is-even 
bash-completion gio-module-cache manpages gobject-introspection-data
 
 GTKDOC_MESON_OPTION = "gtk_doc"
 
-- 
2.39.2


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#193854): 
https://lists.openembedded.org/g/openembedded-core/message/193854
Mute This Topic: https://lists.openembedded.org/mt/103759567/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH v2 2/3] gobject-introspection-data.bbclass: move do_compile() tweak to g-i class

2024-01-16 Thread Alexander Kanavin
g-i-data class is strictly for setting GI_DATA_ENABLED. Any build tweaks
should be in g-i class.

Signed-off-by: Alexander Kanavin 
---
 meta/classes-recipe/gobject-introspection-data.bbclass | 5 -
 meta/classes-recipe/gobject-introspection.bbclass  | 5 +
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/meta/classes-recipe/gobject-introspection-data.bbclass 
b/meta/classes-recipe/gobject-introspection-data.bbclass
index 7f522a1ed32..aa04c70ca6c 100644
--- a/meta/classes-recipe/gobject-introspection-data.bbclass
+++ b/meta/classes-recipe/gobject-introspection-data.bbclass
@@ -11,8 +11,3 @@
 # so that qemu use can be avoided when necessary.
 GI_DATA_ENABLED ?= "${@bb.utils.contains('DISTRO_FEATURES', 
'gobject-introspection-data', \
   bb.utils.contains('MACHINE_FEATURES', 'qemu-usermode', 
'True', 'False', d), 'False', d)}"
-
-do_compile:prepend() {
-# This prevents g-ir-scanner from writing cache data to $HOME
-export GI_SCANNER_DISABLE_CACHE=1
-}
diff --git a/meta/classes-recipe/gobject-introspection.bbclass 
b/meta/classes-recipe/gobject-introspection.bbclass
index 65c67ddc721..d0052cd6231 100644
--- a/meta/classes-recipe/gobject-introspection.bbclass
+++ b/meta/classes-recipe/gobject-introspection.bbclass
@@ -50,6 +50,11 @@ do_configure:prepend:class-target () {
 cp ${STAGING_DIR_NATIVE}/${datadir}/aclocal/introspection.m4 ${S}/m4
 }
 
+do_compile:prepend() {
+# This prevents g-ir-scanner from writing cache data to $HOME
+export GI_SCANNER_DISABLE_CACHE=1
+}
+
 # .typelib files are needed at runtime and so they go to the main package (so
 # they'll be together with libraries they support).
 FILES:${PN}:append = " ${libdir}/girepository-*/*.typelib" 
-- 
2.39.2


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#193855): 
https://lists.openembedded.org/g/openembedded-core/message/193855
Mute This Topic: https://lists.openembedded.org/mt/103759568/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [RFC v3 1/2] bitbake-layers: Add ability to update the reference of repositories

2024-01-16 Thread Jermain Horsman
> Is comma (,) as a separator okay? Maybe : is better?

In my opinion a comma suggest a list, whereas a semicolon
suggests a relation, so I've opted to use ':'.

I did implement a new version, it is available on the mailing list,
it should include all other feedback as well.

Sincerely,

Jermain Horsman

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#193853): 
https://lists.openembedded.org/g/openembedded-core/message/193853
Mute This Topic: https://lists.openembedded.org/mt/103598114/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [RFC v4 1/2] bitbake-layers: Add ability to update the reference of repositories

2024-01-16 Thread Jermain Horsman
From: Jermain Horsman 

This uses an existing setup-layers configuration and modifies one
or more repositories using a reference provided by the user.

This is a very minimal implementation, no validation of this reference
is done and it is left to the user to provide a valid value.

Signed-off-by: Jermain Horsman 
---
 .../bblayers/setupwriters/oe-setup-layers.py  | 79 +--
 1 file changed, 72 insertions(+), 7 deletions(-)

diff --git a/meta/lib/bblayers/setupwriters/oe-setup-layers.py 
b/meta/lib/bblayers/setupwriters/oe-setup-layers.py
index bd71ca1f51..59ca968ff3 100644
--- a/meta/lib/bblayers/setupwriters/oe-setup-layers.py
+++ b/meta/lib/bblayers/setupwriters/oe-setup-layers.py
@@ -31,16 +31,69 @@ class OeSetupLayersWriter():
 with open(output, 'w') as f:
 json.dump(repos, f, sort_keys=True, indent=4)
 
+def _read_repo_config(self, json_path):
+with open(json_path) as f:
+json_config = json.load(f)
+
+supported_versions = ["1.0"]
+if json_config["version"] not in supported_versions:
+err = "File {} has version {}, which is not in supported versions: 
{}".format(json_path, json_config["version"], supported_versions)
+logger.error(err)
+raise Exception(err)
+
+return json_config
+
+def _modify_repo_config(self, json_config, args):
+sources = json_config['sources']
+for pair in args.custom_references:
+try:
+repo, rev = pair.split(':', maxsplit=1)
+except ValueError:
+err = "Invalid custom reference specified: '{}'. Provide one 
using 'REPOSITORY:REFERENCE'.".format(pair)
+logger.error(err)
+raise Exception(err)
+if not repo in sources.keys():
+err = "Repository {} does not exist in setup-layers 
config".format(repo)
+logger.error(err)
+raise Exception(err)
+
+layer_remote = json_config['sources'][repo]['git-remote']
+layer_remote['rev'] = rev
+# Clear describe
+layer_remote['describe'] = ''
+
 def do_write(self, parent, args):
 """ Writes out a python script and a json config that replicate the 
directory structure and revisions of the layers in a current build. """
-if not os.path.exists(args.destdir):
-os.makedirs(args.destdir)
-repos = parent.make_repo_config(args.destdir)
-json = {"version":"1.0","sources":repos}
-if not repos:
-raise Exception("Could not determine layer sources")
 output = args.output_prefix or "setup-layers"
-output = os.path.join(os.path.abspath(args.destdir),output)
+output = os.path.join(os.path.abspath(args.destdir), output)
+
+if args.update:
+# Modify existing layers setup
+if args.custom_references is None:
+err = "No custom reference specified. Please provide one using 
'--use-custom-reference REPOSITORY:REFERENCE'."
+logger.error(err)
+raise Exception(err)
+
+json = self._read_repo_config(output + ".json")
+if not 'sources' in json.keys():
+err = "File {}.json does not contain valid layer 
sources.".format(output)
+logger.error(err)
+raise Exception(err)
+
+else:
+# Create new layers setup
+if not os.path.exists(args.destdir):
+os.makedirs(args.destdir)
+repos = parent.make_repo_config(args.destdir)
+json = {"version":"1.0","sources":repos}
+if not repos:
+err = "Could not determine layer sources"
+logger.error(err)
+raise Exception(err)
+
+if args.custom_references is not None:
+self._modify_repo_config(json, args)
+
 self._write_json(json, output + ".json")
 logger.info('Created {}.json'.format(output))
 if not args.json_only:
@@ -50,3 +103,15 @@ class OeSetupLayersWriter():
 def register_arguments(self, parser):
 parser.add_argument('--json-only', action='store_true',
 help='When using the oe-setup-layers writer, write only the layer 
configuruation in json format. Otherwise, also a copy of 
scripts/oe-setup-layers (from oe-core or poky) is provided, which is a self 
contained python script that fetches all the needed layers and sets them to 
correct revisions using the data from the json.')
+
+parser.add_argument('--update', '-u',
+action='store_true',
+help=("Instead of writing a new json file, update an existing 
layer setup json file with custom references provided via the 
'--use-custom-reference' option."
+  "\nThis will only update repositories for which a custom 
reference is specified, all other repositores will be left unchanged."))
+parse

[OE-core] [RFC v4 2/2] bitbake-layers: Add test case layers setup update

2024-01-16 Thread Jermain Horsman
From: Jermain Horsman 

This includes a simple test which creates a layer setup using
custom references, and subsequently modifies the resulting layers
setup using a different custom reference.

Signed-off-by: Jermain Horsman 
---
 meta/lib/oeqa/selftest/cases/bblayers.py | 53 
 1 file changed, 53 insertions(+)

diff --git a/meta/lib/oeqa/selftest/cases/bblayers.py 
b/meta/lib/oeqa/selftest/cases/bblayers.py
index 8faa060234..bf807badb7 100644
--- a/meta/lib/oeqa/selftest/cases/bblayers.py
+++ b/meta/lib/oeqa/selftest/cases/bblayers.py
@@ -167,3 +167,56 @@ class BitbakeLayers(OESelftestTestCase):
 oecoredir = os.listdir(testcheckoutdir)[0]
 testcheckoutfile = os.path.join(testcheckoutdir, oecoredir, 
"oe-init-build-env")
 self.assertTrue(os.path.exists(testcheckoutfile), "File {} not found 
in test layer checkout".format(testcheckoutfile))
+
+def test_bitbakelayers_updatelayer(self):
+result = runCmd('bitbake-layers create-layers-setup 
{}'.format(self.testlayer_path))
+jsonfile = os.path.join(self.testlayer_path, "setup-layers.json")
+self.validate_layersjson(jsonfile)
+
+import json
+with open(jsonfile) as f:
+data = json.load(f)
+repos = []
+for s in data['sources']:
+repos.append(s)
+
+self.assertTrue(len(repos) > 1, "Not enough repositories available")
+self.validate_layersjson(jsonfile)
+
+test_ref_1 = 'ref_1'
+test_ref_2 = 'ref_2'
+
+# Create a new layers setup using custom references
+result = runCmd('bitbake-layers create-layers-setup 
--use-custom-reference {first_repo}:{test_ref} --use-custom-reference 
{second_repo}:{test_ref} {path}'
+.format(first_repo=repos[0], second_repo=repos[1], 
test_ref=test_ref_1, path=self.testlayer_path))
+self.validate_layersjson(jsonfile)
+
+with open(jsonfile) as f:
+data = json.load(f)
+first_rev_1 = data['sources'][repos[0]]['git-remote']['rev']
+first_desc_1 = data['sources'][repos[0]]['git-remote']['describe']
+second_rev_1 = data['sources'][repos[1]]['git-remote']['rev']
+second_desc_1 = data['sources'][repos[1]]['git-remote']['describe']
+
+self.assertEqual(first_rev_1, test_ref_1, "Revision not set correctly: 
'{}'".format(first_rev_1))
+self.assertEqual(first_desc_1, '', "Describe not cleared: 
'{}'".format(first_desc_1))
+self.assertEqual(second_rev_1, test_ref_1, "Revision not set 
correctly: '{}'".format(second_rev_1))
+self.assertEqual(second_desc_1, '', "Describe not cleared: 
'{}'".format(second_desc_1))
+
+# Update one of the repositories in the layers setup using a different 
custom reference
+# This should only update the selected repository, everything else 
should remain as is
+result = runCmd('bitbake-layers create-layers-setup --update 
--use-custom-reference {first_repo}:{test_ref} {path}'
+.format(first_repo=repos[0], test_ref=test_ref_2, 
path=self.testlayer_path))
+self.validate_layersjson(jsonfile)
+
+with open(jsonfile) as f:
+data = json.load(f)
+first_rev_2 = data['sources'][repos[0]]['git-remote']['rev']
+first_desc_2 = data['sources'][repos[0]]['git-remote']['describe']
+second_rev_2 = data['sources'][repos[1]]['git-remote']['rev']
+second_desc_2 = data['sources'][repos[1]]['git-remote']['describe']
+
+self.assertEqual(first_rev_2, test_ref_2, "Revision not set correctly: 
'{}'".format(first_rev_2))
+self.assertEqual(first_desc_2, '', "Describe not cleared: 
'{}'".format(first_desc_2))
+self.assertEqual(second_rev_2, second_rev_1, "Revision should not be 
updated: '{}'".format(second_rev_2))
+self.assertEqual(second_desc_2, second_desc_1, "Describe should not be 
updated: '{}'".format(second_desc_2))
-- 
2.42.0.windows.2


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#193852): 
https://lists.openembedded.org/g/openembedded-core/message/193852
Mute This Topic: https://lists.openembedded.org/mt/103759486/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [RFC v4 0/2] bitbake-layers: Add possibility to update layers setup

2024-01-16 Thread Jermain Horsman
From: Jermain Horsman 

During development it can be useful to use a branch instead of a
revision, e.g. when rebasing often or just for easy upgrading of
the setup.

This iteration has a very minimal implementation, which covers many
use cases, but certainly not all.

As previously discussed the interface is as follows:

bitbake-layers create-layers-setup
  [--update]
  --use-custom-reference :
  

Note: '--use-custom-reference :' can be used multiple times

Based on previous discussions, this implementation does not check
any input and it is left to the user to make sure that provided
references are actually valid for use by git.

Valid references are git hashes, tags and branch names, there are a
few things that should be noted:
- On systems without a default branch, using a branch name that is
  known to multiple remotes will fail.
- Using a branch name without remote will work, however after the
  initial checkout this branch is never changed as no pull is
  performed.
- The layers setup will be created successfully even if the reference
  is not valid.

Another thing to note, a possible extension would be to add an option
to update only selected repositories, this could be implemented later.

Changes in v3:
- Moved options from lib/bblayers/makesetup.py to
  lib/bblayers/setupwrites/oe-setup-layers.py.
- Split '--update REPOSITORY' in separate '--update' and '--repository
  REPOSITORY' options. Specifiying '--update' now selects the old setup
  config to be modified, without it an entirely new setup will be created
  and subsequently modified.
- Updated test case for the new options.

Changes in v4:
- Combined '--reference' and '--repository' options in
  '--use-custom-reference'.
- Updated option descriptions.
- Make all error reporting consistent.
- Updated test case.

Jermain Horsman (2):
  bitbake-layers: Add ability to update the reference of repositories
  bitbake-layers: Add test case layers setup update

 .../bblayers/setupwriters/oe-setup-layers.py  | 79 +--
 meta/lib/oeqa/selftest/cases/bblayers.py  | 53 +
 2 files changed, 125 insertions(+), 7 deletions(-)

-- 
2.42.0.windows.2


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#193850): 
https://lists.openembedded.org/g/openembedded-core/message/193850
Mute This Topic: https://lists.openembedded.org/mt/103759483/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH v2] weston: Update to 13.0.0

2024-01-16 Thread Fabio Estevam
From: Fabio Estevam 

Update to Weston 13.0.0.

Remove the following options that were no longer exist in 13.0.0:
deprecated-launcher-logind and launcher-libseat.

Add seatd as a required dependency for kms.

Signed-off-by: Fabio Estevam 
---
Changes since v1:
- Fixed typo in the commit log. (Khem)

 .../wayland/{weston_12.0.2.bb => weston_13.0.0.bb}   | 9 ++---
 1 file changed, 2 insertions(+), 7 deletions(-)
 rename meta/recipes-graphics/wayland/{weston_12.0.2.bb => weston_13.0.0.bb} 
(93%)

diff --git a/meta/recipes-graphics/wayland/weston_12.0.2.bb 
b/meta/recipes-graphics/wayland/weston_13.0.0.bb
similarity index 93%
rename from meta/recipes-graphics/wayland/weston_12.0.2.bb
rename to meta/recipes-graphics/wayland/weston_13.0.0.bb
index cfcaaca9c7..c74f471f07 100644
--- a/meta/recipes-graphics/wayland/weston_12.0.2.bb
+++ b/meta/recipes-graphics/wayland/weston_13.0.0.bb
@@ -14,7 +14,7 @@ SRC_URI = 
"https://gitlab.freedesktop.org/wayland/weston/-/releases/${PV}/downlo
file://systemd-notify.weston-start \
"
 
-SRC_URI[sha256sum] = 
"eb686a7cf00992a23b17f192fca9a887313e92c346ee35d8575196983d656b4a"
+SRC_URI[sha256sum] = 
"52ff1d4aa2394a2e416c85a338b627ce97fa71d43eb762fd4aaf145d36fc795a"
 
 UPSTREAM_CHECK_URI = "https://wayland.freedesktop.org/releases.html";
 UPSTREAM_CHECK_REGEX = "weston-(?P\d+\.\d+\.(?!9\d+)\d+)"
@@ -38,7 +38,6 @@ PACKAGECONFIG ??= "${@bb.utils.contains('DISTRO_FEATURES', 
'wayland', 'kms wayla
${@bb.utils.contains('DISTRO_FEATURES', 'x11 wayland', 
'xwayland', '', d)} \
${@bb.utils.filter('DISTRO_FEATURES', 'systemd x11', d)} \
${@bb.utils.contains_any('DISTRO_FEATURES', 'wayland x11', 
'', 'headless', d)} \
-   launcher-libseat \
image-jpeg \
screenshare \
shell-desktop \
@@ -54,7 +53,7 @@ SIMPLECLIENTS ?= "all"
 # Compositor choices
 #
 # Weston on KMS
-PACKAGECONFIG[kms] = "-Dbackend-drm=true,-Dbackend-drm=false,drm udev 
virtual/egl virtual/libgles2 virtual/libgbm mtdev"
+PACKAGECONFIG[kms] = "-Dbackend-drm=true,-Dbackend-drm=false,drm udev seatd 
virtual/egl virtual/libgles2 virtual/libgbm mtdev"
 # Weston on Wayland (nested Weston)
 PACKAGECONFIG[wayland] = 
"-Dbackend-wayland=true,-Dbackend-wayland=false,virtual/egl virtual/libgles2"
 # Weston on X11
@@ -93,10 +92,6 @@ PACKAGECONFIG[shell-ivi] = 
"-Dshell-ivi=true,-Dshell-ivi=false"
 PACKAGECONFIG[shell-kiosk] = "-Dshell-kiosk=true,-Dshell-kiosk=false"
 # JPEG image loading support
 PACKAGECONFIG[image-jpeg] = "-Dimage-jpeg=true,-Dimage-jpeg=false, jpeg"
-# support libseat based launch
-PACKAGECONFIG[launcher-libseat] = 
"-Dlauncher-libseat=true,-Dlauncher-libseat=false,seatd"
-# deprecated and superseded by libseat launcher
-PACKAGECONFIG[launcher-logind] = 
"-Ddeprecated-launcher-logind=true,-Ddeprecated-launcher-logind=false,"
 # screencasting via PipeWire
 PACKAGECONFIG[pipewire] = 
"-Dbackend-pipewire=true,-Dbackend-pipewire=false,pipewire"
 # VNC remote screensharing
-- 
2.37.3


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#193849): 
https://lists.openembedded.org/g/openembedded-core/message/193849
Mute This Topic: https://lists.openembedded.org/mt/103759101/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] Patchtest results for [PATCH v2 7/9] oeqa/selftest/recipetool: Move create_go test to a proper class

2024-01-16 Thread Vyacheslav Yurkov
I also have the same opinion. What else am I supposed to write in the 
body if it were merely a refactoring (function moved, renamed, etc), and 
it's already described in the hearer?


Slava

On 16.01.2024 10:32, Alexander Kanavin wrote:

Because making it strict would only result in useless noise in the
commit logs. It's entirely valid to have changes that can fully be
described with a commit header. I see it as a notice to consider if
the commit message should be added, at the discretion of both
submitter and committer.

Alex

On Tue, 16 Jan 2024 at 10:28, Alexandre Belloni
 wrote:

On 16/01/2024 10:08:50+0100, Alexander Kanavin wrote:

No.

Why not?




-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#193848): 
https://lists.openembedded.org/g/openembedded-core/message/193848
Mute This Topic: https://lists.openembedded.org/mt/103758512/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] Patchtest results for [PATCH v2 7/9] oeqa/selftest/recipetool: Move create_go test to a proper class

2024-01-16 Thread Alexander Kanavin
Because making it strict would only result in useless noise in the
commit logs. It's entirely valid to have changes that can fully be
described with a commit header. I see it as a notice to consider if
the commit message should be added, at the discretion of both
submitter and committer.

Alex

On Tue, 16 Jan 2024 at 10:28, Alexandre Belloni
 wrote:
>
> On 16/01/2024 10:08:50+0100, Alexander Kanavin wrote:
> > No.
>
> Why not?
>
> >
> > Alex
> >
> > On Tue, 16 Jan 2024 at 09:53, Vyacheslav Yurkov  wrote:
> > >
> > > Is that a strict requirement now even for trivial patches?
> > >
> > > Slava
> > >
> > > On 16.01.2024 09:45, patcht...@automation.yoctoproject.org wrote:
> > > > Thank you for your submission. Patchtest identified one
> > > > or more issues with the patch. Please see the log below for
> > > > more information:
> > > >
> > > > ---
> > > > Testing patch 
> > > > /home/patchtest/share/mboxes/v2-7-9-oeqa-selftest-recipetool-Move-create_go-test-to-a-proper-class.patch
> > > >
> > > > FAIL: test commit message presence: Please include a commit message on 
> > > > your patch explaining the change 
> > > > (test_mbox.TestMbox.test_commit_message_presence)
> > > >
> > > > PASS: pretest pylint (test_python_pylint.PyLint.pretest_pylint)
> > > > PASS: test Signed-off-by presence 
> > > > (test_mbox.TestMbox.test_signed_off_by_presence)
> > > > PASS: test author valid (test_mbox.TestMbox.test_author_valid)
> > > > PASS: test max line length 
> > > > (test_metadata.TestMetadata.test_max_line_length)
> > > > PASS: test mbox format (test_mbox.TestMbox.test_mbox_format)
> > > > PASS: test non-AUH upgrade (test_mbox.TestMbox.test_non_auh_upgrade)
> > > > PASS: test pylint (test_python_pylint.PyLint.test_pylint)
> > > > PASS: test shortlog format (test_mbox.TestMbox.test_shortlog_format)
> > > > PASS: test shortlog length (test_mbox.TestMbox.test_shortlog_length)
> > > >
> > > > SKIP: pretest src uri left files: No modified recipes, skipping pretest 
> > > > (test_metadata.TestMetadata.pretest_src_uri_left_files)
> > > > SKIP: test CVE check ignore: No modified recipes, skipping test 
> > > > (test_metadata.TestMetadata.test_cve_check_ignore)
> > > > SKIP: test CVE tag format: No new CVE patches introduced 
> > > > (test_patch.TestPatch.test_cve_tag_format)
> > > > SKIP: test Signed-off-by presence: No new CVE patches introduced 
> > > > (test_patch.TestPatch.test_signed_off_by_presence)
> > > > SKIP: test Upstream-Status presence: No new CVE patches introduced 
> > > > (test_patch.TestPatch.test_upstream_status_presence_format)
> > > > SKIP: test bugzilla entry format: No bug ID found 
> > > > (test_mbox.TestMbox.test_bugzilla_entry_format)
> > > > SKIP: test lic files chksum modified not mentioned: No modified 
> > > > recipes, skipping test 
> > > > (test_metadata.TestMetadata.test_lic_files_chksum_modified_not_mentioned)
> > > > SKIP: test lic files chksum presence: No added recipes, skipping test 
> > > > (test_metadata.TestMetadata.test_lic_files_chksum_presence)
> > > > SKIP: test license presence: No added recipes, skipping test 
> > > > (test_metadata.TestMetadata.test_license_presence)
> > > > SKIP: test series merge on head: Merge test is disabled for now 
> > > > (test_mbox.TestMbox.test_series_merge_on_head)
> > > > SKIP: test src uri left files: No modified recipes, skipping pretest 
> > > > (test_metadata.TestMetadata.test_src_uri_left_files)
> > > > SKIP: test summary presence: No added recipes, skipping test 
> > > > (test_metadata.TestMetadata.test_summary_presence)
> > > > SKIP: test target mailing list: Series merged, no reason to check other 
> > > > mailing lists (test_mbox.TestMbox.test_target_mailing_list)
> > > >
> > > > ---
> > > >
> > > > Please address the issues identified and
> > > > submit a new revision of the patch, or alternatively, reply to this
> > > > email with an explanation of why the patch should be accepted. If you
> > > > believe these results are due to an error in patchtest, please submit a
> > > > bug at https://bugzilla.yoctoproject.org/ (use the 'Patchtest' category
> > > > under 'Yocto Project Subprojects'). For more information on specific
> > > > failures, see: https://wiki.yoctoproject.org/wiki/Patchtest. Thank
> > > > you!
> > >
> > >
> > >
> > >
> > >
>
> >
> > 
> >
>
>
> --
> Alexandre Belloni, co-owner and COO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#193847): 
https://lists.openembedded.org/g/openembedded-core/message/193847
Mute This Topic: https://lists.openembedded.org/mt/103758512/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] Patchtest results for [PATCH v2 7/9] oeqa/selftest/recipetool: Move create_go test to a proper class

2024-01-16 Thread Alexandre Belloni via lists.openembedded.org
On 16/01/2024 10:08:50+0100, Alexander Kanavin wrote:
> No.

Why not?

> 
> Alex
> 
> On Tue, 16 Jan 2024 at 09:53, Vyacheslav Yurkov  wrote:
> >
> > Is that a strict requirement now even for trivial patches?
> >
> > Slava
> >
> > On 16.01.2024 09:45, patcht...@automation.yoctoproject.org wrote:
> > > Thank you for your submission. Patchtest identified one
> > > or more issues with the patch. Please see the log below for
> > > more information:
> > >
> > > ---
> > > Testing patch 
> > > /home/patchtest/share/mboxes/v2-7-9-oeqa-selftest-recipetool-Move-create_go-test-to-a-proper-class.patch
> > >
> > > FAIL: test commit message presence: Please include a commit message on 
> > > your patch explaining the change 
> > > (test_mbox.TestMbox.test_commit_message_presence)
> > >
> > > PASS: pretest pylint (test_python_pylint.PyLint.pretest_pylint)
> > > PASS: test Signed-off-by presence 
> > > (test_mbox.TestMbox.test_signed_off_by_presence)
> > > PASS: test author valid (test_mbox.TestMbox.test_author_valid)
> > > PASS: test max line length 
> > > (test_metadata.TestMetadata.test_max_line_length)
> > > PASS: test mbox format (test_mbox.TestMbox.test_mbox_format)
> > > PASS: test non-AUH upgrade (test_mbox.TestMbox.test_non_auh_upgrade)
> > > PASS: test pylint (test_python_pylint.PyLint.test_pylint)
> > > PASS: test shortlog format (test_mbox.TestMbox.test_shortlog_format)
> > > PASS: test shortlog length (test_mbox.TestMbox.test_shortlog_length)
> > >
> > > SKIP: pretest src uri left files: No modified recipes, skipping pretest 
> > > (test_metadata.TestMetadata.pretest_src_uri_left_files)
> > > SKIP: test CVE check ignore: No modified recipes, skipping test 
> > > (test_metadata.TestMetadata.test_cve_check_ignore)
> > > SKIP: test CVE tag format: No new CVE patches introduced 
> > > (test_patch.TestPatch.test_cve_tag_format)
> > > SKIP: test Signed-off-by presence: No new CVE patches introduced 
> > > (test_patch.TestPatch.test_signed_off_by_presence)
> > > SKIP: test Upstream-Status presence: No new CVE patches introduced 
> > > (test_patch.TestPatch.test_upstream_status_presence_format)
> > > SKIP: test bugzilla entry format: No bug ID found 
> > > (test_mbox.TestMbox.test_bugzilla_entry_format)
> > > SKIP: test lic files chksum modified not mentioned: No modified recipes, 
> > > skipping test 
> > > (test_metadata.TestMetadata.test_lic_files_chksum_modified_not_mentioned)
> > > SKIP: test lic files chksum presence: No added recipes, skipping test 
> > > (test_metadata.TestMetadata.test_lic_files_chksum_presence)
> > > SKIP: test license presence: No added recipes, skipping test 
> > > (test_metadata.TestMetadata.test_license_presence)
> > > SKIP: test series merge on head: Merge test is disabled for now 
> > > (test_mbox.TestMbox.test_series_merge_on_head)
> > > SKIP: test src uri left files: No modified recipes, skipping pretest 
> > > (test_metadata.TestMetadata.test_src_uri_left_files)
> > > SKIP: test summary presence: No added recipes, skipping test 
> > > (test_metadata.TestMetadata.test_summary_presence)
> > > SKIP: test target mailing list: Series merged, no reason to check other 
> > > mailing lists (test_mbox.TestMbox.test_target_mailing_list)
> > >
> > > ---
> > >
> > > Please address the issues identified and
> > > submit a new revision of the patch, or alternatively, reply to this
> > > email with an explanation of why the patch should be accepted. If you
> > > believe these results are due to an error in patchtest, please submit a
> > > bug at https://bugzilla.yoctoproject.org/ (use the 'Patchtest' category
> > > under 'Yocto Project Subprojects'). For more information on specific
> > > failures, see: https://wiki.yoctoproject.org/wiki/Patchtest. Thank
> > > you!
> >
> >
> >
> > 
> >

> 
> 
> 


-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#193846): 
https://lists.openembedded.org/g/openembedded-core/message/193846
Mute This Topic: https://lists.openembedded.org/mt/103758512/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] Patchtest results for [PATCH v2 7/9] oeqa/selftest/recipetool: Move create_go test to a proper class

2024-01-16 Thread Alexander Kanavin
No.

Alex

On Tue, 16 Jan 2024 at 09:53, Vyacheslav Yurkov  wrote:
>
> Is that a strict requirement now even for trivial patches?
>
> Slava
>
> On 16.01.2024 09:45, patcht...@automation.yoctoproject.org wrote:
> > Thank you for your submission. Patchtest identified one
> > or more issues with the patch. Please see the log below for
> > more information:
> >
> > ---
> > Testing patch 
> > /home/patchtest/share/mboxes/v2-7-9-oeqa-selftest-recipetool-Move-create_go-test-to-a-proper-class.patch
> >
> > FAIL: test commit message presence: Please include a commit message on your 
> > patch explaining the change 
> > (test_mbox.TestMbox.test_commit_message_presence)
> >
> > PASS: pretest pylint (test_python_pylint.PyLint.pretest_pylint)
> > PASS: test Signed-off-by presence 
> > (test_mbox.TestMbox.test_signed_off_by_presence)
> > PASS: test author valid (test_mbox.TestMbox.test_author_valid)
> > PASS: test max line length (test_metadata.TestMetadata.test_max_line_length)
> > PASS: test mbox format (test_mbox.TestMbox.test_mbox_format)
> > PASS: test non-AUH upgrade (test_mbox.TestMbox.test_non_auh_upgrade)
> > PASS: test pylint (test_python_pylint.PyLint.test_pylint)
> > PASS: test shortlog format (test_mbox.TestMbox.test_shortlog_format)
> > PASS: test shortlog length (test_mbox.TestMbox.test_shortlog_length)
> >
> > SKIP: pretest src uri left files: No modified recipes, skipping pretest 
> > (test_metadata.TestMetadata.pretest_src_uri_left_files)
> > SKIP: test CVE check ignore: No modified recipes, skipping test 
> > (test_metadata.TestMetadata.test_cve_check_ignore)
> > SKIP: test CVE tag format: No new CVE patches introduced 
> > (test_patch.TestPatch.test_cve_tag_format)
> > SKIP: test Signed-off-by presence: No new CVE patches introduced 
> > (test_patch.TestPatch.test_signed_off_by_presence)
> > SKIP: test Upstream-Status presence: No new CVE patches introduced 
> > (test_patch.TestPatch.test_upstream_status_presence_format)
> > SKIP: test bugzilla entry format: No bug ID found 
> > (test_mbox.TestMbox.test_bugzilla_entry_format)
> > SKIP: test lic files chksum modified not mentioned: No modified recipes, 
> > skipping test 
> > (test_metadata.TestMetadata.test_lic_files_chksum_modified_not_mentioned)
> > SKIP: test lic files chksum presence: No added recipes, skipping test 
> > (test_metadata.TestMetadata.test_lic_files_chksum_presence)
> > SKIP: test license presence: No added recipes, skipping test 
> > (test_metadata.TestMetadata.test_license_presence)
> > SKIP: test series merge on head: Merge test is disabled for now 
> > (test_mbox.TestMbox.test_series_merge_on_head)
> > SKIP: test src uri left files: No modified recipes, skipping pretest 
> > (test_metadata.TestMetadata.test_src_uri_left_files)
> > SKIP: test summary presence: No added recipes, skipping test 
> > (test_metadata.TestMetadata.test_summary_presence)
> > SKIP: test target mailing list: Series merged, no reason to check other 
> > mailing lists (test_mbox.TestMbox.test_target_mailing_list)
> >
> > ---
> >
> > Please address the issues identified and
> > submit a new revision of the patch, or alternatively, reply to this
> > email with an explanation of why the patch should be accepted. If you
> > believe these results are due to an error in patchtest, please submit a
> > bug at https://bugzilla.yoctoproject.org/ (use the 'Patchtest' category
> > under 'Yocto Project Subprojects'). For more information on specific
> > failures, see: https://wiki.yoctoproject.org/wiki/Patchtest. Thank
> > you!
>
>
>
> 
>

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#193845): 
https://lists.openembedded.org/g/openembedded-core/message/193845
Mute This Topic: https://lists.openembedded.org/mt/103758512/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core][PATCH v2] cmake.bbclass: add Darwin support

2024-01-16 Thread Etienne Cordonnier via lists.openembedded.org
I fixed a typo in the commit message: "directory -> directly".

On Tue, Jan 16, 2024 at 10:02 AM  wrote:

> From: Etienne Cordonnier 
>
> This was initially added by
> https://git.yoctoproject.org/meta-darwin/commit/?id=97a84e083d0c2812e44231d48fb478e9a9cfac79
> to the meta-darwin repository, however having it directly in
> openembedded-core will make the maintenance of meta-darwin easier.
>
> Signed-off-by: Dominik Schnitzer 
> Signed-off-by: Etienne Cordonnier 
> ---
>  meta/classes-recipe/cmake.bbclass | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/meta/classes-recipe/cmake.bbclass
> b/meta/classes-recipe/cmake.bbclass
> index d978b88944..1e353f660f 100644
> --- a/meta/classes-recipe/cmake.bbclass
> +++ b/meta/classes-recipe/cmake.bbclass
> @@ -72,6 +72,8 @@ OECMAKE_TARGET_COMPILE ?= "all"
>  OECMAKE_TARGET_INSTALL ?= "install"
>
>  def map_host_os_to_system_name(host_os):
> +if host_os.startswith('darwin'):
> +return 'Darwin'
>  if host_os.startswith('mingw'):
>  return 'Windows'
>  if host_os.startswith('linux'):
> --
> 2.36.1.vfs.0.0
>
>

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#193844): 
https://lists.openembedded.org/g/openembedded-core/message/193844
Mute This Topic: https://lists.openembedded.org/mt/103758605/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Patchtest results for [OE-core][kirkstone][PATCH 1/1] cpio: upgrade to 2.14

2024-01-16 Thread Patchtest
Thank you for your submission. Patchtest identified one
or more issues with the patch. Please see the log below for
more information:

---
Testing patch 
/home/patchtest/share/mboxes/kirkstone-1-1-cpio-upgrade-to-2.14.patch

FAIL: test CVE check ignore: CVE_CHECK_IGNORE is deprecated and should be 
replaced by CVE_STATUS (test_metadata.TestMetadata.test_cve_check_ignore)
FAIL: test CVE tag format: Missing or incorrectly formatted CVE tag in patch 
file. Correct or include the CVE tag in the patch with format: "CVE: 
CVE--" (test_patch.TestPatch.test_cve_tag_format)

PASS: pretest src uri left files 
(test_metadata.TestMetadata.pretest_src_uri_left_files)
PASS: test Signed-off-by presence 
(test_mbox.TestMbox.test_signed_off_by_presence)
PASS: test Signed-off-by presence 
(test_patch.TestPatch.test_signed_off_by_presence)
PASS: test Upstream-Status presence 
(test_patch.TestPatch.test_upstream_status_presence_format)
PASS: test author valid (test_mbox.TestMbox.test_author_valid)
PASS: test bugzilla entry format (test_mbox.TestMbox.test_bugzilla_entry_format)
PASS: test commit message presence 
(test_mbox.TestMbox.test_commit_message_presence)
PASS: test lic files chksum modified not mentioned 
(test_metadata.TestMetadata.test_lic_files_chksum_modified_not_mentioned)
PASS: test max line length (test_metadata.TestMetadata.test_max_line_length)
PASS: test mbox format (test_mbox.TestMbox.test_mbox_format)
PASS: test non-AUH upgrade (test_mbox.TestMbox.test_non_auh_upgrade)
PASS: test shortlog format (test_mbox.TestMbox.test_shortlog_format)
PASS: test shortlog length (test_mbox.TestMbox.test_shortlog_length)
PASS: test src uri left files 
(test_metadata.TestMetadata.test_src_uri_left_files)

SKIP: pretest pylint: No python related patches, skipping test 
(test_python_pylint.PyLint.pretest_pylint)
SKIP: test lic files chksum presence: No added recipes, skipping test 
(test_metadata.TestMetadata.test_lic_files_chksum_presence)
SKIP: test license presence: No added recipes, skipping test 
(test_metadata.TestMetadata.test_license_presence)
SKIP: test pylint: No python related patches, skipping test 
(test_python_pylint.PyLint.test_pylint)
SKIP: test series merge on head: Merge test is disabled for now 
(test_mbox.TestMbox.test_series_merge_on_head)
SKIP: test summary presence: No added recipes, skipping test 
(test_metadata.TestMetadata.test_summary_presence)
SKIP: test target mailing list: Series merged, no reason to check other mailing 
lists (test_mbox.TestMbox.test_target_mailing_list)

---

Please address the issues identified and
submit a new revision of the patch, or alternatively, reply to this
email with an explanation of why the patch should be accepted. If you
believe these results are due to an error in patchtest, please submit a
bug at https://bugzilla.yoctoproject.org/ (use the 'Patchtest' category
under 'Yocto Project Subprojects'). For more information on specific
failures, see: https://wiki.yoctoproject.org/wiki/Patchtest. Thank
you!

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#193843): 
https://lists.openembedded.org/g/openembedded-core/message/193843
Mute This Topic: https://lists.openembedded.org/mt/103758608/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core][PATCH v2] cmake.bbclass: add Darwin support

2024-01-16 Thread Etienne Cordonnier via lists.openembedded.org
From: Etienne Cordonnier 

This was initially added by 
https://git.yoctoproject.org/meta-darwin/commit/?id=97a84e083d0c2812e44231d48fb478e9a9cfac79
to the meta-darwin repository, however having it directly in openembedded-core 
will make the maintenance of meta-darwin easier.

Signed-off-by: Dominik Schnitzer 
Signed-off-by: Etienne Cordonnier 
---
 meta/classes-recipe/cmake.bbclass | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/meta/classes-recipe/cmake.bbclass 
b/meta/classes-recipe/cmake.bbclass
index d978b88944..1e353f660f 100644
--- a/meta/classes-recipe/cmake.bbclass
+++ b/meta/classes-recipe/cmake.bbclass
@@ -72,6 +72,8 @@ OECMAKE_TARGET_COMPILE ?= "all"
 OECMAKE_TARGET_INSTALL ?= "install"
 
 def map_host_os_to_system_name(host_os):
+if host_os.startswith('darwin'):
+return 'Darwin'
 if host_os.startswith('mingw'):
 return 'Windows'
 if host_os.startswith('linux'):
-- 
2.36.1.vfs.0.0


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#193842): 
https://lists.openembedded.org/g/openembedded-core/message/193842
Mute This Topic: https://lists.openembedded.org/mt/103758605/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] Patchtest results for [PATCH v2 7/9] oeqa/selftest/recipetool: Move create_go test to a proper class

2024-01-16 Thread Vyacheslav Yurkov

Is that a strict requirement now even for trivial patches?

Slava

On 16.01.2024 09:45, patcht...@automation.yoctoproject.org wrote:

Thank you for your submission. Patchtest identified one
or more issues with the patch. Please see the log below for
more information:

---
Testing patch 
/home/patchtest/share/mboxes/v2-7-9-oeqa-selftest-recipetool-Move-create_go-test-to-a-proper-class.patch

FAIL: test commit message presence: Please include a commit message on your 
patch explaining the change (test_mbox.TestMbox.test_commit_message_presence)

PASS: pretest pylint (test_python_pylint.PyLint.pretest_pylint)
PASS: test Signed-off-by presence 
(test_mbox.TestMbox.test_signed_off_by_presence)
PASS: test author valid (test_mbox.TestMbox.test_author_valid)
PASS: test max line length (test_metadata.TestMetadata.test_max_line_length)
PASS: test mbox format (test_mbox.TestMbox.test_mbox_format)
PASS: test non-AUH upgrade (test_mbox.TestMbox.test_non_auh_upgrade)
PASS: test pylint (test_python_pylint.PyLint.test_pylint)
PASS: test shortlog format (test_mbox.TestMbox.test_shortlog_format)
PASS: test shortlog length (test_mbox.TestMbox.test_shortlog_length)

SKIP: pretest src uri left files: No modified recipes, skipping pretest 
(test_metadata.TestMetadata.pretest_src_uri_left_files)
SKIP: test CVE check ignore: No modified recipes, skipping test 
(test_metadata.TestMetadata.test_cve_check_ignore)
SKIP: test CVE tag format: No new CVE patches introduced 
(test_patch.TestPatch.test_cve_tag_format)
SKIP: test Signed-off-by presence: No new CVE patches introduced 
(test_patch.TestPatch.test_signed_off_by_presence)
SKIP: test Upstream-Status presence: No new CVE patches introduced 
(test_patch.TestPatch.test_upstream_status_presence_format)
SKIP: test bugzilla entry format: No bug ID found 
(test_mbox.TestMbox.test_bugzilla_entry_format)
SKIP: test lic files chksum modified not mentioned: No modified recipes, 
skipping test 
(test_metadata.TestMetadata.test_lic_files_chksum_modified_not_mentioned)
SKIP: test lic files chksum presence: No added recipes, skipping test 
(test_metadata.TestMetadata.test_lic_files_chksum_presence)
SKIP: test license presence: No added recipes, skipping test 
(test_metadata.TestMetadata.test_license_presence)
SKIP: test series merge on head: Merge test is disabled for now 
(test_mbox.TestMbox.test_series_merge_on_head)
SKIP: test src uri left files: No modified recipes, skipping pretest 
(test_metadata.TestMetadata.test_src_uri_left_files)
SKIP: test summary presence: No added recipes, skipping test 
(test_metadata.TestMetadata.test_summary_presence)
SKIP: test target mailing list: Series merged, no reason to check other mailing 
lists (test_mbox.TestMbox.test_target_mailing_list)

---

Please address the issues identified and
submit a new revision of the patch, or alternatively, reply to this
email with an explanation of why the patch should be accepted. If you
believe these results are due to an error in patchtest, please submit a
bug at https://bugzilla.yoctoproject.org/ (use the 'Patchtest' category
under 'Yocto Project Subprojects'). For more information on specific
failures, see: https://wiki.yoctoproject.org/wiki/Patchtest. Thank
you!




-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#193841): 
https://lists.openembedded.org/g/openembedded-core/message/193841
Mute This Topic: https://lists.openembedded.org/mt/103758512/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core][kirkstone][PATCH 1/1] cpio: upgrade to 2.14

2024-01-16 Thread Soumya via lists.openembedded.org
From: Soumya Sambu 

This includes fix for CVE-2023-7207.

Drop all submitted patches.

Apply a patch from git to fix the build with clang.

[ YOCTO #11674 ]

$git log --oneline release_2_13..v2.14
4a41909 (HEAD, tag: v2.14) Version 2.14
6f9e5d3 Update NEWS
807b3ea Use GNU ls algorithm for deciding timestamp format
19219d1 Fix integer overflows in timestamp output
ed28f14 Whitespace cleanup
4ab2813 Update version of gnulib
0987d63 Fix appending to archives bigger than 2G
1df0062 Fix combination of --create, --append, --directory
6a94d5e New option --ignore-dirnlink
376d663 Fix 45b0ee2b407913c533f7ded8d6f8cbeec16ff6ca.
beba8c0 Require automake 1.16.5
70fffa7 Update for newer autotools
a1b2f78 Fix calculation of CRC in copy-out mode.
18ea636 Upgrade gnulib
1a61f62 Update copyright years
a1c97c8 Fix wording in the manpage
97fab48 Update copyright years
86dacfe Remove redundant condition check
4d16930 Use inttostr to represent integer values as strings
236684f Fix dynamic string reallocations
dfc801c Fix previous commit
dd96882 Rewrite dynamic string support.
269d204 Improve online version of the documentation.
7dd8ba9 Update gnulib
905907c Update copyright years
4a78d77 Formatting changes in the documentation.
9fe8494 Update copyright years
641d3f4 Minor fix * src/global.c: Remove superfluous declaration of program_name
0c4ffde Fix handling of device numbers (part 2)
df55fb1 Fix handling of device numbers on copy out.
b1c8583 Improve 684b7ac5
684b7ac Fix cpio header verification.

Signed-off-by: Soumya Sambu 
---
 ...charset_alias-when-building-for-musl.patch |  30 -
 ...ove-superfluous-declaration-of-progr.patch |  28 -
 ...-calculation-of-CRC-in-copy-out-mode.patch |  58 --
 ...appending-to-archives-bigger-than-2G.patch | 312 --
 .../cpio/cpio-2.13/CVE-2021-38185.patch   | 581 --
 .../cpio/{cpio_2.13.bb => cpio_2.14.bb}   |   9 +-
 ...e-needed-header-for-major-minor-macr.patch |  47 ++
 7 files changed, 49 insertions(+), 1016 deletions(-)
 delete mode 100644 
meta/recipes-extended/cpio/cpio-2.13/0001-Unset-need_charset_alias-when-building-for-musl.patch
 delete mode 100644 
meta/recipes-extended/cpio/cpio-2.13/0002-src-global.c-Remove-superfluous-declaration-of-progr.patch
 delete mode 100644 
meta/recipes-extended/cpio/cpio-2.13/0003-Fix-calculation-of-CRC-in-copy-out-mode.patch
 delete mode 100644 
meta/recipes-extended/cpio/cpio-2.13/0004-Fix-appending-to-archives-bigger-than-2G.patch
 delete mode 100644 meta/recipes-extended/cpio/cpio-2.13/CVE-2021-38185.patch
 rename meta/recipes-extended/cpio/{cpio_2.13.bb => cpio_2.14.bb} (74%)
 create mode 100644 
meta/recipes-extended/cpio/files/0001-configure-Include-needed-header-for-major-minor-macr.patch

diff --git 
a/meta/recipes-extended/cpio/cpio-2.13/0001-Unset-need_charset_alias-when-building-for-musl.patch
 
b/meta/recipes-extended/cpio/cpio-2.13/0001-Unset-need_charset_alias-when-building-for-musl.patch
deleted file mode 100644
index 6ae213942c..00
--- 
a/meta/recipes-extended/cpio/cpio-2.13/0001-Unset-need_charset_alias-when-building-for-musl.patch
+++ /dev/null
@@ -1,30 +0,0 @@
-From b9565dc2fe0c4f7daaec91b7e83bc7313dee2f4a Mon Sep 17 00:00:00 2001
-From: Khem Raj 
-Date: Mon, 13 Apr 2015 17:02:13 -0700
-Subject: [PATCH] Unset need_charset_alias when building for musl
-
-localcharset uses ac_cv_gnu_library_2_1 from glibc21.m4
-which actually shoudl be fixed in gnulib and then all downstream
-projects will get it eventually. For now we apply the fix to
-coreutils
-
-Upstream-Status: Pending
-
-Signed-off-by: Khem Raj 

- lib/gnulib.mk | 2 +-
- 1 file changed, 1 insertion(+), 1 deletion(-)
-
-Index: cpio-2.11/gnu/Makefile.am
-===
 cpio-2.11.orig/gnu/Makefile.am
-+++ cpio-2.11/gnu/Makefile.am
-@@ -734,7 +734,7 @@ install-exec-localcharset: all-local
- case '$(host_os)' in \
-   darwin[56]*) \
- need_charset_alias=true ;; \
--  darwin* | cygwin* | mingw* | pw32* | cegcc*) \
-+  darwin* | cygwin* | mingw* | pw32* | cegcc* | linux-musl*) \
- need_charset_alias=false ;; \
-   *) \
- need_charset_alias=true ;; \
diff --git 
a/meta/recipes-extended/cpio/cpio-2.13/0002-src-global.c-Remove-superfluous-declaration-of-progr.patch
 
b/meta/recipes-extended/cpio/cpio-2.13/0002-src-global.c-Remove-superfluous-declaration-of-progr.patch
deleted file mode 100644
index 478324c1c4..00
--- 
a/meta/recipes-extended/cpio/cpio-2.13/0002-src-global.c-Remove-superfluous-declaration-of-progr.patch
+++ /dev/null
@@ -1,28 +0,0 @@
-From 33e6cb5a28fab3d99bd6818f8c01e6f33805390f Mon Sep 17 00:00:00 2001
-From: Sergey Poznyakoff 
-Date: Mon, 20 Jan 2020 07:45:39 +0200
-Subject: [PATCH] src/global.c: Remove superfluous declaration of program_name
-
-Upstream-Status: Backport (commit 641d3f4)
-Signed-off-by: Richard Leitner 

- src/global.c | 3 ---
- 1 file changed, 3 deletions(-)
-
-diff 

[OE-core] Patchtest results for [PATCH v2 9/9] oeqa/selftest/recipetool: Add test coverage for local go modules

2024-01-16 Thread Patchtest
Thank you for your submission. Patchtest identified one
or more issues with the patch. Please see the log below for
more information:

---
Testing patch 
/home/patchtest/share/mboxes/v2-9-9-oeqa-selftest-recipetool-Add-test-coverage-for-local-go-modules.patch

FAIL: test commit message presence: Please include a commit message on your 
patch explaining the change (test_mbox.TestMbox.test_commit_message_presence)

PASS: pretest pylint (test_python_pylint.PyLint.pretest_pylint)
PASS: test Signed-off-by presence 
(test_mbox.TestMbox.test_signed_off_by_presence)
PASS: test author valid (test_mbox.TestMbox.test_author_valid)
PASS: test max line length (test_metadata.TestMetadata.test_max_line_length)
PASS: test mbox format (test_mbox.TestMbox.test_mbox_format)
PASS: test non-AUH upgrade (test_mbox.TestMbox.test_non_auh_upgrade)
PASS: test pylint (test_python_pylint.PyLint.test_pylint)
PASS: test shortlog format (test_mbox.TestMbox.test_shortlog_format)
PASS: test shortlog length (test_mbox.TestMbox.test_shortlog_length)
PASS: test target mailing list (test_mbox.TestMbox.test_target_mailing_list)

SKIP: pretest src uri left files: Patch cannot be merged 
(test_metadata.TestMetadata.pretest_src_uri_left_files)
SKIP: test CVE check ignore: No modified recipes, skipping test 
(test_metadata.TestMetadata.test_cve_check_ignore)
SKIP: test CVE tag format: No new CVE patches introduced 
(test_patch.TestPatch.test_cve_tag_format)
SKIP: test Signed-off-by presence: No new CVE patches introduced 
(test_patch.TestPatch.test_signed_off_by_presence)
SKIP: test Upstream-Status presence: No new CVE patches introduced 
(test_patch.TestPatch.test_upstream_status_presence_format)
SKIP: test bugzilla entry format: No bug ID found 
(test_mbox.TestMbox.test_bugzilla_entry_format)
SKIP: test lic files chksum modified not mentioned: No modified recipes, 
skipping test 
(test_metadata.TestMetadata.test_lic_files_chksum_modified_not_mentioned)
SKIP: test lic files chksum presence: No added recipes, skipping test 
(test_metadata.TestMetadata.test_lic_files_chksum_presence)
SKIP: test license presence: No added recipes, skipping test 
(test_metadata.TestMetadata.test_license_presence)
SKIP: test series merge on head: Merge test is disabled for now 
(test_mbox.TestMbox.test_series_merge_on_head)
SKIP: test src uri left files: Patch cannot be merged 
(test_metadata.TestMetadata.test_src_uri_left_files)
SKIP: test summary presence: No added recipes, skipping test 
(test_metadata.TestMetadata.test_summary_presence)

---

Please address the issues identified and
submit a new revision of the patch, or alternatively, reply to this
email with an explanation of why the patch should be accepted. If you
believe these results are due to an error in patchtest, please submit a
bug at https://bugzilla.yoctoproject.org/ (use the 'Patchtest' category
under 'Yocto Project Subprojects'). For more information on specific
failures, see: https://wiki.yoctoproject.org/wiki/Patchtest. Thank
you!

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#193839): 
https://lists.openembedded.org/g/openembedded-core/message/193839
Mute This Topic: https://lists.openembedded.org/mt/103758514/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] Patchtest results for [PATCH v2 8/9] oeqa/selftest/recipetool: Move helper function to the class scope

2024-01-16 Thread Patchtest
Thank you for your submission. Patchtest identified one
or more issues with the patch. Please see the log below for
more information:

---
Testing patch 
/home/patchtest/share/mboxes/v2-8-9-oeqa-selftest-recipetool-Move-helper-function-to-the-class-scope.patch

FAIL: test commit message presence: Please include a commit message on your 
patch explaining the change (test_mbox.TestMbox.test_commit_message_presence)

PASS: pretest pylint (test_python_pylint.PyLint.pretest_pylint)
PASS: test Signed-off-by presence 
(test_mbox.TestMbox.test_signed_off_by_presence)
PASS: test author valid (test_mbox.TestMbox.test_author_valid)
PASS: test max line length (test_metadata.TestMetadata.test_max_line_length)
PASS: test mbox format (test_mbox.TestMbox.test_mbox_format)
PASS: test non-AUH upgrade (test_mbox.TestMbox.test_non_auh_upgrade)
PASS: test pylint (test_python_pylint.PyLint.test_pylint)
PASS: test shortlog format (test_mbox.TestMbox.test_shortlog_format)
PASS: test shortlog length (test_mbox.TestMbox.test_shortlog_length)
PASS: test target mailing list (test_mbox.TestMbox.test_target_mailing_list)

SKIP: pretest src uri left files: Patch cannot be merged 
(test_metadata.TestMetadata.pretest_src_uri_left_files)
SKIP: test CVE check ignore: No modified recipes, skipping test 
(test_metadata.TestMetadata.test_cve_check_ignore)
SKIP: test CVE tag format: No new CVE patches introduced 
(test_patch.TestPatch.test_cve_tag_format)
SKIP: test Signed-off-by presence: No new CVE patches introduced 
(test_patch.TestPatch.test_signed_off_by_presence)
SKIP: test Upstream-Status presence: No new CVE patches introduced 
(test_patch.TestPatch.test_upstream_status_presence_format)
SKIP: test bugzilla entry format: No bug ID found 
(test_mbox.TestMbox.test_bugzilla_entry_format)
SKIP: test lic files chksum modified not mentioned: No modified recipes, 
skipping test 
(test_metadata.TestMetadata.test_lic_files_chksum_modified_not_mentioned)
SKIP: test lic files chksum presence: No added recipes, skipping test 
(test_metadata.TestMetadata.test_lic_files_chksum_presence)
SKIP: test license presence: No added recipes, skipping test 
(test_metadata.TestMetadata.test_license_presence)
SKIP: test series merge on head: Merge test is disabled for now 
(test_mbox.TestMbox.test_series_merge_on_head)
SKIP: test src uri left files: Patch cannot be merged 
(test_metadata.TestMetadata.test_src_uri_left_files)
SKIP: test summary presence: No added recipes, skipping test 
(test_metadata.TestMetadata.test_summary_presence)

---

Please address the issues identified and
submit a new revision of the patch, or alternatively, reply to this
email with an explanation of why the patch should be accepted. If you
believe these results are due to an error in patchtest, please submit a
bug at https://bugzilla.yoctoproject.org/ (use the 'Patchtest' category
under 'Yocto Project Subprojects'). For more information on specific
failures, see: https://wiki.yoctoproject.org/wiki/Patchtest. Thank
you!

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#193838): 
https://lists.openembedded.org/g/openembedded-core/message/193838
Mute This Topic: https://lists.openembedded.org/mt/103758513/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] Patchtest results for [PATCH v2 7/9] oeqa/selftest/recipetool: Move create_go test to a proper class

2024-01-16 Thread Patchtest
Thank you for your submission. Patchtest identified one
or more issues with the patch. Please see the log below for
more information:

---
Testing patch 
/home/patchtest/share/mboxes/v2-7-9-oeqa-selftest-recipetool-Move-create_go-test-to-a-proper-class.patch

FAIL: test commit message presence: Please include a commit message on your 
patch explaining the change (test_mbox.TestMbox.test_commit_message_presence)

PASS: pretest pylint (test_python_pylint.PyLint.pretest_pylint)
PASS: test Signed-off-by presence 
(test_mbox.TestMbox.test_signed_off_by_presence)
PASS: test author valid (test_mbox.TestMbox.test_author_valid)
PASS: test max line length (test_metadata.TestMetadata.test_max_line_length)
PASS: test mbox format (test_mbox.TestMbox.test_mbox_format)
PASS: test non-AUH upgrade (test_mbox.TestMbox.test_non_auh_upgrade)
PASS: test pylint (test_python_pylint.PyLint.test_pylint)
PASS: test shortlog format (test_mbox.TestMbox.test_shortlog_format)
PASS: test shortlog length (test_mbox.TestMbox.test_shortlog_length)

SKIP: pretest src uri left files: No modified recipes, skipping pretest 
(test_metadata.TestMetadata.pretest_src_uri_left_files)
SKIP: test CVE check ignore: No modified recipes, skipping test 
(test_metadata.TestMetadata.test_cve_check_ignore)
SKIP: test CVE tag format: No new CVE patches introduced 
(test_patch.TestPatch.test_cve_tag_format)
SKIP: test Signed-off-by presence: No new CVE patches introduced 
(test_patch.TestPatch.test_signed_off_by_presence)
SKIP: test Upstream-Status presence: No new CVE patches introduced 
(test_patch.TestPatch.test_upstream_status_presence_format)
SKIP: test bugzilla entry format: No bug ID found 
(test_mbox.TestMbox.test_bugzilla_entry_format)
SKIP: test lic files chksum modified not mentioned: No modified recipes, 
skipping test 
(test_metadata.TestMetadata.test_lic_files_chksum_modified_not_mentioned)
SKIP: test lic files chksum presence: No added recipes, skipping test 
(test_metadata.TestMetadata.test_lic_files_chksum_presence)
SKIP: test license presence: No added recipes, skipping test 
(test_metadata.TestMetadata.test_license_presence)
SKIP: test series merge on head: Merge test is disabled for now 
(test_mbox.TestMbox.test_series_merge_on_head)
SKIP: test src uri left files: No modified recipes, skipping pretest 
(test_metadata.TestMetadata.test_src_uri_left_files)
SKIP: test summary presence: No added recipes, skipping test 
(test_metadata.TestMetadata.test_summary_presence)
SKIP: test target mailing list: Series merged, no reason to check other mailing 
lists (test_mbox.TestMbox.test_target_mailing_list)

---

Please address the issues identified and
submit a new revision of the patch, or alternatively, reply to this
email with an explanation of why the patch should be accepted. If you
believe these results are due to an error in patchtest, please submit a
bug at https://bugzilla.yoctoproject.org/ (use the 'Patchtest' category
under 'Yocto Project Subprojects'). For more information on specific
failures, see: https://wiki.yoctoproject.org/wiki/Patchtest. Thank
you!

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#193837): 
https://lists.openembedded.org/g/openembedded-core/message/193837
Mute This Topic: https://lists.openembedded.org/mt/103758512/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH 1/3] recipetool: Don't fail on local go modules

2024-01-16 Thread Vyacheslav Yurkov

On 10.01.2024 16:45, Lukas Funke wrote:

On 10.01.2024 14:59, Richard Purdie wrote:

On Wed, 2024-01-10 at 12:53 +0100, Vyacheslav Yurkov wrote:

Local modules are usually referenced with a 'replace' directive in
go.mod file. If that's the case, remove them from populating SRC_URI.

Signed-off-by: Vyacheslav Yurkov 
---
  scripts/lib/recipetool/create_go.py | 32 
+

  1 file changed, 19 insertions(+), 13 deletions(-)


Do these changes mean we need to improve the test coverage in oe-
selftest for recipetool?


Test converage needs improvement, yes. I haven't considered the case 
for local modules since this seems to be rare(?). Are there public 
projects which use this mechanism?


Best regards
Lukas



I added coverage for local modules in my v2.

I'm not a golang expert, but it seems that local modules in golang is a 
means to "place a patched version into the project space until upstream 
fixes it" more or less like Yocto does with Upstream patches. It's used 
a lot by in-house projects, but you could also get a glimpse on github 
with this query 
https://github.com/search?q=path%3A%2Fgo.mod+NOT+is%3Afork+content%3A%2F%5Ereplace+.*%2F&type=code&query=content%3Ago.mod+replace&p=3 
. Note, Github is able to display only first 100 search results (Github 
API restriction).


One thing I don't like in my v2 is that I need to look up a public 
project to add required coverage. I would rather improve tests further 
by having everything in one repository and just one test, i.e. it has to 
be a small test project that could be used to test all go-related 
functionality. The question is though where it should be placed? I could 
create it on my Github account, but would that be a good option?


Richard, any suggestions on where these projects for selftest coverage 
should be hosted?


Slava

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#193836): 
https://lists.openembedded.org/g/openembedded-core/message/193836
Mute This Topic: https://lists.openembedded.org/mt/103639058/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] "ptest-pkgs" image feature misses ptest package dependencies due to COMPLEMENTARY_GLOB ignoring all RRECOMMENDS

2024-01-16 Thread Alexander Kanavin
Yes, ptest-pkgs is not tested anywhere, and so isn't guaranteed to
work. But if you can fix it, that'd be welcome.

Alex

On Tue, 16 Jan 2024 at 01:07, Lyu, William via lists.openembedded.org
 wrote:
>
> When I try to build a core-image-minimal image with ptest for openssl 
> installed using the following conf/local.conf modifications, the 
> openssl-ptest is installed but with missing runtime dependencies.
>
> DISTRO_FEATURES:append = " ptest"
> EXTRA_IMAGE_FEATURES += " ptest-pkgs"
> PTEST_ENABLED = "1"
> IMAGE_INSTALL:append = " openssl"
>
> When I boot the image and try to run the ptest for openssl, I get the 
> following error complaining about missing dependencies in the output:
>
> # ptest-runner openssl -t 3000
> BEGIN: /usr/lib/openssl/ptest
> Can't locate File/Spec/Functions.pm in @INC ...
> ...
>
> This error is due to package perl-module-file-spec-functions, along with some 
> other perl-module-* packages, not being installed - these packages are 
> missing in the .manifest file in the directory containing the built image. 
> The dependency for these packages is as follows.
>
> openssl-ptest --(RDEPENDS)--> perl-modules --(RRECOMMENDS)--> 
> perl-module-file-spec-functions
>\-(RRECOMMENDS)--> some other 
> perl-module-* packages
>
> "ptest-pkgs" along with various other image features are defined as 
> COMPLEMENTARY_GLOB in meta/classes-recipe/populate_sdk_base.bbclass in 
> openembedded-core:
>
> COMPLEMENTARY_GLOB[ptest-pkgs] = '*-ptest ${MLPREFIX}ptest-runner'
>
> Following this patch to package_manager referenced by link 
> https://lists.openembedded.org/g/openembedded-core/message/167303, recommends 
> relationships (set via RRECOMMENDS) are always ignored when installing 
> complementary packages [1]. This causes the necessary runtime dependencies 
> for openssl-ptest not being installed. I am not sure if this issue only 
> pertains to openssl-ptest.
>
> Note that, if I follow the alternative "more selective" [2] way to include 
> the tests (see the following sample conf/local.conf), I can properly install 
> openssl-ptest with all dependencies, as openssl-ptest is now explicitly 
> declared as package-to-be-installed instead of implicitly discovered via the 
> COMPLEMENTARY_GLOB "ptest-pkgs". I would say that this means that 
> "ptest-pkgs" is not very robust to use.
>
> DISTRO_FEATURES:append = " ptest"
> PTEST_ENABLED = "1"
> IMAGE_INSTALL:append = " openssl openssl-ptest"
>
> [1] 
> https://docs.yoctoproject.org/dev/ref-manual/variables.html#term-COMPLEMENTARY_GLOB
> [2] https://wiki.yoctoproject.org/wiki/Ptest#Adding_ptest_to_your_build
>
> William
>
>
> 
>

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#193835): 
https://lists.openembedded.org/g/openembedded-core/message/193835
Mute This Topic: https://lists.openembedded.org/mt/103752398/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH v2] libtest-warnings-perl: upgrade 0.031 -> 0.032

2024-01-16 Thread Alexander Kanavin
Thanks!

Alex

On Tue, 16 Jan 2024 at 00:55, wangmy  wrote:
>
> From: Wang Mingyu 
>
> License-Update:
>  basic artistic license changed to perl artistic license.
>
> Signed-off-by: Wang Mingyu 
> ---
>  ...ings-perl_0.031.bb => libtest-warnings-perl_0.032.bb} | 9 +++--
>  1 file changed, 3 insertions(+), 6 deletions(-)
>  rename meta/recipes-devtools/perl/{libtest-warnings-perl_0.031.bb => 
> libtest-warnings-perl_0.032.bb} (78%)
>
> diff --git a/meta/recipes-devtools/perl/libtest-warnings-perl_0.031.bb 
> b/meta/recipes-devtools/perl/libtest-warnings-perl_0.032.bb
> similarity index 78%
> rename from meta/recipes-devtools/perl/libtest-warnings-perl_0.031.bb
> rename to meta/recipes-devtools/perl/libtest-warnings-perl_0.032.bb
> index e03deaf15f..5876e8a63c 100644
> --- a/meta/recipes-devtools/perl/libtest-warnings-perl_0.031.bb
> +++ b/meta/recipes-devtools/perl/libtest-warnings-perl_0.032.bb
> @@ -1,6 +1,3 @@
> -# Copyright (C) 2020 Jens Rehsack 
> -# Released under the MIT license (see COPYING.MIT for the terms)
> -
>  SUMMARY = "Test::Warnings - Test for warnings and the lack of them"
>  DESCRIPTION = "If you've ever tried to use Test::NoWarnings to confirm there 
> are no \
>  warnings generated by your tests, combined with the convenience of \
> @@ -12,13 +9,13 @@ demonstration.)"
>  HOMEPAGE = "https://github.com/karenetheridge/Test-Warnings";
>  BUGTRACKER = 
> "https://rt.cpan.org/Public/Dist/Display.html?Name=Test-Warnings";
>  SECTION = "libs"
> -LICENSE = "Artistic-1.0 | GPL-1.0-or-later"
> +LICENSE = "Artistic-1.0-Perl | GPL-1.0-or-later"
>
> -LIC_FILES_CHKSUM = "file://LICENCE;md5=6f2b02f39e7d359efd9525fbc56c84a1"
> +LIC_FILES_CHKSUM = "file://LICENCE;md5=f98106ac3cc05d9cbebcdb8fbf7b7815"
>
>  SRC_URI = "${CPAN_MIRROR}/authors/id/E/ET/ETHER/Test-Warnings-${PV}.tar.gz"
>
> -SRC_URI[sha256sum] = 
> "1e542909fef305e45563e9878ea1c3b0c7cef1b28bb7ae07eba2e1efabec477b"
> +SRC_URI[sha256sum] = 
> "4727dae2416e9f07e41e2dc3a9143ba6affc1ec57652117c99d50038e313e9d9"
>
>  S = "${WORKDIR}/Test-Warnings-${PV}"
>
> --
> 2.34.1
>
>
> 
>

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#193834): 
https://lists.openembedded.org/g/openembedded-core/message/193834
Mute This Topic: https://lists.openembedded.org/mt/103752132/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH v2] python3-subunit: upgrade 1.4.2 -> 1.4.4

2024-01-16 Thread Alexander Kanavin
Thanks, looks good!

Alex

On Tue, 16 Jan 2024 at 00:54, wangmy  wrote:
>
> From: Wang Mingyu 
>
> License-Update:
>  change License file to COPYING.
>  add BSD-3-Clause to LICENSE
>
> Changelog:
> ===
> * Removed use of deprecated "utc" and "utcfromtimestamp"
>   methods of "datetime.datetime".
> * Fix an issue with date parsing exception handling
> * Add support for Python 3.12
>
> Signed-off-by: Wang Mingyu 
> ---
>  .../{python3-subunit_1.4.2.bb => python3-subunit_1.4.4.bb}  | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>  rename meta/recipes-devtools/python/{python3-subunit_1.4.2.bb => 
> python3-subunit_1.4.4.bb} (55%)
>
> diff --git a/meta/recipes-devtools/python/python3-subunit_1.4.2.bb 
> b/meta/recipes-devtools/python/python3-subunit_1.4.4.bb
> similarity index 55%
> rename from meta/recipes-devtools/python/python3-subunit_1.4.2.bb
> rename to meta/recipes-devtools/python/python3-subunit_1.4.4.bb
> index a018ef1dc8..db5fecf921 100644
> --- a/meta/recipes-devtools/python/python3-subunit_1.4.2.bb
> +++ b/meta/recipes-devtools/python/python3-subunit_1.4.4.bb
> @@ -1,12 +1,12 @@
>  SUMMARY = "Python implementation of subunit test streaming protocol"
>  HOMEPAGE = "https://pypi.org/project/python-subunit/";
>  SECTION = "devel/python"
> -LICENSE = "Apache-2.0"
> -LIC_FILES_CHKSUM = 
> "file://README.rst;beginline=1;endline=20;md5=909c08e291647fd985fbe5d9836d51b6"
> +LICENSE = "Apache-2.0 | BSD-3-Clause"
> +LIC_FILES_CHKSUM = 
> "file://COPYING;beginline=1;endline=20;md5=b1121e68d06c8d9ea544fcd895df0d39"
>
>  PYPI_PACKAGE = "python-subunit"
>
> -SRC_URI[sha256sum] = 
> "2988d324d55ec35dd037e502e3f74ac38f4e457bd44ee0edf5e898f7ee1134d4"
> +SRC_URI[sha256sum] = 
> "1079363131aa1d3f45259237265bc2e61a77e35f20edfb6e3d1d2558a2cdea34"
>
>  inherit pypi setuptools3
>
> --
> 2.34.1
>
>
> 
>

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#193833): 
https://lists.openembedded.org/g/openembedded-core/message/193833
Mute This Topic: https://lists.openembedded.org/mt/103752116/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH v2 9/9] oeqa/selftest/recipetool: Add test coverage for local go modules

2024-01-16 Thread Vyacheslav Yurkov
Signed-off-by: Vyacheslav Yurkov 
---
 meta/lib/oeqa/selftest/cases/recipetool.py | 55 ++
 1 file changed, 55 insertions(+)

diff --git a/meta/lib/oeqa/selftest/cases/recipetool.py 
b/meta/lib/oeqa/selftest/cases/recipetool.py
index 83848d6170..0c296875b2 100644
--- a/meta/lib/oeqa/selftest/cases/recipetool.py
+++ b/meta/lib/oeqa/selftest/cases/recipetool.py
@@ -927,6 +927,61 @@ class RecipetoolCreateTests(RecipetoolBase):
 self.assertTrue(os.path.isfile(deps_require_file))
 self._test_recipe_contents(deps_require_file, checkvars, [])
 
+def test_recipetool_create_go_replace_modules(self):
+# Check handling of replaced modules
+temprecipe = os.path.join(self.tempdir, 'recipe')
+os.makedirs(temprecipe)
+
+recipefile = os.path.join(temprecipe, 'openapi-generator_git.bb')
+deps_require_file = os.path.join(temprecipe, 'openapi-generator', 
'go-modules.inc')
+lics_require_file = os.path.join(temprecipe, 'openapi-generator', 
'go-licenses.inc')
+modules_txt_file = os.path.join(temprecipe, 'openapi-generator', 
'modules.txt')
+
+srcuri = 'https://github.com/OpenAPITools/openapi-generator.git'
+srcrev = "v7.2.0"
+srcbranch = "master"
+srcsubdir = "samples/openapi3/client/petstore/go"
+
+result = runCmd('recipetool create -o %s %s -S %s -B %s --src-subdir 
%s' % (temprecipe, srcuri, srcrev, srcbranch, srcsubdir))
+
+self.maxDiff = None
+inherits = ['go-vendor']
+
+checkvars = {}
+checkvars['GO_IMPORT'] = 
"github.com/OpenAPITools/openapi-generator/samples/openapi3/client/petstore/go"
+checkvars['SRC_URI'] = 
{'git://${GO_IMPORT};destsuffix=git/src/${GO_IMPORT};nobranch=1;name=${BPN};protocol=https',
+'file://modules.txt'}
+
+self.assertNotIn('Traceback', result.output)
+self.assertIn('No license file was detected for the main module', 
result.output)
+self.assertTrue(os.path.isfile(recipefile))
+self._test_recipe_contents(recipefile, checkvars, inherits)
+
+# make sure that dependencies don't mention local directory 
./go-petstore
+dependencies = \
+[   ('github.com/stretchr/testify','v1.8.4', '', '', ''),
+('go.googlesource.com/oauth2','v0.10.0','golang.org/x/oauth2', 
'', ''),
+('github.com/davecgh/go-spew','v1.1.1', '', '', ''),
+('github.com/golang/protobuf','v1.5.3', '', '', ''),
+('github.com/kr/pretty','v0.3.0', '', '', ''),
+('github.com/pmezard/go-difflib','v1.0.0', '', '', ''),
+('github.com/rogpeppe/go-internal','v1.9.0', '', '', ''),
+('go.googlesource.com/net','v0.12.0','golang.org/x/net', '', 
''),
+
('github.com/golang/appengine','v1.6.7','google.golang.org/appengine', '', ''),
+
('go.googlesource.com/protobuf','v1.31.0','google.golang.org/protobuf', '', ''),
+('gopkg.in/check.v1','v1.0.0-20201130134442-10cb98267c6c', '', 
'', ''),
+('gopkg.in/yaml.v3','v3.0.1', '', '', ''),
+]
+
+src_uri = set()
+for d in dependencies:
+src_uri.add(self._go_urifiy(*d))
+
+checkvars = {}
+checkvars['GO_DEPENDENCIES_SRC_URI'] = src_uri
+
+self.assertTrue(os.path.isfile(deps_require_file))
+self._test_recipe_contents(deps_require_file, checkvars, [])
 
 class RecipetoolTests(RecipetoolBase):
 
-- 
2.35.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#193832): 
https://lists.openembedded.org/g/openembedded-core/message/193832
Mute This Topic: https://lists.openembedded.org/mt/103758372/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH v2 7/9] oeqa/selftest/recipetool: Move create_go test to a proper class

2024-01-16 Thread Vyacheslav Yurkov
Signed-off-by: Vyacheslav Yurkov 
---
 meta/lib/oeqa/selftest/cases/recipetool.py | 24 ++
 1 file changed, 11 insertions(+), 13 deletions(-)

diff --git a/meta/lib/oeqa/selftest/cases/recipetool.py 
b/meta/lib/oeqa/selftest/cases/recipetool.py
index df15c80069..356bb4a746 100644
--- a/meta/lib/oeqa/selftest/cases/recipetool.py
+++ b/meta/lib/oeqa/selftest/cases/recipetool.py
@@ -744,19 +744,6 @@ class RecipetoolCreateTests(RecipetoolBase):
 def test_recipetool_create_git_srcbranch(self):
 
self._test_recipetool_create_git('git://git.yoctoproject.org/matchbox-keyboard;protocol=https',
 'matchbox-keyboard-0-1')
 
-
-class RecipetoolTests(RecipetoolBase):
-
-@classmethod
-def setUpClass(cls):
-import sys
-
-super(RecipetoolTests, cls).setUpClass()
-bb_vars = get_bb_vars(['BBPATH'])
-cls.bbpath = bb_vars['BBPATH']
-libpath = os.path.join(get_bb_var('COREBASE'), 'scripts', 'lib', 
'recipetool')
-sys.path.insert(0, libpath)
-
 def test_recipetool_create_go(self):
 # Basic test to check go recipe generation
 def urifiy(url, version, modulepath = None, pathmajor = None, subdir = 
None):
@@ -941,6 +928,17 @@ class RecipetoolTests(RecipetoolBase):
 self._test_recipe_contents(deps_require_file, checkvars, [])
 
 
+class RecipetoolTests(RecipetoolBase):
+
+@classmethod
+def setUpClass(cls):
+import sys
+
+super(RecipetoolTests, cls).setUpClass()
+bb_vars = get_bb_vars(['BBPATH'])
+cls.bbpath = bb_vars['BBPATH']
+libpath = os.path.join(get_bb_var('COREBASE'), 'scripts', 'lib', 
'recipetool')
+sys.path.insert(0, libpath)
 
 def _copy_file_with_cleanup(self, srcfile, basedstdir, *paths):
 dstdir = basedstdir
-- 
2.35.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#193830): 
https://lists.openembedded.org/g/openembedded-core/message/193830
Mute This Topic: https://lists.openembedded.org/mt/103758370/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH v2 8/9] oeqa/selftest/recipetool: Move helper function to the class scope

2024-01-16 Thread Vyacheslav Yurkov
Signed-off-by: Vyacheslav Yurkov 
---
 meta/lib/oeqa/selftest/cases/recipetool.py | 14 +++---
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/meta/lib/oeqa/selftest/cases/recipetool.py 
b/meta/lib/oeqa/selftest/cases/recipetool.py
index 356bb4a746..83848d6170 100644
--- a/meta/lib/oeqa/selftest/cases/recipetool.py
+++ b/meta/lib/oeqa/selftest/cases/recipetool.py
@@ -744,14 +744,14 @@ class RecipetoolCreateTests(RecipetoolBase):
 def test_recipetool_create_git_srcbranch(self):
 
self._test_recipetool_create_git('git://git.yoctoproject.org/matchbox-keyboard;protocol=https',
 'matchbox-keyboard-0-1')
 
+def _go_urifiy(self, url, version, modulepath = None, pathmajor = None, 
subdir = None):
+modulepath = ",path='%s'" % modulepath if len(modulepath) else ''
+pathmajor = ",pathmajor='%s'" % pathmajor if len(pathmajor) else ''
+subdir = ",subdir='%s'" % subdir if len(subdir) else ''
+return "${@go_src_uri('%s','%s'%s%s%s)}" % (url, version, modulepath, 
pathmajor, subdir)
+
 def test_recipetool_create_go(self):
 # Basic test to check go recipe generation
-def urifiy(url, version, modulepath = None, pathmajor = None, subdir = 
None):
-modulepath = ",path='%s'" % modulepath if len(modulepath) else ''
-pathmajor = ",pathmajor='%s'" % pathmajor if len(pathmajor) else ''
-subdir = ",subdir='%s'" % subdir if len(subdir) else ''
-return "${@go_src_uri('%s','%s'%s%s%s)}" % (url, version, 
modulepath, pathmajor, subdir)
-
 temprecipe = os.path.join(self.tempdir, 'recipe')
 os.makedirs(temprecipe)
 
@@ -919,7 +919,7 @@ class RecipetoolCreateTests(RecipetoolBase):
 
 src_uri = set()
 for d in dependencies:
-src_uri.add(urifiy(*d))
+src_uri.add(self._go_urifiy(*d))
 
 checkvars = {}
 checkvars['GO_DEPENDENCIES_SRC_URI'] = src_uri
-- 
2.35.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#193831): 
https://lists.openembedded.org/g/openembedded-core/message/193831
Mute This Topic: https://lists.openembedded.org/mt/103758371/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH v2 6/9] recipetool: Disregard version in URL for replaced modules

2024-01-16 Thread Vyacheslav Yurkov
Major module version is a part of name, but not necessary part of the
actual URL (See https://go.dev/ref/mod#module-path).

Nevertheless, name detection function can't handle that suffix, so get
rid of it to determine component name.

For replaced modules that name might be different that the actual module
name defined in go.mod file.

Signed-off-by: Vyacheslav Yurkov 
---
 scripts/lib/recipetool/create_go.py | 22 +-
 1 file changed, 17 insertions(+), 5 deletions(-)

diff --git a/scripts/lib/recipetool/create_go.py 
b/scripts/lib/recipetool/create_go.py
index 035ab9f7c1..c560831442 100644
--- a/scripts/lib/recipetool/create_go.py
+++ b/scripts/lib/recipetool/create_go.py
@@ -506,6 +506,7 @@ class GoRecipeHandler(RecipeHandler):
 
 def __go_handle_dependencies(self, go_mod, srctree, localfilesdir, 
extravalues, d):
 
+import re
 src_uris = []
 src_revs = []
 
@@ -555,7 +556,9 @@ class GoRecipeHandler(RecipeHandler):
 src_uris.append(inline_fcn)
 src_revs.append(generate_src_rev(path, version, commithash))
 
-pn, _ = determine_from_url(go_mod['Module']['Path'])
+# strip version part from module URL /vXX
+baseurl = re.sub(r'/v(\d+)$', '', go_mod['Module']['Path'])
+pn, _ = determine_from_url(baseurl)
 go_mods_basename = "%s-modules.inc" % pn
 
 go_mods_filename = os.path.join(localfilesdir, go_mods_basename)
@@ -636,7 +639,9 @@ class GoRecipeHandler(RecipeHandler):
 lic_files_chksum.append(
 'file://src/${GO_IMPORT}/vendor/%s;md5=%s' % (licvalue[1], 
licvalue[2]))
 
-pn, _ = determine_from_url(go_mod['Module']['Path'])
+# strip version part from module URL /vXX
+baseurl = re.sub(r'/v(\d+)$', '', go_mod['Module']['Path'])
+pn, _ = determine_from_url(baseurl)
 licenses_basename = "%s-licenses.inc" % pn
 
 licenses_filename = os.path.join(localfilesdir, licenses_basename)
@@ -682,6 +687,13 @@ class GoRecipeHandler(RecipeHandler):
 
 localfilesdir = tempfile.mkdtemp(prefix='recipetool-go-')
 extravalues.setdefault('extrafiles', {})
+
+# Use an explicit name determined from the module name because it
+# might differ from the actual URL for replaced modules
+# strip version part from module URL /vXX
+baseurl = re.sub(r'/v(\d+)$', '', go_mod['Module']['Path'])
+pn, _ = determine_from_url(baseurl)
+
 # go.mod files with version < 1.17 may not include all indirect
 # dependencies. Thus, we have to upgrade the go version.
 if go_version_major == 1 and go_version_minor < 17:
@@ -699,18 +711,18 @@ class GoRecipeHandler(RecipeHandler):
 # Write additional $BPN-modules.inc file
 self.__go_mod_vendor(go_mod, srctree, localfilesdir, extravalues, 
d)
 lines_before.append("LICENSE += \" & ${GO_MOD_LICENSES}\"")
-lines_before.append("require ${BPN}-licenses.inc")
+lines_before.append("require %s-licenses.inc" % (pn))
 
 self.__rewrite_src_uri(lines_before, ["file://modules.txt"])
 
 self.__go_handle_dependencies(go_mod, srctree, localfilesdir, 
extravalues, d)
-lines_before.append("require ${BPN}-modules.inc")
+lines_before.append("require %s-modules.inc" % (pn))
 
 # Do generic license handling
 handle_license_vars(srctree, lines_before, handled, extravalues, d)
 self.__rewrite_lic_uri(lines_before)
 
-lines_before.append("GO_IMPORT = \"{}\"".format(go_import))
+lines_before.append("GO_IMPORT = \"{}\"".format(baseurl))
 lines_before.append("SRCREV_FORMAT = \"${BPN}\"")
 
 def __update_lines_before(self, updated, newlines, lines_before):
-- 
2.35.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#193829): 
https://lists.openembedded.org/g/openembedded-core/message/193829
Mute This Topic: https://lists.openembedded.org/mt/103758369/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH v2 5/9] recipetool: Proceed even with a missing license file

2024-01-16 Thread Vyacheslav Yurkov
Whenever the recipe uses a CLOSED license, the list is going to be
empty. It's a discouraged practice not to have a license, but proceed
anyway to finish recipe generation.

Signed-off-by: Vyacheslav Yurkov 
---
 scripts/lib/recipetool/create_go.py | 6 ++
 1 file changed, 6 insertions(+)

diff --git a/scripts/lib/recipetool/create_go.py 
b/scripts/lib/recipetool/create_go.py
index 668a24b8dd..035ab9f7c1 100644
--- a/scripts/lib/recipetool/create_go.py
+++ b/scripts/lib/recipetool/create_go.py
@@ -730,6 +730,12 @@ class GoRecipeHandler(RecipeHandler):
 new_licenses = []
 licenses = origvalue.split('\\')
 for license in licenses:
+if not license:
+logger.warning("No license file was detected for the 
main module!")
+# the license list of the main recipe must be empty
+# this can happen for example in case of CLOSED license
+# Fall through to complete recipe generation
+continue
 license = license.strip()
 uri, chksum = license.split(';', 1)
 url = urllib.parse.urlparse(uri)
-- 
2.35.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#193828): 
https://lists.openembedded.org/g/openembedded-core/message/193828
Mute This Topic: https://lists.openembedded.org/mt/103758368/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH v2 4/9] classes: go-vendor: Unlink vendor dir later

2024-01-16 Thread Vyacheslav Yurkov
Vendor directory might still be required during install stage, so defer
the removal until later stage.

Signed-off-by: Vyacheslav Yurkov 
---
 meta/classes/go-vendor.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes/go-vendor.bbclass b/meta/classes/go-vendor.bbclass
index 48f4d1041c..1bbb99ac79 100644
--- a/meta/classes/go-vendor.bbclass
+++ b/meta/classes/go-vendor.bbclass
@@ -48,7 +48,7 @@ python do_vendor_unlink() {
 os.unlink(linkname)
 }
 
-addtask vendor_unlink before do_install after do_compile
+addtask vendor_unlink before do_package after do_install
 
 python do_go_vendor() {
 import shutil
-- 
2.35.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#193827): 
https://lists.openembedded.org/g/openembedded-core/message/193827
Mute This Topic: https://lists.openembedded.org/mt/103758367/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH v2 3/9] classes: go-vendor: Handle modules from the same repo

2024-01-16 Thread Vyacheslav Yurkov
Take into account module version when populating vendor directory,
because a module with the same URL but with a different version tag
could be used as an indirect dependency.

Signed-off-by: Vyacheslav Yurkov 
---
 meta/classes/go-vendor.bbclass | 9 -
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/meta/classes/go-vendor.bbclass b/meta/classes/go-vendor.bbclass
index b965428dd1..48f4d1041c 100644
--- a/meta/classes/go-vendor.bbclass
+++ b/meta/classes/go-vendor.bbclass
@@ -103,18 +103,17 @@ python do_go_vendor() {
 pathMajor = fetcher.ud[url].parm.get('go_pathmajor')
 pathMajor = None if not pathMajor else pathMajor.strip('/')
 
-if not repo in modules:
-modules[repo] =   { "version": version,
+if not (repo, version) in modules:
+modules[(repo, version)] =   {
 "repo_path": os.path.join(import_dir, p),
 "module_path": module_path,
 "subdir": subdir,
 "pathMajor": pathMajor }
 
-for module_key in sorted(modules):
+for module_key, module in modules.items():
 
 # only take the version which is explicitly listed
 # as a dependency in the go.mod
-module = modules[module_key]
 module_path = module['module_path']
 rootdir = module['repo_path']
 subdir = module['subdir']
@@ -139,7 +138,7 @@ python do_go_vendor() {
 dst = os.path.join(vendor_dir, module_path)
 
 bb.debug(1, "cp %s --> %s" % (src, dst))
-shutil.copytree(src, dst, symlinks=True, \
+shutil.copytree(src, dst, symlinks=True, dirs_exist_ok=True, \
 ignore=shutil.ignore_patterns(".git", \
 "vendor", \
 "*._test.go"))
-- 
2.35.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#193826): 
https://lists.openembedded.org/g/openembedded-core/message/193826
Mute This Topic: https://lists.openembedded.org/mt/103758366/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH v2 1/9] recipetool: Don't fail on local go modules

2024-01-16 Thread Vyacheslav Yurkov
Local modules are usually referenced with a 'replace' directive in
go.mod file. If that's the case, remove them from populating SRC_URI.

Signed-off-by: Vyacheslav Yurkov 
---
 scripts/lib/recipetool/create_go.py | 36 ++---
 1 file changed, 23 insertions(+), 13 deletions(-)

diff --git a/scripts/lib/recipetool/create_go.py 
b/scripts/lib/recipetool/create_go.py
index 21dcb41271..668a24b8dd 100644
--- a/scripts/lib/recipetool/create_go.py
+++ b/scripts/lib/recipetool/create_go.py
@@ -504,7 +504,7 @@ class GoRecipeHandler(RecipeHandler):
 
 return inline_fcn, commit
 
-def __go_handle_dependencies(self, go_mod, localfilesdir, extravalues, d):
+def __go_handle_dependencies(self, go_mod, srctree, localfilesdir, 
extravalues, d):
 
 src_uris = []
 src_revs = []
@@ -525,6 +525,27 @@ class GoRecipeHandler(RecipeHandler):
 
 return src_rev
 
+# we first go over replacement list, because we are essentialy
+# interested only in the replaced path
+if go_mod['Replace']:
+for replacement in go_mod['Replace']:
+oldpath = replacement['Old']['Path']
+path = replacement['New']['Path']
+version = ''
+if 'Version' in replacement['New']:
+version = replacement['New']['Version']
+
+if os.path.exists(os.path.join(srctree, path)):
+# the module refers to the local path, remove it from 
requirement list
+# because it's a local module
+go_mod['Require'][:] = [v for v in go_mod['Require'] if 
v.get('Path') != oldpath]
+else:
+# Replace the path and the version, so we don't iterate 
replacement list anymore
+for require in go_mod['Require']:
+if require['Path'] == oldpath:
+require.update({'Path': path, 'Version': version})
+break
+
 for require in go_mod['Require']:
 path = require['Path']
 version = require['Version']
@@ -534,17 +555,6 @@ class GoRecipeHandler(RecipeHandler):
 src_uris.append(inline_fcn)
 src_revs.append(generate_src_rev(path, version, commithash))
 
-if go_mod['Replace']:
-for replacement in go_mod['Replace']:
-oldpath = replacement['Old']['Path']
-path = replacement['New']['Path']
-version = replacement['New']['Version']
-
-inline_fcn, commithash = self.__generate_srcuri_inline_fcn(
-path, version, oldpath)
-src_uris.append(inline_fcn)
-src_revs.append(generate_src_rev(path, version, commithash))
-
 pn, _ = determine_from_url(go_mod['Module']['Path'])
 go_mods_basename = "%s-modules.inc" % pn
 
@@ -693,7 +703,7 @@ class GoRecipeHandler(RecipeHandler):
 
 self.__rewrite_src_uri(lines_before, ["file://modules.txt"])
 
-self.__go_handle_dependencies(go_mod, localfilesdir, extravalues, 
d)
+self.__go_handle_dependencies(go_mod, srctree, localfilesdir, 
extravalues, d)
 lines_before.append("require ${BPN}-modules.inc")
 
 # Do generic license handling
-- 
2.35.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#193824): 
https://lists.openembedded.org/g/openembedded-core/message/193824
Mute This Topic: https://lists.openembedded.org/mt/103758364/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH v2 2/9] classes: go-vendor: Reference local modules

2024-01-16 Thread Vyacheslav Yurkov
Create symlinks for local modules, which are usually not referenced in
the SRC_URI, but still expected to be found in the vendor directory
during the build.

Signed-off-by: Vyacheslav Yurkov 
---
 meta/classes/go-vendor.bbclass | 18 +-
 1 file changed, 17 insertions(+), 1 deletion(-)

diff --git a/meta/classes/go-vendor.bbclass b/meta/classes/go-vendor.bbclass
index 2426bddfba..b965428dd1 100644
--- a/meta/classes/go-vendor.bbclass
+++ b/meta/classes/go-vendor.bbclass
@@ -169,6 +169,7 @@ python do_go_vendor() {
 fetched_paths.remove('.')
 
 vendored_paths = set()
+replaced_paths = dict()
 with open(modules_txt_src) as f:
 for line in f:
 if not line.startswith("#"):
@@ -182,6 +183,15 @@ python do_go_vendor() {
 vendored_paths.add(topdir)
 
 topdir = os.path.dirname(topdir)
+else:
+replaced_module = line.split("=>")
+if len(replaced_module) > 1:
+# This module has been replaced, use a local path
+# we parse the line that has a pattern "# module-name 
[module-version] => local-path
+actual_path = replaced_module[1].strip()
+vendored_name = replaced_module[0].split()[1]
+bb.debug(1, "added vendored name %s for actual path %s" % 
(vendored_name, actual_path))
+replaced_paths[vendored_name] = actual_path
 
 for path in fetched_paths:
 if path not in vendored_paths:
@@ -189,7 +199,13 @@ python do_go_vendor() {
 if os.path.exists(realpath):
 shutil.rmtree(realpath)
 
-# Create a symlink the the actual directory
+for vendored_name, replaced_path in replaced_paths.items():
+symlink_target = os.path.join(source_dir, *['src', go_import, 
replaced_path])
+symlink_name = os.path.join(vendor_dir, vendored_name)
+bb.debug(1, "vendored name %s, symlink name %s" % (vendored_name, 
symlink_name))
+os.symlink(symlink_target, symlink_name)
+
+# Create a symlink to the actual directory
 os.symlink(vendor_dir, linkname)
 }
 
-- 
2.35.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#193825): 
https://lists.openembedded.org/g/openembedded-core/message/193825
Mute This Topic: https://lists.openembedded.org/mt/103758365/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-