Re: [OE-core] Remove oprofileui-server
Hi Richard, On Fri, Sep 4, 2015 at 5:17 PM, Richard Purdie wrote: > On Fri, 2015-09-04 at 16:59 +0100, Burton, Ross wrote: >> On 4 September 2015 at 10:05, Felipe Tonello >> wrote: >> oprofileui-server is obsolete since it uses legacy OProfile's >> 'opcontrol' commands to record a session, instead of operf. >> It >> doesn't work on fido builds. >> > >> Anyone familiar with the code base can tell if it is too much >> work to >> update it to use operf? >> >> Yes, its known that it's broken (bug 7054). >> >> It hopefully isn't too much work to update it, > > It just needs someone with some glib knowledge to look at it, its > straight forward enough. I did get part way through it before realising > my glib knowledge is lacking (conversion of some sync code to become > async) and I haven't had the time :(. I will try to find the time to take a look in the next few weeks. Felipe -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
[OE-core] Remove oprofileui-server
Hi, oprofileui-server is obsolete since it uses legacy OProfile's 'opcontrol' commands to record a session, instead of operf. It doesn't work on fido builds. Anyone familiar with the code base can tell if it is too much work to update it to use operf? Felipe -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH] psplash: Show psplash before X in reboot/shutdown process
Ok. But wouldn't be necessary in this case? Also, this patch is inappropriate without a patch for X. So I would suggest to ignore this patch for now. Felipe On Mon, Oct 28, 2013 at 11:31 AM, Otavio Salvador wrote: > On Mon, Oct 28, 2013 at 4:22 PM, wrote: >> From: "Felipe F. Tonello" >> >> This is interesting because if you shutdown/reboot a device the screen will >> flicker because X will be killed and then psplash will take a while to run. >> >> Signed-off-by: Felipe F. Tonello > ... >> SRCREV = "afd4e228c606a9998feae44a3fed4474803240b7" >> PV = "0.1+git${SRCPV}" >> -PR = "r15" >> +PR = "r16" > ... > > Please don't do PR bumps. > > -- > Otavio Salvador O.S. Systems > http://www.ossystems.com.brhttp://code.ossystems.com.br > Mobile: +55 (53) 9981-7854Mobile: +1 (347) 903-9750 ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH v2] valgrind: added perl dependency
Hum, I didn't noticed. Sorry. I will send another patch. On Tue, Jul 16, 2013 at 3:54 PM, Saul Wold wrote: > On 07/16/2013 03:16 PM, e...@felipetonello.com wrote: >> >> From: "Felipe F. Tonello" >> >> This is necessary since the valgrind package depends on /usr/bin/perl. >> >> This patch will fix this error while installing into rootfs: >> Computing transaction...error: Can't install >> valgrind-3.8.1-r8@armv7a_vfp_neon: no package provides /usr/bin/perl >> >> Signed-off-by: Felipe F. Tonello >> --- >> meta/recipes-devtools/valgrind/valgrind_3.8.1.bb | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/meta/recipes-devtools/valgrind/valgrind_3.8.1.bb >> b/meta/recipes-devtools/valgrind/valgrind_3.8.1.bb >> index 3520d49..4ee1b64 100644 >> --- a/meta/recipes-devtools/valgrind/valgrind_3.8.1.bb >> +++ b/meta/recipes-devtools/valgrind/valgrind_3.8.1.bb >> @@ -9,7 +9,7 @@ LIC_FILES_CHKSUM = >> "file://COPYING;md5=c46082167a314d785d012a244748d803 \ >> >> X11DEPENDS = "virtual/libx11" >> DEPENDS = "${@base_contains('DISTRO_FEATURES', 'x11', '${X11DEPENDS}', >> '', d)}" >> -PR = "r8" >> +PR = "r9" >> > PR Bump is not needed, mentioned this in past reviews. > > Sau! > >> SRC_URI = "http://www.valgrind.org/downloads/valgrind-${PV}.tar.bz2 \ >>file://fix_issue_caused_by_ccache.patch \ >> @@ -37,6 +37,8 @@ do_install_append () { >> install -m 644 ${B}/default.supp ${D}/${libdir}/valgrind/ >> } >> >> +RDEPENDS_${PN} += "perl" >> + >> FILES_${PN}-dbg += "${libdir}/${PN}/*/.debug/*" >> RRECOMMENDS_${PN}_powerpc += "${TCLIBC}-dbg" >> RRECOMMENDS_${PN}_powerpc64 += "${TCLIBC}-dbg" >> > ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH] pulseaudio: Added consolekit dependency for pulseaudio-module-console-kit package
Hi Martin, On Thu, Jul 11, 2013 at 5:26 AM, Martin Jansa wrote: > On Thu, Jul 11, 2013 at 11:32:14AM +0100, Burton, Ross wrote: >> On 10 July 2013 19:50, Saul Wold wrote: >> > Is this really a build-time dependency or a runtime dependency specific to >> > the pulseaudio-module? >> >> It's a runtime dependency, but from memory bitbake doesn't manage to >> piece the chain together enough to actually build consolekit (probably >> because the packages are dynamically created). > > The problem is that RDEPENDS_ = "foo" > doesn't enforce foo to be built before is used in > image: > > https://bugzilla.yoctoproject.org/show_bug.cgi?id=3498 > > So if is the only thing pulling "foo" into the image > you can get do_rootfs error about missing "foo". > > Cheers, > Yes, that's exactly what happens. I added this dep in my bbappend for a temporary fix, but I would like to see a final fix for it. Regards, Felipe ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH] valgrind: added perl dependency
Should I send another patch? On Tue, Jun 11, 2013 at 12:36 AM, Khem Raj wrote: > On Fri, Jun 7, 2013 at 11:37 AM, Martin Jansa wrote: >> On Fri, Jun 07, 2013 at 10:51:14AM -0700, Felipe Tonello wrote: >>> I got this: >>> >>> valgrind/usr/bin/ms_print >>> 1:#! /usr/bin/perl >>> >>> valgrind/usr/bin/cg_diff >>> 1:#! /usr/bin/perl >>> >>> valgrind/usr/bin/cg_annotate >>> 1:#! /usr/bin/perl >>> >>> valgrind/usr/bin/callgrind_annotate >>> 1:#! /usr/bin/perl -w >>> >>> valgrind/usr/bin/callgrind_control >>> 1:#! /usr/bin/perl -w >>> >>> valgrind-doc/usr/share/doc/valgrind/html/manual-core.html >>> 165:/usr/bin/perl, or whatever interpreter >>> >>> valgrind-doc/usr/share/doc/valgrind/valgrind_manual.ps >>> 55978:(/usr/bin/perl) 77.7083 Tj >>> >>> Do you know if these "binaries" are part of the main package or can be >>> extra? I'm not that familiar with valgrind. >> >> Neither am I, but from filenames I would guess they are not mandatory to >> run valgrind binary, hopefully someone who is using valgrind daily will >> respond soon... >> > > > they are fine with valgrind package itself. although its a rdepend and > not depend > > >> -- >> Martin 'JaMa' Jansa jabber: martin.ja...@gmail.com >> >> ___ >> Openembedded-core mailing list >> Openembedded-core@lists.openembedded.org >> http://lists.openembedded.org/mailman/listinfo/openembedded-core >> ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH] valgrind: added perl dependency
I got this: valgrind/usr/bin/ms_print 1:#! /usr/bin/perl valgrind/usr/bin/cg_diff 1:#! /usr/bin/perl valgrind/usr/bin/cg_annotate 1:#! /usr/bin/perl valgrind/usr/bin/callgrind_annotate 1:#! /usr/bin/perl -w valgrind/usr/bin/callgrind_control 1:#! /usr/bin/perl -w valgrind-doc/usr/share/doc/valgrind/html/manual-core.html 165:/usr/bin/perl, or whatever interpreter valgrind-doc/usr/share/doc/valgrind/valgrind_manual.ps 55978:(/usr/bin/perl) 77.7083 Tj Do you know if these "binaries" are part of the main package or can be extra? I'm not that familiar with valgrind. ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH] valgrind: added perl dependency
Hi Martin, On Fri, Jun 7, 2013 at 10:42 AM, Martin Jansa wrote: > On Fri, Jun 07, 2013 at 10:35:02AM -0700, e...@felipetonello.com wrote: >> From: "Felipe F. Tonello" >> >> This is necessary since the valgrind package depends on /usr/bin/perl. >> >> This patch will fix this error while installing into rootfs: >> Computing transaction...error: Can't install >> valgrind-3.8.1-r8@armv7a_vfp_neon: no package provides /usr/bin/perl > > This doesn't look as build-time dependency and before you add it to > RDEPENDS_${PN} use grep to find which file in valgrind package is using > /usr/bin/perl shebang You are right, it's not a build time dependency, but this fix works anyway hehe. > > grep -R '#/usr/bin/perl' packages-split/valgrind > > and if it's just some "extra" script not always needed for valgrind, > then move it to extra package and add perl only to > PN-this-extra-package. Yes, this makes sense. Thank you Felipe ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH] qmake2.bbclass: export OE_QMAKE_QT_CONFIG
On Thu, Jun 6, 2013 at 2:54 AM, Paul Eggleton wrote: > On Wednesday 05 June 2013 10:01:09 Saul Wold wrote: >> On 06/05/2013 09:57 AM, Paul Eggleton wrote: >> > On Wednesday 05 June 2013 09:46:49 Saul Wold wrote: >> >> On 06/05/2013 02:30 AM, Martin Jansa wrote: >> >>> On Wed, Jun 05, 2013 at 07:01:50PM +1000, Jonathan Liu wrote: >> qconfig.pri was not being loaded by qmake properly. This means Qt >> qmake projects are unable to query QT_ARCH, QT_VERSION and other >> variables defined in qconfig.pri. >> >> Export OE_QMAKE_QT_CONFIG, setting it to the location of qconfig.pri >> so that it can be located by qmake. >> >>> >> >>> There is such patch already: >> >>> http://lists.openembedded.org/pipermail/openembedded-core/2013-May/07831 >> >>> 4. >> >>> html >> >> >> >> Got lost in my queue, adding it for the next MUT. >> > >> > FWIW I am still concerned by the assertion in the commit message about it >> > causing undesirable behaviour. I'd want that checked out and the note >> > removed before we look at merging this. >> >> OK, I will shelf this until I hear more about the testing of this change >> regarding the original patch's note. > > So I tested a rebuild of qt4-x11-free with Felipe's patch and two of > Jonathan's ("qt4: fix QMAKE_QT_CONFIG being overwritten with empty value" and > "classes/qmake_base: allow parallel make"), and did not observe any unexpected > behaviour and buildhistory looks clean for qt itself and fotowall/quicky. So > I'd say feel free to throw these into MUT, but I think we need to drop the > note. > Awesome. Thank you, Felipe ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core