[OE-core] [PATCH v4 1/2] tcf-agent: fix machine setting for arm64 build

2017-04-26 Thread Gernot Hillier
tcf-agent uses "a64", not "aarch64", see agent/Makefile.inc. This fix
allows to re-enable features like SERVICE_Breakpoints and SERVICE_
MemoryMap on arm64.

Signed-off-by: Gernot Hillier <gernot.hill...@siemens.com>
Acked-by: Eugene Tarassov <eugene.taras...@xilinx.com>
---
 meta/recipes-devtools/tcf-agent/tcf-agent_git.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-devtools/tcf-agent/tcf-agent_git.bb 
b/meta/recipes-devtools/tcf-agent/tcf-agent_git.bb
index e5e41f148e..cd0081ac16 100644
--- a/meta/recipes-devtools/tcf-agent/tcf-agent_git.bb
+++ b/meta/recipes-devtools/tcf-agent/tcf-agent_git.bb
@@ -30,7 +30,7 @@ INITSCRIPT_NAME = "tcf-agent"
 INITSCRIPT_PARAMS = "start 99 3 5 . stop 20 0 1 2 6 ."
 
 # mangling needed for make
-MAKE_ARCH = "`echo ${TARGET_ARCH} | sed s,i.86,i686,`"
+MAKE_ARCH = "`echo ${TARGET_ARCH} | sed s,i.86,i686, | sed s,aarch64,a64,`"
 MAKE_OS = "`echo ${TARGET_OS} | sed s,^linux.*,GNU/Linux,`"
 
 EXTRA_OEMAKE = "MACHINE=${MAKE_ARCH} OPSYS=${MAKE_OS} 'CC=${CC}' 'AR=${AR}'"
-- 
2.12.0

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


[OE-core] [PATCH v4 2/2] tcf-agent: enable default target debugging features

2017-04-26 Thread Gernot Hillier
A number of features were disabled in OE due to historic problems
on ARM. In tcf-agent 1.4, they compile cleanly on all architectures
besides mips and libc-musl. These features are required for target
debugging with Eclipse Neon, CDT and TCF plugins - for example used
by Xilinx Vivado SDK 2016.4.

For MIPS and libc-musl, at least re-enable SERVICE_Symbols and
SERVICE_LineNumbers which compile cleanly.

Signed-off-by: Gernot Hillier <gernot.hill...@siemens.com>
Signed-off-by: Tim Offermann <tim.offerm...@siemens.com>
Acked-by: Eugene Tarassov <eugene.taras...@xilinx.com>
---
 meta/recipes-devtools/tcf-agent/tcf-agent_git.bb | 13 +
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/meta/recipes-devtools/tcf-agent/tcf-agent_git.bb 
b/meta/recipes-devtools/tcf-agent/tcf-agent_git.bb
index cd0081ac16..1dad825fda 100644
--- a/meta/recipes-devtools/tcf-agent/tcf-agent_git.bb
+++ b/meta/recipes-devtools/tcf-agent/tcf-agent_git.bb
@@ -35,11 +35,16 @@ MAKE_OS = "`echo ${TARGET_OS} | sed s,^linux.*,GNU/Linux,`"
 
 EXTRA_OEMAKE = "MACHINE=${MAKE_ARCH} OPSYS=${MAKE_OS} 'CC=${CC}' 'AR=${AR}'"
 
-# They don't build on ARM and we don't need them actually.
-CFLAGS += "-DSERVICE_RunControl=0 -DSERVICE_Breakpoints=0 \
+# These features don't compile on mips and libc-musl
+CFLAGS_mips_append = "-DSERVICE_RunControl=0 -DSERVICE_Breakpoints=0 \
 -DSERVICE_Memory=0 -DSERVICE_Registers=0 -DSERVICE_MemoryMap=0 \
--DSERVICE_StackTrace=0 -DSERVICE_Symbols=0 -DSERVICE_LineNumbers=0 \
--DSERVICE_Expressions=0"
+-DSERVICE_StackTrace=0 -DSERVICE_Expressions=0"
+CFLAGS_mips64_append = "-DSERVICE_RunControl=0 -DSERVICE_Breakpoints=0 \
+-DSERVICE_Memory=0 -DSERVICE_Registers=0 -DSERVICE_MemoryMap=0 \
+-DSERVICE_StackTrace=0 -DSERVICE_Expressions=0"
+CFLAGS_append_libc-musl = "-DSERVICE_RunControl=0 -DSERVICE_Breakpoints=0 \
+-DSERVICE_Memory=0 -DSERVICE_Registers=0 -DSERVICE_MemoryMap=0 \
+-DSERVICE_StackTrace=0 -DSERVICE_Expressions=0"
 
 do_install() {
oe_runmake install INSTALLROOT=${D}
-- 
2.12.0

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


[OE-core] [PATCH v4 0/2] tcf-agent: fix target debugging with Eclipse CDT

2017-04-26 Thread Gernot Hillier
Default recipe for tcf-agent disabled a number of features because of
historic build problems on ARM dating back to tcf-agent 0.0+svnr1855
(from 2011). We re-enable them for all archs besides mips and libc-musl.
For arm64, we additionally need to fix MACHINE setting to make those
features compile again.

Without those features, target debugging using Eclipse Neon and CDT
with TCF 1.4 plugin didn't work in our tests. This is the default
debugging mode in the Xilinx Vivado SDK.

Thanks to Eugene, main TCF developer, for reviewing the patches!

Series history:
v1: enable default tcf-agent features on all archs, sent to Poky ML
v2: address build break on mips and arm64, thx to Richard Purdie for 
pointing me to this!
v3: Sent using git-send-email to fix line wrapping (sorry!)
v4: address build break on libc-musl, thx to Ross Burton for the hint

--
Gernot Hillier
Siemens AG, Corporate Competence Center Embedded Linux


Gernot Hillier (2):
  tcf-agent: fix machine setting for arm64 build
  tcf-agent: enable default target debugging features

 meta/recipes-devtools/tcf-agent/tcf-agent_git.bb | 15 ++-
 1 file changed, 10 insertions(+), 5 deletions(-)

-- 
2.12.0

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


Re: [OE-core] [PATCH v3 2/2] tcf-agent: enable default target debugging features

2017-04-25 Thread Gernot Hillier
On 21.04.2017 18:39, Burton, Ross wrote:
> 
> On 20 April 2017 at 20:08, Gernot Hillier <gernot.hill...@siemens.com
> <mailto:gernot.hill...@siemens.com>> wrote:
> 
> A number of features were disabled in OE due to historic problems
> on ARM. In tcf-agent 1.4, they compile cleanly on all architectures
> besides mips. These features are required for target debugging with
> Eclipse Neon, CDT and TCF plugins - for example used by Xilinx Vivado
> SDK 2016.4.
> 
> 
> Would this be responsible for this failure under musl on the autobuilder:
> 
> system/GNU/Linux/tcf/context-linux.c:490:10: error: variable 'cmd' has
> initializer but incomplete type
>  enum __ptrace_request cmd = PTRACE_SINGLESTEP;
>   ^~~~

Thanks to pointing me to this!

Looks like we need to disable the advanced tcf-agent features for musl
again as it seems to lack the necessary ptrace header.

I'll double-check other builders and post an updated patch series soon.

-- 
Gernot
Siemens AG, Corporate Competence Center Embedded Linux

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


[OE-core] [PATCH v3 2/2] tcf-agent: enable default target debugging features

2017-04-20 Thread Gernot Hillier
A number of features were disabled in OE due to historic problems
on ARM. In tcf-agent 1.4, they compile cleanly on all architectures
besides mips. These features are required for target debugging with
Eclipse Neon, CDT and TCF plugins - for example used by Xilinx Vivado
SDK 2016.4.

For MIPS, at least re-enable SERVICE_Symbols and SERVICE_LineNumbers
which compile cleanly.

Signed-off-by: Gernot Hillier <gernot.hill...@siemens.com>
Signed-off-by: Tim Offermann <tim.offerm...@siemens.com>
---
 meta/recipes-devtools/tcf-agent/tcf-agent_git.bb | 10 ++
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/meta/recipes-devtools/tcf-agent/tcf-agent_git.bb 
b/meta/recipes-devtools/tcf-agent/tcf-agent_git.bb
index cd0081ac16..eb18a925d0 100644
--- a/meta/recipes-devtools/tcf-agent/tcf-agent_git.bb
+++ b/meta/recipes-devtools/tcf-agent/tcf-agent_git.bb
@@ -35,11 +35,13 @@ MAKE_OS = "`echo ${TARGET_OS} | sed s,^linux.*,GNU/Linux,`"
 
 EXTRA_OEMAKE = "MACHINE=${MAKE_ARCH} OPSYS=${MAKE_OS} 'CC=${CC}' 'AR=${AR}'"
 
-# They don't build on ARM and we don't need them actually.
-CFLAGS += "-DSERVICE_RunControl=0 -DSERVICE_Breakpoints=0 \
+# They don't build on mips
+CFLAGS_mips_append = "-DSERVICE_RunControl=0 -DSERVICE_Breakpoints=0 \
 -DSERVICE_Memory=0 -DSERVICE_Registers=0 -DSERVICE_MemoryMap=0 \
--DSERVICE_StackTrace=0 -DSERVICE_Symbols=0 -DSERVICE_LineNumbers=0 \
--DSERVICE_Expressions=0"
+-DSERVICE_StackTrace=0 -DSERVICE_Expressions=0"
+CFLAGS_mips64_append = "-DSERVICE_RunControl=0 -DSERVICE_Breakpoints=0 \
+-DSERVICE_Memory=0 -DSERVICE_Registers=0 -DSERVICE_MemoryMap=0 \
+-DSERVICE_StackTrace=0 -DSERVICE_Expressions=0"
 
 do_install() {
oe_runmake install INSTALLROOT=${D}
-- 
2.12.0

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


[OE-core] [PATCH v3 1/2] tcf-agent: fix machine setting for arm64 build

2017-04-20 Thread Gernot Hillier
tcf-agent uses "a64", not "aarch64", see agent/Makefile.inc. This fix
allows to re-enable features like SERVICE_Breakpoints and SERVICE_
MemoryMap on arm64.

Signed-off-by: Gernot Hillier <gernot.hill...@siemens.com>
---
 meta/recipes-devtools/tcf-agent/tcf-agent_git.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-devtools/tcf-agent/tcf-agent_git.bb 
b/meta/recipes-devtools/tcf-agent/tcf-agent_git.bb
index e5e41f148e..cd0081ac16 100644
--- a/meta/recipes-devtools/tcf-agent/tcf-agent_git.bb
+++ b/meta/recipes-devtools/tcf-agent/tcf-agent_git.bb
@@ -30,7 +30,7 @@ INITSCRIPT_NAME = "tcf-agent"
 INITSCRIPT_PARAMS = "start 99 3 5 . stop 20 0 1 2 6 ."
 
 # mangling needed for make
-MAKE_ARCH = "`echo ${TARGET_ARCH} | sed s,i.86,i686,`"
+MAKE_ARCH = "`echo ${TARGET_ARCH} | sed s,i.86,i686, | sed s,aarch64,a64,`"
 MAKE_OS = "`echo ${TARGET_OS} | sed s,^linux.*,GNU/Linux,`"
 
 EXTRA_OEMAKE = "MACHINE=${MAKE_ARCH} OPSYS=${MAKE_OS} 'CC=${CC}' 'AR=${AR}'"
-- 
2.12.0

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


[OE-core] [PATCH v3 0/2] tcf-agent: fix CDT target debugging

2017-04-20 Thread Gernot Hillier
Default recipe for tcf-agent disabled a number of features because of
historic build problems on ARM dating back to tcf-agent 0.0+svnr1855
(from 2011). We re-enable them for all archs besides mips. For arm64,
we additionally need to fix MACHINE setting to make those features
compile again.

Without those features, target debugging using Eclipse Neon and CDT
with TCF 1.4 plugin didn't work in our tests. This is the default
debugging mode in the Xilinx Vivado SDK.

Series history:
v1: enable default tcf-agent features on all archs, sent to Poky ML
v2: address build break on mips and arm64, thx to Richard Purdie for 
pointing me to this!
v3: Sent using git-send-email to fix line wrapping (sorry!)

--
Gernot Hillier
Siemens AG, Corporate Competence Center Embedded Linux

Gernot Hillier (2):
  tcf-agent: fix machine setting for arm64 build
  tcf-agent: enable default target debugging features

 meta/recipes-devtools/tcf-agent/tcf-agent_git.bb | 12 +++-
 1 file changed, 7 insertions(+), 5 deletions(-)

-- 
2.12.0

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


[OE-core] [PATCH v3 0/2] tcf-agent: fix CDT target debugging

2017-04-20 Thread Gernot Hillier
Default recipe for tcf-agent disabled a number of features because of
historic build problems on ARM dating back to tcf-agent 0.0+svnr1855
(from 2011). We re-enable them for all archs besides mips. For arm64,
we additionally need to fix MACHINE setting to make those features
compile again.

Without those features, target debugging using Eclipse Neon and CDT
with TCF 1.4 plugin didn't work in our tests. This is the default
debugging mode in the Xilinx Vivado SDK.

Series history:
v1: enable default tcf-agent features on all archs, sent to Poky ML
v2: address build break on mips and arm64, thx to Richard Purdie for 
pointing me to this!
v3: Sent using git-send-email to fix line wrapping (sorry!)

--
Gernot Hillier
Siemens AG, Corporate Competence Center Embedded Linux

Gernot Hillier (2):
  tcf-agent: fix machine setting for arm64 build
  tcf-agent: enable default target debugging features

 meta/recipes-devtools/tcf-agent/tcf-agent_git.bb | 12 +++-
 1 file changed, 7 insertions(+), 5 deletions(-)

-- 
2.12.0

-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


[OE-core] [PATCH 1/2] tcf-agent: fix machine setting for arm64 build

2017-04-20 Thread Gernot Hillier

tcf-agent uses "a64", not "aarch64", see agent/Makefile.inc. This fix
allows to re-enable features like SERVICE_Breakpoints and SERVICE_
MemoryMap on arm64.

Signed-off-by: Gernot Hillier <gernot.hill...@siemens.com>
---
 meta/recipes-devtools/tcf-agent/tcf-agent_git.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-devtools/tcf-agent/tcf-agent_git.bb
b/meta/recipes-devtools/tcf-agent/tcf-agent_git.bb
index e5e41f148e..cd0081ac16 100644
--- a/meta/recipes-devtools/tcf-agent/tcf-agent_git.bb
+++ b/meta/recipes-devtools/tcf-agent/tcf-agent_git.bb
@@ -30,7 +30,7 @@ INITSCRIPT_NAME = "tcf-agent"
 INITSCRIPT_PARAMS = "start 99 3 5 . stop 20 0 1 2 6 ."

 # mangling needed for make
-MAKE_ARCH = "`echo ${TARGET_ARCH} | sed s,i.86,i686,`"
+MAKE_ARCH = "`echo ${TARGET_ARCH} | sed s,i.86,i686, | sed s,aarch64,a64,`"
 MAKE_OS = "`echo ${TARGET_OS} | sed s,^linux.*,GNU/Linux,`"

 EXTRA_OEMAKE = "MACHINE=${MAKE_ARCH} OPSYS=${MAKE_OS} 'CC=${CC}'
'AR=${AR}'"
-- 
2.12.0
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


[OE-core] [PATCH 2/2] tcf-agent: enable default target debugging features

2017-04-20 Thread Gernot Hillier

A number of features were disabled in OE due to historic problems
on ARM. In tcf-agent 1.4, they compile cleanly on all architectures
besides mips. These features are required for target debugging with
Eclipse Neon, CDT and TCF plugins - for example used by Xilinx Vivado
SDK 2016.4.

For MIPS, at least re-enable SERVICE_Symbols and SERVICE_LineNumbers
which compile cleanly.

Signed-off-by: Gernot Hillier <gernot.hill...@siemens.com>
Signed-off-by: Tim Offermann <tim.offerm...@siemens.com>
---
 meta/recipes-devtools/tcf-agent/tcf-agent_git.bb | 10 ++
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/meta/recipes-devtools/tcf-agent/tcf-agent_git.bb 
b/meta/recipes-devtools/tcf-agent/tcf-agent_git.bb
index cd0081ac16..eb18a925d0 100644
--- a/meta/recipes-devtools/tcf-agent/tcf-agent_git.bb
+++ b/meta/recipes-devtools/tcf-agent/tcf-agent_git.bb
@@ -35,11 +35,13 @@ MAKE_OS = "`echo ${TARGET_OS} | sed s,^linux.*,GNU/Linux,`"
 
 EXTRA_OEMAKE = "MACHINE=${MAKE_ARCH} OPSYS=${MAKE_OS} 'CC=${CC}' 'AR=${AR}'"
 
-# They don't build on ARM and we don't need them actually.
-CFLAGS += "-DSERVICE_RunControl=0 -DSERVICE_Breakpoints=0 \
+# They don't build on mips
+CFLAGS_mips_append = "-DSERVICE_RunControl=0 -DSERVICE_Breakpoints=0 \
 -DSERVICE_Memory=0 -DSERVICE_Registers=0 -DSERVICE_MemoryMap=0 \
--DSERVICE_StackTrace=0 -DSERVICE_Symbols=0 -DSERVICE_LineNumbers=0 \
--DSERVICE_Expressions=0"
+-DSERVICE_StackTrace=0 -DSERVICE_Expressions=0"
+CFLAGS_mips64_append = "-DSERVICE_RunControl=0 -DSERVICE_Breakpoints=0 \
+-DSERVICE_Memory=0 -DSERVICE_Registers=0 -DSERVICE_MemoryMap=0 \
+-DSERVICE_StackTrace=0 -DSERVICE_Expressions=0"
 
 do_install() {
oe_runmake install INSTALLROOT=${D}
-- 
2.12.0
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core


[OE-core] [PATCH v2 0/2] tcf-agent: fix CDT target debugging

2017-04-20 Thread Gernot Hillier
Default recipe for tcf-agent disabled a number of features because of
historic build problems on ARM dating back to tcf-agent 0.0+svnr1855
(from 2011). We re-enable them for all archs besides mips. For arm64,
we additionally need to fix MACHINE setting to make those features
compile again.

Without those features, target debugging using Eclipse Neon and CDT
with TCF 1.4 plugin didn't work in our tests. This is the default
debugging mode in the Xilinx Vivado SDK.

This series contains updated version of patch to address mips and arm64
issues, thx to Richard Purdie for pointing me to this! Patch v1 was
sent to poky ML in error.

--
Gernot Hillier
Siemens AG, Corporate Competence Center Embedded Linux
-- 
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core