Re: [OE-core] Y2038 proposal

2022-12-02 Thread Matt Johnston
On Wed, 2022-11-30 at 09:07 +0100, Alexander Kanavin wrote:
> > > > On Tue, 29 Nov 2022 at 16:45, Stephen Jolley
> > > >  wrote:
> > > > > > > > We’d welcome a proposal/series on how to move forward with
> > > > > > > > the Y2038 work for 32 bit platforms.
> > > > 
> > > > I have the following proposal:
> > > > 
> > > > 1. A branch is made where:
> > > > a. "-D_TIME_BITS=64 -D_FILE_OFFSET_BITS=64" is enabled globally.
> > > > b. qemu is always started with "-rtc base=2040-01-01", simulating
> > > > Y2038 actually occurring.
> > > > c. an additional runtime test verifies that both RTC clock and system
> > > > clock report 2040.
> > > > 
> > > > 2. This branch is run through a-full on the autobuilder. Any
> > > > uncovered
> > > > issues are filed as bugs.

Your email prompted me to check my own software (Dropbear) and it showed a
few y2038 issues to fix. Those bugs wouldn't be noticed from a quick test -
it "only" prevented auth and idle timeouts from occurring.

gcc and clang are able to flag truncated conversions for 64-bit time_t with 
-Wconversion, but that's very noisy. Comparing that against a 32-bit time_t
build, however, gives a pretty clean list of code that needs attention.

As an experiment I've built OpenBMC with and without 64-bit time_t,
https://github.com/mkj/yocto-y2038 has the results and a description. There
are a mix of false positives (particularly tv_usec/tv_nsec), but also some
real-looking things. As an example, busybox using a uint32_t to copy a dhcpd
lease expiry.

I'm not sure the best way to use these logs - they need manual review.
Expanding the list of packages should be easy, but there will be more that
need manual intervention to get rid of -Werror.

Cheers,
Matt





-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#174229): 
https://lists.openembedded.org/g/openembedded-core/message/174229
Mute This Topic: https://lists.openembedded.org/mt/95354043/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core][PATCH] dropbear: Enable x11 forwarding

2022-07-24 Thread Matt Johnston
On Thu, 2022-07-21 at 09:12 +, Ross Burton wrote:
> > On 20 Jul 2022, at 20:44, Daniel Gomez via lists.openembedded.org
> >  wrote:
> > +   
> > file://0008-default_options-Enable-x11-forwarding.patch', '', d)}”
> 
> This should be a PACKAGECONFIG instead of a forced on/off based on
> DISTRO_FEATURES.
> 
> Upstreaming a configure option to expose this as —enable-x-forwarding would
> be great, but for now you can easily sed this file as needed based on the
> value of PACKAGECONFIG.

The upstream method for Dropbear configuration is #define entries in a
localoptions.h file.  default_options.h should be left untouched.  Adding it
to CFLAGS for configure would also work, as 

./configure CFLAGS="-Os -Wall -DDROPBEAR_X11FWD=1"

Cheers,
Matt
(Dropbear upstream)


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#168466): 
https://lists.openembedded.org/g/openembedded-core/message/168466
Mute This Topic: https://lists.openembedded.org/mt/92512561/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH] openssh: openssh-dev shouldn't depend on openssh

2021-09-30 Thread Matt Johnston
On Wed, 2021-09-29 at 09:40 -0500, Mark Hatle wrote:
> 
> If your root filesystem does NOT have openssh in it, then we need to answer 
> the
> question why was the -dev version added?
> 
> You mention above it's "any built package", but that should not be the case.  
> It
> should be for any package installed into the corresponding root filesystem.

In this case "openssh" isn't installed in the root filesystem, only 
"openssh-sftp-server". 

> This should NOT install -dev packages for things not located in
> core-image-minimal.  If it does, then there is another problem, that was not 
> the
> intended design.  The intention when the do_populate_sdk was written was
> construct the rootfs, parse what was install and add -dev packages + their
> dependencies.

populate_sdk resolves the globs for installed packages with 
"oe-pkgdata-util glob /tmp/installedpkgs *-dev"
which falls back to using the PN ("openssh") to find a match for openssh-
sftp-server.
That behaviour is useful for libraries like 
libboost-thread1.77.0 -> boost-dev, so I guess it's best left as-is.

Cheers,
Matt
> 


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#156481): 
https://lists.openembedded.org/g/openembedded-core/message/156481
Mute This Topic: https://lists.openembedded.org/mt/85941131/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [OE-core] [PATCH] openssh: openssh-dev shouldn't depend on openssh

2021-09-29 Thread Matt Johnston
On Wed, 2021-09-29 at 09:24 +0100, Richard Purdie wrote:
> > +RDEPENDS:${PN}-dev = ""
> 
> At that point what is the point of the -dev package? I think you could make
> this argument about a lot of the -dev packages and I'm not sure I'd want to
> see every recipe doing this.
> 
> What are you using the -dev package for and do you need it at all?

The -dev package isn't needed for anything, but it gets pulled in when
"populate_sdk" is built. That does a glob over all -dev packages for
any built package.

Cheers,
Matt

> 
> [As an aside, I do think the -dev package dependencies need rethinking but
> that is a lot more work which nobody seems very interested in]
> 
> Cheers,
> 
> Richard
> 



-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#156452): 
https://lists.openembedded.org/g/openembedded-core/message/156452
Mute This Topic: https://lists.openembedded.org/mt/85941131/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[OE-core] [PATCH] openssh: openssh-dev shouldn't depend on openssh

2021-09-28 Thread Matt Johnston
In some situations packages such as openssh-sftp-server are used
separately from openssh-sshd. The openssh-dev package is empty
but can have conflicts when installed via populate_sdk. Removing the
dependency avoids that.

https://github.com/openbmc/openbmc/issues/3819 is an example of the
problem.

Signed-off-by: Matt Johnston 
---
 meta/recipes-connectivity/openssh/openssh_8.7p1.bb | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/meta/recipes-connectivity/openssh/openssh_8.7p1.bb 
b/meta/recipes-connectivity/openssh/openssh_8.7p1.bb
index 07cd6b74cd..3ebdd62de3 100644
--- a/meta/recipes-connectivity/openssh/openssh_8.7p1.bb
+++ b/meta/recipes-connectivity/openssh/openssh_8.7p1.bb
@@ -165,6 +165,8 @@ RDEPENDS:${PN}-sshd += "${PN}-keygen 
${@bb.utils.contains('DISTRO_FEATURES', 'pa
 RRECOMMENDS:${PN}-sshd:append:class-target = "\
 ${@bb.utils.filter('PACKAGECONFIG', 'rng-tools', d)} \
 "
+# openssh-dev shouldn't pull in openssh-sshd etc
+RDEPENDS:${PN}-dev = ""
 
 # gdb would make attach-ptrace test pass rather than skip but not worth the 
build dependencies
 RDEPENDS:${PN}-ptest += "${PN}-sftp ${PN}-misc ${PN}-sftp-server make sed sudo 
coreutils"
-- 
2.30.2


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#156437): 
https://lists.openembedded.org/g/openembedded-core/message/156437
Mute This Topic: https://lists.openembedded.org/mt/85941131/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub 
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-