Re: [OE-core] [PATCH v2] bzip2: Add test suite for bzip2
Hi Randy,
patch has been accepted by bzip2 community with additional changes.
https://sourceware.org/git/?p=bzip2-tests.git;a=commit;h=f9061c030a25de5b6829e1abf373057309c734c0
So I need your suggestion with respect to Yocto.
Since required changes for ptest infrastructure is integrated to the
bzip2-tests.git source code.
So now we can just change the SRCREV with the latest commit instead of
applying the patch to the bzip2-tests.git source code.
And since we are just integrating the bzip2-tests source to the bzip2
recipe and not modifying any file so i think no need to add any License for
it.
Now patch will look like
=
--- a/meta/recipes-extended/bzip2/bzip2/Makefile.am
+++ b/meta/recipes-extended/bzip2/bzip2/Makefile.am
@@ -46,6 +46,7 @@ runtest:
else echo "FAIL: sample2 decompress"; fi
@if cmp sample3.tst sample3.ref; then echo "PASS: sample3
decompress";\
else echo "FAIL: sample3 decompress"; fi
+ ./bzip2-tests/run-tests.sh --tests-dir="$(PWD)/bzip2-tests"
install-ptest:
sed -n '/^runtest:/,/^install-ptest:/{/^install-ptest:/!p}' \
@@ -56,6 +57,7 @@ install-ptest:
cp $(srcdir)/sample1.bz2$(DESTDIR)/
cp $(srcdir)/sample2.bz2$(DESTDIR)/
cp $(srcdir)/sample3.bz2$(DESTDIR)/
+ cp -rf $(srcdir)/../git $(DESTDIR)/bzip2-tests
ln -s $(bindir)/bzip2 $(DESTDIR)/bzip2
install-exec-hook:
diff --git a/meta/recipes-extended/bzip2/bzip2_1.0.8.bb
b/meta/recipes-extended/bzip2/bzip2_1.0.8.bb
index d58f553..c5aa690 100644
--- a/meta/recipes-extended/bzip2/bzip2_1.0.8.bb
+++ b/meta/recipes-extended/bzip2/bzip2_1.0.8.bb
@@ -8,13 +8,17 @@ LICENSE = "bzip2-1.0.6"
LIC_FILES_CHKSUM =
"file://LICENSE;beginline=4;endline=37;md5=600af43c50f1fcb82e32f19b32df4664"
SRC_URI = "https://sourceware.org/pub/${BPN}/${BPN}-${PV}.tar.gz \
+ git://sourceware.org/git/bzip2-tests.git;name=bzip2-tests \
file://configure.ac;subdir=${BP} \
file://Makefile.am;subdir=${BP} \
file://run-ptest \
"
+
SRC_URI[md5sum] = "67e051268d0c475ea773822f7500d0e5"
SRC_URI[sha256sum] =
"ab5a03176ee106d3f0fa90e381da478ddae405918153cca248e682cd0c4a2269"
+SRCREV_bzip2-tests = "f9061c030a25de5b6829e1abf373057309c734c0" *<< this
commit Id includes latest charges for ptest infrastruct.*
+
UPSTREAM_CHECK_URI = "https://www.sourceware.org/pub/bzip2/";
PACKAGES =+ "libbz2"
@@ -39,7 +43,7 @@ do_install_ptest () {
FILES_libbz2 = "${libdir}/lib*${SOLIBS}"
-RDEPENDS_${PN}-ptest += "make"
+RDEPENDS_${PN}-ptest += "make bash"
PROVIDES_append_class-native = " bzip2-replacement-native"
BBCLASSEXTEND = "native nativesdk"
=====
Kindly comment on it and feel free to point out, if i am wrong at any place.
*Thanks & Regards,*
Rahul Kumar
Software Engineer,Linux Solutions Engineering
Group,Montavista Software LLC
Email Id: rah...@mvista.com
<https://plus.google.com/+CodeTwoSoftware>
On Fri, May 1, 2020 at 6:56 AM Randy MacLeod
wrote:
> On 2020-04-27 3:39 p.m., Alexander Kanavin wrote:
> > You need to first see from the failure page which configuration is
> > failing, for example non-gpl3 is one such.
> >
> > Then you find that configuration in config.json. The below should
> > hopefully be self-explanatory in how you should set up the build?
> >
> > |"non-gpl3" : { "NEEDREPOS" : ["poky", "meta-gplv2"], "MACHINE" :
> > "qemux86", "BBTARGETS" : "core-image-minimal core-image-full-cmdline",
> > "extravars" : [ "INCOMPATIBLE_LICENSE = '*GPLv3'", "WARN_QA_remove =
> > 'incompatible-license'" ], "EXTRACMDS" : [
> > "../../yocto-autobuilder-helper/scripts/check-gplv3" ] },
> >
> > |
> >
> > |
> > |
> >
> > |Alex
>
> Hi Rahul,
>
> Sorry for my late reply.
>
> The commit log for v2 is very good now!
> Thanks for incorporating my --pedantic suggestions. ;-)
>
> It seems that you need a perl dependency for something (docs?
> $ cd .../bzip2.git
> $ grep -r "perl " *
> format.pl:#!/usr/bin/perl -w
> README.XML.STUFF:It uses format.pl, a perl script...
>
> Then we need to figure out how to deal with the GPLv3 issue.
>
> The buildbot output can be tedious to figure out. I haven't really
> spent enough time plugging away at it to be proficient yet either.
> Have you been able to reproduce the problems that Richard reporte
Re: [OE-core] [PATCH v2] bzip2: Add test suite for bzip2
Hi Peter,
I am sharing a few information related to bzip2-test source and licensing
information.
As per your suggestion and as per my understanding I added License to the
bzip2 recipe file.
bzip2-tests.git source tree structure is given below
(here showing licence related fle, removed other file names )
bzip2-tests.git/
├── commons-compress
│ ├── LICENSE.txt
│
├── dotnetzip
│ ├── License.txt
│ ├── License.zlib.txt
|
├── go
│ ├── LICENSE
│
├── lbzip2
├── pyflate
├── README
└── run-tests.sh
source code link:
https://sourceware.org/git/bzip2-tests.git
bzip2-tests.git source contains
1) comman-commpress: which is Originally distributed under the Apache
License Version 2.0.
See LICENSE.txt
2) dotnetzip:
(i) The DotNetZip Library is distributed under the MicroSoft Public License
(Ms-PL) see the License.txt file.
(ii) The BZ2 related resources are distributed under the licenses in
License.zlib.txt.
3) go:
Go is distributed under a BSD-style license.
See the LICENSE file.
4) lbzip2:
lbzip2 is free software: you can redistribute it and/or modify it under the
terms of the GNU General Public License as published by the Free Software
Foundation, either version 3 of the License, or (at your option) any later
version
5) pyflate: You may use and distribute this code and documentation under any
DFSG-compatible license (eg. BSD, GNU GPLv2).
6) run-tests.sh: you can redistribute it and/or modify it under the terms
of the GNU General Public License (GPL); either
version 3, or (at your option) any later version.
SO in recipe I added the License like below
LICENSE = "bzip2-1.0.6 & GPLv3+ & Apache-2.0 & MS-PL & BSD "
LICENSE_${PN}-ptest = "GPLv3+ & Apache-2.0 & MS-PL & BSD"
LIC_FILES_CHKSUM =
"file://LICENSE;beginline=4;endline=37;md5=600af43c50f1fcb82e32f19b32df4664
\
file://${WORKDIR}/git/commons-compress/LICENSE.txt;md5=86d3f3a95c324c9479bd8986968f4327
\ # For comman-commpress (Apache-2.0)
file://${WORKDIR}/git/dotnetzip/License.txt;md5=9cb56871eed4e748c3bc7e8ff352a54f
\ # For dotnetzip (Ms-PL)
file://${WORKDIR}/git/dotnetzip/License.zlib.txt;md5=cc421ccd22eeb2e5db6b79e6de0a029f
\ # For dotnetzip (jzlib +zlib)
file://${WORKDIR}/git/go/LICENSE;md5=5d4950ecb7b26d2c5e4e7b4e0dd74707 \
# For go (BSD-style license)
here I need few suggestion:
1) I added the BSD and GPLv3+ license in LICENSE and LICENSE_${PN}-ptest.
but not added LIC_FILES_CHKSUM for GPLv3 and BSD because bzip2-tests.git
source code doesn't have GPLv3 and BSD License text file like other
directories.
2) License.zlib.txt: This is a combination of two licence jzlib and zlib.
In meta/files/common-licenses Zlib license is available but not jzlib.
In this case how can I proceed?
Kindly comment on this and feel free to point out if i am wrong at any
place.
*Thanks & Regards,*
Rahul Kumar
Software Engineer,Linux Solutions Engineering
Group,Montavista Software LLC
Email Id: rah...@mvista.com
<https://plus.google.com/+CodeTwoSoftware>
On Mon, May 18, 2020 at 1:18 AM Peter Kjellerstedt <
peter.kjellerst...@axis.com> wrote:
> As I wrote in my previous mail, when it comes to licenses, it is the
> distribution that is important. So if you build a package (bzip2-ptest)
> that includes code that is GPL-3.0, it does not matter if that code is only
> used as a binary blob, it is still distributed in the package, and thus the
> package needs to be covered by the GPL-3.0 license.
>
>
>
> //Peter
>
>
>
> *From:* openembedded-core@lists.openembedded.org <
> openembedded-core@lists.openembedded.org> *On Behalf Of *Rahul Kumar
> *Sent:* den 17 maj 2020 21:18
> *To:* Randy MacLeod
> *Cc:* Alexander Kanavin ; Richard Purdie <
> richard.pur...@linuxfoundation.org>; OE-core <
> openembedded-core@lists.openembedded.org>; Trevor Gamblin <
> trevor.gamb...@windriver.com>
> *Subject:* Re: [OE-core] [PATCH v2] bzip2: Add test suite for bzip2
>
>
>
> Hi Randy,
>
> patch has been accepted by bzip2 community with additional changes.
>
> https://sourceware.org/git/?p=bzip2-tests.git;a=commit;h=f9061c030a25de5b6829e1abf373057309c734c0
>
>
> So I need your suggestion with respect to Yocto.
>
> Since required changes for ptest infrastructure is integrated to the
> bzip2-tests.git source code.
> So now we can just change the SRCREV with the latest commit instead of
> applying the patch to the bzip2-tests.git source code.
>
> And since we are just integrating the bzip2-tests source to the bzip2
> recipe and not modifying any file so i think no need to add any License for
> it.
>
>
> Now patch will look like
> =
> --- a/meta/recipes-extended/bzip2/bzip2/Makefile.am
> +++ b/meta/recipes-extended/bzip2/bzip2/Makefile.am
Re: [OE-core] [PATCH v2] bzip2: Add test suite for bzip2
Hi Peter,
Thank you for the quick response.
I will work on your suggestion.but I need your confirmation on
LIC_FILES_CHKSUM also.
*Thanks & Regards,*
Rahul Kumar
Software Engineer,Linux Solutions Engineering
Group,Montavista Software LLC
Email Id: rah...@mvista.com
<https://plus.google.com/+CodeTwoSoftware>
On Tue, May 19, 2020 at 9:59 PM Peter Kjellerstedt <
peter.kjellerst...@axis.com> wrote:
> The jzlib license is a three clause BSD license, and so is the go/LICENSE,
> so you should be able to set LICENSE as:
>
>
>
> LICENSE = "bzip2-1.0.6 & GPLv3+ & Apache-2.0 & MS-PL & BSD-3-Clause & Zlib"
>
>
>
> You also need to add:
>
>
>
> LICENSE_${PN} = "bzip2-1.0.6"
>
> LICENSE_${PN}-dev = "bzip2-1.0.6"
>
> LICENSE_${PN}-dbg = "bzip2-1.0.6"
>
> LICENSE_${PN}-doc = "bzip2-1.0.6"
>
> LICENSE_${PN}-src = "bzip2-1.0.6"
>
> LICENSE_libbz2 = "bzip2-1.0.6"
>
>
>
> so the non-ptest packages are not affected by the licenses for the ptest
> package.
>
>
>
> //Peter
>
>
>
> *From:* Rahul Kumar
> *Sent:* den 19 maj 2020 13:58
> *To:* Peter Kjellerstedt
> *Cc:* Randy MacLeod ; Alexander Kanavin <
> alex.kana...@gmail.com>; Richard Purdie <
> richard.pur...@linuxfoundation.org>; OE-core <
> openembedded-core@lists.openembedded.org>; Trevor Gamblin <
> trevor.gamb...@windriver.com>
> *Subject:* Re: [OE-core] [PATCH v2] bzip2: Add test suite for bzip2
>
>
>
> Hi Peter,
>
> I am sharing a few information related to bzip2-test source and licensing
> information.
> As per your suggestion and as per my understanding I added License to the
> bzip2 recipe file.
>
> bzip2-tests.git source tree structure is given below
> (here showing licence related fle, removed other file names )
>
> bzip2-tests.git/
> ├── commons-compress
> │ ├── LICENSE.txt
> │
> ├── dotnetzip
> │ ├── License.txt
> │ ├── License.zlib.txt
> |
> ├── go
> │ ├── LICENSE
> │
> ├── lbzip2
> ├── pyflate
> ├── README
> └── run-tests.sh
>
> source code link:
> https://sourceware.org/git/bzip2-tests.git
>
> bzip2-tests.git source contains
> 1) comman-commpress: which is Originally distributed under the Apache
> License Version 2.0.
>
> See LICENSE.txt
>
>
> 2) dotnetzip:
> (i) The DotNetZip Library is distributed under the MicroSoft Public
> License
> (Ms-PL) see the License.txt file.
> (ii) The BZ2 related resources are distributed under the licenses in
> License.zlib.txt.
>
> 3) go:
>
> Go is distributed under a BSD-style license.
> See the LICENSE file.
>
> 4) lbzip2:
> lbzip2 is free software: you can redistribute it and/or modify it under the
> terms of the GNU General Public License as published by the Free Software
> Foundation, either version 3 of the License, or (at your option) any later
> version
>
> 5) pyflate: You may use and distribute this code and documentation under
> any
> DFSG-compatible license (eg. BSD, GNU GPLv2).
>
> 6) run-tests.sh: you can redistribute it and/or modify it under the terms
> of the GNU General Public License (GPL); either
> version 3, or (at your option) any later version.
>
>
> SO in recipe I added the License like below
> LICENSE = "bzip2-1.0.6 & GPLv3+ & Apache-2.0 & MS-PL & BSD "
> LICENSE_${PN}-ptest = "GPLv3+ & Apache-2.0 & MS-PL & BSD"
> LIC_FILES_CHKSUM =
> "file://LICENSE;beginline=4;endline=37;md5=600af43c50f1fcb82e32f19b32df4664
> \
>
> file://${WORKDIR}/git/commons-compress/LICENSE.txt;md5=86d3f3a95c324c9479bd8986968f4327
> \ # For comman-commpress (Apache-2.0)
>
> file://${WORKDIR}/git/dotnetzip/License.txt;md5=9cb56871eed4e748c3bc7e8ff352a54f
> \ # For dotnetzip (Ms-PL)
>
> file://${WORKDIR}/git/dotnetzip/License.zlib.txt;md5=cc421ccd22eeb2e5db6b79e6de0a029f
> \ # For dotnetzip (jzlib +zlib)
>
> file://${WORKDIR}/git/go/LICENSE;md5=5d4950ecb7b26d2c5e4e7b4e0dd74707 \
> # For go (BSD-style license)
>
> here I need few suggestion:
>
> 1) I added the BSD and GPLv3+ license in LICENSE and LICENSE_${PN}-ptest.
>but not added LIC_FILES_CHKSUM for GPLv3 and BSD because
> bzip2-tests.git source code doesn't have GPLv3 and BSD License text file
> like other
>directories.
>
> 2) License.zlib.txt: This is a combination of two licence jzlib and zlib.
> In meta/files/common-licenses Zlib license is available but not jzlib.
>In this case how can I proceed?
>
> Kindly comment on this and feel free to point out if i am wrong at any
> place.
>
>
&g
Re: [OE-core] [PATCH v2] bzip2: Add test suite for bzip2
Hi Randy/Peter/community members, Can you please conclude I should go with which option. *Thanks & Regards,* Rahul Kumar Software Engineer,Linux Solutions Engineering Group,Montavista Software LLC Email Id: rah...@mvista.com <https://plus.google.com/+CodeTwoSoftware> On Thu, May 21, 2020 at 2:29 AM Randy MacLeod wrote: > On 2020-05-19 8:06 p.m., Peter Kjellerstedt wrote: > >> -Original Message- > >> From: Randy MacLeod > >> Sent: den 19 maj 2020 23:45 > >> To: Peter Kjellerstedt ; Rahul Kumar > >> > >> Cc: Alexander Kanavin ; Richard Purdie > >> ; OE-core >> c...@lists.openembedded.org>; Trevor Gamblin > >> > >> Subject: Re: [OE-core] [PATCH v2] bzip2: Add test suite for bzip2 > >> > >> On 2020-05-19 12:29 p.m., Peter Kjellerstedt wrote: > >>> The jzlib license is a three clause BSD license, and so is the > >>> go/LICENSE, so you should be able to set LICENSE as: > >>> > >>> LICENSE = "bzip2-1.0.6 & GPLv3+ & Apache-2.0 & MS-PL & BSD-3-Clause & > Zlib" > >> > >> Peter, > >> > >> I respectfully disagree. > >> > >> The only source that is _executed_ in normal use by bzip2-test is > >> the run-tests.sh script that is licensed as GPLv3+ > > > > Well, I am definitely not a lawyer either, > > Phew! :) > > > but I am pretty sure that > > whether something that is distributed under a certain license is > > executed or not is irrelevant (unless of course the license covers > > execution of the code). > > There's a difference between a legal report and the Yocto LICENSE tag. > The Yocto tag is meant to be an over-all/community acknowledged license > for the _code_ in the package that ends up as executable / script on > the target. We should probably document this in greater detail, perhaps > in: > > > https://www.yoctoproject.org/docs/current/mega-manual/mega-manual.html#var-LICENSE > > A more comprehensive analysis usually includes a file by file > IP report often accompanied by a summary generated by an IP expert. > > > > >> The other files, although they came from source packages, > >> are *only* used as test data. The source code has been completely > >> stripped out, hasn't it? > > > > Given that they were originally distributed in an archive together > > with a LICENSE/COPYING/similar file covering the entire archive, > > those files are still covered by that license even if they are not > > source files per se. > > > Licenses describe the terms that apply to items that are covered > under copyright. Data generally can not be copyrighted. > > From my IP contact: > > --- > > In order for something to be copyrightable three requirements > must be satisfied: > > 1. The work represents a creative form of expression > (basic facts do not represent a creative form of expression) > > 2. The work is original (novel) – not copied from someone else. > Two different people could come up with similar creative forms > of expression. They just can’t copy from someone else. > > 3. It must be put in tangible form (e.g., written, digital, …). > Someone can’t just claim it resides inside their head. > > > > Data as a general is not copyrightable because it fails number 1. > However if someone can argue that a certain compilation of data > represents some form of creative expression, they might have a case. > This is discussed in the first two paragraphs here: > > https://libguides.library.kent.edu/data-management/copyright > > > Data can be protected under patent or trade secret law but different > requirements apply and a different license would need to be created. > Open Source licenses are largely copyright licenses. Although sometimes > they include patent terms, they are generally not considered patent > licenses. > > --- > > > Most of the files here are clearly just data and > are therefore neither subject to copyright nor governed by > typical open source licenses. > > Some possible exceptions are: > > dotnetzip/dancing-color.ps.bz2 >- This could be considered as software since that's what a PostScript > file is. In fact it's the 'Dancing links" paper by Donald Knuth: > https://www-cs-faculty.stanford.edu/~knuth/preprints.html > Copyright is not asserted but is of course implied for such works. > No licensing terms are declared. > > go/compress/Isaac.Newton-Opticks.txt.bz2 >- out of copyright since unfortunately the author died long ago :-/ >
[OE-core] [PATCH v3] bzip2: Add test suite for bzip2
Source: git://sourceware.org/git/bzip2-tests.git
Type: Enhancement
Description:
bzip2 now has a test suite available at
git://sourceware.org/git/bzip2-tests.git.
This is a collection of "interesting" .bz2 files that can be used to
test bzip2 works correctly. They come from different projects.
Some files are deliberately bad, and are use to see how bzip2 handles
corrupt files. They are explicitly not intended to decompress correctly,
but to catch errors in bzip2 trying to deal with deliberately bad data.
All such files have a name ending in .bz2.bad.
All non-bad files end in bz2. And should come with a .md5 file for
the original input file. The .md5 file is used to check that bzip2
could correctly decompress the file. The original (non-compressed)
files are deliberately not checked in.
It will by default test with the command 'bzip2', running under
valgrind (if installed on the system).
For each .bz2 file found it is decompressed, recompressed and
decompressed again. Once with the default bzip2 settings and
once in --small (-s) mode.
For each .bz2.bad file decompression is tried twice also. In
default mode and small mode. The bzip2 binary is expected to
return either 1 or 2 as exit status. Any other exit code is
interpreted as failure.
License:
In bzip2-tests source code Each directory should contain a README
file explaining where the .bz2 files originally came from.
Plus a reference to the (Free Software) license that the project
files were distributed under.
Test Summery:
On qemux86-64/kvm the ptest results with extra filesystem space (atleast
114688) are:
TOTAL: 396
PASS: 396
SKIP: 0
XFAIL: 0
FAIL: 0
XPASS: 0
ERROR: 0
All tests passed
DURATION: 517
[YOCTO #13444]
Signed-off-by: Rahul Kumar
---
meta/recipes-extended/bzip2/bzip2/Makefile.am | 2 ++
meta/recipes-extended/bzip2/bzip2_1.0.8.bb| 23 ---
2 files changed, 22 insertions(+), 3 deletions(-)
diff --git a/meta/recipes-extended/bzip2/bzip2/Makefile.am
b/meta/recipes-extended/bzip2/bzip2/Makefile.am
index dcf6458..aab6558 100644
--- a/meta/recipes-extended/bzip2/bzip2/Makefile.am
+++ b/meta/recipes-extended/bzip2/bzip2/Makefile.am
@@ -46,6 +46,7 @@ runtest:
else echo "FAIL: sample2 decompress"; fi
@if cmp sample3.tst sample3.ref; then echo "PASS: sample3 decompress";\
else echo "FAIL: sample3 decompress"; fi
+ ./bzip2-tests/run-tests.sh --tests-dir="$(PWD)/bzip2-tests"
install-ptest:
sed -n '/^runtest:/,/^install-ptest:/{/^install-ptest:/!p}' \
@@ -56,6 +57,7 @@ install-ptest:
cp $(srcdir)/sample1.bz2$(DESTDIR)/
cp $(srcdir)/sample2.bz2$(DESTDIR)/
cp $(srcdir)/sample3.bz2$(DESTDIR)/
+ cp -rf $(srcdir)/../git $(DESTDIR)/bzip2-tests
ln -s $(bindir)/bzip2 $(DESTDIR)/bzip2
install-exec-hook:
diff --git a/meta/recipes-extended/bzip2/bzip2_1.0.8.bb
b/meta/recipes-extended/bzip2/bzip2_1.0.8.bb
index d58f553..20b52f7 100644
--- a/meta/recipes-extended/bzip2/bzip2_1.0.8.bb
+++ b/meta/recipes-extended/bzip2/bzip2_1.0.8.bb
@@ -4,10 +4,25 @@ Huffman coding. Compression is generally considerably better
than that achieved
LZ77/LZ78-based compressors, and approaches the performance of the PPM family
of statistical compressors."
HOMEPAGE = "https://sourceware.org/bzip2/";
SECTION = "console/utils"
-LICENSE = "bzip2-1.0.6"
-LIC_FILES_CHKSUM =
"file://LICENSE;beginline=4;endline=37;md5=600af43c50f1fcb82e32f19b32df4664"
+LICENSE = "bzip2-1.0.6 & GPLv3+ & Apache-2.0 & MS-PL & BSD-3-Clause & Zlib"
+LICENSE_${PN} = "bzip2-1.0.6"
+LICENSE_${PN}-dev = "bzip2-1.0.6"
+LICENSE_${PN}-dbg = "bzip2-1.0.6"
+LICENSE_${PN}-doc = "bzip2-1.0.6"
+LICENSE_${PN}-src = "bzip2-1.0.6"
+LICENSE_libbz2 = "bzip2-1.0.6"
+LICENSE_${PN}-ptest = "bzip2-1.0.6 & GPLv3+ & Apache-2.0 & MS-PL &
BSD-3-Clause & Zlib"
+
+LIC_FILES_CHKSUM =
"file://LICENSE;beginline=4;endline=37;md5=600af43c50f1fcb82e32f19b32df4664 \
+
file://${WORKDIR}/git/commons-compress/LICENSE.txt;md5=86d3f3a95c324c9479bd8986968f4327
\
+
file://${WORKDIR}/git/dotnetzip/License.txt;md5=9cb56871eed4e748c3bc7e8ff352a54f
\
+
file://${WORKDIR}/git/dotnetzip/License.zlib.txt;md5=cc421ccd22eeb2e5db6b79e6de0a029f
\
+
file://${WORKDIR}/git/go/LICENSE;md5=5d4950ecb7b26d2c5e4e7b4e0dd74707 \
+
file://${WORKDIR}/git/lbzip2/COPYING;md5=d32239bcb673463ab874e80d47fae504 \
+"
SRC_URI = "https://sourceware.org/pub/${BPN}/${BPN}-${PV}.tar.gz \
+ git://sourceware.org/git/bzip2-tests.git;name=bzip2-tests \
file://configure.ac;
[OE-core] [meta-oe,zeus][PATCH] tremor: update SRC_URI as project moved to gitlab
From: Armin Kuster It appears Xiph.Org is now on gitlab https://gitlab.xiph.org/xiph Signed-off-by: Armin Kuster Signed-off-by: Khem Raj (cherry picked from commit cc6e59fdff71e47ef5b9b40aab3bcd9438960ea4) Signed-off-by: Rahul Kumar --- meta-multimedia/recipes-multimedia/tremor/tremor_20180319.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta-multimedia/recipes-multimedia/tremor/tremor_20180319.bb b/meta-multimedia/recipes-multimedia/tremor/tremor_20180319.bb index beeb23a..d2ad961 100644 --- a/meta-multimedia/recipes-multimedia/tremor/tremor_20180319.bb +++ b/meta-multimedia/recipes-multimedia/tremor/tremor_20180319.bb @@ -6,7 +6,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=db1b7a668b2a6f47b2af88fb008ad555 \ file://os.h;beginline=3;endline=14;md5=5c0af5e1bedef3ce8178c89f48cd6f1f" DEPENDS = "libogg" -SRC_URI = "git://git.xiph.org/tremor.git;protocol=https \ +SRC_URI = "git://gitlab.xiph.org/xiph/tremor.git;protocol=https \ file://obsolete_automake_macros.patch;striplevel=0 \ file://tremor-arm-thumb2.patch \ " -- 2.7.4 -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#139226): https://lists.openembedded.org/g/openembedded-core/message/139226 Mute This Topic: https://lists.openembedded.org/mt/74676752/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] [meta-oe,zeus][PATCH] tremor: update SRC_URI as project moved to gitlab
Hi Denys, I apologize, By Mistake it happened. Now i have sent it to the correct mailing list . *Thanks & Regards,* Rahul Kumar Software Engineer,Linux Solutions Engineering Group,Montavista Software LLC Email Id: rah...@mvista.com <https://plus.google.com/+CodeTwoSoftware> On Thu, Jun 4, 2020 at 11:39 PM Denys Dmytriyenko wrote: > Why openembedded-core mailing list? > > On Thu, Jun 04, 2020 at 11:17:08PM +0530, Rahul Kumar wrote: > > From: Armin Kuster > > > > It appears Xiph.Org is now on gitlab > > https://gitlab.xiph.org/xiph > > > > Signed-off-by: Armin Kuster > > Signed-off-by: Khem Raj > > (cherry picked from commit cc6e59fdff71e47ef5b9b40aab3bcd9438960ea4) > > Signed-off-by: Rahul Kumar > > --- > > meta-multimedia/recipes-multimedia/tremor/tremor_20180319.bb | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/meta-multimedia/recipes-multimedia/tremor/ > tremor_20180319.bb b/meta-multimedia/recipes-multimedia/tremor/ > tremor_20180319.bb > > index beeb23a..d2ad961 100644 > > --- a/meta-multimedia/recipes-multimedia/tremor/tremor_20180319.bb > > +++ b/meta-multimedia/recipes-multimedia/tremor/tremor_20180319.bb > > @@ -6,7 +6,7 @@ LIC_FILES_CHKSUM = > "file://COPYING;md5=db1b7a668b2a6f47b2af88fb008ad555 \ > > > file://os.h;beginline=3;endline=14;md5=5c0af5e1bedef3ce8178c89f48cd6f1f" > > DEPENDS = "libogg" > > > > -SRC_URI = "git://git.xiph.org/tremor.git;protocol=https \ > > +SRC_URI = "git://gitlab.xiph.org/xiph/tremor.git;protocol=https \ > > file://obsolete_automake_macros.patch;striplevel=0 \ > > file://tremor-arm-thumb2.patch \ > > " > > -- > > 2.7.4 > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#139229): https://lists.openembedded.org/g/openembedded-core/message/139229 Mute This Topic: https://lists.openembedded.org/mt/74676752/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[OE-core] package bzip2-ptest requires /usr/bin/sh, but no providers found in RDEPENDS_bzip2-ptest
Hi community members,
I am working on Yocto Newcommer Bug 13444 - Add test suite for bzip2
Patch link
https://patchwork.openembedded.org/patch/173009/
but upstream build, reported below error .
step1b: ERROR: bzip2-1.0.8-r0 do_package_qa: QA Issue:
/usr/lib/bzip2/ptest/bzip2-tests/.git/hooks/update.sample contained in package
bzip2-ptest requires /usr/bin/sh, but no providers found in
RDEPENDS_bzip2-ptest? [file-rdeps]
step1b: ERROR: bzip2-1.0.8-r0 do_package_qa: QA run found fatal errors. Please
consider fixing them.
I am already using below line to my patch.
RDEPENDS_${PN}-ptest += "make bash perl"
can anyone please help me on this.
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#139754):
https://lists.openembedded.org/g/openembedded-core/message/139754
Mute This Topic: https://lists.openembedded.org/mt/75044252/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] package bzip2-ptest requires /usr/bin/sh, but no providers found in RDEPENDS_bzip2-ptest
Hi khem Raj,
Create a patch to update.sample where it asks for /bin/sh instead
I don't think we can create a patch to update.sample file because this is
git hidden file.
.git/hooks/update.sample
In my Patch fetching bzip2-tests.git repository as mentioned below Is there
any issue with below line.
SRC_URI = "https://sourceware.org/pub/${BPN}/${BPN}-${PV}.tar.gz \
git://sourceware.org/git/bzip2-tests.git;name=bzip2-tests \
At my local system i am not able to face this issue but when this patch
built with open source auto-builder then reporting below error
do_package_qa: QA Issue:
/usr/lib/bzip2/ptest/bzip2-tests/.git/hooks/update.sample contained in
package bzip2-ptest requires /usr/bin/sh, but no providers found in
RDEPENDS_bzip2-ptest? [file-rdeps]
step1b: ERROR: bzip2-1.0.8-r0 do_package_qa: QA run found fatal errors.
Please consider fixing them.
I have stuck here. I am not aware why do_package_qa is reporting errors
with git hidden files.
*Thanks & Regards,*
Rahul Kumar
Software Engineer,Linux Solutions Engineering
Group,Montavista Software LLC
Email Id: rah...@mvista.com
<https://plus.google.com/+CodeTwoSoftware>
On Mon, Jun 22, 2020 at 11:42 PM Khem Raj wrote:
>
>
> On Mon, Jun 22, 2020 at 10:59 AM Rahul Kumar wrote:
>
>> Hi community members,
>>
>> I am working on Yocto Newcommer Bug 13444 - Add test suite for bzip2
>> Patch link
>> https://patchwork.openembedded.org/patch/173009/
>>
>> but upstream build, reported below error .
>> step1b: ERROR: bzip2-1.0.8-r0 do_package_qa: QA Issue:
>> /usr/lib/bzip2/ptest/bzip2-tests/.git/hooks/update.sample contained in
>> package bzip2-ptest requires /usr/bin/sh, but no providers found in
>> RDEPENDS_bzip2-ptest? [file-rdeps]
>>
>
> Create a patch to update.sample where it asks for /bin/sh instead
>
>
> step1b: ERROR: bzip2-1.0.8-r0 do_package_qa: QA run found fatal errors.
>> Please consider fixing them.
>>
>> I am already using below line to my patch.
>> RDEPENDS_${PN}-ptest += "make bash perl"
>>
>> can anyone please help me on this.
>>
>>
>>
>>
>
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#139903):
https://lists.openembedded.org/g/openembedded-core/message/139903
Mute This Topic: https://lists.openembedded.org/mt/75044252/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
[OE-core] [PATCH v4] bzip2: Add test suite for bzip2
Source: git://sourceware.org/git/bzip2-tests.git
Type: Enhancement
Description:
bzip2 now has a test suite available at
git://sourceware.org/git/bzip2-tests.git.
This is a collection of "interesting" .bz2 files that can be used to
test bzip2 works correctly. They come from different projects.
Some files are deliberately bad, and are use to see how bzip2 handles
corrupt files. They are explicitly not intended to decompress correctly,
but to catch errors in bzip2 trying to deal with deliberately bad data.
All such files have a name ending in .bz2.bad.
All non-bad files end in bz2. And should come with a .md5 file for
the original input file. The .md5 file is used to check that bzip2
could correctly decompress the file. The original (non-compressed)
files are deliberately not checked in.
It will by default test with the command 'bzip2', running under
valgrind (if installed on the system).
For each .bz2 file found it is decompressed, recompressed and
decompressed again. Once with the default bzip2 settings and
once in --small (-s) mode.
For each .bz2.bad file decompression is tried twice also. In
default mode and small mode. The bzip2 binary is expected to
return either 1 or 2 as exit status. Any other exit code is
interpreted as failure.
License:
In bzip2-tests source code Each directory should contain a README
file explaining where the .bz2 files originally came from.
Plus a reference to the (Free Software) license that the project
files were distributed under.
Test Summery:
On qemux86-64/kvm the ptest results with extra filesystem space (atleast
114688) are:
TOTAL: 396
PASS: 396
SKIP: 0
XFAIL: 0
FAIL: 0
XPASS: 0
ERROR: 0
All tests passed
DURATION: 517
[YOCTO #13444]
Signed-off-by: Rahul Kumar
---
meta/recipes-extended/bzip2/bzip2/Makefile.am | 1 +
meta/recipes-extended/bzip2/bzip2_1.0.8.bb| 31 ---
2 files changed, 29 insertions(+), 3 deletions(-)
diff --git a/meta/recipes-extended/bzip2/bzip2/Makefile.am
b/meta/recipes-extended/bzip2/bzip2/Makefile.am
index dcf6458..d449894 100644
--- a/meta/recipes-extended/bzip2/bzip2/Makefile.am
+++ b/meta/recipes-extended/bzip2/bzip2/Makefile.am
@@ -46,6 +46,7 @@ runtest:
else echo "FAIL: sample2 decompress"; fi
@if cmp sample3.tst sample3.ref; then echo "PASS: sample3 decompress";\
else echo "FAIL: sample3 decompress"; fi
+ ./bzip2-tests/run-tests.sh --tests-dir="$(PWD)/bzip2-tests"
install-ptest:
sed -n '/^runtest:/,/^install-ptest:/{/^install-ptest:/!p}' \
diff --git a/meta/recipes-extended/bzip2/bzip2_1.0.8.bb
b/meta/recipes-extended/bzip2/bzip2_1.0.8.bb
index d58f553..70eb67f 100644
--- a/meta/recipes-extended/bzip2/bzip2_1.0.8.bb
+++ b/meta/recipes-extended/bzip2/bzip2_1.0.8.bb
@@ -4,10 +4,25 @@ Huffman coding. Compression is generally considerably better
than that achieved
LZ77/LZ78-based compressors, and approaches the performance of the PPM family
of statistical compressors."
HOMEPAGE = "https://sourceware.org/bzip2/";
SECTION = "console/utils"
-LICENSE = "bzip2-1.0.6"
-LIC_FILES_CHKSUM =
"file://LICENSE;beginline=4;endline=37;md5=600af43c50f1fcb82e32f19b32df4664"
+LICENSE = "bzip2-1.0.6 & GPLv3+ & Apache-2.0 & MS-PL & BSD-3-Clause & Zlib"
+LICENSE_${PN} = "bzip2-1.0.6"
+LICENSE_${PN}-dev = "bzip2-1.0.6"
+LICENSE_${PN}-dbg = "bzip2-1.0.6"
+LICENSE_${PN}-doc = "bzip2-1.0.6"
+LICENSE_${PN}-src = "bzip2-1.0.6"
+LICENSE_libbz2 = "bzip2-1.0.6"
+LICENSE_${PN}-ptest = "bzip2-1.0.6 & GPLv3+ & Apache-2.0 & MS-PL &
BSD-3-Clause & Zlib"
+
+LIC_FILES_CHKSUM =
"file://LICENSE;beginline=4;endline=37;md5=600af43c50f1fcb82e32f19b32df4664 \
+
file://${WORKDIR}/git/commons-compress/LICENSE.txt;md5=86d3f3a95c324c9479bd8986968f4327
\
+
file://${WORKDIR}/git/dotnetzip/License.txt;md5=9cb56871eed4e748c3bc7e8ff352a54f
\
+
file://${WORKDIR}/git/dotnetzip/License.zlib.txt;md5=cc421ccd22eeb2e5db6b79e6de0a029f
\
+
file://${WORKDIR}/git/go/LICENSE;md5=5d4950ecb7b26d2c5e4e7b4e0dd74707 \
+
file://${WORKDIR}/git/lbzip2/COPYING;md5=d32239bcb673463ab874e80d47fae504 \
+"
SRC_URI = "https://sourceware.org/pub/${BPN}/${BPN}-${PV}.tar.gz \
+ git://sourceware.org/git/bzip2-tests.git;name=bzip2-tests \
file://configure.ac;subdir=${BP} \
file://Makefile.am;subdir=${BP} \
file://run-ptest \
@@ -15,6 +30,8 @@ SRC_URI =
"https://sourceware.org/pub/${BPN}/${BPN}-${PV}.tar.gz \
SRC_URI[md5sum] = "67e051268d0c475ea773822f7500d0e5"
SRC_URI[sha256sum] =
"ab5a03176ee106d3f0fa90e381da478ddae405918153cca248e682cd0c4a2269"
+SRCREV_bzip
Re: [OE-core] [PATCH v4] bzip2: Add test suite for bzip2
Hi Richard,
Gentle reminder.
I have submitted the Patch V4 for Bug 13444
<https://bugzilla.yoctoproject.org/show_bug.cgi?id=13444>which is in NEW
state.
kindly take a look.
*Thanks & Regards,*
Rahul Kumar
Software Engineer,Linux Solutions Engineering
Group,Montavista Software LLC
Email Id: rah...@mvista.com
<https://plus.google.com/+CodeTwoSoftware>
On Thu, Jun 25, 2020 at 6:41 PM Rahul Kumar wrote:
> Source: git://sourceware.org/git/bzip2-tests.git
> Type: Enhancement
> Description:
> bzip2 now has a test suite available at git://
> sourceware.org/git/bzip2-tests.git.
>
> This is a collection of "interesting" .bz2 files that can be used to
> test bzip2 works correctly. They come from different projects.
>
> Some files are deliberately bad, and are use to see how bzip2 handles
> corrupt files. They are explicitly not intended to decompress correctly,
> but to catch errors in bzip2 trying to deal with deliberately bad data.
> All such files have a name ending in .bz2.bad.
>
> All non-bad files end in bz2. And should come with a .md5 file for
> the original input file. The .md5 file is used to check that bzip2
> could correctly decompress the file. The original (non-compressed)
> files are deliberately not checked in.
>
> It will by default test with the command 'bzip2', running under
> valgrind (if installed on the system).
>
> For each .bz2 file found it is decompressed, recompressed and
> decompressed again. Once with the default bzip2 settings and
> once in --small (-s) mode.
>
> For each .bz2.bad file decompression is tried twice also. In
> default mode and small mode. The bzip2 binary is expected to
> return either 1 or 2 as exit status. Any other exit code is
> interpreted as failure.
>
> License:
>In bzip2-tests source code Each directory should contain a README
>file explaining where the .bz2 files originally came from.
>Plus a reference to the (Free Software) license that the project
>files were distributed under.
>
> Test Summery:
>On qemux86-64/kvm the ptest results with extra filesystem space
> (atleast 114688) are:
>
> TOTAL: 396
> PASS: 396
> SKIP: 0
> XFAIL: 0
> FAIL: 0
> XPASS: 0
> ERROR: 0
>
> All tests passed
> DURATION: 517
>
> [YOCTO #13444]
>
> Signed-off-by: Rahul Kumar
> ---
> meta/recipes-extended/bzip2/bzip2/Makefile.am | 1 +
> meta/recipes-extended/bzip2/bzip2_1.0.8.bb| 31
> ---
> 2 files changed, 29 insertions(+), 3 deletions(-)
>
> diff --git a/meta/recipes-extended/bzip2/bzip2/Makefile.am
> b/meta/recipes-extended/bzip2/bzip2/Makefile.am
> index dcf6458..d449894 100644
> --- a/meta/recipes-extended/bzip2/bzip2/Makefile.am
> +++ b/meta/recipes-extended/bzip2/bzip2/Makefile.am
> @@ -46,6 +46,7 @@ runtest:
> else echo "FAIL: sample2 decompress"; fi
> @if cmp sample3.tst sample3.ref; then echo "PASS: sample3
> decompress";\
> else echo "FAIL: sample3 decompress"; fi
> + ./bzip2-tests/run-tests.sh --tests-dir="$(PWD)/bzip2-tests"
>
> install-ptest:
> sed -n '/^runtest:/,/^install-ptest:/{/^install-ptest:/!p}' \
> diff --git a/meta/recipes-extended/bzip2/bzip2_1.0.8.bb
> b/meta/recipes-extended/bzip2/bzip2_1.0.8.bb
> index d58f553..70eb67f 100644
> --- a/meta/recipes-extended/bzip2/bzip2_1.0.8.bb
> +++ b/meta/recipes-extended/bzip2/bzip2_1.0.8.bb
> @@ -4,10 +4,25 @@ Huffman coding. Compression is generally considerably
> better than that achieved
> LZ77/LZ78-based compressors, and approaches the performance of the PPM
> family of statistical compressors."
> HOMEPAGE = "https://sourceware.org/bzip2/";
> SECTION = "console/utils"
> -LICENSE = "bzip2-1.0.6"
> -LIC_FILES_CHKSUM =
> "file://LICENSE;beginline=4;endline=37;md5=600af43c50f1fcb82e32f19b32df4664"
> +LICENSE = "bzip2-1.0.6 & GPLv3+ & Apache-2.0 & MS-PL & BSD-3-Clause &
> Zlib"
> +LICENSE_${PN} = "bzip2-1.0.6"
> +LICENSE_${PN}-dev = "bzip2-1.0.6"
> +LICENSE_${PN}-dbg = "bzip2-1.0.6"
> +LICENSE_${PN}-doc = "bzip2-1.0.6"
> +LICENSE_${PN}-src = "bzip2-1.0.6"
> +LICENSE_libbz2 = "bzip2-1.0.6"
> +LICENSE_${PN}-ptest = "bzip2-1.0.6 & GPLv3+ & Apache-2.0 & MS-PL &
> BSD-3-Clause & Zlib"
> +
> +LIC_FILES_CHKSUM =
> "file://LICENSE;beginline=4;endline=37;md5=600af43c50f1fcb82e32f19b32df4664
> \
> +
> file://${WORKDIR}/git/commons-compress/LICENSE.txt;md5=86d3f3a95c324c9479bd8986968f4327
> \
> +
> file://${WORKDIR}/git/dotnetzip/L
[OE-core] [dunfell][PATCH] busybox: Security Fix For CVE-2018-1000500
CVE: CVE-2018-1000500
Signed-off-by: Rahul Kumar
---
.../busybox/busybox/busybox-CVE-2018-1000500.patch | 98 ++
meta/recipes-core/busybox/busybox_1.31.1.bb| 1 +
2 files changed, 99 insertions(+)
create mode 100644
meta/recipes-core/busybox/busybox/busybox-CVE-2018-1000500.patch
diff --git a/meta/recipes-core/busybox/busybox/busybox-CVE-2018-1000500.patch
b/meta/recipes-core/busybox/busybox/busybox-CVE-2018-1000500.patch
new file mode 100644
index 000..cde3923
--- /dev/null
+++ b/meta/recipes-core/busybox/busybox/busybox-CVE-2018-1000500.patch
@@ -0,0 +1,98 @@
+From 71e7e2fb35c806d20f9739d832cd9ae3a86fdee2 Mon Sep 17 00:00:00 2001
+From: Dimitri John Ledkov
+Date: Tue, 19 May 2020 18:20:39 +0100
+Subject: [PATCH] wget: implement TLS verification with
+ ENABLE_FEATURE_WGET_OPENSSL
+
+When ENABLE_FEATURE_WGET_OPENSSL is enabled, correctly implement TLS
+verification by default. And only ignore verification errors, if
+--no-check-certificate was passed.
+
+Also note, that previously OPENSSL implementation did not implement
+TLS verification, nor printed any warning messages that verification
+was not performed.
+
+Bug-Ubuntu: https://bugs.launchpad.net/bugs/1879533
+
+CVE-2018-1000500
+
+Upstream Status: Backport
https://git.busybox.net/busybox/commit/?id=45fa3f18adf57ef9d743038743d9c90573aeeb91
+CVE: CVE-2018-1000500
+
+Signed-off-by: Dimitri John Ledkov
+Signed-off-by: Denys Vlasenko
+Signed-off-by: Rahul Kumar
+---
+ networking/wget.c | 20 +---
+ 1 file changed, 17 insertions(+), 3 deletions(-)
+
+diff --git a/networking/wget.c b/networking/wget.c
+index 9153264..a7e6deb 100644
+--- a/networking/wget.c
b/networking/wget.c
+@@ -91,6 +91,9 @@
+ //config: patches, but do want to waste bandwidth expaining how wrong
+ //config: it is, you will be ignored.
+ //config:
++//config: FEATURE_WGET_OPENSSL does implement TLS verification
++//config: using the certificates available to OpenSSL.
++//config:
+ //config:config FEATURE_WGET_OPENSSL
+ //config: bool "Try to connect to HTTPS using openssl"
+ //config: default y
+@@ -115,6 +118,9 @@
+ //config: If openssl can't be executed, internal TLS code will be used
+ //config: (if you enabled it); if openssl can be executed but fails later,
+ //config: wget can't detect this, and download will fail.
++//config:
++//config: By default TLS verification is performed, unless
++//config: --no-check-certificate option is passed.
+
+ //applet:IF_WGET(APPLET(wget, BB_DIR_USR_BIN, BB_SUID_DROP))
+
+@@ -124,8 +130,11 @@
+ //usage: IF_FEATURE_WGET_LONG_OPTIONS(
+ //usage: "[-c|--continue] [--spider] [-q|--quiet] [-O|--output-document
FILE]\n"
+ //usage: " [-o|--output-file FILE] [--header 'header: value']
[-Y|--proxy on/off]\n"
++//usage: IF_FEATURE_WGET_OPENSSL(
++//usage: " [--no-check-certificate]\n"
++//usage: )
+ /* Since we ignore these opts, we don't show them in --help */
+-/* //usage:" [--no-check-certificate] [--no-cache] [--passive-ftp]
[-t TRIES]" */
++/* //usage:" [--no-cache] [--passive-ftp] [-t TRIES]" */
+ /* //usage:" [-nv] [-nc] [-nH] [-np]" */
+ //usage: " [-P DIR] [-S|--server-response] [-U|--user-agent
AGENT]" IF_FEATURE_WGET_TIMEOUT(" [-T SEC]") " URL..."
+ //usage: )
+@@ -137,7 +146,9 @@
+ //usage: "Retrieve files via HTTP or FTP\n"
+ //usage: IF_FEATURE_WGET_LONG_OPTIONS(
+ //usage: "\n --spiderOnly check URL existence: $? is 0 if
exists"
+-///: "\n --no-check-certificate Don't validate the server's
certificate"
++//usage: IF_FEATURE_WGET_OPENSSL(
++//usage: "\n --no-check-certificate Don't validate the server's
certificate"
++//usage: )
+ //usage: )
+ //usage: "\n -c Continue retrieval of aborted transfer"
+ //usage: "\n -q Quiet"
+@@ -662,7 +673,7 @@ static int spawn_https_helper_openssl(const char *host,
unsigned port)
+ pid = xvfork();
+ if (pid == 0) {
+ /* Child */
+- char *argv[8];
++ char *argv[9];
+
+ close(sp[0]);
+ xmove_fd(sp[1], 0);
+@@ -689,6 +700,9 @@ static int spawn_https_helper_openssl(const char *host,
unsigned port)
+ argv[5] = (char*)"-servername";
+ argv[6] = (char*)servername;
+ }
++ if (!(option_mask32 & WGET_OPT_NO_CHECK_CERT)) {
++ argv[7] = (char*)"-verify_return_error";
++ }
+
+ BB_EXECVP(argv[0], argv);
+ xmove_fd(3, 2);
+--
+2.7.4
+
diff --git a/meta/recipes-core/busybox/b
[OE-core] [dunfell][PATCH v2] busybox: Security Fix For CVE-2018-1000500
CVE: CVE-2018-1000500
Signed-off-by: Rahul Kumar
---
.../busybox/busybox/busybox-CVE-2018-1000500.patch | 98 ++
meta/recipes-core/busybox/busybox_1.31.1.bb| 1 +
2 files changed, 99 insertions(+)
create mode 100644
meta/recipes-core/busybox/busybox/busybox-CVE-2018-1000500.patch
diff --git a/meta/recipes-core/busybox/busybox/busybox-CVE-2018-1000500.patch
b/meta/recipes-core/busybox/busybox/busybox-CVE-2018-1000500.patch
new file mode 100644
index 000..d1a33e4
--- /dev/null
+++ b/meta/recipes-core/busybox/busybox/busybox-CVE-2018-1000500.patch
@@ -0,0 +1,98 @@
+From 71e7e2fb35c806d20f9739d832cd9ae3a86fdee2 Mon Sep 17 00:00:00 2001
+From: Dimitri John Ledkov
+Date: Tue, 19 May 2020 18:20:39 +0100
+Subject: [PATCH] wget: implement TLS verification with
+ ENABLE_FEATURE_WGET_OPENSSL
+
+When ENABLE_FEATURE_WGET_OPENSSL is enabled, correctly implement TLS
+verification by default. And only ignore verification errors, if
+--no-check-certificate was passed.
+
+Also note, that previously OPENSSL implementation did not implement
+TLS verification, nor printed any warning messages that verification
+was not performed.
+
+Bug-Ubuntu: https://bugs.launchpad.net/bugs/1879533
+
+CVE-2018-1000500
+
+Upstream-Status: Backport
[https://git.busybox.net/busybox/commit/?id=45fa3f18adf57ef9d743038743d9c90573aeeb91]
+CVE: CVE-2018-1000500
+
+Signed-off-by: Dimitri John Ledkov
+Signed-off-by: Denys Vlasenko
+Signed-off-by: Rahul Kumar
+---
+ networking/wget.c | 20 +---
+ 1 file changed, 17 insertions(+), 3 deletions(-)
+
+diff --git a/networking/wget.c b/networking/wget.c
+index 9153264..a7e6deb 100644
+--- a/networking/wget.c
b/networking/wget.c
+@@ -91,6 +91,9 @@
+ //config: patches, but do want to waste bandwidth expaining how wrong
+ //config: it is, you will be ignored.
+ //config:
++//config: FEATURE_WGET_OPENSSL does implement TLS verification
++//config: using the certificates available to OpenSSL.
++//config:
+ //config:config FEATURE_WGET_OPENSSL
+ //config: bool "Try to connect to HTTPS using openssl"
+ //config: default y
+@@ -115,6 +118,9 @@
+ //config: If openssl can't be executed, internal TLS code will be used
+ //config: (if you enabled it); if openssl can be executed but fails later,
+ //config: wget can't detect this, and download will fail.
++//config:
++//config: By default TLS verification is performed, unless
++//config: --no-check-certificate option is passed.
+
+ //applet:IF_WGET(APPLET(wget, BB_DIR_USR_BIN, BB_SUID_DROP))
+
+@@ -124,8 +130,11 @@
+ //usage: IF_FEATURE_WGET_LONG_OPTIONS(
+ //usage: "[-c|--continue] [--spider] [-q|--quiet] [-O|--output-document
FILE]\n"
+ //usage: " [-o|--output-file FILE] [--header 'header: value']
[-Y|--proxy on/off]\n"
++//usage: IF_FEATURE_WGET_OPENSSL(
++//usage: " [--no-check-certificate]\n"
++//usage: )
+ /* Since we ignore these opts, we don't show them in --help */
+-/* //usage:" [--no-check-certificate] [--no-cache] [--passive-ftp]
[-t TRIES]" */
++/* //usage:" [--no-cache] [--passive-ftp] [-t TRIES]" */
+ /* //usage:" [-nv] [-nc] [-nH] [-np]" */
+ //usage: " [-P DIR] [-S|--server-response] [-U|--user-agent
AGENT]" IF_FEATURE_WGET_TIMEOUT(" [-T SEC]") " URL..."
+ //usage: )
+@@ -137,7 +146,9 @@
+ //usage: "Retrieve files via HTTP or FTP\n"
+ //usage: IF_FEATURE_WGET_LONG_OPTIONS(
+ //usage: "\n --spiderOnly check URL existence: $? is 0 if
exists"
+-///: "\n --no-check-certificate Don't validate the server's
certificate"
++//usage: IF_FEATURE_WGET_OPENSSL(
++//usage: "\n --no-check-certificate Don't validate the server's
certificate"
++//usage: )
+ //usage: )
+ //usage: "\n -c Continue retrieval of aborted transfer"
+ //usage: "\n -q Quiet"
+@@ -662,7 +673,7 @@ static int spawn_https_helper_openssl(const char *host,
unsigned port)
+ pid = xvfork();
+ if (pid == 0) {
+ /* Child */
+- char *argv[8];
++ char *argv[9];
+
+ close(sp[0]);
+ xmove_fd(sp[1], 0);
+@@ -689,6 +700,9 @@ static int spawn_https_helper_openssl(const char *host,
unsigned port)
+ argv[5] = (char*)"-servername";
+ argv[6] = (char*)servername;
+ }
++ if (!(option_mask32 & WGET_OPT_NO_CHECK_CERT)) {
++ argv[7] = (char*)"-verify_return_error";
++ }
+
+ BB_EXECVP(argv[0], argv);
+ xmove_fd(3, 2);
+--
+2.7.4
+
diff --git a/meta/recipes-core/busybox/b
Re: [OE-core] [dunfell][PATCH] busybox: Security Fix For CVE-2018-1000500
Hi Armin,
As per my observation, master branch does not affect this CVE.
I could not get any reference where i find out exactly from which version
to which version, This CVE affect.
Since busybox upstarem released a patch for CVE-2018-1000500 with busybox
v1_32_0~25
and master branch is using busybox v1.32.0-r0 and I checked this patch code
is present in busybox v1.32.0-r0 source code.
so master branch does not affect.
Feel free to point out if I am wrong at any place.
*Thanks & Regards,*
Rahul Kumar
Software Engineer,Linux Solutions Engineering
Group,Montavista Software LLC
Email Id: rah...@mvista.com
<https://plus.google.com/+CodeTwoSoftware>
On Sun, Jul 12, 2020 at 8:33 AM akuster808 wrote:
>
>
> On 7/11/20 6:21 PM, Rahul Kumar wrote:
>
> CVE: CVE-2018-1000500
>
> Signed-off-by: Rahul Kumar
>
>
> Does this affect master?
>
> -armin
>
> ---
> .../busybox/busybox/busybox-CVE-2018-1000500.patch | 98
> ++
> meta/recipes-core/busybox/busybox_1.31.1.bb| 1 +
> 2 files changed, 99 insertions(+)
> create mode 100644
> meta/recipes-core/busybox/busybox/busybox-CVE-2018-1000500.patch
>
> diff --git a/meta/recipes-core/busybox/busybox/busybox-CVE-2018-1000500.patch
> b/meta/recipes-core/busybox/busybox/busybox-CVE-2018-1000500.patch
> new file mode 100644
> index 000..cde3923
> --- /dev/null
> +++ b/meta/recipes-core/busybox/busybox/busybox-CVE-2018-1000500.patch
> @@ -0,0 +1,98 @@
> +From 71e7e2fb35c806d20f9739d832cd9ae3a86fdee2 Mon Sep 17 00:00:00 2001
> +From: Dimitri John Ledkov
> +Date: Tue, 19 May 2020 18:20:39 +0100
> +Subject: [PATCH] wget: implement TLS verification with
> + ENABLE_FEATURE_WGET_OPENSSL
> +
> +When ENABLE_FEATURE_WGET_OPENSSL is enabled, correctly implement TLS
> +verification by default. And only ignore verification errors, if
> +--no-check-certificate was passed.
> +
> +Also note, that previously OPENSSL implementation did not implement
> +TLS verification, nor printed any warning messages that verification
> +was not performed.
> +
> +Bug-Ubuntu: https://bugs.launchpad.net/bugs/1879533
> +
> +CVE-2018-1000500
> +
> +Upstream Status: Backport
> https://git.busybox.net/busybox/commit/?id=45fa3f18adf57ef9d743038743d9c90573aeeb91
> +CVE: CVE-2018-1000500
> +
> +Signed-off-by: Dimitri John Ledkov
> +Signed-off-by: Denys Vlasenko
>
> +Signed-off-by: Rahul Kumar
> +---
> + networking/wget.c | 20 +---
> + 1 file changed, 17 insertions(+), 3 deletions(-)
> +
> +diff --git a/networking/wget.c b/networking/wget.c
> +index 9153264..a7e6deb 100644
> +--- a/networking/wget.c
> b/networking/wget.c
> +@@ -91,6 +91,9 @@
> + //config: patches, but do want to waste bandwidth expaining how wrong
> + //config: it is, you will be ignored.
> + //config:
> ++//config: FEATURE_WGET_OPENSSL does implement TLS verification
> ++//config: using the certificates available to OpenSSL.
> ++//config:
> + //config:config FEATURE_WGET_OPENSSL
> + //config: bool "Try to connect to HTTPS using openssl"
> + //config: default y
> +@@ -115,6 +118,9 @@
> + //config: If openssl can't be executed, internal TLS code will be used
> + //config: (if you enabled it); if openssl can be executed but fails later,
> + //config: wget can't detect this, and download will fail.
> ++//config:
> ++//config: By default TLS verification is performed, unless
> ++//config: --no-check-certificate option is passed.
> +
> + //applet:IF_WGET(APPLET(wget, BB_DIR_USR_BIN, BB_SUID_DROP))
> +
> +@@ -124,8 +130,11 @@
> + //usage:IF_FEATURE_WGET_LONG_OPTIONS(
> + //usage: "[-c|--continue] [--spider] [-q|--quiet]
> [-O|--output-document FILE]\n"
> + //usage: "[-o|--output-file FILE] [--header 'header: value']
> [-Y|--proxy on/off]\n"
> ++//usage:IF_FEATURE_WGET_OPENSSL(
> ++//usage: "[--no-check-certificate]\n"
> ++//usage:)
> + /* Since we ignore these opts, we don't show them in --help */
> +-/* //usage:"[--no-check-certificate] [--no-cache] [--passive-ftp]
> [-t TRIES]" */
> ++/* //usage:"[--no-cache] [--passive-ftp] [-t TRIES]" */
> + /* //usage:"[-nv] [-nc] [-nH] [-np]" */
> + //usage: "[-P DIR] [-S|--server-response] [-U|--user-agent
> AGENT]" IF_FEATURE_WGET_TIMEOUT(" [-T SEC]") " URL..."
> + //usage:)
> +@@ -137,7 +146,9 @@
> + //usage: "Retrieve files via HTTP or FTP\n"
> + //usage:IF_FEATURE_WGET_LONG_OPTIONS(
> + //usage: "\n--spiderOnly check URL existence: $? is 0 if
> exists"
[OE-core] [PATCH] systemd-serialgetty: Fix sed: -e expression #1, char 13: unterminated `s' command
Error Message:
| NOTE: Installed into sysroot: []
| NOTE: Skipping as already exists in sysroot: ['pseudo-native', 'glibc',
'patch-native', 'quilt-native', 'gcc-cross-arm', 'gcc-runtime',
'linux-libc-headers', 'libgcc', 'flex-native', 'xz-native', 'libtool-native',
'automake-native', 'binutils-cross-arm', 'zlib-native', 'mpfr-native',
'texinfo-dummy-native', 'autoconf-native', 'libmpc-native',
'gnu-config-native', 'gmp-native', 'attr-native', 'm4-native',
'gettext-minimal-native']
| DEBUG: Python function extend_recipe_sysroot finished
| DEBUG: Executing shell function do_install
| sed: -e expression #1, char 13: unterminated `s' command
| WARNING: exit code 1 from a shell command.
| ERROR: Execution of
'/opt/Projects/poky/build/tmp/work/qemux86_64-poky-linux/systemd-serialgetty/1.0-r5/temp/run.do_install.11228'
failed with exit code 1:
| sed: -e expression #1, char 13: unterminated `s' command
| WARNING: exit code 1 from a shell command.
|
To Fix this Issue using the strong (single quote) character in sed command.
It is recommend to use quotes. If we have meta-characters in the command,
quotes are necessary.
Signed-off-by: Rahul Kumar
---
meta/recipes-core/systemd/systemd-serialgetty.bb | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/recipes-core/systemd/systemd-serialgetty.bb
b/meta/recipes-core/systemd/systemd-serialgetty.bb
index 044c6c5b67..059fccc2b6 100644
--- a/meta/recipes-core/systemd/systemd-serialgetty.bb
+++ b/meta/recipes-core/systemd/systemd-serialgetty.bb
@@ -21,7 +21,7 @@ do_install() {
install -d ${D}${systemd_unitdir}/system/
install -d ${D}${sysconfdir}/systemd/system/getty.target.wants/
install -m 0644 ${WORKDIR}/serial-getty@.service
${D}${systemd_unitdir}/system/
- sed -i -e s/\@BAUDRATE\@/$default_baudrate/g
${D}${systemd_unitdir}/system/serial-getty@.service
+ sed -i -e 's/\@BAUDRATE\@/$default_baudrate/g'
${D}${systemd_unitdir}/system/serial-getty@.service
tmp="${SERIAL_CONSOLES}"
for entry in $tmp ; do
--
2.27.0
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#142198):
https://lists.openembedded.org/g/openembedded-core/message/142198
Mute This Topic: https://lists.openembedded.org/mt/76670752/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
[OE-core] oe-core (master branch) build failed during enable ptest
Hi,
I Created OE-Core Standalone Setup.
I am building core-image-minimal with openembedded-core (master branch) ,
bitbake (master branch) and trying to enable ptest for bzip2-ptest.
To enable ptest added below lines in local.conf
DISTRO_FEATURES_append = " ptest"
CORE_IMAGE_EXTRA_INSTALL += "bzip2-ptest"
but I am facing below error.
=
ERROR: busybox-1.31.1-r0 do_package: Error executing a python function in
exec_python_func() autogenerated:
The stack trace of python calls that resulted in this exception/failure was:
File: 'exec_python_func() autogenerated', lineno: 2, function:
0001:
*** 0002:ptest_update_alternatives(d)
0003:
File: '/opt/opensource/openembedded-core.git/meta/classes/ptest.bbclass',
lineno: 98, function: ptest_update_alternatives
0094:for alt_name, alt_link, alt_target, _ in alternatives:
0095:# Some alternatives are for man pages,
0096:# check if the alternative is in PATH
0097:if os.path.dirname(alt_link) in bin_paths:
*** 0098:os.symlink(alt_target, os.path.join(ptest_bindir,
alt_name))
0099:}
0100:
0101:do_configure_ptest_base[dirs] = "${B}"
0102:do_compile_ptest_base[dirs] = "${B}"
Exception: FileExistsError: [Errno 17] File exists: '/bin/busybox.suid' ->
'/opt/opensource/openembedded-core.git/build-master/tmp-glibc/work/core2-64-oe-linux/busybox/1.31.1-r0/package/usr/lib/busybox/ptest/bin/login'
ERROR: Logfile of failure stored in:
/opt/opensource/openembedded-core.git/build-master/tmp-glibc/work/core2-64-oe-linux/busybox/1.31.1-r0/temp/log.do_package.16217
ERROR: Task
(/opt/opensource/openembedded-core.git/meta/recipes-core/busybox/busybox_1.31.1.bb:do_package)
failed with exit code '1'
====
Can group member please provide any pointers on this issue.
*Thanks & Regards,*
Rahul Kumar
Software Engineer,Linux Solutions Engineering
Group,Montavista Software LLC
Email Id: rah...@mvista.com
<https://plus.google.com/+CodeTwoSoftware>
--
___
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
[OE-core] [PATCH] bzip2: Add test suite for bzip2
[YOCTO #13444]
Signed-off-by: Rahul Kumar
---
.../bzip2/0001-bzip2-modify-run-tests-script.patch | 220 +
meta/recipes-extended/bzip2/bzip2/Makefile.am | 2 +
meta/recipes-extended/bzip2/bzip2_1.0.8.bb | 15 +-
3 files changed, 234 insertions(+), 3 deletions(-)
create mode 100644
meta/recipes-extended/bzip2/bzip2/0001-bzip2-modify-run-tests-script.patch
diff --git
a/meta/recipes-extended/bzip2/bzip2/0001-bzip2-modify-run-tests-script.patch
b/meta/recipes-extended/bzip2/bzip2/0001-bzip2-modify-run-tests-script.patch
new file mode 100644
index 000..8ae3c4e
--- /dev/null
+++ b/meta/recipes-extended/bzip2/bzip2/0001-bzip2-modify-run-tests-script.patch
@@ -0,0 +1,220 @@
+From 42e6258485030085285d4b30854bfb94bcf43880 Mon Sep 17 00:00:00 2001
+From: Rahul Kumar
+Date: Mon, 30 Mar 2020 12:17:00 +0530
+Subject: [PATCH] bzip2: modify run-tests script
+
+Upstream-Status: Inappropriate [ modify run-tests script for ptest
infrastructure ]
+
+modify run-tests script to write PASS/FAIL as expected by the ptest
infrastructure
+
+Signed-off-by: Rahul Kumar
+---
+ run-tests.sh | 83 +++-
+ 1 file changed, 43 insertions(+), 40 deletions(-)
+
+diff --git a/run-tests.sh b/run-tests.sh
+index 1ba8c27..1eff62a 100755
+--- a/run-tests.sh
b/run-tests.sh
+@@ -10,7 +10,7 @@
+ VALGRIND="valgrind"
+ VALGRIND_ARGS="-q --error-exitcode=9"
+ BZIP2="bzip2"
+-TESTS_DIR="."
++TESTS_DIR="./bzip2-tests"
+ IGNORE_MD5=0
+
+ for i in "$@"
+@@ -40,21 +40,21 @@ case $i in
+ esac
+ done
+
+-if ! type "valgrind" > /dev/null; then
++if ! type "valgrind" > /dev/null 2>&1; then
+ VALGRIND=""
+ VALGRIND_ARGS=""
+ fi
+
+ echo "Testing ${BZIP2} in directory ${TESTS_DIR}"
+ if [ "$VALGRIND" != "" ]; then
+- echo " using valgrind"
++ echo "Using valgrind: Yes"
+ else
+- echo " NOT using valgrind"
++ echo "Using valgrind: No"
+ fi
+ if [[ ${IGNORE_MD5} -eq 0 ]]; then
+- echo " checking md5 sums"
++ echo "Checking md5 sums: Yes"
+ else
+- echo " NOT checking md5 sums"
++ echo "Checking md5 sums: No"
+ fi
+
+ # Remove any left over tesfilecopies from previous runs first.
+@@ -76,16 +76,16 @@ while IFS= read -r -d '' bzfile; do
+ echo "Processing ${bzfile}"
+
+ # Decompress it.
+- echo " Decompress..."
++ # echo " Decompress..."
+ rm -f "${file}"
+- ${VALGRIND} ${VALGRIND_ARGS} ${BZIP2} -k -d -q ${bzfile} \
+-|| { echo "!!! bad decompress result $?";
++ ${VALGRIND} ${VALGRIND_ARGS} ${BZIP2} -k -d -q ${bzfile} && { echo "PASS:
${bzfile} Decompress"; } \
++|| { echo "FAIL: ${bzfile} Decompress";
+ badtests=("${badtests[@]}" $"${bzfile} bad decompress result")
+ nogood=$[${nogood}+1]; continue; }
+
+ if [[ ${IGNORE_MD5} -ne 1 ]]; then
+-md5sum --check --status ${md5file} < ${file} \
+- || { echo "!!! md5sum doesn't match decompressed file";
++md5sum -c ${md5file} < ${file} && { echo "PASS: ${bzfile} md5sum
Matched"; } \
++ || { echo "FAIL: ${bzfile} md5sum Matched";
+badtests=("${badtests[@]}" $"${file} md5sum doesn't match")
+nogood=$[${nogood}+1]; continue; }
+ fi
+@@ -93,20 +93,20 @@ while IFS= read -r -d '' bzfile; do
+ # Compress and decompress a copy
+ mv "${file}" "${copy}"
+ rm -f "${bzcopy}"
+- echo " Recompress..."
+- ${VALGRIND} ${VALGRIND_ARGS} ${BZIP2} -z -q -s ${copy} \
+-|| { echo "!!! bad compress result $?";
++ # echo " Recompress..."
++ ${VALGRIND} ${VALGRIND_ARGS} ${BZIP2} -z -q -s ${copy} && { echo "PASS:
${bzfile} Recompress "; } \
++|| { echo "FAIL: ${bzfile} Recompress";
+ badtests=("${badtests[@]}" $"${copy} bad result")
+ nogood=$[${nogood}+1]; continue; }
+- echo " Redecompress..."
+- ${VALGRIND} ${VALGRIND_ARGS} ${BZIP2} -d -q -s ${bzcopy} \
+-|| { echo "!!! bad (re)decompress result $?";
++ # echo " Redecompress..."
++ ${VALGRIND} ${VALGRIND_ARGS} ${BZIP2} -d -q -s ${bzcopy} && { echo "PASS:
${bzfile} Redecompress"; } \
++|| { echo "FAIL: ${bzfile} Redecompress";
+ badtests=("${badtests[@]}" $"${bzcopy} bad result")
+ nogood=$[${nogood}+1]; continue; }
+
+ if [[ ${IGNORE_MD5} -ne 1 ]]; then
+-md5sum --check --status ${md5file} < ${copy} \
+- || { echo "!!! md5sum doesn't match (re)decompressed file";
++md5sum -c ${md5file} < ${co
Re: [OE-core] [PATCH] bzip2: Add test suite for bzip2
Hi Randy,
Kindly find the attached bzip2 ptest logs file.
I answered your Question here .
Kindly take a look and feel free to point out if i am wrong at any place
and let me know if i missed anything.
==
> +
> +modify run-tests script to write PASS/FAIL as expected by the ptest
infrastructure
> +
> +Signed-off-by: Rahul Kumar
> +---
> + run-tests.sh | 83
+++-
> + 1 file changed, 43 insertions(+), 40 deletions(-)
> +
> +diff --git a/run-tests.sh b/run-tests.sh
> +index 1ba8c27..1eff62a 100755
> +--- a/run-tests.sh
> b/run-tests.sh
> +@@ -10,7 +10,7 @@
> + VALGRIND="valgrind"
> + VALGRIND_ARGS="-q --error-exitcode=9"
> + BZIP2="bzip2"
> +-TESTS_DIR="."
> ++TESTS_DIR="./bzip2-tests"
Can you explain why you did this? Maybe upstream would accept it ?
Ans:
we need to parse the TEST_DIR Path because we are running runtest.sh script
outside the bzip2-tests directory.
But I figured out a more convenient way for this.
I will parse the TEST_DIR path during running the runscript.sh.
I can implement this by adding below line in makefile.am file.
./bzip2-tests/run-tests.sh --tests-dir="$(PWD)/bzip2-tests"
In Next version of patch I will implement it.
===
> + IGNORE_MD5=0
> +
> + for i in "$@"
> +@@ -40,21 +40,21 @@ case $i in
> + esac
> + done
> +
> +-if ! type "valgrind" > /dev/null; then
> ++if ! type "valgrind" > /dev/null 2>&1; then
> + VALGRIND=""
> + VALGRIND_ARGS=""
> + fi
Explanation:
if ! type "valgrind" > /dev/null;
suppose if valgrind is not present in my image at that time it is
showing
./bzip2-tests/run-tests.sh: line 43: type: valgrind: not found
Since we are displaying a message in script that valgrind is used or
not.
So i redirect the output
BY Modifying this line with "if ! type "valgrind" > /dev/null 2>&1"
==
> + echo "Testing ${BZIP2} in directory ${TESTS_DIR}"
> + if [ "$VALGRIND" != "" ]; then
> +- echo " using valgrind"
> ++ echo "Using valgrind: Yes"
> + else
> +- echo " NOT using valgrind"
> ++ echo "Using valgrind: No"
> + fi
> + if [[ ${IGNORE_MD5} -eq 0 ]]; then
> +- echo " checking md5 sums"
> ++ echo "Checking md5 sums: Yes"
> + else
> +- echo " NOT checking md5 sums"
> ++ echo "Checking md5 sums: No"
> + fi
> +
Explanation:
I Simply modified valgrind and md5sum messages with Yes/No
==
> + # Remove any left over tesfilecopies from previous runs first.
> +@@ -76,16 +76,16 @@ while IFS= read -r -d '' bzfile; do
> + echo "Processing ${bzfile}"
> +
> + # Decompress it.
> +- echo " Decompress..."
> ++ # echo " Decompress..."
Explanation:
Initially for each file It is printing Decompress...
I think which is not required to display in ptest logs so i comment it out.
==
> + if [[ ${IGNORE_MD5} -ne 1 ]]; then
> +-md5sum --check --status ${md5file} < ${file} \
> +- || { echo "!!! md5sum doesn't match decompressed file";
> ++md5sum -c ${md5file} < ${file} && { echo "PASS: ${bzfile} md5sum
Matched"; } \
> ++ || { echo "FAIL: ${bzfile} md5sum Matched";
> +badtests=("${badtests[@]}" $"${file} md5sum doesn't match")
> +nogood=$[${nogood}+1]; conti
Explanation:
for md5sum there is no short form option for --status option.
use of --status is "don't output anything, status code shows success"
md5sum -c ${md5file} < ${copy}
so i removed the --status option due to this below line is coming in ptest
log
-: OK
==
+ echo "Bad results, look for !!! in the logs above"
+ printf ' - %s\n' "${badtests[@]}"
+- exit 1
+ fi
+--
Explanation:
if some test failed then script is returning with exit 1 status due to this
at the end of ptest below message is printing
make: *** [Makefile:14: runtest] Error 1
logs wil looks like below if script returning with exit 1 status
PASS: Correctly found data integrity errors in
./bzip2-tests/lbzip2/void.bz2.bad during decompress (small)
Correctly found all bad file data integrity errors.
Bad results, look for !!! in the logs above
- ./bzip2-tests/commons-compress/zip64support.tar.bz2 bad decompress result
- ./bzip2-tests/go/regexp/re2-exhaustive.txt.bz2 bad decompress result
- ./bzip2-tests/lbzip2/idx89.bz2 bad decompress result
- ./bzip2-tests/lbzip2/ch255.bz2 bad decompress result
- ./bzip2-tests/pyflate/45MB-fb.bz2 bad decomp
Re: [OE-core] [PATCH] bzip2: Add test suite for bzip2
Hi Randy,
Thanks for your feedback.
As per your suggestion,I am working on that.
currently my patch has Upstream-Status: Inappropriate.
Since I am not aware of the patch submission process on bzip2, I posted a
query on bzip2 mailing list (2 days back) but I did not get any response
from there.
If they are not responding, in this case shall i keep Upstream-Status:
Inappropriate and send the v2 to oe-core Or should i wait for his
response?
Or
Do you have any idea how to submit the patch for bzip2-test repo.
*Thanks & Regards,*
Rahul Kumar
Software Engineer,Linux Solutions Engineering
Group,Montavista Software LLC
Email Id: rah...@mvista.com
<https://plus.google.com/+CodeTwoSoftware>
On Tue, Apr 14, 2020 at 12:48 AM Randy MacLeod
wrote:
> On 2020-04-13 1:22 p.m., Rahul Kumar wrote:
>
> Hi Randy,
>
> Kindly find the attached bzip2 ptest logs file.
>
> Hi Rahul,
>
> Most or even all of the tests that fail are due to:
>
> bzip2: No space left on device
>
> For a [de]compression utility ptest suite, it's certainly reasonable
> to add extra space to the test image:
>
> https://www.yoctoproject.org/docs/current/ref-manual/ref-manual.html#var-IMAGE_ROOTFS_EXTRA_SPACE
>
> Make note of what how much extra space is needed in your commit log since
> we don't have a way for ptests to declare this and for it to be added
> automatically.
>
> It would also be really nice to see a summary of your ptest result
> in the long log. For example in my recent update to rsyslog in meta-oe:
>1ec13d7d9 rsyslog: 8.1911.0 -> 8.2002.0
> ...
>
> On qemux86-64/kvm the ptest results with extra filesystem
> space and a timeout of 800 seconds are:
> 1911 2002
> TOTAL: 389408
> PASS:339357
> SKIP: 39 39
> XFAIL: 0 0
> FAIL: 11 12
> XPASS: 0 0
> ERROR: 0 0
>
> I probably should have listed the extra space used! oops. :)
>
> I answered your Question here .
> Kindly take a look and feel free to point out if i am wrong at any place
> and let me know if i missed anything.
> ==
> > +
> > +modify run-tests script to write PASS/FAIL as expected by the ptest
> infrastructure
> > +
> > +Signed-off-by: Rahul Kumar
> > +---
> > + run-tests.sh | 83
> +++-
> > + 1 file changed, 43 insertions(+), 40 deletions(-)
> > +
> > +diff --git a/run-tests.sh b/run-tests.sh
> > +index 1ba8c27..1eff62a 100755
> > +--- a/run-tests.sh
> > b/run-tests.sh
> > +@@ -10,7 +10,7 @@
> > + VALGRIND="valgrind"
> > + VALGRIND_ARGS="-q --error-exitcode=9"
> > + BZIP2="bzip2"
> > +-TESTS_DIR="."
> > ++TESTS_DIR="./bzip2-tests"
>
> Can you explain why you did this? Maybe upstream would accept it ?
>
> Ans:
> we need to parse the TEST_DIR Path because we are running runtest.sh
> script outside the bzip2-tests directory.
> But I figured out a more convenient way for this.
> I will parse the TEST_DIR path during running the runscript.sh.
>
> I can implement this by adding below line in makefile.am file.
> ./bzip2-tests/run-tests.sh --tests-dir="$(PWD)/bzip2-tests"
>
> Ah good.
>
>
> In Next version of patch I will implement it.
>
> ===
>
> > + IGNORE_MD5=0
> > +
> > + for i in "$@"
> > +@@ -40,21 +40,21 @@ case $i in
> > + esac
> > + done
> > +
> > +-if ! type "valgrind" > /dev/null; then
> > ++if ! type "valgrind" > /dev/null 2>&1; then
> > + VALGRIND=""
> > + VALGRIND_ARGS=""
> > + fi
>
> Explanation:
>
>if ! type "valgrind" > /dev/null;
>suppose if valgrind is not present in my image at that time it is
> showing
> ./bzip2-tests/run-tests.sh: line 43: type: valgrind: not found
>
>Since we are displaying a message in script that valgrind is used or
> not.
>
>So i redirect the output
>BY Modifying this line with "if ! type "valgrind" > /dev/null 2>&1"
>
> ==
>
> > + echo "Testing ${BZIP2} in directory ${TESTS_DIR}"
> > + if [ "$VALGRIND" != "" ]; then
> > +- echo " using valgrind"
> > ++ echo "Using valgrind: Yes"
> > + else
> > +- echo " NOT using valgrind"
> > ++ echo "Using valgrind: No"
> > + fi
> > + if [[ ${IGNORE_MD5} -eq 0 ]]; then
> > +- echo " checking md5 sums"
> > ++ echo "Checking
[OE-core] [PATCH v2] bzip2: Add test suite for bzip2
Source: git://sourceware.org/git/bzip2-tests.git
Type: Enhancement
Description:
bzip2 now has a test suite available at
git://sourceware.org/git/bzip2-tests.git.
This is a collection of "interesting" .bz2 files that can be used to
test bzip2 works correctly. They come from different projects.
Some files are deliberately bad, and are use to see how bzip2 handles
corrupt files. They are explicitly not intended to decompress correctly,
but to catch errors in bzip2 trying to deal with deliberately bad data.
All such files have a name ending in .bz2.bad.
All non-bad files end in bz2. And should come with a .md5 file for
the original input file. The .md5 file is used to check that bzip2
could correctly decompress the file. The original (non-compressed)
files are deliberately not checked in.
It will by default test with the command 'bzip2', running under
valgrind (if installed on the system).
For each .bz2 file found it is decompressed, recompressed and
decompressed again. Once with the default bzip2 settings and
once in --small (-s) mode.
For each .bz2.bad file decompression is tried twice also. In
default mode and small mode. The bzip2 binary is expected to
return either 1 or 2 as exit status. Any other exit code is
interpreted as failure.
License:
In bzip2-tests source code Each directory should contain a README
file explaining where the .bz2 files originally came from.
Plus a reference to the (Free Software) license that the project
files were distributed under.
Adding GPLv3+ License to the bzip2 recipe. Since we modify the
bzip2-tests.git/run-tests.sh script and we can redistribute it and/or
modify it under the terms of the GNU General Public License (GPL);
either version 3, or (at your option) any later version.
since all other files and directories are unchanged and We are simply
using the compressed files as data so we are ignoring the license info for
these files and directories in bzip2-tests.git
Test Summery:
On qemux86-64/kvm the ptest results with extra filesystem space (atleast
114688) are:
TOTAL: 396
PASS: 396
SKIP: 0
XFAIL: 0
FAIL: 0
XPASS: 0
ERROR: 0
All tests passed
DURATION: 517
[YOCTO #13444]
Signed-off-by: Rahul Kumar
---
.../bzip2/0001-bzip2-modify-run-tests-script.patch | 188 +
meta/recipes-extended/bzip2/bzip2/Makefile.am | 2 +
meta/recipes-extended/bzip2/bzip2_1.0.8.bb | 9 +-
3 files changed, 197 insertions(+), 2 deletions(-)
create mode 100644
meta/recipes-extended/bzip2/bzip2/0001-bzip2-modify-run-tests-script.patch
diff --git
a/meta/recipes-extended/bzip2/bzip2/0001-bzip2-modify-run-tests-script.patch
b/meta/recipes-extended/bzip2/bzip2/0001-bzip2-modify-run-tests-script.patch
new file mode 100644
index 000..900a9aa
--- /dev/null
+++ b/meta/recipes-extended/bzip2/bzip2/0001-bzip2-modify-run-tests-script.patch
@@ -0,0 +1,188 @@
+From 8e704bc7bf25f892968eac8bcb40a205248ff5b2 Mon Sep 17 00:00:00 2001
+From: Rahul Kumar
+Date: Mon, 30 Mar 2020 12:17:00 +0530
+Subject: [PATCH] bzip2: modify run-tests script
+
+1) modify run-tests script to write PASS/FAIL as expected by the ptest
infrastructure
+
+2) Since the discrete md5sum does not have a short form of --status.And
minimal base
+ images does not support commands with long form arguments so dropping this
+ argument
+
+Upstream-Status: Submitted [bzip2-de...@sourceware.org]
+- Submitted to bzip2 mailing list and waiting approval
+
+Signed-off-by: Rahul Kumar
+---
+ run-tests.sh | 62
+ 1 file changed, 33 insertions(+), 29 deletions(-)
+
+diff --git a/run-tests.sh b/run-tests.sh
+index 1ba8c27..771584d 100755
+--- a/run-tests.sh
b/run-tests.sh
+@@ -40,21 +40,21 @@ case $i in
+ esac
+ done
+
+-if ! type "valgrind" > /dev/null; then
++if ! type "valgrind" > /dev/null 2>&1; then
+ VALGRIND=""
+ VALGRIND_ARGS=""
+ fi
+
+ echo "Testing ${BZIP2} in directory ${TESTS_DIR}"
+ if [ "$VALGRIND" != "" ]; then
+- echo " using valgrind"
++ echo "Using valgrind: Yes"
+ else
+- echo " NOT using valgrind"
++ echo "Using valgrind: No"
+ fi
+ if [[ ${IGNORE_MD5} -eq 0 ]]; then
+- echo " checking md5 sums"
++ echo "Checking md5 sums: Yes"
+ else
+- echo " NOT checking md5 sums"
++ echo "Checking md5 sums: No"
+ fi
+
+ # Remove any left over tesfilecopies from previous runs first.
+@@ -78,14 +78,14 @@ while IFS= read -r -d '' bzfile; do
+ # Decompress it.
+ echo " Decompress..."
+ rm -f "${file}"
+- ${VALGRIND} ${VALGRIND_ARGS} ${BZIP2} -k -d -q ${bzfile} \
+-|| { echo "!!! bad decompress result $?";
++ ${VALGRIND} ${VALGRIND_ARGS} ${BZIP2} -k -d -q ${bzfile} && { echo "PASS:
${bzfile} Decompress"; } \
++
Re: [OE-core] [PATCH v2] bzip2: Add test suite for bzip2
Hi Richard, With this patch I am able to build core-image-minimal without any Error/Warning in my system. Can you please suggest to me, how can i reproduce this issue in my system during build? *Thanks & Regards,* Rahul Kumar Software Engineer,Linux Solutions Engineering Group,Montavista Software LLC Email Id: rah...@mvista.com <https://plus.google.com/+CodeTwoSoftware> On Mon, Apr 27, 2020 at 8:39 PM Richard Purdie < richard.pur...@linuxfoundation.org> wrote: > On Fri, 2020-04-24 at 00:09 +0530, Rahul Kumar wrote: > > Source: git://sourceware.org/git/bzip2-tests.git > > Type: Enhancement > > Description: > > bzip2 now has a test suite available at > > git://sourceware.org/git/bzip2-tests.git. > > > > This is a collection of "interesting" .bz2 files that can be used to > > test bzip2 works correctly. They come from different projects. > > > > Some files are deliberately bad, and are use to see how bzip2 handles > > corrupt files. They are explicitly not intended to decompress > > correctly, > > but to catch errors in bzip2 trying to deal with deliberately bad > > data. > > All such files have a name ending in .bz2.bad. > > > > All non-bad files end in bz2. And should come with a .md5 file for > > the original input file. The .md5 file is used to check that bzip2 > > could correctly decompress the file. The original (non-compressed) > > files are deliberately not checked in. > > > > It will by default test with the command 'bzip2', running under > > valgrind (if installed on the system). > > > > For each .bz2 file found it is decompressed, recompressed and > > decompressed again. Once with the default bzip2 settings and > > once in --small (-s) mode. > > > > For each .bz2.bad file decompression is tried twice also. In > > default mode and small mode. The bzip2 binary is expected to > > return either 1 or 2 as exit status. Any other exit code is > > interpreted as failure. > > I did try running this on the autobuilder. There are a few issues. > > https://autobuilder.yoctoproject.org/typhoon/#/builders/62/builds/1816 > step1b > <https://autobuilder.yoctoproject.org/typhoon/#/builders/62/builds/1816step1b>: > ERROR: bzip2-1.0.8-r0 do_package_qa: QA Issue: > /usr/lib/bzip2/ptest/bzip2-tests/.git/hooks/fsmonitor-watchman.sample > contained in package bzip2-ptest requires /usr/bin/perl, but no providers > found in RDEPENDS_bzip2-ptest? [file-rdeps] > step1b: ERROR: bzip2-1.0.8-r0 do_package_qa: QA run found fatal errors. > Please consider fixing them. > > also, the new license (GPLv3) causes problems: > > https://autobuilder.yoctoproject.org/typhoon/#/builders/75/builds/1814 > > Cheers, > > Richard > > > > -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#137526): https://lists.openembedded.org/g/openembedded-core/message/137526 Mute This Topic: https://lists.openembedded.org/mt/73224911/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] [PATCH v2] bzip2: Add test suite for bzip2
Hi Richard/Alexander, I am not able to understand how I can use the below file. http://git.yoctoproject.org/cgit/cgit.cgi/yocto-autobuilder-helper/tree/config.json did you mean to say that i have to set MACRO in local.conf based on this file. *Thanks & Regards,* Rahul Kumar Software Engineer,Linux Solutions Engineering Group,Montavista Software LLC Email Id: rah...@mvista.com <https://plus.google.com/+CodeTwoSoftware> On Mon, Apr 27, 2020 at 11:46 PM Richard Purdie < richard.pur...@linuxfoundation.org> wrote: > On Mon, 2020-04-27 at 18:30 +0200, Alexander Kanavin wrote: > > You need to look at configurations defined here: > > > http://git.yoctoproject.org/cgit/cgit.cgi/yocto-autobuilder-helper/tree/config.json > > and replicate them locally. Then you can reproduce the failures that > > the AB gets in those configurations. > > That start of the failing logs on the autobuilder also list out the > configuration options for that build. > > Cheers, > > Richard > > -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#137533): https://lists.openembedded.org/g/openembedded-core/message/137533 Mute This Topic: https://lists.openembedded.org/mt/73224911/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] [PATCH v2] bzip2: Add test suite for bzip2
Hi Randy,
As per your suggestion I did some progress.
Issue 1:
Configuration for this issue:
=
MACHINE = "edgerouter"
DISTRO = "poky"
SDKMACHINE = "i686"
PACKAGE_CLASSES = "package_rpm package_deb package_ipk"
INHERIT += 'image-buildinfo'
IMAGE_BUILDINFO_VARS_append = ' IMAGE_BASENAME IMAGE_NAME'
QEMU_USE_KVM = 'True'
INHERIT += 'report-error'
PREMIRRORS = ''
BB_GENERATE_MIRROR_TARBALLS = '1'
BB_NUMBER_THREADS = '16'
PARALLEL_MAKE = '-j 16'
BB_TASK_NICE_LEVEL = '5'
BB_TASK_NICE_LEVEL_task-testimage = '0'
BB_TASK_IONICE_LEVEL = '2.7'
BB_TASK_IONICE_LEVEL_task-testimage = '2.1'
INHERIT += 'testimage'
TEST_QEMUBOOT_TIMEOUT = '1500'
SANITY_TESTED_DISTROS = ''
SDK_EXT_TYPE = 'minimal'
SDK_INCLUDE_TOOLCHAIN = '1'
Command:
bitbake core-image-sato core-image-sato-dev core-image-sato-sdk
core-image-minimal core-image-minimal-dev core-image-sato-ptest
core-image-sato:do_populate_sdk -k
but could not reproduce the issue.
work-around to reproduce this issue.
I am observing since bzip2-tests is a git repo and
fsmonitor-watchman.sample (.git/hooks/fsmonitor-watchman.sample) is perl
script.
that's why I got this error.
so manually I copied fsmonitor-watchman.sample file into the
bzip2-tests/.git/hooks and able to reproduce the issue.
Error:
https://autobuilder.yoctoproject.org/typhoon/#/builders/62/builds/1816
step1b: ERROR: bzip2-1.0.8-r0 do_package_qa: QA Issue:
/usr/lib/bzip2/ptest/bzip2-tests/.git/hooks/fsmonitor-watchman.sample
contained in package bzip2-ptest requires /usr/bin/perl, but no providers
found in RDEPENDS_bzip2-ptest? [file-rdeps]
step1b: ERROR: bzip2-1.0.8-r0 do_package_qa: QA run found fatal errors.
Please consider fixing them.
I find out the solution by appending RDEPENDS_${PN}-ptest with perl.
RDEPENDS_${PN}-ptest += "make bash perl"
so this issue got resolved.
Issue2:
===
Configuration for this issue
MACHINE = "qemux86"
DISTRO = "poky"
SDKMACHINE = "i686"
PACKAGE_CLASSES = "package_rpm package_deb package_ipk"
INCOMPATIBLE_LICENSE = '*GPLv3'
WARN_QA_remove = 'incompatible-license'
QEMU_USE_KVM = 'True'
INHERIT += 'report-error'
PREMIRRORS = ''
BB_GENERATE_MIRROR_TARBALLS = '1'
BB_NUMBER_THREADS = '16'
PARALLEL_MAKE = '-j 16'
BB_TASK_NICE_LEVEL = '5'
BB_TASK_NICE_LEVEL_task-testimage = '0'
BB_TASK_IONICE_LEVEL = '2.7'
BB_TASK_IONICE_LEVEL_task-testimage = '2.1'
INHERIT += 'testimage'
TEST_QEMUBOOT_TIMEOUT = '1500'
SANITY_TESTED_DISTROS = ''
SDK_EXT_TYPE = 'minimal'
SDK_INCLUDE_TOOLCHAIN = '1'
Command
===
bitbake core-image-minimal core-image-full-cmdline -k
INCOMPATIBLE_LICENSE = '*GPLv3'
WARN_QA_remove = 'incompatible-license'
My doubt is since above configuration is using during build and we are
using GPLv3+ license then definetly it will report error.
It looks like you are packaging the test code/data with the main package
not in bzip2-ptest. Have a look at:
meta/recipes-support/libpcre/libpcre_8.44.bb
for an example. There are many more.
Also, if you look at oe-core.git:
$ rgrep LICENSE_ * | grep PN
you can see many examples of sub-packages with different licenses
than the main package. One example is:
meta/recipes-support/gnutls/gnutls_3.6.13.bb
I hope that can address the buildbot problem but I haven't tried it
myself yet.
Explanation:
I checked, Here is packaging the test code/data in bzip2-ptest.
/opt/opensource/build/tmp/work/mips64-poky-linux/bzip2/1.0.8-r0/packages-split/bzip2-ptest
I tried with the changes below in the bzip2_1.0.8.bb file.
LICENSE = "bzip2"
LICENSE_${PN}-ptest = "GPLv3+"
WARNING: LICENSE_bzip2-ptest includes licenses (GPLv3+) that are not listed
in LICENSE
To resolve this warning i did below changes.
LICENSE = "bzip2 & GPLv3+"
LICENSE_${PN}-ptest = "GPLv3+"
But I am getting below error in both case
ERROR: Nothing RPROVIDES 'bzip2' (but
/opt/opensource/poky/meta/recipes-extended/packagegroups/
packagegroup-core-full-cmdline.bb,
/opt/opensource/poky/meta/recipes-devtools/python/python3_3.8.2.bb RDEPENDS
on or otherwise requires it)
bzip2 was skipped: it has incompatible license(s): GPL-3.0+
NOTE: Runtime target 'bzip2' is unbuildable, removing...
Missing or unbuildable dependency chain was: ['bzip2']
So as per my understanding, if we are splitting the package and assigning
Licence to it.
example:
LICENSE = "
Re: [OE-core] [PATCH v2] bzip2: Add test suite for bzip2
Hi,
Can any one please help me to figure out how to deal with the GPLv3+ issue.
you can see my Patch at below link
https://patchwork.openembedded.org/patch/172134/
*Issue:*
the new license (GPLv3) causes problems:
https://autobuilder.yoctoproject.org/typhoon/#/builders/75/builds/1814
Thanks & Regards,
Rahul Kumar
Software Engineer,Linux Solutions Engineering
Group,Montavista Software LLC
Email Id: rah...@mvista.com
<https://plus.google.com/+CodeTwoSoftware>
On Wed, May 6, 2020 at 4:47 PM Rahul Kumar via lists.openembedded.org
wrote:
> Hi Randy,
>
> As per your suggestion I did some progress.
>
> Issue 1:
>
>
> Configuration for this issue:
> =
> MACHINE = "edgerouter"
> DISTRO = "poky"
> SDKMACHINE = "i686"
> PACKAGE_CLASSES = "package_rpm package_deb package_ipk"
> INHERIT += 'image-buildinfo'
> IMAGE_BUILDINFO_VARS_append = ' IMAGE_BASENAME IMAGE_NAME'
> QEMU_USE_KVM = 'True'
> INHERIT += 'report-error'
> PREMIRRORS = ''
> BB_GENERATE_MIRROR_TARBALLS = '1'
> BB_NUMBER_THREADS = '16'
> PARALLEL_MAKE = '-j 16'
> BB_TASK_NICE_LEVEL = '5'
> BB_TASK_NICE_LEVEL_task-testimage = '0'
> BB_TASK_IONICE_LEVEL = '2.7'
> BB_TASK_IONICE_LEVEL_task-testimage = '2.1'
> INHERIT += 'testimage'
> TEST_QEMUBOOT_TIMEOUT = '1500'
> SANITY_TESTED_DISTROS = ''
> SDK_EXT_TYPE = 'minimal'
> SDK_INCLUDE_TOOLCHAIN = '1'
> Command:
>
> bitbake core-image-sato core-image-sato-dev core-image-sato-sdk
> core-image-minimal core-image-minimal-dev core-image-sato-ptest
> core-image-sato:do_populate_sdk -k
>
> but could not reproduce the issue.
>
> work-around to reproduce this issue.
>
> I am observing since bzip2-tests is a git repo and
> fsmonitor-watchman.sample (.git/hooks/fsmonitor-watchman.sample) is perl
> script.
> that's why I got this error.
> so manually I copied fsmonitor-watchman.sample file into the
> bzip2-tests/.git/hooks and able to reproduce the issue.
> Error:
> https://autobuilder.yoctoproject.org/typhoon/#/builders/62/builds/1816
> step1b: ERROR: bzip2-1.0.8-r0 do_package_qa: QA Issue:
> /usr/lib/bzip2/ptest/bzip2-tests/.git/hooks/fsmonitor-watchman.sample
> contained in package bzip2-ptest requires /usr/bin/perl, but no providers
> found in RDEPENDS_bzip2-ptest? [file-rdeps]
> step1b: ERROR: bzip2-1.0.8-r0 do_package_qa: QA run found fatal errors.
> Please consider fixing them.
>
> I find out the solution by appending RDEPENDS_${PN}-ptest with perl.
> RDEPENDS_${PN}-ptest += "make bash perl"
>
> so this issue got resolved.
>
> Issue2:
> ===
> Configuration for this issue
>
> MACHINE = "qemux86"
> DISTRO = "poky"
> SDKMACHINE = "i686"
> PACKAGE_CLASSES = "package_rpm package_deb package_ipk"
> INCOMPATIBLE_LICENSE = '*GPLv3'
> WARN_QA_remove = 'incompatible-license'
> QEMU_USE_KVM = 'True'
> INHERIT += 'report-error'
> PREMIRRORS = ''
> BB_GENERATE_MIRROR_TARBALLS = '1'
> BB_NUMBER_THREADS = '16'
> PARALLEL_MAKE = '-j 16'
> BB_TASK_NICE_LEVEL = '5'
> BB_TASK_NICE_LEVEL_task-testimage = '0'
> BB_TASK_IONICE_LEVEL = '2.7'
> BB_TASK_IONICE_LEVEL_task-testimage = '2.1'
> INHERIT += 'testimage'
> TEST_QEMUBOOT_TIMEOUT = '1500'
> SANITY_TESTED_DISTROS = ''
> SDK_EXT_TYPE = 'minimal'
> SDK_INCLUDE_TOOLCHAIN = '1'
> Command
> ===
> bitbake core-image-minimal core-image-full-cmdline -k
>
>
> INCOMPATIBLE_LICENSE = '*GPLv3'
> WARN_QA_remove = 'incompatible-license'
> My doubt is since above configuration is using during build and we are
> using GPLv3+ license then definetly it will report error.
>
> It looks like you are packaging the test code/data with the main package
> not in bzip2-ptest. Have a look at:
> meta/recipes-support/libpcre/libpcre_8.44.bb
> for an example. There are many more.
> Also, if you look at oe-core.git:
> $ rgrep LICENSE_ * | grep PN
> you can see many examples of sub-packages with different licenses
> than the main package. One example is:
> meta/recipes-support/gnutls/gnutls_3.6.13.bb
> I hope that can address the buildbot problem but I haven't tried it
> myself yet.
>
> Explanation:
> I
Re: [OE-core] [PATCH v2] bzip2: Add test suite for bzip2
Hi Trevor,
It will be really helpful to me.But I don't have a Fedora system with me.
I have only Ubuntu System.
I am available on #oe IRC Channels.
*Thanks & Regards,*
Rahul Kumar
Software Engineer,Linux Solutions Engineering
Group,Montavista Software LLC
Email Id: rah...@mvista.com
<https://plus.google.com/+CodeTwoSoftware>
On Wed, May 13, 2020 at 7:58 PM Trevor Gamblin
wrote:
>
> On 5/12/20 7:22 PM, Randy MacLeod wrote:
> > On 2020-05-12 12:58 a.m., Rahul Kumar wrote:
> >> Hi,
> >>
> >> Can any one please help me to figure out how to deal with the GPLv3+
> >> issue.
> >>
> >> you can see my Patch at below link
> >> https://patchwork.openembedded.org/patch/172134/
> >>
> >> *Issue:*
> >> the new license (GPLv3) causes problems:
> >> https://autobuilder.yoctoproject.org/typhoon/#/builders/75/builds/1814
> >> *
> >> *
> >
> > Hi Rahul,
> >
> > I'm having some email problems with the oe-core list so apologies
> > if this is redundant.
> >
> > What happens if you split the license info into two parts like:
> >
> > $ grep "^LICENSE" recipes-extended/libvirt/libvirt_6.1.0.bb
> > LICENSE = "LGPLv2.1+ & GPLv2+"
> > LICENSE_${PN}-ptest = "GPLv2+ & LGPLv2.1+"
> > except of course with GPLv3.
> >
> > I might try that tomorrow on our local instance of the YP autobuilder.
> > If you'd like to set one up @ mvista, I hear from Trevor that it doesn't
> > take all that much time. As others have explained, you can also dig
> > through the yocto-autobuilder2/yocto-autobuilder-helper git repos.
>
> Hi Rahul, I can definitely help you get an autobuilder instance running
> locally, if you'd like. At the moment I'd suggest doing so on a host
> that's running Fedora, as that's where I've had the most success
> (Richard has explained to me how they run it on Ubuntu, but I haven't
> gotten it fully functional there yet).
>
> Are you on either the #yocto and/or #oe IRC channels?
>
> >
> > ../Randy
> >
> >> Thanks & Regards,
> >> Rahul Kumar
> >> Software Engineer,Linux Solutions Engineering
> >> Group,Montavista Software LLC
> >> Email Id: rah...@mvista.com <mailto:rah...@mvista.com>
> >> <https://plus.google.com/+CodeTwoSoftware>
> >>
> >>
> >> On Wed, May 6, 2020 at 4:47 PM Rahul Kumar via lists.openembedded.org
> >> <http://lists.openembedded.org>
> >> >> <mailto:mvista@lists.openembedded.org>> wrote:
> >>
> >> Hi Randy,
> >>
> >> As per your suggestion I did some progress.
> >>
> >> Issue 1:
> >>
> >>
> >> Configuration for this issue:
> >> =
> >>MACHINE = "edgerouter"
> >>DISTRO = "poky"
> >>SDKMACHINE = "i686"
> >>PACKAGE_CLASSES = "package_rpm package_deb package_ipk"
> >>INHERIT += 'image-buildinfo'
> >>IMAGE_BUILDINFO_VARS_append = ' IMAGE_BASENAME IMAGE_NAME'
> >>QEMU_USE_KVM = 'True'
> >>INHERIT += 'report-error'
> >>PREMIRRORS = ''
> >>BB_GENERATE_MIRROR_TARBALLS = '1'
> >>BB_NUMBER_THREADS = '16'
> >>PARALLEL_MAKE = '-j 16'
> >>BB_TASK_NICE_LEVEL = '5'
> >>BB_TASK_NICE_LEVEL_task-testimage = '0'
> >>BB_TASK_IONICE_LEVEL = '2.7'
> >>BB_TASK_IONICE_LEVEL_task-testimage = '2.1'
> >>INHERIT += 'testimage'
> >>TEST_QEMUBOOT_TIMEOUT = '1500'
> >>SANITY_TESTED_DISTROS = ''
> >>SDK_EXT_TYPE = 'minimal'
> >>SDK_INCLUDE_TOOLCHAIN = '1'
> >> Command:
> >>
> >> bitbake core-image-sato core-image-sato-dev core-image-sato-sdk
> >> core-image-minimal core-image-minimal-dev core-image-sato-ptest
> >> core-image-sato:do_populate_sdk -k
> >>
> >> but could not reproduce the issue.
> >>
> >> work-around to reproduce this issue.
> >>
> >> I am observing since bzip2-tests is a git repo and
> >> fsmonitor-watchman.sample (.g
[OE-core] [PATCH] neard: Switch SRC_URI to git repo
From: Rahul Kumar
The tarball (neard-0.16.tar.xz) fetched by the recipe is incomplete.
Few plugins (e.g. tizen) and tests scripts (e.g. Test-channel, test-see,
neard-ui.py, ndef-agent etc) are missing.
Since neard did not release latest tarballs, so as per community
recommendation switching the recipe SRC_URI to git repo.
Community Discussion:
https://lists.openembedded.org/g/openembedded-core/topic/90058043#163681
Signed-off-by: Rahul Kumar
---
meta/recipes-connectivity/neard/neard_0.16.bb | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/meta/recipes-connectivity/neard/neard_0.16.bb
b/meta/recipes-connectivity/neard/neard_0.16.bb
index 57f2a3e2e1..bc9ce07d79 100644
--- a/meta/recipes-connectivity/neard/neard_0.16.bb
+++ b/meta/recipes-connectivity/neard/neard_0.16.bb
@@ -2,21 +2,22 @@ SUMMARY = "Linux NFC daemon"
DESCRIPTION = "A daemon for the Linux Near Field Communication stack"
HOMEPAGE = "http://01.org/linux-nfc";
LICENSE = "GPL-2.0-only"
+LIC_FILES_CHKSUM = "file://COPYING;md5=12f884d2ae1ff87c09e5b7ccc2c4ca7e \
+
file://src/near.h;beginline=1;endline=20;md5=358e4deefef251a4761e1ffacc965d13 \
+ "
DEPENDS = "dbus glib-2.0 libnl"
-SRC_URI = "${KERNELORG_MIRROR}/linux/network/nfc/${BP}.tar.xz \
+SRC_URI =
"git://git.kernel.org/pub/scm/network/nfc/neard.git;protocol=git;branch=master \
file://neard.in \
file://Makefile.am-fix-parallel-issue.patch \
file://Makefile.am-do-not-ship-version.h.patch \
file://0001-Add-header-dependency-to-nciattach.o.patch \
"
-SRC_URI[md5sum] = "5c691fb7872856dc0d909c298bc8cb41"
-SRC_URI[sha256sum] =
"eae3b11c541a988ec11ca94b7deab01080cd5b58cfef3ced6ceac9b6e6e65b36"
-LIC_FILES_CHKSUM = "file://COPYING;md5=12f884d2ae1ff87c09e5b7ccc2c4ca7e \
- file://src/near.h;beginline=1;endline=20;md5=358e4deefef251a4761e1ffacc965d13
\
- "
+SRCREV = "949795024f7625420e93e288c56e194cb9a3e74a"
+
+S = "${WORKDIR}/git"
inherit autotools pkgconfig systemd update-rc.d
--
2.25.1
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#164869):
https://lists.openembedded.org/g/openembedded-core/message/164869
Mute This Topic: https://lists.openembedded.org/mt/90706220/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
[OE-core] [warrior][PATCH] neard: Switch SRC_URI to git repo
From: Rahul Kumar
The tarball (neard-0.16.tar.xz) fetched by the recipe is incomplete.
Few plugins (e.g. tizen) and tests scripts (e.g. Test-channel, test-see,
neard-ui.py, ndef-agent etc) are missing.
Since neard did not release latest tarballs, so as per community
recommendation switching the recipe SRC_URI to git repo.
Community Discussion:
https://lists.openembedded.org/g/openembedded-core/topic/90058043#163681
Signed-off-by: Rahul Kumar
Signed-off-by: Luca Ceresoli
Signed-off-by: Richard Purdie
(cherry-picked from b563f40ebf4461d9c35df72bd7599ea11e97da9c)
Signed-off-by: Rahul Kumar
---
meta/recipes-connectivity/neard/neard_0.16.bb | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/meta/recipes-connectivity/neard/neard_0.16.bb
b/meta/recipes-connectivity/neard/neard_0.16.bb
index cc6af4e1ca..769fda8c19 100644
--- a/meta/recipes-connectivity/neard/neard_0.16.bb
+++ b/meta/recipes-connectivity/neard/neard_0.16.bb
@@ -2,21 +2,22 @@ SUMMARY = "Linux NFC daemon"
DESCRIPTION = "A daemon for the Linux Near Field Communication stack"
HOMEPAGE = "http://01.org/linux-nfc";
LICENSE = "GPLv2"
+LIC_FILES_CHKSUM = "file://COPYING;md5=12f884d2ae1ff87c09e5b7ccc2c4ca7e \
+
file://src/near.h;beginline=1;endline=20;md5=358e4deefef251a4761e1ffacc965d13 \
+ "
DEPENDS = "dbus glib-2.0 libnl"
-SRC_URI = "${KERNELORG_MIRROR}/linux/network/nfc/${BP}.tar.xz \
+SRC_URI =
"git://git.kernel.org/pub/scm/network/nfc/neard.git;protocol=git;branch=master \
file://neard.in \
file://Makefile.am-fix-parallel-issue.patch \
file://Makefile.am-do-not-ship-version.h.patch \
file://0001-Add-header-dependency-to-nciattach.o.patch \
"
-SRC_URI[md5sum] = "5c691fb7872856dc0d909c298bc8cb41"
-SRC_URI[sha256sum] =
"eae3b11c541a988ec11ca94b7deab01080cd5b58cfef3ced6ceac9b6e6e65b36"
-LIC_FILES_CHKSUM = "file://COPYING;md5=12f884d2ae1ff87c09e5b7ccc2c4ca7e \
- file://src/near.h;beginline=1;endline=20;md5=358e4deefef251a4761e1ffacc965d13
\
- "
+SRCREV = "949795024f7625420e93e288c56e194cb9a3e74a"
+
+S = "${WORKDIR}/git"
inherit autotools pkgconfig systemd update-rc.d bluetooth
--
2.25.1
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#164987):
https://lists.openembedded.org/g/openembedded-core/message/164987
Mute This Topic: https://lists.openembedded.org/mt/90769943/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
[OE-core] [dunfell][PATCH] neard: Switch SRC_URI to git repo
From: Rahul Kumar
The tarball (neard-0.16.tar.xz) fetched by the recipe is incomplete.
Few plugins (e.g. tizen) and tests scripts (e.g. Test-channel, test-see,
neard-ui.py, ndef-agent etc) are missing.
Since neard did not release latest tarballs, so as per community
recommendation switching the recipe SRC_URI to git repo.
Community Discussion:
https://lists.openembedded.org/g/openembedded-core/topic/90058043#163681
Signed-off-by: Rahul Kumar
Signed-off-by: Luca Ceresoli
Signed-off-by: Richard Purdie
(cherry-picked from b563f40ebf4461d9c35df72bd7599ea11e97da9c)
Signed-off-by: Rahul Kumar
---
meta/recipes-connectivity/neard/neard_0.16.bb | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/meta/recipes-connectivity/neard/neard_0.16.bb
b/meta/recipes-connectivity/neard/neard_0.16.bb
index 7c124a3c0b..dd0742f792 100644
--- a/meta/recipes-connectivity/neard/neard_0.16.bb
+++ b/meta/recipes-connectivity/neard/neard_0.16.bb
@@ -2,21 +2,22 @@ SUMMARY = "Linux NFC daemon"
DESCRIPTION = "A daemon for the Linux Near Field Communication stack"
HOMEPAGE = "http://01.org/linux-nfc";
LICENSE = "GPLv2"
+LIC_FILES_CHKSUM = "file://COPYING;md5=12f884d2ae1ff87c09e5b7ccc2c4ca7e \
+
file://src/near.h;beginline=1;endline=20;md5=358e4deefef251a4761e1ffacc965d13 \
+ "
DEPENDS = "dbus glib-2.0 libnl"
-SRC_URI = "${KERNELORG_MIRROR}/linux/network/nfc/${BP}.tar.xz \
+SRC_URI =
"git://git.kernel.org/pub/scm/network/nfc/neard.git;protocol=git;branch=master \
file://neard.in \
file://Makefile.am-fix-parallel-issue.patch \
file://Makefile.am-do-not-ship-version.h.patch \
file://0001-Add-header-dependency-to-nciattach.o.patch \
"
-SRC_URI[md5sum] = "5c691fb7872856dc0d909c298bc8cb41"
-SRC_URI[sha256sum] =
"eae3b11c541a988ec11ca94b7deab01080cd5b58cfef3ced6ceac9b6e6e65b36"
-LIC_FILES_CHKSUM = "file://COPYING;md5=12f884d2ae1ff87c09e5b7ccc2c4ca7e \
- file://src/near.h;beginline=1;endline=20;md5=358e4deefef251a4761e1ffacc965d13
\
- "
+SRCREV = "949795024f7625420e93e288c56e194cb9a3e74a"
+
+S = "${WORKDIR}/git"
inherit autotools pkgconfig systemd update-rc.d
--
2.25.1
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#164994):
https://lists.openembedded.org/g/openembedded-core/message/164994
Mute This Topic: https://lists.openembedded.org/mt/90771211/21656
Group Owner: openembedded-core+ow...@lists.openembedded.org
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
[arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
[OE-core] backported "neard: Switch SRC_URI to git repo" patch from master to dunfell and warrior branch
Hi Team, I backported "neard: Switch SRC_URI to git repo" patch from master to dunfell and warrior branch. https://patchwork.yoctoproject.org/project/oe-core/patch/20220429121744.2196669-1-rahulku...@code1.emi.philips.com/ https://patchwork.yoctoproject.org/project/oe-core/patch/20220429100159.2196288-1-rahulku...@code1.emi.philips.com/ @Steve Sakoman and @Armin Kuster ,Requesting You or any community member to Review the patch. Thanks & Regards Rahul Kumar -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#165082): https://lists.openembedded.org/g/openembedded-core/message/165082 Mute This Topic: https://lists.openembedded.org/mt/90816117/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[OE-core] backported "neard: Switch SRC_URI to git repo" patch from master to dunfell and warrior branch
[Edited Message Follows] Hi Team, I backported "neard: Switch SRC_URI to git repo" patch from master to dunfell and warrior branch. https://patchwork.yoctoproject.org/project/oe-core/patch/20220429121744.2196669-1-rahulku...@code1.emi.philips.com https://patchwork.yoctoproject.org/project/oe-core/patch/20220429100159.2196288-1-rahulku...@code1.emi.philips.com @Steve Sakoman and @Armin Kuster ,Requesting You or any community member to Review the patch. Thanks & Regards Rahul Kumar -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#165082): https://lists.openembedded.org/g/openembedded-core/message/165082 Mute This Topic: https://lists.openembedded.org/mt/90816117/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[OE-core] backported "neard: Switch SRC_URI to git repo" patch from master to dunfell and warrior branch
[Edited Message Follows] Hi Team, I backported "neard: Switch SRC_URI to git repo" patch from master to dunfell and warrior branch. https://patchwork.yoctoproject.org/project/oe-core/list/?series=3910 https://patchwork.yoctoproject.org/project/oe-core/list/?series=3907 @Steve Sakoman and @Armin Kuster ,Requesting You or any community member to Review the patch. Thanks & Regards Rahul Kumar -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#165082): https://lists.openembedded.org/g/openembedded-core/message/165082 Mute This Topic: https://lists.openembedded.org/mt/90816117/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [OE-core] backported "neard: Switch SRC_URI to git repo" patch from master to dunfell and warrior branch
Thanks Steve For Quick response. Any update on Warrior branch. Or Is there any way to track the queue for warrior branch? Thanks & Regards Rahul Kumar -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#165084): https://lists.openembedded.org/g/openembedded-core/message/165084 Mute This Topic: https://lists.openembedded.org/mt/90816117/21656 Group Owner: openembedded-core+ow...@lists.openembedded.org Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
