Re: [OE-core] [PATCH v2] kernel-fitimage.bbclass: Deploy fitImage without Initramfs
Hi Vincent, Thanks, I was using the second one. The auto builder uses http://git.openembedded.org and the patches should be on top of it ? Thanks Vineeth On 03/08/2018 02:09 PM, Vincent Prince wrote: Hi Vineeth, I think it's because this class can be found in those two repos and error log tells it should be based on first one: http://git.openembedded.org/openembedded-core/tree/meta/classes/kernel-fitimage.bbclass http://git.yoctoproject.org/cgit.cgi/poky/tree/meta/classes/kernel-fitimage.bbclass Best regards, Vincent 2018-03-08 5:39 GMT+01:00 Vineeth Karumanchi <vineethchowz.chowd...@xilinx.com <mailto:vineethchowz.chowd...@xilinx.com>>: Hi, I am getting the patch failure error saying unable to apply. https://patchwork.openembedded.org/series/11297/ <https://patchwork.openembedded.org/series/11297/> I did these steps: - git clone git://git.yoctoproject.org/poky <http://git.yoctoproject.org/poky> ( master is at 83cd2b3e775235942dd4201622dc5cc2d4328994 ) - Applied this patch, it went well. Can you please let me know what is the mistake . I was sending patch on master. Thanks Vineeth On 03/08/2018 09:00 AM, Vineeth Chowdary Karumanchi wrote: This patch deploys fitImage (linux.bin + dtb ). The use case is to have 2 partioned sd card, with FAT partition having bootloader + fitImage and ext4 partion having rootfs. Signed-off-by: Vineeth Chowdary Karumanchi <vineethchowz.chowd...@xilinx.com <mailto:vineethchowz.chowd...@xilinx.com>> --- v2: Proper signed off --- meta/classes/kernel-fitimage.bbclass | 5 + 1 file changed, 5 insertions(+) diff --git a/meta/classes/kernel-fitimage.bbclass b/meta/classes/kernel-fitimage.bbclass index 50a91e1..25884d5 100644 --- a/meta/classes/kernel-fitimage.bbclass +++ b/meta/classes/kernel-fitimage.bbclass @@ -464,6 +464,10 @@ kernel_do_deploy_append() { linux_bin_base_name="fitImage-linux.bin-${PV}-${PR}-${MACHINE}-${DATETIME}" linux_bin_symlink_name=fitImage-linux.bin-${MACHINE} install -m 0644 linux.bin ${DEPLOYDIR}/${linux_bin_base_name}.bin + fitimage_base_name="fitImage-${PV}-${PR}-${MACHINE}-${DATETIME}" + fitimage_symlink_name=fitImage-${MACHINE} + install -m 0644 arch/${ARCH}/boot/fitImage ${DEPLOYDIR}/${fitimage_base_name}.bin + if [ -n "${INITRAMFS_IMAGE}" ]; then echo "Copying fit-image-${INITRAMFS_IMAGE}.its source file..." @@ -478,6 +482,7 @@ kernel_do_deploy_append() { cd ${DEPLOYDIR} ln -sf ${its_base_name}.its ${its_symlink_name}.its ln -sf ${linux_bin_base_name}.bin ${linux_bin_symlink_name}.bin + ln -sf ${fitimage_base_name}.bin ${fitimage_symlink_name}.bin if [ -n "${INITRAMFS_IMAGE}" ]; then ln -sf ${its_initramfs_base_name}.its ${its_initramfs_symlink_name}.its -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org <mailto:Openembedded-core@lists.openembedded.org> http://lists.openembedded.org/mailman/listinfo/openembedded-core <http://lists.openembedded.org/mailman/listinfo/openembedded-core> -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH] kernel-fitimage.bbclass: Deploy fitImage without Initramfs
Hi Martin, On 03/08/2018 01:25 PM, Manjukumar Harthikote Matha wrote: Hi Martin, -Original Message- From: Martin Hundebøll [mailto:m...@prevas.dk] Sent: Wednesday, March 07, 2018 11:26 PM To: Vineeth Karumanchi <vinee...@xilinx.com>; openembedded- c...@lists.openembedded.org; Manjukumar Harthikote Matha <manju...@xilinx.com> Subject: Re: [OE-core] [PATCH] kernel-fitimage.bbclass: Deploy fitImage without Initramfs Hi Vineeth, On 2018-03-07 15:41, Vineeth Chowdary Karumanchi wrote: This patch deploys fitImage (linux.bin + dtb ). The use case is to have 2 partioned sd card, with FAT partition having bootloader + fitImage and ext4 partion having rootfs. Signen-off-by: Vineeth Chowdary Karumanchi <vineethchowz.chowd...@xilinx.com> --- meta/classes/kernel-fitimage.bbclass | 5 + 1 file changed, 5 insertions(+) diff --git a/meta/classes/kernel-fitimage.bbclass b/meta/classes/kernel-fitimage.bbclass index 50a91e1..25884d5 100644 --- a/meta/classes/kernel-fitimage.bbclass +++ b/meta/classes/kernel-fitimage.bbclass @@ -464,6 +464,10 @@ kernel_do_deploy_append() { linux_bin_base_name="fitImage-linux.bin-${PV}-${PR}-${MACHINE}- ${DATETIME}" linux_bin_symlink_name=fitImage-linux.bin-${MACHINE} install -m 0644 linux.bin ${DEPLOYDIR}/${linux_bin_base_name}.bin + fitimage_base_name="fitImage-${PV}-${PR}-${MACHINE}- ${DATETIME}" + fitimage_symlink_name=fitImage-${MACHINE} + install -m 0644 arch/${ARCH}/boot/fitImage + ${DEPLOYDIR}/${fitimage_base_name}.bin + Isn't this already handled by the "linux_bin_base_name" variable just above (i.e. fitImahe-linux.bin-${MACHINE}). It is linux.bin which is generated at the time of fitImage creation. - linux.bin and arch/${ARCH}/boot/fitImage differ, - uboot fails to recognise linux.bin - arch/${ARCH}/boot/fitImage is the fitimage. Thanks VIneeth I have various fitimages, and as far as I recall, a non-initramfs fitimage is already deployed. This patch seems to do the right thing. linux.bin is being copied as fitImage-linux.bin-${MACHINE} , and I think it is incorrect. It should be fitImage, which is generated in do_assemble_fitimage If you look at initramfs case: install -m 0644 arch/${ARCH}/boot/fitImage-${INITRAMFS_IMAGE} ${DEPLOYDIR}/${fit_initramfs_base_name}.bin which is correct Thanks, Manju -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH v2] kernel-fitimage.bbclass: Deploy fitImage without Initramfs
Hi, I am getting the patch failure error saying unable to apply. https://patchwork.openembedded.org/series/11297/ I did these steps: - git clone git://git.yoctoproject.org/poky ( master is at 83cd2b3e775235942dd4201622dc5cc2d4328994 ) - Applied this patch, it went well. Can you please let me know what is the mistake . I was sending patch on master. Thanks Vineeth On 03/08/2018 09:00 AM, Vineeth Chowdary Karumanchi wrote: This patch deploys fitImage (linux.bin + dtb ). The use case is to have 2 partioned sd card, with FAT partition having bootloader + fitImage and ext4 partion having rootfs. Signed-off-by: Vineeth Chowdary Karumanchi--- v2: Proper signed off --- meta/classes/kernel-fitimage.bbclass | 5 + 1 file changed, 5 insertions(+) diff --git a/meta/classes/kernel-fitimage.bbclass b/meta/classes/kernel-fitimage.bbclass index 50a91e1..25884d5 100644 --- a/meta/classes/kernel-fitimage.bbclass +++ b/meta/classes/kernel-fitimage.bbclass @@ -464,6 +464,10 @@ kernel_do_deploy_append() { linux_bin_base_name="fitImage-linux.bin-${PV}-${PR}-${MACHINE}-${DATETIME}" linux_bin_symlink_name=fitImage-linux.bin-${MACHINE} install -m 0644 linux.bin ${DEPLOYDIR}/${linux_bin_base_name}.bin + fitimage_base_name="fitImage-${PV}-${PR}-${MACHINE}-${DATETIME}" + fitimage_symlink_name=fitImage-${MACHINE} + install -m 0644 arch/${ARCH}/boot/fitImage ${DEPLOYDIR}/${fitimage_base_name}.bin + if [ -n "${INITRAMFS_IMAGE}" ]; then echo "Copying fit-image-${INITRAMFS_IMAGE}.its source file..." @@ -478,6 +482,7 @@ kernel_do_deploy_append() { cd ${DEPLOYDIR} ln -sf ${its_base_name}.its ${its_symlink_name}.its ln -sf ${linux_bin_base_name}.bin ${linux_bin_symlink_name}.bin + ln -sf ${fitimage_base_name}.bin ${fitimage_symlink_name}.bin if [ -n "${INITRAMFS_IMAGE}" ]; then ln -sf ${its_initramfs_base_name}.its ${its_initramfs_symlink_name}.its -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Re: [OE-core] [PATCH] kernel-fitimage.bbclass: Fix 64 bit ENTRYPOINT
Hi Ross, On 2/8/2018 3:45 PM, Burton, Ross wrote: On 8 February 2018 at 06:29, Vineeth Chowdary Karumanchi> wrote: 64 bit entry point should be passed in 2 literals ( "0x1 0x8000" ).ENTRYPOINT is assigned with first half only and erroring out as 'command not found' for the second half. Adding quotes while assignment fixes the issue. Does this mean that this expression below is broken too? if [ -n "${UBOOT_ENTRYSYMBOL}" ]; then ENTRYPOINT=`${HOST_PREFIX}nm vmlinux | \ awk '$3=="${UBOOT_ENTRYSYMBOL}" {print "0x"$1;exit}'` It will pass here as the return value is full 64 bit, but fails at mkimage utility. The return value has to be splitted into 2 literals if it is more than 32 bit wide. Thanks Vineeth Ross -- ___ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core